From unknown Tue Jun 24 15:44:02 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5724: 23.1.94; ido bug in next match Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Mar 2010 16:49:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: report 5724 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: storm@cua.dk, 5724@debbugs.gnu.org X-Debbugs-Original-To: storm@cua.dk, bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.126867171123641 (code B ref -1); Mon, 15 Mar 2010 16:49:02 +0000 Received: (at submit) by debbugs.gnu.org; 15 Mar 2010 16:48:31 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NrDSw-00069G-MW for submit@debbugs.gnu.org; Mon, 15 Mar 2010 12:48:30 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NrDSu-00069B-N9 for submit@debbugs.gnu.org; Mon, 15 Mar 2010 12:48:29 -0400 Received: from lists.gnu.org ([199.232.76.165]:41430) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NrDSp-0004Dt-V0 for submit@debbugs.gnu.org; Mon, 15 Mar 2010 12:48:24 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NrDSp-0004BQ-LW for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2010 12:48:23 -0400 Received: from [140.186.70.92] (port=44824 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NrDSo-00049T-9F for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2010 12:48:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_MIME_NO_TEXT, T_RP_MATCHES_RCVD, T_TO_NO_BRKTS_FREEMAIL, T_TVD_MIME_NO_HEADERS autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NrDSm-0007MB-F9 for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2010 12:48:22 -0400 Received: from ppsw-0.csi.cam.ac.uk ([131.111.8.130]:37748) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NrDSm-0007M1-5D for bug-gnu-emacs@gnu.org; Mon, 15 Mar 2010 12:48:20 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from wlan-gw.st-edmunds.cam.ac.uk ([131.111.223.101]:49444 helo=Victoria.local) by ppsw-0.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.150]:587) with esmtpsa (PLAIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1NrDSk-00025w-36 (Exim 4.70) (return-path ); Mon, 15 Mar 2010 16:48:19 +0000 From: Leo Date: Mon, 15 Mar 2010 16:48:18 +0000 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.6 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) --=-=-= In ido mode, C-s rotate the matches. The following steps exhibits a delicate bug which seemingly causes the matches to re-order. 1. Emacs -q -l long-list.el (attached) take a look at the first 4 matches in the minibuffer 2. C-s Normally you expect C-s to get you one step closer to the fourth item but it just pushes it one step further in this case. This is also reproducible with the ido.el included in Emacs 22. It may have something to do with prefix-matches, matches, suffix-mathes in ido-set-matches-1. BTW, in my local copy of ido.el I have integrated recentf into it so ido automatically pulls in visited files when switching buffers and the user input does not match any. I have a long recentf-list. --=-=-= Content-Type: application/emacs-lisp Content-Disposition: attachment; filename=long-list.el Content-Transfer-Encoding: quoted-printable Content-Description: long-list.el (setq mylist '("ido.el" "emacs23/src/sysdep.c" "leo/model/README" "emacs23/= src/process.c" "init" "README-ido" "recentf" "mach_init.h" "custom" "ido.or= g" "memoir.cls" "alloc.c" "exclude" "config" "git.org" "sysctl.h" "proc.h" = "proc_info.c" "proc_info.h" "fixes.el" "MFE.org" "leothesis.org" "leo.org" = "Maybe.org" "Tasks.org" "site.el" "lisp-irc.doc" "chap3.tex" "thesis.tex" "= emacs23/config.status" "emacs23/src/eval.c" "task.c" "pgrp.c" "faults.c" "c= sw.c" "cpu.c" "sys/errno.h" "include/errno.h" "keyboard.c" "callint.c" "ema= cs23/src/bytecode.c" "libtop.h" "thread_info.h" "kernel_types.h" "libtop.c"= "emacs-23.1.93/src/sysdep.c" "emacs23/Makefile" "bbc.gpg" "OSTypes.h" "ema= cs23/src/config.h" "emacs23/src/TAGS" "README-mac" "org.el" "org.diff" "ref= tex-toc.el" "Reference" "bookmarks" ".dir-locals.el" "sources/emacs23/READM= E" "emacs23/INSTALL" "emacs-23.1.93/src/config.h" "systime.h" "emacs-23.1.9= 3/src/TAGS" "c10.c" "MacTypes.h" "DriverServices.h" "clock_types.h" "Compon= ents.k.h" "CoreServices.h" "Users/phd/clock.h" "sys/time.h" "include/mach/c= lock.h" "time_value.h" "clock_reply.h" "clock_priv.h" "timer.c" "clock.c" "= Headers/kern/clock.h" "task_info.h" "bsd_kern.c" "proc.c" "emacs-23.1.93/sr= c/bytecode.c" "emacs-23.1.93/src/eval.c" "emacs-23.1.93/src/process.c" "lib= proc.h" "dproc.c" "gnus" "processor.h" "kern/task.h" "Headers/mach/clock.h"= "mach_traps.h" "mach_time.h" "test4.c" "test3.c" "test2.c" "test.c" "ms.or= g.gpg" "calc-histogram.el" "siunitx.sty" "if.h" "kern_control.h" "un.h" "st= at.h" "types.h" "param.h" "ucred.h" "vm.h" "resource.h" "audit.h" "film.org= .gpg" "machine.h" "host_info.h" "task_policy.h" "sched.h" "test8.c" "host_s= pecial_ports.h" "x86_64/task.h" "mach/task.h" "mach_syscalls.h" "mach_param= .h" "mach.h" "deprecated.lisp" "mac.diff" "host_priv.h" "_endian.h" "etc/TO= DO" "xsteve.el" "sys/_structs.h" "timeb.h" "times.h" "include/time.h" "cdef= s.h" "test7.c" "vmmeter.h" "include/_structs.h" "timeconv.h" "utime.h" "thr= ead_status.h" "task_access.defs" "task_ledger.h" "task_special_ports.h" "ta= sk.defs" "thread_act.h" "vm_map.h" "contrib/ChangeLog" "slime/ChangeLog" "m= essage.h" "mach_types.h" "mach_host.h" "mach_vm.h" "wait.h" "resourcevar.h"= "kern_memorystatus.h" "ev.h" "buf.h" "attr.h" "Processes.h" "appleapiopts.= h" "queue.h" "boolean.h" "event.h" "test6.c" "kk.c" "vmparam.h" "test5.c" "= .CFUserTextEncoding" "vproc.h" "proc2.c" "MoreProcesses.h" "MoreProcesses.c= p" ".authinfo.gpg" "magit.el" "Emacs_2010-03-08-115648_Victoria.crash" "kil= l-ring-browse.el" "steady-state.lisp" "Create New Mailing List Mailbox.scpt= " "clos.tex" "swank.lisp" "scores" "history" "leothesis.cls" "download.txt"= "solver.lisp" "loop.lisp" "leo/TODO" "swank.diff" "swank-sbcl.lisp" "swank= -ccl.lisp" "swank-backend.lisp" "lib/macros.lisp" "cache" "emms/Makefile" "= lisp/Makefile" "gst-wrapper" "RELEASE" "sources/emms/README" "NEWS" "FAQ" "= .ccl-init.lisp" "oac.el" "_rev.tex" "emacsbook.tex" "emacs4latex.tex" "prac= journ.cls" "tests/roots-multi.lisp" "solve-minimize-fit/roots-multi.lisp" "= cn.el" "macros4me.el" "tex4me.el" "ns.el" "tramp" "alarm.el" "MacBook.org" = "sources/elim/README" "elim/Makefile" "convert.lisp" "ffi.lisp" "version.li= sp-expr" "device.lisp" "sch.tex" "prelim2e.sty" "t1pfu.fd" "cn" "lock.lisp"= "clnotes.cls" "general.tex" "ncl.tex" "cn-128k.m3u" "l0-float.lisp" "gamma= .lisp" "with-unique-names.lisp" "compose.lisp" "COPYRIGHT" "HEADER" "babel_= 0.3.0/NOTES" "AppleScript.org" "00Photonics.bib" "chap2.tex" "chap4.tex" "c= olophon.tex" "chap7.tex" "chap6.tex" "chap5.tex" "chap1.tex" "publications.= tex" "acknowledge.tex" "abstract.tex" "declaration.tex" "titlepage.tex" "cs= quotes.sty" "glossaries.sty" "hyperref.sty" "pgfplots/ChangeLog" "pgf/Chang= eLog" "biblatex.sty" "amsmath.sty" "numbers.lisp" "model/packages.lisp" "qd= soa.asd" "onlisp.lisp" "beamer-notes.tex" "futura.sty" "qdsoa-test.lisp" "m= odel/plot.lisp" "Map_IssX.txt" "Map_Sym.txt" "Map_IssW.txt" "normal.lisp" "= ode-example.lisp" "=E4=BB=A5=E7=88=B6=E4=B9=8B=E5=90=8D.lrc" "=E7=BE=8E=E4= =B8=BD=E7=9A=84=E7=A5=9E=E8=AF=9D.lrc" "sysutils.lisp" "cairo-1.9.6/INSTALL= " "libffi-unix.lisp" "time-domain.lisp" "common.lisp" "auctex.diff" "gtd.or= g" "Notes.org" "ode-system.lisp" "swank-arglists.lisp" "swank-fancy-inspect= or.lisp" "swank-indentation.lisp" "swank-hyperdoc.lisp" "swank-motd.lisp" "= xref.lisp" "metering.lisp" "maref.lisp" "marray.lisp" "callback-included.li= sp" "scheme-paean.txt" "release-notes.txt" "l0-cfm-support.lisp" "libffi-un= ix.c" "level-2.lisp" "defmfun.lisp" "minimization-multi.lisp" "api.lisp" "l= 0-misc.lisp" "swank.rb" "swank.asd" "swank-source-path-parser.lisp" "swank-= source-file-cache.lisp" "swank-loader.lisp" "defsystem.lisp" "asdf.lisp" "q= dsoa-test.asd" "x04c.c" "x02c.c" "surface-plot.lisp" "window/plot.lisp" "cl= asses.lisp" "x-y-plot.lisp" "x17c.c" "examples/CMakeLists.txt" "defcfun.lis= p" "misc.lisp" "system-examples.lisp" "english.tex" "diode-lasers.tex" "Jou= rnal.org" "Emacs.org" "stepping.lisp" "foreign-array.lisp" "ode.lisp" "swan= k-allegro.lisp" "swank-rpc.lisp" "swank-gray.lisp" "sbcl-pprint-patch.lisp"= "PROBLEMS" "evolution.lisp" "both.lisp" "array-tests.lisp" "matrix.lisp" "= vector.lisp" "c/Makefile" "nonlinear.c" "monte-carlo.lisp" "test/packages.l= isp" "lisp-unit.lisp" "floating-point.lisp" "monte-carlo-test.lisp" "test.l= isp" "qrng-test.lisp" "cl-qrng-test.asd" "package.fasl" "sobol.lisp" "contr= ol.lisp" "l1-clos.lisp" "multimediasymbols.sty" "l1-utils.lisp" "window.lis= p" "3D-window.lisp" "color-table.lisp" "axis.lisp" "package.lisp" "slime.te= x" "window/macros.lisp" "l1-aprims.lisp" "lingo.tex" "PRBS.HTM" "MAKEPRI" "= LINUX.TXT" "beamerouterthemelogosidebar.sty" "geometry.sty" "Publications.b= ib" "etoolbox.sty" "Business.org" "TWLM.h" "TWLM.cpp" "numerical-sop.tex" "= nx0.lisp" "loadlib.lisp" "cmap1_blue_yellow.pal" "cmap0_white_bg.pal" "cmap= 0_default.pal" "window-examples.lisp" "mathematical.lisp" "Tasks.org_archiv= e" "macros.sty" "uffi.asd" "cffi-uffi-compat.asd" "uffi-compat.lisp" "doc/M= akefile" "lisp.bib" "sn.txt" "agenda" "MFE.org_archive" "leo.org_archive" "= GU.org" "mhchem.sty" "mlist.sty" "varioref.sty" "microtype.sty" "enumitem.s= ty" ".gitconfig" ".gitignore" "jmt.lisp" "l1-files.lisp" "l0-numbers.lisp" = "cairo.c" "aqt.c" "sources/pango-1.26.2/README" "pango-1.26.2/INSTALL" "lib= iconv-1.13.1/NOTES" "acglib.m4" "aclocal.m4" "configure.in" "sources/gettex= t-0.17/README" "gettext-0.17/INSTALL" "glib-2.22.4/INSTALL" "load-asdf-inst= all.lisp" "variables.lisp" "installer.lisp" "defpackage.lisp" "split-sequen= ce.lisp" "port.lisp" "loader.lisp" "lift-standard.config" "digitool.lisp" "= dead-letter.lisp" "conditions.lisp" "asdf-install.asd" "letter-scrlttr2.tex= " "beamerexample-conference-talk.tex" "mathptmx.sty" "beamerbasefont.sty" "= beamer.cls" "beamerouterthemesidebar.sty" "beamer-cn.tex" "fad.lisp" "l1-pa= thnames.lisp" "demo.conf" "trivial-configuration-parser.lisp" "fft.lisp" "b= las1.lisp" "beamerthemeBerkeley.sty" "beamercolorthemealbatross.sty" "beame= rcolorthemelily.sty" "beamercolorthemestructure.sty" "beamercolorthemewhale= .sty" "beamercolorthemeorchid.sty" "pgfbaseimage.sty" "latex-beamer/INSTALL= " "beamercolorthemeexample.tex" "multimedia.sty" "AUTHORS" "FILES" "sources= /latex-beamer/README" "Copyright" "plplot/CMakeLists.txt" "plplot/INSTALL" = "sources/plplot/README" "utility-functions.lisp" "prepare-mcl-environment.l= isp" "pmcl-kernel.c" "AQTAdapter.h" "cairo-version.h" "cairo.h" "NSString.h= " "gd.h" "NSObject.h" "pgf/INSTALL" "generic/pgf/README" "sources/pgf/READM= E" ".bash_profile" "profile" "bashrc" "contour-plot.lisp" "mac-unicode-debu= g-2.8" "ccl-32.diff" "monte-carlo-structs.lisp" "ccl-64.diff" "sequences.li= sp" "gsl-1.13/config.status" "fontenc.sty" "ae.sty" "lmodern.sty")) (ido-mode) (ido-completing-read "Test: " mylist nil nil "sou") --=-=-= In GNU Emacs 23.1.94.1 (x86_64-apple-darwin10.2.0, Carbon Version 1.6.0 AppKit 1038.25) of 2010-03-14 on Victoria.local Windowing system distributor `Apple Inc.', version 10.6.2 configured using `configure '--prefix=/usr/local/unix/emacs' '--with-mac' 'CFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: iso-latin-1-unix default enable-multibyte-characters: t --=-=-=-- From unknown Tue Jun 24 15:44:02 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5724: 23.1.94; ido bug in next match References: In-Reply-To: Resent-From: Christian Dietrich Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Mar 2010 12:07:03 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5724 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5724 <5724@debbugs.gnu.org> Received: via spool by 5724-submit@debbugs.gnu.org id=B5724.126960521515177 (code B ref 5724); Fri, 26 Mar 2010 12:07:03 +0000 Received: (at 5724) by debbugs.gnu.org; 26 Mar 2010 12:06:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nv8JS-0003wj-Lx for submit@debbugs.gnu.org; Fri, 26 Mar 2010 08:06:55 -0400 Received: from peer.zerties.org ([188.40.33.175]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nv61U-0002Oz-6E for 5724@debbugs.gnu.org; Fri, 26 Mar 2010 05:40:12 -0400 Received: from stettberger by peer.zerties.org with local (Exim 4.69) (envelope-from ) id 1Nv61Q-000658-Jp for 5724@debbugs.gnu.org; Fri, 26 Mar 2010 10:40:08 +0100 Content-Type: text/plain; charset=UTF-8 From: Christian Dietrich Date: Fri, 26 Mar 2010 10:40:08 +0100 Message-Id: <1269596170-sup-9737@peer.zerties.org> User-Agent: Sup/git Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Mailman-Approved-At: Fri, 26 Mar 2010 08:06:53 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.3 (-) Hi, i can reproduce your bug here with emacs 23.1, and i tried to track down the problem. But as far as i can see the reordering of the match results isn't done by ido-set-matches-1. The position of the matches items in ido-cur-list and in the result of ido-set-matches-1 is the same. Think of (remove-if '(lambda (x) (not (member x after-match)) before-match) So i assume that the Problem isn't at that place. greetz didi -- No documentation is better than bad documentation -- Das Ausdrucken dieser Mail wird urheberrechtlich verfolgt. From unknown Tue Jun 24 15:44:02 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5724: 23.1.94; ido bug in next match Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Mar 2010 10:44:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5724 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Christian Dietrich Cc: 5724 <5724@debbugs.gnu.org> Received: via spool by 5724-submit@debbugs.gnu.org id=B5724.12696866052114 (code B ref 5724); Sat, 27 Mar 2010 10:44:01 +0000 Received: (at 5724) by debbugs.gnu.org; 27 Mar 2010 10:43:25 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvTUC-0000Y3-TF for submit@debbugs.gnu.org; Sat, 27 Mar 2010 06:43:25 -0400 Received: from ppsw-1.csi.cam.ac.uk ([131.111.8.131]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvTUA-0000Xx-PT for 5724@debbugs.gnu.org; Sat, 27 Mar 2010 06:43:23 -0400 X-Cam-AntiVirus: no malware found X-Cam-SpamDetails: not scanned X-Cam-ScannerInfo: http://www.cam.ac.uk/cs/email/scanner/ Received: from smaug.linux.pwf.cam.ac.uk ([193.60.95.72]:37415) by ppsw-1.csi.cam.ac.uk (smtp.hermes.cam.ac.uk [131.111.8.151]:587) with esmtpsa (LOGIN:sl392) (TLSv1:DHE-RSA-AES128-SHA:128) id 1NvTU5-0002Yb-3h (Exim 4.70) (return-path ); Sat, 27 Mar 2010 10:43:17 +0000 From: Leo References: <1269596170-sup-9737@peer.zerties.org> Date: Sat, 27 Mar 2010 10:43:16 +0000 In-Reply-To: <1269596170-sup-9737@peer.zerties.org> (Christian Dietrich's message of "Fri, 26 Mar 2010 10:40:08 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) --=-=-= On 2010-03-26 09:40 +0000, Christian Dietrich wrote: > Hi, > i can reproduce your bug here with emacs 23.1, and i tried to track > down the problem. But as far as i can see the reordering of the > match results isn't done by ido-set-matches-1. The position of the > matches items in ido-cur-list and in the result of ido-set-matches-1 > is the same. Think of > > (remove-if '(lambda (x) (not (member x after-match)) before-match) > > So i assume that the Problem isn't at that place. > > greetz didi I think I have located the problem. ido-set-matches is called with different args when C-s so it returns different matches. I couldn't understand why it is designed this way. I am surprised no one has been annoyed by this bug. It has caused me to choose the wrong match quite often. I have attempted a fix by simply rotating the ido-matches when rotating. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=ido.diff Content-Description: ido.diff diff --git a/lisp/ido.el b/lisp/ido.el index e414408..803fa74 100644 --- a/lisp/ido.el +++ b/lisp/ido.el @@ -3145,20 +3145,18 @@ If repeated, insert text from buffer instead." (defun ido-next-match () "Put first element of `ido-matches' at the end of the list." (interactive) - (if ido-matches - (let ((next (cadr ido-matches))) - (setq ido-cur-list (ido-chop ido-cur-list next)) - (setq ido-rescan t) - (setq ido-rotate t)))) + (when ido-matches + (setq ido-matches + (ido-chop ido-matches (cadr ido-matches))) + (setq ido-rotate t))) (defun ido-prev-match () "Put last element of `ido-matches' at the front of the list." (interactive) - (if ido-matches - (let ((prev (car (last ido-matches)))) - (setq ido-cur-list (ido-chop ido-cur-list prev)) - (setq ido-rescan t) - (setq ido-rotate t)))) + (when ido-matches + (setq ido-matches + (ido-chop ido-matches (car (last ido-matches)))) + (setq ido-rotate t))) (defun ido-next-match-dir () "Find next directory in match list. @@ -3177,7 +3175,8 @@ first matching file." (while (and (< i cnt) (not (ido-final-slash (nth i ido-matches)))) (setq i (1+ i))) (if (< i cnt) - (setq ido-cur-list (ido-chop ido-cur-list (nth i ido-matches))))))) + (setq ido-matches (ido-chop ido-matches (nth i ido-matches)) + ido-rotate t))))) (defun ido-prev-match-dir () "Find previous directory in match list. @@ -3196,7 +3195,8 @@ for first matching file." (while (and (> i 0) (not (ido-final-slash (nth i ido-matches)))) (setq i (1- i))) (if (> i 0) - (setq ido-cur-list (ido-chop ido-cur-list (nth i ido-matches))))))) + (setq ido-matches (ido-chop ido-matches (nth i ido-matches)) + ido-rotate t))))) (defun ido-restrict-to-matches () "Set current item list to the currently matched items." @@ -4494,8 +4494,10 @@ For details of keybindings, see `ido-find-file'." ;; Update the list of matches (setq ido-text contents) - (ido-set-matches) - (ido-trace "new " ido-matches) + (if ido-rotate + (setq ido-rotate nil) + (ido-set-matches) + (ido-trace "new " ido-matches)) (when (and ido-enter-matching-directory ido-matches --=-=-= Cheers, Leo --=-=-=-- From unknown Tue Jun 24 15:44:02 2025 X-Loop: help-debbugs@gnu.org Subject: bug#5724: 23.1.94; ido bug in next match References: In-Reply-To: Resent-From: Leo Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Feb 2011 17:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5724 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5724@debbugs.gnu.org Received: via spool by 5724-submit@debbugs.gnu.org id=B5724.129675289513717 (code B ref 5724); Thu, 03 Feb 2011 17:09:02 +0000 Received: (at 5724) by debbugs.gnu.org; 3 Feb 2011 17:08:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pl2fH-0003ZC-CF for submit@debbugs.gnu.org; Thu, 03 Feb 2011 12:08:15 -0500 Received: from mail-gx0-f172.google.com ([209.85.161.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pl2fF-0003Yy-G3 for 5724@debbugs.gnu.org; Thu, 03 Feb 2011 12:08:14 -0500 Received: by gxk27 with SMTP id 27so617192gxk.3 for <5724@debbugs.gnu.org>; Thu, 03 Feb 2011 09:16:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:date:message-id:user-agent :mime-version:content-type; bh=TsjUTIgOyftgYQ1752v94IxMkjfXWfY/12GVw33v9d4=; b=q5m3lBPZ6KpxRqqhXJQrpL85UYvW4i9kEm0ov5OAM2pBAATWnFElT3vKjkma1PfIXy FaDdVjmOGSg7EuBNrq9he8CRoGhHkiFhl8gDVHn5O6MZLWgDaMcUeg6+PWJR9no6Ibdu sVQ4Odr/3wAAMveS3fnCG8H7Do1Sa+RzrBqMY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; b=hvlPs8maAnc04IBSBtfhOl4IVLXIAr68jH0eovoq3XF07ws2oTD32xAlC79oKbDeLq Fdg4yTRMvnYAzA/oHv9ndDhMtbu8IQgXC95z159JYXRNMhIUMsElQ2DNJZocGAISCKyA 617n8CkUjA7dKF8qeZQ0F7hToFYvATUyi4MjE= Received: by 10.236.108.145 with SMTP id q17mr5542595yhg.70.1296753401894; Thu, 03 Feb 2011 09:16:41 -0800 (PST) Received: from Victoria.local ([222.79.248.63]) by mx.google.com with ESMTPS id z33sm613977yhc.42.2011.02.03.09.16.38 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 03 Feb 2011 09:16:41 -0800 (PST) From: Leo Date: Fri, 04 Feb 2011 01:16:29 +0800 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2.93 (Mac OS X 10.6.6) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) This bug seems to be fixed in: http://repo.or.cz/w/emacs.git/commitdiff/7c481af3e2b7dc3a530c7e0d9c61b0721aadbd1d "(ido-next-match, ido-prev-match): Fix stray reordering of matching items when cycling through the matches." Leo -- Oracle is the new evil From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 11 20:24:33 2011 Received: (at control) by debbugs.gnu.org; 12 Feb 2011 01:24:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Po4Dx-0006x5-4s for submit@debbugs.gnu.org; Fri, 11 Feb 2011 20:24:33 -0500 Received: from vm-emlprdomr-04.its.yale.edu ([130.132.50.145]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Po4Dv-0006wu-Ig for control@debbugs.gnu.org; Fri, 11 Feb 2011 20:24:31 -0500 Received: from furball (dhcp128036014062.central.yale.edu [128.36.14.62]) (authenticated bits=0) by vm-emlprdomr-04.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1C1XMKS016719 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Fri, 11 Feb 2011 20:33:22 -0500 Received: by furball (Postfix, from userid 1000) id A368A16055E; Fri, 11 Feb 2011 20:33:20 -0500 (EST) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 5724 Date: Fri, 11 Feb 2011 20:33:20 -0500 Message-ID: <871v3eox3z.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.145 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 5724 thanks