From unknown Mon Aug 18 20:14:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57219: 29.0.50; [PATCH] Fix gcc warning in coding.c Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Aug 2022 23:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 57219@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1660521500304 (code B ref -1); Sun, 14 Aug 2022 23:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Aug 2022 23:58:20 +0000 Received: from localhost ([127.0.0.1]:40063 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNNUq-0008WU-HX for submit@debbugs.gnu.org; Sun, 14 Aug 2022 19:58:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:49190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNNUo-0008WL-0u for submit@debbugs.gnu.org; Sun, 14 Aug 2022 19:58:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNNUn-0006K0-Pi for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 19:58:17 -0400 Received: from relay12.mail.gandi.net ([2001:4b98:dc4:8::232]:57907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNNUl-0004lT-AE for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 19:58:17 -0400 Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 6759D200002 for ; Sun, 14 Aug 2022 23:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1660521491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=RvPeInDHAGEzVv0Vi0coG4wYrPMqglDyT+oAdUnGXUw=; b=ANWfdsuLF/6OXZ2GpGoEkEBbmt9JwJWuKMWwd+3uNcB1KZRMBSoFZ0kf6Rzb4bxKfltWxQ pcU38Uml4DYkOq8BoinT34mdfFhP97D/3lnPBJGsAFDyZRIpBXHR22DAlfgkz3cz347vfy 4OPTgKdxsC9soHq8Bl292lulxVNPydP3LVjGY9+mOCOFLZ7RjA58SdlzJxqYodghdGmSDt igomT8xyfEh0QJrqd/Yya78nL0W1785IHhWs58V/lg+/ziGjLpPiTBrv4JQmhbcF6o1B97 81ImFqyzxiR7zBmtHy025wpFr2A+iwRfILhaG2WuODzhhMBRKVHPNZ5XwoWUCg== Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1oNNUe-001NuW-1T for bug-gnu-emacs@gnu.org; Sun, 14 Aug 2022 16:58:08 -0700 From: Matt Armstrong Date: Sun, 14 Aug 2022 16:58:08 -0700 Message-ID: <87czd2cr8v.fsf@rfc20.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:4b98:dc4:8::232; envelope-from=matt@rfc20.org; helo=relay12.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain gcc 12 is warning about a possible uninitialized variable in coding.c. Looks like Paul fixed the same warning in a nearby function years ago, so I used the same suppression technique here. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Pacify-warnings-from-gcc-12.patch >From ae25595681bdec33e271f3804d0ccfae132bb170 Mon Sep 17 00:00:00 2001 From: Matt Armstrong Date: Sun, 14 Aug 2022 16:41:56 -0700 Subject: [PATCH] Pacify warnings from gcc 12 * src/coding.c (encode_coding_object): Mark saved_pt_byte with UNINIT to silence a false alarm from -Wmaybe-uninitialized. This was already done in decode_coding_object. The fix is correct because saved_pt is used as a sentinel before saved_pt_byte is used. --- src/coding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/coding.c b/src/coding.c index 3fb4f148b1..0ae8eb3282 100644 --- a/src/coding.c +++ b/src/coding.c @@ -8283,7 +8283,7 @@ encode_coding_object (struct coding_system *coding, ptrdiff_t chars = to - from; ptrdiff_t bytes = to_byte - from_byte; Lisp_Object attrs; - ptrdiff_t saved_pt = -1, saved_pt_byte; + ptrdiff_t saved_pt = -1, saved_pt_byte UNINIT; bool need_marker_adjustment = 0; bool kill_src_buffer = 0; Lisp_Object old_deactivate_mark; -- 2.35.1 --=-=-=-- From unknown Mon Aug 18 20:14:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57219: 29.0.50; [PATCH] Fix gcc warning in coding.c Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57219 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Matt Armstrong Cc: 57219@debbugs.gnu.org Received: via spool by 57219-submit@debbugs.gnu.org id=B57219.166054664411547 (code B ref 57219); Mon, 15 Aug 2022 06:58:02 +0000 Received: (at 57219) by debbugs.gnu.org; 15 Aug 2022 06:57:24 +0000 Received: from localhost ([127.0.0.1]:40474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNU2O-00030B-6r for submit@debbugs.gnu.org; Mon, 15 Aug 2022 02:57:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNU2M-0002zu-Fp for 57219@debbugs.gnu.org; Mon, 15 Aug 2022 02:57:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RzCbJV8MVCfFfepth5La+rpKobvQvEMA7YaaM75evwU=; b=qPvxpSjT1HnojY5y64OHlvL0e5 2Iu2xtpPdYYwrW+0M3h88XCt98wYFwOlcNQI4nA6O6ErHfG64UBrUH/tnOz0gsxiFbZMkoQpuC4ab 1iu4OtihoRckrwJNa2JE4/fNSIvs4B3RHb2kZnzO22N5cAgXDnRdQZZ11PGuTiw7wRk4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNU2D-0004hO-Pv; Mon, 15 Aug 2022 08:57:16 +0200 From: Lars Ingebrigtsen In-Reply-To: <87czd2cr8v.fsf@rfc20.org> (Matt Armstrong's message of "Sun, 14 Aug 2022 16:58:08 -0700") References: <87czd2cr8v.fsf@rfc20.org> X-Now-Playing: Aksak Maboul's _Un Peu De L'Ame Des Bandits_: "Palmiers en Pots" Date: Mon, 15 Aug 2022 08:57:13 +0200 Message-ID: <877d3ac7ue.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Matt Armstrong writes: > gcc 12 is warning about a possible uninitialized variable in coding.c. > Looks like Paul fixed the same warning in a nearby function years ago, > so I used the same suppression technique here. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Matt Armstrong writes: > gcc 12 is warning about a possible uninitialized variable in coding.c. > Looks like Paul fixed the same warning in a nearby function years ago, > so I used the same suppression technique here. Thanks; pushed to Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 15 02:57:27 2022 Received: (at control) by debbugs.gnu.org; 15 Aug 2022 06:57:27 +0000 Received: from localhost ([127.0.0.1]:40477 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNU2R-00030S-Fb for submit@debbugs.gnu.org; Mon, 15 Aug 2022 02:57:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNU2Q-000302-0h for control@debbugs.gnu.org; Mon, 15 Aug 2022 02:57:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dQ/FTA9c329Tz3telbUEw6zHx5vGPQttGbyAtnK04Zw=; b=Fr8vH+ZknN6iuB5QlrydJxZOZI rn4iGIq+g7tOUwzeSHtw1p19qNsMsAOfpZesxfccCgAGYUdfVEJZSygMlS2HSF+p96dFiqTu+SjMS rZH2j4R+wPR/SD8b1T4mQf9G7HjI+nmRAgBZzIr9UlEhjYsrAI3O3r/xf0FYDPpfTfdA=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNU2I-0004hW-87 for control@debbugs.gnu.org; Mon, 15 Aug 2022 08:57:20 +0200 Date: Mon, 15 Aug 2022 08:57:17 +0200 Message-Id: <875yiuc7ua.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57219 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57219 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57219 29.1 quit