Subject: bug#57208: 29.0.50; Uninitialized compilation warnings in xterm.c

From: Po Lu <[email-masked]>
Date: Mon, 15 Aug 2022 08:52:16 +0800

"Basil L. Contovounesios" <[email-masked]> writes:

> Severity: minor
> Tags: patch
>
> Compiling with GCC 12 and -Og, I get the following -Wmaybe-uninitialized
> warnings:
>
> xterm.c: In function ‘x_dnd_free_toplevels’:
> xterm.c:2918:17: warning: ‘dpy’ may be used uninitialized [-Wmaybe-uninitialized]
>  2918 |       dpyinfo = x_display_info_for_display (dpy);
>       |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> xterm.c:2853:12: note: ‘dpy’ was declared here
>  2853 |   Display *dpy;
>       |            ^~~
>
> xterm.c: In function ‘xm_setup_dnd_targets’:
> xterm.c:2284:21: warning: ‘recs’ may be used uninitialized [-Wmaybe-uninitialized]
>  2284 |                 recs[header.target_list_count - 1]->targets[i] = targets_sorted[i];
>       |                     ^
> xterm.c:2112:26: note: ‘recs’ was declared here
>  2112 |   xm_targets_table_rec **recs;
>       |                          ^~~~
>
> They're bogus, right?  Is it okay to silence them as follows?

Yes, those are all bogus.  I installed something different to pacify
them on master.

Thanks.