GNU bug report logs - #5719
[patch] fix bat-generic-mode highlighting pattern for CLI switch.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Oleksandr Gavenko <gavenkoa <at> gmail.com>
Subject: bug#5719: closed (Re: [patch] fix bat-generic-mode highlighting
 pattern for CLI switch.)
Date: Sun, 27 Jun 2010 18:45:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#5719: [patch] fix bat-generic-mode highlighting pattern for CLI switch.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 5719 <at> debbugs.gnu.org.

-- 
5719: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5719
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Oleksandr Gavenko <gavenkoa <at> gmail.com>
Cc: 5719-done <at> debbugs.gnu.org
Subject: Re: [patch] fix bat-generic-mode highlighting pattern for CLI switch.
Date: Sun, 27 Jun 2010 14:44:46 -0400

> Pattern for highlight '/help', '/query', '/a' like command line
> options currently does not require leading whitespace char but MUST.

Thanks for the patch.  I've checked it in.

[Message part 3 (message/rfc822, inline)]

From: Oleksandr Gavenko <gavenkoa <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [patch] fix bat-generic-mode highlighting pattern for CLI switch.
Date: Sun, 14 Mar 2010 22:18:19 +0200

[Message part 4 (text/plain, inline)]

Pattern for highlight '/help', '/query', '/a' like
command line options currently does not require
leading whitespace char but MUST.

If you use Cygwin/MSYS from bat file you can type expressions like

  ls dir/sub-dir

and '/sub-dir' unfortunately highlighted as CLI switch!

Switch which start with - or + properly required leading whitespaces.

There exist one situation then you must highlight switch
exactly at start of line (and so there are no any leading whitespaces)
because this line considered continuation of previous line
if previous line end with '^' char.

But this not true for command.com and so unusual situation
so we can ignore it.

So in patch I just improve pattern for '+'/'-', which already
do job right.

-- 
Best regards!

[.patch (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.