GNU bug report logs - #5718
scroll-margin in buffer with small line count.

Previous Next

Package: emacs;

Reported by: Oleksandr Gavenko <gavenkoa <at> gmail.com>

Date: Sun, 14 Mar 2010 17:28:02 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: ahyatt <at> gmail.com, 5718 <at> debbugs.gnu.org, gavenkoa <at> gmail.com
Subject: bug#5718: scroll-margin in buffer with small line count.
Date: Sat, 28 Jan 2017 19:57:21 -0500
[Message part 1 (text/plain, inline)]
tags 5718 patch
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> 
>> I came up with this modified version of partial_line_height, which does
>> actually work.
>
> It looks good to me, thanks.

Okay, I think this is ready now, I'm posting the final patchset for
reference.  It's basically the same as the previous stuff, but I've made
maximum-scroll-margin customizable, and renamed window-tests.el to
test/manual/scroll-tests.el (since it only works in an interactive
session).

I'll push to master in a couple of days.

[v4-0001-Refactor-uses-of-scroll_margin-to-a-function.patch.gz (application/octet-stream, attachment)]
[v4-0002-Don-t-count-mode-line-for-scroll-margin-limit.patch (text/x-diff, attachment)]
[v4-0003-Make-limit-on-scroll-margin-variable.patch (text/x-diff, attachment)]
[v4-0004-Fix-scrolling-with-partial-lines.patch (text/x-diff, attachment)]
[v4-0005-Add-tests-for-scrolling.patch (text/x-diff, attachment)]

This bug report was last modified 8 years and 168 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.