Subject: bug#57176: 29.0.50; Commit 744ed0ce applies outline-minor-mode-highlight-buffer repeatedly

From: Stephen Berman <[email-masked]>
Date: Wed, 17 Aug 2022 09:57:59 +0200

On Mon, 15 Aug 2022 09:42:33 +0200 Lars Ingebrigtsen <[email-masked]> wrote:

> daanturo <[email-masked]> writes:
>
>> I think we should clear old outline overlays before applying new ones,
>> or adjust the conditions like the old one.
>
> I guess this might be the result of this change?
>
> -          (if (and global-font-lock-mode (font-lock-specified-p major-mode))
> -              (progn
> -                (font-lock-add-keywords nil outline-font-lock-keywords t)
> -                (font-lock-flush))
> -            (outline-minor-mode-highlight-buffer)))
> +          (when (and global-font-lock-mode (font-lock-specified-p major-mode))
> +            (font-lock-add-keywords nil outline-font-lock-keywords t)
> +            (font-lock-flush))
> +          (outline-minor-mode-highlight-buffer))
>
> I've added Stephen to the CCs; perhaps he has some comments.

Sorry for the late response.  Juri Linkov already noted a probably
related problem with my patch, see <[email-masked]>.
I'm afraid my reply to his message still holds:

>> I'm not familiar enough with the intricacies of font-lock to whip
>> up a quick fix and can't afford to spend a lot of time on it, so I hope
>> someone better qualified than me will do it.

Juri replied to that:

> I guess what is needed here is to find the right place to call
> outline--fix-up-all-buttons on first visiting the NEWS buffer.

but I haven't had time to look into that, nor whether that would also
work for bug#57176.

Steve Berman