Subject: bug#57173: closed (Re: [bug#57173] [PATCH] gnu: yt-dlp: Update to 2022.08.08.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 02 Sep 2023 03:59:01 +0000

Your bug report

#57173: [PATCH] gnu: yt-dlp: Update to 2022.08.08.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
57173: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57173
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#57173] [PATCH] gnu: yt-dlp: Update to 2022.08.08.
From: Vagrant Cascadian <[email-masked]>
To: Csepp <[email-masked]>, Tobias Geerinckx-Rice <[email-masked]>
Cc: [email-masked]
Date: Fri, 01 Sep 2023 20:58:26 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

On 2022-08-14, Csepp wrote:
> Tobias Geerinckx-Rice <[email-masked]> writes:
>> raingloom 写道：
>>> * gnu/packages/video.scm (yt-dlp): Update to 2022.08.08.
...
>> When using GIT-FETCH, always set the file-name to something
>> meaningful:
>>
>>  (file-name (git-file-name name version))
>>
>>> -                   ;; Delete the pre-generated files, except for
>>> the man page
>>> -                   ;; which requires 'pandoc' to build.
>>
>> OK, but then we do need to build it ourselves, not remove it.
>>
>> Done in c2481b1bea56f2885110d5af0a6cff36a3d95933.
>
> I lazily assumed it was being generated already, I guess the comment was
> misleading and I should have verified it.
>
>> The new package works fine, but differs slightly:
>> extractor/lazy_extractors.py is no longer installed.  What's up with
>> that?
>
> Not sure what that is or where it's used.  I'll try to take a look soon-ish.
>
>> Leaving open for now,

If there are other outstanding issues, might be best to open a new bug
for them at this point?

yt-dlp has been updated several times since, the latest being:

88d107b2b9bf72a628065a1475ecce7b49852c35 gnu: yt-dlp: Update to 2023.07.06.

Marking as done.

live well,
  vagrant

Subject: [PATCH] gnu: yt-dlp: Update to 2022.08.08.
From: raingloom <[email-masked]>
To: [email-masked]
Cc: raingloom <[email-masked]>
Date: Sat, 13 Aug 2022 15:53:01 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/video.scm (yt-dlp): Update to 2022.08.08.
  [source]: remove snippet, switch to git-fetch
---
 gnu/packages/video.scm | 23 ++++++-----------------
 1 file changed, 6 insertions(+), 17 deletions(-)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 6d0b5ccb58..94ef3f0468 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -2486,26 +2486,15 @@ (define-public youtube-dl
 (define-public yt-dlp
   (package/inherit youtube-dl
     (name "yt-dlp")
-    (version "2022.07.18")
+    (version "2022.08.08")
     (source (origin
-              (method url-fetch)
-              (uri (string-append "https://github.com/yt-dlp/yt-dlp/"
-                                  "releases/download/"
-                                  version "/yt-dlp.tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/yt-dlp/yt-dlp/")
+                    (commit version)))
               (sha256
                (base32
-                "1wmzfqhysx1mqdba4ikvm6nbahasihi4xgqwqad20y3vs701slyj"))
-              (snippet
-               #~(begin
-                   ;; Delete the pre-generated files, except for the man page
-                   ;; which requires 'pandoc' to build.
-                   (for-each delete-file
-                             (list "yt-dlp"
-                                   ;;pandoc is needed to generate
-                                   ;;"yt-dlp.1"
-                                   "completions/bash/yt-dlp"
-                                   "completions/fish/yt-dlp.fish"
-                                   "completions/zsh/_yt-dlp"))))))
+                "07qz1zdndlpki0asw35zk5hdjcwpl3n1g54nxg4yb1iykbyv7rll"))))
     (arguments
      (substitute-keyword-arguments (package-arguments youtube-dl)
        ((#:tests? _) #t)
-- 
2.37.1