GNU bug report logs - #57171
[PATCH] gnu: Add emacs-pdfgrep.

Previous Next

Package: guix-patches;

Reported by: pinoaffe <pinoaffe <at> gmail.com>

Date: Sat, 13 Aug 2022 12:09:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 57171 <at> debbugs.gnu.org
Subject: [bug#57171] [PATCH] gnu: Add emacs-pdfgrep.
Date: Tue, 23 Aug 2022 12:07:30 +0200

Thanks for the patch.

I’d change the let* to let, because we don’t need previous bindings to
be available in later bindings.

It would also be nice to avoid propagating pdfgrep.
We could probably avoid propagation by patching
https://github.com/jeremy-compostella/pdfgrep/blob/master/pdfgrep.el#L59
and perhaps also line 81 (executable-find "pdfgrep").

In the synopsis I’d remove the `…' quotes, but that’s a nit-pick.

What do you think?

-- 
Ricardo
This bug report was last modified 2 years and 248 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.