GNU bug report logs - #57171
[PATCH] gnu: Add emacs-pdfgrep.

Previous Next

Full log

Message #16 received at 57171-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: pinoaffe <pinoaffe <at> gmail.com>
Cc: 57171-done <at> debbugs.gnu.org
Subject: Re: [bug#57171] [PATCH v2] gnu: Add emacs-pdfgrep.
Date: Tue, 20 Sep 2022 21:38:47 +0200

Hello,

pinoaffe <pinoaffe <at> gmail.com> writes:

> Date: Sat, 13 Aug 2022 13:59:20 +0200
> From 28d500390c6eee5e89b9fb3c756300751b8af598 Mon Sep 17 00:00:00 2001
> * gnu/packages/emacs-xyz.scm (emacs-pdfgrep): New variable.

Thank you. Applied with the following changes.

> +(define-public emacs-pdfgrep
> +  (let ((commit "a4ca0a1e6521de93f28bb6736a5344b4974d144c")
> +        (revision "0"))
> +    (package
> +      (name "emacs-pdfgrep")
> +      (version (git-version "0" revision commit))

Latest version is actually 1.4. I also downgraded the commit to the one
matching the version bump.

> +               (url "https://github.com/jeremy-compostella/pdfgrep.git")

I removed the ".git" suffix from the URL.
> +                     (add-after
> +                         'unpack
> +                         'patch-pdfgrep-path
> +                       (lambda* (#:key inputs #:allow-other-keys)
> +                         (make-file-writable "pdfgrep.el")
> +                         (emacs-substitute-variables "pdfgrep.el"
> +                           ("pdfgrep-program"
> +                            (search-input-file inputs "bin/pdfgrep")))
> +                         #t)))))

I removed the trailing #t.

> +      (synopsis "Run pdfgrep within Emacs and display the results.")
> +      (description
> +       "This package provides the Emacs \"grep\" facilities for the pdfgrep program.")

I used the description from the repository, which seemed more clear.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.