GNU bug report logs - #57171
[PATCH] gnu: Add emacs-pdfgrep.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#57171: closed ([PATCH] gnu: Add emacs-pdfgrep.)
Date: Tue, 20 Sep 2022 19:39:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 20 Sep 2022 21:38:47 +0200
with message-id <87sfklx2d4.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#57171] [PATCH v2] gnu: Add emacs-pdfgrep.
has caused the debbugs.gnu.org bug report #57171,
regarding [PATCH] gnu: Add emacs-pdfgrep.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
57171: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57171
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: pinoaffe <pinoaffe <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-pdfgrep.
Date: Sat, 13 Aug 2022 14:08:12 +0200

Date: Sat, 13 Aug 2022 13:59:20 +0200
From ed9c9546ff4ed6f24dd534fc80854755f20d8de1 Mon Sep 17 00:00:00 2001
* gnu/packages/emacs-xyz.scm (emacs-pdfgrep): New variable.
---
 gnu/packages/emacs-xyz.scm | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 3c1d322db3..18e32a3283 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -70,7 +70,7 @@
 ;;; Copyright © 2020 Jérémy Korwin-Zmijowski <jeremy <at> korwin-zmijowski.fr>
 ;;; Copyright © 2020 Alberto Eleuterio Flores Guerrero <barbanegra+guix <at> posteo.mx>
 ;;; Copyright © 2020 Marius Bakke <mbakke <at> fastmail.com>
-;;; Copyright © 2020 pinoaffe <pinoaffe <at> airmail.cc>
+;;; Copyright © 2020, 2022 pinoaffe <pinoaffe <at> gmail.com>
 ;;; Copyright © 2020, 2021, 2022 Vinicius Monego <monego <at> posteo.net>
 ;;; Copyright © 2020 Ryan Desfosses <rdes <at> protonmail.com>
 ;;; Copyright © 2020 Marcin Karpezo <sirmacik <at> wioo.waw.pl>
@@ -3839,6 +3839,28 @@ (define-public emacs-saveplace-pdf-view
 restore the saved place.")
     (license license:gpl3+)))
 
+(define-public emacs-pdfgrep
+  (let* ((commit "a4ca0a1e6521de93f28bb6736a5344b4974d144c")
+         (revision "0"))
+    (package
+      (name "emacs-pdfgrep")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/jeremy-compostella/pdfgrep.git")
+               (commit commit)))
+         (sha256
+          (base32 "093sm3ywa338lhhz2ib3ylcgklsbxcsqck2qsaq26i2qxr0r7lq2"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list pdfgrep))
+      (home-page "https://github.com/jeremy-compostella/pdfgrep")
+      (synopsis "Run `pdfgrep' within Emacs and display the results.")
+      (description
+       "This package provides the Emacs \"grep\" facilities for the pdfgrep program.")
+      (license license:gpl3+))))
+
 (define-public emacs-dash
   (package
     (name "emacs-dash")
-- 
2.37.1

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: pinoaffe <pinoaffe <at> gmail.com>
Cc: 57171-done <at> debbugs.gnu.org
Subject: Re: [bug#57171] [PATCH v2] gnu: Add emacs-pdfgrep.
Date: Tue, 20 Sep 2022 21:38:47 +0200

Hello,

pinoaffe <pinoaffe <at> gmail.com> writes:

> Date: Sat, 13 Aug 2022 13:59:20 +0200
> From 28d500390c6eee5e89b9fb3c756300751b8af598 Mon Sep 17 00:00:00 2001
> * gnu/packages/emacs-xyz.scm (emacs-pdfgrep): New variable.

Thank you. Applied with the following changes.

> +(define-public emacs-pdfgrep
> +  (let ((commit "a4ca0a1e6521de93f28bb6736a5344b4974d144c")
> +        (revision "0"))
> +    (package
> +      (name "emacs-pdfgrep")
> +      (version (git-version "0" revision commit))

Latest version is actually 1.4. I also downgraded the commit to the one
matching the version bump.

> +               (url "https://github.com/jeremy-compostella/pdfgrep.git")

I removed the ".git" suffix from the URL.
> +                     (add-after
> +                         'unpack
> +                         'patch-pdfgrep-path
> +                       (lambda* (#:key inputs #:allow-other-keys)
> +                         (make-file-writable "pdfgrep.el")
> +                         (emacs-substitute-variables "pdfgrep.el"
> +                           ("pdfgrep-program"
> +                            (search-input-file inputs "bin/pdfgrep")))
> +                         #t)))))

I removed the trailing #t.

> +      (synopsis "Run pdfgrep within Emacs and display the results.")
> +      (description
> +       "This package provides the Emacs \"grep\" facilities for the pdfgrep program.")

I used the description from the repository, which seemed more clear.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.