From unknown Sat Aug 16 23:42:10 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5717: 23.1; auto-revert-mode loses point in dired buffers Resent-From: flat0103@gmail.com Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Mar 2010 07:36:02 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: report 5717 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 5717@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.126855211330260 (code B ref -1); Sun, 14 Mar 2010 07:36:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Mar 2010 07:35:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NqiLv-0007s1-1y for submit@debbugs.gnu.org; Sun, 14 Mar 2010 03:35:13 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NqiLr-0007rw-TA for submit@debbugs.gnu.org; Sun, 14 Mar 2010 03:35:10 -0400 Received: from lists.gnu.org ([199.232.76.165]:52968) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NqiLo-0003NX-BZ for submit@debbugs.gnu.org; Sun, 14 Mar 2010 03:35:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NqiLn-0000sE-KF for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2010 03:35:03 -0400 Received: from [140.186.70.92] (port=52955 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NqiLl-0000pY-PL for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2010 03:35:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NqiLk-0008Gi-0c for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2010 03:35:01 -0400 Received: from mail-px0-f204.google.com ([209.85.216.204]:57407) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NqiLj-0008GY-SU for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2010 03:34:59 -0400 Received: by pxi42 with SMTP id 42so903001pxi.26 for ; Sat, 13 Mar 2010 23:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:date:message-id:to :subject; bh=NUl8gUMfAp+dcYVL9gTR2rI8uTJrGzbjA/iMkHRml5Y=; b=E5Ont1Cm2211RfqZT6Zh9utJYqvp/FDUnoc23gjnGKutYmBiGsPwyrjiZkMszZ7AuP pIcvW44K+2oLbAAdfHLsM36ZuBFAbGYWqdjMLPKNOnJRyw/dV7NOR4bVHhJX70Q9OXnQ mjHpY1YOawiv3U91+zlPAmCtAbgbpyRMg+rBQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:message-id:to:subject; b=oQLytXMwdV7hr62cjNRKdmxUNcaTLrNYRxfb41/B5MZN5xZu4m14NbkFN/LQ6g8QY0 qVcp0aakBbCzy5aWW2kxFR8D00lScgAs2zDW4Za128A9AJbuYzoy+era3tCzN2J5ft1/ Ej2KeH/mxNGKG9uzLxNIExh4DtlLnm3+/3veI= Received: by 10.114.187.19 with SMTP id k19mr519175waf.20.1268552098363; Sat, 13 Mar 2010 23:34:58 -0800 (PST) Received: from nflath-laptop (c-67-170-87-148.hsd1.wa.comcast.net [67.170.87.148]) by mx.google.com with ESMTPS id 23sm3931404pzk.14.2010.03.13.23.34.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 13 Mar 2010 23:34:58 -0800 (PST) From: flat0103@gmail.com Date: Sat, 13 Mar 2010 23:34:49 -0800 Message-Id: <87mxybjqzq.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) In dired buffers, auto-revert-mode will cause the location of point to change to point-min whenever a change occurs. It seems much better to keep current point; this may not always be the same cursor location, but will be correct much more often. Patch follows: diff --git a/lisp/autorevert.el b/lisp/autorevert.el index 81d9fbf..697507f 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -478,6 +478,8 @@ This is an internal function used by Auto-Revert Mode." (when eob (goto-char (point-max))) (dolist (window eoblist) (set-window-point window (point-max))))) + (unless eoblist + (goto-char (point))) ;; `preserve-modes' avoids changing the (minor) modes. But we ;; do want to reset the mode for VC, so we do it manually. (when (or revert auto-revert-check-vc-info) From unknown Sat Aug 16 23:42:10 2025 X-Loop: bug-gnu-emacs@gnu.org Subject: bug#5717: 23.1; auto-revert-mode loses point in dired buffers Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 14 Mar 2010 22:06:01 +0000 Resent-Message-ID: Resent-Sender: bug-gnu-emacs@gnu.org X-GNU-PR-Message: followup 5717 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: flat0103@gmail.com Cc: 5717@debbugs.gnu.org Received: via spool by 5717-submit@debbugs.gnu.org id=B5717.126860434221231 (code B ref 5717); Sun, 14 Mar 2010 22:06:01 +0000 Received: (at 5717) by debbugs.gnu.org; 14 Mar 2010 22:05:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NqvwM-0005WO-JW for submit@debbugs.gnu.org; Sun, 14 Mar 2010 18:05:42 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NqvwK-0005WH-Od for 5717@debbugs.gnu.org; Sun, 14 Mar 2010 18:05:41 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.68.205.cable.starman.ee [82.131.68.205]) by mx1.starman.ee (Postfix) with ESMTP id 1FD503F40AA; Mon, 15 Mar 2010 00:05:31 +0200 (EET) From: Juri Linkov Organization: JURTA References: <87mxybjqzq.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me> Date: Sun, 14 Mar 2010 23:55:00 +0200 In-Reply-To: <87mxybjqzq.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me> (flat's message of "Sat, 13 Mar 2010 23:34:49 -0800") Message-ID: <87pr36wouj.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) > In dired buffers, auto-revert-mode will cause the location of point to > change to point-min whenever a change occurs. It seems much better to > keep current point; this may not always be the same cursor location, > but will be correct much more often. Recently we fixed `dired-revert' to keep window points. And now I can't reproduce your bug report with the latest code. `auto-revert-mode' keeps point in dired buffers. Could you provide more information: Emacs version number and step-by-step recipe with the latest code. -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 18 22:59:11 2010 Received: (at control) by debbugs.gnu.org; 19 Mar 2010 02:59:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NsSQZ-0007Jq-KB for submit@debbugs.gnu.org; Thu, 18 Mar 2010 22:59:11 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NsSQX-0007Jk-Vm for control@debbugs.gnu.org; Thu, 18 Mar 2010 22:59:10 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NsSQT-0007is-VH; Thu, 18 Mar 2010 22:59:06 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19362.59513.721447.641996@fencepost.gnu.org> Date: Thu, 18 Mar 2010 22:59:05 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: cyan X-Ran: pg=Ww3JAIc\=!*)%Z5Fhs9Ym$)~XH{,K X-Debbugs-No-Ack: yes X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) close 5642 severity 5716 minor tags 5717 moreinfo severity 5721 wishlist reassign 4065 emacs From unknown Sat Aug 16 23:42:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: flat0103@gmail.com Subject: bug#5717: closed (Re: bug#5717: 23.1; auto-revert-mode loses point in dired buffers) Message-ID: References: <87mxybjqzq.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me> X-Gnu-PR-Message: they-closed 5717 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: moreinfo Reply-To: 5717@debbugs.gnu.org Date: Mon, 11 Jul 2011 21:38:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1310420282-19277-1" This is a multi-part message in MIME format... ------------=_1310420282-19277-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #5717: 23.1; auto-revert-mode loses point in dired buffers which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 5717@debbugs.gnu.org. --=20 5717: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D5717 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1310420282-19277-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 5717-done) by debbugs.gnu.org; 11 Jul 2011 21:37:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgOAa-00050H-4G for submit@debbugs.gnu.org; Mon, 11 Jul 2011 17:37:36 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgOAY-000506-3S for 5717-done@debbugs.gnu.org; Mon, 11 Jul 2011 17:37:34 -0400 Received: from localhost ([127.0.0.1]:44391) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QgOAS-0006N7-9V; Mon, 11 Jul 2011 17:37:28 -0400 From: Glenn Morris To: 5717-done@debbugs.gnu.org Subject: Re: bug#5717: 23.1; auto-revert-mode loses point in dired buffers References: <87mxybjqzq.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me> <87pr36wouj.fsf@mail.jurta.org> X-Spook: MIT-LL Mahmoud Ahmadinejad AVIP BRLO unclassified Taiwan X-Ran: eP17h]@:]zL4%:yJ`lkN#}F"a4)d-CRhh$X*^}A*{1f2szCY9`0MqsL6=M (Juri Linkov's message of "Sun, 14 Mar 2010 23:55:00 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: 5717-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) This bug is being closed because it could not be reproduced and there was no response to a request for more information. If you still see the problem with the latest Emacs release, 23.3, please reply with the requested information and it can be reopened if needed. You can view the whole report at http://debbugs.gnu.org/BUGNUMBER Juri Linkov wrote: > Recently we fixed `dired-revert' to keep window points. > And now I can't reproduce your bug report with the latest code. > `auto-revert-mode' keeps point in dired buffers. > > Could you provide more information: Emacs version number > and step-by-step recipe with the latest code. ------------=_1310420282-19277-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Mar 2010 07:35:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NqiLv-0007s1-1y for submit@debbugs.gnu.org; Sun, 14 Mar 2010 03:35:13 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NqiLr-0007rw-TA for submit@debbugs.gnu.org; Sun, 14 Mar 2010 03:35:10 -0400 Received: from lists.gnu.org ([199.232.76.165]:52968) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NqiLo-0003NX-BZ for submit@debbugs.gnu.org; Sun, 14 Mar 2010 03:35:04 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NqiLn-0000sE-KF for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2010 03:35:03 -0400 Received: from [140.186.70.92] (port=52955 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NqiLl-0000pY-PL for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2010 03:35:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NqiLk-0008Gi-0c for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2010 03:35:01 -0400 Received: from mail-px0-f204.google.com ([209.85.216.204]:57407) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NqiLj-0008GY-SU for bug-gnu-emacs@gnu.org; Sun, 14 Mar 2010 03:34:59 -0400 Received: by pxi42 with SMTP id 42so903001pxi.26 for ; Sat, 13 Mar 2010 23:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:date:message-id:to :subject; bh=NUl8gUMfAp+dcYVL9gTR2rI8uTJrGzbjA/iMkHRml5Y=; b=E5Ont1Cm2211RfqZT6Zh9utJYqvp/FDUnoc23gjnGKutYmBiGsPwyrjiZkMszZ7AuP pIcvW44K+2oLbAAdfHLsM36ZuBFAbGYWqdjMLPKNOnJRyw/dV7NOR4bVHhJX70Q9OXnQ mjHpY1YOawiv3U91+zlPAmCtAbgbpyRMg+rBQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:date:message-id:to:subject; b=oQLytXMwdV7hr62cjNRKdmxUNcaTLrNYRxfb41/B5MZN5xZu4m14NbkFN/LQ6g8QY0 qVcp0aakBbCzy5aWW2kxFR8D00lScgAs2zDW4Za128A9AJbuYzoy+era3tCzN2J5ft1/ Ej2KeH/mxNGKG9uzLxNIExh4DtlLnm3+/3veI= Received: by 10.114.187.19 with SMTP id k19mr519175waf.20.1268552098363; Sat, 13 Mar 2010 23:34:58 -0800 (PST) Received: from nflath-laptop (c-67-170-87-148.hsd1.wa.comcast.net [67.170.87.148]) by mx.google.com with ESMTPS id 23sm3931404pzk.14.2010.03.13.23.34.57 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 13 Mar 2010 23:34:58 -0800 (PST) From: flat0103@gmail.com Date: Sat, 13 Mar 2010 23:34:49 -0800 Message-Id: <87mxybjqzq.fsf@nflath-laptop.i-did-not-set--mail-host-address--so-tickle-me> To: bug-gnu-emacs@gnu.org Subject: 23.1; auto-revert-mode loses point in dired buffers X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) In dired buffers, auto-revert-mode will cause the location of point to change to point-min whenever a change occurs. It seems much better to keep current point; this may not always be the same cursor location, but will be correct much more often. Patch follows: diff --git a/lisp/autorevert.el b/lisp/autorevert.el index 81d9fbf..697507f 100644 --- a/lisp/autorevert.el +++ b/lisp/autorevert.el @@ -478,6 +478,8 @@ This is an internal function used by Auto-Revert Mode." (when eob (goto-char (point-max))) (dolist (window eoblist) (set-window-point window (point-max))))) + (unless eoblist + (goto-char (point))) ;; `preserve-modes' avoids changing the (minor) modes. But we ;; do want to reset the mode for VC, so we do it manually. (when (or revert auto-revert-check-vc-info) ------------=_1310420282-19277-1--