Subject: Re: bug#57146: [PATCH] gnu: polkit: Fix cross-compiling

From: Andrew Patterson <[email-masked]>
Date: Fri, 12 Aug 2022 17:24:39 -0400

> Thanks for working on that. It looks like this patch is breaking 
> host
> compilation:
>
> error: in phase 'fix-manpage-generation': uncaught exception:
> wrong-type-arg "string-append" "Wrong type (expecting ~A): ~S" 
> ("string" #f) (#f) 
> phase `fix-manpage-generation' failed after 0.0 seconds
> Backtrace:
>            9 (primitive-load 
>            "/gnu/store/k2p4qxc23g871rm5q50bcx45f3m…")
> In guix/build/gnu-build-system.scm:
>     906:2  8 (gnu-build #:source _ #:outputs _ #:inputs _ 
>     #:phases . #)
Huh.  Looking at Jean Pierre's patch, apparently native-inputs 
only exists when cross-compiling, good to know.

> Also you are doing a lot of things at the same time: fixing 
> indentation,
> introducing gexps, fixing cross-compilation. It would be great 
> if you
> could do that in separate patches to ease the review process.
I'll make sure to keep that in mind in the future, sorry.

-- 
Andrew Patterson