GNU bug report logs - #57144
29.0.50; Missing description for excluded files in docstring of loaddefs-generate

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57144 in the body.
You can then email your comments to 57144 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: emacs-bugs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.50; Missing description for excluded files in docstring of
 loaddefs-generate
Date: Thu, 11 Aug 2022 21:31:32 +0200

Hi all,

This is the docstring of `loaddefs-generate':

,----[ C-h f loaddefs-generate RET ]
| loaddefs-generate is an autoloaded Lisp function in ‘loaddefs-gen.el’.
| 
| (loaddefs-generate DIR OUTPUT-FILE &optional EXCLUDED-FILES EXTRA-DATA
| INCLUDE-PACKAGE-VERSION GENERATE-FULL)
| 
| Generate loaddefs files for Lisp files in the directories DIRS.
| DIR can be either a single directory or a list of directories.
| 
| The autoloads will be written to OUTPUT-FILE.  If any Lisp file
| binds ‘generated-autoload-file’ as a file-local variable, write
| its autoloads into the specified file instead.
| 
| The function does NOT recursively descend into subdirectories of the
| directory or directories specified.
| 
| If EXTRA-DATA, include this string at the start of the generated
| file.  This will also force generation of OUTPUT-FILE even if
| there are no autoloads to put into the file.
| 
| If INCLUDE-PACKAGE-VERSION, include package version data.
| 
| If GENERATE-FULL, don’t update, but regenerate all the loaddefs files.
`----

A description for EXCLUDED-FILES is missing.  It will a list containing
file names, but details should be added.

Best, Arash

Message #10 received at 57144-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: 57144-done <at> debbugs.gnu.org
Subject: Re: bug#57144: 29.0.50;
 Missing description for excluded files in docstring of
 loaddefs-generate
Date: Fri, 12 Aug 2022 09:50:59 +0300

> From: Arash Esbati <arash <at> gnu.org>
> Date: Thu, 11 Aug 2022 21:31:32 +0200
> 
> A description for EXCLUDED-FILES is missing.  It will a list containing
> file names, but details should be added.

Thanks, fixed.

Message #13 received at 57144 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57144 <at> debbugs.gnu.org
Subject: Re: bug#57144: 29.0.50; Missing description for excluded files in
 docstring of loaddefs-generate
Date: Fri, 12 Aug 2022 19:51:03 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Arash Esbati <arash <at> gnu.org>
>> Date: Thu, 11 Aug 2022 21:31:32 +0200
>> 
>> A description for EXCLUDED-FILES is missing.  It will a list containing
>> file names, but details should be added.
>
> Thanks, fixed.

Thanks for the quick fix.  I still can't get files excluded in the
generation process.  Please consider the 3 simple .el files attached and
save them under ~/Test/.  Now eval in *scratch*

(loaddefs-generate "~/Test/"
                   "~/Test/autoload.el"
                   '("ignore.el") nil nil t)

or

(loaddefs-generate "~/Test/"
                   "~/Test/autoload.el"
                   '("~/Test/input-ignore.el") nil nil t)

autoloads from input-ignore.el aren't ignored.  Am I missing something?

Best, Arash

[input-one.el (application/emacs-lisp, attachment)]

[input-two.el (application/emacs-lisp, attachment)]

[input-ignore.el (application/emacs-lisp, attachment)]

Message #16 received at 57144 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57144 <at> debbugs.gnu.org
Subject: Re: bug#57144: 29.0.50; Missing description for excluded files in
 docstring of loaddefs-generate
Date: Sat, 13 Aug 2022 14:08:06 +0200

Arash Esbati <arash <at> gnu.org> writes:

> (loaddefs-generate "~/Test/"
>                    "~/Test/autoload.el"
>                    '("~/Test/input-ignore.el") nil nil t)
>
> autoloads from input-ignore.el aren't ignored.  Am I missing something?

The excluded files weren't expanded.  I've now fixed this in Emacs 29.

Message #19 received at 57144 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57144 <at> debbugs.gnu.org
Subject: Re: bug#57144: 29.0.50; Missing description for excluded files in
 docstring of loaddefs-generate
Date: Sat, 13 Aug 2022 18:47:52 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Arash Esbati <arash <at> gnu.org> writes:
>
>> (loaddefs-generate "~/Test/"
>>                    "~/Test/autoload.el"
>>                    '("~/Test/input-ignore.el") nil nil t)
>>
>> autoloads from input-ignore.el aren't ignored.  Am I missing something?
>
> The excluded files weren't expanded.  I've now fixed this in Emacs 29.

Thanks for looking at this.  But it still doesn't work for with the
recipe I've posted in this message[1].  Does it work for you?  This is
with Emacs master 9d6d3b0edb.

Best, Arash

Footnotes:
[1]  https://lists.gnu.org/archive/html/bug-gnu-emacs/2022-08/msg01067.html

Message #22 received at 57144 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57144 <at> debbugs.gnu.org
Subject: Re: bug#57144: 29.0.50; Missing description for excluded files in
 docstring of loaddefs-generate
Date: Mon, 15 Aug 2022 08:33:24 +0200

Arash Esbati <arash <at> gnu.org> writes:

> Thanks for looking at this.  But it still doesn't work for with the
> recipe I've posted in this message[1].  Does it work for you?  This is
> with Emacs master 9d6d3b0edb.

No, there were further bugs in the exclusion logic.  Can you test again
now?

Message #25 received at 57144 <at> debbugs.gnu.org (full text, mbox):

From: Arash Esbati <arash <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57144 <at> debbugs.gnu.org
Subject: Re: bug#57144: 29.0.50; Missing description for excluded files in
 docstring of loaddefs-generate
Date: Mon, 15 Aug 2022 11:48:51 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Arash Esbati <arash <at> gnu.org> writes:
>
>> Thanks for looking at this.  But it still doesn't work for with the
>> recipe I've posted in this message[1].  Does it work for you?  This is
>> with Emacs master 9d6d3b0edb.
>
> No, there were further bugs in the exclusion logic.  Can you test again
> now?

It seems to work now.  Thanks for the fix.

Best, Arash

Message #28 received at 57144 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Arash Esbati <arash <at> gnu.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57144 <at> debbugs.gnu.org
Subject: Re: bug#57144: 29.0.50; Missing description for excluded files in
 docstring of loaddefs-generate
Date: Mon, 15 Aug 2022 12:08:32 +0200

Arash Esbati <arash <at> gnu.org> writes:

> It seems to work now.  Thanks for the fix.

Thanks; I'm closing this bug report, then.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.