From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 08:30:42 2022 Received: (at submit) by debbugs.gnu.org; 10 Aug 2022 12:30:43 +0000 Received: from localhost ([127.0.0.1]:46757 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLkrC-000838-2u for submit@debbugs.gnu.org; Wed, 10 Aug 2022 08:30:42 -0400 Received: from lists.gnu.org ([209.51.188.17]:53436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLa0k-0008RJ-QJ for submit@debbugs.gnu.org; Tue, 09 Aug 2022 20:55:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLa0k-0003y9-Ki for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 20:55:50 -0400 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]:39822) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLa0i-0005e7-Fc for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 20:55:50 -0400 Received: by mail-io1-xd31.google.com with SMTP id i84so10999680ioa.6 for ; Tue, 09 Aug 2022 17:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc; bh=EHu19rUOLSnGxQtYXB8/r0tkX1ELs5n4CvU0lU7GJDk=; b=eSw7sB1aQwlz1AbRBf6+lJF+cxpbzFz5Ss1YZAJNR6hzm8IoWCyHHX2NTyyWhoCC0b jgHuqSkYUrZ46ltpQOdp2F756sR9SVs/OJ0FVX/kjuZ8UVksUvsvw3xAy6vTT2/qIRyx gWT70lislA3yCUR9X3hy9oRku0jJtN5giuUgeiot2JDsw+DsM3pa7gehZe8/XHt4fNMu iCr6MbpKvZ99Ug9tj9aw22LZ5fCt9lpXlFTEW1CucUJfuHvPb23SNSxELHNIoyJPmm6k UDz20OiQSL3qwOYafSTjCW6DkME8K9z3zOWrjNGbzVB5ipo4YTiqiq2Z4E/fUIVfFVXQ aagQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc; bh=EHu19rUOLSnGxQtYXB8/r0tkX1ELs5n4CvU0lU7GJDk=; b=O+NUwgKpZeD3sLZUfzPNHXKd0y4eODxG4mvLV9v8F+qKDdGKYNoEqP7XphuvOJJBaQ ytkH7ezvbkPx93FalufzVPHgVxIQRtGpShVOJpFnekq7+lv4efFsshu3EvRgJCHORC2v si8XQNHJ646wOjI4NsglJCr0RZGXgip1hEPTlmGR5Ako7ZSn3tIsSVwYQxvG4MEbx8EF CHeiINBYOUKCGopZ2qPE5ef1eC0OSRoOTiu9VlI1uxzZZNHa9zI12nGsGBBMOvfUulNI 6eQcEqVV/Wj7nBd9g/+Gvt05HQZn7xCiAkypF2qfrRxz7rnpo801U4x2SyXiVp/RpkWM iXrQ== X-Gm-Message-State: ACgBeo1dzAZj/pv/2Ns7MwlPSB+yPK+MlJDKkNNf6/Y713sPo7tp++iA 38rzh5zvJZDKlYBMrDYoxdPmNlE6eknILoQrDOi4HRcIIAwibA== X-Google-Smtp-Source: AA6agR7lCUhY35gy/tZpED9R6g2tK2w56BjYMZkB8Q7O4zENx7IZ4kTHPVCgnHe8OKRr9VgoCzxAgMEarHrpbVykD2Q= X-Received: by 2002:a05:6638:1496:b0:342:873b:a07c with SMTP id j22-20020a056638149600b00342873ba07cmr11424399jak.236.1660092946619; Tue, 09 Aug 2022 17:55:46 -0700 (PDT) MIME-Version: 1.0 From: Pythonora Nybon Date: Wed, 10 Aug 2022 08:55:09 +0800 Message-ID: Subject: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="00000000000060a55b05e5d882b3" Received-SPF: pass client-ip=2607:f8b0:4864:20::d31; envelope-from=bmsac0001@gmail.com; helo=mail-io1-xd31.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 10 Aug 2022 08:30:40 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --00000000000060a55b05e5d882b3 Content-Type: text/plain; charset="UTF-8" Dear emacs maintenance team: I found a seriously bug in the latest emacs master development branch (i.e. the next-stage emacs 29 version) which may cause seriously compatibility issues for older emacs users, please see the description below: # Description: **NOTE: It's a seriously fatal bug** It seems the new `oclosure` internal API invocation caused this issue since it modified `advice` refers. And there's no problem in emacs-28 and further older versions. This bug will definitely broke the user emacs config compatibility while they update to 29, since many user use **non-side-effects advice** to inject their owns habits into the vanilla emacs specification. I use the `find-file` just as a example but the bug seemly effects on most of the `advice` behaviour covered on others occasions. Reproduce: Insert below snippet as your `init.el` and run with vanilla emacs 29 session. ``` elisp (toggle-debug-on-quit) ;; (toggle-frame-maximized) ;; (package-initialize) (require 'files) (require 'help) (with-temp-message (substitute-command-keys (format "emacs %s is hang of `commandp' loop via advice to `find-file', \ please hint `\\[keyboard-quit]' to see the backtrace." emacs-major-version)) (dotimes (cnt 20) (let ((sym (intern (format "test-advice/cnt-%s" cnt)))) (eval `(progn (defun ,sym (&rest _) nil) (advice-add 'find-file :before ',sym))))) (commandp 'find-file)) ``` # SYSTEM informations ``` In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-07-28 built on HOMEPC. Repository revision: 163424e04b7f75a1655fd263ba4b6d6d4fa880b2 Repository branch: HEAD Windowing system distributor 'The X.Org Foundation', version 11.0.12201003 System Description: Arch Linux Configured using: 'configure --prefix=/usr/local/share/emacs/29.0.50/ --with-mailutils --with-imagemagick' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ IMAGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-fns radix-tree cl-print byte-opt gv bytecomp byte-compile cconv debug backtrace help-mode find-func cl-loaddefs cl-lib cus-start cus-load rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 113315 7232) (symbols 48 7241 0) (strings 32 19051 975) (string-bytes 1 602973) (vectors 16 11955) (vector-slots 8 171420 9118) (floats 8 24 26) (intervals 56 5526 0) (buffers 992 12)) ``` --00000000000060a55b05e5d882b3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Dear emacs maintenance team:

I found a serious= ly bug in the latest emacs master development branch
(i.e. the next-stag= e emacs 29 version) which may cause seriously
compatibility issues for o= lder emacs users, please see the description
below:

# Description= :

**NOTE: It's a seriously fatal bug**

It seems the new `= oclosure` internal API invocation caused this issue
since it modified `a= dvice` refers.=C2=A0And there's no problem in
emacs-28 and further o= lder versions.

This bug will definitely broke the user emacs config = compatibility
while they update to 29, since many user use **non-side-ef= fects
advice** to inject their owns habits into the vanilla emacs
spe= cification.

I use the `find-file` just as a example but the bug seem= ly effects on
most of the `advice` behaviour covered on others occasions= .

Reproduce:

Insert below snippet as your `init.el` and run w= ith vanilla emacs 29 session.

``` elisp

(toggle-debug-on-quit= )
;; (toggle-frame-maximized)
;; (package-initialize)
(require = 9;files)
(require 'help)
(with-temp-message
=C2=A0 =C2=A0 (sub= stitute-command-keys
=C2=A0 =C2=A0 =C2=A0(format
=C2=A0 =C2=A0 =C2=A0= "emacs %s is hang of `commandp' loop via advice to `find-file'= ;, \
please hint `\\[keyboard-quit]' to see the backtrace."
= =C2=A0 =C2=A0 =C2=A0 emacs-major-version))
=C2=A0 (dotimes (cnt 20)
= =C2=A0 =C2=A0 (let ((sym (intern (format "test-advice/cnt-%s" cnt= ))))
=C2=A0 =C2=A0 =C2=A0 (eval
=C2=A0 =C2=A0 =C2=A0 =C2=A0`(progn=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (defun ,sym (&rest _)
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 nil)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = (advice-add 'find-file :before ',sym)))))
=C2=A0 (commandp '= find-file))

```

# SYSTEM informations

```

In GN= U Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
=C2=A03.24.3= 4, cairo version 1.17.6) of 2022-07-28 built on
=C2=A0HOMEPC. Repository= revision:
=C2=A0163424e04b7f75a1655fd263ba4b6d6d4fa880b2 Repository bra= nch: HEAD
=C2=A0Windowing system distributor 'The X.Org Foundation&#= 39;, version
=C2=A011.0.12201003 System Description: Arch Linux

C= onfigured using: 'configure --prefix=3D/usr/local/share/emacs/29.0.50/<= br>=C2=A0--with-mailutils --with-imagemagick'

Configured feature= s: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM
GSETTINGS HARFBUZZ IM= AGEMAGICK JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2
M17N_FLT MODULES NOT= IFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3
THREADS TIFF TOOLKIT_= SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settin= gs: value of $LANG: en_US.UTF-8 locale-coding-system:
=C2=A0 utf-8-unix<= br>
Major mode: Lisp Interaction

Minor modes in effect: tooltip-m= ode: t global-eldoc-mode: t eldoc-mode:
=C2=A0 t show-paren-mode: t elec= tric-indent-mode: t mouse-wheel-mode: t
=C2=A0 tool-bar-mode: t menu-bar= -mode: t file-name-shadow-mode: t
=C2=A0 global-font-lock-mode: t font-l= ock-mode: t blink-cursor-mode: t
=C2=A0 line-number-mode: t indent-tabs-= mode: t transient-mark-mode: t
=C2=A0 auto-composition-mode: t auto-encr= yption-mode: t
=C2=A0 auto-compression-mode: t

Load-path shadows:= None found.

Features: (shadow sort mail-extr emacsbug message mailc= ap yank-media
puny dired dired-loaddefs rfc822 mml mml-sec password-cach= e epa derived
epg rfc6068 epg-config gnus-util text-property-search time= -date subr-x
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev= gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-p= rsvr
mail-utils help-fns radix-tree cl-print byte-opt gv bytecomp
byt= e-compile cconv debug backtrace help-mode find-func cl-loaddefs
cl-lib c= us-start cus-load rmc iso-transl tooltip eldoc paren electric
uniquify e= diff-hook vc-hooks lisp-float-type elisp-mode mwheel
term/x-win x-win te= rm/common-win x-dnd tool-bar dnd fontset image
regexp-opt fringe tabulat= ed-list replace newcomment text-mode lisp-mode
prog-mode register page t= ab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mou= se jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer = nadvice seq simple cl-generic
indonesian philippine cham georgian utf-8-= lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese eucj= p-ms cp51932 hebrew greek
romanian slovak czech european ethiopic indian= cyrillic chinese
composite emoji-zwj charscript charprop case-table epa= -hook
jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loa= ddefs
faces cus-face macroexp files window text-properties overlay sha1 = md5
base64 format env code-pages mule custom widget keymap
hashtable-= print-readable backquote threads dbusbind inotify lcms2
dynamic-setting = system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit= xinput2 x multi-tty make-network-process
emacs)

Memory informati= on: ((conses 16 113315 7232) (symbols 48 7241 0)
(strings 32 19051 975) = (string-bytes 1 602973) (vectors 16 11955)
(vector-slots 8 171420 9118) = (floats 8 24 26) (intervals 56 5526 0)
(buffers 992 12))

```
<= /div>
--00000000000060a55b05e5d882b3-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 12 11:28:06 2022 Received: (at 57115) by debbugs.gnu.org; 12 Aug 2022 15:28:06 +0000 Received: from localhost ([127.0.0.1]:58639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMWZx-0008R0-M8 for submit@debbugs.gnu.org; Fri, 12 Aug 2022 11:28:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMWZv-0008QP-Uf for 57115@debbugs.gnu.org; Fri, 12 Aug 2022 11:28:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=2rOyu/5N3VVn+kqt5fyw2/Z3WqcP1k9K7GVCyTOmBhA=; b=qhfthya4JpcBmdbNeZa3uhy60o c9mj1Xwteyy7cpZZ5J1/oHSv44PYjC3Fx0PH/ozCevECnF562LHlaBIM8AzaK91c0i972vu/hCdyt 1TWS7NX6FU37+oGUng9LqPUxdUhpGMIdxh6xdEAy2+bJLIQWPd4CafVkwuw6fyScjmqU=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMWZm-0006V6-Ef; Fri, 12 Aug 2022 17:27:56 +0200 From: Lars Ingebrigtsen To: Pythonora Nybon Subject: Re: bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level In-Reply-To: (Pythonora Nybon's message of "Wed, 10 Aug 2022 08:55:09 +0800") References: X-Now-Playing: Joni Mitchell's _Clouds_: "That Song About the Midway" Date: Fri, 12 Aug 2022 17:27:53 +0200 Message-ID: <87czd5o51i.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Pythonora Nybon writes: > Insert below snippet as your `init.el` and run with vanilla emacs 29 session. > > ``` elisp > > (toggle-debug-on-quit) > ; ; (toggle-frame-maximized) > ; ; (package-initialize) > (require 'files) > (r [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57115 Cc: 57115@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Pythonora Nybon writes: > Insert below snippet as your `init.el` and run with vanilla emacs 29 session. > > ``` elisp > > (toggle-debug-on-quit) > ;; (toggle-frame-maximized) > ;; (package-initialize) > (require 'files) > (require 'help) > (with-temp-message > (substitute-command-keys > (format > "emacs %s is hang of `commandp' loop via advice to `find-file', \ > please hint `\\[keyboard-quit]' to see the backtrace." > emacs-major-version)) > (dotimes (cnt 20) > (let ((sym (intern (format "test-advice/cnt-%s" cnt)))) > (eval > `(progn > (defun ,sym (&rest _) > nil) > (advice-add 'find-file :before ',sym))))) > (commandp 'find-file)) I'm not quite sure what this code snippet is attempting to achieve, but it does hang in Emacs 29, and it didn't in Emacs 28. Adding Stefan to the CCs; perhaps he has some comments. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 00:37:34 2022 Received: (at 57115) by debbugs.gnu.org; 13 Aug 2022 04:37:35 +0000 Received: from localhost ([127.0.0.1]:59372 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMity-0000vx-OB for submit@debbugs.gnu.org; Sat, 13 Aug 2022 00:37:34 -0400 Received: from mout.web.de ([212.227.17.11]:47397) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMitv-0000vj-ET for 57115@debbugs.gnu.org; Sat, 13 Aug 2022 00:37:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1660365439; bh=7Nj3JkaYUsTDxRN+d7Rv2Ln4VRwF/U8xKZ0s3vb9mPY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=N0REFm3GkLecdV/mo/vr8LtJbq83QUzgU5w6myxbbM8C1gDLmoAYCHmIwGwicWggN 7v//oL7xltNf1Fq7QOd5/9Ad9LNdUkPh4s+CGlSyk1MmLFZqpq5bC6dOBh777Rqmx1 UZ5RT+osMUT6L3YM30Czp7Mi4G9xdzTrlNcSzCHo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1N6bCu-1nJSa11Z1y-0181ED; Sat, 13 Aug 2022 06:37:19 +0200 From: Michael Heerdegen To: Lars Ingebrigtsen Subject: Re: bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level In-Reply-To: <87czd5o51i.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 12 Aug 2022 17:27:53 +0200") References: <87czd5o51i.fsf@gnus.org> Date: Sat, 13 Aug 2022 06:37:18 +0200 Message-ID: <87h72goj29.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:dcZEIGI83cqW28TD+RkcHz1sCaVJVwEFZp34RPY1+TAya6AVTL+ Mi1rm9yThcpw8K7gFVAXbEGcpXDWVt8sT7UJLYdC6aIk1zY9Rj/4VWyw0nnyRaUBpgPxJXg rlJsAmaladwRoaF8hiYUVMTCQpc5exC/t0IIECaWbpHd53I8VYnUcHCwXGedRkz5tLh70NW LCm2nehJPh6Gg5BVkqngA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:I8C939vcXnw=:fxeHe2err4cyfmwxMVgVbU vCcWeGe5WT9Ah1AhVABs3ZOpVfRFCcbxiZq8tyQfIUUoRpb8WWjJMwN8PKICh9zQDf/S2ik/E bWEftjWLXk3GJe0CaK7C+P76RNmunln1tAKNaP9UWWk1jzV7gzw0/N/QBoBhZPEf6IET65/Hl Z45Vdtlvt+mctAbmdle1uuWTyCbZidrMHedjXuJyG7S+1WnPGKIyVQeOL6yFPAXJhgOVxXLdA 20zMtmeqQUBVAT+Yk1CDqam4IHfGF5uB/bvuabdOyFYcT4NJf/nwVBzqCAkohhx/sThRhKJJ4 foXix6JGkIKgpjmTEORcaLxjkKZqH45/toXTpoo32GAfMHcR/nkofU1plNbPoJmKMwwhtp3hY zaNwnvtBGycLcuSYkm7ByB7+vGFFJnBCS9lBrq9zmfPMvBhOtHvEidnCauAvkBd8RZ5H7H3M8 CdsR5grgiTSMQkMomgdF1AX+pj+xmGS5TRDcYdnKWOAMPC1tOHF6JtrKxCq4Zhy7gWZ8xdYkJ qpiPOzuVLxnyYL/Z4lcVlLKibgdKEjHu2w7Ye3WLMndA2ZWoBhhxPEJ/HouH18Fa3y1L4zTf/ PHC67WWWHKCSZk5a5Lj4hCK0txzGViED4gDC9XOvvhpkuCqVRjr84Y65AOFZ5gq+YFBaNXZZq gOEjZslCwkr1v6Klf5dFREos9exDtjEFcjy6hijOPZJXBzXFcm+zeoHbqUCZM7RXUQzaSxNyy Ug4yU8a3b9BZXDci0XSmD28r0ZkU7QIPv7spj0/GD13v2CQ2J4cTONoJVsLGGPJ2Ap32sJ5SA SBdcNpeuU4Z+zOwcpi8TdUM32BFwIelWWVVUQ04JviSHTjh9M938oQWl+K4WBQeCauOkdSDwi nTXTwlTsA/s8TvIeP+jH2+V3D8VGmlQ8oSVupYacVrv9MExGg0+fvkyfbYSnAGvtSCV1hpWUd HZZVp2Zggsr6T/7Cwk3KRW3UEi5gUmAWOtN3dzqwF43anoRyiwF0fFVRcMlH5me/WwAvqwzku TgZAWTJAvATKhw2J7ZzY7sVa6VcXwooQWcbOXtb+uRX3VMiwJzyyeJBV9/UzUlYW5xAYSFRSw Gae6bANggsjfaGzglnRk8wQQOxw2PX5MYxnC7Lvk/cRrnx037sXtAWOrA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57115 Cc: Pythonora Nybon , 57115@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I'm not quite sure what this code snippet is attempting to achieve, but > it does hang in Emacs 29, and it didn't in Emacs 28. > > Adding Stefan to the CCs; perhaps he has some comments. The `commandp' call is what is hanging (or taking extremely long). I guess there is a tree-like recursion of `commandp' and `oclosure-interactive-form' (recurses on advice--car and advice--cdr...?) - just guessing. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 12:06:49 2022 Received: (at 57115) by debbugs.gnu.org; 13 Aug 2022 16:06:49 +0000 Received: from localhost ([127.0.0.1]:34933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMtey-00055f-RM for submit@debbugs.gnu.org; Sat, 13 Aug 2022 12:06:49 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:1841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMtew-00055Q-7H for 57115@debbugs.gnu.org; Sat, 13 Aug 2022 12:06:48 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6233980796; Sat, 13 Aug 2022 12:06:40 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 4641D802A7; Sat, 13 Aug 2022 12:06:39 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1660406799; bh=hwZIni3X0OIBj/mVYYGjpljQSGw7Om0F2otlOva24JY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RYICYdjlJ4k64jcrEL498/uZiUcXchsjhD5FcJDMeJ5kU/gtCFzVLiRBsNZTqNpcJ RGDWiIHfRBlsOgynUczoPVp1OTnZTI2TffUhMIVfGPIjzr7tRR/6YmCCQ+s9zy6OyL K0A3BUWhY7hldwusr+7sDU66An8P0hFcg04VmRUvGLDZJgWSAgXn6uYuz+1JcWENGB DuYCegoS7niELDtNpJRv6JcQ/4QZ2XMNaQWt2ukBZ05LcH1rBpC+ZWuxIaHY+CbABf HF3CL12GX3H5gbdktsyF4z2uKb1MeBjDIm5IgF7QfBY6DOsysnzY8GZBvmkLMsole+ uCM2g4Hf1Dl6w== Received: from pastel (unknown [45.72.195.111]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 19622120480; Sat, 13 Aug 2022 12:06:39 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level In-Reply-To: <87czd5o51i.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 12 Aug 2022 17:27:53 +0200") Message-ID: References: <87czd5o51i.fsf@gnus.org> Date: Sat, 13 Aug 2022 12:06:37 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57115 Cc: Pythonora Nybon , 57115@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I'm not quite sure what this code snippet is attempting to achieve, but > it does hang in Emacs 29, and it didn't in Emacs 28. It doesn't really hang: in my tests it takes ~1s for 12 pieces of advice, and 3x slower for every additional advice, so it should finish in about 2h :-) Should be fixed on `master` now. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 13 22:02:37 2022 Received: (at submit) by debbugs.gnu.org; 14 Aug 2022 02:02:38 +0000 Received: from localhost ([127.0.0.1]:35458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oN2xZ-00053k-Ix for submit@debbugs.gnu.org; Sat, 13 Aug 2022 22:02:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:56900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oN2xY-00053c-02 for submit@debbugs.gnu.org; Sat, 13 Aug 2022 22:02:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN2xX-0000ny-Rq for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 22:02:35 -0400 Received: from mout.web.de ([212.227.15.14]:40563) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oN2xW-0006fE-6y for bug-gnu-emacs@gnu.org; Sat, 13 Aug 2022 22:02:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1660442538; bh=ZPZxeR+zoUkjtcbq7hTgJ0WtUWfJBVc8U1Drt7ossOU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=LOcSDLFV9it8SGWh7U73WU/E5KzyiOMqU4/7uajADdmLokBW6fGhFKBIXMI4BvVOi iwOIpR8s4mQHepHUgcVrafmggKctpgR2uL7IRU6Q1v8uBvOE1aOC15iPuRkgYIxFiH cb8GHDyabVStdXa5aU1sqVe9F0mUnX0SanAckS3E= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MvKbd-1nWanD1zmr-00qyID; Sun, 14 Aug 2022 04:02:18 +0200 From: Michael Heerdegen To: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Subject: Re: bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level In-Reply-To: (Stefan Monnier via's message of "Sat, 13 Aug 2022 12:06:37 -0400") References: <87czd5o51i.fsf@gnus.org> Date: Sun, 14 Aug 2022 04:02:14 +0200 Message-ID: <87k07boa55.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:IF4JhmsWPF9Xt3Euulu1hZR8iTswYSlFebvTIcMhGEGn1aTdMvW Jk4heXP76MrTsomhdAKj8ddg90jiL/4+t2sNRpTkebx634QFUIS4wTPwMbnlVv8yLM70D/1 1f+h9UAIZiqku616xdQj0CWsrkeTcBXV8o3u25P4RuFJkbOSruFjDaJIsiRawd6m3X2Hm9P dv3At1qHoXHCRVp3bnYLw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Lvp9IhSeZcU=:AlbtBjtsD4c1o1fYLnmDjH roo5FFVYQUGIvL7pfeDI6EMZygQYlXnkIthicW7Q8VK7NcqwJNp7ULlobGA4Fx5BiqLAHwodA yGYxxjYuUGGP8Hbv+PZgsBsrEe6dfi1gAzCw4MbtlLW+/bHUNldHHnoGI/fxhBXB55gMxpuKO UmVSQg75fz+tK474o+wImoxp/6LrvzYZUi4Wk9gnRvk5kphQZx8gZtLrFzeKTUi3FK5MWYh1g Efh+nKMsQL/u1nBTb+e99LOCgb4SM3v0YRN10dE/QV5UWe1wZlKPBmzFi5vs1VUH4/jLdQT9/ aUvAOfuy1DGXcA579uyB0R0IBATahUKTkLq4I6dEjgj9I89t00lCZptKrLqolMRGXSED60yhW fzoXZiRwuTF0zHEkiDzdk48gJY6hR6A1NAX8XZarVF2H4qx3BW3C3xQHQTuDqHR8U0Ec3kdWZ wEE+wciXjyNwp7IFQKUjGKmbVnim2LwmN4adfvDYL5cUGCZS1SOIVr8KIupXpi4xqKljg5a9u Bufj2+YWMLz3F+v6/oagEC9HzzYQDlvh6kcJe6qRqInNZSkE+JcW+jJ2sRvfVcI253aBv2jJe h3sf1ZqAV6VojQhqBmr/SuM7fxl9vRKzMpSbEo0nVrS4RGKhIPgwOwKSnFTE3zS/8xpyaxTq0 Nj17Grc1ZPbBtJbHDq2f4Dbo4qeYmkyvHawIYE4D7JziLol4WehIL7NVTti+eixQmEkJ4xN7b yT5gMWt70FD1k8QtfYeHieO+MZWAPJx9I1CTDYS4bgyvd8d4/M540HZq/Cwi5uCEFmv9QEvnW aRYH+2fPjCNzId8ZSRvK1MG7dezyQkxVuqsvfvVWaIIRSDJJB4Ri9TzSBRaV4wyFEuEhgeabb YY/NlbFHZzH2nUdSqJU+yxOFXMLBzvKQ6afhfAU3ClgnQSzy0UZ17oW63zgE6PVP3WmQrzjGz rkGWcGdHQ2WfPkTfertAbe4ifnlif7jtR0G3B7LTjF4vD5lPgtNnXXkgIeTdNcQx/F1K3lKV0 8XebRMlvX3GI3ZlS/nFdPlCct1WVMaha18A1e4KMSV6fkM6Kfih2chZgn20Vv3BzDY9dxLpK0 l6UnDqpYt7yerPNtdxT4fqfRP+4AzkClvQRZqnD/0fb6yYusY6Aku6tXQ== Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=212.227.15.14; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen , Pythonora Nybon , 57115@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Should be fixed on `master` now. modified lisp/emacs-lisp/nadvice.el @@ -167,31 +167,31 @@ advice-eval-interactive-spec (defun advice--interactive-form (function) "Like `interactive-form' but tries to avoid autoloading functions." - (when (commandp function) - (if (not (and (symbolp function) (autoloadp (indirect-function functi= on)))) - (interactive-form function) - `(interactive (advice-eval-interactive-spec + (if (not (and (symbolp function) (autoloadp (indirect-function function= )))) + (interactive-form function) + (when (commandp function) + `(interactive (advice--eval-interactive-spec ^^ That function doesn't exist...? TIA, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 14 09:20:09 2022 Received: (at 57115) by debbugs.gnu.org; 14 Aug 2022 13:20:09 +0000 Received: from localhost ([127.0.0.1]:36212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNDXF-00045t-75 for submit@debbugs.gnu.org; Sun, 14 Aug 2022 09:20:09 -0400 Received: from mail-vs1-f53.google.com ([209.85.217.53]:40824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNDXD-00045Q-69 for 57115@debbugs.gnu.org; Sun, 14 Aug 2022 09:20:07 -0400 Received: by mail-vs1-f53.google.com with SMTP id q190so5030817vsb.7 for <57115@debbugs.gnu.org>; Sun, 14 Aug 2022 06:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc; bh=2Ct4g7o1ZjB3wCrWxGcEPVBGKYzVFRs9qpwiQDclXCE=; b=DoYDtzRwgFY6g+ZOC2nzMwlvcSQfd0Tj6WUv/ybMUZEyU790n8DLMttt96LWKdVBoN R1NZwFGn0VB8MDk+PZyfwXgNvt8D5GIGTgUfaUrXamItetHcveMHj+qeSgV9sbYwHA8u dz1tfYT47cCmjKsf87PF+09z3OuA0a1lPYIa+l6b5Dg8LVaefPiryu4ebezvvVQex5hm SC1w3YgpHEv2tb6D6AQ75NZBhpOJvbrYBltkXTuITxv5YCF/88Nwxi41Yr77uclz8y9O 1CjAuD+m4rcxsxBWKhs176tNo9tD+fFEHMosrFrre0+8a55/4Bgx62pNUyXq2J27EwwU 1HoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc; bh=2Ct4g7o1ZjB3wCrWxGcEPVBGKYzVFRs9qpwiQDclXCE=; b=ifThd4Q4DZAP0N1B2VNue+qMcggSk0VwOlPOUVTqOuHdx6QC7BP2v7FvsdFdXvesek TqEfp1pyCThUeS9UXmXEsvA5PhlicxGyvaaMRb/GlZx9THL91vLEsTaIVhCf3GT5sSNM gFrmZtHjA6cKtDvsGGiNQx/hg6hzUtQn6qAvUTUlg/bp07+w8cup2yXpP3//0zgOYlf7 q1tvzKOL/HSRYEG4N+Vs2OjpQxtXatvW0a9AlEA3G/CdH+RrLp2RQTWUxAWZ8sOarxel D5R7nuq2zH/H1oArC1VIHGHvFmlFUCxpbv5AmaA7WxHGdTurGuHxFZSGtnRGaTI2U/Qk us1g== X-Gm-Message-State: ACgBeo2Q/vfjMLju+wqYqlJG3JjjPBCpd8E7FQJXnfK0xCmc6xMjgwX4 7nDZBBV2S2kUXBWhZGjye6n4Xtp5CYBCALyGdjo= X-Google-Smtp-Source: AA6agR71ABv5T8Ey4kNGi5FcquCVov/oySxP97uZaiGCY3BBdhsfRZdoKiXHPHJMa86cDFWUfvx1KCChQICiT/hNUeo= X-Received: by 2002:a05:6102:2387:b0:34b:9f6d:10da with SMTP id v7-20020a056102238700b0034b9f6d10damr4868916vsr.28.1660483201556; Sun, 14 Aug 2022 06:20:01 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 14 Aug 2022 06:20:01 -0700 From: Stefan Kangas In-Reply-To: <87k07boa55.fsf@web.de> References: <87czd5o51i.fsf@gnus.org> <87k07boa55.fsf@web.de> X-Hashcash: 1:20:220814:larsi@gnus.org::jH8W/zwxb4SPAf4f:Egxo MIME-Version: 1.0 Date: Sun, 14 Aug 2022 06:20:01 -0700 Message-ID: Subject: Re: bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level To: Michael Heerdegen , 57115@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57115 Cc: larsi@gnus.org, bmsac0001@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Michael Heerdegen writes: > That function doesn't exist...? This seems to be fixed in commit b93e14fa0f. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 14 18:53:53 2022 Received: (at 57115) by debbugs.gnu.org; 14 Aug 2022 22:53:53 +0000 Received: from localhost ([127.0.0.1]:40035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNMUT-0006tX-3A for submit@debbugs.gnu.org; Sun, 14 Aug 2022 18:53:53 -0400 Received: from mout.web.de ([212.227.15.14]:40063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNMUN-0006tF-Jw for 57115@debbugs.gnu.org; Sun, 14 Aug 2022 18:53:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1660517618; bh=6JsUpTJLDpPTDhr1RgGCVVcTy9THBLPv6LMhyuv5rWA=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=aI3/Mhd8W8VrPhhf1xsdCqzGLxpAVNvxVEYagVy5IGZiOjBKFz4I5mLzvVuKYFojB 40mac0QYmXIS33zL6OJbTzwexVKW3MwaR5ApEstkJ7E/xiemGoPjxCmYU6QDfgDLOh Q0DI1KSZ9YbDF+LX9zZKdowCsJTTgBSgL7kAsrNI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M1rTQ-1oL9Z33nQG-002epo; Mon, 15 Aug 2022 00:53:37 +0200 From: Michael Heerdegen To: Stefan Kangas Subject: Re: bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level In-Reply-To: (Stefan Kangas's message of "Sun, 14 Aug 2022 06:20:01 -0700") References: <87czd5o51i.fsf@gnus.org> <87k07boa55.fsf@web.de> Date: Mon, 15 Aug 2022 00:53:36 +0200 Message-ID: <875yiuh1xr.fsf@web.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:WaIteJd+3e7JnAAVCaHPB9Yq8Al9OAOzout04sti1Iqz51Zm75F FySzrKKNICr/gtVL89RpFwV9VgdKl2kAZ4iii3R1qrIBj/ppUneK/7gPbHVAMUcHg+Mohcp HwL1ee0O5zJCBMpUY27qVFoYlmJk25pD6DIVqkLz2XnNiApBuanv0gLZqVQJmhXcfrxRsEp Y8cHeLNuEwQ7sdjV9ckSA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TmZl2a9qU0k=:ZKxCSLvxcMedDeYCrJAEF9 4QtIJB4rJ10RnJgfMjda2hHAw0+5jzO7UhfzVRaRi4EP+sepPteK3Ok6kIh1LXKvT4ADIAcXL h1NLE5dVmKPbTP/Vy5jNvnvmY7Ws6qnVZM3C3DYWRFoDJndkMbRVn4QWh6uA1Y+3ZVzPCI72a Qo/tvgYmqPDEXPnzrX8knLvxqlD5dGASruSf9NEUIxd7TaE7xHQVp5qL92TbI2fQK8QNRRObo Tv2Jcb5rHJjmTH6XoGQ9eVutqdaeGtrnR6n/R+0TkhJMAyIdJZtOnx8XF341m7LMIghB8P5Xy HOYTDr++oeMZOtsmeLn2pJd8IiJVREyxJbnPFvzTwTAS4Xmn8lbnfTmKmYYINkRHePF1iqR/V 8AouZxVTLcjnJ584UW5gCKjiZO8TVnVEbPBJhuz/ZNQbcon4t3u6doQJjHrm+KjKTPRqTI4/0 Xl0MRWJ2Av9KepIQ3tK2zQPGMPtAbQt676Zf9/9znFkp8kpAQvWrsgpzNLpjN+n09SsmGe8w1 GMcnJse4mEcMGJNzgidOM9badYAxdSZ6rfGXhf02dCjBouReKjBMqWweQKepwMr016bZsCDUm bHYwWSQAYeubFLm770R9CsEyXxN+6RK/ZY03pEcNe9cz6qLZpc98K+Y8uBa8+11+z5sKhG7SH jBGjP8RUZk0o0PLs+zI1FTm9iEPAiXSpDrmjqke33fm8FEtvI7QfqDpMeDNdJ0yJ2+cwpr+kU DDjKvbMKAxsyzwgYYYF2/W4TuIGsDvbC8wr5gSQp4mP+V7gPBGsehLfquSGMBPUsYnDW+xshp 4wIRkvPmSoZ4WcfsiQ45qr1alD86xZZ3yT0eZCo4qxOW/bCO4OCy0h/x7d6B1EI3CR2bYhK8z amGAKHW7D5215UMo/859Nl4tzjBlWdycYOs0E1M9PspMYKkILQvgY48BAnIW+Gl4rP0ERBImT Rn1lhUp7zlXPbzkI3g6Ouh4ZaD3O8wArJhHqlAb2azVbIG8u/VAv+WGyosRCYj0cQldDdb94v X28RRSsMI1V/1YjPnwKLPPmGaY7cCeT4b72zwtVGVyylZVRasT58GuPQdNnWFb439XXupQ7to ZPI44x88iluN7ZgbmsVEzGD86N43vTlfCPzfry0W2VnQJRGPMPN0+L5Bg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57115 Cc: larsi@gnus.org, bmsac0001@gmail.com, 57115@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > > That function doesn't exist...? > > This seems to be fixed in commit b93e14fa0f. Yes, it is indeed, thanks. Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 15 10:29:13 2022 Received: (at 57115) by debbugs.gnu.org; 15 Aug 2022 14:29:13 +0000 Received: from localhost ([127.0.0.1]:43773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNb5d-0003Lu-8h for submit@debbugs.gnu.org; Mon, 15 Aug 2022 10:29:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNb5b-0003LT-OX for 57115@debbugs.gnu.org; Mon, 15 Aug 2022 10:29:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rqxWCa+CgSwqR0as+aKPkmbYPrDUtfHtKHDTfHt0U2U=; b=QYE2QNROCME3+walc+BhAWO6I0 tZsOBH8vxb1+XCQDsIhMRMqVMHqU3EXDyHnT9LtnhG+twrl5/sxv5k94sd8ra784tZqTWrpfy7OZq eelb2F4gIJpfEdkbIgbV67RVOuPoAekRKKlsf6+OgdGQLWkyaxN/SaUk1BwJOTL9f9yo=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNb5R-0008Lg-Oz; Mon, 15 Aug 2022 16:29:03 +0200 From: Lars Ingebrigtsen To: Michael Heerdegen Subject: Re: bug#57115: emacs 29 ~commandp~ check function ~find-file~ loop without termination while ~find-file~ is adviced nested up to 20 level In-Reply-To: <875yiuh1xr.fsf@web.de> (Michael Heerdegen's message of "Mon, 15 Aug 2022 00:53:36 +0200") References: <87czd5o51i.fsf@gnus.org> <87k07boa55.fsf@web.de> <875yiuh1xr.fsf@web.de> X-Now-Playing: Fontaines D.C.'s _Dogrel_: "The Lotts" Date: Mon, 15 Aug 2022 16:29:00 +0200 Message-ID: <87a68537ir.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Heerdegen writes: >> This seems to be fixed in commit b93e14fa0f. > > Yes, it is indeed, thanks. And I can confirm that the original reported problem has gone away, so I'm closing this bug report. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57115 Cc: bmsac0001@gmail.com, 57115@debbugs.gnu.org, Stefan Kangas , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Heerdegen writes: >> This seems to be fixed in commit b93e14fa0f. > > Yes, it is indeed, thanks. And I can confirm that the original reported problem has gone away, so I'm closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 15 10:29:17 2022 Received: (at control) by debbugs.gnu.org; 15 Aug 2022 14:29:17 +0000 Received: from localhost ([127.0.0.1]:43776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNb5h-0003MB-Gq for submit@debbugs.gnu.org; Mon, 15 Aug 2022 10:29:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNb5e-0003Lj-6T for control@debbugs.gnu.org; Mon, 15 Aug 2022 10:29:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cacAkpcKkwqcwGG+y76LDL0HDYCl8/VhDkM2B8PabP0=; b=qLVQcQuR191/NA+gccHjO0MtUB CaKzhXExAs6ntZmTCbH0ohpr7sn8+gHil0BEDwvhZmLBLdGkQXZAwD32kAftg5iz5BpMhjpssewVC vT+furl6R7O+7sDwdqTFRCWsCoqdXD4J27ue/fmSNPn3mc7pqyPtWm1eC5qSrMb6ewq8=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNb5W-0008Lq-A1 for control@debbugs.gnu.org; Mon, 15 Aug 2022 16:29:08 +0200 Date: Mon, 15 Aug 2022 16:29:05 +0200 Message-Id: <878rnp37im.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57115 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57115 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57115 29.1 quit From unknown Sat Aug 16 12:45:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 13 Sep 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator