GNU bug report logs - #57100
29.0.50; Restore using view-mode in NEWS buffer?

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57100 in the body.
You can then email your comments to 57100 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Restore using view-mode in NEWS buffer?
Date: Wed, 10 Aug 2022 10:07:00 +0200

[Message part 1 (text/plain, inline)]

With the new emacs-news-view-mode is there a good reason not to use
view-mode when reading NEWS, as was the case through Emacs 28?  I find
it particularly convenient to type (S-)SPC to scroll and `q' to bury the
buffer.

[Message part 2 (text/x-patch, inline)]

diff --git a/lisp/textmodes/emacs-news-mode.el b/lisp/textmodes/emacs-news-mode.el
index c7fa9fa2b2..bc2f98a63b 100644
--- a/lisp/textmodes/emacs-news-mode.el
+++ b/lisp/textmodes/emacs-news-mode.el
@@ -94,7 +92,8 @@ emacs-news-view-mode
   (setq buffer-read-only t)
   (emacs-news--buttonize)
   (button-mode)
-  (emacs-news--mode-common))
+  (emacs-news--mode-common)
+  (view-mode))

 (defun emacs-news--fill-paragraph (&optional justify)
   (cond

[Message part 3 (text/plain, inline)]

In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.17.6)
 of 2022-08-08 built on strobelfs2
Repository revision: f1f1912658556e2f2a39cdae0da7ea2b8564d861
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Linux From Scratch r11.0-165

Configured using:
 'configure --with-xinput2 --with-xwidgets 'CFLAGS=-Og -g3'
 PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG
SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM
XINPUT2 XPM XWIDGETS GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Message #8 received at 57100 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: 57100 <at> debbugs.gnu.org
Subject: Re: bug#57100: 29.0.50; Restore using view-mode in NEWS buffer?
Date: Fri, 12 Aug 2022 17:45:00 +0200

Stephen Berman <stephen.berman <at> gmx.net> writes:

> With the new emacs-news-view-mode is there a good reason not to use
> view-mode when reading NEWS, as was the case through Emacs 28?  I find
> it particularly convenient to type (S-)SPC to scroll and `q' to bury the
> buffer.

I've now fixed this in Emacs 29.

Message #13 received at 57100 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57100 <at> debbugs.gnu.org
Subject: Re: bug#57100: 29.0.50; Restore using view-mode in NEWS buffer?
Date: Fri, 12 Aug 2022 18:22:43 +0200

On Fri, 12 Aug 2022 17:45:00 +0200 Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Stephen Berman <stephen.berman <at> gmx.net> writes:
>
>> With the new emacs-news-view-mode is there a good reason not to use
>> view-mode when reading NEWS, as was the case through Emacs 28?  I find
>> it particularly convenient to type (S-)SPC to scroll and `q' to bury the
>> buffer.
>
> I've now fixed this in Emacs 29.

Thanks.

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.