GNU bug report logs -
#57087
29.0.50; (face-at-point nil t) does not return all faces when hl-line-mode is active
Previous Next
Reported by: dalanicolai <dalanicolai <at> gmail.com>
Date: Tue, 9 Aug 2022 18:56:02 UTC
Severity: normal
Tags: notabug
Found in version 29.0.50
Fixed in version 29.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
Eli Zaretskii <eliz <at> gnu.org> writes:
> Yes, probably. However, "return the first one" doesn't tell which one
> this would be. Also "character has more than one face" is inaccurate,
> we should say "more than one source of face information" or somesuch.
Yup. And `thing' is an unfortunate argument name, since people might
interpret that as the face property should be gotten from that thing (as
with get-text-property and friends with `object').
>> I think it sounds like it would be more useful if it did indeed return
>> all the faces at point instead of just the face(s) from either the
>> overlay or the face(s) from the text property.
>
> AFAICT, there's only one user of MULTIPLE, and that is org.el, so we
> should ask them what they expect. There's always a possibility to add
> a new function, say faces-at-point.
Yes, I think perhaps adding a new function like that might make more
sense, because `face-at-point' seems like a very DWIM-ish function with
unclear semantics (like preferring the `read-face-name' over `face'
property, etc).
So I've now just explained this in the doc string. I think the function
is basically fine as is -- it works well as a prompt default function.
This bug report was last modified 2 years and 283 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.