From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 12:18:50 2022 Received: (at submit) by debbugs.gnu.org; 9 Aug 2022 16:18:50 +0000 Received: from localhost ([127.0.0.1]:44616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLRwQ-0001JS-30 for submit@debbugs.gnu.org; Tue, 09 Aug 2022 12:18:50 -0400 Received: from lists.gnu.org ([209.51.188.17]:34504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLRwO-0001JJ-5W for submit@debbugs.gnu.org; Tue, 09 Aug 2022 12:18:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37738) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLRw6-0005ot-DB for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:18:40 -0400 Received: from mout.gmx.net ([212.227.17.21]:60057) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLRvs-0002H6-2m for bug-gnu-emacs@gnu.org; Tue, 09 Aug 2022 12:18:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660061892; bh=r6LTtcZSuFexKr5AfdUKXLY/5jnQO4Qj9VUoThzr5N0=; h=X-UI-Sender-Class:From:To:Subject:Date; b=Su16gIYJK4G3PiHvlsOe9X4EPKcN5B2ItxH933DYYGvVwiGuRlqxmtBtq7hUW8UGL ufg82h1y6IixLMnx4ZeDR9wx0ApVTiXNRmRM6S9VheSnd1lef3jIbVuq89ZtBjyU3H 5sfMP9h0BNzc0r2YFUAkcti04IA5PM3mTLinE1q4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs2 ([89.246.38.154]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mk0JM-1nfXY41ivo-00kQZp for ; Tue, 09 Aug 2022 18:18:12 +0200 From: Stephen Berman To: bug-gnu-emacs@gnu.org Subject: 29.0.50; emacs-news-view-mode breakage Date: Tue, 09 Aug 2022 18:18:11 +0200 Message-ID: <87zggdxuf0.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:Jr1Vk6/QT8dYyjgi7VOCJdcMTMNTxt2JEYyOHr19jPwSIdJWfX7 k4OQ/2P07fW0I6+A/mTh+mpE5tIKl5Uo+HS8wqRzNyqsEmg5XK+rbzZZaxGT0UaIV9ZJEKZ FVKnpylI4966xlSWi15aNG8YHcUQHYwPgJgq5eSiQgWqjOs3u30sU/p0dnVu1GZlA2/BBPc ttjuxLHfD05FHONY49wtA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:TgUhaWPLbyM=:Od6O8MPMUfK/1QHeGzR9sa vQ9i76UWzRd7zavuRluWD6a+pMFDIqk7712d5a3YAhzoKYm2L+xqPx1YlAzXdBp3ppesj96B/ k185ASDw3f/h6wVZdviHLBpFhJiJ63wgnrW9Tr5EzpKLgzL5MmVA9/taP0UhT3y6ybGnk8cAG paSrfj2QgQiGa6UU+XdbykiDwEZg1ymFL9hEzrHwny+1b2s1sV3YFdJ0CHVmXNTfzMqA3oGwd QpZmmUF0PIo5bRs0M0wd23mcXUw0TO4QuvBXnZ9Mg6Uel/NSL0MYi5O7gyhlDb45u/rK1PEJe y24H5WbGlm3+FGYneTX7HXSwZMLimUVzvxWrJWYHTQkMcpUYYdx4VXtEc1Lm7H9JQEdNgN2R7 Yz3hL2GBEiP8B28FC9qnWA5v7eIgn335bjgIm+M5j+picQ7cBGCKAYLjBP9o0XHdc/s1B/n83 6/V81fxATtZMPQupfL/5ze4eMaR/qFTCKY8BBr/gKvWwZcpcQLE9rEE/ASMw36QnSsLE1MUqq wZGLK2UL98CXRs6j+aq0sbgz+JUQQjbPUd/RTKOrBkMzymKVrGgowjFjbXBJ7O4WCGAXK4LVQ FBCYdUP35qOKVn22MfW5Ylj48W1mWC7SitbIxdLUn6kE+HtdcSKwTTGUZ1PCyIHYi8L2M7DKD jrJy5/xyPDYa1k8rg9oLB/tJqU1MiSpTHuN+20UxAVaUP9bU3HnzkPm2wVkWWmR9DlF6mOM/h ne9MmJ5M0yy/z4UA2PCpQ9oAclOhTFxeSznWWFd/YiLZFDeCuuTaoIj3ik4tKq3RP83yKLS8h 50LjbgwNCewF5wAOIItLBM9VbHlpClNj0tYIuoMco32iuX4OLE7U8djpN4MPmY+vKH+JSsHlC 2bIlkfeq2aRJ2efUQOrce4mrHbOrzeBqdWUuHpzi38UV6BuflpM6eVa8H8G6G0E+F2GFgOIhZ +ED46jYd5ENfuJsdBLQnhZJlJgJjZdCWClKp80d6Hkp1fUCHW6zOdk2eBJkUxDGAqidW+Yh1W fOs/VYvLm6BFd/q0t+Bs9dV3ZszL/oXcoSQACGL35UrycX8TX58ksvvP13f3/O84qubBUKYBA mI9pPgMQ8JMLvnl5M4vjQjPn41Isy6ABU/5gQ+NItr/qajE/WpET+cazA== Received-SPF: pass client-ip=212.227.17.21; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain 0. emacs -Q 1. Type `C-h n' => The NEWS buffer is displayed without icons on the header lines, although the value of `outline-minor-mode-use-buttons' is `(derived-mode . special-mode)'. 2. Type `C-c C-n' to move point to the first NEWS header "* Installation Changes in Emacs 29.1" and then type TAB => Now there is an outline-close icon (emoji) at the beginning of the header, the header has lost its first-level fontification and the NEWS buffer is flagged as modified in the mode line. But instead of hiding the current header line's body as per outline-cycle, there is no other change in the buffer. 3. Type TAB again => forward-button is executed instead of outline-cycle, indicating that the line with the icon is now not being treated as an outline header line. And typing `M-< C-c C-n' now puts point on the first second level header below the line with the icon. 4. Move point back to the icon and type RET => The icon changes to outline-open but there is otherwise no change in the outline structure, and the message "Before first heading" is displayed. 5. Type `C-c @ C-q' (outline-hide-sublevels) => The outline-close icon is inserted at the start of the second-level header below the current line and after the icon only "..." is displayed, i.e. all remaing text in the buffer has vanished. Repeatedly typing RET toggles the icon between outline-open and outline-close and displays the message "Before first heading" but the text remains hidden. (Typing `C-c @ C-a' unhides the text.) The attached patch appears to fix the problems described above, but the only buffer using outline-minor-mode beside NEWS that I've tested it on is *Help* showing the output of describe-bindings, and the seems to work as expected with the patch (and due to the patch is not flagged as modified, though that isn't important for *Help*.) In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.17.6) of 2022-08-09 built on strobelfs2 Repository revision: f1f1912658556e2f2a39cdae0da7ea2b8564d861 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Linux From Scratch r11.0-165 Configured using: 'configure --with-xinput2 --with-xwidgets 'CFLAGS=-Og -g3' PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM XWIDGETS GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Description: NEWS + outline patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/outline.el b/lisp/outline.el index 7750f9a75d..35524a79a9 100644 =2D-- a/lisp/outline.el +++ b/lisp/outline.el @@ -435,7 +435,7 @@ outline-minor-mode-highlight-buffer (goto-char (match-beginning 0)) (not (get-text-property (point) 'face)))) (overlay-put overlay 'face (outline-font-lock-face))) - (when (outline--use-buttons-p) + (when (and (outline--use-buttons-p) (outline-on-heading-p)) (outline--insert-open-button))) (goto-char (match-end 0)))))) @@ -452,11 +452,10 @@ outline-minor-mode (if outline-minor-mode (progn (when outline-minor-mode-highlight - (if (and global-font-lock-mode (font-lock-specified-p major-mod= e)) - (progn - (font-lock-add-keywords nil outline-font-lock-keywords t) - (font-lock-flush)) - (outline-minor-mode-highlight-buffer))) + (when (and global-font-lock-mode (font-lock-specified-p major-m= ode)) + (font-lock-add-keywords nil outline-font-lock-keywords t) + (font-lock-flush)) + (outline-minor-mode-highlight-buffer)) ;; Turn off this mode if we change major modes. (add-hook 'change-major-mode-hook (lambda () (outline-minor-mode -1)) @@ -1011,32 +1010,34 @@ outline--make-button-overlay o)) (defun outline--insert-open-button () - (save-excursion - (beginning-of-line) - (when (derived-mode-p 'special-mode) - (let ((inhibit-read-only t)) - (insert " ") - (beginning-of-line))) - (let ((o (outline--make-button-overlay 'open))) - (overlay-put o 'help-echo "Click to hide") - (overlay-put o 'keymap - (define-keymap - "RET" #'outline-hide-subtree - "" #'outline-hide-subtree))))) + (with-silent-modifications + (save-excursion + (beginning-of-line) + (when (derived-mode-p 'special-mode) + (let ((inhibit-read-only t)) + (insert " ") + (beginning-of-line))) + (let ((o (outline--make-button-overlay 'open))) + (overlay-put o 'help-echo "Click to hide") + (overlay-put o 'keymap + (define-keymap + "RET" #'outline-hide-subtree + "" #'outline-hide-subtree)))))) (defun outline--insert-close-button () - (save-excursion - (beginning-of-line) - (when (derived-mode-p 'special-mode) - (let ((inhibit-read-only t)) - (insert " ") - (beginning-of-line))) - (let ((o (outline--make-button-overlay 'close))) - (overlay-put o 'help-echo "Click to show") - (overlay-put o 'keymap - (define-keymap - "RET" #'outline-show-subtree - "" #'outline-show-subtree))))) + (with-silent-modifications + (save-excursion + (beginning-of-line) + (when (derived-mode-p 'special-mode) + (let ((inhibit-read-only t)) + (insert " ") + (beginning-of-line))) + (let ((o (outline--make-button-overlay 'close))) + (overlay-put o 'help-echo "Click to show") + (overlay-put o 'keymap + (define-keymap + "RET" #'outline-show-subtree + "" #'outline-show-subtree)))))) (defun outline--fix-up-all-buttons (&optional from to) (when from diff --git a/lisp/textmodes/emacs-news-mode.el b/lisp/textmodes/emacs-news= -mode.el index c7fa9fa2b2..e6e1f03728 100644 =2D-- a/lisp/textmodes/emacs-news-mode.el +++ b/lisp/textmodes/emacs-news-mode.el @@ -69,11 +69,9 @@ emacs-news-mode-font-lock-keywords (defun emacs-news--mode-common () (setq-local font-lock-defaults '(emacs-news-mode-font-lock-keywords t)) - (setq-local outline-regexp "\\*+ " + (setq-local outline-regexp "\\(:? +\\)?\\(\\*+\\) " outline-minor-mode-cycle t - ;; We subtract one from the level, because we have a - ;; space after the asterisks. - outline-level (lambda () (1- (length (match-string 0)))) + outline-level (lambda () (length (match-string 2))) outline-minor-mode-highlight 'append) (outline-minor-mode)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 14:23:59 2022 Received: (at 57082) by debbugs.gnu.org; 9 Aug 2022 18:24:00 +0000 Received: from localhost ([127.0.0.1]:44875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTtX-0006mV-LW for submit@debbugs.gnu.org; Tue, 09 Aug 2022 14:23:59 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTtW-0006mG-7J for 57082@debbugs.gnu.org; Tue, 09 Aug 2022 14:23:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QpHz+LLVz99vHln7kFXt0EsTh/vQ9p0CX9j4O4Po7Xw=; b=IkBvJSfZygoeeiMGtMYYAGWpyd ZMxuUrn+oCKLGzyEH2ELC5avYkf4MH2K9rM3TaboAqgbqWt5/K6hkhhRHHqEbK9tDHB66ugnoRzhs 1xcQoJLg74Js1fbEYBfAqpPfSDZ7PRbubjliG4Tq50TYQQz1gBQZj3jAPxnP31+rcLQI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLTtN-0006V8-KB; Tue, 09 Aug 2022 20:23:51 +0200 From: Lars Ingebrigtsen To: Stephen Berman Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <87zggdxuf0.fsf@gmx.net> (Stephen Berman's message of "Tue, 09 Aug 2022 18:18:11 +0200") References: <87zggdxuf0.fsf@gmx.net> X-Now-Playing: Oneohtrix Point Never's _Returnal Remix_: "Returnal (Antony)" Date: Tue, 09 Aug 2022 20:23:48 +0200 Message-ID: <874jylwa17.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > The attached patch appears to fix the problems described above, but the > only buffer using outline-minor-mode beside NEWS that I've tested it on > is *Help* showing the output of describe-bindings, [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57082 Cc: 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stephen Berman writes: > The attached patch appears to fix the problems described above, but the > only buffer using outline-minor-mode beside NEWS that I've tested it on > is *Help* showing the output of describe-bindings, and the seems to work > as expected with the patch (and due to the patch is not flagged as > modified, though that isn't important for *Help*.) Thanks; patch applied to Emacs 29. The outline button stuff is still a work in progress, as you've found out. I'm not quite sure whether it should be switched on by default in NEWS buffers -- it doesn't seem to bring much value there. (As opposed to in `describe-bindings', where it seems very helpful (since we're starting out with some parts already folded.) So I'm pondering whether to add an additional mechanism to say whether a mode is "opting in" to the buttons or not, but I'm not sure what that should look like. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 14:24:05 2022 Received: (at control) by debbugs.gnu.org; 9 Aug 2022 18:24:05 +0000 Received: from localhost ([127.0.0.1]:44879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTtc-0006nG-VE for submit@debbugs.gnu.org; Tue, 09 Aug 2022 14:24:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:52474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLTta-0006mN-ST for control@debbugs.gnu.org; Tue, 09 Aug 2022 14:24:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rKgIUGkIb0FUiokm6XTwpXU5+2z7vrGDxo+XV0+0LQw=; b=l3TkaOFSNgJjV8Q3d6aQlkiuyT pV+zU2q5J6z/0zccO55xX2cjfhi1L7I0w/Qn+Bhog+SidURLB95wyCeHZqyOM6oNudg9YukKjINkS 4Fa8OBoBMAhOJdoF3pHjF8pk8RerNpw0qx649RV7RkwNSyf/iO011Mmw/++g4vnIo7nM=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLTtS-0006VG-UN for control@debbugs.gnu.org; Tue, 09 Aug 2022 20:23:56 +0200 Date: Tue, 09 Aug 2022 20:23:54 +0200 Message-Id: <8735e5wa11.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57082 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57082 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57082 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 15:22:23 2022 Received: (at 57082) by debbugs.gnu.org; 9 Aug 2022 19:22:23 +0000 Received: from localhost ([127.0.0.1]:45093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLUo2-0006S3-M8 for submit@debbugs.gnu.org; Tue, 09 Aug 2022 15:22:22 -0400 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:35223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLUnz-0006Ri-Vq for 57082@debbugs.gnu.org; Tue, 09 Aug 2022 15:22:20 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3D28A1BF206; Tue, 9 Aug 2022 19:22:11 +0000 (UTC) From: Juri Linkov To: Lars Ingebrigtsen Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <874jylwa17.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 09 Aug 2022 20:23:48 +0200") Organization: LINKOV.NET References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> Date: Tue, 09 Aug 2022 22:18:21 +0300 Message-ID: <865yj1p6o2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Stephen Berman , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> The attached patch appears to fix the problems described above, but the >> only buffer using outline-minor-mode beside NEWS that I've tested it on >> is *Help* showing the output of describe-bindings, and the seems to work >> as expected with the patch (and due to the patch is not flagged as >> modified, though that isn't important for *Help*.) > > Thanks; patch applied to Emacs 29. I noticed more problems: arrow directions are inverted - when an outline is hidden the arrow direction is open; when it's shown then the button has the closed state. S-TAB (outline-cycle-buffer) is very slow: takes ~3 seconds on a small NEWS buffer. Also don't understand why is this change: (when outline-minor-mode-highlight - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) - (progn - (font-lock-add-keywords nil outline-font-lock-keywords t) - (font-lock-flush)) - (outline-minor-mode-highlight-buffer))) + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) + (font-lock-add-keywords nil outline-font-lock-keywords t) + (font-lock-flush)) + (outline-minor-mode-highlight-buffer)) `outline-minor-mode-highlight-buffer' is intended only for buffers that don't support font-lock highlighting. > The outline button stuff is still a work in progress, as you've found > out. I'm not quite sure whether it should be switched on by default in > NEWS buffers -- it doesn't seem to bring much value there. (As opposed > to in `describe-bindings', where it seems very helpful (since we're > starting out with some parts already folded.) It would be nicer if the color of the button depended on the outline's color, e.g. blue for the top-level blue outline face, etc. > So I'm pondering whether to add an additional mechanism to say whether a > mode is "opting in" to the buttons or not, but I'm not sure what that > should look like. Since outline-minor-mode-use-buttons uses buffer-match-p, it can have any condition, including a condition to exclude etc/NEWS, for example. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 16:19:04 2022 Received: (at 57082) by debbugs.gnu.org; 9 Aug 2022 20:19:04 +0000 Received: from localhost ([127.0.0.1]:45162 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLVgt-0001e2-JV for submit@debbugs.gnu.org; Tue, 09 Aug 2022 16:19:03 -0400 Received: from mout.gmx.net ([212.227.15.15]:33499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLVgq-0001dX-Qo for 57082@debbugs.gnu.org; Tue, 09 Aug 2022 16:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660076334; bh=EOths1oWYU2vdGNTv+SXVecZRqmr2XCXKKpYUllwwPo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=ROXJ/ITIKj5YI4nswIekA69496qMgCDhtcJ3U/xNEhrNPFpAWD3SdXYzCxTz/HnI/ QzIwcGWNBDZpVCyoW2Cia0woVZqFfrq5r9+4dyJS75jl2ErUt1xo9aZ20sULHZmA98 wivFpgJtcUGVLkzC6Zwa//nauJzYIlEqDyQ+d+cg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs2 ([89.246.38.154]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKsnP-1o7Qg72uIX-00LD7a; Tue, 09 Aug 2022 22:18:54 +0200 From: Stephen Berman To: Juri Linkov Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <865yj1p6o2.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 09 Aug 2022 22:18:21 +0300") References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> Date: Tue, 09 Aug 2022 22:18:53 +0200 Message-ID: <87v8r1xj9u.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Y7FeNWA/wxD5uFbOtxQqU0hkdHifhsiVmpF9bQLY3SWmgS1cEwV YbEHUDzwjh8up6VuPoHOYtSWTYJlsZWmy6+Th1a/vvfSoC851BImHqOs6sS5S444RDtrpsl eyzZJbTe7i8SO7nD+OkvJoe+X/55wWtFGfD76Y2HyeFVqrOvk6j+qScpyO92vtv5PvWMGP9 1KTynvzSdJ6/YSxYf908A== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:dF/ha5afKMI=:LRrLFj/nw3x4VcRLsUYh3W POKjt5kJvjQdiovkX/C7fG2valdi7llhnDSuPGYbvz0gTHSipgj1JnU6QueA2YEVqkE0Qccub WUr4HwP/m2mxBOaEToqwrvN+R4rDQCA3ymJP66klvgOOkBx+9VkGSHPpgnX8+u9l0+pEBuWJa DztmPOxwqTOBjxT/M+Xx+Bj9kGcbgfm3ntzN7hog/m/2+3XaDf/LCn897BNufmYnykifVGEDe t64NYAkZbQF1DSq1UqoGG25QbpIKGPDQtIYNYBIJAExGwgdfs+/9DsUyTzT5dftOoIt/3FFKd CGWusLhH/6Gro/UdDgoHw8pL/H+XrDHwZx8h311REPyF1aIodeb1aLdWlwWMzgv2VW6ylWgla 29ERvG2gjEu9IUXe6X+V0988LTyO72JofMSS1FDj6CCVRbnUaZs9yQY9GUudPYOsR3HYsfn6M CYayy0cOXhs9R/yHHaDfGEeK+7KPYz6NOEELdNUZI9ra8ct9H/cuOJtaxOQYXHsM9Bpp/Hd4K JRhfgRwjWIAWjHHh9so4lSX/adMGKqsJfjTxVql1bRFyYKZVfRq5P+hD3EOLHuw41zVQVeMG4 9fBVlCpPuNlWlr0bI0XIcbxOYYwQkeuvyeb6iKNt7+Fku/T3eEAOZW9nFeHJjIhrIYFVSul9/ 64PjbACC2mbc76/owdjclHl2k1jrmJApedL9FEGDQtWOagO5yf0vTis53ZjLcd0bYi7QXySbZ oy9Wivf83mhk/G0SE8kp8Th4SVkE4+pdNeBY97/V6nW+E0GJSQ2u7dtRDNh9WcUjrfua7EnRI qkFYWHKE2yWdQk1EWmO6sB+y/WPQmqqK8orDr2cmBew9FQsEFIdD/0w5SH88QWacGrasyr9O0 unxe+6BJpKZg91ckYQ870/XCaG8M+nIEB2k1qLrBxYt8Os5NJGv299GIL8corqnQ7w83aJ1tk kxCE2952qWNS2I2ONQ3/ahhpTK1KWMARcQak72zHn6EjEAqQDvgd5knV1XSDFuvMNVApSJFHX WtNfHM9bmcPGMqD9rfPCKCj/QTAl18HN5ZMrnFVoR9TaBeN16JlWZ95qJG1u/IVlLjYL4XP/c pDwE0VuZP5cEfGZS+07P/xMvkGzf6eb9dI6ZfxFjRXISUy3nKMsDL8DuA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, 09 Aug 2022 22:18:21 +0300 Juri Linkov wrote: >>> The attached patch appears to fix the problems described above, but the >>> only buffer using outline-minor-mode beside NEWS that I've tested it on >>> is *Help* showing the output of describe-bindings, and the seems to work >>> as expected with the patch (and due to the patch is not flagged as >>> modified, though that isn't important for *Help*.) >> >> Thanks; patch applied to Emacs 29. Thanks Lars. > I noticed more problems: arrow directions are inverted - when an outline > is hidden the arrow direction is open; when it's shown then the button has > the closed state. The arrows behave the same as in *Help* with describe-bindings: outline-close (downward-pointing) when the body is hidden, outline-open (leftward-pointing) when the body is shown. Is that wrong? > S-TAB (outline-cycle-buffer) is very slow: takes ~3 seconds on a small > NEWS buffer. > > Also don't understand why is this change: > > (when outline-minor-mode-highlight > - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) > - (progn > - (font-lock-add-keywords nil outline-font-lock-keywords t) > - (font-lock-flush)) > - (outline-minor-mode-highlight-buffer))) > + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) > + (font-lock-add-keywords nil outline-font-lock-keywords t) > + (font-lock-flush)) > + (outline-minor-mode-highlight-buffer)) > > `outline-minor-mode-highlight-buffer' is intended only for buffers > that don't support font-lock highlighting. Yes, but with that change, arrows are displayed on first visiting the NEWS buffer; without it, they only appear when typing TAB on an outline heading. >> The outline button stuff is still a work in progress, as you've found >> out. I'm not quite sure whether it should be switched on by default in >> NEWS buffers -- it doesn't seem to bring much value there. (As opposed >> to in `describe-bindings', where it seems very helpful (since we're >> starting out with some parts already folded.) > > It would be nicer if the color of the button depended on the outline's color, > e.g. blue for the top-level blue outline face, etc. I guess that would require using suitable images rather than emojis. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 20:03:37 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 00:03:37 +0000 Received: from localhost ([127.0.0.1]:45509 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLZCC-00079a-TJ for submit@debbugs.gnu.org; Tue, 09 Aug 2022 20:03:37 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:45648) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLZC9-00079M-VK for 57082@debbugs.gnu.org; Tue, 09 Aug 2022 20:03:35 -0400 Received: by mail-pl1-f176.google.com with SMTP id 13so11354660plo.12 for <57082@debbugs.gnu.org>; Tue, 09 Aug 2022 17:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc; bh=PK0/IiUBoWHtZGPOT0CymenN2kykTW6rkFga3Dg7Y3A=; b=PWsTnjJGbWWAQeNNjFU5FIFuG89CKAq8kUwIv/+i0qlHRP3MPbqr+2z9EipN1XgfG9 rEvwwV2TppxTeVO4s54BPvVC/sX3D6PkazYZlqxxoMswymuoLHUTpsk7F+aWW2s4NVVM JVtUxXMvNf2tSziNN7lCnxkItK2768dYTCGcXY1pegR2uZtdS2id6v8FF7Z3CgCnnErW 1Hihr2B4uBX+ei4CEnH5irMSUM7NTWkrrvdkHOOoxt93Ogf9q03Rq6XMEiNXXTd4mku1 nsSiJvLBCAY2Qw3kVCoaO6Wd8CnRQxFr/Z1EtB30PhM2Id05VIO9yMnNVxTOCh6hfo65 uNwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc; bh=PK0/IiUBoWHtZGPOT0CymenN2kykTW6rkFga3Dg7Y3A=; b=3jJIgFIrOmscJt78K10m15b5hjG3MEBZrF3Nka5BBk5K4o3gOY+t3mGVG5StYFJ/W6 4E41GTLkfqL5Xg/ucwJz84MHLMSkvRtskTacGRmpajFgcI4Str+lO0J1th9gNKS6yg85 5j2U/2HxiocdrtQNSVXw7aj6mH3RvPjw9KyfeH6vLiK4HpNP1Bkvx+8hFBmx0RwoH+Mu UstIePfRgWZpoa6H0NTseJ88epfbsr4QFOtWoaph+gLJhmoO4kyhHAS84yVyJKngSfrz 0y5d/ir7dFZiL0GZPThmlYVYDNM8irzQ69UUhWl02oe1FLj9dIFwitJykxKfavWxgpt6 /n7w== X-Gm-Message-State: ACgBeo1YInLHsZu5MH3ogOLoa/nKKHQEEBhgtxzuKyTRsKBCf0AslRCQ xuD5ZJYAHkIGvM/Ex+h6+oiY0DdXzLs= X-Google-Smtp-Source: AA6agR4u1vLCaA2rsDYOfKt9oCq+qnq+Svhqbt2C7Hjb91r6zmpPD1vFhcH9Gk4XswMoMn8bVj+zRw== X-Received: by 2002:a17:902:bcc9:b0:16e:fde3:172f with SMTP id o9-20020a170902bcc900b0016efde3172fmr26499370pls.36.1660089808193; Tue, 09 Aug 2022 17:03:28 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id t5-20020a1709027fc500b001708e1a10a3sm7878417plb.94.2022.08.09.17.03.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Aug 2022 17:03:27 -0700 (PDT) Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage To: Stephen Berman , Juri Linkov References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> From: Jim Porter Message-ID: Date: Tue, 9 Aug 2022 17:03:25 -0700 MIME-Version: 1.0 In-Reply-To: <87v8r1xj9u.fsf@gmx.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/9/2022 1:18 PM, Stephen Berman wrote: > On Tue, 09 Aug 2022 22:18:21 +0300 Juri Linkov wrote: > >> I noticed more problems: arrow directions are inverted - when an outline >> is hidden the arrow direction is open; when it's shown then the button has >> the closed state. > > The arrows behave the same as in *Help* with describe-bindings: > outline-close (downward-pointing) when the body is hidden, outline-open > (leftward-pointing) when the body is shown. Is that wrong? I think that's wrong, yes. Every GUI I'm familiar with does it the other way: > Closed Item v Open Item > Closed Sub Item This is the visual style used in GNOME (at least, the theme I'm using), MS Windows, macOS, Firefox/Thunderbird, and probably others. More importantly, it's also the style Emacs already uses elsewhere: see the Customize UI. The only other style I've seen is "-" for open items and "+" for closed (because clicking "+" will *add* the children to the UI and "-" will *remove* them). Emacs does that in the speedbar, for example. >> It would be nicer if the color of the button depended on the outline's color, >> e.g. blue for the top-level blue outline face, etc. > > I guess that would require using suitable images rather than emojis. Images would be nice; Emacs already has some for the Customize UI that could be reused. For the NEWS file though (and especially programming modes). I still think it'd be great to put the buttons in the fringe. That way the buttons would never disrupt the contents of the file, e.g. by changing how the indentation looks. However, describe-bindings probably wants the buttons in the body, so this would be yet another option, which adds complexity/maintenance burden... From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 03:55:48 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 07:55:49 +0000 Received: from localhost ([127.0.0.1]:45897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgZA-0006fz-Hh for submit@debbugs.gnu.org; Wed, 10 Aug 2022 03:55:48 -0400 Received: from mout.gmx.net ([212.227.15.19]:55195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgZ8-0006fn-I5 for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 03:55:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660118139; bh=tbXyqTNz/ea2kq7+zaurNlnaNZyMrCrMfiMekudVNDo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=hn6VyfGpq8rgJPYivxYRrBaLoYIbqSdxUUBDjKLeJ2bl/uLVSuM8HEfdd8EhcgnqK o0cRNmSMeYIFNTXt087azKQH4oWOUo6+8InBLN//uYqV87mH2fWwQI//CG4jum4AK6 lpkuAVhIt96C2yQO+1ESaX98f8E1eXqaUUrt2ME0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs2 ([89.246.36.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MzQg6-1nQZjP2YYS-00vOTD; Wed, 10 Aug 2022 09:55:39 +0200 From: Stephen Berman To: Jim Porter Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: (Jim Porter's message of "Tue, 9 Aug 2022 17:03:25 -0700") References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> Date: Wed, 10 Aug 2022 09:55:36 +0200 Message-ID: <87zggcwn0n.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:opEmQsJ31PdZTycppftO7ySE1AyNVqX76xmh23kQcSjZOpA5KL3 0Z/ws/MP+0lwoQZX4lMNe6bwiCgcA8ZY0ypyqgSiJ2MOAtgnD7JBKESMWD+WRxWoFQh4PD4 j5LWjjf2Ast41oNP94GwmCAXPdnksxM2H/WON+TjCtsUw1VjEKLrUX5n06dbRJQD9NP+M76 yxEPZQ/U+lJnxP+b5Dd3w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UfzcLmLz/Qo=:DuSqqz1lrqxFlFxlGixBCN PtdTy+E2D9Hq10dEO5tfVucNCZl5sfOyiH4T+vN0sxg8uNSvBN6OdG2uWpXRwXGZ3v9xKq+bN 9s+/cBmyXbEfVAsA7Sc1pcY5B47h8POgWHZu/bt3Bdvupqz1ftEIX0lWyNRhxc2ulVetBetqb kqd+BhZWYMIzHNL+/cUVFoaSsA/LelPltYSR1mwvWftooqiNWNEBcC73m04WAuyKSlKQM/mhj simSsThfAw9hRkfbeM1ijvomowRvbTszIFi3bR4nge3fwgE9VLc/yQ5j+HxBZ+BGIFICZ4HXo wWWBUhhxXUcq8BOk7rPPfQafgw8GxDdaoshtpa58DGLACMeUjDX+IK22jIecJOD/QHqhriTmw zQRKnsVyMQ3AgPNbn5+zRZMGY2PW2CKE9Lg1G4JVVO4gJ9HCfFIT3HX4XnFsIqGsYmfg+AF9y MEvSjj63gSc3faxHdXHAxQJzYkBo93qu6stWoXH9wT0Yh3dkno6vx3b1HIX0nm7k9EgNHzWWO 4aNwvI6R5Yu2yJnc8/VvapMPh+w1QSANHZRuzBMZlCeAZVXrUC4ZqTb5Wk5DCm6Dgh+JMcQ96 B+uATb3D06qa3W6hgs/hn9iP+tsqBDekpMZ0V5mEfFCBrYA/ABDMNRw1C7CmZ9O+SjxkY4tBX shhK2x7we7Vp8/1SXeZansUCka50Q/Oy8qcRyuhx0fRIRzr6e6IFNVougrrFE4KU8EbK+ZiA0 LuB4HOWKmWtF23tVt8IL4OT6BR2EBbIscV5TNxunLdciQS1ncLIMikDuYkzzddlXrb3C9w+Fo +yDKOPzdrBsshKbtj5FybNp4JfI7ZMq8g1qV6Enh238j290IyPQfnnOpKKBh9e56XHfXPoHTO WpetA7n0jOF2ES5rbVLa905NM8PgbV4Hld46f81zB+Je2qGjKkYMPgFLU6jm1XyeplU6wYvnf WKO82zJ5cvQD7muQhmXsP9Psyxg033I+O1lhyIBvaIL2oxv5/OsuB+A9eJ18RXuqRpJfwKJA4 7oytFEqNJjRVAYk4JtX131taYKvRUXJuCFiRPxc0qSEmUw7tojdzRp+Es2maiimIdH7UIaklv dHjB1apwXt0PgTZ+E2AFG9t4bNAjwfB9RgctS2kvp1uMRBvWNa7K+Zm7Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, 9 Aug 2022 17:03:25 -0700 Jim Porter wrote= : > On 8/9/2022 1:18 PM, Stephen Berman wrote: >> On Tue, 09 Aug 2022 22:18:21 +0300 Juri Linkov wrote: >> >>> I noticed more problems: arrow directions are inverted - when an outli= ne >>> is hidden the arrow direction is open; when it's shown then the button= has >>> the closed state. >> The arrows behave the same as in *Help* with describe-bindings: >> outline-close (downward-pointing) when the body is hidden, outline-open >> (leftward-pointing) when the body is shown. Is that wrong? ^^^^ right (oops) > I think that's wrong, yes. Every GUI I'm familiar with does it the other= way: > > > Closed Item > v Open Item > > Closed Sub Item > > This is the visual style used in GNOME (at least, the theme I'm using), = MS > Windows, macOS, Firefox/Thunderbird, and probably others. More important= ly, > it's also the style Emacs already uses elsewhere: see the Customize UI. Ah, of course, I didn't even think to look there (oops again). --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Description: outline icons patch diff --git a/lisp/outline.el b/lisp/outline.el index 7750f9a75d..8132043097 100644 --- a/lisp/outline.el +++ b/lisp/outline.el @@ -294,16 +294,16 @@ outline-minor-mode-use-buttons :version "29.1") =20 (define-icon outline-open button - '((emoji "=E2=96=B6=EF=B8=8F") - (symbol " =E2=AF=88 ") + '((emoji "=F0=9F=94=BD") + (symbol " =E2=AF=86 ") (text " open ")) "Icon used for buttons for opening a section in outline buffers." :version "29.1" :help-echo "Open this section") =20 (define-icon outline-close button - '((emoji "=F0=9F=94=BD") - (symbol " =E2=AF=86 ") + '((emoji "=E2=96=B6=EF=B8=8F") + (symbol " =E2=AF=88 ") (text " close ")) "Icon used for buttons for closing a section in outline buffers." :version "29.1" --=-=-= Content-Type: text/plain Steve Berman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 04:02:44 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:02:44 +0000 Received: from localhost ([127.0.0.1]:45911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgfs-0006sI-5f for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:02:44 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:55641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgfp-0006s3-Ka for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:02:43 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 31ED720008; Wed, 10 Aug 2022 08:02:33 +0000 (UTC) From: Juri Linkov To: Stephen Berman Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <87v8r1xj9u.fsf@gmx.net> (Stephen Berman's message of "Tue, 09 Aug 2022 22:18:53 +0200") Organization: LINKOV.NET References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> Date: Wed, 10 Aug 2022 10:36:22 +0300 Message-ID: <86bkssedll.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Also don't understand why is this change: >> >> (when outline-minor-mode-highlight >> - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) >> - (progn >> - (font-lock-add-keywords nil outline-font-lock-keywords t) >> - (font-lock-flush)) >> - (outline-minor-mode-highlight-buffer))) >> + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) >> + (font-lock-add-keywords nil outline-font-lock-keywords t) >> + (font-lock-flush)) >> + (outline-minor-mode-highlight-buffer)) >> >> `outline-minor-mode-highlight-buffer' is intended only for buffers >> that don't support font-lock highlighting. > > Yes, but with that change, arrows are displayed on first visiting the > NEWS buffer; without it, they only appear when typing TAB on an outline > heading. This change broke fontification e.g. in diff buffers that now add outline faces on diff hunks. So we need another solution. Maybe on first visiting the NEWS buffer better to call refontification with font-lock-ensure? From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 04:02:47 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:02:47 +0000 Received: from localhost ([127.0.0.1]:45914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgfv-0006sX-DM for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:02:47 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:59741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgfu-0006s8-0R for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:02:46 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 5BF64100004; Wed, 10 Aug 2022 08:02:36 +0000 (UTC) From: Juri Linkov To: Jim Porter Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: (Jim Porter's message of "Tue, 9 Aug 2022 17:03:25 -0700") Organization: LINKOV.NET References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> Date: Wed, 10 Aug 2022 10:39:22 +0300 Message-ID: <86tu6kcyuh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , Stephen Berman , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> It would be nicer if the color of the button depended on the outline's color, >>> e.g. blue for the top-level blue outline face, etc. >> I guess that would require using suitable images rather than emojis. > > Images would be nice; Emacs already has some for the Customize UI that > could be reused. Instead of preparing a lot of different images, maybe it would be possible to specify a background/foreground color for SVG images. OTOH, maybe easier would be just to use Unicode arrow characters instead of emojis? > For the NEWS file though (and especially programming modes). I still think > it'd be great to put the buttons in the fringe. That way the buttons would > never disrupt the contents of the file, e.g. by changing how the > indentation looks. Agreed, the clickable buttons in the fringe would be great, and it's easy to implement. > However, describe-bindings probably wants the buttons in the body, so this > would be yet another option, which adds complexity/maintenance burden... describe-bindings could override the default when necessary. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 04:08:31 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:08:32 +0000 Received: from localhost ([127.0.0.1]:45940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLglT-000727-JO for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:08:31 -0400 Received: from heytings.org ([95.142.160.155]:46850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLglS-00071v-0U for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:08:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1660118908; bh=0knl738mND7yJu7lk6ZUUjHdU2yHFlEdcmfOJRVXQAI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=Flt2HG9sjwX85I3hIGI8znvvAQpF2kj6lHEhdQNePJm7yUU+PbpABbxgGioRB8+yP 4hbVLtj/Ild0ZoNLNJrCew61f2NQqyAM/FKfjjsonOFC7ELefHJFF1I2MA5l3AeBei nQRR2Ko3gwYiv68tktCuH2gMWlfDs8wSaAwkTjzjzPtJ6OMSHjnEnrsOwr4vyTsvtY 5/1T7sfoO+XJ4x3VPeu2QPlzELv9PSy2JJzNf8mQh04qcGvT/USpdFW2vYhkmrWvQL ITMMI6HufmClj1YUGHrqxrHFSCFDKeNeU3tj1xsbqEoH/FdnUHZnHu8xgmhok8oGYI AGcgGZ5534Dkw== Date: Wed, 10 Aug 2022 08:08:28 +0000 From: Gregory Heytings To: Juri Linkov Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <86tu6kcyuh.fsf@mail.linkov.net> Message-ID: References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86tu6kcyuh.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57082 Cc: Jim Porter , Lars Ingebrigtsen , Stephen Berman , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >> For the NEWS file though (and especially programming modes). I still >> think it'd be great to put the buttons in the fringe. That way the >> buttons would never disrupt the contents of the file, e.g. by changing >> how the indentation looks. > > Agreed, the clickable buttons in the fringe would be great, and it's > easy to implement. > Some users disable both fringes, or only the left fringe, though. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 04:09:59 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:09:59 +0000 Received: from localhost ([127.0.0.1]:45944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgmt-00074F-0w for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:09:59 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:59715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgmr-000742-9t for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:09:57 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 9D714100003; Wed, 10 Aug 2022 08:09:47 +0000 (UTC) From: Juri Linkov To: Stephen Berman Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <87zggcwn0n.fsf@gmx.net> (Stephen Berman's message of "Wed, 10 Aug 2022 09:55:36 +0200") Organization: LINKOV.NET References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <87zggcwn0n.fsf@gmx.net> Date: Wed, 10 Aug 2022 11:07:14 +0300 Message-ID: <86fsi4cyhd.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Jim Porter , Lars Ingebrigtsen , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> I think that's wrong, yes. Every GUI I'm familiar with does it the other way: >> >> > Closed Item >> v Open Item >> > Closed Sub Item >> >> This is the visual style used in GNOME (at least, the theme I'm using), MS >> Windows, macOS, Firefox/Thunderbird, and probably others. More importantly, >> it's also the style Emacs already uses elsewhere: see the Customize UI. > > Ah, of course, I didn't even think to look there (oops again). > > diff --git a/lisp/outline.el b/lisp/outline.el > index 7750f9a75d..8132043097 100644 > --- a/lisp/outline.el > +++ b/lisp/outline.el > @@ -294,16 +294,16 @@ outline-minor-mode-use-buttons > :version "29.1") > > (define-icon outline-open button > - '((emoji "▶️") > - (symbol " ⯈ ") > + '((emoji "🔽") > + (symbol " ⯆ ") > (text " open ")) > "Icon used for buttons for opening a section in outline buffers." > :version "29.1" > :help-echo "Open this section") It seems the problem is somewhere else - in code that uses these definitions, because here semantically everything is correct: the outline-open button for opening a section means that the current state of the button is closed. This assumes that in "outline-open" the word "open" is a verb. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 04:11:20 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:11:20 +0000 Received: from localhost ([127.0.0.1]:45948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgoC-00076w-JI for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:11:20 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:38031) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgo6-00076f-N4 for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:11:19 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1FA0140009; Wed, 10 Aug 2022 08:11:06 +0000 (UTC) From: Juri Linkov To: Gregory Heytings Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: (Gregory Heytings's message of "Wed, 10 Aug 2022 08:08:28 +0000") Organization: LINKOV.NET References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86tu6kcyuh.fsf@mail.linkov.net> Date: Wed, 10 Aug 2022 11:10:35 +0300 Message-ID: <86a68ccydg.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Jim Porter , Lars Ingebrigtsen , Stephen Berman , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> For the NEWS file though (and especially programming modes). I still >>> think it'd be great to put the buttons in the fringe. That way the >>> buttons would never disrupt the contents of the file, e.g. by changing >>> how the indentation looks. >> >> Agreed, the clickable buttons in the fringe would be great, and it's easy >> to implement. > > Some users disable both fringes, or only the left fringe, though. Then it should fall back to other methods. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 04:19:29 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:19:29 +0000 Received: from localhost ([127.0.0.1]:45972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgw5-0007Jx-5e for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:19:29 -0400 Received: from mout.gmx.net ([212.227.15.15]:41285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLgw3-0007Jk-ID for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:19:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660119561; bh=1CYhdf82ykrZChcd847ee9drcjzrdXzGtTDlega8MXY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=LiXUXfmlptRn5OPYCbiv21JwWkPKbL5nDeX+SsArZfOtM8LQkOgFXupp/2sm6LX1o L3Og9dqqtvWbJBFJa9pzLNIbXitjPR+BL+o1W8iKn8DG9TOab/d2iE1SznAH0rvl+X bHzfr/LPyDRbikC+A3JVEH4/W0qKm4SYaRhwvLeI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs2 ([89.246.36.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MtfNl-1nXQxj1vrT-00v5mY; Wed, 10 Aug 2022 10:19:20 +0200 From: Stephen Berman To: Juri Linkov Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <86bkssedll.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 10 Aug 2022 10:36:22 +0300") References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86bkssedll.fsf@mail.linkov.net> Date: Wed, 10 Aug 2022 10:19:19 +0200 Message-ID: <87r11owlx4.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:1sAonxHFhHzPZaawwZsvibSV8f2bjo09QLWMx9mTTKYhB3guQGd OgGGnoLihWN3ogFApOZgijGkAGE84z+g7aLi7whE0EkJmBPcba9Ohh60y7QdXMmTsVzpDIb l2TBG7j7XXGgeMozxJ1kEDIX7OMqpeCJ9EarTGCY0xZDkGIt/9f5vwfn5klywYVX2iiERfb YsCELNCU9IQnEagDFmTXw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:XeKv5fiQPPc=:vBDow+4ZBj064VKAVyKPMz m+QUJvU4IMGm6OCr/FM7wWtq6Naf+YAL2XEENJ55clZe0Wo+QBwkvPOrAEm4/C7PMNwKrXtKp XsvdjaxZIpl53Jl3ZqIJr07S2iyLIJnt1DznRuTUMAoygmKzHTfdNQWloynAFHClzZkrrPPVu RAit6b519gsLomOh9Ba1uaW7WAfLi/dam1C3P/oCna94sXIUyS5wBDhM3nmAupGdOhBSxWzPX CU3ziOpNyR6TIOLyOyrsiArzI3fRJfZzuAo/T5r+f6HYyRn+sLna3J7ypg8f49NyEElTrPXSe lt3EipZ6Xc5KLzpsz5jULAR9WAfXPCXGCElDlv+sahPUNYgfoWLURlBTxD2cJ6bn0a3GOA/hn QtNm8FgxpUSwPeJA+cAOA6jP92grSOTPurT7sjfkSmcZEiAGXrM5MzHMloeE99PiogiUya9H4 8IwhQn+wl/Hakp0LToXo+QunJSADKc8cCF7OG+OYsuoz0qZ22q1M1kedLogUUfu7mIL2R9IYU NFIabUpqkXKCEw4bwwRdWp0+o7LjD2sCEVW5f0Omvvx2wLUJk03Pq5hpldWlQaV8B4UkTZZd2 8M5SuPD13ur2FJWJz5klDmm3feh4JzIY9SyY5+sUkuFmo69yVYWXHBRy9JupydA6xON3zq7W0 5oeyf8kPMUDmrh+xKc1M3MPHoNA0rnrXJCNS3GoLyXny/q8E2ZI6WDfW6DeDbKgLULdqIRX2o uGAECQyQyYJQRRWmnAkt6yszY+9i1khi/axSQey7YP5siaR/HDOPdstvK0Razksk1V6n8RNhS N8+sW/5aypPBvE7wg8U0j7HIVSJYVYt/Qse2pZXns+lBQpIVs7XsQIOps7c/9SAg4JO9BmrGE bov1BD/vZ+yWm4s9PZLTYXocqlsZRb202Y19d4FJWk2v64qDG93pDvC5vV3mEoGGl6az7cPta RHqoQpY/XrERQTBh5P5l+rfqGw9SmyEKqRrrDfSbkJVcOstWCf6c4ibZd1CHUxoJTGY7eahre vepqWRrUsREuxWAdY3E8ZChqM8scDRVGBfqRKYhoEmoWQClbDHWZz8KAHzvhPhOV4WGLwifP3 nhvKNZc5q3IJYd5t1wKgx/Juk9Hr/JFOBCQOBCHovySrLR9tK7Ectro/Q== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 10 Aug 2022 10:36:22 +0300 Juri Linkov wrote: >>> Also don't understand why is this change: >>> >>> (when outline-minor-mode-highlight >>> - (if (and global-font-lock-mode (font-lock-specified-p major-mode)) >>> - (progn >>> - (font-lock-add-keywords nil outline-font-lock-keywords t) >>> - (font-lock-flush)) >>> - (outline-minor-mode-highlight-buffer))) >>> + (when (and global-font-lock-mode (font-lock-specified-p major-mode)) >>> + (font-lock-add-keywords nil outline-font-lock-keywords t) >>> + (font-lock-flush)) >>> + (outline-minor-mode-highlight-buffer)) >>> >>> `outline-minor-mode-highlight-buffer' is intended only for buffers >>> that don't support font-lock highlighting. >> >> Yes, but with that change, arrows are displayed on first visiting the >> NEWS buffer; without it, they only appear when typing TAB on an outline >> heading. > > This change broke fontification e.g. in diff buffers that now > add outline faces on diff hunks. So we need another solution. Oh, dear (as I noted in my OP, I only checked NEWS and *Help* with describe-binding). But do you have a recipe to see this? When I create a diff with vc-diff I don't see outline faces on the hunks. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 04:24:58 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 08:24:58 +0000 Received: from localhost ([127.0.0.1]:45982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLh1N-0007ST-Tt for submit@debbugs.gnu.org; Wed, 10 Aug 2022 04:24:58 -0400 Received: from heytings.org ([95.142.160.155]:46880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLh1M-0007SL-48 for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 04:24:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1660119894; bh=pvUhaCwmXWao+hoWBwtaP7osGsn5w20b45eIBlUt7tk=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=XJiiV5ce7AR4K8cALAWZi7VpvoSpFtM0cw2R0acMbKZRuu8c95NB86i7l9xS9Egkc 0Gg+YzS3908FQuF0ilvkVVXs67Nyjfj3XgbDg5ISSRP5Gf4kXtzx8lwxmCNrj/rA1U VzniKVpWaxfzYr0Sua+9j9d70+MRSU2+ZN8CM7AxZ2qoup+mmmwuKWEdCvxpGDvEFr ww2GdRW1Kxa6JEHnofISQT73B5rlLPRqMFHQL74jM8kl++w7IUTD2sRLJaZTraSsl1 RW+DRBVXunJsaiidwqsa352HHKyGbq9SMmgHhGmoUlh0GI2hWEHaj5FFyyE6rNGC1W ktAZ9E8UOz6bg== Date: Wed, 10 Aug 2022 08:24:54 +0000 From: Gregory Heytings To: Juri Linkov Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <86a68ccydg.fsf@mail.linkov.net> Message-ID: References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86tu6kcyuh.fsf@mail.linkov.net> <86a68ccydg.fsf@mail.linkov.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57082 Cc: Jim Porter , Lars Ingebrigtsen , Stephen Berman , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>> For the NEWS file though (and especially programming modes). I still >>>> think it'd be great to put the buttons in the fringe. That way the >>>> buttons would never disrupt the contents of the file, e.g. by >>>> changing how the indentation looks. >>> >>> Agreed, the clickable buttons in the fringe would be great, and it's >>> easy to implement. >> >> Some users disable both fringes, or only the left fringe, though. > > Then it should fall back to other methods. > Yes, I mentioned this only to remind that another methods should be available. And if another method is available, perhaps the chosen method should also depend on a configuration variable. Some users may prefer in-buffer buttons even if they do not disable the fringes. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 11:17:57 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 15:17:57 +0000 Received: from localhost ([127.0.0.1]:50476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLnT2-0002p5-Mh for submit@debbugs.gnu.org; Wed, 10 Aug 2022 11:17:57 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:22172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLnSy-0002os-Mg for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 11:17:55 -0400 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27AD0BjS008284; Wed, 10 Aug 2022 15:17:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=Via+iaK/4jt1casntJ+PFBZ6PtGu/OqPplRbBP4/Vgc=; b=0HELxMyowQsVQ1580X+9ZynS6rBDlf0LHUx+3ZOYfF7RbXhASG3WiYx/ad2M2Bnec8hj uWVNjwgeoAPrD+31bbb00RmXG/2QvIc/3J/Xy+bxMSMQbW9X9mSvIOq2/f1K0ATg8W0n eOYWO138hLhW854NY6v73az0VidwY63TPC3Ac0W5DNoAWvFcbKt4NUwahEW50JkCWtz5 mtddVXOcFL5fNxBD3OOUQLLlX2ZPA4I1W0XrFA3ijL7cCrByNGgVdeoqoiKCDGuRm2eK BPwao31rL8Hf6R1OEJyhe7nOrmyt0xqDQ2DRTsH+fDVjF7TTH6GZNY1CLPOjg3AIdbt1 Yw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3huwqdt7c0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Aug 2022 15:17:51 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 27AEh42n015453; Wed, 10 Aug 2022 15:17:51 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3huwqj7m0x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Aug 2022 15:17:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6R7ssX4kHdBIbepxeOOXTFtdRaiiOQlpb5UV6jHtzTkqiiYZO3vNPFz9/mUOpdEM1tENOTSv1Xb0lgfR6EP7OaAodY4ih0+xx6KKhszhvvpSkJ6TTYZb0JTa1q0qTIpZndzh3V4S02G/+I2c1IoyxMV2tN3ssq4oyTTHjY/hfN9P4+wrF/9oQORxKFObQBnrdTjhfNET6NnDZ+K5GCjwatozwI0JJ4xvPj2OqTAJBDAUJYpuRw4B3xUXc/MCxgtMNP9J57AoRKoT7nJfge6wodkWZgC8GQsednxvgFurhcWTr2m8/d0SYVDPLzJUTb4v0/i5cq1H1BR0b5Gz6ePxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Via+iaK/4jt1casntJ+PFBZ6PtGu/OqPplRbBP4/Vgc=; b=E2oG5riR3Qly8OVRjseJXJ8wPH0/wEMk9B15I7QEyVTFipeceZrQn2AZyrzaD9n4E9IpxefPeadvM1HdprwjABGjx9DaXFcETHVsMymMQucbjI4ecAOHIdPEQQZwkGufq4eq7/TeK9YBIcQgH+o7oAAoI/xDu8Z+kXkVeoG85bwg71PWp6rDZL5V2R1JW6MANPTtpfsrwC6cl0LonzYr9ulqwSnfrb6DUN/hwXcCMEG73RZpcp1DjQmWYfXWJRu/jmMkOENtcUA7gIxl5LbS/rdG0R4MdeSCx8rTJua3Kmb9eJBqlIZ/kuQnCJU3wxR6pcYYjHTe8ZEGNVxgXIH6/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Via+iaK/4jt1casntJ+PFBZ6PtGu/OqPplRbBP4/Vgc=; b=aEe6uTZ9XSRYm+ruMeA1tgMl2Kbnv55lb0b2fUJzyk/KORMAY6lGsNdqIV5xJmMozGHK3nWR4Ibde2lARa7ZB5S2KfW8nZ1DvkPphMr8vHtZDo4g5rS0RCrByQqFRWEeVPtJQFFqO6WDceV5VztThlybhLce+rqfL7MuEdbxsNA= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by MW4PR10MB5679.namprd10.prod.outlook.com (2603:10b6:303:18d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.20; Wed, 10 Aug 2022 15:17:48 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::570:ff21:c9e1:22f1]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::570:ff21:c9e1:22f1%2]) with mapi id 15.20.5525.011; Wed, 10 Aug 2022 15:17:48 +0000 From: Drew Adams To: Gregory Heytings , Juri Linkov Subject: RE: [External] : bug#57082: 29.0.50; emacs-news-view-mode breakage Thread-Topic: [External] : bug#57082: 29.0.50; emacs-news-view-mode breakage Thread-Index: AQHYrJK3EnSFcC2qTE2L45O3Mk7w362oPH3w Date: Wed, 10 Aug 2022 15:17:48 +0000 Message-ID: References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86tu6kcyuh.fsf@mail.linkov.net> <86a68ccydg.fsf@mail.linkov.net> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 94b5dfe6-5c0c-4fbd-c21f-08da7ae37c3f x-ms-traffictypediagnostic: MW4PR10MB5679:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 93LYhasZ0rQ0gaK5EIMA7gZIcW4pfXdy9GSUn+6eYh31ino6fX4CsNar/J6t1qKTH7EJAKdv+7NlEeOQ+QYndVz0CpgPXo9i192e332dHW7W2sTnCJjGUzkTuVtDCm2pPyC99WTqnUrI7ub3Oe6AE6bxefGSgI7LLyun/RoQ5xtVyo0eV4YvWks0fsA/QwEuligILCHxwdDAOapG7z+qFaLPHf/8DFlJXLnVLT+xlY76Bc/YwBSt02jWiv/kCzUmXpr3OeM/LrORU2dirJLjmTNTR9Gp6jNYO5q9BchhL0q9PsamfpgvccQYM/KO0PSEab+sutZ2s54JkEyqsfHk4yoXKJ0Wlc03JsEOti1cqVtEqzJksRItg4vA8g8bEqXPWYQuuPvT6kZ+1zavN0HDyE7oeSiIL4zv0dofhHH0nipjwGNolu2Bu/20TaPfMt/eF/RadgV4sV40/3d3U1mjYt39Ku254MrCB2DVyYfHyHJQAVKB02bRqnXSydcxnJuxuxxMzjUTTriukyLVhiRbLyWFvh+zvnT22P0etzXQD8VcRYWcVpvdn4r1hUzHrC399Bj4dvNPEWBggM9ze97diEcryno26P4u/USul9DhkErk4kOsRJ2PLjbChIrO5sxNW+ObaSOJalx+4+pyO1p7Bwnp0pziIkFqnbf/2HQaCcYDZn2lIGgZhk4sm+kkxIAw4wCnuw8vKRZ8umd+oJyZgXIM48vIS9MBImw7xD8PcSD2fcEtLm48TAO4L5nU298N7O9/aeHgoGNaT0ibH+Iy43CW7+WNGHHsoQtuLQt3U4ybWECAgTFpmHBDZA2KxCSy x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(366004)(136003)(396003)(346002)(39860400002)(2906002)(6506007)(316002)(26005)(41300700001)(71200400001)(9686003)(7696005)(86362001)(33656002)(110136005)(54906003)(186003)(52536014)(66946007)(8936002)(66556008)(122000001)(76116006)(44832011)(66476007)(5660300002)(66446008)(478600001)(55016003)(64756008)(4744005)(38100700002)(4326008)(38070700005)(8676002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4255UxSg7ndb4nSkERc+sxrdqu3lwG33CELmhcycGWtWhAT99bLc8vxTW7Rs?= =?us-ascii?Q?jCVf27M2dkjkWdEMzEUdK/lMtNFzO6DRd+FA3OsmDQySXDAAgepqNOkd+xT3?= =?us-ascii?Q?rFbYyMOsJ/hRhRCnjRfTvrsNw5wck5c4BdbLzlnBM8pN5RIFXtZeysykqiE7?= =?us-ascii?Q?INP8q4/0P2QzRKYEgfQd6WyoNnV2knlLLB05bhOf/fAKVBUDliZmVhjDy0e4?= =?us-ascii?Q?r9xcOLt3+OlD0Wo4A34vpPKV4w8xiZlCxRiLEQ7rmqgyzfdW4V7ESWinX9fe?= =?us-ascii?Q?2hdGQ/apFlROp5SNDmgJaE+/1Qdu/LbQCCMBsjcttfTm2TGtCW9/hApzrNrk?= =?us-ascii?Q?mMkBx2DfLSxkbPFVm3w/qPNlLQs7PtMHY7zWPM9+4eg/3lT1m8XKQFW6ZJ2F?= =?us-ascii?Q?yFZXjpmFLdk4+0nY1IDVMOMRNFyhnLlzQtg4MagjFre3RVVyb+kTPLVV3xbp?= =?us-ascii?Q?RMa9+KViu/AVyZfvl/SlrV0wsHZQP3I0+fBLgl4L2z6MTHTSItm3msz+soTR?= =?us-ascii?Q?nDW9DO135S8I0qkbUGx16ht6LT6PJQLd3dwqoJ9yO2LBGdIlE5fi64GytUp0?= =?us-ascii?Q?ev3hAff9fZ4T9a+5ag2ZVpl0d4A/9X+JD35w8qrshr+1+qI4NIelFx/i2DNh?= =?us-ascii?Q?LAV8X+Kv7LbPJptJlH8PF9sjxI/jG0tJ6sG7t2C6FcipHAJhWn8AL8ya87Kk?= =?us-ascii?Q?ikOBxMFEYMg5p0FS0enTVQ965iFjbULNY1k2biBl4aJgDtYUgCjdQ+HcmeXc?= =?us-ascii?Q?H0xjdOZN11kEIPVsN1ZeSeLuqOa8K3MbmCVMcAJBrSIWAQsGY50PU6hqJQgl?= =?us-ascii?Q?548FBvySzH3JLFDp+w9YDtzihcNAUkWCzmgLmUT/QyfEgqMivGmMSPsMOG8B?= =?us-ascii?Q?R8GnjMOf2vD63zINJOpL1h6OibQMfpkUkK20Lcp1j5QmMotpThIKF0xGwjKm?= =?us-ascii?Q?l6irqfwmdkFBJi7GWi10LxL1MsaTZAQyIeI9Wjr6BejZXbSPRNZ3UiQ7l+Pp?= =?us-ascii?Q?v4TJtpNo9mj6uIQsYyfvSOoA1/eURDvkWxYcFXMcfQQsWxs8eU4gO4mo1JPk?= =?us-ascii?Q?8ZVboQchXUarGY+zT/6QR4gFyPNf7HI96T8uFGeOHMoYvoueSYOqNyN69453?= =?us-ascii?Q?XdXeREETF2fJjg4kogpWCV9hLT6C6NqvzYkHey5G4/4djsVcsdfShvcCVte6?= =?us-ascii?Q?EtDk9lpwo67i2jiAq44ykT7+BwG8y6CWYohG0+ePqWvjT6ttHSqWaV1vSvM2?= =?us-ascii?Q?G9bURE2J/UYaays4H80iWZEfUVKu4bwAJn+6l/7Ki/AZhPNgPmFbR3nnw87P?= =?us-ascii?Q?9WABynPCCupYXs6psjzHnvX6masoyaheejgGtFv4UYPIMH1/2CtP3yy6sWYj?= =?us-ascii?Q?vY9Hq0orGAuoAFSLg5V6mCV7QOGEfIv8xDAtxfHoH7RY950Lji3XuOSh2g5R?= =?us-ascii?Q?t/U3dXQ0uhaLQ2x3GL3ejyx1DPEaBeYQSrK0X8XgLUY92KmCjk4YJGkkJISO?= =?us-ascii?Q?5QFnJP96vLcZd5EiceiT49ROAL7XmuvuRaJiWy7rC3C3OtKbPfeCXogmu4nn?= =?us-ascii?Q?4tYXQogg2hMjbabWz44BojRB/sBGlQ3l8QYEZ44t?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94b5dfe6-5c0c-4fbd-c21f-08da7ae37c3f X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Aug 2022 15:17:48.6908 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EqfhnIdgZr8e9jZbHbCyrw5pT6zNOEFORILs3mP4OFg5vuRWHqdx5FLtOgS1TAX19ItW7Rm35tWJfNopZTkZqw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB5679 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-10_09,2022-08-10_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 mlxscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208100049 X-Proofpoint-GUID: 3bexuT3L7JIvQMn6FhzhhL4vG8SY6Cr9 X-Proofpoint-ORIG-GUID: 3bexuT3L7JIvQMn6FhzhhL4vG8SY6Cr9 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Jim Porter , Lars Ingebrigtsen , Stephen Berman , "57082@debbugs.gnu.org" <57082@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This may be irrelevant/off-topic; if so, please ignore. Whenever we have an icon or character (e.g. +, -) that acts as a button to expand or contract some hierarchical info by clicking the mouse, would it be good to also have a mouseover tooltip there, that lets you know a toggle key that both expands and contracts (based on point being on that line or whatever)? Emacs typically has keyboard keys to toggle things, and expanding/contracting together toggle. Presumably there's a toggle key for the display change involved here (if not, shouldn't there be?), and it might be good to let someone using a mouse know that there's an alternative to try. The mouseover help won't show unless you hesitate with the mouse over the icon/character, so this shouldn't be annoying etc. Just an idea. (Maybe this is already available?) From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 14:46:23 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 18:46:23 +0000 Received: from localhost ([127.0.0.1]:50762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLqil-00045u-Iq for submit@debbugs.gnu.org; Wed, 10 Aug 2022 14:46:23 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:41231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLqik-00045d-1H for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 14:46:23 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 387E2C0002; Wed, 10 Aug 2022 18:46:11 +0000 (UTC) From: Juri Linkov To: Stephen Berman Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <87r11owlx4.fsf@gmx.net> (Stephen Berman's message of "Wed, 10 Aug 2022 10:19:19 +0200") Organization: LINKOV.NET References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86bkssedll.fsf@mail.linkov.net> <87r11owlx4.fsf@gmx.net> Date: Wed, 10 Aug 2022 21:45:25 +0300 Message-ID: <86sfm4q6nu.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>>> `outline-minor-mode-highlight-buffer' is intended only for buffers >>>> that don't support font-lock highlighting. >>> >>> Yes, but with that change, arrows are displayed on first visiting the >>> NEWS buffer; without it, they only appear when typing TAB on an outline >>> heading. >> >> This change broke fontification e.g. in diff buffers that now >> add outline faces on diff hunks. So we need another solution. > > Oh, dear (as I noted in my OP, I only checked NEWS and *Help* with > describe-binding). But do you have a recipe to see this? When I create > a diff with vc-diff I don't see outline faces on the hunks. The minimal test case is this: (setq-default outline-minor-mode-highlight t) (add-hook 'diff-mode-hook 'outline-minor-mode) Then the first lines of diff is highlighted with blue outline-1 face, the @@-lines with outline-2 face, etc. This is because outline-font-lock-keywords and outline-minor-mode-highlight-buffer have slightly different interpretations of the values for outline-minor-mode-highlight. This could be improved, but in any case both these functions should not be applied at the same time. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 14:58:17 2022 Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 18:58:18 +0000 Received: from localhost ([127.0.0.1]:50784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLquH-0004QI-JA for submit@debbugs.gnu.org; Wed, 10 Aug 2022 14:58:17 -0400 Received: from mout.gmx.net ([212.227.15.15]:44249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLquD-0004Q0-7s for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 14:58:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660157886; bh=2DbpNY+sXjdqUjO1TRX6rzffW0jpfD5a1JigqxRHsEM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Kykk/HviOtqnRyTZoRf6sOksR4bpuuJi52EPLHid7ka9DwVGjb7tWktP4lcFBvsML 2R/XYYAaL7FE5xb6IyH438ofRCXwDwxtqljUk2y0yCFFYsCbY7j2BQFLdIktimmM0H KWhuOPQ+Cp82obXv7VSTvKzFPME6fKynw6v/Ki8Y= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobelfs2 ([89.246.36.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MHG8g-1o8bLa2pEG-00DIL9; Wed, 10 Aug 2022 20:58:06 +0200 From: Stephen Berman To: Juri Linkov Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <86sfm4q6nu.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 10 Aug 2022 21:45:25 +0300") References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86bkssedll.fsf@mail.linkov.net> <87r11owlx4.fsf@gmx.net> <86sfm4q6nu.fsf@mail.linkov.net> Date: Wed, 10 Aug 2022 20:58:03 +0200 Message-ID: <87pmh8uds4.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:BQ97/dAHq1A5FLTVIhGs44co66e2l7bSKV33/YLD/FpfX7fu/U4 F28Un8wAafbNgoSQ9BxalKwnyjqQUqzxvYYGqJAKC8INOJCdyTH0hY2onU87OXrq2Buc+0q aIygNIAafBu8Pr6Ba+ykEv1mvg1ptP/GylowbXF/zVotwyBxKYwtQTxqs/DSaICXRHHbIdq vNmMLJNoddS1iH1vT/MVQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:uO97bJLY1wE=:pAGoGRJgJtMU+lTv/96VyR mOF4zuh0tl9/yIpiLbyQaxGzJlxZpdoUacjobzlzg7jIQEvsbqXk4yCZYL2xNfiH089cJxr3G zHMmTw7Lmr3mjuLBy78G/rUx363POu29zOVJLPRRzXR6Hvk1OP6Ec9oWBcZ9QSj7nggR/eLSF NhUPz/FTrwI6Zcvscku2kvz293YGd7K3QOgebztAYp7sz4gpu/bhIzfJusDC/bBgOr4eIXdXP TQ8Rtksf9tysZ2+rWyI4IP4zboADSopJw236c/QuKuuxTUgAvOXdch2OjHJX7mJvF4UIVetJK AQ3T4a8c31kLxCYQ1d9vabhHPKGiMvdciIq1ZIwGLtlchKidrM6P+/7HgrRhIyPmGpDIRta7k 2TwEgS8M782M1DXtYdLzjdb7FYjD0LaYYsLp05EWD5jrVF7lYFcm9RfXxfMAQKanHxywjJXiS AEpoFTU7lUXr4Kyyv0geCHJ//XA7JDGx/tDRE0tnQNcOK4X6jm7xOjBiPVCJDlUbuQhzevl+n UVlCllyYorga/GXc8l9JtUfB1r3l2k3kKwp2lI6YRl9zJ7fj42VUf5zNgTxJt3PQG5l89MqcB cyyoloDJw8EQryBWonZP4mkjj3QzwgvjovrTHFtoQ5ZaIsiGvX1lEzGjTnSi4Keq3twK9o/zx eyjRcQAqB967s9c5+sQhTWNq4hql8RhxKGcmZxs1+yH4CzjZzVXH2cpaG6Mrdki4aavtKerw2 rWotcoC6SdKLP6nrKr3QnhJqng8trsIMnDmO5MiqWYpFsZmPuFvq3jkXDwTtSFBEp9/lGQ8Zo l3pGpL11F/fiaZ6AGK7jLSgfrU45OybVpBI57z1njJAhd0VZPfRUclv8QbhLxjXtLbuzYT8Ls K/BKKoYpygz5JcZ1jR0no8ofdnRf8EFjyGn7hgXQSsdK91cqLdKz30HBIUpN+T9qeSoxAlEvu FEiWPuACecG3UfBT+GC9SF1xfHErp18v0j5sYVLYFsJ1PVaIiQ8/ZCVV+JmCg0ukvvYph9Tzr 54FLKeN9JJfWJ0DXfItmBJPfM9cH8g/ewJ4Tlipu8lBhAfNgpGPw5Kt6Ih+wNx9bDWMsafdAU JfWoqVVWAh8tudE9cCFDgIVOQe5cxEe99DbmgE2LVZWMMvGWuu2OyAxSA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, 10 Aug 2022 21:45:25 +0300 Juri Linkov wrote: >>>>> `outline-minor-mode-highlight-buffer' is intended only for buffers >>>>> that don't support font-lock highlighting. >>>> >>>> Yes, but with that change, arrows are displayed on first visiting the >>>> NEWS buffer; without it, they only appear when typing TAB on an outline >>>> heading. >>> >>> This change broke fontification e.g. in diff buffers that now >>> add outline faces on diff hunks. So we need another solution. >> >> Oh, dear (as I noted in my OP, I only checked NEWS and *Help* with >> describe-binding). But do you have a recipe to see this? When I create >> a diff with vc-diff I don't see outline faces on the hunks. > > The minimal test case is this: > > (setq-default outline-minor-mode-highlight t) > (add-hook 'diff-mode-hook 'outline-minor-mode) > > Then the first lines of diff is highlighted with blue outline-1 face, > the @@-lines with outline-2 face, etc. Yes, I see it now, thanks. > This is because outline-font-lock-keywords and > outline-minor-mode-highlight-buffer have slightly different > interpretations of the values for outline-minor-mode-highlight. > > This could be improved, but in any case both these functions > should not be applied at the same time. Ok. I'm not familiar enough with the intricacies of font-lock to whip up a quick fix and can't afford to spend a lot of time on it, so I hope someone better qualified than me will do it. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 11 02:45:34 2022 Received: (at 57082) by debbugs.gnu.org; 11 Aug 2022 06:45:34 +0000 Received: from localhost ([127.0.0.1]:51269 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM1wk-0005Xl-7s for submit@debbugs.gnu.org; Thu, 11 Aug 2022 02:45:34 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:51339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM1wi-0005XY-JD for 57082@debbugs.gnu.org; Thu, 11 Aug 2022 02:45:33 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 24B54FF802; Thu, 11 Aug 2022 06:45:24 +0000 (UTC) From: Juri Linkov To: Stephen Berman Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <87pmh8uds4.fsf@gmx.net> (Stephen Berman's message of "Wed, 10 Aug 2022 20:58:03 +0200") Organization: LINKOV.NET References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86bkssedll.fsf@mail.linkov.net> <87r11owlx4.fsf@gmx.net> <86sfm4q6nu.fsf@mail.linkov.net> <87pmh8uds4.fsf@gmx.net> Date: Thu, 11 Aug 2022 09:44:48 +0300 Message-ID: <868rnvs2hr.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57082 Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> This is because outline-font-lock-keywords and >> outline-minor-mode-highlight-buffer have slightly different >> interpretations of the values for outline-minor-mode-highlight. >> >> This could be improved, but in any case both these functions >> should not be applied at the same time. > > Ok. I'm not familiar enough with the intricacies of font-lock to whip > up a quick fix and can't afford to spend a lot of time on it, so I hope > someone better qualified than me will do it. I guess what is needed here is to find the right place to call outline--fix-up-all-buttons on first visiting the NEWS buffer. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 12 08:49:50 2022 Received: (at 57082) by debbugs.gnu.org; 12 Aug 2022 12:49:50 +0000 Received: from localhost ([127.0.0.1]:55871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMU6o-0005iz-6L for submit@debbugs.gnu.org; Fri, 12 Aug 2022 08:49:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMU6m-0005il-5y for 57082@debbugs.gnu.org; Fri, 12 Aug 2022 08:49:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=dtZIf0s4r3Nhtv6yNZlywtD5trVHaEGX7CnGsVYRICc=; b=FqUG/OTlg2xDeUcY6qKVeHlgMN Pw/y0S5UYSqi59xoYF4ikgNH1hzmiXOjXroNDst6rzTPpXb7gK5zzFnwufwN33K5g5YlWRKgbT9bP 47YQJ+dIzxhCVNiJNWjJr0kDl7omXzn/FkDe6bGNDKEMHjbkefO8V7F+MJcwOMyzso6E=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMU6d-0004wz-79; Fri, 12 Aug 2022 14:49:41 +0200 From: Lars Ingebrigtsen To: Stephen Berman Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <87zggcwn0n.fsf@gmx.net> (Stephen Berman's message of "Wed, 10 Aug 2022 09:55:36 +0200") References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <87zggcwn0n.fsf@gmx.net> X-Now-Playing: Two Nice Girls's _Chloe Liked Olivia_: "Let's Go Bonding" Date: Fri, 12 Aug 2022 14:49:38 +0200 Message-ID: <87tu6hr5i5.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: >> This is the visual style used in GNOME (at least, the theme I'm using), MS >> Windows, macOS, Firefox/Thunderbird, and probably others. More importantly, >> it's also the style Emacs already uses e [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57082 Cc: Jim Porter , 57082@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stephen Berman writes: >> This is the visual style used in GNOME (at least, the theme I'm using), MS >> Windows, macOS, Firefox/Thunderbird, and probably others. More importantly, >> it's also the style Emacs already uses elsewhere: see the Customize UI. > > Ah, of course, I didn't even think to look there (oops again). Thanks; pushed to Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 12 08:50:13 2022 Received: (at 57082) by debbugs.gnu.org; 12 Aug 2022 12:50:14 +0000 Received: from localhost ([127.0.0.1]:55875 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMU7B-0005k6-G5 for submit@debbugs.gnu.org; Fri, 12 Aug 2022 08:50:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54114) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMU7A-0005jq-1n for 57082@debbugs.gnu.org; Fri, 12 Aug 2022 08:50:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TwH1e51wVT5KjybmP/B6vUYYq+5HWLLCDA/5I+R/ttQ=; b=GHulvbEU9M+9/8QP3aNnNRRyVs Re0WD2OrFGNLV6Dh3W3f04sacJFY6y3smKVsdbqKmtYaIEOz1lc/CzYQSsalKyRYd7w+KuJRBh8Ne IIb0YeDPaCBBxZZ7KWZo+zFAwdrhqyrARuqiIx9S5+bvNz2OZu4icRWW/UJSBydbqhwc=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMU71-0004xP-0I; Fri, 12 Aug 2022 14:50:05 +0200 From: Lars Ingebrigtsen To: Juri Linkov Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: <86fsi4cyhd.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 10 Aug 2022 11:07:14 +0300") References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <87zggcwn0n.fsf@gmx.net> <86fsi4cyhd.fsf@mail.linkov.net> X-Now-Playing: Two Nice Girls's _Chloe Liked Olivia_: "Let's Go Bonding" Date: Fri, 12 Aug 2022 14:50:02 +0200 Message-ID: <87pmh5r5hh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Juri Linkov writes: > It seems the problem is somewhere else - in code that uses these definitions, > because here semantically everything is correct: the outline-open button > for opening a section means that the curren [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57082 Cc: Jim Porter , Stephen Berman , 57082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Juri Linkov writes: > It seems the problem is somewhere else - in code that uses these definitions, > because here semantically everything is correct: the outline-open button > for opening a section means that the current state of the button is closed. > This assumes that in "outline-open" the word "open" is a verb. No, they're nouns. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 12 08:51:36 2022 Received: (at 57082) by debbugs.gnu.org; 12 Aug 2022 12:51:36 +0000 Received: from localhost ([127.0.0.1]:55879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMU8W-0005mS-1E for submit@debbugs.gnu.org; Fri, 12 Aug 2022 08:51:36 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMU8U-0005mF-9T for 57082@debbugs.gnu.org; Fri, 12 Aug 2022 08:51:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=mA3Jx2ak9NHR6dCuWOGgaCPWer9XBpfl+X+owplx+DA=; b=kRfo+v+dy7L+Yvsx+xLPw8UkYX 7tXLHj408SMZgKHiGAF3EBdqkMxxZva/XTg3Dm8/UNJTUobUJWczeV12jVzY5bxHesax2jOEIJ+Uv bUhv4YSy/qWUo1U/b8HOkd32kL/aV2BPP90h9/CDCeiE8gJXZPuHIOF9VgNgU7EKFM58=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oMU8L-0004ye-UM; Fri, 12 Aug 2022 14:51:27 +0200 From: Lars Ingebrigtsen To: Jim Porter Subject: Re: bug#57082: 29.0.50; emacs-news-view-mode breakage In-Reply-To: (Jim Porter's message of "Tue, 9 Aug 2022 17:03:25 -0700") References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> X-Now-Playing: Two Nice Girls's _Chloe Liked Olivia_: "Let's Go Bonding" Date: Fri, 12 Aug 2022 14:51:25 +0200 Message-ID: <87lertr5f6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > For the NEWS file though (and especially programming modes). I still > think it'd be great to put the buttons in the fringe. Yes, I agree. The in-buffer buttons look nice in *Help*, but in a more text-like buffer like NEWS (and which also opens unfolded by default), they're distracting. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57082 Cc: Stephen Berman , 57082@debbugs.gnu.org, Juri Linkov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > For the NEWS file though (and especially programming modes). I still > think it'd be great to put the buttons in the fringe. Yes, I agree. The in-buffer buttons look nice in *Help*, but in a more text-like buffer like NEWS (and which also opens unfolded by default), they're distracting. From unknown Sat Sep 20 08:01:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 10 Sep 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator