GNU bug report logs - #57079
29.0.50; Performance of seq-uniq is not very good

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Tue, 9 Aug 2022 16:12:02 UTC

Severity: minor

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #55 received at 57079 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 57079 <at> debbugs.gnu.org, stefan <at> marxist.se,
 Juri Linkov <juri <at> linkov.net>
Subject: Re: bug#57079: 29.0.50; Performance of seq-uniq is not very good
Date: Sat, 13 Aug 2022 01:59:11 +0200
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> > delete-dups is faster because its implementation uses the hash table.
>
> Good point.  I've now made seq-uniq do the same, and this makes the test
> case go from 1.7s to 0.07s.

Good.

I think a large amount of non-standard test functions is of the form

  (lambda (x y) (TEST (F x) (F y)))

where TEST is a standard test function (equal or eq) and F some function
that CL calls key function.

This case can still be supported using hash tables.  So I think it could
make sense to add support for an additional optional KEY argument.

Michael.




This bug report was last modified 3 years and 2 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.