GNU bug report logs - #57079
29.0.50; Performance of seq-uniq is not very good

Previous Next

Full log

Message #46 received at 57079 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57079 <at> debbugs.gnu.org, stefan <at> marxist.se
Subject: Re: bug#57079: 29.0.50; Performance of seq-uniq is not very good
Date: Tue, 09 Aug 2022 21:16:56 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: stefan <at> marxist.se,  57079 <at> debbugs.gnu.org
> Date: Tue, 09 Aug 2022 20:03:46 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > My point is that it will never be as fast as the implementations
> > Stefan deleted, replacing them with seq-uniq.  My point is that those
> > changes just made several places in Emacs slower, even after your
> > speedup, for no good reason.  Those deleted functions, if they needed
> > to be deleted, should have been replaced by a different
> > implementation, which doesn't support TESTFN and is therefore faster,
> > as the original implementations, now deleted, were.
> 
> The performance of the new seq-uniq (called with no TESTFN) is identical
> to the old gnus-delete-duplicates -- it's the same code.

Yes, and delete-dups on a copy is faster.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.