GNU bug report logs - #57079
29.0.50; Performance of seq-uniq is not very good

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Tue, 9 Aug 2022 16:12:02 UTC

Severity: minor

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


Message #43 received at 57079 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57079 <at> debbugs.gnu.org, stefan <at> marxist.se
Subject: Re: bug#57079: 29.0.50; Performance of seq-uniq is not very good
Date: Tue, 09 Aug 2022 20:03:46 +0200
Eli Zaretskii <eliz <at> gnu.org> writes:

> My point is that it will never be as fast as the implementations
> Stefan deleted, replacing them with seq-uniq.  My point is that those
> changes just made several places in Emacs slower, even after your
> speedup, for no good reason.  Those deleted functions, if they needed
> to be deleted, should have been replaced by a different
> implementation, which doesn't support TESTFN and is therefore faster,
> as the original implementations, now deleted, were.

The performance of the new seq-uniq (called with no TESTFN) is identical
to the old gnus-delete-duplicates -- it's the same code.





This bug report was last modified 3 years and 3 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.