From unknown Tue Aug 19 14:24:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57070 <57070@debbugs.gnu.org> To: bug#57070 <57070@debbugs.gnu.org> Subject: Status: [PATCH] bootloader: extlinux: support for optional FDTDIR Reply-To: bug#57070 <57070@debbugs.gnu.org> Date: Tue, 19 Aug 2025 21:24:04 +0000 retitle 57070 [PATCH] bootloader: extlinux: support for optional FDTDIR reassign 57070 guix-patches submitter 57070 Reza Alizadeh Majd severity 57070 normal tag 57070 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 06:27:45 2022 Received: (at submit) by debbugs.gnu.org; 9 Aug 2022 10:27:45 +0000 Received: from localhost ([127.0.0.1]:42614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLMSf-0006UG-5s for submit@debbugs.gnu.org; Tue, 09 Aug 2022 06:27:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:51646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLMSd-0006U9-NI for submit@debbugs.gnu.org; Tue, 09 Aug 2022 06:27:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50910) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLMSd-0008Qc-IO for guix-patches@gnu.org; Tue, 09 Aug 2022 06:27:43 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:60797) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLMSb-0001dX-G0 for guix-patches@gnu.org; Tue, 09 Aug 2022 06:27:43 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8921F320083A for ; Tue, 9 Aug 2022 06:27:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 09 Aug 2022 06:27:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1660040858; x=1660127258; bh=plk4gqNeVR b9bvddwShSYgV43GC4hKHFUOLZDA298hs=; b=tNB7qLh/BIvxpiA//JyEA9eQGd UJyIc67Zuql7vSJcL0sybiclovKbNX3Ax0no1iBxb4NW4R3JVWxHc1XAVo9Ln70U sisGbwtU1EohIL1/xyAn6G9BOltQLbyV/13G3rFqS3OUU/U225vkUrgqjuxXqJOw d/VSw8Mpp6Z2Kpi6WNL1GOn9TGqJXhPMFMR90ZjjHitTXx5W8AIcViZ7L5yiQMeX ceFQsXGijpGnu6vlqu6MSUdJiE0S9sU/LctMrjpcTC3uitwWUJ+HowjUdhOHHLK3 kaboGyiCVCN0b4bNEovj08/9lieKsRA+powPF+KLVHIH8vyq8uzDGNAJYw5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660040858; x=1660127258; bh=plk4gqNeVRb9bvddwShSYgV43GC4 hKHFUOLZDA298hs=; b=nn706G2o7Pe6yVyGb/Nt9UUMzW0qzgiRkIQmM/mkYvB2 1rv66nOsXlUYfKBvvOL/9hVku1w5tdho4P/ten4+NJ1eARByybQbLoT50vtMNsw6 8l9phprUVVLxloyC9fpVeU/cncb2LLVn6MMsNtpUiBCh0fTT/mIm8AHgFpWSSHS2 CpJxG+KyHNdofdhq1xaGEiOpJLiVpPaeJAjwvcfVUbYRtpuvmaIp8e54uDHsXQhS shK2WsPa+qRNqcigLUE+FVFKIvmhXbFyqYNpN/i3CVhaasqPsbBfZd7uteR4aaBv iAPuXASv8gCPXCaWa2KwhsDkJ5HjXp8fPUkPEjU1Jg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegtddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkohfogggtgfesthhqre dtredtjeenucfhrhhomheptfgviigrucetlhhiiigruggvhhcuofgrjhguuceorhdrmhgr jhgusehprghnthhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepffevfeefffeghf dvleehieduteevheethfekkefgteeugfehhfefvedvheeufedtnecuffhomhgrihhnpehp rghnthhhvghrgidrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmh grihhlfhhrohhmpehrrdhmrghjugesphgrnhhthhgvrhigrdhorhhg X-ME-Proxy: Feedback-ID: i063944dc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Tue, 9 Aug 2022 06:27:36 -0400 (EDT) Date: Tue, 9 Aug 2022 14:57:30 +0430 From: Reza Alizadeh Majd To: guix-patches@gnu.org Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR Message-ID: <20220809145730.435ef8d0@pantherx.org> Organization: PantherX X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.147.123.24; envelope-from=r.majd@pantherx.org; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) There are situations that u-boot doesn't have to load from the device tree. some provide the device tree using a vendor bootloader (like what raspberry-pi does) or with an external bootloader that chainloads the u-boot (what Asahi does for m1n1 bootloader).=20 Unfortunately we couldn't find any reliable document to enforce u-boot to pass the device tree via `extlinux.conf`, however during our tests, we found that removing the `FDTDIR` line from the `extlinux.conf` tend us to do so. There is also no reliable way to guess if u-boot bootloader should load device tree or not on a specific hardware. in addition, there are hardware that can be booted with both firmware device tree on some kernels and with special device tree on other (modified) kernels.=20 so we propose the following patch to define an optional parameter in `bootloader` record, called `ignore-fdtdir?` which by default is set to `#f` to keep the current behavior unchanged. if this paramter is set to `#t`, the `FDTDIR` line will be discarded from the `extlinux.conf` and u-boot doesn't load the device tree automatically. This patch was tested on a Raspberry PI and in a VM. It is proven to preserve the old behavior. We=E2=80=99d love to hear your feedback and hope= we can support more arm hardware in the future. Regards, Reza --=20 Reza Alizadeh Majd PantherX Team https://pantherx.org From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 09 06:31:11 2022 Received: (at 57070) by debbugs.gnu.org; 9 Aug 2022 10:31:11 +0000 Received: from localhost ([127.0.0.1]:42653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLMVz-0006e9-1T for submit@debbugs.gnu.org; Tue, 09 Aug 2022 06:31:11 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:53033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLMVt-0006d9-Gw for 57070@debbugs.gnu.org; Tue, 09 Aug 2022 06:31:10 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id BE0CD32002F9; Tue, 9 Aug 2022 06:30:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 09 Aug 2022 06:30:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1660041058; x=1660127458; bh=M8+JU0JgxZbiqlyTSQPFcUIH0 N2UICjCr8S7WWw1Ytc=; b=Wa6j4SyBf3mBunOVE8YcPFujl0O9/AidQbyVkpP/a n+pYer0OM9MEOTyQAmlVaLGd+/hSIqlQEQ3wZ7ZZ2HVzFFTURDhHBfhEwC/Krrea uhYQgbg/RnOUFEUVRh3GL7hSH7F7sPlI1dU6LFx8S2MxQkGQfsgxMrTK6V/5OYkO TtOlOGte8sv64dPrB0Esu73w5JkVdpr1BI2+2J67jtlfz5VOsFo2dkCIPqsUu1yk t44ktlQWb2VUd5l6Pj383WSoz4GBOrF32TDjq5ZnLTaG6IUMTbwHlJKgjP5eXL4V SWCaeAlOlbDb2DRmZIsJQhifHD8MpDMvy7JBhOPnns9Yg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1660041058; x=1660127458; bh=M8+JU0JgxZbiqlyTSQPFcUIH0N2UICjCr8S 7WWw1Ytc=; b=5B4bNdnp7IcL/O3SNyjpifAiCIuAy2PsMM0W5Uuiok5r+gyvnDN gpKyzYHVK2z+ddZJyyrfhFFfLTx13Arjt3cxY3qaLIUhmwLOwGJcQQkubD4Xm+Ty 28BTrTsVEVp1Nk7riXKvjSplaKn2ruOfXhNYZH+wCDP29DjBwcCVVKH4HhrnJl4f HaXduvAX4CzrV/wmPbMF9v+QVDpiMWNl8nf60f52AdUdM8KC5ZvQ1Q2kYWwPW18w G0QcJ0pgmgJthLdB8IU+MZhKTD0VKuMVnMwnjX9p9O6yj7e4wFRXhyhECye58hhE IGREgJu1+xdBJ85j1UGYWiZYEQ+Kw17KQhA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegtddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpeftvgiirgcutehlihiirgguvghhucforghjugcuoehrrdhmrghj ugesphgrnhhthhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpefgheejhfelhfeuhe etvdfgieeffeekvdelkedujeeuvdejjedvheehffdvfeegkeenucevlhhushhtvghrufhi iigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrrdhmrghjugesphgrnhhthhgvrh igrdhorhhg X-ME-Proxy: Feedback-ID: i063944dc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 9 Aug 2022 06:30:55 -0400 (EDT) From: Reza Alizadeh Majd To: 57070@debbugs.gnu.org Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR Date: Tue, 9 Aug 2022 15:00:44 +0430 Message-Id: <20220809103044.27964-1-r.majd@pantherx.org> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: Reza Alizadeh Majd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/bootloader.scm ()[ignore-fdtdir?]: new field. * gnu/bootloader/extlinux.scm (extlinux-configuration-file): add FDTDIR line based on bootloader field of . --- gnu/bootloader.scm | 5 ++++- gnu/bootloader/extlinux.scm | 12 ++++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/gnu/bootloader.scm b/gnu/bootloader.scm index 9cf5457873..acf51bff7a 100644 --- a/gnu/bootloader.scm +++ b/gnu/bootloader.scm @@ -54,6 +54,7 @@ (define-module (gnu bootloader) bootloader-disk-image-installer bootloader-configuration-file bootloader-configuration-file-generator + bootloader-ignore-fdtdir? bootloader-configuration bootloader-configuration? @@ -173,7 +174,9 @@ (define-record-type* (disk-image-installer bootloader-disk-image-installer (default #f)) (configuration-file bootloader-configuration-file) - (configuration-file-generator bootloader-configuration-file-generator)) + (configuration-file-generator bootloader-configuration-file-generator) + (ignore-fdtdir? bootloader-ignore-fdtdir? + (default #f))) ;;; diff --git a/gnu/bootloader/extlinux.scm b/gnu/bootloader/extlinux.scm index 6b5ff298e7..084ed1e7c9 100644 --- a/gnu/bootloader/extlinux.scm +++ b/gnu/bootloader/extlinux.scm @@ -38,6 +38,10 @@ (define* (extlinux-configuration-file config entries (define all-entries (append entries (bootloader-configuration-menu-entries config))) + (define ignore-fdtdir? + (let ((bootloader (bootloader-configuration-bootloader config))) + (bootloader-ignore-fdtdir? bootloader))) + (define (menu-entry->gexp entry) (let ((label (menu-entry-label entry)) (kernel (menu-entry-linux entry)) @@ -46,12 +50,16 @@ (define (menu-entry->gexp entry) #~(format port "LABEL ~a MENU LABEL ~a KERNEL ~a - FDTDIR ~a/lib/dtbs + ~a INITRD ~a APPEND ~a ~%" #$label #$label - #$kernel (dirname #$kernel) #$initrd + #$kernel + (if (not #$ignore-fdtdir?) + (string-append "FDTDIR " (dirname #$kernel) "/lib/dtbs") + "") + #$initrd (string-join (list #$@kernel-arguments))))) (define builder -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 05:31:15 2022 Received: (at 57070) by debbugs.gnu.org; 10 Aug 2022 09:31:15 +0000 Received: from localhost ([127.0.0.1]:46082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLi3T-0000lQ-Iq for submit@debbugs.gnu.org; Wed, 10 Aug 2022 05:31:15 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:33586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLi3Q-0000lF-LP for 57070@debbugs.gnu.org; Wed, 10 Aug 2022 05:31:10 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id 5lX52800R20ykKC01lX64o; Wed, 10 Aug 2022 11:31:06 +0200 Message-ID: <2b867267-cfa3-07a9-99c9-b69c80f862ff@telenet.be> Date: Wed, 10 Aug 2022 11:31:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Reza Alizadeh Majd , 57070@debbugs.gnu.org References: <20220809145730.435ef8d0@pantherx.org> From: Maxime Devos Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR In-Reply-To: <20220809145730.435ef8d0@pantherx.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------1Sr7YDC5vUHNUWwK0FBDfMqY" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1660123866; bh=irUidETK1oN3jSKPjpMkSyzumlJN8cydd4CaOLWU/Ds=; h=Date:To:References:From:Subject:In-Reply-To; b=SJuBNhudUsPxVTdUky/j238gfWfWd9QI7HEvb1Qq9oNvrSiDIekb7P30POt/qqF/U DsvEHtwYRurKFhPRlDLYMeWvZ/LuLifsMcTh5rQhu+Wzx5M78w7B9I2CBhe5N6WKny VehOtDEfhWVIwkjlMklGX1F9aA8KgMA2cMbNM9sc+Tqf77s71J7azIENk/6j8fOX2H GMVrnatgqlSpGk1EUka7J7Hzqf3VgmEO4wp7OE/cMhXbs309a2/Ui0/Br8Pd4JA7KH yvpy4McONb4kFODI64rUkwWLGKMo5STUXvqJ/+TqAL++TPOryonifRQqEOvbE8mlG0 EdKj+CEWF5pmQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------1Sr7YDC5vUHNUWwK0FBDfMqY Content-Type: multipart/mixed; boundary="------------C0xZLNMmc94l3EWu4mQB0fLt"; protected-headers="v1" From: Maxime Devos To: Reza Alizadeh Majd , 57070@debbugs.gnu.org Message-ID: <2b867267-cfa3-07a9-99c9-b69c80f862ff@telenet.be> Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> In-Reply-To: <20220809145730.435ef8d0@pantherx.org> --------------C0xZLNMmc94l3EWu4mQB0fLt Content-Type: multipart/mixed; boundary="------------RBbEeFLqvhM00prAj3XleCiD" --------------RBbEeFLqvhM00prAj3XleCiD Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAwOS0wOC0yMDIyIDEyOjI3LCBSZXphIEFsaXphZGVoIE1hamQgd3JvdGU6DQo+IFRo aXMgcGF0Y2ggd2FzIHRlc3RlZCBvbiBhIFJhc3BiZXJyeSBQSSBhbmQgaW4gYSBWTS4gSXQg aXMgcHJvdmVuIHRvDQo+IHByZXNlcnZlIHRoZSBvbGQgYmVoYXZpb3IuIFdl4oCZZCBsb3Zl IHRvIGhlYXIgeW91ciBmZWVkYmFjayBhbmQgaG9wZSB3ZQ0KPiBjYW4gc3VwcG9ydCBtb3Jl IGFybSBoYXJkd2FyZSBpbiB0aGUgZnV0dXJlLg0KDQpQYW50aGVyWCBjbGFpbWluZyBpdCdz IHRoZSB1cHN0cmVhbSBvZiBHdWl4IChzZWUgdG9vbHRpcCBvZiAnb3BlcmF0aW5nIA0Kc3lz dGVtJyBvbiB0aGUgaG9tZSBwYWdlKSwgYnV0IHRoYXQncyBpbmNvcnJlY3QsIGl0J3MgdGhl IG90aGVyIHdheSBhcm91bmQuDQoNCkl0IGlzIGFsc28gaW1wbGllcyB0aGF0IG1vc3Qgb2Yg aXQgaXMgZGV2ZWxvcGVkIGJ5IFBhbnRoZXJYIHBlb3BsZSwgYnV0IA0KSUlVQyBtb3N0IG9m IGl0IGlzIGJhc2VkIG9uIEd1aXggU3lzdGVtLg0KDQpUaGUgd2Vic2l0ZSBhbHNvIGhpZGVz IHdlbGwgdGhhdCBpdCdzIG1vc3RseSBHdWl4IChlLmcuOiBvbiB0aGUgaG9tZSANCnBhZ2Ug aXQncyBvbmx5IG1lbnRpb25lZCBpbiB0aGUgdG9vbHRpcCkuDQoNClRoZSBBYm91dCBwYWdl IG1lbnRpb25zIGJvdGggIkxlc3Mgd2FzdGUiIGFuZCAib3RoZXIgdGVjaCBzaG91bGQgZm9s bG93IA0KdGhlIGZvb3Qtc3RlcHMgW29mIEJpdGNvaW5dIiwgdGhpcyBzZWVtcyBjb250cmFk aWN0b3J5Lg0KDQpJdCBhbHNvIGNsYWltcyBwcml2YWN5LCBidXQgdGhlIHdlYnNpdGUgaW5j bHVkZXMgc3R1ZmYgZnJvbSBhbiBleHRlcm5hbCANCnNlcnZpY2UgKGRra21hLmNvbSksIGFu ZCBhcHBhcmVudGx5IGl0J3MgYSB0cmFja2VyLg0KDQpHcmVldGluZ3MsDQpNYXhpbWUuDQoN Cg== --------------RBbEeFLqvhM00prAj3XleCiD Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------RBbEeFLqvhM00prAj3XleCiD-- --------------C0xZLNMmc94l3EWu4mQB0fLt-- --------------1Sr7YDC5vUHNUWwK0FBDfMqY Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYvN62QUDAAAAAAAKCRBJ4+4iGRcl7kzN AQCIm8ynBAlWxZYm5zlwS4DomqpaURjJaKjMw3/8yMjpaAEA2WXvp14uz/YR2f5uoamTx8cs4Pf7 kSEtYTrGlAx4hQ8= =kJsj -----END PGP SIGNATURE----- --------------1Sr7YDC5vUHNUWwK0FBDfMqY-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 05:32:41 2022 Received: (at 57070) by debbugs.gnu.org; 10 Aug 2022 09:32:41 +0000 Received: from localhost ([127.0.0.1]:46096 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLi4v-0000o7-LS for submit@debbugs.gnu.org; Wed, 10 Aug 2022 05:32:41 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:36284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLi4t-0000ny-Rw for 57070@debbugs.gnu.org; Wed, 10 Aug 2022 05:32:40 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id 5lYe2800T20ykKC01lYeRJ; Wed, 10 Aug 2022 11:32:39 +0200 Message-ID: <59ee7050-d5b1-695a-4be4-c1f1856fbda7@telenet.be> Date: Wed, 10 Aug 2022 11:32:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR Content-Language: en-US To: Reza Alizadeh Majd , 57070@debbugs.gnu.org References: <20220809145730.435ef8d0@pantherx.org> From: Maxime Devos In-Reply-To: <20220809145730.435ef8d0@pantherx.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------kjfC3xPp1eI0ODTeck737TsP" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1660123959; bh=6L5F6/Lsk5idjO1GlhZVIukHAAFtgJ7LUQudLt8qnUk=; h=Date:Subject:To:References:From:In-Reply-To; b=TqoFYnbG+8vYlJFGvHHRYQDmEC4iGSn76cg6kiLf+HhTfp7VNpFWopuj5WPai1wwj DsgSnWNFQHgBRyG4lUo5WLK2afiigQGUgz9/oIBI1lEwj8SOBlGMBTaMu4CIAiM33O C9da3yiO2tyRQQzvYy2d6PK+HRWNDyh9aId7BoCNqJZomSvoz3i2sqlutcpjrfvkHZ vr0mrlNQSvGoLr48K/UT8YHUZ3ri4CcYCkMRmF6BQGhIim0uZ0NlnEuUf9lv/AB0di +xe9ex/pbGg5UiDmcT08E3Ou1AnNXnSgil8aMw02fTyIot3UtEb7xCmPc8smMvhiHQ 1tqZ1fPoiLEQA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------kjfC3xPp1eI0ODTeck737TsP Content-Type: multipart/mixed; boundary="------------XFkP6pa00I40OZvfuegw2ii0"; protected-headers="v1" From: Maxime Devos To: Reza Alizadeh Majd , 57070@debbugs.gnu.org Message-ID: <59ee7050-d5b1-695a-4be4-c1f1856fbda7@telenet.be> Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> In-Reply-To: <20220809145730.435ef8d0@pantherx.org> --------------XFkP6pa00I40OZvfuegw2ii0 Content-Type: multipart/mixed; boundary="------------xrEYhNMT0oJRkHAEvv46aX0T" --------------xrEYhNMT0oJRkHAEvv46aX0T Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAwOS0wOC0yMDIyIDEyOjI3LCBSZXphIEFsaXphZGVoIE1hamQgd3JvdGU6DQo+IFRo aXMgcGF0Y2ggd2FzIHRlc3RlZCBvbiBhIFJhc3BiZXJyeSBQSSBhbmQgaW4gYSBWTS4gSXQg aXMgcHJvdmVuIHRvDQo+IHByZXNlcnZlIHRoZSBvbGQgYmVoYXZpb3IuIFsuLi5dDQoNClRo ZSBWTSB0aGluZyBzb3VuZHMgbGlrZSBhIGdvb2Qgc3lzdGVtIHRlc3QsIGFkZCBpdCB0byBn bnUvdGVzdHMvIHNvIHdlIA0KY2FuIHZlcmlmeSBpdCBhbmQgYXZvaWQgYnJlYWtpbmcgdGhp bmdzIHdpdGggZnV0dXJlIGNoYW5nZXMuDQoNCkdyZWV0aW5ncywNCk1heGltZS4NCg== --------------xrEYhNMT0oJRkHAEvv46aX0T Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------xrEYhNMT0oJRkHAEvv46aX0T-- --------------XFkP6pa00I40OZvfuegw2ii0-- --------------kjfC3xPp1eI0ODTeck737TsP Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYvN7NgUDAAAAAAAKCRBJ4+4iGRcl7uTD AQDYHsEpAADrph1wWEjVubAJKH06QXArhO5s3C4IQlDU8gD8CuTMt5rYQ+P/vN06o4HQNv4joQj9 k3SbTy99VBUJVAA= =mVJ0 -----END PGP SIGNATURE----- --------------kjfC3xPp1eI0ODTeck737TsP-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 10:37:57 2022 Received: (at 57070) by debbugs.gnu.org; 10 Aug 2022 14:37:57 +0000 Received: from localhost ([127.0.0.1]:50418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLmqL-0001nF-7r for submit@debbugs.gnu.org; Wed, 10 Aug 2022 10:37:57 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLmqJ-0001n1-EM for 57070@debbugs.gnu.org; Wed, 10 Aug 2022 10:37:56 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 25C945C01AC for <57070@debbugs.gnu.org>; Wed, 10 Aug 2022 10:37:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 10 Aug 2022 10:37:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1660142270; x=1660228670; bh=hEf+ss1f4X AU8fv98tgFb+YPhhDPZezG/BQV05Mv230=; b=P4a4kofATu7uvMsYX5O6WE6fe+ vTshrKmHP/Ty5Pf5K58v32P9Zef7Jrs1wuzD+uoYNtl4E7GEp2icC+Q18mhA9JsS 7B3a2TLouIX4krdWNdJjk/sTflQJFcPwwbs18Bn3Vi7paz53jD+QpnKLYEuH7pgg Fiw1wOjtH/UnNG7wXc6e7M59Vj06IpX/15JnivoTVts5pSHVn7SptXaQ1T/80QzI RGlEdBX5rkSf2Y3//PL7ECKqEqWQqTutPDFeNaa7TW23dyoGTtL4JiHRAuqkJMlH +qPdMgbKSmrvHwUrIyemm+2TFyNO40YSDxh5LNb+cO3LMq/THljc6QmoBNbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660142270; x=1660228670; bh=hEf+ss1f4XAU8fv98tgFb+YPhhDP ZezG/BQV05Mv230=; b=KTJhVaWIgn0+yJyL8gaq4eeIylfOiQgszzxQB6Ks6Niv htt2Qpupoe83CVKUiSrEd0OJGeiKwHMR5hF0D+LT9SOufe0oHAgufQlnwhMTyYy2 9MksM3LP+sUI4VDMfMgmB/WCh+tYwKcIQnnhLJ5B0HhrnffrStaMrZ6dFRMcSpJm AEm7rwrGGHGo8/e7bgiMyptTyvBSGQIx6q5HJFwC4PluUOP7lWrZWI40lA/4zG6P PY8YPHfo6Te4ErW/4GWZlmiNb8zohKGNoSA1pdi8WllxT+VGzl9n4NJntYakAEvw y2l6hry3A0WC9zIs3hM3vP9VPeaExBemYD2/L1H7QA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegvddgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtgfgggfukfffvffosehtqhhmtd hhtdejnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgr nhhthhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpefgieffleefuedvteektdduhf ekheejgeejtdekveefheekhfdvkeejleefgfdttdenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrhigrd horhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <57070@debbugs.gnu.org>; Wed, 10 Aug 2022 10:37:49 -0400 (EDT) From: Pavel Shlyak Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR Message-Id: <268A8657-46A1-489F-BE48-08378BCD0183@pantherx.org> Date: Wed, 10 Aug 2022 17:37:47 +0300 To: 57070@debbugs.gnu.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Maxime, how is your information about pantherx related to the patch? = This patch in question makes guix bootloader config more flexible with = the perspective of supporting additional hardware. It doesn=E2=80=99t = rely on any component of pantherx, thus I am not sure it=E2=80=99s the = right place to discuss that. As for the tests, I ran the image on a non-guix arm machine and I doubt = it=E2=80=99s possible or makes sense to run a VM during tests phase. = That would require much effort and probably hardware support for = virtualization (that=E2=80=99s not present on many relevant machines). I = believe a simple test like checking if the line is present in a newly = generated extlinux.conf would have more sense. Sincerely, Pavel From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 10:46:32 2022 Received: (at 57070) by debbugs.gnu.org; 10 Aug 2022 14:46:32 +0000 Received: from localhost ([127.0.0.1]:50428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLmye-00020H-JM for submit@debbugs.gnu.org; Wed, 10 Aug 2022 10:46:32 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:49239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLmyc-000202-BV for 57070@debbugs.gnu.org; Wed, 10 Aug 2022 10:46:31 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 04C745C01C0 for <57070@debbugs.gnu.org>; Wed, 10 Aug 2022 10:46:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 10 Aug 2022 10:46:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1660142785; x=1660229185; bh=vaLKCdJpcs vcVl4TUVopDWoVA2cB3FIOhp7sOF06ep8=; b=GJ7im4ZjLtzLjOvkX+WS/ifeMH Ogk3uuc3qPmG/Yx8jjH3xOgK1RhVAFsXasDer87Lp1C4vr28QKEfsqAIfwmKd7hc yTF8yJyPKVBfZbl7wEkvmIeiyEF9Do/wUafAnBKqvmXoqj10MZWQSTpYzQxUl/u+ Y407rH4irT6i935gsdB6/T66mXByaRlcp22IKEY76wDLVlUJokXsV0xKbhUWfH0K ReOuyUL3k1c5YjFNp+jf+xMUZvLmUXMtdBwgauMzrC5y98ceTlmyJnjVb2QT3viX uGGquGLB4KoZhIMukDKXL/D1MtteG5/x8wc7CV+BINjp/ry5/aZI43y6TBmw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660142785; x=1660229185; bh=vaLKCdJpcsvcVl4TUVopDWoVA2cB 3FIOhp7sOF06ep8=; b=zo6F5gTF6s5eCLPbA3fSw6yUuxuqieZG1HbnXtsvXmfk r/aEBSuW7/KtqGhqbgnuok/SNeUNQMsuP/S6ssigBD1ddn4E59SseGFxkS7jLrvn F63VtbTz0zdOR8IBmt1vg5wms1Cy/+pEnmbIXXv+muuEc+30MUxUzvLh0XhwWT2J FuGdCk0z9Po8ClMAK1RZ7nNPhnR03DMG+pQe4jUghjWT17Iizoe+piqaP3SfUmJU ksskDs3CFADMqeRgv6i5qvNdlyAv3TJjTxopXCCZa0SkoLU9voNWEGYqyvRmIUXe 1zMgU0ZkpuzrFNm6LuIfcKPDHhRdSwTNyWQd4P9FRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegvddgjeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtgfgggfukfffvffosehtqhhmtd hhtddvnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgr nhhthhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpeejgeehveekveeugeegteette ejfedtteekudeghfdtudfhjeekueeiveduhedtudenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrhigrd horhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <57070@debbugs.gnu.org>; Wed, 10 Aug 2022 10:46:24 -0400 (EDT) From: Pavel Shlyak Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR Message-Id: Date: Wed, 10 Aug 2022 17:46:22 +0300 To: 57070@debbugs.gnu.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) P. S. Just to clarify: patch was written by Reza, I was the one who took = part in testing it.= From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 11 06:00:55 2022 Received: (at 57070) by debbugs.gnu.org; 11 Aug 2022 10:00:55 +0000 Received: from localhost ([127.0.0.1]:51701 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM4zj-0004Vr-W0 for submit@debbugs.gnu.org; Thu, 11 Aug 2022 06:00:55 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:35390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM4ze-0004Va-Ko for 57070@debbugs.gnu.org; Thu, 11 Aug 2022 06:00:50 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by albert.telenet-ops.be with bizsmtp id 6A0g2800M20ykKC06A0h6R; Thu, 11 Aug 2022 12:00:43 +0200 Message-ID: <43277e51-3340-4821-10ca-23de061c5871@telenet.be> Date: Thu, 11 Aug 2022 12:00:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Pavel Shlyak , 57070@debbugs.gnu.org References: <20220809145730.435ef8d0@pantherx.org> <268A8657-46A1-489F-BE48-08378BCD0183@pantherx.org> From: Maxime Devos Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR In-Reply-To: <268A8657-46A1-489F-BE48-08378BCD0183@pantherx.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------VHITKgQolj70LXX0rzaAfMi0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1660212043; bh=NUmjyDaP/0z1uk9nu/Y1xqOfhwfGH+4ML6as34sgo+k=; h=Date:To:References:From:Subject:In-Reply-To; b=SVZFea7O7mzlnoWCPiuNLPFAD5wJx/o1sqhxCP7gT0txa8paYXq9ERZMN9/aOlZW+ GtPThW+WMtGuAyimPECKC4qqihUYMvOIkNyHreyUUh3oJmVFb+S7KLGka5XvCkjK5d OdP/N9vKI7jXE8ZbTIOpirl1qOy4i5uzjKUEBo7ZXqzm0o0Ch5ZkBOvbVMGVn28SBv LFMsXPffdxQrDUHYkB4UUMkB0K+0roddCn3DQd/7XBd5AD/Pae6bu+mk/tfeoW9wgG nIkR7ULtBFlCRl07DyQeoW9KXuGPxEMf7kNUALTOMJfNqmkaDG3zJw29a6livH4Fdr +QAlPqO7o7gzQ== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------VHITKgQolj70LXX0rzaAfMi0 Content-Type: multipart/mixed; boundary="------------hWiZ0Q4xqQBt2JY3gptmrEsv"; protected-headers="v1" From: Maxime Devos To: Pavel Shlyak , 57070@debbugs.gnu.org Message-ID: <43277e51-3340-4821-10ca-23de061c5871@telenet.be> Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> <268A8657-46A1-489F-BE48-08378BCD0183@pantherx.org> In-Reply-To: <268A8657-46A1-489F-BE48-08378BCD0183@pantherx.org> --------------hWiZ0Q4xqQBt2JY3gptmrEsv Content-Type: multipart/mixed; boundary="------------l79vH6HKU0haA04Ayjo0773q" --------------l79vH6HKU0haA04Ayjo0773q Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTAtMDgtMjAyMiAxNjozNywgUGF2ZWwgU2hseWFrIHdyb3RlOg0KDQo+IE1heGltZSwg aG93IGlzIHlvdXIgaW5mb3JtYXRpb24gYWJvdXQgcGFudGhlcnggcmVsYXRlZCB0byB0aGUg cGF0Y2g/IFRoaXMgcGF0Y2ggaW4gcXVlc3Rpb24gbWFrZXMgZ3VpeCBib290bG9hZGVyIGNv bmZpZyBtb3JlIGZsZXhpYmxlIHdpdGggdGhlIHBlcnNwZWN0aXZlIG9mIHN1cHBvcnRpbmcg YWRkaXRpb25hbCBoYXJkd2FyZS4gSXQgZG9lc27igJl0IHJlbHkgb24gYW55IGNvbXBvbmVu dCBvZiBwYW50aGVyeCwgdGh1cyBJIGFtIG5vdCBzdXJlIGl04oCZcyB0aGUgcmlnaHQgcGxh Y2UgdG8gZGlzY3VzcyB0aGF0Lg0KDQpUaGUgcGF0Y2ggYXBwZWFycyB0byBiZSBieSBQYW50 aGVyWCAoc2VlOiB0aGUgQHBhbnRlcngub3JnIG1haWwgYWRkcmVzcywgDQp0aGUgdXNlIG9m ICJ3ZSIgYW5kIHRoZSBjb3Jwb3JhdGUgcGhyYXNpbmcpLiBUaGUgbWFpbCBhc2tzIGZvciBm ZWVkYmFjaywgDQpzbyBJIGdpdmUgZmVlZGJhY2suIEl0IGFwcGVhcnMgdGhhdCBQYW50aGVy WCB3aWxsIGludGVyYWN0IHdpdGggR3VpeCBpbiANCnRoZSBmdXR1cmU7IFBhbnRoZXJYIG1h a2luZyBmYWxzZSBvciBtaXNsZWFkaW5nIGNsYWltcyBtYWtlcyBtZSBsZXNzIA0KaW50ZXJl c3RlZCBpbiByZXZpZXdpbmcgcGF0Y2hlcywgc28gdGhpcyBzZWVtcyBpbXBvcnRhbnQgZmVl ZGJhY2sgdG8gZ2l2ZS4NCg0KSSBjb3VsZCBvZiBjb3Vyc2Ugb3V0LW9mLXRoZS1ibHVlIHNl bmQgYSBtYWlsIHRvIHdoYXRldmVyIFBhbnRoZXJYIG1haW4gDQplLW1haWwgYWRkcmVzcyBp cywgYnV0IEknbSBub3QgYSBjdXN0b21lciBvZiBQYW50aGVyWCwgc28gdGhhdCB3b3VsZCAN CnNlZW0gdG8gYmUgYSBwb2ludGxlc3MgZW5kZWF2b3IgdG8gbWUgLS0gaWYgaXQncyBhbnl0 aGluZyBsaWtlIG90aGVyIA0KY29tcGFuaWVzLCBpdCB3aWxsIGp1c3QgYmUgbW92ZWQgaW50 byB0aGUgdHJhc2guwqAgSSBiZWxpZXZlIHRoYXQgDQpkaXJlY3RseSByZXNwb25kaW5nIHRv IHRoZSBhcHBhcmVudCBlbXBsb3llZSBvZiBQYW50aGVyWCAoYW5kIGF0IHRoZSANCnNhbWUg dGltZSB3cml0aW5nIHNvbWUgbW9yZSB0ZWNobmljYWwgY29tbWVudHMpIGhhcyBoaWdoZXIg Y2hhbmNlcyBvZiANCnN1Y2Nlc3MuDQoNClN1bW1hcmlzZWQ6IHRoaXMgc2VlbXMgYSBnb29k IHBsYWNlIHRvIG1ha2Ugc3VjaCBjb21tZW50cyBhbmQgSSdtIG5vdCANCmF3YXJlIG9mIGFu eSBiZXR0ZXIgcGxhY2VzLg0KDQpHcmVldGluZ3MsDQpNYXhpbWUuDQoNCg== --------------l79vH6HKU0haA04Ayjo0773q Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------l79vH6HKU0haA04Ayjo0773q-- --------------hWiZ0Q4xqQBt2JY3gptmrEsv-- --------------VHITKgQolj70LXX0rzaAfMi0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYvTTSAUDAAAAAAAKCRBJ4+4iGRcl7nts AQCt7lS+bdyilcw+qbPUAbhAPdVPlcGa++GPjWQy+BDB6gD/UKyfYEttoRhP/FoYU9yqIMI34f8Y GZ51ylj/kaNxFwA= =sdLD -----END PGP SIGNATURE----- --------------VHITKgQolj70LXX0rzaAfMi0-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 11 07:13:43 2022 Received: (at 57070) by debbugs.gnu.org; 11 Aug 2022 11:13:43 +0000 Received: from localhost ([127.0.0.1]:51874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM68F-0006f0-5c for submit@debbugs.gnu.org; Thu, 11 Aug 2022 07:13:43 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:42901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM68A-0006eh-Cf for 57070@debbugs.gnu.org; Thu, 11 Aug 2022 07:13:41 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id B75C43200934; Thu, 11 Aug 2022 07:13:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 11 Aug 2022 07:13:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1660216411; x=1660302811; bh=oWGxGif5iS jEtmcYVwW/+l2nzpNMQqqsaTuhTAbO1G8=; b=gaFO7JdoIGtsRelaygxhpRl6FK j2dmI9ZLtku6QinL9YiHjeiKC1/jGQzKOlY4LoHe8+F9+n9U1vAB8elZrkFyzBtX 0HUjxsHMBrZMbwwvOZ5Z0A5T71IYJRAEWLzszb9vSB9ypJme6C+sKSn3+wH3bOE2 ajLF/dLMcg7tO9teLQcVODGosaHkjSRe0qTlMAPJ3z6kK4Ppl6ZFdayjReJCYsDj FFFcwfv6Pleg0gWMS0Awt1EafCVfVRjaYBVDpJ4Cv/Px+kaVBUGPnNGiVDe1uEdS F0PHR6mPqfVCUH/ttD1AAU7HzMxX9StZLS0pN5HNmaD4wlUkwYoCkNSRBMcA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660216411; x=1660302811; bh=oWGxGif5iSjEtmcYVwW/+l2nzpNM QqqsaTuhTAbO1G8=; b=kaljSGmzFcNNlhs853eQBlEJG6B6TW+WFHSd+9EgS3wS OQqY2r0oqCijueXMeVUvhO1p7BbPEVla6WxOyHLXMpA/qHYeYcmLqDvRILVxuw63 7jQKlkxWAdzdUo6FX6kJ3xN2kjhbh7VkxAX7NC2tCpfR3NOohz4qrRDF243ii0an /A1AbesANEcSoGahC4YLrBTyCw6FZNFV4QQ3Ie0mTjS67sq3aAPpB6JG+PvP4LTv mLi6aPcwTMdMW/mULo3+TEekMlzKDiuonI1orfboiBBenu+8tOhtHVyf6XAJayj5 0nalKP+NXY+vcfoQud16pNxqyTCgc63Fn3630CW30w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeggedgfeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdtjeenucfhrhhomheprfgrvhgv lhcuufhhlhihrghkuceophdrshhhlhihrghksehprghnthhhvghrgidrohhrgheqnecugg ftrfgrthhtvghrnhephfejudeljeejieelffehheefudejhffgudelgfeihfettdekueeu veeuleeltddunecuffhomhgrihhnpehprghnthhhvghrgidrohhrghenucevlhhushhtvg hrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgr nhhthhgvrhigrdhorhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 11 Aug 2022 07:13:30 -0400 (EDT) From: Pavel Shlyak Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_745134D3-D6F1-4017-B84E-E6054232D368" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR Date: Thu, 11 Aug 2022 14:13:28 +0300 In-Reply-To: <43277e51-3340-4821-10ca-23de061c5871@telenet.be> To: Maxime Devos References: <20220809145730.435ef8d0@pantherx.org> <268A8657-46A1-489F-BE48-08378BCD0183@pantherx.org> <43277e51-3340-4821-10ca-23de061c5871@telenet.be> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_745134D3-D6F1-4017-B84E-E6054232D368 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hello, Maxime Firstly, we always welcome feedback and we=E2=80=99re glad to answer = your questions if you contact us directly. Here are the options: = https://www.pantherx.org/contact/ . = That might be a better place for it to avoid making other devs who=E2=80=99= re subscribed to the mailing list read about things they=E2=80=99re not = really into. Secondly, we=E2=80=99ve already taken some steps to correct the issues = you=E2=80=99ve mentioned on our website. I hope it will be clear and = polished by the time we publish the first PantherX release.=20 Finally, I=E2=80=99m personally glad and thankful that you=E2=80=99ve = found time to inspect our website. Even I, as a member of the team, = haven=E2=80=99t looked at it that closely :) P. S. Reza=E2=80=99s working on the tests now. It will just take some = time before he sends the following patch here. Sincerely, Pavel= --Apple-Mail=_745134D3-D6F1-4017-B84E-E6054232D368 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Hello, Maxime

Firstly, we always welcome feedback and we=E2=80=99re glad to = answer your questions if you contact us directly. Here are the = options: https://www.pantherx.org/contact/. That might be a better = place for it to avoid making other devs who=E2=80=99re subscribed to the = mailing list read about things they=E2=80=99re not really = into.
Secondly, we=E2=80=99ve already taken some steps to = correct the issues you=E2=80=99ve mentioned on our website. I hope it = will be clear and polished by the time we publish the first PantherX = release. 
Finally, I=E2=80=99m personally glad and = thankful that you=E2=80=99ve found time to inspect our website. Even I, = as a member of the team, haven=E2=80=99t looked at it that closely = :)

P. S. Reza=E2=80=99s working on the = tests now. It will just take some time before he sends the following = patch here.

Sincerely,
Pavel
= --Apple-Mail=_745134D3-D6F1-4017-B84E-E6054232D368-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 15 05:27:27 2022 Received: (at 57070) by debbugs.gnu.org; 15 Aug 2022 09:27:27 +0000 Received: from localhost ([127.0.0.1]:40874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNWNb-0007Dt-C0 for submit@debbugs.gnu.org; Mon, 15 Aug 2022 05:27:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNWNa-0007Df-4O for 57070@debbugs.gnu.org; Mon, 15 Aug 2022 05:27:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35536) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNWNU-0004Bk-SS; Mon, 15 Aug 2022 05:27:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=wYu4RkYBg92Z697M8t1vUygPtdb7BpdXLY7hR17ySW4=; b=MGvYL9gH1zu3FXHihbzY ptYF4LjFXhmL9rk6t4/Xh8dfrsrJ1a/j8opYbM263lVUc/HueJK7gDyjHpzKT9lGW9JnTs4CT4GlL 9hrKRFZ1wnGr1bXWJZLb3Ck6AHYTg386cKoLz+RLbhesy5qaCt7R/jUBvLearAHxQVKvdc/sOVUMD IMZWV4h3lUIYMSNguBEnaVmP2hqe1l2yDSKKygz+iZxIipU25Gx1D3I75NSAVOAWIxVliWeVWXIDd uD9ispEdaiVD3edaFVM/gzDLvPZhLxmj8ZnBBokTMKJABWW8EDdJJmZlz1Lw8f9eNu8VHn5LKUddI pgIN/aZTNm0kVA==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:51714 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNWNU-0005B2-GH; Mon, 15 Aug 2022 05:27:20 -0400 From: Mathieu Othacehe To: Reza Alizadeh Majd Subject: Re: bug#57070: [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> <20220809103044.27964-1-r.majd@pantherx.org> Date: Mon, 15 Aug 2022 11:27:19 +0200 In-Reply-To: <20220809103044.27964-1-r.majd@pantherx.org> (Reza Alizadeh Majd's message of "Tue, 9 Aug 2022 15:00:44 +0430") Message-ID: <87bksleu14.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > * gnu/bootloader.scm ()[ignore-fdtdir?]: new field. The bootloader record is supposed to be bootloader agnostic. This fdtdir naming thing seems to be extlinux specific. Should we maybe rename this field "device-tree-support?" Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 15 07:05:17 2022 Received: (at submit) by debbugs.gnu.org; 15 Aug 2022 11:05:17 +0000 Received: from localhost ([127.0.0.1]:40968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNXuH-0003d6-0Z for submit@debbugs.gnu.org; Mon, 15 Aug 2022 07:05:17 -0400 Received: from lists.gnu.org ([209.51.188.17]:39854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNXuC-0003cs-TR for submit@debbugs.gnu.org; Mon, 15 Aug 2022 07:05:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52230) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNXuA-0007v9-Ou for guix-patches@gnu.org; Mon, 15 Aug 2022 07:05:12 -0400 Received: from tobias.gr ([2a02:c205:2020:6054::1]:53100) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNXu8-0001oc-Ob for guix-patches@gnu.org; Mon, 15 Aug 2022 07:05:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=mDVYtqq5KLepq 1gNFaZYBMQoDqrRydc2h+L68nk455E=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=pS2p0yPHoqUzqO5P1jKMDsTLeEWFuxmwmRfpUT mibusOB6ReKwutnN4sRe0OjW1BsKa3SxXC/KXW4SCWqotp1Zujv7WQy39mTTe2v5lnEfPb 3s4Kl0uiGkyAmBxzunhT8wT2WaEUmUKF6QYBAm140I7lvarU8v+7bhYHBQDHn/mdzhC+5G HkgpmXppR5HCCpqLBbDN2vpRJTs4Ti4JmxxgDy0NvJitbBzK3tymgS/Ku/SZncFsJJvW32 qPp0vopqksLn9zFCZveWZq5lofD8hqORzPegxHPBax90YRJAgml+v9WjfUCsWO0VNoxArn 3NTmn1E18U+BpkvgmGXBPbEg== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 94e74d7e (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 15 Aug 2022 11:05:02 +0000 (UTC) References: <20220809145730.435ef8d0@pantherx.org> <2b867267-cfa3-07a9-99c9-b69c80f862ff@telenet.be> From: Tobias Geerinckx-Rice To: Maxime Devos Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR Date: Mon, 15 Aug 2022 12:57:32 +0200 In-reply-to: <2b867267-cfa3-07a9-99c9-b69c80f862ff@telenet.be> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87wnb9hin4.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 57070@debbugs.gnu.org, guix-patches@gnu.org, Reza Alizadeh Majd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Maxime Devos =E5=86=99=E9=81=93=EF=BC=9A > PantherX claiming it's the upstream of Guix (see tooltip of=20 > 'operating > system' on the home page), but that's incorrect, it's the other=20 > way > around. For the record: they did when Maxime posted this, but at least=20 that tooltip has since been corrected and now reads: =E2=80=98PantherX is a downstream distribution of GNU Guix and uses the Linux Kernel=E2=80=99 Keep on auditing everything, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCYvooXw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15TG0BAKcRsTOuECImc6D+ggJ2DhwyBvG6Fw+P3hT6Pa5l X+wOAQComt5o/5fYfGdxQo53mcXRZSPLOHtMtiS+XllbHmGpDQ== =tWn2 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 16 13:08:52 2022 Received: (at 57070) by debbugs.gnu.org; 16 Aug 2022 17:08:52 +0000 Received: from localhost ([127.0.0.1]:48173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO03f-0001Lc-M5 for submit@debbugs.gnu.org; Tue, 16 Aug 2022 13:08:52 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56143) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO03e-0001LP-0a for 57070@debbugs.gnu.org; Tue, 16 Aug 2022 13:08:51 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id ADF995C01A5; Tue, 16 Aug 2022 13:08:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 16 Aug 2022 13:08:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1660669724; x=1660756124; bh=9BTTCloGBh vQl+hnxdqS+upsU8DKTlrNK3VyivKQVC0=; b=Fjfr6mHPf6wrdX4StAJeXMn/ZU uELpkgXsnxCMs8xOdo3srjRTkq9QXoW7R/cS8iYCzDaUYe++17lg2xYuWSC7IogY 0KPMdYNwucARw0GC/fQi3T0CGl7au6v1itz53Hu7PD2RQ4DG36g8kUQa0svSECMq P3reTbtVrEvhPluPAfHckySuH4j4yC7e3IysQD1nL0X4FfYcPm6by1HP+A1QBGEc 9OWjcfgyadspVzn/E/l0BvxyOe5lWYmWc1JSkxvUZ02Eq30ohBX5EE2pBItVvOwm ifczxFZu4d6pdCxnqxjtUG+ymekQDY+jsWDSBfmt6xl9TskGrCSkg8T5eK8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660669724; x=1660756124; bh=9BTTCloGBhvQl+hnxdqS+upsU8DK TlrNK3VyivKQVC0=; b=DpBpPFiilo/BvNlC9P7WsanFwX6jh35S/qDna5hMhndo F3M+GLPoeTVZgYeTaDWlpwtgi07pPJS1x6LKWflp1nbelCT3MrT5l0rGl3vJeDn8 sGrJ0wh6zfTDvgDL9mXtQUJdLYa9f7hzoyKdd/dtZexhHccmmWhXC9RcshKFivDX 6XB9ZSB8lD5W+fbQ6QzssuDfYBPpYVaFAuEV/PxQyQwu2pmyXdDcig2sAvSFUTGw 2hcO+KV7TbVHDhWldD+a0+NOFsxjwI7hwd/Bz4Kl3EcxzmgGzRK7jK/Pnni0HWBo 6tpT/DETJZroda4XFcyiWACuhhh61GUt4MLWNwmnHQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehgedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfgjfhhoofggtgesmhdtreerredtvdenucfhrhhomheptfgv iigrucetlhhiiigruggvhhcuofgrjhguuceorhdrmhgrjhgusehprghnthhhvghrgidroh hrgheqnecuggftrfgrthhtvghrnhepvefhvdejueekhedthfelkeejjeduveeugfehhfel teduieduvefhgffhjefgfeeknecuffhomhgrihhnpehprghnthhhvghrgidrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrrdhmrghj ugesphgrnhhthhgvrhigrdhorhhg X-ME-Proxy: Feedback-ID: i063944dc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 16 Aug 2022 13:08:42 -0400 (EDT) Date: Tue, 16 Aug 2022 21:38:35 +0430 From: Reza Alizadeh Majd To: 57070@debbugs.gnu.org Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR Message-ID: <20220816213835.3e0dd301@pantherx.org> In-Reply-To: <59ee7050-d5b1-695a-4be4-c1f1856fbda7@telenet.be> References: <20220809145730.435ef8d0@pantherx.org> <59ee7050-d5b1-695a-4be4-c1f1856fbda7@telenet.be> Organization: PantherX X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/zBSExOms=cyn/fO1mDTv545" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: Mathieu Othacehe , Maxime Devos X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --MP_/zBSExOms=cyn/fO1mDTv545 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Sorry for the late response, I was a little busy to apply the suggested changes. On Wed, 10 Aug 2022 11:32:38 +0200 Maxime Devos wrote: >The VM thing sounds like a good system test, add it to gnu/tests/ so >we can verify it and avoid breaking things with future changes. I implemented the `gnu/tests/bootloader.scm` tests related to the changes we are proposing. also about other remarks you mentioned me directly, I applied them on my recent patch. > Can FDTDIR be set automatically or unset automatically depending on > the hardware? That would reduce the required configuration No, that's not possible. As I mentioned in the initial message, some hardware may or may not require it depending on the kernel. On Mon, 15 Aug 2022 11:27:19 +0200 Mathieu Othacehe wrote: >The bootloader record is supposed to be bootloader agnostic. This >fdtdir naming thing seems to be extlinux specific. > >Should we maybe rename this field "device-tree-support?" in the recent patch I renamed the `ignore-fdtdir?` parameter to the `device-tree-support?` Regards, Reza -- Reza Alizadeh Majd PantherX Team https://pantherx.org --MP_/zBSExOms=cyn/fO1mDTv545 Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-bootloader-extlinux-support-for-optional-FDTDIR.patch =46rom 06edac43226f8ef4bd45c973cd47c1ccd9d7da7a Mon Sep 17 00:00:00 2001 From: Reza Alizadeh Majd Date: Fri, 5 Aug 2022 20:00:42 +0430 Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR There are situations that u-boot doesn't have to load from the device tree. some provide the device tree using a vendor bootloader (like what raspberry= -pi does) or with an external bootloader that chainloads the u-boot (what Asahi does for m1n1 bootloader). Unfortunately we couldn't find any reliable document to enforce u-boot to p= ass the device tree via `extlinux.conf`, however during our tests, we found that removing the `FDTDIR` line from the `extlinux.conf` tend us to do so. There is also no reliable way to guess if u-boot bootloader should load dev= ice tree or not on a specific hardware. in addition, there are hardware that can be booted with both firmware device tree on some kernels and with special device tree on other (modified) kernels. the following changes provided to define an optional parameter in record, called which by default is set to #t to keep the current behavior unchanged. if this paramter is set to #f, the FDTDIR l= ine will be discarded from the and u-boot doesn't load the devi= ce tree automatically. * gnu/bootloader.scm ()[ignore-fdtdir?]: new field. * gnu/bootloader/extlinux.scm (extlinux-configuration-file): add FDTDIR line based on bootloader field of . * gnu/tests/bootloader.scm: add tests for FDTDIR modification. * gnu/local.mk (GNU_SYSTEM_MODULES): Add gnu/tests/bootloader.scm --- gnu/bootloader.scm | 6 +- gnu/bootloader/extlinux.scm | 13 +++- gnu/local.mk | 2 + gnu/tests/bootloader.scm | 119 ++++++++++++++++++++++++++++++++++++ 4 files changed, 137 insertions(+), 3 deletions(-) create mode 100644 gnu/tests/bootloader.scm diff --git a/gnu/bootloader.scm b/gnu/bootloader.scm index 9cf5457873..3793cc981f 100644 --- a/gnu/bootloader.scm +++ b/gnu/bootloader.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2017 Leo Famulari ;;; Copyright =C2=A9 2019, 2021 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd ;;; ;;; This file is part of GNU Guix. ;;; @@ -54,6 +55,7 @@ (define-module (gnu bootloader) bootloader-disk-image-installer bootloader-configuration-file bootloader-configuration-file-generator + bootloader-device-tree-support? =20 bootloader-configuration bootloader-configuration? @@ -173,7 +175,9 @@ (define-record-type* (disk-image-installer bootloader-disk-image-installer (default #f)) (configuration-file bootloader-configuration-file) - (configuration-file-generator bootloader-configuration-file-generator= )) + (configuration-file-generator bootloader-configuration-file-generator) + (device-tree-support? bootloader-device-tree-support? + (default #t))) =20 =0C ;;; diff --git a/gnu/bootloader/extlinux.scm b/gnu/bootloader/extlinux.scm index 6b5ff298e7..f3d69c0cc0 100644 --- a/gnu/bootloader/extlinux.scm +++ b/gnu/bootloader/extlinux.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2017 David Craven ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd ;;; ;;; This file is part of GNU Guix. ;;; @@ -38,6 +39,10 @@ (define* (extlinux-configuration-file config entries (define all-entries (append entries (bootloader-configuration-menu-entries config))) =20 + (define with-fdtdir? + (let ((bootloader (bootloader-configuration-bootloader config))) + (bootloader-device-tree-support? bootloader))) + (define (menu-entry->gexp entry) (let ((label (menu-entry-label entry)) (kernel (menu-entry-linux entry)) @@ -46,12 +51,16 @@ (define (menu-entry->gexp entry) #~(format port "LABEL ~a MENU LABEL ~a KERNEL ~a - FDTDIR ~a/lib/dtbs + ~a INITRD ~a APPEND ~a ~%" #$label #$label - #$kernel (dirname #$kernel) #$initrd + #$kernel + (if #$with-fdtdir? + (string-append "FDTDIR " (dirname #$kernel) "/lib/dtbs= ") + "") + #$initrd (string-join (list #$@kernel-arguments))))) =20 (define builder diff --git a/gnu/local.mk b/gnu/local.mk index 88100416d5..b430c664ea 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -51,6 +51,7 @@ # Copyright =C2=A9 2022 Remco van 't Veer # Copyright =C2=A9 2022 Artyom V. Poptsov # Copyright =C2=A9 2022 John Kehayias +# Copyright =C2=A9 2022 Reza Alizadeh Majd # # This file is part of GNU Guix. # @@ -736,6 +737,7 @@ GNU_SYSTEM_MODULES =3D \ %D%/tests.scm \ %D%/tests/audio.scm \ %D%/tests/base.scm \ + %D%/tests/bootloader.scm \ %D%/tests/ci.scm \ %D%/tests/cups.scm \ %D%/tests/databases.scm \ diff --git a/gnu/tests/bootloader.scm b/gnu/tests/bootloader.scm new file mode 100644 index 0000000000..0c3bffa58d --- /dev/null +++ b/gnu/tests/bootloader.scm @@ -0,0 +1,119 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu tests bootloader) + #:use-module (gnu) + #:use-module (gnu bootloader u-boot) + #:use-module (gnu system vm) + #:use-module (gnu tests) + #:use-module (guix scripts system reconfigure) + #:export (%test-uboot-with-fdtdir + %test-uboot-without-fdtdir)) + + +(define %u-boot-with-fdtdir-bootloader + (bootloader + (inherit u-boot-bootloader))) + + +(define %u-boot-without-fdtdir-bootloader + (bootloader + (inherit u-boot-bootloader) + (device-tree-support? #f))) + + +(define (u-boot-os with-fdtdir?) + (operating-system + (inherit %simple-os) + (bootloader (bootloader-configuration + (bootloader (if with-fdtdir? + %u-boot-with-fdtdir-bootloader + %u-boot-without-fdtdir-bootloader)))))) + + +(define* (run-uboot-fdtdir-test name #:key (with-fdtdir? #t)) + "Run u-boot-bootloader installation with/without FDTDIR record for +extlinux.conf" + + (define os + (marionette-operating-system + (u-boot-os with-fdtdir?))) + + (define vm (virtual-machine + (operating-system os) + (volatile? #f))) + + (define (test script) + (with-imported-modules '((gnu build marionette)) + #~(begin + (use-modules (gnu build marionette) + (srfi srfi-64)) + + (define marionette + (make-marionette (list #$vm))) + + (test-runner-current (system-test-runner #$output)) + (test-begin #$name) + + (test-assert "bootloader installed" + (marionette-eval + '(primitive-load #$script) + marionette)) + + (test-assert "extlinux.conf file created" + (marionette-eval + '(file-exists? "/boot/extlinux/extlinux.conf") + marionette)) + + (let ((content (wait-for-file "/boot/extlinux/extlinux.conf" mar= ionette + #:read 'get-string-all + #:timeout 30))) + (if #$with-fdtdir? + (test-assert "FDTDIR exists" + (string-contains content "FDTDIR")) + (test-assert "FDTDIR removed" + (not (string-contains content "FDTDIR"))))) + + (test-end #$name)))) + + (let* ((bootcfg (operating-system-bootcfg os '())) + (bootloader ((compose bootloader-configuration-bootloader + operating-system-bootloader) os)) + (bootcfg-file (bootloader-configuration-file bootloader))) + (gexp->derivation "uboot" + (test (install-bootloader-program #f #f #f bootcfg bootcfg-file + '(#f) "/"))))) + + +(define %test-uboot-with-fdtdir + (system-test + (name "uboot-with-fdtdir") + (description "test uboot installation with fdtdir") + (value + (run-uboot-fdtdir-test "uboot-with-fdtdir" + #:with-fdtdir? #t)))) + + +(define %test-uboot-without-fdtdir + (system-test + (name "uboot-without-fdtdir") + (description "test uboot installation without fdtdir") + (value + (run-uboot-fdtdir-test "uboot-without-fdtdir" + #:with-fdtdir? #f)))) --=20 2.37.1 --MP_/zBSExOms=cyn/fO1mDTv545-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 16 14:10:22 2022 Received: (at 57070) by debbugs.gnu.org; 16 Aug 2022 18:10:22 +0000 Received: from localhost ([127.0.0.1]:48263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO118-0005Gf-7j for submit@debbugs.gnu.org; Tue, 16 Aug 2022 14:10:21 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:38689) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO115-0005GH-MZ for 57070@debbugs.gnu.org; Tue, 16 Aug 2022 14:10:17 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 421165C0235 for <57070@debbugs.gnu.org>; Tue, 16 Aug 2022 14:10:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 16 Aug 2022 14:10:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1660673410; x=1660759810; bh=g9xF9BC1df mKq8ZevJJPjZEIotdvs8p7n6NLm0paAbU=; b=kXNaJUz1e+AkXu4PhDHeIfhhzJ CstMGNjY5+E+oUqyFLtBVupb6XHUHl4pKB3k1VRx9PLK7mFHgPgVMrgfv1Q4YwvY 4z2N0BhaPj+NjpQI0uWIGgxN3KtLKP2K1/E7o1Cli9QuA8muQ58QxPgty9Ee9xqY ZRmCzFD1AuJrBIBHuSdB0hGXYAZfKOWP7S34zkIVFmCin6mHdEAvgSJHhToYafMf MRiOuzCpIGWOF8kBDP/CQDpGexVIYPRQzbfdZGZTMHUTqag37wMHskFxXwOZuEs1 QjzlRbpBWjfdpocxy7d153cBoiQ3oQYxjdsvIvtra8zkgeu6YSsaFXVdkdDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660673410; x=1660759810; bh=g9xF9BC1dfmKq8ZevJJPjZEIotdv s8p7n6NLm0paAbU=; b=qq8Y9nUjXIH+V5G0/hsnAzcMrkAkfCLa5Abaz6B96VoH NgFPHwtAfWCqP8nUu8pPiP2EtQtuauBgiPZ+OSN3R2SpfD40b7pVvkhPAGLp0t3B LqB7MnXqRBVSuTl84//w1f9DPJyIMLuQeqiG/qPsdu7AYUOySKupK5vNyOtrD1tF /BzhzSLNl84uiJQEBa06jHzPxv/jmekDyhzpDRiyBwWGIuokU3HMWVTCAQ8+pPM8 vY2i5zOqLSC3chab4aRz71ktionBQxiNemqxuLCTZhhPKDrC2cIJU52l15MdSnCF QfErXUrTwPd5R6QyUy21BOPJ3ciA5eo1yyG6xuXVdw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdehgedguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfgjfhhoofggtgesmh dtreerredtvdenucfhrhhomheptfgviigrucetlhhiiigruggvhhcuofgrjhguuceorhdr mhgrjhgusehprghnthhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepfeeigeduke elvdelgfetjefgleeliedtieetuefhvdevheetgfeutdeghfduveevnecuffhomhgrihhn pehprghnthhhvghrgidrohhrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehrrdhmrghjugesphgrnhhthhgvrhigrdhorhhg X-ME-Proxy: Feedback-ID: i063944dc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <57070@debbugs.gnu.org>; Tue, 16 Aug 2022 14:10:09 -0400 (EDT) Date: Tue, 16 Aug 2022 22:40:04 +0430 From: Reza Alizadeh Majd To: 57070@debbugs.gnu.org Subject: Re: [PATCH] bootloader: extlinux: support for optional FDTDIR Message-ID: <20220816224004.1744c1d5@pantherx.org> In-Reply-To: <20220809103044.27964-1-r.majd@pantherx.org> References: <20220809103044.27964-1-r.majd@pantherx.org> Organization: PantherX X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/B1.F1lOKa6kiV.4yCSe/JM=" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --MP_/B1.F1lOKa6kiV.4yCSe/JM= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline It seems that I forgot to update some parts of the commit message, I just submitted the edited one. -- Reza Alizadeh Majd PantherX Team https://pantherx.org --MP_/B1.F1lOKa6kiV.4yCSe/JM= Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-bootloader-extlinux-support-for-optional-FDTDIR.patch =46rom eaa1c6db1e5a8a059f499c904861d8270194faf6 Mon Sep 17 00:00:00 2001 From: Reza Alizadeh Majd Date: Fri, 5 Aug 2022 20:00:42 +0430 Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR There are situations that u-boot doesn't have to load from the device tree. some provide the device tree using a vendor bootloader (like what raspberry= -pi does) or with an external bootloader that chainloads the u-boot (what Asahi does for m1n1 bootloader). Unfortunately we couldn't find any reliable document to enforce u-boot to p= ass the device tree via `extlinux.conf`, however during our tests, we found that removing the `FDTDIR` line from the `extlinux.conf` tend us to do so. There is also no reliable way to guess if u-boot bootloader should load dev= ice tree or not on a specific hardware. in addition, there are hardware that can be booted with both firmware device tree on some kernels and with special device tree on other (modified) kernels. the following changes provided to define an optional parameter in record, called which by default is set to #t to keep the current behavior unchanged. if this paramter is set to #f, the FDTDIR l= ine will be discarded from the and u-boot doesn't load the devi= ce tree automatically. * gnu/bootloader.scm ()[device-tree-support?]: new field. * gnu/bootloader/extlinux.scm (extlinux-configuration-file): add FDTDIR line based on bootloader field of . * gnu/tests/bootloader.scm: add tests for FDTDIR modification. * gnu/local.mk (GNU_SYSTEM_MODULES): Add gnu/tests/bootloader.scm --- gnu/bootloader.scm | 6 +- gnu/bootloader/extlinux.scm | 13 +++- gnu/local.mk | 2 + gnu/tests/bootloader.scm | 119 ++++++++++++++++++++++++++++++++++++ 4 files changed, 137 insertions(+), 3 deletions(-) create mode 100644 gnu/tests/bootloader.scm diff --git a/gnu/bootloader.scm b/gnu/bootloader.scm index 9cf5457873..3793cc981f 100644 --- a/gnu/bootloader.scm +++ b/gnu/bootloader.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2017 Leo Famulari ;;; Copyright =C2=A9 2019, 2021 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd ;;; ;;; This file is part of GNU Guix. ;;; @@ -54,6 +55,7 @@ (define-module (gnu bootloader) bootloader-disk-image-installer bootloader-configuration-file bootloader-configuration-file-generator + bootloader-device-tree-support? =20 bootloader-configuration bootloader-configuration? @@ -173,7 +175,9 @@ (define-record-type* (disk-image-installer bootloader-disk-image-installer (default #f)) (configuration-file bootloader-configuration-file) - (configuration-file-generator bootloader-configuration-file-generator= )) + (configuration-file-generator bootloader-configuration-file-generator) + (device-tree-support? bootloader-device-tree-support? + (default #t))) =20 =0C ;;; diff --git a/gnu/bootloader/extlinux.scm b/gnu/bootloader/extlinux.scm index 6b5ff298e7..f3d69c0cc0 100644 --- a/gnu/bootloader/extlinux.scm +++ b/gnu/bootloader/extlinux.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2017 David Craven ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd ;;; ;;; This file is part of GNU Guix. ;;; @@ -38,6 +39,10 @@ (define* (extlinux-configuration-file config entries (define all-entries (append entries (bootloader-configuration-menu-entries config))) =20 + (define with-fdtdir? + (let ((bootloader (bootloader-configuration-bootloader config))) + (bootloader-device-tree-support? bootloader))) + (define (menu-entry->gexp entry) (let ((label (menu-entry-label entry)) (kernel (menu-entry-linux entry)) @@ -46,12 +51,16 @@ (define (menu-entry->gexp entry) #~(format port "LABEL ~a MENU LABEL ~a KERNEL ~a - FDTDIR ~a/lib/dtbs + ~a INITRD ~a APPEND ~a ~%" #$label #$label - #$kernel (dirname #$kernel) #$initrd + #$kernel + (if #$with-fdtdir? + (string-append "FDTDIR " (dirname #$kernel) "/lib/dtbs= ") + "") + #$initrd (string-join (list #$@kernel-arguments))))) =20 (define builder diff --git a/gnu/local.mk b/gnu/local.mk index 88100416d5..b430c664ea 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -51,6 +51,7 @@ # Copyright =C2=A9 2022 Remco van 't Veer # Copyright =C2=A9 2022 Artyom V. Poptsov # Copyright =C2=A9 2022 John Kehayias +# Copyright =C2=A9 2022 Reza Alizadeh Majd # # This file is part of GNU Guix. # @@ -736,6 +737,7 @@ GNU_SYSTEM_MODULES =3D \ %D%/tests.scm \ %D%/tests/audio.scm \ %D%/tests/base.scm \ + %D%/tests/bootloader.scm \ %D%/tests/ci.scm \ %D%/tests/cups.scm \ %D%/tests/databases.scm \ diff --git a/gnu/tests/bootloader.scm b/gnu/tests/bootloader.scm new file mode 100644 index 0000000000..0c3bffa58d --- /dev/null +++ b/gnu/tests/bootloader.scm @@ -0,0 +1,119 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + + +(define-module (gnu tests bootloader) + #:use-module (gnu) + #:use-module (gnu bootloader u-boot) + #:use-module (gnu system vm) + #:use-module (gnu tests) + #:use-module (guix scripts system reconfigure) + #:export (%test-uboot-with-fdtdir + %test-uboot-without-fdtdir)) + + +(define %u-boot-with-fdtdir-bootloader + (bootloader + (inherit u-boot-bootloader))) + + +(define %u-boot-without-fdtdir-bootloader + (bootloader + (inherit u-boot-bootloader) + (device-tree-support? #f))) + + +(define (u-boot-os with-fdtdir?) + (operating-system + (inherit %simple-os) + (bootloader (bootloader-configuration + (bootloader (if with-fdtdir? + %u-boot-with-fdtdir-bootloader + %u-boot-without-fdtdir-bootloader)))))) + + +(define* (run-uboot-fdtdir-test name #:key (with-fdtdir? #t)) + "Run u-boot-bootloader installation with/without FDTDIR record for +extlinux.conf" + + (define os + (marionette-operating-system + (u-boot-os with-fdtdir?))) + + (define vm (virtual-machine + (operating-system os) + (volatile? #f))) + + (define (test script) + (with-imported-modules '((gnu build marionette)) + #~(begin + (use-modules (gnu build marionette) + (srfi srfi-64)) + + (define marionette + (make-marionette (list #$vm))) + + (test-runner-current (system-test-runner #$output)) + (test-begin #$name) + + (test-assert "bootloader installed" + (marionette-eval + '(primitive-load #$script) + marionette)) + + (test-assert "extlinux.conf file created" + (marionette-eval + '(file-exists? "/boot/extlinux/extlinux.conf") + marionette)) + + (let ((content (wait-for-file "/boot/extlinux/extlinux.conf" mar= ionette + #:read 'get-string-all + #:timeout 30))) + (if #$with-fdtdir? + (test-assert "FDTDIR exists" + (string-contains content "FDTDIR")) + (test-assert "FDTDIR removed" + (not (string-contains content "FDTDIR"))))) + + (test-end #$name)))) + + (let* ((bootcfg (operating-system-bootcfg os '())) + (bootloader ((compose bootloader-configuration-bootloader + operating-system-bootloader) os)) + (bootcfg-file (bootloader-configuration-file bootloader))) + (gexp->derivation "uboot" + (test (install-bootloader-program #f #f #f bootcfg bootcfg-file + '(#f) "/"))))) + + +(define %test-uboot-with-fdtdir + (system-test + (name "uboot-with-fdtdir") + (description "test uboot installation with fdtdir") + (value + (run-uboot-fdtdir-test "uboot-with-fdtdir" + #:with-fdtdir? #t)))) + + +(define %test-uboot-without-fdtdir + (system-test + (name "uboot-without-fdtdir") + (description "test uboot installation without fdtdir") + (value + (run-uboot-fdtdir-test "uboot-without-fdtdir" + #:with-fdtdir? #f)))) --=20 2.37.1 --MP_/B1.F1lOKa6kiV.4yCSe/JM=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 16 14:44:50 2022 Received: (at 57070) by debbugs.gnu.org; 16 Aug 2022 18:44:50 +0000 Received: from localhost ([127.0.0.1]:48310 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO1YX-00068o-K6 for submit@debbugs.gnu.org; Tue, 16 Aug 2022 14:44:49 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:58964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oO1YU-00068b-Kc for 57070@debbugs.gnu.org; Tue, 16 Aug 2022 14:44:48 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id 8Jkk2800A20ykKC01Jkkux; Tue, 16 Aug 2022 20:44:45 +0200 Message-ID: <2ea79bba-ad84-56ad-e907-61481401ac6d@telenet.be> Date: Tue, 16 Aug 2022 20:44:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Reza Alizadeh Majd , 57070@debbugs.gnu.org References: <20220809145730.435ef8d0@pantherx.org> <59ee7050-d5b1-695a-4be4-c1f1856fbda7@telenet.be> <20220816213835.3e0dd301@pantherx.org> From: Maxime Devos Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR In-Reply-To: <20220816213835.3e0dd301@pantherx.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------IuxxoPoL8UyN1TZ7wmgNWqP0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1660675485; bh=blQcz32BwOvfDkl8zZtf/ivMcWV4oeHZQgnirGzWQEc=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=dORsT4+TbO0DyupZUzUbKdE3oj/PFW+dgaaK/b0tR5ITqhZ7TF8J7xq+w1XCrcrVN wreW1EIKdwXdTnHfEamvJWC/rqik3r+Q4B+bgYewDIw4Ol2FOyL3emoO4pY103NgMp pDUPSlt4oAM1uO0NBBU7VoTb0Lp2jlF8T8Y5OXWyXLK7ek/U83VbyOuGhi4yTY4HSK BauYdHpZ0CCTU5SOy9xU1fXVNSvUYvLdK9DMYtQmonZrb0gdA/++JNnrEAI4gd5qW/ Iz5JPNCB9VAqJ323SEQHEOHoyLFPga4R50/7MhT2AwHGiWXwyRETCWHMW7YZT3rEav upMlhmZd2yCNw== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57070 Cc: Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------IuxxoPoL8UyN1TZ7wmgNWqP0 Content-Type: multipart/mixed; boundary="------------X0uRUHYxl8hDUTwl6kYsqvG4"; protected-headers="v1" From: Maxime Devos To: Reza Alizadeh Majd , 57070@debbugs.gnu.org Cc: Mathieu Othacehe Message-ID: <2ea79bba-ad84-56ad-e907-61481401ac6d@telenet.be> Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> <59ee7050-d5b1-695a-4be4-c1f1856fbda7@telenet.be> <20220816213835.3e0dd301@pantherx.org> In-Reply-To: <20220816213835.3e0dd301@pantherx.org> --------------X0uRUHYxl8hDUTwl6kYsqvG4 Content-Type: multipart/mixed; boundary="------------00XbY6bvreRvagddtQnCyvKg" --------------00XbY6bvreRvagddtQnCyvKg Content-Type: multipart/alternative; boundary="------------UrD707Lb0oKzLpLXPopciZ01" --------------UrD707Lb0oKzLpLXPopciZ01 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAxNi0wOC0yMDIyIDE5OjA4LCBSZXphIEFsaXphZGVoIE1hamQgd3JvdGU6DQo+PiBD YW4gRkRURElSIGJlIHNldCBhdXRvbWF0aWNhbGx5IG9yIHVuc2V0IGF1dG9tYXRpY2FsbHkg ZGVwZW5kaW5nIG9uDQo+PiB0aGUgaGFyZHdhcmU/IFRoYXQgd291bGQgcmVkdWNlIHRoZSBy ZXF1aXJlZCBjb25maWd1cmF0aW9uDQo+IE5vLCB0aGF0J3Mgbm90IHBvc3NpYmxlLiBBcyBJ IG1lbnRpb25lZCBpbiB0aGUgaW5pdGlhbCBtZXNzYWdlLCBzb21lDQo+IGhhcmR3YXJlIG1h eSBvciBtYXkgbm90IHJlcXVpcmUgaXQgZGVwZW5kaW5nIG9uIHRoZSBrZXJuZWwuDQoNCk15 IHF1ZXN0aW9uIGhhcyBhIHBhcnQgJ2RlcGVuZGluZyBvbiB0aGUgaGFyZHdhcmUnLCBzbyBw b3NzaWJseSB0aGUgDQpyZWxldmFudCBjb2RlIGNvdWxkIGNoZWNrIHdoYXQgdGhlIGhhcmR3 YXJlIGlzLsKgIExpa2V3aXNlLCB0aGUgY29kZSANCmNvdWxkIGNoZWNrIHRoZSBrZXJuZWwg dmVyc2lvbi7CoCBNb3JlIGdlbmVyYWxseSwgd2hlbiBzb21ldGhpbmcgY2FuIGJlIA0KZGVj aWRlZCBtYW51YWxseSwgaXQgY2FuIG9mdGVuIGJlIGRldGVjdGVkIGF1dG9tYXRpY2FsbHkg d2l0aCBzb21lIA0Kd29yay7CoCBJJ20gbm90IHNlZWluZyBhbnkgaW1wb3NzaWJpbGl0eSBo ZXJlLg0KDQpBbHNvLCBhZ2Fpbiwgd2h5IGFyZSB5b3Ugc3VibWl0dGluZyB0aGlzIHdvcmst YXJvdW5kIHdoZW4gaXQgYXBwZWFycyB0byANCmJlIHNpbXBseSBhIGtlcm5lbCBidWcgdGhh dCBuZWVkcyBhIGtlcm5lbCBwYWNrYWdlIHRvIGJlIHVwZGF0ZWQgYW5kIA0KbWF5YmUgYSBk ZXZpY2V0cmVlIGZpeCB0byBiZSBiYWNrcG9ydGVkPyBBcyB3cml0dGVuIGluIGEgcHJldmlv dXMgcmVzcG9uc2U6DQoNCj4g4oCYVGhlcmUgaXMgYWxzbyBubyByZWxpYWJsZSB3YXkgdG8g Z3Vlc3MgaWYgdS1ib290IGJvb3Rsb2FkZXIgc2hvdWxkIGxvYWQNCj4gZGV2aWNlIHRyZWUg b3Igbm90IG9uIGEgc3BlY2lmaWMgaGFyZHdhcmUuIGluIGFkZGl0aW9uLCB0aGVyZSBhcmUN Cj4gaGFyZHdhcmUgdGhhdCBjYW4gYmUgYm9vdGVkIHdpdGggYm90aCBmaXJtd2FyZSBkZXZp Y2UgdHJlZSBvbiBzb21lDQo+IGtlcm5lbHMgYW5kIHdpdGggc3BlY2lhbCBkZXZpY2UgdHJl ZSBvbiBvdGhlciAobW9kaWZpZWQpIGtlcm5lbHMu4oCZDQo+DQo+IElmIEknbSBndWVzc2lu ZyBjb3JyZWN0bHksIHRoYXQgc291bmRzIGxpa2UgdGhlIHByb2JsZW0gaXMgdGhhdCBkZXZp Y2UgDQo+IHRyZWUgaW5mb3JtYXRpb24gaXMgbWlzc2luZyBmcm9tIHRoZSBrZXJuZWwuIFBy b3Bvc2FsOiB1cHN0cmVhbSB0aGUgDQo+IGRldmljZSB0cmVlIGluZm9ybWF0aW9uLg0KDQpH cmVldGluZ3MsDQpNYXhpbWUuDQoNCg== --------------UrD707Lb0oKzLpLXPopciZ01 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 16-08-2022 19:08, Reza Alizadeh Maj= d wrote:
Can FDTDIR be set automati=
cally or unset automatically depending on
the hardware? That would reduce the required configuration

No, that's not possible. As =
I mentioned in the initial message, some
hardware may or may not require it depending on the kernel.

My question has a part 'depending on the hardware', so possibly the relevant code could check what the hardware is.=C2=A0 Likewise,= the code could check the kernel version.=C2=A0 More generally, when something can be decided manually, it can often be detected automatically with some work.=C2=A0 I'm not seeing any impossibilit= y here.

Also, again, why are you submitting this work-around when it appears to be simply a kernel bug that needs a kernel package to be updated and maybe a devicetree fix to be backported? As written in a previous response:

=E2=80=98There is also no =
reliable way to guess if u-boot bootloader should load
device tree or not on a specific hardware. in addition, there are
hardware that can be booted with both firmware device tree on some
kernels and with special device tree on other (modified) kernels.=E2=80=99=
If I'm guessing correctly, that sounds like the problem is that device tree information is missing from the kernel. Proposal: upstream the device tree information.

Greetings,
Maxime.

--------------UrD707Lb0oKzLpLXPopciZ01-- --------------00XbY6bvreRvagddtQnCyvKg Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------00XbY6bvreRvagddtQnCyvKg-- --------------X0uRUHYxl8hDUTwl6kYsqvG4-- --------------IuxxoPoL8UyN1TZ7wmgNWqP0 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYvvlnAUDAAAAAAAKCRBJ4+4iGRcl7oF4 AP929H2zENzqsTAVgR4T3flZ0ovTxKJd7KdVM1toj039nAEA5ZeWL9hLOnAbtj9xrgePzp9DZMv2 BjvvANdRQpxysgg= =Izml -----END PGP SIGNATURE----- --------------IuxxoPoL8UyN1TZ7wmgNWqP0-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 20 06:15:53 2022 Received: (at 57070) by debbugs.gnu.org; 20 Aug 2022 10:15:53 +0000 Received: from localhost ([127.0.0.1]:59640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPLWD-00070t-3j for submit@debbugs.gnu.org; Sat, 20 Aug 2022 06:15:53 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:50007) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPLWA-00070f-Oj for 57070@debbugs.gnu.org; Sat, 20 Aug 2022 06:15:51 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id CA3AE32002E8 for <57070@debbugs.gnu.org>; Sat, 20 Aug 2022 06:15:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 20 Aug 2022 06:15:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1660990544; x=1661076944; bh=cUHs8I5e33 F80mC+QUH5Tmi6OCFX0KWoB/Is2ZakZWY=; b=aHVV/09SfYW8nOc32iZhE2Utus n7AfnqZtiJWHHHKQlMwbbK8FJbDPKdQzhwUjCNXBaXuoODZq/EhezNvQKQKOYCnk cTjJjVVrGid+znXdS+UNnZehKQn/9CQmOWDCSn/mcFZ3i6ho5nlAgHwn7y/fNzY0 9WSB8onHKYSchQi2tLk3Z9EQ+Mnl0TDD8KA652ccPaqIOiQrp6RCRmPdryPxMotX ChTTDcln3T/PKqSVP3OopcwCj9efaQLXs2v/bbplBwNEbF5xsbQ3pKeFKl55Nlky mT4VNUa0o/VuZbxuqZTCvPRQMS+DklFBckKly1GmBsWtu3MUJJv7DpMUOSBw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1660990544; x=1661076944; bh=cUHs8I5e33F80mC+QUH5Tmi6OCFX 0KWoB/Is2ZakZWY=; b=cSgohrjxoVM2KTZ1w96NeIpQehnNn53MkQ2yxX99xqiI iRioQdJ3Mb+WxYHnVtxt6/OlAypeQf3gWRLcL0VigZ+eimDxpYB/rBnRolyAI9iY aO/lgdC32Vr9cOYC/zAHwlGgs7ORlNbHBWitKFJyuCdDFLZZJkmSI3mMb1/8Ho6P FztFvjKBs5ZvAu39a/z5ydpEbucXKfMh6MgCdJBDyC5XgflVfdVj7NA+sRZq3L2M eVwe1y89gVNij583ILUygJ+dBfiRxe9aOJR8rtOPYUWNhSfzDXpA9eZd23bC8dIf YN+CpqkUJLJz8EsJfd63K+vFB45RSjMYj5U3gPo5rQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeifedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhtgfgggfukfffvffosehtqhhmtd hhtdejnecuhfhrohhmpefrrghvvghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgr nhhthhgvrhigrdhorhhgqeenucggtffrrghtthgvrhhnpefgieffleefuedvteektdduhf ekheejgeejtdekveefheekhfdvkeejleefgfdttdenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehprdhshhhlhigrkhesphgrnhhthhgvrhigrd horhhg X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <57070@debbugs.gnu.org>; Sat, 20 Aug 2022 06:15:43 -0400 (EDT) From: Pavel Shlyak Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR Message-Id: <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> Date: Sat, 20 Aug 2022 13:15:38 +0300 To: 57070@debbugs.gnu.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Dear Maxime, I do not think I can agree that =C2=ABa relevant code could check what = the hardware is=C2=BB as it=E2=80=99s not hardware-defined, but also = user-defined. It=E2=80=99s not just about detection, it=E2=80=99s also = about choice. The same system definition I have on RPI4, for example, = can boot both with kernel-provided FDT (loaded with uboot) and = bootloader-provided FDT (loaded with RPI bootloader). There are also a = lot of different devices out there on the market and there=E2=80=99s no = common way to know how OS definition is written for it. If you have = ideas - you=E2=80=99re welcome to propose your way to do it. It does not appear to =C2=ABbe simply a kernel bug=C2=BB to me. Kernel = does not pass configuration to the bootloader and we=E2=80=99re = configuring a bootloader entry here. It=E2=80=99s simple as that: = bootloader entry may include or not include that line and that=E2=80=99s = user-defined. Of course, you=E2=80=99re always welcome to suggest your ideas how the = automation you like to have could be implemented. Also, please, keep in = mind this change doesn=E2=80=99t change anything on current = boards/systems and most users won=E2=80=99t even notice this change is = merged. Sincerely, Pavel Shlyak= From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 04:54:14 2022 Received: (at 57070) by debbugs.gnu.org; 22 Aug 2022 08:54:15 +0000 Received: from localhost ([127.0.0.1]:37766 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ3CI-0004Mo-IZ for submit@debbugs.gnu.org; Mon, 22 Aug 2022 04:54:14 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:53036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ3CF-0004Md-Eb for 57070@debbugs.gnu.org; Mon, 22 Aug 2022 04:54:12 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by michel.telenet-ops.be with bizsmtp id AYu72800520ykKC06Yu7Xn; Mon, 22 Aug 2022 10:54:08 +0200 Message-ID: <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> Date: Mon, 22 Aug 2022 10:54:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Pavel Shlyak , 57070@debbugs.gnu.org References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> From: Maxime Devos Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR In-Reply-To: <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------QfZ3MF70sQ7iYPRwT8ArTZfc" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661158448; bh=57epUNWqBxUgddhDHTbzfJtv8J6OU5bRk7Kheqq1R7c=; h=Date:To:References:From:Subject:In-Reply-To; b=PZP8dfspy9KnA4P3S3MD1n0qI8eDdXwCAVE+rvIjTLX63keAWy1wG1lq8My5EDWyW hxKXOYe3eVYl97HD82i2PZ4NQZ2qFN5bVAqzU4tpgK1ROjfX7TkzpKVAiHho8d45r7 9ZGLZQE8JQhHiazZsNBx/AyFaGAIjgrbJzp3D61x+gAubeHB+UInpauTJf1hL1kHa+ XfoCXNwkdncrzQD8VvYYyBUIufn5C8UJ1oxB5wOSVSvJAokT+n2ghqcBhUQrAh9sxt VaASKs09cWI7/38o8bbUcLvedF2CZz9yVttzAeXpaY3lncTARZYkOH2G2D+GDjzzuU 48LBQBkHYaLmA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------QfZ3MF70sQ7iYPRwT8ArTZfc Content-Type: multipart/mixed; boundary="------------FJl0wH2CFxYeF6WL8gYYToL9"; protected-headers="v1" From: Maxime Devos To: Pavel Shlyak , 57070@debbugs.gnu.org Message-ID: <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> In-Reply-To: <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> --------------FJl0wH2CFxYeF6WL8gYYToL9 Content-Type: multipart/mixed; boundary="------------yb08QA1jfXIB3NGYsDeg0ZPI" --------------yb08QA1jfXIB3NGYsDeg0ZPI Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAtMDgtMjAyMiAxMjoxNSwgUGF2ZWwgU2hseWFrIHdyb3RlOg0KDQo+IEkgZG8gbm90 IHRoaW5rIEkgY2FuIGFncmVlIHRoYXQgwqthIHJlbGV2YW50IGNvZGUgY291bGQgY2hlY2sg d2hhdCB0aGUgaGFyZHdhcmUgaXPCuyBhcyBpdOKAmXMgbm90IGhhcmR3YXJlLWRlZmluZWQs IGJ1dCBhbHNvIHVzZXItZGVmaW5lZC4gSXTigJlzIG5vdCBqdXN0IGFib3V0IGRldGVjdGlv biwgaXTigJlzIGFsc28gYWJvdXQgY2hvaWNlLiBUaGUgc2FtZSBzeXN0ZW0gZGVmaW5pdGlv biBJIGhhdmUgb24gUlBJNCwgZm9yIGV4YW1wbGUsIGNhbiBib290IGJvdGggd2l0aCBrZXJu ZWwtcHJvdmlkZWQgRkRUIChsb2FkZWQgd2l0aCB1Ym9vdCkgYW5kIGJvb3Rsb2FkZXItcHJv dmlkZWQgRkRUIChsb2FkZWQgd2l0aCBSUEkgYm9vdGxvYWRlcikuDQoNCklmIHRoZSB1c2Vy IHJlYWxseSB3YW50cyB0byBjaG9vc2UgYSBkaWZmZXJlbnQgRFQsIHRoZXkgY2FuIGN1c3Rv bWlzZSANCnRoZWlyIGtlcm5lbCBieSBvdmVycmlkaW5nIHRoZSBzb3VyY2NlLg0KDQpJZiB0 aGUgYm9vdGxvYWRlciBEVCBpcyBtb3JlIHByZWNpc2UgdGhhbiB0aGUga2VybmVsIERUIChv ciB0aGUga2VybmVsIA0KRFQgaXMgbWlzc2luZyksIHdoeSBub3Qgc3VibWl0IHRoZSBib290 bG9hZGVyIERUIHRvIHRoZSBrZXJuZWw/IFRoZW4gDQpldmVyeW9uZSBjYW4gYmVuZWZpdCwg bm90IG9ubHkgcGVvcGxlIHVzaW5nIHRoZSAnUlBJIGJvb3Rsb2FkZXIuJyANCkJldHdlZW4g YW4gaW5mZXJpb3IgYW5kIGEgc3VwZXJpb3IgRFQsIEkgZG8gbm90IHNlZSB0aGUgcG9pbnQg b2YgDQpwcm92aWRpbmcgYW4gb3B0aW9uIGluIEd1aXggZm9yIHNlbGVjdGluZyB0aGUgaW5m ZXJpb3Igb25lLg0KDQpMaWtld2lzZSwgaWYgdGhleSBhcmUgZXF1aXZhbGVudCwgSSBkb24n dCBzZWUgdGhlIHBvaW50IGVpdGhlci4NCg0KWW91IHdyaXRlIHRoYXQgdGhlIHN5c3RlbSBk ZWZpbml0aW9uIGNhbiBib3RoIGJvb3Qgd2l0aCB0aGUgDQprZXJuZWwtcHJvdmlkZWQgRkRU IGFuZCBib290bG9hZGVyIEZEVCwgdGhlbiB3aHkgYXJlIHlvdSB3cml0aW5nIHRoaXMgDQpw YXRjaCBpZiB0aGluZ3Mgd29yaz8NCg0KPiAgIFRoZXJlIGFyZSBhbHNvIGEgbG90IG9mIGRp ZmZlcmVudCBkZXZpY2VzIG91dCB0aGVyZSBvbiB0aGUgbWFya2V0IGFuZCB0aGVyZeKAmXMg bm8gY29tbW9uIHdheSB0byBrbm93IGhvdyBPUyBkZWZpbml0aW9uIGlzIHdyaXR0ZW4gZm9y IGl0LiBJZiB5b3UgaGF2ZSBpZGVhcyAtIHlvdeKAmXJlIHdlbGNvbWUgdG8gcHJvcG9zZSB5 b3VyIHdheSB0byBkbyBpdC4NCg0KVGhlIGtlcm5lbCBoYXMgbXVsdGlwbGUgRFRzLiBJIGFz c3VtZSB0aGF0LCBzb21laG93LCB0aGUga2VybmVsIGNhbiANCmZpZ3VyZSBvdXQgd2hpY2gg b25lLg0KDQpJZiB5b3UgbXVzdCBnbyBmb3IgdGhpcyB3b3JrLWFyb3VuZCwgeW91IGNvdWxk IHRyeSBwb3J0aW5nIHRoZSBsb2dpYyANCnRoYXQgdGhlIGtlcm5lbCB1c2VzIHRvIGZpZ3Vy ZSBvdXQgdGhlIHJpZ2h0IERULCBhbmQgZXh0ZW5kIGl0IGZvciB0aGUgDQpkZXZpY2UgdGhh dCByZXF1aXJlZCB0aGUgcGF0Y2guDQoNCj4gSXQgZG9lcyBub3QgYXBwZWFyIHRvIMKrYmUg c2ltcGx5IGEga2VybmVsIGJ1Z8K7IHRvIG1lLiBLZXJuZWwgZG9lcyBub3QgcGFzcyBjb25m aWd1cmF0aW9uIHRvIHRoZSBib290bG9hZGVyIGFuZCB3ZeKAmXJlIGNvbmZpZ3VyaW5nIGEg Ym9vdGxvYWRlciBlbnRyeSBoZXJlLiBJdOKAmXMgc2ltcGxlIGFzIHRoYXQ6IGJvb3Rsb2Fk ZXIgZW50cnkgbWF5IGluY2x1ZGUgb3Igbm90IGluY2x1ZGUgdGhhdCBsaW5lIGFuZCB0aGF0 4oCZcyB1c2VyLWRlZmluZWQuDQoNCkFGQUlLLCBkZXZpY2UgdHJlZSBpbmZvcm1hdGlvbiBp cyB1c2VkIGJ5IHRoZSBrZXJuZWwsIG5vdCB0aGUgDQpib290bG9hZGVyLiBBRkFJSywgYXQg bW9zdCB0aGUgYm9vdGxvYWRlciBwYXNzZXMgYSBEVCB0byB0aGUga2VybmVsLsKgIFdlIA0K Y291bGQganVzdCBub3Qgc3VwcG9ydCBvdmVycmlkaW5nIHRoZSBEVCBpbiBHdWl4IGluIHRo ZSBib290bG9hZGVyIA0KZW50cnk/IEkgZG9uJ3Qgc2VlIHRoZSBwb2ludCBpZiB1cGRhdGlu ZyB0aGUgRFQgaW4gdGhlIGtlcm5lbCBhcHBlYXJzIHRvIA0KYmUgc3VmZmljaWVudC4NCg0K R3JlZXRpbmdzLA0KTWF4aW1lLg0KDQo= --------------yb08QA1jfXIB3NGYsDeg0ZPI Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------yb08QA1jfXIB3NGYsDeg0ZPI-- --------------FJl0wH2CFxYeF6WL8gYYToL9-- --------------QfZ3MF70sQ7iYPRwT8ArTZfc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwNELgUDAAAAAAAKCRBJ4+4iGRcl7tke AP4hy5kRilIps7gA5oEfhHEWOV0pPM3RAuFWrq1ylr0HNAEA48qSIaCzWMb37chn7dC1YTClaiZO 2N3pvos10qt5Gg4= =mHj0 -----END PGP SIGNATURE----- --------------QfZ3MF70sQ7iYPRwT8ArTZfc-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 06:52:20 2022 Received: (at 57070) by debbugs.gnu.org; 22 Aug 2022 10:52:20 +0000 Received: from localhost ([127.0.0.1]:38069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ52a-0005qS-DI for submit@debbugs.gnu.org; Mon, 22 Aug 2022 06:52:20 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQ52W-0005qD-OR for 57070@debbugs.gnu.org; Mon, 22 Aug 2022 06:52:18 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 40BB05C005E; Mon, 22 Aug 2022 06:52:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 22 Aug 2022 06:52:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1661165531; x=1661251931; bh=tuWtYxUr8x k+/SJNV5aDAdVOqqWA/gERIBOXwvwBzXo=; b=Xzc667qS8o7v2n+Zuz0j9mg8I1 /ZPHDv3Nla/pGXjBz5URcX4fdRrDCjvBxf0PNjeOEsW/vBjD0RNvoFK+iwWovAAh yCu3p+AEb05Ij5BQEF+p5Df6T/+wLBHnMTSbWL8jD+tOeRNGC8ONWSwt5JmjR4GR B1q78manFRlZ2Ed/afIsY8PV3c4cvkb5L7aLghbCG3qcMO9fdB2ShigRtR9SqAlN sB9h1yIl910cYq8k/OokESD/FLaEv/ys9wD9+8Bn0ak5YprLv2I+C/s8qNv4es0U 2RLwVVw3WdUmEV8dd15f7x5hQ+twaI/mEBYLnJRAQTjJb5EDgtOpmZ1aA6Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661165531; x=1661251931; bh=tuWtYxUr8xk+/SJNV5aDAdVOqqWA /gERIBOXwvwBzXo=; b=QM2yt9UEz4L+/o5t4TgI92nwZYGec6kCMWondp9vh769 VGJms5VyU+tyFis/896E9htRTmoM+ZfQZ/TI7ephUTSYlxj/B3tv32vFzCG3RztD CS1Lgw9O5qx6LmmaxNNM3EZavRPHLf0XER8Up5z7NYz895675HBh97ovOh+gLvGC HkhMEu8fLVxaUu9rA4toVdnhKWBFT1ADa7Xy+rAAhIpGkCTO1mNxGSHBhBmTCwko 1cksbg1blYn3ezHnQX46x4lbbjfzRqxrOyeAKpAky9jAUZFsCqpWmUmL1ev5t9HR O4B8pARpiAzg4Ofnb9NW9lCYfCeRorSzC7F4RcyfOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeijedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffktgggufffjgevvfhfofesrgdtmherhhdtjeenucfhrhhomheprfgrvhgv lhcuufhhlhihrghkuceophdrshhhlhihrghksehprghnthhhvghrgidrohhrgheqnecugg ftrfgrthhtvghrnhepfefhteeugfekudeuffegkeduteejheelgfetuefhvefffeekieeh fedvuedtleeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepphdrshhhlhihrghksehprghnthhhvghrgidrohhrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Aug 2022 06:52:10 -0400 (EDT) From: Pavel Shlyak Message-Id: Content-Type: multipart/alternative; boundary="Apple-Mail=_4ACFBBE1-9629-4E73-9C20-2FB6ABBA5BE7" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR Date: Mon, 22 Aug 2022 13:52:08 +0300 In-Reply-To: <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> To: Maxime Devos References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_4ACFBBE1-9629-4E73-9C20-2FB6ABBA5BE7 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > If the user really wants to choose a different DT, they can customise = their kernel by overriding the sourcce. Yes, unless it=E2=80=99s generated by bootloader. > why not submit the bootloader DT to the kernel? Because it passes board-specific parameters. We cannot submit DTs for = all board revisions, memory sizes etc. > Likewise, if they are equivalent, I don't see the point either. They are not > You write that the system definition can both boot with the = kernel-provided FDT and bootloader FDT, then why are you writing this = patch if things work? It can boot on RPI4b, but not on RPI3b+ or Compute Module 4 > The kernel has multiple DTs. I assume that, somehow, the kernel can = figure out which one. DTs are loaded by the bootloader. Kernel cannot figure anything out. > If you must go for this work-around, you could try porting the logic = that the kernel No, kernel does not include this logic > AFAIK, device tree information is used by the kernel, not the = bootloader. Uboot uses DT on some platforms > I don't see the point if updating the DT in the kernel appears to be = sufficient. I hope dynamic DT with some data that only bootloader can know is = sufficient for you. Again, this is how things work on Raspberry and some = other boards on any distro. We don=E2=80=99t support that - we don=E2=80=99= t support these devices. I personally don=E2=80=99t loose much as we can = apply this patch directly on pantherx channel, making pantherx richer in = device support. However, I do not quite like the idea of me answering = =C2=ABInstall PantherX=C2=BB to the people who cannot get GUIX on their = devices. I would be also happy if someone more competent on the topic joined this = discussion.=20 --Apple-Mail=_4ACFBBE1-9629-4E73-9C20-2FB6ABBA5BE7 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 > If the user really wants to choose a different = DT, they can customise their kernel by overriding the = sourcce.
Yes, = unless it=E2=80=99s generated by bootloader.
> why = not submit the bootloader DT to the kernel?
Because it passes board-specific parameters. We cannot = submit DTs for all board revisions, memory sizes etc.
> Likewise, if they are equivalent, I = don't see the point either.
They are not
> You write that the system definition can both = boot with the kernel-provided FDT and bootloader FDT, then why are you = writing this patch if things work?
It can boot on RPI4b, but not on RPI3b+ or = Compute Module 4
> The kernel has multiple DTs. I assume = that, somehow, the kernel can figure out which one.
DTs are loaded by the bootloader. Kernel cannot figure = anything out.
> If = you must go for this work-around, you could try porting the logic that = the kernel
No, kernel does not = include this logic
> AFAIK, device tree information is used by the kernel, not the = bootloader.
Uboot uses DT on some platforms
> I = don't see the point if updating the DT in the kernel appears to be = sufficient.
I hope dynamic DT with some data that only = bootloader can know is sufficient for you. Again, this is how things = work on Raspberry and some other boards on any distro. We don=E2=80=99t = support that - we don=E2=80=99t support these devices. I personally = don=E2=80=99t loose much as we can apply this patch directly on pantherx = channel, making pantherx richer in device support. However, I do not = quite like the idea of me answering =C2=ABInstall PantherX=C2=BB to the = people who cannot get GUIX on their devices.

I would be also happy if someone more = competent on the topic joined this discussion. 

= --Apple-Mail=_4ACFBBE1-9629-4E73-9C20-2FB6ABBA5BE7-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 14:57:20 2022 Received: (at 57070) by debbugs.gnu.org; 22 Aug 2022 18:57:20 +0000 Received: from localhost ([127.0.0.1]:41758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCbw-0003B6-1W for submit@debbugs.gnu.org; Mon, 22 Aug 2022 14:57:20 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:57292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCbt-0003Av-9Q for 57070@debbugs.gnu.org; Mon, 22 Aug 2022 14:57:18 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by laurent.telenet-ops.be with bizsmtp id AixF2800D20ykKC01ixFFP; Mon, 22 Aug 2022 20:57:15 +0200 Message-ID: Date: Mon, 22 Aug 2022 20:57:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Pavel Shlyak References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> From: Maxime Devos Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------jwJJ754AZez5d2AYYP520yJp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661194635; bh=m1yv8+DUlsNkQ3or2ORS/MVweDrpggeWOzMxVBxLwkk=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=dbKuvH2Gcwyh4MVt91BuBNAftLFmz43geM8su5SAZEJx3fUOjB9e6exDfPWfm0wxH Z48sgu9Y85b374FH3h7kFKV6bBcVX43yVUVoKS4F2uRGN1BKLXUUVjCOBc1RkAh6ns n/n+NxmB2r/TVMTNMhUng80J9RyERHuRJm+wb9eOumHYapTcBKv3BKMM7kB/cAZywW jKiwvTKnnfdWMJei0VGEYMCu3xKpWn8PYozNTQMoExqb7i8KwLG4FlkuZw6XUyw+wk GrnXcMf2M4PGbDxcAY41bDCMnUElTwNuTQQIRZG51dOBbWfApNSrC3tEy/IhOdVkje VpRIcsOoJoFMg== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------jwJJ754AZez5d2AYYP520yJp Content-Type: multipart/mixed; boundary="------------59O8iYKGGTkuJF9JNLeB7kF0"; protected-headers="v1" From: Maxime Devos To: Pavel Shlyak Cc: 57070@debbugs.gnu.org Message-ID: Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> In-Reply-To: --------------59O8iYKGGTkuJF9JNLeB7kF0 Content-Type: multipart/mixed; boundary="------------KXhm0PwlB528tbZfKOQwTV40" --------------KXhm0PwlB528tbZfKOQwTV40 Content-Type: multipart/alternative; boundary="------------QjzU0K0AOURJl6NYk87Gm175" --------------QjzU0K0AOURJl6NYk87Gm175 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjItMDgtMjAyMiAxMjo1MiwgUGF2ZWwgU2hseWFrIHdyb3RlOg0KDQo+ID4gSWYgdGhl IHVzZXIgcmVhbGx5IHdhbnRzIHRvIGNob29zZSBhIGRpZmZlcmVudCBEVCwgdGhleSBjYW4g DQo+IGN1c3RvbWlzZSB0aGVpciBrZXJuZWwgYnkgb3ZlcnJpZGluZyB0aGUgc291cmNjZS4N Cj4gWWVzLCB1bmxlc3MgaXTigJlzIGdlbmVyYXRlZCBieSBib290bG9hZGVyLg0KQ291bGQg eW91IHBvaW50IG1lIGF0IHRoZSBkb2N1bWVudGF0aW9uIG9yIGNvZGUgdGhhdCBjbGFpbXMg b3IgZG9lcyANCnRoYXQ/IEkgYW0gbm90IGZpbmRpbmcgYW55IGV2aWRlbmNlIHRoYXQgZGV2 aWNlIHRyZWVzIGFyZSBnZW5lcmF0ZWQgYXQgYm9vdC4NCj4gPiB3aHkgbm90IHN1Ym1pdCB0 aGUgYm9vdGxvYWRlciBEVCB0byB0aGUga2VybmVsPw0KPiBCZWNhdXNlIGl0IHBhc3NlcyBi b2FyZC1zcGVjaWZpYyBwYXJhbWV0ZXJzLiBXZSBjYW5ub3Qgc3VibWl0IERUcyBmb3IgDQo+ IGFsbCBib2FyZCByZXZpc2lvbnMsIG1lbW9yeSBzaXplcyBldGMuDQpJZiB0aGUgYm9vdGxv YWRlciBjYW4sIHN1cmVseSB0aGUga2VybmVsIGNhbi4NCj4gPiBZb3Ugd3JpdGUgdGhhdCB0 aGUgc3lzdGVtIGRlZmluaXRpb24gY2FuIGJvdGggYm9vdCB3aXRoIHRoZSANCj4ga2VybmVs LXByb3ZpZGVkIEZEVCBhbmQgYm9vdGxvYWRlciBGRFQsIHRoZW4gd2h5IGFyZSB5b3Ugd3Jp dGluZyB0aGlzIA0KPiBwYXRjaCBpZiB0aGluZ3Mgd29yaz8NCj4gSXQgY2FuIGJvb3Qgb24g UlBJNGIsIGJ1dCBub3Qgb24gUlBJM2IrIG9yIENvbXB1dGXCoE1vZHVsZSA0DQpJIGJlbGll dmUgdGhlIGtlcm5lbCBmb2xrcyB3aWxsIGFwcHJlY2lhdGUgYSBwYXRjaCBmaXhpbmcgdGhl IERUIGZvciANClJQSTNiKyBhbmQgQ29tcHV0ZSBNb2R1bGUgNC4NCj4gPiBUaGUga2VybmVs IGhhcyBtdWx0aXBsZSBEVHMuIEkgYXNzdW1lIHRoYXQsIHNvbWVob3csIHRoZSBrZXJuZWwg Y2FuIA0KPiBmaWd1cmUgb3V0IHdoaWNoIG9uZS4NCj4gRFRzIGFyZSBsb2FkZWQgYnkgdGhl IGJvb3Rsb2FkZXIuIEtlcm5lbCBjYW5ub3QgZmlndXJlIGFueXRoaW5nIG91dC4NCg0KRFRz IGFyZSBhIGtlcm5lbCB0aGluZywgZS5nLiB0aGUgTGludXggZG9jdW1lbnRhdGlvbiANCmh0 dHBzOi8vd3d3Lmtlcm5lbC5vcmcvZG9jL2h0bWwvbGF0ZXN0L2RldmljZXRyZWUvdXNhZ2Ut bW9kZWwuaHRtbCANCm1lbnRpb25zIERULCBhbHNvLCBMaW51eC7CoCBJIGNvdWxkIG5vdCBm aW5kIGFueSBpbmZvcm1hdGlvbiBvbiANCmJvb3Rsb2FkZXJzIGxvYWRpbmcgRFRzLg0KDQo+ ID4gSWYgeW91IG11c3QgZ28gZm9yIHRoaXMgd29yay1hcm91bmQsIHlvdSBjb3VsZCB0cnkg cG9ydGluZyB0aGUgbG9naWMgDQo+IHRoYXQgdGhlIGtlcm5lbA0KPiBObywga2VybmVsIGRv ZXMgbm90IGluY2x1ZGUgdGhpcyBsb2dpYw0KVGhlIHBhZ2UgDQpodHRwczovL3d3dy5rZXJu ZWwub3JnL2RvYy9odG1sL2xhdGVzdC9kZXZpY2V0cmVlL3VzYWdlLW1vZGVsLmh0bWwgDQpt ZW50aW9ucyB2YXJpb3VzIHByb3BlcnRpZXMgZm9yIHNwZWNpZnlpbmcgdGhlIG1vZGVsIGlu IHRoZSBEVCBpbmZvLCBpdCANCmhhcyBhIHNlY3Rpb24gJzIuMiBQbGF0Zm9ybSBJZGVudGlm aWNhdGlvbicgb24gaG93IExpbnV4IGRlY2lkZXMgd2hpY2ggDQpvbmUgaXMgdGhlIHJpZ2h0 IG9uZS4gUGxlbnR5IG9mIGxvZ2ljIHRoZXJlLg0KPiA+IEFGQUlLLCBkZXZpY2UgdHJlZSBp bmZvcm1hdGlvbiBpcyB1c2VkIGJ5IHRoZSBrZXJuZWwsIG5vdCB0aGUgYm9vdGxvYWRlci4N Cj4gVWJvb3QgdXNlcyBEVCBvbiBzb21lwqBwbGF0Zm9ybXMNCk9LLiBJcyB0aGUgYm9hcmQg eW91IGFyZSB0cnlpbmcgdG8gc3VwcG9ydCBvbmUgb2YgdGhlbSwgYW5kIGRvZXMgZm9yIA0K dGhhdCBjYXNlIHRoZSBwcmUtcGF0Y2ggYmVoYXZpb3VyIHN1ZmZpY2UgdGhlcmUgKExpbnV4 IHdpbGwgbG9hZCBpdHMgb3duIA0KRFQgbGF0ZXIgYW55d2F5PykuDQoNClRoaXMgcmVzcG9u c2UgbWFrZXMgbWUgd29uZGVyIHdoZXJlIHRoZSBib290IGZhaWxlZCAtLSBkaWQgaXQgZmFp bCBpbiANCnRoZSBib290bG9hZGVyLCBvciBpbiB0aGUga2VybmVsIHN0YXJ0dXA/DQoNCj4g PiBJIGRvbid0IHNlZSB0aGUgcG9pbnQgaWYgdXBkYXRpbmcgdGhlIERUIGluIHRoZSBrZXJu ZWwgYXBwZWFycyB0byBiZSANCj4gc3VmZmljaWVudC4NCj4gSSBob3BlIGR5bmFtaWMgRFQg d2l0aCBzb21lIGRhdGEgdGhhdCBvbmx5IGJvb3Rsb2FkZXIgY2FuIGtub3cgaXMgDQo+IHN1 ZmZpY2llbnQgZm9yIHlvdS4gDQoNCkl0IGlzIG5laXRoZXIgc3VmZmljaWVudCBub3IgaW5z dWZmaWNpZW50IGZvciBtZSAtLSBpdCBpcyB5b3UgdGhhdCBpcyANCmFkZGluZyBzdXBwb3J0 IGZvciBzb21lIGJvYXJkcywgbm90IG1lLCBHUlVCK3g4Nl82NCB3b3JrcyBqdXN0IG5pY2Ug aGVyZS4NCg0KQmVzaWRlcywgdGhlIGJvb3Rsb2FkZXIva2VybmVsIGRpc3RpbmN0aW9uIGlz IGp1c3QgYSBtYXR0ZXIgb2YgDQpjb252ZW50aW9uLCBib290bG9hZGVycyBkb24ndCBtYWdp Y2FsbHkgaGF2ZSBhY2Nlc3MgdG8gbW9yZSBpbmZvcm1hdGlvbiANCnRoYW4ga2VybmVscy4g QW55dGhpbmcgYSBib290bG9hZGVyIGNhbiBkZXRlcm1pbmUsIGEga2VybmVsIGNhbiBhcyB3 ZWxsLCANCmFuZCB2aWNlLXZlcnNhLCB0aGV5IGFyZSBib3RoIGp1c3Qgc29mdHdhcmUgcnVu bmluZyBvbiBhIENQVSBhbmQgdmFyaW91cyANCmFzc29jaWF0ZWQgaGFyZHdhcmUuDQoNCj4g QWdhaW4sIHRoaXMgaXMgaG93IHRoaW5ncyB3b3JrIG9uIFJhc3BiZXJyeSBhbmQgc29tZSBv dGhlciBib2FyZHMgb24gDQo+IGFueSBkaXN0cm8uIFdlIGRvbuKAmXQgc3VwcG9ydCB0aGF0 IC0gd2UgZG9u4oCZdCBzdXBwb3J0IHRoZXNlIGRldmljZXMuDQoNClRoYXQncyB3aGF0IEkg dGhvdWdodCB0aGUgcGF0Y2ggd2FzIGZvciAtLSBhZGRpbmcgc3VwcG9ydCBmb3Igc29tZSAN CmRldmljZXMsIHR1cm5pbmcgdGhlICJpdCdzIG5vdCBzdXBwb3J0ZWQiIGludG8gYW4gIml0 J3Mgc3VwcG9ydGVkIi4gDQpNb3Zpbmcgc3VwcG9ydCBmcm9tIHRoZSBib290bG9hZGVyIHRv IHRoZSBrZXJuZWwgd291bGQgYWNjb21wbGlzaCB0aGF0IA0KYXMgd2VsbC4gQWxzbywgYWQg cG9wdWx1bS4NCg0KSWYgeW91IGRvbid0IHdhbnQgdG8gc3VwcG9ydCBuZXcgcGxhdGZvcm1z LCB0aGF0J3MgZmluZSwgYnV0IHdoeSBhcmUgeW91IA0Kc2VuZGluZyBhIHBhdGNoIHRoZW4/ DQoNCj4gSSBwZXJzb25hbGx5IGRvbuKAmXQgbG9vc2UgbXVjaCBhcyB3ZSBjYW4gYXBwbHkg dGhpcyBwYXRjaCBkaXJlY3RseSBvbiANCj4gcGFudGhlcnggY2hhbm5lbCwgbWFraW5nIHBh bnRoZXJ4IHJpY2hlciBpbiBkZXZpY2Ugc3VwcG9ydC4gSG93ZXZlciwgSSANCj4gZG8gbm90 IHF1aXRlIGxpa2UgdGhlIGlkZWEgb2YgbWUgYW5zd2VyaW5nIMKrSW5zdGFsbCBQYW50aGVy WMK7IHRvIHRoZSANCj4gcGVvcGxlIHdobyBjYW5ub3QgZ2V0IEdVSVggb24gdGhlaXIgZGV2 aWNlcy4NCg0KTXkgcG9pbnQgaXMgdGhhdCBzdXBwb3J0aW5nIG1vcmUgZGV2aWNlcyB3b3Vs ZCBiZSBuaWNlLCBidXQgdGhpcyBwYXRjaCANCmlzbid0IHRoZSB3YXkgdG8gZG8gaXQuDQoN CkFkZGl0aW9uYWxseSwgdGhlIHByb3BlciBjYXBpdGFsaXNhdGlvbiBpcyBHdWl4LCBHVUlY IGlzIGFub3RoZXIgdGhpbmcuDQoNCkdyZWV0aW5ncywNCk1heGltZS4NCg0K --------------QjzU0K0AOURJl6NYk87Gm175 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 22-08-2022 12:52, Pavel Shlyak wrote:

>=C2=A0If the user really wants to choose a different DT, the= y can customise their kernel by overriding the sourcce.
Yes, unless it=E2= =80=99s generated by bootloader.
Could you point me at the documentation or code that claims or does that? I am not finding any evidence that device trees are generated at boot.
>=C2=A0why not submit the bootloader DT to the kernel?
Because it passes board-specific parameters. We cannot submit DTs for all board revisions, memory sizes etc.
If the bootloader can, surely the kernel can.
>=C2=A0You write that the system definition can both boot with the kernel-provided FDT and bootloader FDT, then why are you writing this patch if things work?
It can boot on R= PI4b, but not on RPI3b+ or Compute=C2=A0Module 4
I believe the kernel folks will appreciate a patch fixing the DT for RPI3b+ and Compute Module 4.
>=C2=A0The kernel has multiple DTs. I assume that, somehow,= the kernel can figure out which one.
DTs are loaded by the bootloader. Kernel cannot figure anything out.

DTs are a kernel thing, e.g. the Linux documentation https://www.kernel.org/doc/ht= ml/latest/devicetree/usage-model.html mentions DT, also, Linux.=C2=A0 I could not find any information on= bootloaders loading DTs.

>=C2=A0If you must go for this work-around, you could try porting the logic that the kernel
No, kernel does not include this logi= c
The page https://www.kernel.org/doc/html= /latest/devicetree/usage-model.html mentions various properties for specifying the model in the DT info, it has a section '2.2 Platform Identification' on how Linux decides which one is the right one. Plenty of logic there.
>=C2=A0AFAIK, device tree information is used by the kernel, not the bootloader.
Uboot uses DT on= some=C2=A0platforms
OK. Is the board you are trying to support one of them, and does for that case the pre-patch behaviour suffice there (Linux will load its own DT later anyway?).

This response makes me wonder where the boot failed -- did it fail in the bootloader, or in the kernel startup?

>=C2=A0I don't see the point if updating the DT in the kernel appears to be sufficient.
I hope dynamic DT with some data that only bootloader can know is sufficient for you.

It is neither sufficient nor insufficient for me -- it is you that is adding support for some boards, not me, GRUB+x86_64 works just nice here.

Besides, the bootloader/kernel distinction is just a matter of convention, bootloaders don't magically have access to more information than kernels. Anything a bootloader can determine, a kernel can as well, and vice-versa, they are both just software running on a CPU and various associated hardware.

Agai= n, this is how things work on Raspberry and some other boards on any distro. We don=E2=80=99t support that - we don=E2=80=99t support th= ese devices.

That's what I thought the patch was for -- adding support for some devices, turning the "it's not supported" into an "it's supported". Moving support from the bootloader to the kernel would accomplish that as well. Also, ad populum.

If you don't want to support new platforms, that's fine, but why are you sending a patch then?

I personally don=E2=80=99t loose much as we can apply this patch dire= ctly on pantherx channel, making pantherx richer in device support. However, I do not quite like the idea of me answering =C2=ABInstall= PantherX=C2=BB to the people who cannot get GUIX on their devices.<= /blockquote>

My point is that supporting more devices would be nice, but this patch isn't the way to do it.

Additionally, the proper capitalisation is Guix, GUIX is another thing.

Greetings,
Maxime.

--------------QjzU0K0AOURJl6NYk87Gm175-- --------------KXhm0PwlB528tbZfKOQwTV40 Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------KXhm0PwlB528tbZfKOQwTV40-- --------------59O8iYKGGTkuJF9JNLeB7kF0-- --------------jwJJ754AZez5d2AYYP520yJp Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwPRiwUDAAAAAAAKCRBJ4+4iGRcl7lYJ AQDTNCjnOFUOSrcCf/6QCZDDlw8MMWqrANSul8Z7gVesXgEAmZUdgidvi0PibiQ7Vnt3pRps32np nR8R7qVOrJZv4QQ= =VbBc -----END PGP SIGNATURE----- --------------jwJJ754AZez5d2AYYP520yJp-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 15:19:43 2022 Received: (at 57070) by debbugs.gnu.org; 22 Aug 2022 19:19:43 +0000 Received: from localhost ([127.0.0.1]:41809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCxa-00084U-Qh for submit@debbugs.gnu.org; Mon, 22 Aug 2022 15:19:43 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:39147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQCxV-00084C-VW for 57070@debbugs.gnu.org; Mon, 22 Aug 2022 15:19:40 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 856E15C00EA; Mon, 22 Aug 2022 15:19:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 22 Aug 2022 15:19:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1661195972; x= 1661282372; bh=aF6pxgfH76WgXhOuuntAq98Q4dSshLteOqJRmaoilIU=; b=g GxjeTqjzfhi+sjx0t1hH6t9RQeZhU1KjmsyZ25jZAug+BphAJB7V5ZYJE4XJKPp9 NZG2YzmeQ9Z1qIN92J9GcYaP3GDab0N6fHjhe23kuY91qpirZnRt3TecheYIFTXm cvnsmpgSmgKKiWc1sv8tOof1h0YrVFxrzo/kvpAQxTY278h9PBMbo13H+wtgUZhA apJGXIgJcDnze0zIhdfyUI8ArqW7sv6q94ks6c4LS4TIMUPuEQJ3p89uxVKWXzKb vhKaQf/1NdZsdSiU1THeAjXFsJNkEP5QS2wSt/0NaUE85GjuV3C3Hdg56Y4EJ8MQ vCYe9jp8L7FfpQKunt2Lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1661195972; x= 1661282372; bh=aF6pxgfH76WgXhOuuntAq98Q4dSshLteOqJRmaoilIU=; b=z BbniF2rRlXXbZdbjbkNKpjFbPb4ZXFc0NZwzm/hxhbDaXlcBtJpgVRngrGtRVduI IQwN/tGvBfSGBqGsQq9qjVhWtbUdpj/mIE9459NGcSgSF2hFbGZ9SVIsG5pOHOOD fnupObq6F2XZDGwIWlEbp524hMkBPs+51Gsw+0DH+bb2B8hk2Djvu+ONEEF4xFSY dfse2np+upTmvddgadZz4SnQe/xRm+PK3J0AJugITt/z55eBnDtE2ZfpsH1IPqaa VrryTs3CCpwqqxC8jXZbjaq68iGLSxd5fA27+0kAi7nf4VtxuxuIsnmGcqyWc0tJ FncDBFp5tlGO7jayVtBGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeijedgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtjeenucfhrhhomheprfgr vhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehprghnthhhvghrgidrohhrgheqne cuggftrfgrthhtvghrnhepveehudduvefhledthefgieefffefgedtleegvdffieffjeel feegjedtvdfgfefhnecuffhomhgrihhnpehrrghsphgsvghrrhihphhirdgtohhmpdhkvg hrnhgvlhdrohhrghdprhgvrgguthhhvgguohgtshdrihhopdhoiihlrggsshdrohhrghdp ghhithhhuhgsrdgtohhmpdhfrhgvvgguvghskhhtohhprdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghn thhhvghrgidrohhrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Aug 2022 15:19:31 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR From: Pavel Shlyak In-Reply-To: Date: Mon, 22 Aug 2022 22:19:29 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <13223735-7417-4785-81F8-43715A135574@pantherx.org> References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> To: Maxime Devos X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: vagrant@debian.org, 57070@debbugs.gnu.org, Tobias Geerinckx-Rice X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Could you point me at the documentation or code that claims or does = that? I am not finding any evidence that device trees are generated at = boot. Google =C2=ABdevice tree raspberry bootloader=C2=BB, 1st result = https://forums.raspberrypi.com/viewtopic.php?t=3D329799 > If the bootloader can, surely the kernel can. Bootloader runs on GPU on Raspberry. It cannot run kernel.=20 Also, check m1n1 on Apple. It has docs. > I believe the kernel folks will appreciate a patch fixing the DT for = RPI3b+ and Compute Module 4. And for other devices that behave the same way? You=E2=80=99re literally = promoting making GUIX not bootable on all devices alike. > DTs are a kernel thing, e.g. the Linux documentation = https://www.kernel.org/doc/html/latest/devicetree/usage-model.html = mentions DT, also, Linux. I could not find any information on = bootloaders loading DTs. Because you didn=E2=80=99t search for it. Google =C2=ABdevice tree = raspberry bootloader=C2=BB, the first link is about bootloader forming = the device tree https://forums.raspberrypi.com/viewtopic.php?t=3D329799. = Google =C2=ABuboot device tree=C2=BB = https://u-boot.readthedocs.io/en/latest/usage/fdt_overlays.html to know = how uboot manipulates them. Moreover, Raspberry PI uboot uses DTB to boot on the board as in = https://patchwork.ozlabs.org/project/uboot/patch/20191106144104.28177-1-ma= tthias.bgg@kernel.org/ (Instead of using the embedded DTB as done in = RPi3 we use the devicetree provided by the firmware.) > bootloaders don't magically have access to more information than = kernels They do, if they are run on a separate core on the SOC that linux or arm = core has no access to. Check = https://github.com/christinaa/rpi-open-firmware > My point is that supporting more devices would be nice, but this patch = isn't the way to do it. Well, there is no other way to support devices that require DTB not to = be loaded with uboot. The solutions you suggest are not possible. Moreover, keep in mind FDTDIR is not in the = http://www.freedesktop.org/wiki/Specifications/BootLoaderSpec/ = specification and making is permanent we basically violate it.=20 Since we=E2=80=99ve not come to any understanding here, I kindly invite = Vagrant and Tobias to join the discussion. They seem to be familiar with = the relevant parts of GUIX. Sincerely, Pavel= From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 17:17:23 2022 Received: (at 57070) by debbugs.gnu.org; 22 Aug 2022 21:17:23 +0000 Received: from localhost ([127.0.0.1]:41937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQEnS-00072T-JU for submit@debbugs.gnu.org; Mon, 22 Aug 2022 17:17:23 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:60374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQEnN-00072H-IE for 57070@debbugs.gnu.org; Mon, 22 Aug 2022 17:17:21 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by baptiste.telenet-ops.be with bizsmtp id AlHD2800620ykKC01lHDlb; Mon, 22 Aug 2022 23:17:14 +0200 Message-ID: Date: Mon, 22 Aug 2022 23:17:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US To: Pavel Shlyak References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> <13223735-7417-4785-81F8-43715A135574@pantherx.org> From: Maxime Devos Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR In-Reply-To: <13223735-7417-4785-81F8-43715A135574@pantherx.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------3MQq4iJyiBjf3j3lnkXOlwHU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1661203034; bh=Z/+ey6VimmfkCM7aQCreQcxu9RpC5DqMieaLm4J78qo=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=PSzdQjIu3RkyO6INfBIZ1lvXRicsRDHr42kKJfKUaQXpvfwr+we+B9ekz9AgbR41o BEK1EbV94UsGhuW/M7fcrxNsK+8mQbtCyjqBzf2yI+bZMUSpTsmiaVVZCJ5kJ85pzU i66s0KaMLzfG1ZE7L56Q6ISPElzwe4TpceUWeb5Hzep+hzbgxBwuTKgzyL/Yy9/TQT NSXZdU56Ezp+1lfHJHpiditab39W0zwJab5sEnP5LXwKsFQGSdemh1IhfL+4ZyI9xJ ihzsTE4YVLfRhjGkHwN24niB8z/RvxkiWjLuVdVw9JpnS8n+hMFh+XZN5gR+kJZx+6 tsfXuz9w9mDZA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: vagrant@debian.org, 57070@debbugs.gnu.org, Tobias Geerinckx-Rice X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------3MQq4iJyiBjf3j3lnkXOlwHU Content-Type: multipart/mixed; boundary="------------eR1OKklFJMw0nobR4a7POARw"; protected-headers="v1" From: Maxime Devos To: Pavel Shlyak Cc: 57070@debbugs.gnu.org, vagrant@debian.org, Tobias Geerinckx-Rice Message-ID: Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> <13223735-7417-4785-81F8-43715A135574@pantherx.org> In-Reply-To: <13223735-7417-4785-81F8-43715A135574@pantherx.org> --------------eR1OKklFJMw0nobR4a7POARw Content-Type: multipart/mixed; boundary="------------3YHSJjIlSwiHymjoqY8vCFeB" --------------3YHSJjIlSwiHymjoqY8vCFeB Content-Type: multipart/alternative; boundary="------------bBciqExNXhhUpF0eiumwpunl" --------------bBciqExNXhhUpF0eiumwpunl Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAyMi0wOC0yMDIyIDIxOjE5LCBQYXZlbCBTaGx5YWsgd3JvdGU6DQo+IFN1YmplY3Q6 DQo+IFJlOiBbYnVnIzU3MDcwXSBbUEFUQ0hdIGJvb3Rsb2FkZXI6IGV4dGxpbnV4OiBzdXBw b3J0IGZvciBvcHRpb25hbCBGRFRESVINCj4gRnJvbToNCj4gUGF2ZWwgU2hseWFrIDxwLnNo bHlha0BwYW50aGVyeC5vcmc+DQo+IERhdGU6DQo+IDIyLTA4LTIwMjIgMjE6MTkNCj4NCj4g VG86DQo+IE1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT4NCj4gQ0M6DQo+ IDU3MDcwQGRlYmJ1Z3MuZ251Lm9yZywgdmFncmFudEBkZWJpYW4ub3JnLCBUb2JpYXMgR2Vl cmluY2t4LVJpY2UgDQo+IDxtZUB0b2JpYXMuZ3I+DQo+DQo+DQo+PiBDb3VsZCB5b3UgcG9p bnQgbWUgYXQgdGhlIGRvY3VtZW50YXRpb24gb3IgY29kZSB0aGF0IGNsYWltcyBvciBkb2Vz IHRoYXQ/IEkgYW0gbm90IGZpbmRpbmcgYW55IGV2aWRlbmNlIHRoYXQgZGV2aWNlIHRyZWVz IGFyZSBnZW5lcmF0ZWQgYXQgYm9vdC4NCj4gR29vZ2xlIMKrZGV2aWNlIHRyZWUgcmFzcGJl cnJ5IGJvb3Rsb2FkZXLCuywgMXN0IHJlc3VsdGh0dHBzOi8vZm9ydW1zLnJhc3BiZXJyeXBp LmNvbS92aWV3dG9waWMucGhwP3Q9MzI5Nzk5DQoNClRoYXQgd2ViIHBhZ2UgZG9lcyBub3Qg Y2xhaW0gdGhhdCBhbnl3aGVyZS4NCg0KPj4gSWYgdGhlIGJvb3Rsb2FkZXIgY2FuLCBzdXJl bHkgdGhlIGtlcm5lbCBjYW4uDQo+IEJvb3Rsb2FkZXIgcnVucyBvbiBHUFUgb24gUmFzcGJl cnJ5LiBJdCBjYW5ub3QgcnVuIGtlcm5lbC4NCj4gQWxzbywgY2hlY2sgbTFuMSBvbiBBcHBs ZS4gSXQgaGFzIGRvY3MuDQoNCkkgaGF2ZSBuZXZlciBjbGFpbWVkIHRoYXQgdGhlIEdQVSBj YW4gcnVuIHRoZSBrZXJuZWwuDQoNCldoYXQgZG9lcyBtMW4xIGhhdmUgdG8gZG8gd2l0aCBh bnl0aGluZyBoZXJlPyBtMW4xIGlzbid0IGV4dGxpbnV4IGFuZCANCmlzbid0IHBhY2thZ2Vk IGluIEd1aXguDQoNCkJvb3Rsb2FkZXJzIHJ1bm5pbmcgb24gdGhlIEdQVSBpcyBzb21ldGhp bmcgSSdtIG5vdCB1c2VkIHRvIGF0IGFsbCwgaXQncyANCm5vdCBzb21ldGhpbmcgSSBoYWQg ZXhwZWN0ZWQsIHNlZSBsYXRlci4NCg0KPj4gSSBiZWxpZXZlIHRoZSBrZXJuZWwgZm9sa3Mg d2lsbCBhcHByZWNpYXRlIGEgcGF0Y2ggZml4aW5nIHRoZSBEVCBmb3IgUlBJM2IrIGFuZCBD b21wdXRlIE1vZHVsZSA0Lg0KPiBBbmQgZm9yIG90aGVyIGRldmljZXMgdGhhdCBiZWhhdmUg dGhlIHNhbWUgd2F5PyBZb3XigJlyZSBsaXRlcmFsbHkgcHJvbW90aW5nIG1ha2luZyBHVUlY IG5vdCBib290YWJsZSBvbiBhbGwgZGV2aWNlcyBhbGlrZS4NCg0KSSBsaXRlcmFsbHkgbmV2 ZXIgd3JvdGUgc3VjaCBhIHRoaW5nLiBJbiB3aGF0IHNlbnRlbmNlcyBkaWQgSSBwcm9tb3Rl IHRoYXQ/DQoNCkV2ZW4gaWYgeW91IG1lYW50ICdpbXBsaWVkJyBpbnN0ZWFkIG9mICdsaXRl cmFsbHknLCB0aGVuIHRoYXQgc3RpbGwgDQpkb2Vzbid0IG1ha2Ugc2Vuc2UgdG8gbWU7IEkn bSBydW5uaW5nIEd1aXggU3lzdGVtLCBpdCdzIGluIG15IG93biANCmludGVyZXN0IHRvIGtl ZXAgaXQgYm9vdGFibGUgb24gbXkgZGV2aWNlLg0KDQo+PiBEVHMgYXJlIGEga2VybmVsIHRo aW5nLCBlLmcuIHRoZSBMaW51eCBkb2N1bWVudGF0aW9uaHR0cHM6Ly93d3cua2VybmVsLm9y Zy9kb2MvaHRtbC9sYXRlc3QvZGV2aWNldHJlZS91c2FnZS1tb2RlbC5odG1sICBtZW50aW9u cyBEVCwgYWxzbywgTGludXguICBJIGNvdWxkIG5vdCBmaW5kIGFueSBpbmZvcm1hdGlvbiBv biBib290bG9hZGVycyBsb2FkaW5nIERUcy4NCj4gQmVjYXVzZSB5b3UgZGlkbuKAmXQgc2Vh cmNoIGZvciBpdC4NCkkgZGlkIHNlYXJjaCBmb3IgaXQsIGZpZ3VyaW5nIG91dCBhbiBfYXBw cm9wcmlhdGVfIHF1ZXJ5IGFuZCBmaW5kaW5nIA0KcmVsZXZhbnQgcmVzdWx0cyBpcyBhbm90 aGVyIG1hdHRlci4NCj4gICBHb29nbGUNCk5vLiBJdCBoYXMgbW9ub3BvbHkgYW5kIHByaXZh Y3kgcHJvYmxlbXMuDQo+ICAgwqtkZXZpY2UgdHJlZSByYXNwYmVycnkgYm9vdGxvYWRlcsK7 LCB0aGUgZmlyc3QgbGluayBpcyBhYm91dCBib290bG9hZGVyIGZvcm1pbmcgdGhlIGRldmlj ZSB0cmVlaHR0cHM6Ly9mb3J1bXMucmFzcGJlcnJ5cGkuY29tL3ZpZXd0b3BpYy5waHA/dD0z Mjk3OTkuDQpHZW5lcmF0aW5nIHRoZSBEVCBpcyBhIGRpZmZlcmVudCBtYXR0ZXIgZnJvbSBs b2FkaW5nIHRoZSBEVC7CoCBJdCdzIGFsc28gDQphYm91dCBmaXJtd2FyZSwgbm90IHRoZSBi b290bG9hZGVyLg0KPiAgIEdvb2dsZSDCq3Vib290IGRldmljZSB0cmVlwrtodHRwczovL3Ut Ym9vdC5yZWFkdGhlZG9jcy5pby9lbi9sYXRlc3QvdXNhZ2UvZmR0X292ZXJsYXlzLmh0bWwg IHRvIGtub3cgaG93IHVib290IG1hbmlwdWxhdGVzIHRoZW0uDQpUaGVzZSBvdmVybGF5cyBs b29rIHJhdGhlciBtYW51YWwsIHRvIGJlIGRvbmUgYnkgdGhlIHVzZXIgZm9yIGluZGl2aWR1 YWwgDQptb2RlbHMsIEkgZG9uJ3Qgc2VlIHRoZSByZWxldmFuY3kuDQo+IE1vcmVvdmVyLCBS YXNwYmVycnkgUEkgdWJvb3QgdXNlcyBEVEIgdG8gYm9vdCBvbiB0aGUgYm9hcmQgYXMgaW5o dHRwczovL3BhdGNod29yay5vemxhYnMub3JnL3Byb2plY3QvdWJvb3QvcGF0Y2gvMjAxOTEx MDYxNDQxMDQuMjgxNzctMS1tYXR0aGlhcy5iZ2dAa2VybmVsLm9yZy8gIChJbnN0ZWFkIG9m IHVzaW5nIHRoZSBlbWJlZGRlZCBEVEIgYXMgZG9uZSBpbiBSUGkzIHdlIHVzZSB0aGUgZGV2 aWNldHJlZSBwcm92aWRlZCBieSB0aGUgZmlybXdhcmUuKQ0KR29pbmcgYnkgdGhlIG1lbnRp b24gb2YgJ2RlZmNvbmZpZycgYW5kICdhcmNoL2FybScgYW5kICdjb25maWdzJywgdGhpcyAN CmFwcGVhcnMgdG8gYmUgYSBwYXRjaCB0byBMaW51eCwgbm90IHVib290LiBBcyBzdWNoLCBp dCBhcHBlYXJzIHRoYXQgdGhlIA0KZGV2aWNlIHRyZWUgaW5mb3JtYXRpb24gaXMgdXNlZCBi eSBMaW51eCBoZXJlLCB0aGVyZSBpcyBubyBpbmZvcm1hdGlvbiANCnRoZXJlIG9uIHdoZXRo ZXIgaXQgaXMgdXNlZCBieSBVLUJvb3QuDQo+PiBib290bG9hZGVycyBkb24ndCBtYWdpY2Fs bHkgaGF2ZSBhY2Nlc3MgdG8gbW9yZSBpbmZvcm1hdGlvbiB0aGFuIGtlcm5lbHMNCj4gVGhl eSBkbywgaWYgdGhleSBhcmUgcnVuIG9uIGEgc2VwYXJhdGUgY29yZSBvbiB0aGUgU09DIHRo YXQgbGludXggb3IgYXJtIGNvcmUgaGFzIG5vIGFjY2VzcyB0by4gIENoZWNraHR0cHM6Ly9n aXRodWIuY29tL2NocmlzdGluYWEvcnBpLW9wZW4tZmlybXdhcmUNCg0KVGhhdCdzIGEgc2V0 dXAgSSB3b3VsZCBub3QgaGF2ZSBleHBlY3RlZC4NCg0KQUZBSUsgbm90aGluZyBpcyBzdG9w cGluZyBMaW51eCBmcm9tIHNlbmRpbmcgc29tZSBjb2RlIHRvIHRoZSBzZXBhcmF0ZSANCmNv cmUgdG8gZmlndXJlIG91dCB0aGUgcmVsZXZhbnQgaW5mb3JtYXRpb24gYW5kIHNlbmRpbmcg aXQgYmFjayB0byANCkxpbnV4LiBCdXQgZ2l2ZW4gdGhlIHVudXN1YWwgc2V0dXAsIEkgd291 bGQgY29uc2lkZXIgaXQgcGxhdXNpYmxlIHRoYXQgDQpMaW51eCBwZW9wbGUgd2FudCB0byBk ZWxlZ2F0ZSBzdWNoIHJlc3BvbnNpYmlsaXR5IHRvIHRoZSBib290bG9hZGVyLg0KDQpXYXMg dGhpcyAoaS5lLiAidGhleSBhcmUgcnVuIG9uIGEgc2VwYXJhdGUgY29yZSBvbiB0aGUgU09D IC4uLiIpIHRoZSANCmNhc2UgZm9yIHRoZSBSYXNwYmVycnkgZGV2aWNlIHlvdSBhcmUgdHJ5 aW5nIHRvIHN1cHBvcnQ/DQoNCklmIHNvLCBmaWd1cmluZyBvdXQgdGhlIGFwcHJvcHJpYXRl IG9wdGlvbnMgdG8gbGV0IFUtYm9vdCBwYXNzIHRoZSANCmRldmljZSB0cmVlIHRvIExpbnV4 IHNlZW1zIHJlYXNvbmFibGUgdG8gbWUuDQoNCj4+IE15IHBvaW50IGlzIHRoYXQgc3VwcG9y dGluZyBtb3JlIGRldmljZXMgd291bGQgYmUgbmljZSwgYnV0IHRoaXMgcGF0Y2ggaXNuJ3Qg dGhlIHdheSB0byBkbyBpdC4NCj4gV2VsbCwgdGhlcmUgaXMgbm8gb3RoZXIgd2F5IHRvIHN1 cHBvcnQgZGV2aWNlcyB0aGF0IHJlcXVpcmUgRFRCIG5vdCB0byBiZSBsb2FkZWQgd2l0aCB1 Ym9vdC4gVGhlIHNvbHV0aW9ucyB5b3Ugc3VnZ2VzdCBhcmUgbm90IHBvc3NpYmxlLg0KPg0K PiBNb3Jlb3Zlciwga2VlcCBpbiBtaW5kIEZEVERJUiBpcyBub3QgaW4gdGhlaHR0cDovL3d3 dy5mcmVlZGVza3RvcC5vcmcvd2lraS9TcGVjaWZpY2F0aW9ucy9Cb290TG9hZGVyU3BlYy8g IHNwZWNpZmljYXRpb24gYW5kIG1ha2luZyBpcyBwZXJtYW5lbnQgd2UgYmFzaWNhbGx5IHZp b2xhdGUgaXQuDQoNCkFuZCBpcyB0aGlzIGEgYmFkIHRoaW5nLCBhbmQgaWYgc28sIHBlcmhh cHMgRkRURElSIGNvdWxkIGJlIGFkZGVkIHRvIHRoZSANCnNwZWNpZmljYXRpb24/IEd1aXgg YmVpbmcgaW4gdmlvbGF0aW9uIG9mIHNvbWUgc3BlY2lmaWNhdGlvbiBpcyBub3QgaW4gDQpp dHNlbGYgYSBidWcsIGZvciBleGFtcGxlIHRoZSBzdG9yZSBtb2RlbCBvZiBHdWl4IGlzIG5v dCAnTGludXggU3RhbmRhcmQgDQpCYXNlJy4NCg0KSXQgbWlnaHQgYmUgYSBiYWQgdGhpbmcs IGJ1dCB0aGVyZSdzIGEgc3RlcCBtaXNzaW5nIGluIHlvdXIgYXJndW1lbnQuDQoNCj4gU2lu Y2Ugd2XigJl2ZSBub3QgY29tZSB0byBhbnkgdW5kZXJzdGFuZGluZyBoZXJlLCBJIGtpbmRs eSBpbnZpdGUgVmFncmFudCBhbmQgVG9iaWFzIHRvIGpvaW4gdGhlIGRpc2N1c3Npb24uIFRo ZXkgc2VlbSB0byBiZSBmYW1pbGlhciB3aXRoIHRoZSByZWxldmFudCBwYXJ0cyBvZiBHVUlY Lg0KDQpTZWUgdGhlICdJZiBzbywgZmlndXJpbmcgb3V0IHRoZSBhcHByb3ByaWF0ZSBvcHRp b25zIC4uLicgYWJvdmUuDQoNCkFsc28sIGFnYWluLCBpdCdzIEd1aXgsIG5vdCBHVUlYLiBH VUlYIGlzIGEgTWljcm9zb2Z0IHRoaW5nLg0KDQpHcmVldGluZ3MsDQpNYXhpbWUNCg== --------------bBciqExNXhhUpF0eiumwpunl Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On 22-08-2022 21:19, Pavel Shlyak wrote:
Subject:
Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR
From:
Pavel Shlyak <p.shlyak@pantherx.org>
Date:
22-08-2022 21:19
To:
Maxime Devos <maximedevos@telenet.be>
CC:
57070@debbugs.gnu.org, vagrant@debian.org, Tobia= s Geerinckx-Rice <me@tobias.gr>		 

Could you point me at th=
e documentation or code that claims or does that? I am not finding any ev=
idence that device trees are generated at boot.

Google =C2=ABdevice tree r=
aspberry bootloader=C2=BB, 1st result https://forums.raspberrypi.com/viewtopic.php?t=3D329799<=
/a>

That web page does not claim that anywhere. 

If the bootloader can, s=
urely the kernel can.

Bootloader runs on GPU on =
Raspberry. It cannot run kernel.=20
Also, check m1n1 on Apple. It has docs.

I have never claimed that the GPU can run the kernel.

What does m1n1 have to do with anything here? m1n1 isn't extlinux and isn't packaged in Guix.

Bootloaders running on the GPU is something I'm not used to at all, it's not something I had expected, see later.

I believe the kernel fol=
ks will appreciate a patch fixing the DT for RPI3b+ and Compute Module 4.=


And for other devices that=
 behave the same way? You=E2=80=99re literally promoting making GUIX not =
bootable on all devices alike.

I literally never wrote such a thing. In what sentences did I promote that?

Even if you meant 'implied' instead of 'literally', then that still doesn't make sense to me; I'm running Guix System, it's in my own interest to keep it bootable on my device. 

DTs are a kernel thing, =
e.g. the Linux documentation https://www.kernel.org/doc/html/latest/devicetree/usag=
e-model.html mentions DT, also, Linux.  I could not find any informat=
ion on bootloaders loading DTs.

Because you didn=E2=80=99t=
 search for it.
I did search for it, figuring out an _appropriate_ query and finding relevant results is another matter.
 Google
No. It has monopoly and privacy problems.
 =C2=ABdevice tree raspber=
ry bootloader=C2=BB, the first link is about bootloader forming the devic=
e tree https://forums=
=2Eraspberrypi.com/viewtopic.php?t=3D329799.
Generating the DT is a different matter from loading the DT.=C2=A0 It= 's also about firmware, not the bootloader.
 Google =C2=ABuboot device=
 tree=C2=BB h=
ttps://u-boot.readthedocs.io/en/latest/usage/fdt_overlays.html to kno=
w how uboot manipulates them.
These overlays look rather manual, to be done by the user for individual models, I don't see the relevancy. 
Moreover, Raspberry PI ubo=
ot uses DTB to boot on the board as in https://patchw=
ork.ozlabs.org/project/uboot/patch/20191106144104.28177-1-matthias.bgg@ke=
rnel.org/ (Instead of using the embedded DTB as done in RPi3 we use t=
he devicetree provided by the firmware.)
Going by the mention of 'defconfig' and 'arch/arm' and 'configs', this appears to be a patch to Linux, not uboot. As such, it appears that the device tree information is used by Linux here, there is no information there on whether it is used by U-Boot. 
bootloaders don't magica=
lly have access to more information than kernels

They do, if they are run o=
n a separate core on the SOC that linux or arm core has no access to.  Ch=
eck https://github.com/christ=
inaa/rpi-open-firmware

That's a setup I would not have expected.

AFAIK nothing is stopping Linux from sending some code to the separate core to figure out the relevant information and sending it back to Linux. But given the unusual setup, I would consider it plausible that Linux people want to delegate such responsibility to the bootloader.

Was this (i.e. "they are run on a separate core on the SOC ...") the case for the Raspberry device you are trying to support?

If so, figuring out the appropriate options to let U-boot pass the device tree to Linux seems reasonable to me.

My point is that support=
ing more devices would be nice, but this patch isn't the way to do it.

Well, there is no other wa=
y to support devices that require DTB not to be loaded with uboot. The so=
lutions you suggest are not possible.

Moreover, keep in mind FDTDIR is not in the http://www.freedesktop.org/wiki/Specificati=
ons/BootLoaderSpec/ specification and making is permanent we basicall=
y violate it.

And is this a bad thing, and if so, perhaps FDTDIR could be added to the specification? Guix being in violation of some specification is not in itself a bug, for example the store model of Guix is not 'Linux Standard Base'.

It might be a bad thing, but there's a step missing in your argument.

Since we=E2=80=99ve not co=
me to any understanding here, I kindly invite Vagrant and Tobias to join =
the discussion. They seem to be familiar with the relevant parts of GUIX.=

See the 'If so, figuring out the appropriate options ...' above.

Also, again, it's Guix, not GUIX. GUIX is a Microsoft thing.

Greetings,
Maxime
--------------bBciqExNXhhUpF0eiumwpunl-- --------------3YHSJjIlSwiHymjoqY8vCFeB Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------3YHSJjIlSwiHymjoqY8vCFeB-- --------------eR1OKklFJMw0nobR4a7POARw-- --------------3MQq4iJyiBjf3j3lnkXOlwHU Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYwPyWQUDAAAAAAAKCRBJ4+4iGRcl7kZW AQCUmfKLfWOf30qdBSE3+p5z25x/JaugfOGf8HzAPUeTLwEAiQBTm0B8yeya8pbFp+dB75H7j4On bdbDRvkp0Tx/xQg= =nuJf -----END PGP SIGNATURE----- --------------3MQq4iJyiBjf3j3lnkXOlwHU-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 17:29:23 2022 Received: (at 57070) by debbugs.gnu.org; 22 Aug 2022 21:29:23 +0000 Received: from localhost ([127.0.0.1]:41950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQEz4-0007KN-RR for submit@debbugs.gnu.org; Mon, 22 Aug 2022 17:29:23 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQEz2-0007K6-I7 for 57070@debbugs.gnu.org; Mon, 22 Aug 2022 17:29:21 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 630A95C00D6; Mon, 22 Aug 2022 17:29:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 22 Aug 2022 17:29:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1661203753; x=1661290153; bh=GbO5HxsfXK OFMmk+M1KCle4DU7rWzYBRAPQEvvp8+DU=; b=Al7Nhc3lrZuv3JvWIGtaTpxx1+ qgTWVLR9kE2gKYZSAFZwOUNkQgF91mmooz+OYvUZNHm/ZWzXAHkhwUA852gXykUz TAAoL5ZAZJspwBENcS87iSwwtAooCOm/3QXyMSC1wTuS65MzJSdT7JNRF2wgZPtH J4NPDl/pGmFGtOkYQ8iAkhy+jh4uim6L4q0JbOhtupYuYBgjitPnrnl42oLMQjNG ASqwIyA6Xa7BABJF/QAwxQtQErVMPcGaxGO9JHCGK75YY0Vy7hgCQ8+mxhbxSDtk mmh7yf19lrk6vFIsg23/v/aqFJ+bD+rMBWtgSStqfQjA+fpN58hH+T9UtgQA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661203753; x=1661290153; bh=GbO5HxsfXKOFMmk+M1KCle4DU7rW zYBRAPQEvvp8+DU=; b=O8G4kICFCc1kYlzPYHi4CJg0oHx2LRzVl2EpfkcWfvGR my0VJZ6d9p4Pm5JwCm1/Tz38+3zvQKensp3S8sQSubSo0WsZwgrnHPbS/ZennXdl BMUZBhYWWsgwH3Y3EOmoF1dk3UaOWfPIWT4q5IJFzYG2k1iQmzojik448s3Wa4Ay FtmXdUkUpoojCqlT2UC0AFNs+8udO3qy0wnLmlIxt2qMXt6NIoPnXuWyduwWfnJO NXWZNU4o07o/SVilyNgD5ddj8jM6/C1rinOdvDplS2g6IYxVPKcUHJ/GM30Gt4DH kIkt/8P+paYIghPSUllH2oZKvRJEBleEPGpwACNJVw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdeijedgudeigecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhkfgtggfuffgjvefvfhfosegrtdhmrehhtdejnecuhfhrohhmpefrrghv vghlucfuhhhlhigrkhcuoehprdhshhhlhigrkhesphgrnhhthhgvrhigrdhorhhgqeenuc ggtffrrghtthgvrhhnpeehjedugfekgffhjeekkeetfeehhfeffeevudeitdefiefffeei ffeuhffhieegteenucffohhmrghinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghn thhhvghrgidrohhrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 22 Aug 2022 17:29:12 -0400 (EDT) From: Pavel Shlyak Message-Id: <9C1A13AC-4FAA-4D45-8579-FF88D5E69A90@pantherx.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_14550530-0BF4-4FA0-BFD5-4253F3EAD310" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR Date: Tue, 23 Aug 2022 00:29:11 +0300 In-Reply-To: To: Maxime Devos References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> <13223735-7417-4785-81F8-43715A135574@pantherx.org> X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --Apple-Mail=_14550530-0BF4-4FA0-BFD5-4253F3EAD310 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > That web page does not claim that anywhere. Here's a rough list of the DT changes performed by the firmware, besides = merging the obvious dtoverlays and dtparams: * Applying the "upstream" overlay, if "upstream_kernel=3D1". * Changing the CPU ID declarations on a Pi 2+ (BCM2837 vs BCM2836). * Adding i2c_vc and i2c_arm labels and aliases (and their relatives). * If the board has a POWER_LOW GPIO declared in dt-blob.bin, using that = to configure the pwr_led node. * Adding the Bluetooth flow control pins to the "uart0_pins" node, on = boards that support it. * Setting numerous items to /chosen - bootargs (the command line), = rpi-boardrev-ext, rpi-country-code (Pi 400), details of the bootloader = version, boot-mode, linux,initrd-start and linux,initrd-end. * Adding a copy of the bootloader configuration. * Loading the vl805 overlay on CM4s which have "VL805=3D1" in their = bootloader configuration. * Automatically loading overlays for supported cameras that are = detected. * Automatically loading overlays for the PoE HATs, switching between = firmware-driven and I2C-driven as needed. * Expanding the dma-ranges property of the emmc2bus node on BCM2711C0. * Disabling the old OTG USB controller and enabling the XHCI controller = if "otg_mode=3D1". * Loading the appropriate rpi- display overlay. * Setting the aliases "serial0" and "serial1" to point to the = console/user UART and the Bluetooth/spare UART, respectively. * Adding information about the HAT in "/hat". * Copying any significant error messages to "/chosen/user-warning", from = where it can be read by the GUI and turned into notifications. * Declaring the available RAM. * Passing the board revision, serial number, kaslr seed and rng seed. * Limiting the size of the CMA region to 256MB if < 2GB RAM or gpu_mem > = 256. * Expanding the inbound window declared by the pcie0 dma-ranges property = on a C0, moving the base address to 0x4_00000000 regardless. * Setting the MDIO address of the Ethernet PHY. * Declaring a simple-framebuffer, if wanted. > What does m1n1 have to do with anything here? m1n1 isn't extlinux and = isn't packaged in Guix. It chainloads uboot > Going by the mention of 'defconfig' and 'arch/arm' and 'configs', this = appears to be a patch to Linux, not uboot. As such, it appears that the = device tree information is used by Linux here, there is no information = there on whether it is used by U-Boot. I cannot agree. = https://github.com/u-boot/u-boot/blob/master/arch/arm/mach-bcm283x/Kconfig= = = https://github.com/u-boot/u-boot/blob/master/configs/A10-OLinuXino-Lime_de= fconfig = > And is this a bad thing, and if so, perhaps FDTDIR could be added to = the specification? I don=E2=80=99t think so. Keep in mind the source code in Guix is named = extlinux.scm and the file is named extlinux.conf and extlinux doesn=E2=80=99= t support FDTDIR > If so, figuring out the appropriate options to let U-boot pass the = device tree to Linux seems reasonable to me. Of course it passes device tree. The problem in question is the source = of that device tree: in my case, it should not be loaded from a file. --Apple-Mail=_14550530-0BF4-4FA0-BFD5-4253F3EAD310 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 > That web page = does not claim that anywhere.

Here's a = rough list of the DT changes performed by the firmware, besides merging = the obvious dtoverlays and dtparams:
* Applying the = "upstream" overlay, if "upstream_kernel=3D1".
* Changing = the CPU ID declarations on a Pi 2+ (BCM2837 vs BCM2836).
* = Adding i2c_vc and i2c_arm labels and aliases (and their relatives).
* If the board has a POWER_LOW GPIO declared in dt-blob.bin, = using that to configure the pwr_led node.
* Adding the = Bluetooth flow control pins to the "uart0_pins" node, on boards that = support it.
* Setting numerous items to /chosen - bootargs = (the command line), rpi-boardrev-ext, rpi-country-code (Pi 400), details = of the bootloader version, boot-mode, linux,initrd-start and = linux,initrd-end.
* Adding a copy of the bootloader = configuration.
* Loading the vl805 overlay on CM4s which = have "VL805=3D1" in their bootloader configuration.
* = Automatically loading overlays for supported cameras that are = detected.
* Automatically loading overlays for the PoE = HATs, switching between firmware-driven and I2C-driven as needed.
* Expanding the dma-ranges property of the emmc2bus node on = BCM2711C0.
* Disabling the old OTG USB controller and = enabling the XHCI controller if "otg_mode=3D1".
* Loading = the appropriate rpi- display overlay.
* Setting the = aliases "serial0" and "serial1" to point to the console/user UART and = the Bluetooth/spare UART, respectively.
* Adding = information about the HAT in "/hat".
* Copying any = significant error messages to "/chosen/user-warning", from where it can = be read by the GUI and turned into notifications.
* = Declaring the available RAM.
* Passing the board revision, = serial number, kaslr seed and rng seed.
* Limiting the = size of the CMA region to 256MB if < 2GB RAM or gpu_mem > 256.
* Expanding the inbound window declared by the pcie0 = dma-ranges property on a C0, moving the base address to 0x4_00000000 = regardless.
* Setting the MDIO address of the Ethernet = PHY.
* Declaring a simple-framebuffer, if wanted.

> What does m1n1 have to do with = anything here? m1n1 isn't extlinux and isn't packaged in Guix.

It chainloads uboot

> Going by the mention of = 'defconfig' and 'arch/arm' and 'configs', this appears to be a patch to = Linux, not uboot. As such, it appears that the device tree information = is used by Linux here, there is no information there on whether it = is used by U-Boot.

I cannot agree.
https://github.com/u-boot/u-boot/blob/master/arch/arm/mach-bcm2= 83x/Kconfig
https://github.com/u-boot/u-boot/blob/master/configs/A10-OLinuX= ino-Lime_defconfig

> And is this a bad thing, = and if so, perhaps FDTDIR could be added to the = specification?

I don=E2=80=99t think so. Keep in mind the source code in = Guix is named extlinux.scm and the file is named extlinux.conf and = extlinux doesn=E2=80=99t support FDTDIR

> If so, figuring out the appropriate options = to let U-boot pass the device tree to Linux seems reasonable to = me.

Of course = it passes device tree. The problem in question is the source of that = device tree: in my case, it should not be loaded from a file.


= --Apple-Mail=_14550530-0BF4-4FA0-BFD5-4253F3EAD310-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 23 14:11:23 2022 Received: (at 57070) by debbugs.gnu.org; 23 Aug 2022 18:11:23 +0000 Received: from localhost ([127.0.0.1]:45038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQYN1-0004IJ-8v for submit@debbugs.gnu.org; Tue, 23 Aug 2022 14:11:23 -0400 Received: from cascadia.aikidev.net ([173.255.214.101]:37826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQYMy-0004I3-Jk for 57070@debbugs.gnu.org; Tue, 23 Aug 2022 14:11:21 -0400 Received: from localhost (unknown [IPv6:2600:3c01:e000:21:7:77:0:20]) (Authenticated sender: vagrant@cascadia.debian.net) by cascadia.aikidev.net (Postfix) with ESMTPSA id 308E71AC2D; Tue, 23 Aug 2022 11:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=debian.org; s=1.vagrant.user; t=1661278271; bh=40qmPmL+/gun3ptWBmHqRG8H49qFOfOTLPkzU0/Pwx4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XwStUPVLVt4p9M7CrLfg8gjFEBiDFyzL/cNmInLTk8ttF/lSpqfSxiKVyrbuGDKkm UqtErhy8SzsGnVI72q//2rHVVa5/eFXK+hg4TU/HHOtgLsXe2I2wIpXIswPlujbuqI hiu4bGILc+wBDGlbXAPvMQSMiOyw/n/+lB9LeynJrx46w3wI3TA5QQAHkvmSQxXdix HspOuoJn6BqxO/zNcdH+YJvVGBeXBjG+k3E6hUtXg3aywKdnKA3dMiBgYlki2GRgK2 9vmxKZ9H/tWYETsnaB2+SeTvVLvpPX08glFPVzhrRR8FdMo96e2jGrZ+krG2iH7WyU VqRi29NlIK2JQ== From: Vagrant Cascadian To: Pavel Shlyak , Maxime Devos Subject: Re: [bug#57070] [PATCH] bootloader: extlinux: support for optional FDTDIR In-Reply-To: <13223735-7417-4785-81F8-43715A135574@pantherx.org> References: <20220809145730.435ef8d0@pantherx.org> <483BAA4D-ADDE-43C2-B1E3-BADAD7C43E7D@pantherx.org> <85904cd4-576d-81d0-2cfc-05ff0ab802a6@telenet.be> <13223735-7417-4785-81F8-43715A135574@pantherx.org> Date: Tue, 23 Aug 2022 11:11:06 -0700 Message-ID: <871qt6bzk5.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org, Tobias Geerinckx-Rice X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2022-08-22, Pavel Shlyak wrote: >> Could you point me at the documentation or code that claims or does >> that? I am not finding any evidence that device trees are generated >> at boot. I don't know exactly where in the code off the top of my head, but u-boot definitely has support for modifying the device-tree it passes to the kernel, and in some cases (e.g. memory layout, framebuffer) *requires* modifying the device-tree that is passed to the kernel. FWIW, I say this as someone who's maintained u-boot in debian (and to some degree guix) for years... Also, for some virtual platforms (qemu-riscv64?) the device-tree is created on-the-fly when bootstrapping the virtual machine; in these cases you have to rely on the device-tree passed via the boot "firmware" as you shouldn't need to recompile the kernel just to pass a different set of qemu arguments! There are cases where the kernel cannot possibly track the combinatorial explosion of potential add-on hardware modules (rpi hats, beagleboard capes, etc.) that need to be represented in the device-tree in order to work, sometimes before the kernel is even booted. There is some support for device-tree overlays both in-kernel and in u-boot (and plausibly other bootloaders) kernel to handle this, but in many cases, a simpler and more reliable method is to provide a single custom device-tree. > And for other devices that behave the same way? You=E2=80=99re literally > promoting making GUIX not bootable on all devices alike. > >> DTs are a kernel thing, e.g. the Linux documentation >> https://www.kernel.org/doc/html/latest/devicetree/usage-model.html >> mentions DT, also, Linux. Yes and no. Device-trees are used in, by and for both bootloaders and kernels alike. There is long-standing debate around device-tree should being treated as a boot firmware thing rather than a kernel thing. There are some pretty simple questions: You don't see ACPI tables for every supported x86 board in the kernel, why should boards using device-tree be any different? Why is the linux kernel the source of device-trees for, say, the Hurd, *BSD, etc.? So yes, it is de-facto where most device-trees come from at the end of the day, but ... that doesn't necessarily mean it *should* be. >> I could not find any information on bootloaders loading DTs. Well, that's what the FDTDIR and FDT settings for extlinux do; it tells the bootloader (e.g. u-boot) to load a device-tree. Grub also has a devicetree option, though no correlary to FDTDIR. If grub isn't passed a devicetree argument, it passes whatever devicetree that was passed from the boot firmware, as I understand it. >> My point is that supporting more devices would be nice, but this patch i= sn't the way to do it. > > Well, there is no other way to support devices that require DTB not to be= loaded with uboot. The solutions you suggest are not possible. > > Moreover, keep in mind FDTDIR is not in the http://www.freedesktop.org/wi= ki/Specifications/BootLoaderSpec/ specification and making is permanent we = basically violate it.=20 Hrm, that's unfortunate. I daresay supporting FDTDIR is a good thing, as it allows you to use the same boot media to boot multiple different devices, presuming they all have a .dtb present for the relevent boards. Booting arm systems have come a long way from you need a specifically compiled kernel for every different board, but it is still a horrible mess. Sometimes things are implemented in kernel, sometimes in the bootloader, sometimes in the boot firmware, with possibly 3-4 different boot firmware layers... and exactly where may be specific to a particular board. There are arguments that any particular thing might be better implemented at any of those layers, and maybe there is a convincing reason to move something from one layer to another... At the end of the day, the reality is that board support for some platforms (e.g. arm* and possibly riscv*) is a mess of inconsistancy and the usually you need to support multiple different ways of doing seemingly the same things. I think this tends to be hidden from view for x86 as quirks are just worked around in the kernel, whereas with some platforms where more of the boot firmware is free software it is possible to fix it in a more appropriate layer... or whatever layer the someone just happens to get it to work at first! If adding an option to drop the FDTDIR extlinux configuration allows booting more platforms, I see no fundamental reason why it is wrong, as long as it doesn't break existing platforms... the implementation details, I'll leave to people more savvy with scheme. :) live well, vagrant --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQRlgHNhO/zFx+LkXUXcUY/If5cWqgUCYwUYOwAKCRDcUY/If5cW qhV0AQC8N604ajTkp+Jeo30asfRuzvJ3XqvmyHxuboRPzqj+owD/TsKMAbmJRnR/ TCD46jwmVRj10spalBXSGdAfq6KEpA8= =v/wn -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 25 13:35:55 2022 Received: (at 57070) by debbugs.gnu.org; 25 Aug 2022 17:35:55 +0000 Received: from localhost ([127.0.0.1]:51198 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRGln-0006s8-30 for submit@debbugs.gnu.org; Thu, 25 Aug 2022 13:35:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48626) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRGll-0006rw-Jd for 57070@debbugs.gnu.org; Thu, 25 Aug 2022 13:35:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54440) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRGlg-0001gc-7R; Thu, 25 Aug 2022 13:35:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=jmwhLmNZ1AEPVwc9Ev7PCCGVLBH9Q072doQquadt4Do=; b=SLXFL0poGm/Fw+h/yjo6 ynCx+bMsnAlwt0oYp7hzkjbijhHEf4ujNzu3hm++qL7Og2mci3VhmS4Wzb8lxxUSPo6jhFf4C5GP0 qYbDAm42n7Sp5aoXWeduhYIBf/miPiqbZ7ghetW+gHPuUiKOuRgfBeVA8Vf4attwVUwWhfnoJ8fG6 R57dou4g6bWNAEHGRMWH8QDGm1GQ+41fZO9kjavakekGM+7WHE0Y71bgeTkVEi9TTGlMUi8Lo50Z9 PCqARqaZ7mCluf8OS9sRhe1GhbNvuR79dmYqRq1eSxyasgOF8Qq6ln+UP/e+gVV1tHL85VKiLVOPh FEA81u/DLCwpbw==; Received: from [2001:b07:6473:5604:6777:3eba:ebea:f1b1] (port=38712 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRGlf-0001bo-Q2; Thu, 25 Aug 2022 13:35:48 -0400 From: Mathieu Othacehe To: Reza Alizadeh Majd Subject: Re: bug#57070: [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809103044.27964-1-r.majd@pantherx.org> <20220816224004.1744c1d5@pantherx.org> Date: Thu, 25 Aug 2022 19:35:45 +0200 In-Reply-To: <20220816224004.1744c1d5@pantherx.org> (Reza Alizadeh Majd's message of "Tue, 16 Aug 2022 22:40:04 +0430") Message-ID: <87lerc5iq6.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, OK, so I read the long thread. There's still something unclear to me. If FDTDIR is not passed, where is located the device tree that is loaded? Directly in the /boot partition? It looks like the corresponding code is in the label_boot function of the u-boot/boot/pxe_utils.c file. I quickly read this part hoping to find a way to define a priority between device trees located in the FDTDIR directory and device trees installed elsewhere. > * gnu/bootloader.scm ()[device-tree-support?]: new field. You need to document this new field in the "Bootloader Configuration" documentation section. > * gnu/tests/bootloader.scm: add tests for FDTDIR modification. This will test for regressions on an x86_64-linux machine that will probably never use this FDTDIR thing. As those tests are expensive to run an maintain we can probably remove the test. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 25 15:17:01 2022 Received: (at 57070) by debbugs.gnu.org; 25 Aug 2022 19:17:01 +0000 Received: from localhost ([127.0.0.1]:51338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRILd-0001Dv-6q for submit@debbugs.gnu.org; Thu, 25 Aug 2022 15:17:01 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRILa-0001DW-9b for 57070@debbugs.gnu.org; Thu, 25 Aug 2022 15:17:00 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 39A3B5C00AB for <57070@debbugs.gnu.org>; Thu, 25 Aug 2022 15:16:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 25 Aug 2022 15:16:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm2; t=1661455011; x=1661541411; bh=jv+JPom6/v Z0ymKiLBiBBUlaBVpMqYTpGP3DUTn2Af4=; b=W0yB93/gUtTNCFEBS/7uZpGlcu VPd1KyuavnrMKYz0KFixxdWzwUZ0lCpvEvjP6S0idSUINga+d5J/nmluDGJ4buT+ zOwvwHc8nc8fD+63wfCdmvZBg5c36zx23Ocbmm8G1VG+uPbbmUVGmGuYd5XR5C5A /v7+7iJRDaju+/qSTzynWST79mfZ/BuwbM7a/ZUMI1pJhZgzB7+9O8eKa05K9Nd0 tcShlxPE4XLF/x8zTDd3D1Rgr+z5fujtGyip+uDmXw+rINEcGwgOOzy4knuT8b8M usz5uc43wXMQ61+natHEttRFZYS/SABbe+f8z8BwczCdeB3hJtc54fLhOnSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661455011; x=1661541411; bh=jv+JPom6/vZ0ymKiLBiBBUlaBVpM qYTpGP3DUTn2Af4=; b=NrVIiJHHwuaR1+B40WcdiBfmlxWkW7/zBQigNt1I+H+K TzHPQjeH3et9yYVXCtWRRGUeQq8miq57QSVAE9fLzc5/D0sjPR0pr5Ik6JYcTxI+ m8BWPveQfBTZzc7+WD5SF1BD03zSZgUnFyeE72EfjuzSExPasJDXe8ZdOa1z6GKQ oc7YqCjUTvC54tM610aqPcpvzZeySeM9VTdO2tL5UZVtOjwzslQNG/t3EJzju2Xr WdmSBcEAnV/m23k9vmy404pZERQ4ftZEZNxt+tRIx/R7oK8opbMXaLC6c3Xr0iQV LtG6/kTVSNYquP5dtQoNyvVGMkPrdhU6CmpTvUFZ8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejfedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephfgtgfgguffkfffvofesthhqmh dthhdtjeenucfhrhhomheprfgrvhgvlhcuufhhlhihrghkuceophdrshhhlhihrghksehp rghnthhhvghrgidrohhrgheqnecuggftrfgrthhtvghrnhepgfeiffelfeeuvdetkedtud fhkeehjeegjedtkeevfeehkefhvdekjeelfefgtddtnecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepphdrshhhlhihrghksehprghnthhhvghrgi drohhrgh X-ME-Proxy: Feedback-ID: idda946d0:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <57070@debbugs.gnu.org>; Thu, 25 Aug 2022 15:16:50 -0400 (EDT) From: Pavel Shlyak Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR Message-Id: Date: Thu, 25 Aug 2022 22:16:48 +0300 To: 57070@debbugs.gnu.org X-Mailer: Apple Mail (2.3696.120.41.1.1) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, Mathieu Thanks for joining us here! Firstly, I kindly ask everyone in this thread to CC me as emails from = this thread are not delivered to me for some reason I don=E2=80=99t = really understand. I get emails from all other threads but this one. Secondly, to reply you question "where is located the device tree that = is loaded?", I would like to refer uboot source code comments, as I have = not seen this point documented anywhere else. Check boot/pxe_utils.c /* * fdt usage is optional: * It handles the following scenarios. * * Scenario 1: If fdt_addr_r specified and "fdt" or "fdtdir" = label is * defined in pxe file, retrieve fdt blob from server. Pass = fdt_addr_r to * bootm, and adjust argc appropriately. * * If retrieve fails and no exact fdt blob is specified in pxe = file with * "fdt" label, try Scenario 2. * * Scenario 2: If there is an fdt_addr specified, pass it along = to * bootm, and adjust argc appropriately. * * Scenario 3: If there is an fdtcontroladdr specified, pass it = along to * bootm, and adjust argc appropriately. * * Scenario 4: fdt blob is not available. */ In other words, if there=E2=80=99s no fdtdir, uboot just passes the = fdt_addr to bootm command, that means it passes the pointer to device = tree loaded by firmware (or previous bootloader) to the kernel. If = fdt_addr is also missing, it passes fdtcontroladdr to the kernel. If all = of the previous scenarios don=E2=80=99t work, it passes no FDT and = kernel boots without device tree, that is absolutely normal on some = devices, check x86. As for the tests and documentation, I think I should leave these = questions to Reza, as they have more experience and deeper = understanding. Sincerely, Pavel= From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 28 04:20:02 2022 Received: (at 57070) by debbugs.gnu.org; 28 Aug 2022 08:20:03 +0000 Received: from localhost ([127.0.0.1]:57562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSDWL-0005XO-Lf for submit@debbugs.gnu.org; Sun, 28 Aug 2022 04:20:02 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46673) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSDWG-0005X9-Mr for 57070@debbugs.gnu.org; Sun, 28 Aug 2022 04:19:52 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id A19A35C0098; Sun, 28 Aug 2022 04:19:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sun, 28 Aug 2022 04:19:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1661674783; x=1661761183; bh=MZ4qDInLWv ZXsoF5WY7DexVAOEb/IEX0ZaEYbw7tgHM=; b=YMf9svH5CpnjHvtUsPCkHQi+1c wxaV7XtDoXrHy699mzM3drfO+R9QubL1I60awTUNaic019Haq8sXvN74u8w9RXkE B4mFCBW/B29qJhHr+iCaoAOQpUg9I5PdFZA1JKZdBhOyI7O2yYgKsRUgVVVHZPbE Xh1vhvmbeU/wQhXQB0QInExbb29BStGpA3mviN+PS1NGK7doz36AG/OpLc5PCbqd +G4HvxFLwE6amZhd+8tOrGyhNtXUk6FqRE3aIjjSp2EsvLhSiZ8Z8n8o7DoxmcKk YoKahhbnAnDg8dOquQ6ds6ILaUzgxYhLY225TZGwItjUMOOaHLEYXsZuANMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661674783; x=1661761183; bh=MZ4qDInLWvZXsoF5WY7DexVAOEb/ IEX0ZaEYbw7tgHM=; b=VbyO2LubIPZrT2SQqn+QNn5yqHpuLtrqnpeTbrsnNHeM 6iQv1aTiBzvo27o3jGPvfYg65IbDGYHhCB+jBD3duqOszegQUcwSZ+OvedkrLzzT CsGxV1G1CZdE86UtsgZsCqcm0pW5+3FgjvJp7UlJnCSPQbHIoT9zrmMg5a1hUoV4 LAdNdc25LKJbwmvlZ7xPYjoJOV6ix00y2lt///l0OidsWq1cCMWb7GG9t6nKmEZP KVm/d/eBBXjMPMsmWjyyX0o81BnnFJSr724fUPcfmjV9bNUPJ4Pa1wnG7sMj0XLh wkSF8kl5NnHXQbFYOHz5hSE1G2wTBf/wqHP99RLx/A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejledgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkjghfohfogggtsehmtderreertddvnecuhfhrohhmpeftvgii rgcutehlihiirgguvghhucforghjugcuoehrrdhmrghjugesphgrnhhthhgvrhigrdhorh hgqeenucggtffrrghtthgvrhhnpeevhfdvjeeukeehtdfhleekjeejudevuefghefhleet udeiudevhffghfejgfefkeenucffohhmrghinhepphgrnhhthhgvrhigrdhorhhgnecuve hluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhdrmhgrjhgu sehprghnthhhvghrgidrohhrgh X-ME-Proxy: Feedback-ID: i063944dc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 28 Aug 2022 04:19:42 -0400 (EDT) Date: Sun, 28 Aug 2022 12:49:38 +0430 From: Reza Alizadeh Majd To: Mathieu Othacehe Subject: Re: bug#57070: [PATCH] bootloader: extlinux: support for optional FDTDIR Message-ID: <20220828124938.0289bd68@pantherx.org> In-Reply-To: <87lerc5iq6.fsf_-_@gnu.org> References: <20220809103044.27964-1-r.majd@pantherx.org> <20220816224004.1744c1d5@pantherx.org> <87lerc5iq6.fsf_-_@gnu.org> Organization: PantherX X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/nd71U4u7Uca52mYRHqIJCak" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --MP_/nd71U4u7Uca52mYRHqIJCak Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Mathieu, On Thu, 25 Aug 2022 19:35:45 +0200 Mathieu Othacehe wrote: > >> * gnu/bootloader.scm ()[device-tree-support?]: new >> field. > >You need to document this new field in the "Bootloader Configuration" >documentation section. > I just checked the "Bootloader Configuration" section. it describes the "bootloader-configuration" record itself, but the proposed patch adds the "device-tree-supports?" field to the "bootloader" record. unfortunately I couldn't find the section describing the "bootloader" record fields. so I added the documentations as a note for the "bootloader" field of "bootloader-configuration" record. >> * gnu/tests/bootloader.scm: add tests for FDTDIR modification. > >This will test for regressions on an x86_64-linux machine that will >probably never use this FDTDIR thing. As those tests are expensive to >run an maintain we can probably remove the test. > OK, I removed the test from recent patch. Best, Reza -- Reza Alizadeh Majd PantherX Team https://pantherx.org --MP_/nd71U4u7Uca52mYRHqIJCak Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-bootloader-extlinux-support-for-optional-FDTDIR.patch =46rom cbeba372def25a957f5d8942f01fbde6cdc03704 Mon Sep 17 00:00:00 2001 From: Reza Alizadeh Majd Date: Sun, 28 Aug 2022 12:34:46 +0430 Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR There are situations that u-boot doesn't have to load from the device tree. some provide the device tree using a vendor bootloader (like what raspberry= -pi does) or with an external bootloader that chainloads the u-boot (what Asahi does for m1n1 bootloader). Unfortunately we couldn't find any reliable document to enforce u-boot to p= ass the device tree via `extlinux.conf`, however during our tests, we found that removing the `FDTDIR` line from the `extlinux.conf` tend us to do so. There is also no reliable way to guess if u-boot bootloader should load dev= ice tree or not on a specific hardware. in addition, there are hardware that can be booted with both firmware device tree on some kernels and with special device tree on other (modified) kernels. the following changes provided to define an optional parameter in record, called which by default is set to #t to keep the current behavior unchanged. if this paramter is set to #f, the FDTDIR l= ine will be discarded from the and u-boot doesn't load the devi= ce tree automatically. * gnu/bootloader.scm ()[device-tree-support?]: new field. * gnu/bootloader/extlinux.scm (extlinux-configuration-file): add FDTDIR line based on bootloader field of . * doc/guix.texi (Bootloader Configuration)[bootloader]: Add note about bootloader's optional FDTDIR support. --- doc/guix.texi | 9 +++++++++ gnu/bootloader.scm | 6 +++++- gnu/bootloader/extlinux.scm | 13 +++++++++++-- 3 files changed, 25 insertions(+), 3 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 023b48ae35..25b336e958 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -36814,6 +36814,15 @@ modules. In particular, @code{(gnu bootloader u-b= oot)} contains definitions of bootloaders for a wide range of ARM and AArch64 systems, using the @uref{https://www.denx.de/wiki/U-Boot/, U-Boot bootloader}. =20 +@quotation Note +There are situations when @code{u-boot} shouldn't load the device tree from +the file system. because it is either unnecessary for the platform being u= sed +or has already been loaded into RAM earlier in the boot process. in such c= ases +you can set the @code{device-tree-support?} field of the @code{bootloader} +record to @code{#f}. setting this flag to @code{#f} removes the @code{FDTD= IR} +from the @file{/boot/extlinux/extlinux.conf}. +@end quotation + @vindex grub-efi-bootloader @code{grub-efi-bootloader} allows to boot on modern systems using the @dfn{Unified Extensible Firmware Interface} (UEFI). This is what you shou= ld diff --git a/gnu/bootloader.scm b/gnu/bootloader.scm index 70e1836179..32fd7f0c2e 100644 --- a/gnu/bootloader.scm +++ b/gnu/bootloader.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2017 Leo Famulari ;;; Copyright =C2=A9 2019, 2021 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd ;;; ;;; This file is part of GNU Guix. ;;; @@ -54,6 +55,7 @@ (define-module (gnu bootloader) bootloader-disk-image-installer bootloader-configuration-file bootloader-configuration-file-generator + bootloader-device-tree-support? =20 bootloader-configuration bootloader-configuration? @@ -172,7 +174,9 @@ (define-record-type* (disk-image-installer bootloader-disk-image-installer (default #f)) (configuration-file bootloader-configuration-file) - (configuration-file-generator bootloader-configuration-file-generator= )) + (configuration-file-generator bootloader-configuration-file-generator) + (device-tree-support? bootloader-device-tree-support? + (default #t))) =20 =0C ;;; diff --git a/gnu/bootloader/extlinux.scm b/gnu/bootloader/extlinux.scm index 6b5ff298e7..f3d69c0cc0 100644 --- a/gnu/bootloader/extlinux.scm +++ b/gnu/bootloader/extlinux.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2017 David Craven ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd ;;; ;;; This file is part of GNU Guix. ;;; @@ -38,6 +39,10 @@ (define* (extlinux-configuration-file config entries (define all-entries (append entries (bootloader-configuration-menu-entries config))) =20 + (define with-fdtdir? + (let ((bootloader (bootloader-configuration-bootloader config))) + (bootloader-device-tree-support? bootloader))) + (define (menu-entry->gexp entry) (let ((label (menu-entry-label entry)) (kernel (menu-entry-linux entry)) @@ -46,12 +51,16 @@ (define (menu-entry->gexp entry) #~(format port "LABEL ~a MENU LABEL ~a KERNEL ~a - FDTDIR ~a/lib/dtbs + ~a INITRD ~a APPEND ~a ~%" #$label #$label - #$kernel (dirname #$kernel) #$initrd + #$kernel + (if #$with-fdtdir? + (string-append "FDTDIR " (dirname #$kernel) "/lib/dtbs= ") + "") + #$initrd (string-join (list #$@kernel-arguments))))) =20 (define builder --=20 2.37.1 --MP_/nd71U4u7Uca52mYRHqIJCak-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 28 11:49:48 2022 Received: (at 57070) by debbugs.gnu.org; 28 Aug 2022 15:49:48 +0000 Received: from localhost ([127.0.0.1]:59541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSKXj-0002k3-QF for submit@debbugs.gnu.org; Sun, 28 Aug 2022 11:49:48 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSKXi-0002jp-9x for 57070@debbugs.gnu.org; Sun, 28 Aug 2022 11:49:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:37082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSKXd-0006E5-0Q; Sun, 28 Aug 2022 11:49:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=CyILr9BhV2LXLyLoUSAVmRDpXPP4AGpKTyGZL+aE1Vk=; b=Ti78tL5wd1u8f2itoQn+ Q002UipkgvEq4mjcEa4sYE46+tCQnS4konDTCyLMpuc4XsX9bJgzSux0ur00GhYyrd2UhGVS0tV2J FykVm/LFaXZ3bYhLEzUP6Qc9NJnWdIAvJYfe0XT9BhjXXHTRZHcshhz4uur8d+WkqP+qPc6qVSI6r cWT/OkI94UJKi5GTBz1ISMA+ioJO1+Ibnn9ajUGR/VREwMg7PYXuSqlxIUYRfIoNbzVXIw5381z6k oYJDU3C1BIq6EkB5S4Lv/Z6VYZWbm8MPZznfGAI7OSj4PGy6yCAPyj2TR0imNsmdV84Uh9xYStbWX 16hEWCgh1Hq5ww==; Received: from pop.92-184-121-240.mobile.abo.orange.fr ([92.184.121.240]:44110 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSKXc-0008Uz-AA; Sun, 28 Aug 2022 11:49:40 -0400 From: Mathieu Othacehe To: Reza Alizadeh Majd Subject: Re: bug#57070: [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809103044.27964-1-r.majd@pantherx.org> <20220816224004.1744c1d5@pantherx.org> <87lerc5iq6.fsf_-_@gnu.org> <20220828124938.0289bd68@pantherx.org> Date: Sun, 28 Aug 2022 17:49:36 +0200 In-Reply-To: <20220828124938.0289bd68@pantherx.org> (Reza Alizadeh Majd's message of "Sun, 28 Aug 2022 12:49:38 +0430") Message-ID: <87ilmcpdv3.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Reza, Thanks for the updated version! > I just checked the "Bootloader Configuration" section. it describes the > "bootloader-configuration" record itself, but the proposed patch adds > the "device-tree-supports?" field to the "bootloader" record. About that, any reason not to have this "device-tree-supports?" field in the record? The record is about how to install the bootloader while is about its configuration. So maybe it would be a better fit? > OK, I removed the test from recent patch. Good. Let me know what you think about the proposal and we should be good to proceed. Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 29 14:18:02 2022 Received: (at 57070) by debbugs.gnu.org; 29 Aug 2022 18:18:02 +0000 Received: from localhost ([127.0.0.1]:33775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSjKj-00023D-Tl for submit@debbugs.gnu.org; Mon, 29 Aug 2022 14:18:02 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33677) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSjKi-00022g-54 for 57070@debbugs.gnu.org; Mon, 29 Aug 2022 14:18:00 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 168F05C00F2; Mon, 29 Aug 2022 14:17:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 29 Aug 2022 14:17:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantherx.org; h= cc:cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1661797075; x=1661883475; bh=5GdSEFjI/M 96CLstyrDmveYGM0TQc6l/UWjKuSQtcZA=; b=XsEzUjf4SfvSarPzLMgGQqbQxh 2JA94ECW97QnRU6W2wjOLIl05fFGSklhMXBqCmM/pTCIx8fJ7Pwg0yqVwNIXfWKZ B6vf9foPo/ItT9TG2JNaxcZeu93Y+nPSXp3Ka1F2SLGiRmcahOKB/V9L4cztU8dH LWxvsBRwYoprCcBfn2aylF6Bus7H4CUnUxbFqoLDTMxLvnbgU8/mcB9+WPAPTMPI JVho8UMW/2oRVCas3Sdtu1SO2yLGWZf3c+Sb6pAHs8hvQtrixb3crFS66ISAExDi 5S5F5M4jFAo9PX7UO3dVGr1gIRzruJMXs46HXaNjJBQs5zts/rzMp4CnpogQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1661797075; x=1661883475; bh=5GdSEFjI/M96CLstyrDmveYGM0TQ c6l/UWjKuSQtcZA=; b=AOBaodSHl8SO10chQ7wl+Rkmg9oZRR2WNYsvMKQpfQDj dK/Vrf5y7+VXTzupb76nQYUxHzBPTIfUIXuQhuIWBaLE04MKGJfUSBij179gYJRS ojR+aiWJ8KvRwHP/+6ErKJb+h6E+UaYJeIkaQ4XjIj6gx+Tyc6aBGGKX/787OXvt T2UkPvRZxcSAAbDiltuZVcqaoEAEi7SH5PgjLsu2/07ZtPOVd9FmIAXGHYqUj0vL jJT1pkM2C7Wo3L8UOcyra9Umlxo34Z1YCy7AQrUdWETDUB6kFnSM98AOEc/031UP 2y5XKumXO7YZO71g6Ls7bvS2QqIVnBfTEU/DaVMoZQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdekuddguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfgjfhhoofggtgesmhdtreerredtvdenucfhrhhomheptfgv iigrucetlhhiiigruggvhhcuofgrjhguuceorhdrmhgrjhgusehprghnthhhvghrgidroh hrgheqnecuggftrfgrthhtvghrnhepvefhvdejueekhedthfelkeejjeduveeugfehhfel teduieduvefhgffhjefgfeeknecuffhomhgrihhnpehprghnthhhvghrgidrohhrghenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrrdhmrghj ugesphgrnhhthhgvrhigrdhorhhg X-ME-Proxy: Feedback-ID: i063944dc:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Aug 2022 14:17:53 -0400 (EDT) Date: Mon, 29 Aug 2022 22:47:44 +0430 From: Reza Alizadeh Majd To: Mathieu Othacehe Subject: Re: bug#57070: [PATCH] bootloader: extlinux: support for optional FDTDIR Message-ID: <20220829224744.3801f469@pantherx.org> In-Reply-To: <87ilmcpdv3.fsf@gnu.org> References: <20220809103044.27964-1-r.majd@pantherx.org> <20220816224004.1744c1d5@pantherx.org> <87lerc5iq6.fsf_-_@gnu.org> <20220828124938.0289bd68@pantherx.org> <87ilmcpdv3.fsf@gnu.org> Organization: PantherX X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/e/O5iL+lbJQHQAPPMkGHYm+" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --MP_/e/O5iL+lbJQHQAPPMkGHYm+ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Mathieu, On Sun, 28 Aug 2022 17:49:36 +0200 Mathieu Othacehe wrote: > >About that, any reason not to have this "device-tree-supports?" field >in the record? > >The record is about how to install the bootloader while > is about its configuration. So maybe it >would be a better fit? > I wanted to limit my patch to affect as minimum sections as possible. so I added the field to the record. I'm agree with your proposal, since the removal of FDTDIR is more of a configuration for an existing bootloader. I moved this option to the and submit a new patch. it would be great to have your feedback whenever you had time. Regards, Reza -- Reza Alizadeh Majd PantherX Team https://pantherx.org --MP_/e/O5iL+lbJQHQAPPMkGHYm+ Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-bootloader-extlinux-support-for-optional-FDTDIR.patch =46rom a7e3e9afe22274397634e6dbe4caa9766adfb7a9 Mon Sep 17 00:00:00 2001 From: Reza Alizadeh Majd Date: Sun, 28 Aug 2022 12:34:46 +0430 Subject: [PATCH] bootloader: extlinux: support for optional FDTDIR There are situations that u-boot doesn't have to load from the device tree. some provide the device tree using a vendor bootloader (like what raspberry= -pi does) or with an external bootloader that chainloads the u-boot (what Asahi does for m1n1 bootloader). Unfortunately we couldn't find any reliable document to enforce u-boot to p= ass the device tree via `extlinux.conf`, however during our tests, we found that removing the `FDTDIR` line from the `extlinux.conf` tend us to do so. There is also no reliable way to guess if u-boot bootloader should load dev= ice tree or not on a specific hardware. in addition, there are hardware that can be booted with both firmware device tree on some kernels and with special device tree on other (modified) kernels. the following changes provided to define an optional parameter in record, called which by default is set to #t to keep the current behavior unchanged. if this paramt= er is set to #f, the FDTDIR line will be discarded from the and u-boot doesn't load the device tree automatically. * gnu/bootloader.scm ()[device-tree-support?]: ne= w field. * gnu/bootloader/extlinux.scm (extlinux-configuration-file): add FDTDIR line based on field of . * doc/guix.texi (Bootloader Configuration)[device-tree-support?]: Add documentation for the new field. --- doc/guix.texi | 7 ++++++ gnu/bootloader.scm | 50 ++++++++++++++++++++----------------- gnu/bootloader/extlinux.scm | 12 +++++++-- 3 files changed, 44 insertions(+), 25 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 023b48ae35..8171481040 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -36960,6 +36960,13 @@ corresponds to COM1 (@pxref{Serial terminal,,, gru= b,GNU GRUB manual}). The speed of the serial interface, as an integer. For GRUB, the default value is chosen at run-time; currently GRUB chooses 9600@tie{}bps (@pxref{Serial terminal,,, grub,GNU GRUB manual}). + +@item @code{device-tree-support} (default: @code{#t}) +There are situations when @code{u-boot} shouldn't load the device tree from +the file system. because it is either unnecessary for the platform being u= sed +or has already been loaded into RAM earlier in the boot process. in such c= ases +you can set this field to @code{#f}. setting this flag to @code{#f} removes +the @code{FDTDIR} line from the @file{/boot/extlinux/extlinux.conf}. @end table =20 @end deftp diff --git a/gnu/bootloader.scm b/gnu/bootloader.scm index 70e1836179..335133d224 100644 --- a/gnu/bootloader.scm +++ b/gnu/bootloader.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2017 Leo Famulari ;;; Copyright =C2=A9 2019, 2021 Ludovic Court=C3=A8s ;;; Copyright =C2=A9 2020 Jan (janneke) Nieuwenhuizen +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd ;;; ;;; This file is part of GNU Guix. ;;; @@ -69,6 +70,7 @@ (define-module (gnu bootloader) bootloader-configuration-terminal-inputs bootloader-configuration-serial-unit bootloader-configuration-serial-speed + bootloader-configuration-device-tree-support? =20 %bootloaders lookup-bootloader-by-name @@ -193,29 +195,31 @@ (define-with-syntax-properties (warn-target-field-dep= recation (define-record-type* bootloader-configuration make-bootloader-configuration bootloader-configuration? - (bootloader bootloader-configuration-bootloader) ; - (targets %bootloader-configuration-targets ;list of strings - (default #f)) - (target %bootloader-configuration-target ;deprecated - (default #f) (sanitize warn-target-field-deprecation= )) - (menu-entries bootloader-configuration-menu-entries ;list of - (default '())) - (default-entry bootloader-configuration-default-entry ;integer - (default 0)) - (timeout bootloader-configuration-timeout ;seconds as integer - (default 5)) - (keyboard-layout bootloader-configuration-keyboard-layout ; | #f - (default #f)) - (theme bootloader-configuration-theme ;bootloader-specific = theme - (default #f)) - (terminal-outputs bootloader-configuration-terminal-outputs ;list of s= ymbols - (default '(gfxterm))) - (terminal-inputs bootloader-configuration-terminal-inputs ;list of sy= mbols - (default '())) - (serial-unit bootloader-configuration-serial-unit ;integer | #f - (default #f)) - (serial-speed bootloader-configuration-serial-speed ;integer | #f - (default #f))) + (bootloader bootloader-configuration-bootloader) ; + (targets %bootloader-configuration-targets ;list of stri= ngs + (default #f)) + (target %bootloader-configuration-target ;deprecated + (default #f) (sanitize warn-target-field-deprecati= on)) + (menu-entries bootloader-configuration-menu-entries ;list of + (default '())) + (default-entry bootloader-configuration-default-entry ;integer + (default 0)) + (timeout bootloader-configuration-timeout ;seconds as integ= er + (default 5)) + (keyboard-layout bootloader-configuration-keyboard-layout ; | #f + (default #f)) + (theme bootloader-configuration-theme ;bootloader-specifi= c theme + (default #f)) + (terminal-outputs bootloader-configuration-terminal-outputs ;list of= symbols + (default '(gfxterm))) + (terminal-inputs bootloader-configuration-terminal-inputs ;list of = symbols + (default '())) + (serial-unit bootloader-configuration-serial-unit ;integer | #f + (default #f)) + (serial-speed bootloader-configuration-serial-speed ;integer | #f + (default #f)) + (device-tree-support? bootloader-configuration-device-tree-support? + (default #t))) =20 (define-deprecated (bootloader-configuration-target config) bootloader-configuration-targets diff --git a/gnu/bootloader/extlinux.scm b/gnu/bootloader/extlinux.scm index 6b5ff298e7..d9b6d8bf8a 100644 --- a/gnu/bootloader/extlinux.scm +++ b/gnu/bootloader/extlinux.scm @@ -1,6 +1,7 @@ ;;; GNU Guix --- Functional package management for GNU ;;; Copyright =C2=A9 2017 David Craven ;;; Copyright =C2=A9 2017 Mathieu Othacehe +;;; Copyright =C2=A9 2022 Reza Alizadeh Majd ;;; ;;; This file is part of GNU Guix. ;;; @@ -38,6 +39,9 @@ (define* (extlinux-configuration-file config entries (define all-entries (append entries (bootloader-configuration-menu-entries config))) =20 + (define with-fdtdir? + (bootloader-configuration-device-tree-support? config)) + (define (menu-entry->gexp entry) (let ((label (menu-entry-label entry)) (kernel (menu-entry-linux entry)) @@ -46,12 +50,16 @@ (define (menu-entry->gexp entry) #~(format port "LABEL ~a MENU LABEL ~a KERNEL ~a - FDTDIR ~a/lib/dtbs + ~a INITRD ~a APPEND ~a ~%" #$label #$label - #$kernel (dirname #$kernel) #$initrd + #$kernel + (if #$with-fdtdir? + (string-append "FDTDIR " (dirname #$kernel) "/lib/dtbs= ") + "") + #$initrd (string-join (list #$@kernel-arguments))))) =20 (define builder --=20 2.37.1 --MP_/e/O5iL+lbJQHQAPPMkGHYm+-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 30 02:52:44 2022 Received: (at 57070) by debbugs.gnu.org; 30 Aug 2022 06:52:44 +0000 Received: from localhost ([127.0.0.1]:34535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSv75-0004EP-OI for submit@debbugs.gnu.org; Tue, 30 Aug 2022 02:52:44 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39258) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSv73-0004ED-Tq for 57070@debbugs.gnu.org; Tue, 30 Aug 2022 02:52:42 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49262) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSv6x-0005Qf-Co; Tue, 30 Aug 2022 02:52:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=vyNbqhN1OObvA1L/lxNiu+3KnmBuPNYRmbJRbtJKTgA=; b=iPuk5dRa4lzXjXkUYu5S k7jyWuHZ4qgpYtNmQvHUG8aePcXZtta8xcgGU0LM+kbKKBh8ZKOU7rekejprb6cFsxDEnPdsNntZt k4mBSy/eIeUrJRHSh9B7fIQnWD1NuYVWw/xRcdmbwVKapND5FdzlXwsmz5mKa8fXc2d+iVTAbH8mT HcEKvE8ISCb2kzD5VW88K2tFeMFbjehBjBBczwEXiaVOLmjEM3C3rsnGfCtt5Cvn4k8P2cPAmo0x/ rXRHGvPm96JkXENao9teVQ7EDuRD/aPKZADBJIS2nnFXzCO9gSewRUvwIJwTqj7PpYWi/lKfIURRN mzk75ILoTPhG8A==; Received: from [176.32.26.22] (port=34995 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSv6w-0005lA-LF; Tue, 30 Aug 2022 02:52:35 -0400 From: Mathieu Othacehe To: Pavel Shlyak Subject: Re: bug#57070: [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809145730.435ef8d0@pantherx.org> Date: Tue, 30 Aug 2022 08:52:31 +0200 In-Reply-To: (Pavel Shlyak's message of "Thu, 25 Aug 2022 22:16:48 +0300") Message-ID: <877d2qrzo0.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57070 Cc: 57070@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Pavel, > In other words, if there=E2=80=99s no fdtdir, uboot just passes the fdt_a= ddr to bootm > command, that means it passes the pointer to device tree loaded by firmwa= re > (or previous bootloader) to the kernel. If fdt_addr is also missing, it p= asses > fdtcontroladdr to the kernel. If all of the previous scenarios don=E2=80= =99t work, it > passes no FDT and kernel boots without device tree, that is absolutely no= rmal > on some devices, check x86. Thanks for the clarification, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 30 02:53:39 2022 Received: (at 57070-done) by debbugs.gnu.org; 30 Aug 2022 06:53:39 +0000 Received: from localhost ([127.0.0.1]:34540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSv7z-0004G0-4b for submit@debbugs.gnu.org; Tue, 30 Aug 2022 02:53:39 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33132) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oSv7x-0004Fi-VG for 57070-done@debbugs.gnu.org; Tue, 30 Aug 2022 02:53:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSv7s-0005Zm-Gc; Tue, 30 Aug 2022 02:53:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=902VTnRkxOoOfsJS7+n7Xqc/uj+PpE/QfbU2akRibA8=; b=r3l6dw/a5z+A2CvczXHp 6Fe6dExevCfeXmCOuPQlarHPidOm7snGHzEBMe5vn/SikICbACfZeuXigiW5L7hoSuGgsGuTRnu+u DImNrMub4GbJBzlIF0oiQF7nWaK1r29FZSXq8E9mlhzprsmxlBTKEiD+kbniDN4E6VwyuTMrWGIT9 85UydqLdyWLwy6AzE4lMpYAYZjpzDvMm8IOiXhDlUcycuSZJTXd0uSFXPui+XKUz1NtlmJZE+P+8M 8ZbidG+Rl4ZUZsKYkhDP6tFtcvpI8Qt+ENrGSX8INd9XIi9+HrrwF8JVic0dnPHr+1vuX2Ou+iqtH B7OH+JteBP3W7A==; Received: from [176.32.26.22] (port=35279 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oSv7r-0005oy-CW; Tue, 30 Aug 2022 02:53:31 -0400 From: Mathieu Othacehe To: Reza Alizadeh Majd Subject: Re: bug#57070: [PATCH] bootloader: extlinux: support for optional FDTDIR References: <20220809103044.27964-1-r.majd@pantherx.org> <20220816224004.1744c1d5@pantherx.org> <87lerc5iq6.fsf_-_@gnu.org> <20220828124938.0289bd68@pantherx.org> <87ilmcpdv3.fsf@gnu.org> <20220829224744.3801f469@pantherx.org> Date: Tue, 30 Aug 2022 08:53:28 +0200 In-Reply-To: <20220829224744.3801f469@pantherx.org> (Reza Alizadeh Majd's message of "Mon, 29 Aug 2022 22:47:44 +0430") Message-ID: <8735derzmf.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57070-done Cc: 57070-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Reza, > * gnu/bootloader.scm ()[device-tree-support?]: new field. > * gnu/bootloader/extlinux.scm (extlinux-configuration-file): add FDTDIR line > based on field of . > * doc/guix.texi (Bootloader Configuration)[device-tree-support?]: Add > documentation for the new field. I pushed this patch with a few modifications. Thanks, Mathieu From unknown Tue Aug 19 14:24:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Sep 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator