From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 12:39:09 2022 Received: (at submit) by debbugs.gnu.org; 8 Aug 2022 16:39:09 +0000 Received: from localhost ([127.0.0.1]:41834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL5mW-0007Wk-VB for submit@debbugs.gnu.org; Mon, 08 Aug 2022 12:39:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:33060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL5mV-0007Wd-91 for submit@debbugs.gnu.org; Mon, 08 Aug 2022 12:39:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oL5mU-0005Eg-Qv for guix-patches@gnu.org; Mon, 08 Aug 2022 12:39:07 -0400 Received: from knopi.disroot.org ([178.21.23.139]:58520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oL5mS-0006uI-Pl for guix-patches@gnu.org; Mon, 08 Aug 2022 12:39:06 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 620D74578A; Mon, 8 Aug 2022 18:39:01 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id jx4k8iqDP5d0; Mon, 8 Aug 2022 18:38:59 +0200 (CEST) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659976533; bh=1mylBz4hXzvPHBuJWI7Twk1UGDB8EsVpXQU0ypamqhU=; h=From:To:Cc:Subject:Date; b=Vx7KOoPNQVFxzhAbmE6Hoz8U+HMyoLyXpfHIWvpcj2NEKQv6lCeKZIhUvT8Q8daLM LxzocOJMfOjUgfdtLRv2m9LWA5dk8aSaS8AFdvSs0aiLBZDSxySGWNZa8CIR+qDtU+ i4evJUrjcAKIL7Ls/VbDqhpCq5sz6KzHd6FdYS+HUGEOkVrOnnQCbK3z7fqRT+E8VP XycFQGH/VQ7/RyL5TixNzAl7AGIAOi4eo6mD3qgcxmyE3+OZTQqHnrIeXArDXgTB3B SRr8QoqCzsxZBUJPQL6Iw76hnNBVLyfSYPyvBCnnioz/BHdsxHDrfueAD+xWrf8oOK vvLWayV8B2Aiw== To: guix-patches@gnu.org Subject: [PATCH] gnu: pcc: Fix build. Date: Mon, 8 Aug 2022 17:35:29 +0100 Message-Id: <20220808163529.12354-1-paren@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: "\(" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/c.scm (pcc)[arguments]: Use gexps. <#:phases>{fix-multiple-definitions}: New phase. [native-inputs]: Adjust formatting. --- gnu/packages/c.scm | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm index 1630a40d17..113a331070 100644 --- a/gnu/packages/c.scm +++ b/gnu/packages/c.scm @@ -16,6 +16,7 @@ ;;; Copyright © 2022 (unmatched parenthesis ;;; Copyright © 2022 Artyom V. Poptsov ;;; Copyright © 2022 Ekaitz Zarraga +;;; Copyright © 2022 ( ;;; ;;; This file is part of GNU Guix. ;;; @@ -185,12 +186,20 @@ (define-public pcc "1p34w496095mi0473f815w6wbi57zxil106mg7pj6sg6gzpjcgww")))) (build-system gnu-build-system) (arguments - `(#:phases - (modify-phases %standard-phases - (replace 'check - (lambda _ (invoke "make" "-C" "cc/cpp" "test") #t))))) - (native-inputs - (list bison flex)) + (list #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-multiple-definitions + (lambda _ + ;; Certain variables are defined multiple times. This + ;; upsets the linker and causes a build failure. + (substitute* "cc/ccom/pass1.h" + (("FLT flt_zero;") "extern FLT flt_zero;")) + (substitute* (list "cc/ccom/scan.l" "cc/cxxcom/scan.l") + (("lineno, ") "")))) + (replace 'check + (lambda _ + (invoke "make" "-C" "cc/cpp" "test")))))) + (native-inputs (list bison flex)) (synopsis "Portable C compiler") (description "PCC is a portable C compiler. The project goal is to write a C99 -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 14:33:15 2022 Received: (at 57060) by debbugs.gnu.org; 8 Aug 2022 18:33:15 +0000 Received: from localhost ([127.0.0.1]:41909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL7Yx-00043w-IH for submit@debbugs.gnu.org; Mon, 08 Aug 2022 14:33:15 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:53702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL7Yw-00043p-Ni for 57060@debbugs.gnu.org; Mon, 08 Aug 2022 14:33:15 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by michel.telenet-ops.be with bizsmtp id 56ZB2800J20ykKC066ZB5c; Mon, 08 Aug 2022 20:33:13 +0200 Message-ID: Date: Mon, 8 Aug 2022 20:33:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [bug#57060] [PATCH] gnu: pcc: Fix build. Content-Language: en-US To: "(" , 57060@debbugs.gnu.org References: <20220808163529.12354-1-paren@disroot.org> From: Maxime Devos In-Reply-To: <20220808163529.12354-1-paren@disroot.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------SasUT0CjS95pLLcanAR2a219" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1659983593; bh=gi8R5wkp56LrEnIkQHgtqgnwCAy/G/soqOQDZMxBN+Y=; h=Date:Subject:To:References:From:In-Reply-To; b=nBpV7MO5HYqnwXYE46c0CddnZNniKj3LRN3NjL6xJtLtze1ab7zqK7NjDf98RW5mI Yrq4JzWPxwm5PdL3DdrGtDNi87VTSI9L7UzLgLGSrM88LFXfOED6Te70rp7cpDOxPC uRYT4htbVkHXtPFxGB2+nqe55pa+qjG7oGrWEVciWg/35ZGxAf5mijnzfWOcKhXjyd TBuksQn99aw2jK06tF420WXc+G7tDO1IeULgUphCz36bykfQr7tpey+Xkao4AbrpRO Ck1FmvWDg36TbCNNqOLxCPiWyacHb8hdX3KlxpmIu0a0z/ErOkYc/m5z4JIQOrjTeU NQr1cUBZVUXdA== X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57060 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------SasUT0CjS95pLLcanAR2a219 Content-Type: multipart/mixed; boundary="------------u22a7sueKAvnXGqlZe680E0A"; protected-headers="v1" From: Maxime Devos To: "(" , 57060@debbugs.gnu.org Message-ID: Subject: Re: [bug#57060] [PATCH] gnu: pcc: Fix build. References: <20220808163529.12354-1-paren@disroot.org> In-Reply-To: <20220808163529.12354-1-paren@disroot.org> --------------u22a7sueKAvnXGqlZe680E0A Content-Type: multipart/mixed; boundary="------------Cs0UPoBwn7IPZkoacoTf6cET" --------------Cs0UPoBwn7IPZkoacoTf6cET Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQpPbiAwOC0wOC0yMDIyIDE4OjM1LCAoIHZpYSBHdWl4LXBhdGNoZXMgdmlhIHdyb3RlOg0K PiArICAgICAgICAgICAgICAgICAobGFtYmRhIF8NCj4gKyAgICAgICAgICAgICAgICAgICA7 OyBDZXJ0YWluIHZhcmlhYmxlcyBhcmUgZGVmaW5lZCBtdWx0aXBsZSB0aW1lcy4gVGhpcw0K PiArICAgICAgICAgICAgICAgICAgIDs7IHVwc2V0cyB0aGUgbGlua2VyIGFuZCBjYXVzZXMg YSBidWlsZCBmYWlsdXJlLg0KPiArICAgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAi Y2MvY2NvbS9wYXNzMS5oIg0KPiArICAgICAgICAgICAgICAgICAgICAgKCgiRkxUIGZsdF96 ZXJvOyIpICJleHRlcm4gRkxUIGZsdF96ZXJvOyIpKQ0KPiArICAgICAgICAgICAgICAgICAg IChzdWJzdGl0dXRlKiAobGlzdCAiY2MvY2NvbS9zY2FuLmwiICJjYy9jeHhjb20vc2Nhbi5s IikNCj4gKyAgICAgICAgICAgICAgICAgICAgICgoImxpbmVubywgIikgIiIpKSkpDQoNClRo aXMgbG9va3MgbGlrZSBzb21ldGhpbmcgdXBzdHJlYW0gbmVlZHMgdG8ga25vdyBhYm91dC4N Cg0KPiArICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2NoZWNrDQo+ICsgICAgICAgICAgICAg ICAgIChsYW1iZGEgXw0KPiArICAgICAgICAgICAgICAgICAgIChpbnZva2UgIm1ha2UiICIt QyIgImNjL2NwcCIgInRlc3QiKSkpKSkpDQood2hlbiB0ZXN0cz8gLi4uKSwgaW4gYSBmb2xs b3ctdXAgb3IgcHJlY2VkaW5nIHBhdGNoICh0IHdhcyBwcmVzZW50IGluIA0KdGhlIG9sZCBj b2RlKSwgZm9yIC0td2l0aG91dC10ZXN0cy4NCg0KR3JlZXRpbmdzLA0KTWF4aW1lLg0KDQo= --------------Cs0UPoBwn7IPZkoacoTf6cET Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------Cs0UPoBwn7IPZkoacoTf6cET-- --------------u22a7sueKAvnXGqlZe680E0A-- --------------SasUT0CjS95pLLcanAR2a219 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYvFW5wUDAAAAAAAKCRBJ4+4iGRcl7j69 AQCZPKFN3cB2UY5tAEUqjm4jYL9l5Hx3ZZrosRBj3LdHVQD/b0wIHuBMtMXGKqViq8f4+pV3B6wH I+ykcfPJf41elAk= =ja6t -----END PGP SIGNATURE----- --------------SasUT0CjS95pLLcanAR2a219-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 15:10:42 2022 Received: (at 57060) by debbugs.gnu.org; 8 Aug 2022 19:10:42 +0000 Received: from localhost ([127.0.0.1]:42016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL89C-0005Ae-3P for submit@debbugs.gnu.org; Mon, 08 Aug 2022 15:10:42 -0400 Received: from knopi.disroot.org ([178.21.23.139]:52590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL899-0005AU-Iw for 57060@debbugs.gnu.org; Mon, 08 Aug 2022 15:10:40 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0BBEE45DB4; Mon, 8 Aug 2022 21:10:38 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id oAR8rzxpGkc4; Mon, 8 Aug 2022 21:10:37 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659984794; bh=FCkrFEtTLPOsVwahGdOCnjJZqbJ6DCOQJ7mnXhy9/iE=; h=Date:Subject:From:To:References:In-Reply-To; b=AJJ4Lzttpdenr0xR4rwB0CNC8z6O/FUVgwjlZlDxouxYXNrZZ2zN8CeCVCnag/51j 9DJ95wcpG0JekC/9J5ICYbCN6pe/GpmOWn46gFNb2usBqA9KJOQHPhpLKSuhW49lT9 wGhAmszfpbW5nCq8GbU7CR7NjiHmobWJiJOfDJylNyQFyqHEwVE2VpW1+/xMonfBwX XFm5JKOjhmtpJ+WxjRoy5AG7HF4MY6LXH+QxEhhYdjMNgraEq0Oj49/cSZInWntySR o/EZVV9HOaeWXvDv61hP6RphIhb7sl0vK3zvdh0CdEcpeKq8dZFS0s4dCqFEPNW34E 7SYCaWOAQJ8HA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Mon, 08 Aug 2022 19:53:13 +0100 Message-Id: Subject: Re: [bug#57060] [PATCH] gnu: pcc: Fix build. From: "(" To: "Maxime Devos" , <57060@debbugs.gnu.org> References: <20220808163529.12354-1-paren@disroot.org> In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57060 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Mon Aug 8, 2022 at 7:33 PM BST, Maxime Devos wrote: > This looks like something upstream needs to know about. I'm not sure upstream is particularly active. Also, the home-page is down, so I'm not sure how to contact them :) > (when tests? ...), in a follow-up or preceding patch (t was present in=20 > the old code), for --without-tests. Good point! -- ( From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 15:12:24 2022 Received: (at 57060) by debbugs.gnu.org; 8 Aug 2022 19:12:24 +0000 Received: from localhost ([127.0.0.1]:42022 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL8Aq-0005Dp-Fm for submit@debbugs.gnu.org; Mon, 08 Aug 2022 15:12:24 -0400 Received: from knopi.disroot.org ([178.21.23.139]:37764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL8Ao-0005Dh-R7 for 57060@debbugs.gnu.org; Mon, 08 Aug 2022 15:12:23 -0400 Received: by disroot.org (Postfix, from userid 107) id 51CCA45F54; Mon, 8 Aug 2022 21:08:45 +0200 (CEST) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659985725; bh=fY9X4yBxgIRO+eF8R2676kGbxRCW+NtfUfkuute+3zE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=iSMPNArhheldU4WjoQb2xl7YOJ5QUdWDTfwcOn7Q7ApRn8aNvlkZS14KcpPFEu9Kg dVwwUItGJbRQpaURAr5BVytoY9qWnO+XXrfroyBFud1n+DBfmPSokXXFXa1di9DtEc slIS6ewtDLs8bWzMxHJs3YNzEWMRpczWTk1mz043Gr9zKVHUlcxmK3+ANqLnMOZh9o yXBZzLaohb26eDgWADzxg/tRD+9IA7is2O9LzznHXUDIBOe+ilFL80vDuPF+3RUoTU yLkst4tyaghnOPZBNy3WnGxiSkghMM9UNdE4kilYIfQqlqKqSMVn0j+L8oHztNyZWB pKY+0lKgzCR+A== To: 57060@debbugs.gnu.org Subject: [PATCH v2 2/2] gnu: pcc: Respect --without-tests. Date: Mon, 8 Aug 2022 20:08:39 +0100 Message-Id: <20220808190839.20727-2-paren@disroot.org> In-Reply-To: <20220808190839.20727-1-paren@disroot.org> References: <20220808190839.20727-1-paren@disroot.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57060 Cc: "\(" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/c.scm (pcc)[arguments]<#:phases>{check}: Respect the `tests?` argument. --- gnu/packages/c.scm | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm index 113a331070..39f048e993 100644 --- a/gnu/packages/c.scm +++ b/gnu/packages/c.scm @@ -197,8 +197,9 @@ (define-public pcc (substitute* (list "cc/ccom/scan.l" "cc/cxxcom/scan.l") (("lineno, ") "")))) (replace 'check - (lambda _ - (invoke "make" "-C" "cc/cpp" "test")))))) + (lambda* (#:key tests? #:allow-other-keys) + (when tests? + (invoke "make" "-C" "cc/cpp" "test"))))))) (native-inputs (list bison flex)) (synopsis "Portable C compiler") (description -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 15:17:45 2022 Received: (at 57060) by debbugs.gnu.org; 8 Aug 2022 19:17:45 +0000 Received: from localhost ([127.0.0.1]:42028 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL8G1-0005MZ-6T for submit@debbugs.gnu.org; Mon, 08 Aug 2022 15:17:45 -0400 Received: from knopi.disroot.org ([178.21.23.139]:57932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oL8Fz-0005MR-GL for 57060@debbugs.gnu.org; Mon, 08 Aug 2022 15:17:44 -0400 Received: by disroot.org (Postfix, from userid 107) id D8BBB45E83; Mon, 8 Aug 2022 21:08:44 +0200 (CEST) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659985724; bh=1mylBz4hXzvPHBuJWI7Twk1UGDB8EsVpXQU0ypamqhU=; h=From:To:Cc:Subject:Date; b=CTnZdx1s98Wm3z9UYcfTx3MhjExw8T9BTmTWKy/sK/y4AcDJs/cL4O/HPLEUhkX/y cwmigv0EfIh5tChx/pdXLE+jJ6D0laJNw2uODHvwb/BwSBYnqXsBWUMrLA3seH4ZYX dp03QC+82wc6Rio4SIXZ9Xttndufotepp+qzonER4D4OGIaP1OLqN5axHMkfp5/3ta rv7w7mAVhshbPZKz+uibNnxjGdlnC8t7a6gdusCHLUO5ziK/Cgp9+H1ePWMhE3af3t EFXKysmTANYx9D+TX+2DY51GmWvCdcu2Q+bq4yJGs9jXKh/eGBJlsVZDdlaaPz8GDS l9IqRLPHmQfGg== To: 57060@debbugs.gnu.org Subject: [PATCH v2 1/2] gnu: pcc: Fix build. Date: Mon, 8 Aug 2022 20:08:38 +0100 Message-Id: <20220808190839.20727-1-paren@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57060 Cc: "\(" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/c.scm (pcc)[arguments]: Use gexps. <#:phases>{fix-multiple-definitions}: New phase. [native-inputs]: Adjust formatting. --- gnu/packages/c.scm | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/gnu/packages/c.scm b/gnu/packages/c.scm index 1630a40d17..113a331070 100644 --- a/gnu/packages/c.scm +++ b/gnu/packages/c.scm @@ -16,6 +16,7 @@ ;;; Copyright © 2022 (unmatched parenthesis ;;; Copyright © 2022 Artyom V. Poptsov ;;; Copyright © 2022 Ekaitz Zarraga +;;; Copyright © 2022 ( ;;; ;;; This file is part of GNU Guix. ;;; @@ -185,12 +186,20 @@ (define-public pcc "1p34w496095mi0473f815w6wbi57zxil106mg7pj6sg6gzpjcgww")))) (build-system gnu-build-system) (arguments - `(#:phases - (modify-phases %standard-phases - (replace 'check - (lambda _ (invoke "make" "-C" "cc/cpp" "test") #t))))) - (native-inputs - (list bison flex)) + (list #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-multiple-definitions + (lambda _ + ;; Certain variables are defined multiple times. This + ;; upsets the linker and causes a build failure. + (substitute* "cc/ccom/pass1.h" + (("FLT flt_zero;") "extern FLT flt_zero;")) + (substitute* (list "cc/ccom/scan.l" "cc/cxxcom/scan.l") + (("lineno, ") "")))) + (replace 'check + (lambda _ + (invoke "make" "-C" "cc/cpp" "test")))))) + (native-inputs (list bison flex)) (synopsis "Portable C compiler") (description "PCC is a portable C compiler. The project goal is to write a C99 -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 11 04:29:22 2022 Received: (at 57060-done) by debbugs.gnu.org; 11 Aug 2022 08:29:22 +0000 Received: from localhost ([127.0.0.1]:51438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM3ZC-0001xi-2p for submit@debbugs.gnu.org; Thu, 11 Aug 2022 04:29:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oM3Z8-0001xR-8c for 57060-done@debbugs.gnu.org; Thu, 11 Aug 2022 04:29:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM3Z1-0002yO-Ul; Thu, 11 Aug 2022 04:29:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=jMeu4RCUqmOd8JNYjq6WqN+FAX7Cy0Y9beaVYudaTlI=; b=UyaNBKFjvRZq0rJEmuq9 dh4hXh1gc8zqQF/JKMicWD7pVttGts0LMitrmWqWMI35rAeaIF4NUIxjvTLrNLCIFmgMfzTzlVLq/ /Yvn7Fv7U9dyPeZ+rcPIG4rNjEewrF8wSnOp5prPwn+KnV/ggb4yLtndb4iD9bO9J+vBEBtrMyzRw rPhNUpwl5UU9cD2FFFVx/5BPG8zItfSyWFnTd14DJJCJZUZcMiyTNVQUth4KPZ5T0xrDlkvVMGkwa IYCtCFX2vYgw0T3na3TSDBeL86dsnIIrZW/qlv/qBBaqzMPGo15qkrNV9q8GN0kQr0Gl2cxZfiFur JBdgdLWFcH2VSg==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2775.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2775]:47540 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oM3Z1-0000mv-Bl; Thu, 11 Aug 2022 04:29:11 -0400 From: Mathieu Othacehe To: "(" Subject: Re: bug#57060: [PATCH] gnu: pcc: Fix build. References: <20220808190839.20727-1-paren@disroot.org> <20220808190839.20727-2-paren@disroot.org> Date: Thu, 11 Aug 2022 10:29:08 +0200 In-Reply-To: <20220808190839.20727-2-paren@disroot.org> (paren@disroot.org's message of "Mon, 8 Aug 2022 20:08:39 +0100") Message-ID: <874jyj420b.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57060-done Cc: Maxime Devos , 57060-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > * gnu/packages/c.scm (pcc)[arguments]<#:phases>{check}: Respect the > `tests?` argument. Pushed both patches, thanks Maxime for reviewing. Mathieu From unknown Sat Jun 21 05:06:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Sep 2022 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator