GNU bug report logs - #57056
[PATCH] Update python-lsp-server

Previous Next

Full log

Message #20 received at 57056 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Nicolas Graves <ngraves <at> ngraves.fr>
Cc: 57056 <at> debbugs.gnu.org
Subject: Re: bug#57056: [PATCH] Update python-lsp-server
Date: Fri, 12 Aug 2022 11:03:35 +0200

Hello,

> -       (modify-phases %standard-phases
> -         (add-before 'check 'set-HOME
> -           (lambda _ (setenv "HOME" "/tmp")))

You need to document it in the commit message, this way:

[arguments]{set-HOME}: Remove this phase because...
{check}: Do not replace it as test_pyqt_completion is not longer
failing.

or something similar.
>      (propagated-inputs
>       (list python-autopep8
>             python-pydocstyle
>             python-flake8
> -           python-future
>             python-jedi
>             python-lsp-jsonrpc
>             python-pluggy
>             python-pycodestyle
>             python-pyflakes
>             python-rope
> +           python-setuptools
>             python-ujson
>             python-yapf))
>      (native-inputs
>       (list python-coverage
>             python-flaky
>             python-matplotlib
> -           python-mock
>             python-numpy
>             python-pandas
>             python-pylint
>             python-pytest
>             python-pytest-cov
> -           python-versioneer))
> +           python-whatthepatch))

Ditto, with something like

[propagated-inputs]: Remove python-future and add python-setuptools.
[native-inputs]: Remove python-mock, python-versioneer and add
python-whatthepatch.

Could you please send a v2?

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.