Subject: Re: [PATCH v2 02/13] gnu: stex: Fix read-only gifs and math directories.

From: Liliana Marie Prikler <[email-masked]>
Date: Thu, 11 Aug 2022 13:13:47 +0200

Am Donnerstag, dem 11.08.2022 um 07:08 -0400 schrieb Philip McGrath:
> Excplicitly set the user write bit when initializing the gifs or math
> directories from the skeletons installed in the store. See also
> upstream
> discussion at <https://github.com/dybvig/stex/pull/6>. This problem
> would be exposed by the upcoming changes to Racket's build system.
> 
> * gnu/packages/patches/stex-copy-from-immutable-store.patch: New
> patch.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/chez.scm (stex-bootstrap)[patches]: Use it.
> [version]: Increment revision to 1.2.2-3.afa6075.
> ---
>  gnu/local.mk                                  |  1 +
>  gnu/packages/chez.scm                         |  5 ++-
>  .../stex-copy-from-immutable-store.patch      | 41
> +++++++++++++++++++
>  3 files changed, 46 insertions(+), 1 deletion(-)
>  create mode 100644 gnu/packages/patches/stex-copy-from-immutable-
> store.patch
> 
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 1bd791fb0c..d35c6748c9 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -1826,6 +1826,7 @@ dist_patch_DATA
> =                                         \
>    %D%/packages/patches/slim-
> reset.patch                                \
>    %D%/packages/patches/slim-
> login.patch                                \
>    %D%/packages/patches/slim-display.patch                      \
> +  %D%/packages/patches/stex-copy-from-immutable-store.patch    \
>    %D%/packages/patches/syslinux-gcc10.patch                    \
>    %D%/packages/patches/syslinux-strip-gnu-property.patch       \
>    %D%/packages/patches/snappy-add-O2-flag-in-
> CmakeLists.txt.patch      \
> diff --git a/gnu/packages/chez.scm b/gnu/packages/chez.scm
> index 043f2ae47a..4c253effa0 100644
> --- a/gnu/packages/chez.scm
> +++ b/gnu/packages/chez.scm
> @@ -595,7 +595,7 @@ (define-public stex-bootstrap
>    ;; This commit includes a fix which we would otherwise want to use
> as
>    ;; patch.  Let's revert to tagged releases as soon as one becomes
> available.
>    (let ((commit "afa607564a5662ffd748e824801277a6b5a3d11c")
> -        (revision "2"))
> +        (revision "3"))
You don't need to bump the revision to introduce a patch.  Other than
that LGTM, but could you also do this with a build phase using make-
file-writable?  (It's fine if not, just curious where the actual issue
lies)

Cheers