GNU bug report logs - #57043
[PATCH] gnu: rust-freetype-sys-0.13: Unbundle freetype2.

Previous Next

To reply to this bug, email your comments to 57043 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: rust-freetype-sys-0.13: Unbundle freetype2.
Date: Sun, 07 Aug 2022 18:39:55 +0000

[Message part 1 (text/plain, inline)]

Hello,

This patch removes the bundled freetype2 library on `rust-freetype-sys-0.13'.

Also removes unneeded build dependencies (`pkg-config' and `cmake').

One less bundled dependency ;).

—
Jean-Pierre De Jesus DIAZ

[0001-gnu-rust-freetype-sys-0.13-Unbundle-freetype2.patch (text/x-patch, attachment)]

Message #8 received at 57043 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>, 57043 <at> debbugs.gnu.org
Subject: Re: [bug#57043] [PATCH] gnu: rust-freetype-sys-0.13: Unbundle
 freetype2.
Date: Sun, 7 Aug 2022 23:59:26 +0200

[Message part 1 (text/plain, inline)]

On 07-08-2022 20:39, Jean Pierre De Jesus DIAZ via Guix-patches via wrote:
> Hello,
>
> This patch removes the bundled freetype2 library on `rust-freetype-sys-0.13'.
>
> Also removes unneeded build dependencies (`pkg-config' and `cmake').

I've noticed this in antioxidant (and fixed it there locally) but didn't 
report it yet.

Anyway, this can be done more simple -- all that I needed to do was 
deleting the freetype2 subdirectory (in a snippet) and adding 'freetype' 
to inputs.  Patching the build script or build.rs was not necessary.

Additionally, I noticed that in the modified build.rs, only 
rustc-link-lib (-l) is set, but not rustc-link-search (-L). Antioxidant 
needs the latter to be set, otherwise dependents will fail to link 
because of not finding the freetype library.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #11 received at 57043 <at> debbugs.gnu.org (full text, mbox):

From: Jean Pierre De Jesus DIAZ <me <at> jeandudey.tech>
To: "57043 <at> debbugs.gnu.org" <57043 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: rust-freetype-sys-0.13: Unbundle freetype2.
Date: Mon, 08 Aug 2022 14:37:00 +0000

[Message part 1 (text/plain, inline)]

>Anyway, this can be done more simple -- all that I needed to do was
>deleting the freetype2 subdirectory (in a snippet) and adding 'freetype'
>to inputs.  Patching the build script or build.rs was not necessary.

Thought that the pkg-config `if' block was for Android only, my mistake.

Probably influenced by the compilation error caused by not building
without the freetype2 directory, because `pkg-config' was not present.

>Additionally, I noticed that in the modified build.rs, only
>rustc-link-lib (-l) is set, but not rustc-link-search (-L).

>Antioxidant needs the latter to be set, otherwise dependents will fail
>to link because of not finding the freetype library.

This reminds me of also fixing `rust-bzip2-sys-0.1' in the future because
it also doesn't specify the linker search path because the default build
script was removed like I did in this case.

See:

https://github.com/alexcrichton/bzip2-rs/blob/bzip2-sys-0.1.9/bzip2-sys/build.rs#L12-L23

I don't know our stance on this though, or if there's a policy that
mandates removing compilation support for bundled code or to leave it as
is as long as the code compiles. I'd leave it as it though to make
maintenance easier and less modifications to the original source code.

Thanks for the review!

—
Jean-Pierre De Jesus DIAZ

[0001-gnu-rust-freetype-sys-0.13-Unbundle-freetype2.patch (text/x-patch, attachment)]

Message #16 received at 57043-close <at> debbugs.gnu.org (full text, mbox):

From: Hilton Chain <hako <at> ultrarare.space>
To: 57043-close <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: rust-freetype-sys-0.13: Unbundle freetype2.
Date: Mon, 16 Jun 2025 01:49:02 +0800

Closing since unbundling has been done already and crates-io will be removed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.