GNU bug report logs - #57041
[PATCH] Add a word about warnings to CONTRIBUTE

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57041 in the body.
You can then email your comments to 57041 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add a word about warnings to CONTRIBUTE
Date: Sun, 7 Aug 2022 09:42:16 -0500

Severity: wishlist

Any comments?

diff --git a/CONTRIBUTE b/CONTRIBUTE
index 94d757daaf..fe03fe0afc 100644
--- a/CONTRIBUTE
+++ b/CONTRIBUTE
@@ -165,6 +165,11 @@ test 'out-of-tree' builds as well, i.e.:
     ../path-to-emacs-sources/configure
     make

+In most cases, any given change is required not to introduce any test
+failures or warnings.  There are exceptions: for example, we don't
+usually care about warnings from ancient or buggy compilers, but we do
+try to pacify warnings from stable versions of GCC.
+
 ** Commit messages

 Ordinarily, a change you commit should contain a log entry in its

Message #8 received at 57041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 57041 <at> debbugs.gnu.org
Subject: Re: bug#57041: [PATCH] Add a word about warnings to CONTRIBUTE
Date: Sun, 07 Aug 2022 17:59:03 +0300

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sun, 7 Aug 2022 09:42:16 -0500
> 
> Severity: wishlist
> 
> Any comments?

You mean, this existing text

  ** Testing your changes

  Please test your changes before committing them or sending them to the
  list.  If possible, add a new test along with any bug fix or new
  functionality you commit (of course, some changes cannot be easily
  tested).

doesn't already tell the same?  If so, I'm okay with making the first
sentence say

  Please test your changes before committing them or sending them to the
  list, by running the Emacs test suite and making sure there are no
  regressions.

But I see no particular reasons to describe exceptions.

Message #11 received at 57041 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 57041 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#57041: [PATCH] Add a word about warnings to CONTRIBUTE
Date: Sun, 07 Aug 2022 17:05:09 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> But I see no particular reasons to describe exceptions.

This does seem useful to state explicitly:

+ we don't
+usually care about warnings from ancient or buggy compilers, but we do
+try to pacify warnings from stable versions of GCC.

Because it has happened that people have submitted patches to pacify
ancient gcc versions, and that's not useful work.

Message #14 received at 57041 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57041 <at> debbugs.gnu.org, stefan <at> marxist.se
Subject: Re: bug#57041: [PATCH] Add a word about warnings to CONTRIBUTE
Date: Sun, 07 Aug 2022 18:15:41 +0300

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: Stefan Kangas <stefan <at> marxist.se>,  57041 <at> debbugs.gnu.org
> Date: Sun, 07 Aug 2022 17:05:09 +0200
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > But I see no particular reasons to describe exceptions.
> 
> This does seem useful to state explicitly:
> 
> + we don't
> +usually care about warnings from ancient or buggy compilers, but we do
> +try to pacify warnings from stable versions of GCC.
> 
> Because it has happened that people have submitted patches to pacify
> ancient gcc versions, and that's not useful work.

Why do we have to say this in CONTRIBUTE, though?  It's already too
long; making it longer will just increase the probability of TL;DR,
and no one's the wiser.

Message #17 received at 57041 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 57041 <at> debbugs.gnu.org
Subject: Re: bug#57041: [PATCH] Add a word about warnings to CONTRIBUTE
Date: Thu, 18 Aug 2022 03:55:41 -0700

tags 57041 + wontfix
close 57041
thanks

Eli Zaretskii <eliz <at> gnu.org> writes:

> Why do we have to say this in CONTRIBUTE, though?  It's already too
> long; making it longer will just increase the probability of TL;DR,
> and no one's the wiser.

It doesn't sound like we want to make any changes here.  I'm therefore
closing this bug report.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.