From unknown Thu Jun 19 13:58:28 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57034 <57034@debbugs.gnu.org> To: bug#57034 <57034@debbugs.gnu.org> Subject: Status: [PATCH] gnu: packages: Add miniz. Reply-To: bug#57034 <57034@debbugs.gnu.org> Date: Thu, 19 Jun 2025 20:58:28 +0000 retitle 57034 [PATCH] gnu: packages: Add miniz. reassign 57034 guix-patches submitter 57034 "(" severity 57034 normal tag 57034 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 08:02:31 2022 Received: (at submit) by debbugs.gnu.org; 7 Aug 2022 12:02:32 +0000 Received: from localhost ([127.0.0.1]:36100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKezH-0003eK-Gy for submit@debbugs.gnu.org; Sun, 07 Aug 2022 08:02:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:43084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKezD-0003eB-Q6 for submit@debbugs.gnu.org; Sun, 07 Aug 2022 08:02:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKez4-0005zY-4D for guix-patches@gnu.org; Sun, 07 Aug 2022 08:02:21 -0400 Received: from knopi.disroot.org ([178.21.23.139]:55952) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oKeyy-0001md-7d for guix-patches@gnu.org; Sun, 07 Aug 2022 08:02:15 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8A85A43C4E; Sun, 7 Aug 2022 14:02:09 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id diJaSqZju3QF; Sun, 7 Aug 2022 14:02:08 +0200 (CEST) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659873726; bh=JXsYl94/vUk3bYKVYM4xEZJu15C4/STZWeinAo3EQ8A=; h=From:To:Cc:Subject:Date; b=E/8kEMZtVXBTTYjy6G+llEeI1OGBH6ArQgFzKsLjufcHbndNdtyT3gyjwrpeiSZen 0glBxVjPbXnKTlWuwXx3hk6Jt/xWLMXTY2kwi/AlhmAGmurpJh54fbu2hEWBdcan7P cc9x/VHMnFQREmXqbRZW5xbOKZPpbMw8SDBnBifIT/LSQZ24Wa4mGh+i7hOwKbLGbk 3EckY4c4O2z2NfYsuytDpq65rOAf+Cp2V5SFDnmc58QDFDoa5gFWubcXe2WVPuNYxl WBPZ2G5ST4aCEK8jgbXNWINUPN+UhtgV7LVtTGu8tVgTShsWRG05a2NqxzMgYTzahS avVI9fw0fZQ8Q== To: guix-patches@gnu.org Subject: [PATCH] gnu: packages: Add miniz. Date: Sun, 7 Aug 2022 13:02:01 +0100 Message-Id: <20220807120201.19970-1-paren@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: "\(" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) * gnu/packages/compression.scm (miniz): New variable. --- gnu/packages/compression.scm | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index 6070c5beb1..cb1283c9a1 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -35,6 +35,7 @@ ;;; Copyright © 2021 Simon Tournier ;;; Copyright © 2021 Maxim Cournoyer ;;; Copyright © 2021 Ahmad Jarara +;;; Copyright © 2022 ( ;;; ;;; This file is part of GNU Guix. ;;; @@ -2784,3 +2785,34 @@ (define-public fcrackzip (synopsis "Zip password cracker") (description "Fcrackzip is a Zip file password cracker.") (license license:gpl2+))) + +(define-public miniz + ;; Last release was on 27-06-2021; there have been many commits since + ;; then. + (let ((commit "be92575500f71dfb5ac7b0c5bb47b6e736c23039") + (revision "0")) + (package + (name "miniz") + (version (git-version "2.2.0" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/richgel999/miniz") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0w42vagcv4b0hcf0jk7vamrcpmw62dblx9856j98msdfm3qv1xzi")))) + (build-system cmake-build-system) + (arguments + (list #:configure-flags + #~(list "-DBUILD_SHARED_LIBS=ON") + ;; No test target. + #:tests? #f)) + (home-page "https://github.com/richgel999/miniz") + (synopsis "Simple replacement for @code{zlib}") + (description + "@code{miniz} is a small, simple alternative to the @code{zlib} +data compression library for manipulating zlib, DEFLATE, PNG, and ZIP +files from C.") + (license license:expat)))) -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 12:42:47 2022 Received: (at 57034) by debbugs.gnu.org; 7 Aug 2022 16:42:47 +0000 Received: from localhost ([127.0.0.1]:38224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjMV-0000y8-8U for submit@debbugs.gnu.org; Sun, 07 Aug 2022 12:42:47 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:45930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjMR-0000xr-2C for 57034@debbugs.gnu.org; Sun, 07 Aug 2022 12:42:46 -0400 Received: by mail-ej1-f66.google.com with SMTP id dc19so12611450ejb.12 for <57034@debbugs.gnu.org>; Sun, 07 Aug 2022 09:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=r0t5mcXkq8/rx8DunyUhZbbYz70NF4/gnLLMrdiFatY=; b=NWpdQtFBEeJ6c/Pqc1kY6GvPct+IaiJNTpcJEj/QUWSlynt+bHjoAOrz0ojfAlYtIz oEXVEqo2ZEPb4y+wH6w9aDJ1DkstcHzhFmunT2QHRL/HKI9GKc6pwdjEtASgzFJLSbOq kfle13zZIFe7MG0f5KpiXRCGyXESkBTPDh5keA8zHFlo6GYD4aNZd0AUxDokO6QTh3q6 V1ARfyWFIvaJS03cmX45Gc9qlym8Kt2OoZz9lLzJPjDWEAeV7780sw3H5NTLWAkdc4CP HnQc0BORxNMFq922qCQ+Wd0Eouq1oCjSJ8MVWD4lJ4DkvB8NhxFfOhq+HVRDyAoGdd+4 vipw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=r0t5mcXkq8/rx8DunyUhZbbYz70NF4/gnLLMrdiFatY=; b=gSET/Lxe1pItXUkDI/A413Znclu9jhxy7ZFi6tihmury/0yvk0VIY6E9UfuZiGJTww vfcjXCbWEx03r/ktSi0y+20GtKZcncQyhCtI5VJWhOg0qa14ns/i8zkZmVFM98o0oKmR nIB51Ce9k3TloSJqp79KuP3E7dl1YxKmT9085mQz87xjZcL0yz/z2WkC6LsWbS7kW07Q PgjiVvB1ZnTXGRtv+ijAn61MKMLdBtNo253b4V993mxHvTCVycruycFv757mPgAsq4Zn y0k7r45jlP0mIkkscQwSuUXyrAK1mu3ZvMpMYN6rBa8ZIqZv3s4XDM+kaiASUEyNaKFZ EXDA== X-Gm-Message-State: ACgBeo3D76jKslRl+Hlt44kYry+0gNimqBYkXRR+ijIEj6tOgTlItpuf m2PY9uVY6rPgaxy2LGyPXB0= X-Google-Smtp-Source: AA6agR78//a+mRQzyWQdDPM+u2BkAZuoSeBqo6Yk9ipTFh47q7GxVyJ5qEjzlL43ywGGgsWVoCqWtw== X-Received: by 2002:a17:907:da2:b0:731:60e4:2261 with SMTP id go34-20020a1709070da200b0073160e42261mr587626ejc.679.1659890556996; Sun, 07 Aug 2022 09:42:36 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id qw13-20020a170906fcad00b0072b6d91b056sm4050784ejb.142.2022.08.07.09.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 09:42:36 -0700 (PDT) Message-ID: <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> Subject: Re: [PATCH] gnu: packages: Add miniz. From: Liliana Marie Prikler To: "(" , 57034@debbugs.gnu.org Date: Sun, 07 Aug 2022 18:42:35 +0200 In-Reply-To: <20220807120201.19970-1-paren@disroot.org> References: <20220807120201.19970-1-paren@disroot.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57034 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi (, last time I checked, the template was "gnu: Add PACKAGE", not "gnu: packages: Add PACKAGE." Am Sonntag, dem 07.08.2022 um 13:02 +0100 schrieb (: > * gnu/packages/compression.scm (miniz): New variable. > --- >  gnu/packages/compression.scm | 32 ++++++++++++++++++++++++++++++++ >  1 file changed, 32 insertions(+) > > diff --git a/gnu/packages/compression.scm > b/gnu/packages/compression.scm > index 6070c5beb1..cb1283c9a1 100644 > --- a/gnu/packages/compression.scm > +++ b/gnu/packages/compression.scm > @@ -35,6 +35,7 @@ >  ;;; Copyright © 2021 Simon Tournier >  ;;; Copyright © 2021 Maxim Cournoyer >  ;;; Copyright © 2021 Ahmad Jarara > +;;; Copyright © 2022 ( >  ;;; >  ;;; This file is part of GNU Guix. >  ;;; > @@ -2784,3 +2785,34 @@ (define-public fcrackzip >      (synopsis "Zip password cracker") >      (description "Fcrackzip is a Zip file password cracker.") >      (license license:gpl2+))) > + > +(define-public miniz > +  ;; Last release was on 27-06-2021; there have been many commits > since > +  ;; then. And there might still be many more until a release. I don't think using untagged commits "just because" if the latest release is barely a year old is a good idea. > +  (let ((commit "be92575500f71dfb5ac7b0c5bb47b6e736c23039") > +        (revision "0")) > +    (package > +     (name "miniz") > +     (version (git-version "2.2.0" revision commit)) > +     (source (origin > +              (method git-fetch) > +              (uri (git-reference > +                    (url "https://github.com/richgel999/miniz") > +                    (commit commit))) > +              (file-name (git-file-name name version)) > +              (sha256 > +               (base32 > +                > "0w42vagcv4b0hcf0jk7vamrcpmw62dblx9856j98msdfm3qv1xzi")))) > +     (build-system cmake-build-system) > +     (arguments > +      (list #:configure-flags > +            #~(list "-DBUILD_SHARED_LIBS=ON") > +            ;; No test target. > +            #:tests? #f)) There is a test script you could use. > +     (home-page "https://github.com/richgel999/miniz") > +     (synopsis "Simple replacement for @code{zlib}") > +     (description > +      "@code{miniz} is a small, simple alternative to the > @code{zlib} > +data compression library for manipulating zlib, DEFLATE, PNG, and > ZIP > +files from C.") Avoid marketing terms :) From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 12:59:25 2022 Received: (at 57034) by debbugs.gnu.org; 7 Aug 2022 16:59:25 +0000 Received: from localhost ([127.0.0.1]:38235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjcb-0001P2-Gt for submit@debbugs.gnu.org; Sun, 07 Aug 2022 12:59:25 -0400 Received: from knopi.disroot.org ([178.21.23.139]:40692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjcZ-0001Ot-Fh for 57034@debbugs.gnu.org; Sun, 07 Aug 2022 12:59:24 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 13B2D4505B; Sun, 7 Aug 2022 18:59:22 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kP1xQ5M597sO; Sun, 7 Aug 2022 18:59:20 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659891560; bh=i4pKiiFRXVlhd/+8bXjQ7IZGQMfxZtfLU3i7Y+XFgKo=; h=Date:Subject:From:To:References:In-Reply-To; b=Xmy7TP0dW5LkM/YzxLiq02BzotEB+5F0SuJszafGy9CUpWwu7siC5d5eQKSkx//dO OO6j6vakIvwzYapbRUa5IYIN2FX1BXZFJ4IRxJLoHers9jCZ4NZcBR9/+f2JQ9U9gp /TAqns/t4pTQiLLBKsQfIXEa03eVWbqUd5oX0wsFdWEqiMQi3y456vEXS6WGfcU+PL qmKwaDfAj44AotpJwTGtimg2dltibwOsdr2epjHyNTo9EcMssdwb8Pd9rNRfWz2bGF 3seDnnJwTz1LBgN8JKNbRZUTTrQk5Zrkrn3MLwnIeVchnwEuKg/E8ZFlsZQqLjFLlV UWgp9FbsxWtjg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 07 Aug 2022 17:59:19 +0100 Message-Id: Subject: Re: [PATCH] gnu: packages: Add miniz. From: "(" To: "Liliana Marie Prikler" , <57034@debbugs.gnu.org> References: <20220807120201.19970-1-paren@disroot.org> <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> In-Reply-To: <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57034 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun Aug 7, 2022 at 5:42 PM BST, Liliana Marie Prikler wrote: > last time I checked, the template was "gnu: Add PACKAGE", not "gnu: > packages: Add PACKAGE." Okay, I'll remember that for next time :) > And there might still be many more until a release. I don't think > using untagged commits "just because" if the latest release is barely a > year old is a good idea. > > +=C2=A0 (let ((commit "be92575500f71dfb5ac7b0c5bb47b6e736c23039") > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (revision "0")) > > +=C2=A0=C2=A0=C2=A0 (package > > +=C2=A0=C2=A0=C2=A0=C2=A0 (name "miniz") > > +=C2=A0=C2=A0=C2=A0=C2=A0 (version (git-version "2.2.0" revision commit= )) > > +=C2=A0=C2=A0=C2=A0=C2=A0 (source (origin > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (method git-fetch) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (uri (git-reference > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (url "https://github.com/rich= gel999/miniz") > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (commit commit))) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (file-name (git-file-name name version)) > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 (sha256 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 (base32 > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 > > "0w42vagcv4b0hcf0jk7vamrcpmw62dblx9856j98msdfm3qv1xzi")))) > > +=C2=A0=C2=A0=C2=A0=C2=A0 (build-system cmake-build-system) > > +=C2=A0=C2=A0=C2=A0=C2=A0 (arguments > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (list #:configure-flags > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #~(= list "-DBUILD_SHARED_LIBS=3DON") > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ;; = No test target. > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:t= ests? #f)) > There is a test script you could use. It doesn't work; I tried it. > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "@code{miniz} is a small, simple altern= ative to the > > @code{zlib} > > +data compression library for manipulating zlib, DEFLATE, PNG, and > > ZIP > > +files from C.") > Avoid marketing terms :) Do 'small' and 'simple' count as marketing terms? 'smaller than zlib' is objective fact, and 'simpler than zlib' is subjective but pretty obvious. Maybe I could rewrite it to say 'smaller, simpler alternative' instead? -- ( From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 13:01:52 2022 Received: (at 57034) by debbugs.gnu.org; 7 Aug 2022 17:01:52 +0000 Received: from localhost ([127.0.0.1]:38239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjey-0001US-0i for submit@debbugs.gnu.org; Sun, 07 Aug 2022 13:01:52 -0400 Received: from knopi.disroot.org ([178.21.23.139]:42386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjew-0001UK-9m for 57034@debbugs.gnu.org; Sun, 07 Aug 2022 13:01:50 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 8FA214507B; Sun, 7 Aug 2022 19:01:49 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ianaFhnJd4Ao; Sun, 7 Aug 2022 19:01:48 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659891707; bh=GeNb/CinzNYlNGbc5omweuawiUbuh+z76/6DqTQ2l8A=; h=Date:To:Subject:From:References:In-Reply-To; b=Sl6ppzyJ9iS+BAUt08sHuE3nsDJHsspzX9eaUzP8VlwY4oTg1IVN9tfrAxgYwzR52 MxTAbgk/uhm0Iz3DS+UrrqqGrJ0LNADUprknC0AwzwPDxPx9wnJ8P1kO/FAGePr/Rl v5m/xPJ2rWA2Rk2d8h987X2r0OYOGNMlXBu3DZ8Mn+vKaItctrozkRjfVaD90lD6ap HX4gwn0JTbiESzjm1oHxPOtSUSJji3CfhstwuF1qbBmn1j0eUCgilplcwQbXafoJTb z9eTFI1Sa63zLF3b0pyrVwcKfxwhc5HpIcF5uWAYOgOBKxqJ38d04A7gZaPjE9Itq3 IeVwX0TZcDQ4A== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 07 Aug 2022 18:01:46 +0100 Message-Id: To: "Liliana Marie Prikler" , <57034@debbugs.gnu.org> Subject: Re: [PATCH] gnu: packages: Add miniz. From: "(" References: <20220807120201.19970-1-paren@disroot.org> <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> In-Reply-To: <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57034 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun Aug 7, 2022 at 5:42 PM BST, Liliana Marie Prikler wrote: > And there might still be many more until a release. I don't think > using untagged commits "just because" if the latest release is barely a > year old is a good idea. Okay, I'll update it to use the latest release. -- ( From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 13:20:10 2022 Received: (at 57034) by debbugs.gnu.org; 7 Aug 2022 17:20:10 +0000 Received: from localhost ([127.0.0.1]:38245 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjwf-0001uF-Oh for submit@debbugs.gnu.org; Sun, 07 Aug 2022 13:20:10 -0400 Received: from mail-ej1-f66.google.com ([209.85.218.66]:37474) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjwb-0001tb-6b for 57034@debbugs.gnu.org; Sun, 07 Aug 2022 13:20:08 -0400 Received: by mail-ej1-f66.google.com with SMTP id kb8so12786203ejc.4 for <57034@debbugs.gnu.org>; Sun, 07 Aug 2022 10:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=3u4yPNKsQejlHT/72xPhsvIcaZOGTVif+iWVi2rDTc4=; b=qO5uPxSf8hpT5QDTBWyw2WBLB4elxpmliaSYHC7RJ51Z9xNVGePxkBvYHUwWP6M+G0 6Wj+6SFxwAKb/1oBpZvfsAiy6FrhmGqkxe0CZNBy6PhyfbpdzZVCBhTXUWopZqbi7Mkq 26xBind6hEdOO/slcS1qgr53AJ4TLiQA0ZoiskejfCvxIb8TLRIsQnnQjJP6BHNyB4vb 4LjAiHgYYiTcFBYS1b4skPtraa98PGhjsvLWW4mvgsUZOzbPiQ7sIMeVlvlOaI7bEyTX AYjd7RkpXA7YXJbRUtZ9CgD2ELBDnoIqz6mU66ywBfQZBlsigYolffPOgdaFp6wvW8KL 8KLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=3u4yPNKsQejlHT/72xPhsvIcaZOGTVif+iWVi2rDTc4=; b=yEVX0UvBaisYwnU2VhtWETwSU3+c0Ty9A+XhVmChoeXBOuQq88OMlI8p7Pglidot/P jO1AeYMM+gQFz898mtF0zMvivC9RhaX6Rwo+anSvpkZx/nUQ/EpoFt9dAYPu5/BUOkOi jiAIPTA9dWJl9F5fXIc5QyZNuF1EehW2MJwZy4eZ6XmzVmuDt1exXCnvaTwBdImkcTur l0eQAZ0pI/PgogvCf3LdKhbJUWEx27BLmlPYIiLFVxDNHJvklTJYZxQkau89tMiXKUf4 G/npBhNU0UlPSKzcawMtjPR03Yb6bniuOfA+XOAK62mrDL/BfmclrQAM8zuhyEoIWNHj D0yw== X-Gm-Message-State: ACgBeo2QzotKYCHHBlAs9emjGQ/eZg1OYICCQS/UnhRumxdxFs1wl4pp 711Jje+LLyczjKdZdwxso6c= X-Google-Smtp-Source: AA6agR49kZroAjBpqez1k7skBKnXLOH4O7mpCOHfPqn20oJk1b3MGZaPQ2oLRpPD6TF7uPO2pVxLHA== X-Received: by 2002:a17:906:5a4f:b0:730:825a:d860 with SMTP id my15-20020a1709065a4f00b00730825ad860mr11064599ejc.143.1659892799290; Sun, 07 Aug 2022 10:19:59 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id k15-20020a17090632cf00b007304bdf18cfsm3993762ejk.136.2022.08.07.10.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 10:19:58 -0700 (PDT) Message-ID: <5a29460b4974deaaadd1798b9217dad0fae99151.camel@gmail.com> Subject: Re: [PATCH] gnu: packages: Add miniz. From: Liliana Marie Prikler To: "(" , 57034@debbugs.gnu.org Date: Sun, 07 Aug 2022 19:19:57 +0200 In-Reply-To: References: <20220807120201.19970-1-paren@disroot.org> <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57034 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Sonntag, dem 07.08.2022 um 17:59 +0100 schrieb (: > On Sun Aug 7, 2022 at 5:42 PM BST, Liliana Marie Prikler wrote: > > last time I checked, the template was "gnu: Add PACKAGE", not "gnu: > > packages: Add PACKAGE." > Okay, I'll remember that for next time :) > > > And there might still be many more until a release.  I don't think > > using untagged commits "just because" if the latest release is > > barely a > > year old is a good idea. > > > > +  (let ((commit "be92575500f71dfb5ac7b0c5bb47b6e736c23039") > > > +        (revision "0")) > > > +    (package > > > +     (name "miniz") > > > +     (version (git-version "2.2.0" revision commit)) > > > +     (source (origin > > > +              (method git-fetch) > > > +              (uri (git-reference > > > +                    (url "https://github.com/richgel999/miniz") > > > +                    (commit commit))) > > > +              (file-name (git-file-name name version)) > > > +              (sha256 > > > +               (base32 > > > +                > > > "0w42vagcv4b0hcf0jk7vamrcpmw62dblx9856j98msdfm3qv1xzi")))) > > > +     (build-system cmake-build-system) > > > +     (arguments > > > +      (list #:configure-flags > > > +            #~(list "-DBUILD_SHARED_LIBS=ON") > > > +            ;; No test target. > > > +            #:tests? #f)) > > There is a test script you could use. > It doesn't work; I tried it. > > > > +      "@code{miniz} is a small, simple alternative to the > > > @code{zlib} > > > +data compression library for manipulating zlib, DEFLATE, PNG, > > > and > > > ZIP > > > +files from C.") > > Avoid marketing terms :) > Do 'small' and 'simple' count as marketing terms? 'smaller than zlib' > is objective fact, and 'simpler than zlib' is subjective but pretty > obvious. Maybe I could rewrite it to say 'smaller, simpler > alternative' > instead? "subjective, but pretty obvious", how so? I think the fact that it doesn't have its own documentation and you need to instead refer to zlib kinda defeats that point. Several of its README claims seem either outdated already (the 550 lines one for example), or difficult to guarantee forever. I think the only claim we can reasonably make is that it is an alternative zlib implementation, and that it supports zlib, deflate, png and zip. Cheers From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 13:22:33 2022 Received: (at 57034) by debbugs.gnu.org; 7 Aug 2022 17:22:33 +0000 Received: from localhost ([127.0.0.1]:38249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjyz-0001yC-Ar for submit@debbugs.gnu.org; Sun, 07 Aug 2022 13:22:33 -0400 Received: from knopi.disroot.org ([178.21.23.139]:48164) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKjyx-0001y4-Kl for 57034@debbugs.gnu.org; Sun, 07 Aug 2022 13:22:32 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 1AFB0450BC; Sun, 7 Aug 2022 19:22:30 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id N1j9zTMFqzAT; Sun, 7 Aug 2022 19:22:29 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659892949; bh=bhQFxZ1EbKhUHr5JtebNPkwyCBgEZa14U+3ICwUoa2U=; h=Date:Subject:From:To:References:In-Reply-To; b=LbTs5rMsE5/1YbsfohMtvoTCpaIp5oC6sfTWPIwfW+jzMQNeNIUQCpYw0TnMuYL8I FerjzJg+au2EzB7E3KpRlWfW150kYvqPDUZouskhaEBKtU5m48m6CjSyUQkewcXwkD jNbtMi6HkPmjD2avQr4j6ueRM7edwyZU1lU7LcReM4H4teiGjchoHl88lksGmzRS8N RoAQDBjUGzUimVPrY+p/FdqNXlGoe2QW2DEl/JOSknCq/nXf6iylRFrJWqznEcQzLD y0VtaXLRJAiZEb2b5CBQAbHemlUCOnla9eozr5lglc2TS1jnkoqDISr8+Xw7thslTn 2P+Azz8rC7U4A== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Sun, 07 Aug 2022 18:22:28 +0100 Message-Id: Subject: Re: [PATCH] gnu: packages: Add miniz. From: "(" To: "Liliana Marie Prikler" , <57034@debbugs.gnu.org> References: <20220807120201.19970-1-paren@disroot.org> <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> <5a29460b4974deaaadd1798b9217dad0fae99151.camel@gmail.com> In-Reply-To: <5a29460b4974deaaadd1798b9217dad0fae99151.camel@gmail.com> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57034 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun Aug 7, 2022 at 6:19 PM BST, Liliana Marie Prikler wrote: > "subjective, but pretty obvious", how so? I think the fact that it > doesn't have its own documentation and you need to instead refer to > zlib kinda defeats that point. Several of its README claims seem > either outdated already (the 550 lines one for example), or difficult > to guarantee forever. I think the only claim we can reasonably make is > that it is an alternative zlib implementation, and that it supports > zlib, deflate, png and zip. Okay. (There is a little documentation in the headers, by the way.) :) -- ( From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 20:37:01 2022 Received: (at 57034) by debbugs.gnu.org; 8 Aug 2022 00:37:01 +0000 Received: from localhost ([127.0.0.1]:38571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKqlQ-0002QA-Rr for submit@debbugs.gnu.org; Sun, 07 Aug 2022 20:37:01 -0400 Received: from tobias.gr ([80.241.217.52]:60866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKqlM-0002Py-BD for 57034@debbugs.gnu.org; Sun, 07 Aug 2022 20:36:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=z+6KkukE5vqSH VuLvUazA7RrcR+0Qc4BFawVn6QvE7M=; h=references:in-reply-to:subject:to: from:date; d=tobias.gr; b=EcMNwlZGm3erkIuVyKjauIcGxxkZZAqmK7Rk7DoM/84J wRGeGIiO68+OAghU77fPZayhNCyFL3t5FUzlYJAjDYmcsCwennLo63idGCnGL9YdycrVFC pFDrDX+MgEOug8B97C5XUI5aHA/oInwMMdNv1pe9fa23enKsL/qu9xRbsh35W+qPDAxrbS Grif4Z3+0NowJLr36GZWljXVSxE1Mdyb2FJ+2vm+tQOcS9MFQ2CVb/jlPwLNr7D5CFLch9 i4wNGBQs5g5KKF1WmgsnY5EFRsu2yu86amf9XWEKtbQZYbArbn5Oq8d70n83FzyeKVtDPT cUgYUmiC9cKkxUKUuQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id fb0a0e8a (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 8 Aug 2022 00:36:51 +0000 (UTC) Date: Mon, 08 Aug 2022 00:36:20 +0000 From: Tobias Geerinckx-Rice To: guix-patches@gnu.org, Liliana Marie Prikler , "(" , 57034@debbugs.gnu.org Subject: Re: [bug#57034] [PATCH] gnu: packages: Add miniz. In-Reply-To: <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> References: <20220807120201.19970-1-paren@disroot.org> <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Autocrypt: addr=me@tobias.gr; keydata= mQINBFVks2ABEACjGBPhWf/qx0L9OhEIrAFTimo5dHa1FLy0AHaHvxmwYSIdJmERYGiNle1rcOvw cFRtu8KJUsrs27Vgoso3qHJpghVitUUf0v3ZuXQT9kfuQLz1Y8pyMzHwVFMLiJVj4Z3y7CJk+xyZ cpSAMbyPINbFVEhsK+z+8ojVGuaiucZkib6b67ySG6Pp1bon8xVvosj71ZRjfXh1t4X8laWO7fQq itT9lmc6DxbE/4vIhR+Vb2MblaA+DyHoNHGGao89h4CO99lfzWzsux41DnEG9d317sJRQTig6Wja EKHXZRA9FbfogD4SDa2uQYCpTJpsVjAyZyu2fuJ+t0zJJ+Ai9qDY87P6hOyd+/n8Eh2Y4TbxJiDo XUT72XY/RfPH1qrMIP3EI/NNL4LQeGG1n+625k3OVWcRVXG2vRrB6qurLmGkLEmjXWCFD9cCRGfH LeajLm9sM+t/nZPZ3btetcmK9tM2EwivyLUNhrTk73UUnI4CSAzdO2cISqo9zSMtFgj2alqd2fOR s7CKfEn+5PquruDbp/Ej7dOOrjgWSCXLDDYXRrtaKrLz/dhqq5ftFYi9tUTTQecFotM08fPtu+Kw JMP2ySHCkUqp0GvrUCeSRPAJZsmJrd535y+LlRhnqb0mbG4dgMa8A6xhkFYugnqldy/q7kX1EmRI 686N7bA6fh1MCQARAQABtCRUb2JpYXMgR2VlcmluY2t4LVJpY2UgPG1lQHRvYmlhcy5ncj6JAlIE EwEKADwCHgECF4ACGQECGwMWIQT1vFU0w28Ah7OdNu8cncT+udt8SwUCXpe0rAYLCQgHCgQFFQoJ CAsFFgMCAQAACgkQHJ3E/rnbfEu5IhAAk+0BW/twLmx1xMmeXn+I7Ne6SG3++0TRBduEaGWV3n59 lX6XPZUQdAPpS4uy0H+c90Owkw+aWUEwfyOWphrxZRtR2cCOP/3Pxj3Vgtz5RkY4u27lMj15jqa/ p7l2l256ZKJOegr9TvOWtkhMp5lxeVHT6f/44Kv/r/8mMCgSnLXYrEWPE462xI+mIJOanHLJb6No f2xLRCvXoLLp7Yejjv1dwOO71R9PMRhtNy46pZM1ylQ++UTkeSocJw4aNtiu0DHOkX9AlNBkutIx x07RpO+MqJKlzzLeQiC/fE5+dR2itRONopwXAqN3MuT7MonQo5XifBn+VK8i9xZWTXZDkWItWtCC 8oIj4zwxwFWiTmMwwSbI3Wdd/11Zw3CLc4Gd0M6NVgvAnuErQXSgr4lrWhZcncvi4L6EJTc9AUSa 8UWPF+S9t+CHTukpJmcYnsccMkOBhT7OZlmWBsylrYK/JTRWqgWSHWdSKmOuLK+MGDneOZEHkEcf jeXRWvmG7MSU5tE/p7NDLIg9vkvhQV9b0q4OtY65uNWbRe2QRJaYMDcYUAeSZzivRa8VaoVen6tb FvH44zpCxubn23ABl9YIzwvJC++r+H2qLdLpy0cfITiZadZ74Ae0aosNw7XARS6OY+A03BfXyPiI 2oW0jf/PdH9sh2mQrQxIQJ5cZz6Z3X0= X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57034 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 7 August 2022 16:42:35 UTC, Liliana Marie Prikler wrote: >> +=C2=A0=C2=A0=C2=A0=C2=A0 (synopsis "Simple replacement for @code{zlib}= ") >> +=C2=A0=C2=A0=C2=A0=C2=A0 (description >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 "@code{miniz} is a small, simple altern= ative to the >> @code{zlib} >> +data compression library for manipulating zlib, DEFLATE, PNG, and >> ZIP >> +files from C=2E") >Avoid marketing terms :) =20 (Small and simple are marketing terms? Be right back; I need to update my= profile=2E=2E=2E) =2E=2E=2Eno: avoid misleading or meaningless drivel, puffery, and redundan= cy=2E Do, however, point out some basic features that might help users dec= ide which of our oofteen deflate libraries fits their needs=2E Add -er if = you think it helps, or add some examples=2E Otherwise, a common-sense guideline risks devolving into 'avoid adjectives= ; you might accidentally write a useful description'=2E Kind regards, T G-R Sent on the go=2E Excuse or enjoy my brevity=2E From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 08 00:29:41 2022 Received: (at 57034) by debbugs.gnu.org; 8 Aug 2022 04:29:41 +0000 Received: from localhost ([127.0.0.1]:38731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKuOY-0008Lo-AB for submit@debbugs.gnu.org; Mon, 08 Aug 2022 00:29:41 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:45571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKuOQ-0008LW-Kf for 57034@debbugs.gnu.org; Mon, 08 Aug 2022 00:29:36 -0400 Received: by mail-ed1-f65.google.com with SMTP id e13so9785814edj.12 for <57034@debbugs.gnu.org>; Sun, 07 Aug 2022 21:29:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:date:in-reply-to:references:user-agent :mime-version:content-transfer-encoding; bh=Kz27YJ0YKKoxKgBroIcpUapF8m6mUOGrKo7Mv+oENJc=; b=J6KJ2CZT0/vsGjSWJ7EQayYHAajEHeFtSSsvxfP5g4/T824N6TVALrs/SRN3KEzmhT gKwUfQ2gs0IK6a2mx2WQRSqr2i6NdIEvLJlw0ieC9YhRMeAK1CUzDQFWHG/xt96kD4aq loOQ//p4W7gTw+1bdb5I2D54yTRkPZGwv0/EWDKdWWovLL8Nq6TqUq6n9dzBTyqTX77v ZtwELRwWVSGfdSTacq9L9CqnIUdqqy1r4hlgPJUNvc8pmDvKuPvV9PARDdRkRwU2c25K qlp7cK+y9tTkKRxbbUu6BIs9gMZAp0d5VYLnocccXUwghse1BcX7B/DJ/zTFGG+qAQ76 BZZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=Kz27YJ0YKKoxKgBroIcpUapF8m6mUOGrKo7Mv+oENJc=; b=Vuir9sochTc0XTtdUI9Y5gWOH0KXwtGzCJwNy9Mu3vpli+yl/TKG0GjCL0owF5EEf7 EcFbR0Fd0+9jyVMI+D5Qlq3D0h9gAt56OyvIbr62EbC/2XhUtiWIVm2rFFmafp0qszAa Y/eKtHZQQiXhjI3akuT5d7vxsAcC6tEbrYqOv318x30SOCLjcUCCk1S+CuQH1wIJrJIb hSGNzGlcgdIowwnnY3mE9ChDGOWQOqmyLy+BYI9zaRg8Id7p20WIWqGi0pxIqQPr52QY cJ/ro+nOP+m/ERsbltiYGz2ahceVmQ58jHetaUZ7TyG38WZpHA4CwLvrclzlyVSp7XNi pMnA== X-Gm-Message-State: ACgBeo2gVYSrz2Wv0CKrb2IhDZx+DDzPeb+weKKZQW5p97u3tM1tynjW Gd91+ddQBMr+5AWlT4Xo2B0= X-Google-Smtp-Source: AA6agR52hbjdT+49FnP/SLmN1yN56+4IRvGFIXwNBuAz9KKsXYxHhMxEhUsI98YhJs9P6yn9+QUcaQ== X-Received: by 2002:a05:6402:3805:b0:43e:8335:3a2a with SMTP id es5-20020a056402380500b0043e83353a2amr16407193edb.296.1659932964569; Sun, 07 Aug 2022 21:29:24 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id 17-20020a170906211100b0072b2378027csm4498761ejt.26.2022.08.07.21.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Aug 2022 21:29:24 -0700 (PDT) Message-ID: <8c2e7c4be682d3b197cb1e1d99eef3345b15084b.camel@gmail.com> Subject: Re: [bug#57034] [PATCH] gnu: packages: Add miniz. From: Liliana Marie Prikler To: Tobias Geerinckx-Rice , "(" , 57034@debbugs.gnu.org Date: Mon, 08 Aug 2022 06:29:23 +0200 In-Reply-To: References: <20220807120201.19970-1-paren@disroot.org> <1c8bc45b27083d351e3930006c51675e00d3d15b.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57034 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Am Montag, dem 08.08.2022 um 00:36 +0000 schrieb Tobias Geerinckx-Rice: > On 7 August 2022 16:42:35 UTC, Liliana Marie Prikler > wrote: > > > +     (synopsis "Simple replacement for @code{zlib}") > > > +     (description > > > +      "@code{miniz} is a small, simple alternative to the > > > @code{zlib} > > > +data compression library for manipulating zlib, DEFLATE, PNG, > > > and > > > ZIP > > > +files from C.") > > Avoid marketing terms :) >   > (Small and simple are marketing terms?  Be right back; I need to > update my profile...) > > ...no: avoid misleading or meaningless drivel, puffery, and > redundancy.  Do, however, point out some basic features that might > help users decide which of our oofteen deflate libraries fits their > needs.  Add -er if you think it helps, or add some examples. Maybe not always, but I think in this context they are. Especially "simple", who decides that? Pardon my cynicism here, but my personal opinion w.r.t. compression libraries is that projects tend to pick the one they're already contractually obligated to use FSVO contractually obligated. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 12 17:45:15 2022 Received: (at 57034) by debbugs.gnu.org; 12 Dec 2022 22:45:15 +0000 Received: from localhost ([127.0.0.1]:55915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rXv-0005HY-9M for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:45:15 -0500 Received: from knopi.disroot.org ([178.21.23.139]:34580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rXt-0005HP-FZ for 57034@debbugs.gnu.org; Mon, 12 Dec 2022 17:45:14 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 013D041817; Mon, 12 Dec 2022 23:45:12 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 70ZfGGt6Yrsx; Mon, 12 Dec 2022 23:45:10 +0100 (CET) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1670885110; bh=8uQSmfmBVSiOYyBR5EeYFa5RnHoC77KmS+FrgPeSzAY=; h=From:To:Cc:Subject:Date; b=JcgvoRbAD/mI9KYst5WlPMTPZhlnqLlXMQp0msb4ftV4zdtJFphxfYRNCBk7XW7p0 X+9aDubp0SxXNcHR3VKX3FdSHqMocXd/gqtEHAiCjIBf4tu9sP/jUg29j+sa4/4586 clZQiOoe4hyLpSun2yqULXc3qykxFb3WY1zN9ELbdfnu4cHaAl24vhV6gkodIVXU5W 8RmZhyD09GbIxPcCdTnLMDRVKeZqZjp6jzG/pZlr5Ou4eGaOanBtcCFZz2fgyor/+1 FPaFaTXbmdt5Ov9OWDVDzBX0HcB6eItOiTSM9YjHDpg37C/UDFJcpmj8oFNnp8uPW1 hhm5fwIn3E/jQ== To: 57034@debbugs.gnu.org Subject: [PATCH v2] gnu: packages: Add miniz. Date: Mon, 12 Dec 2022 22:45:04 +0000 Message-Id: <20221212224504.21905-1-paren@disroot.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57034 Cc: "\(" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/compression.scm (miniz): New variable. --- gnu/packages/compression.scm | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index d2a1ed36f7..aa6404d1a3 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -36,6 +36,7 @@ ;;; Copyright © 2021 Maxim Cournoyer ;;; Copyright © 2021 Ahmad Jarara ;;; Copyright © 2022 Zhu Zihao +;;; Copyright © 2022 ( ;;; ;;; This file is part of GNU Guix. ;;; @@ -2820,3 +2821,30 @@ (define-public fcrackzip (synopsis "Zip password cracker") (description "Fcrackzip is a Zip file password cracker.") (license license:gpl2+))) + +(define-public miniz + (package + (name "miniz") + (version "3.0.1") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/richgel999/miniz") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0lchj2yhvaiy0bc28xqnjqjhv4yj4kffcgxgfiikn634milwd5b4")))) + (build-system cmake-build-system) + (arguments + (list #:configure-flags + #~(list "-DBUILD_SHARED_LIBS=ON") + ;; No test target. + #:tests? #f)) + (home-page "https://github.com/richgel999/miniz") + (synopsis "Alternative to zlib") + (description + "miniz is an alternative to, and in many cases drop-in replacement for, the +zlib data compression libraries, which provides APIs for manipulating zlib, DEFLATE, +PNG, and ZIP files from C.") + (license license:expat))) base-commit: 1d160f41f5e973ea2bbbf8bc80d216b5d9b0974c -- 2.38.1