GNU bug report logs - #57021
[PATCH] gnu: packages: Add nmail.

Previous Next

Package: guix-patches;

Reported by: M <matf <at> disr.it>

Date: Sat, 6 Aug 2022 23:03:01 UTC

Owned by: Christina O'Donnell <cdo <at> mutix.org>

Severity: normal

Tags: patch

Merged with 56994

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 57021 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: M <matf <at> disr.it>
Cc: 57021 <at> debbugs.gnu.org
Subject: Re: bug#57021: [PATCH] gnu: packages: Add nmail.
Date: Fri, 12 Aug 2022 10:53:33 +0200

Hello,

> * gnu/packages/nmail.scm: Reorder module imports. Remove
>   duplicate imports.
> (nmail): New variable. Fix style.

Thanks for this first contribution. As you are adding a new package, the
preferred way to proceed is to amend your first patch with those changes
and submit a new revision (v2).

The module re-ordering stuff should also be part of a new patch. In
short, we would expect something like:

* gnu: Reorder mail module imports.
* gnu: nmail: New variable.

Do you think you could send those two patches in a v3? Don't hesitate to
ask for guidance here or on IRC if I'm unclear.

Mathieu
This bug report was last modified 1 year and 23 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.