GNU bug report logs - #57004
[PATCH] Fontify Escape Sequences in Python String and Byte Literals

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57004 in the body.
You can then email your comments to 57004 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Laurence Warne <laurencewarne <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fontify Escape Sequences in Python String and Byte Literals
Date: Fri, 5 Aug 2022 14:06:33 +0100

[Message part 1 (text/plain, inline)]

Hi, this patch implements escape code syntax highlighting within string an
bytes literals for python-mode (described at
https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals)
similar to how they are highlighted by https://pygments.org.

I've written a few tests (which should probably be expanded on (: ), an
example based on one of the test samples:

b'example 1: \n \\ \u1234 \U00010348 \N{Plus-Minus Sign}'
'example 2:  \n \\ \u1234 \U00010348 \N{Plus-Minus Sign}'

e.g. in the above we see "\n", "\\" highlighted on the first line, but not
"\u1234", "\U00010348" "\N{Plus-Minus Sign}" since these items aren't valid
escape sequences in byte literals.  The second line however is a string
literal, so all of the preceding items are highlighted.

Thanks, Laurence

[Message part 2 (text/html, inline)]

[0001-Fontify-python-escape-sequences-in-literals.patch (text/x-patch, attachment)]

Message #8 received at 57004 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Laurence Warne <laurencewarne <at> gmail.com>
Cc: 57004 <at> debbugs.gnu.org
Subject: Re: bug#57004: [PATCH] Fontify Escape Sequences in Python String
 and Byte Literals
Date: Sat, 06 Aug 2022 15:02:22 +0200

Laurence Warne <laurencewarne <at> gmail.com> writes:

> Hi, this patch implements escape code syntax highlighting within string an bytes
> literals for python-mode (described at
> https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals)
> similar to how they are highlighted by https://pygments.org.

Thanks; pushed to Emacs 29.

Message #13 received at 57004 <at> debbugs.gnu.org (full text, mbox):

From: Laurence Warne <laurencewarne <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57004 <at> debbugs.gnu.org
Subject: Re: bug#57004: [PATCH] Fontify Escape Sequences in Python String and
 Byte Literals
Date: Tue, 9 Aug 2022 09:42:57 +0100

[Message part 1 (text/plain, inline)]

Great, thanks.  I saw a few bugs playing around a bit more:

1) Consecutive escape codes not fontified:
b'\x12\x23'  # Here only "\x12" would be fontified
2) Multi-line bytes literals fontified as string literals:
b'''\x12 \777 \1\23 \u1234'''  # Here '\u1234" would be (incorrectly)
fontified
3) Octal escape codes may be one to three characters instead of always
three (
https://docs.python.org/3/reference/lexical_analysis.html#escape-sequences):
"\1 \12 \123"  # Here only "\123" would be fontified

I've attached a patch which fixes the above and adds a new test.  The new
test (tests different combinations of multi-line literals) makes up the
majority of the diff.

Thanks, Laurence

On Sat, Aug 6, 2022 at 2:02 PM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:

> Laurence Warne <laurencewarne <at> gmail.com> writes:
>
> > Hi, this patch implements escape code syntax highlighting within string
> an bytes
> > literals for python-mode (described at
> >
> https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals
> )
> > similar to how they are highlighted by https://pygments.org.
>
> Thanks; pushed to Emacs 29.
>
>

[Message part 2 (text/html, inline)]

[0001-Fix-python-escape-code-fontification-for-multi-line-.patch (text/x-patch, attachment)]

Message #16 received at 57004 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Laurence Warne <laurencewarne <at> gmail.com>
Cc: 57004 <at> debbugs.gnu.org
Subject: Re: bug#57004: [PATCH] Fontify Escape Sequences in Python String
 and Byte Literals
Date: Tue, 09 Aug 2022 17:30:43 +0200

Laurence Warne <laurencewarne <at> gmail.com> writes:

> I've attached a patch which fixes the above and adds a new test.  The
> new test (tests different combinations of multi-line literals) makes
> up the majority of the diff.

Thanks; pushed to Emacs 29.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.