GNU bug report logs - #57000
Wrong entry "c-mode" in definition prefix for semantic

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 57000 in the body.
You can then email your comments to 57000 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: Wrong entry "c-mode" in definition prefix for semantic
Date: Fri, 5 Aug 2022 12:06:06 +0200

Severity: minor

I see in loaddefs.el:

    (register-definition-prefixes "semantic/bovine/c" '("c-mode" "semantic"))

I think "c-mode" shouldn't be there, but I can't seem to figure out why
it is.

Message #8 received at 57000 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: 57000 <at> debbugs.gnu.org
Subject: Re: bug#57000: Wrong entry "c-mode" in definition prefix for semantic
Date: Fri, 5 Aug 2022 12:51:55 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> I see in loaddefs.el:
>
>     (register-definition-prefixes "semantic/bovine/c" '("c-mode" "semantic"))
>
> I think "c-mode" shouldn't be there, but I can't seem to figure out why
> it is.

This is caused by

    defcustom-mode-local-semantic-dependency-system-include-path

One possible fix below, but I'm not sure we want to do this generally:

diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
index afba9f8fbc..8aa17be765 100644
--- a/lisp/emacs-lisp/loaddefs-gen.el
+++ b/lisp/emacs-lisp/loaddefs-gen.el
@@ -68,6 +68,7 @@ autoload-ignored-definitions
     "define-short-documentation-group"
     "def-edebug-elem-spec"
     "defvar-mode-local"
+    "defcustom-mode-local-semantic-dependency-system-include-path"
     "define-ibuffer-column"
     "define-ibuffer-sorter")
   "List of strings naming definitions to ignore for prefixes.
@@ -456,7 +457,7 @@ loaddefs-generate--compute-prefixes
   (let ((prefs nil))
     ;; Avoid (defvar <foo>) by requiring a trailing space.
     (while (re-search-forward
-            "^(\\(def[^ \t]+\\)[ \t]+['(]*\\([^' ()\"\n]+\\)[\n \t]" nil t)
+            "^(\\(def[^ \t\n]+\\)[ \t\n]+['(]*\\([^' ()\"\n]+\\)[\n \t]" nil t)
       (unless (member (match-string 1) autoload-ignored-definitions)
         (let ((name (match-string-no-properties 2)))
           (when (save-excursion

Message #11 received at 57000 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 57000 <at> debbugs.gnu.org
Subject: Re: bug#57000: Wrong entry "c-mode" in definition prefix for semantic
Date: Fri, 05 Aug 2022 14:07:38 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> This is caused by
>
>     defcustom-mode-local-semantic-dependency-system-include-path
>
> One possible fix below, but I'm not sure we want to do this generally:

The patch just allows a newline after the (def* form?  I think that
makes sense.

Message #16 received at 57000-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 57000-done <at> debbugs.gnu.org
Subject: Re: bug#57000: Wrong entry "c-mode" in definition prefix for semantic
Date: Fri, 5 Aug 2022 20:27:35 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Stefan Kangas <stefan <at> marxist.se> writes:
>
>> This is caused by
>>
>>     defcustom-mode-local-semantic-dependency-system-include-path
>>
>> One possible fix below, but I'm not sure we want to do this generally:
>
> The patch just allows a newline after the (def* form?  I think that
> makes sense.

Yes, indeed.  Now done on master (commit ea6c2e9295).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.