GNU bug report logs - #56994
[PATCH] Add nmail

Previous Next

Full log

Message #11 received at 56994 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: <matf <at> disr.it>, <56994 <at> debbugs.gnu.org>
Subject: Re: [bug#56994] [PATCH] Add nmail
Date: Fri, 05 Aug 2022 13:30:19 +0100

Nice to see you got it working :) Some stylistic nits:

On Fri Aug 5, 2022 at 3:21 AM BST,  wrote:
> From: M <matf <at> disr.it>
>
> ---

You need to write a commit message following the project's conventions. In
this case, it'd be something like:

> gnu: packages: Add nmail.
>
> * gnu/packages/mail.scm: Reorder module imports. Remove
>   duplicate imports.
> (nmail): New variable.

Refer to <https://www.gnu.org/prep/standards/html_node/Change-Logs.html>.
(No, I don't like it much either :))

> +    (arguments
> +     (list #:phases #~(modify-phases %standard-phases
> +                        (replace 'check
> +                          (lambda*
> +                              (#:key tests? #:allow-other-keys)
> +                              (when tests? (invoke "ctest" "--output-on-failure")))))))

This part should be reformatted like this:

> (arguments
>  (list #:phases
>        #~(modify-phases %standard-phases
>            (replace 'check
>              (lambda* (#:key tests? #:allow-other-keys)
>                (when tests?
>                  (invoke "ctest" "--output-on-failure")))))))

> +    (inputs (list libetpan
> +                  xapian
> +                  sqlite
> +                  cyrus-sasl
> +                  ncurses
> +                  openssl
> +                  file
> +                  (list util-linux "lib")))

And this as:

> (inputs
>  (list cyrus-sasl
>        file
>        ncurses
>        openssl
>        sqlite
>        (list util-linux "lib")
>        xapian))

> +    (native-inputs (list pkg-config))
> +    (home-page "https://github.com/d99kris/nmail")
> +    (synopsis "Terminal-based email client")
> +    (description
> +     "@command{nmail} is a terminal-based email client with a
> +@code{ncurses} user interface similar to @code{alpine} and @code{pine}.")
> +    (license license:expat)))
> +
>  (define-public nullmailer
>    (package
>      (name "nullmailer")
> -- 
> 2.34.0

Other than that, LGTM! :)

    -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.