From unknown Fri Jun 20 19:53:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56990 <56990@debbugs.gnu.org> To: bug#56990 <56990@debbugs.gnu.org> Subject: Status: [PATCH v1 2/5] gnu: bqn: Add bqn-bytecode-sources. Reply-To: bug#56990 <56990@debbugs.gnu.org> Date: Sat, 21 Jun 2025 02:53:04 +0000 retitle 56990 [PATCH v1 2/5] gnu: bqn: Add bqn-bytecode-sources. reassign 56990 guix-patches submitter 56990 Christopher Rodriguez severity 56990 normal tag 56990 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 22:20:54 2022 Received: (at submit) by debbugs.gnu.org; 5 Aug 2022 02:20:54 +0000 Received: from localhost ([127.0.0.1]:55511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJmxJ-0006Ku-QC for submit@debbugs.gnu.org; Thu, 04 Aug 2022 22:20:54 -0400 Received: from lists.gnu.org ([209.51.188.17]:57172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJmxH-0006Kn-Nv for submit@debbugs.gnu.org; Thu, 04 Aug 2022 22:20:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJmxH-00014b-IR for guix-patches@gnu.org; Thu, 04 Aug 2022 22:20:51 -0400 Received: from mail-qv1-xf29.google.com ([2607:f8b0:4864:20::f29]:35826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJmxF-0007kN-KD for guix-patches@gnu.org; Thu, 04 Aug 2022 22:20:50 -0400 Received: by mail-qv1-xf29.google.com with SMTP id b7so949580qvq.2 for ; Thu, 04 Aug 2022 19:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc; bh=fRon4sZtyzO2EZ20u7fPu2UUJWQ24EE+FEgA9OGVRbs=; b=IF/TRglkOJD314jO6UZ5pAOP6YnTTTZGs7+WZikJJOyRBVtlZAigXZUBjAeuxZYW7R msGqCmKN1xQ8jUbR+PliQS4sU82mmTvCZimVv2b15wgQXy9FupfgZnsy/EwRYkpJ9RuD quFt8nsD6jSeRzcFzusDVU2hK6G6FO70+5iCRlo8Au2hWjhTAIQBSbbd0y67p6y9Weoy qWu+1BosCcq4UWcAX6Kwv1lJg/KwF9wl2VeZzo9F2lDuCO1kBN1Lez1Os+YXhe+cONGg Q95TveYKxOCwkkaAg98YA3KdVrFK+eZeIFPK3IjkxH0K76M7a181/e72f5MaMPXU34wV ix7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=fRon4sZtyzO2EZ20u7fPu2UUJWQ24EE+FEgA9OGVRbs=; b=Q4ekNyoL18rP2VP2dmKLdrY3f7mkEDDYJxVnwlyPlEaIb+EWtVA6yFpoyeGl8c45P0 8z5U4FOrD/pXMFH6MgIjN6J+8cBUqAun7NaYM1orglQB4iMtIR3AmZNS7A7JPQQzlEDT J4Ci3GuNHtd6pc7E8Vzm/9BWZCbyVfeBrnD8fl4JIWNJn/8h6vxsK/BG3uKBYp3xetYQ lc7fRcHuJZSXCto3wUA/V9nAMb6r+49b6QYLK9fObwbHNbjZFBoyEqNx+t9/sY1M4buA mtvaeDgUoPTRZsPDvHA/ZX7TkyMKU+7NTG6QHE1kh+rrdlyorHearGTCbBycjYGUX3RB 9j8w== X-Gm-Message-State: ACgBeo3DJRnNnp7OYi0pzvpaJkrHJrz83gpp6NFKGYYXZV5PYJq3CIaR 9hbs6N0rpYPZPdmHmVeEY78V6BvIomnTbA== X-Google-Smtp-Source: AA6agR4mUfOncFJG6OptZQaC3POjLNQx/vIQdxbymXchADhAHTS0j61QIWt8TFRu04uGAVpdaXtHww== X-Received: by 2002:a05:6214:529e:b0:476:93ab:155c with SMTP id kj30-20020a056214529e00b0047693ab155cmr4063439qvb.25.1659666048288; Thu, 04 Aug 2022 19:20:48 -0700 (PDT) Received: from gmail.com ([2601:547:a00:7720::7bb0]) by smtp.gmail.com with ESMTPSA id o14-20020ac8428e000000b0031ece8b6666sm1838675qtl.43.2022.08.04.19.20.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Aug 2022 19:20:48 -0700 (PDT) From: Christopher Rodriguez To: guix-patches@gnu.org Subject: [PATCH v1 2/5] gnu: bqn: Add bqn-bytecode-sources. Date: Thu, 4 Aug 2022 22:20:20 -0400 Message-Id: <20220805022023.5044-2-yewscion@gmail.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220805022023.5044-1-yewscion@gmail.com> References: <20220805022023.5044-1-yewscion@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::f29; envelope-from=yewscion@gmail.com; helo=mail-qv1-xf29.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Christopher Rodriguez X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --- gnu/packages/bqn.scm | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/gnu/packages/bqn.scm b/gnu/packages/bqn.scm index 53e2f0a057..221ed9eaaa 100644 --- a/gnu/packages/bqn.scm +++ b/gnu/packages/bqn.scm @@ -90,3 +90,38 @@ (define-public dbqn (description "BQN implementation based on dzaima/APL.") (home-page "https://github.com/dzaima/BQN") (license license:expat)))) +(define bqn-bytecode-sources + (let* ((tag "0") + (revision "1") + (commit "e219af48401473a7bac49bdd8b89d69082cf5dd8") + (hash "0r6pa9lscl2395g4xlvmg90vpdsjzhin4f1r0s7brymmpvmns2yc") + (version (git-version tag revision commit))) + (package + (name "bqn-bytecode-sources") + (version version) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/mlochbaum/BQN") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + hash)))) + (outputs '("out")) + (build-system copy-build-system) ;This package pulls down needed source + ;; files for CBQN's build process. They + ;; will be compiled during that build; + ;; none of them are prebuilt binaries. + (arguments + (list #:install-plan '(list (list "src/" "share/src" + #:exclude '("README.txt" "doc/")) + (list "test/" "share/test" + #:exclude '("README.txt"))))) + (synopsis "Official BQN sources in BQN") + (description + "The collection of sources needed for building a +BQN-based BQN implementation. These are included here for bootstrapping +purposes.") + (home-page "https://github.com/mlochbaum/BQN.git") + (license license:gpl3)))) -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 03:16:07 2022 Received: (at control) by debbugs.gnu.org; 5 Aug 2022 07:16:07 +0000 Received: from localhost ([127.0.0.1]:55983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJrZ0-0001tz-7o for submit@debbugs.gnu.org; Fri, 05 Aug 2022 03:16:06 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:1071) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJrYt-0001t8-LN; Fri, 05 Aug 2022 03:16:03 -0400 Received: from lprikler-laptop.ist.intra (gw.ist.tugraz.at [129.27.202.101]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4LzcMF4HWkz1LXt0; Fri, 5 Aug 2022 09:15:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4LzcMF4HWkz1LXt0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1659683754; bh=rnG4PBMsdlXDXd44cQmQDWSyFfJ5M8qELxKCMCO5DdM=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=eFIj+cBNt7iqEuAuEs462PfNSPGo32JfFD+aAzPDw89OyjVEJzQA200QLMmyEuyzg Mdl3T3zQ8S78gbCjXdi8rDLWQIdAYTWf2DmjklBVmGUVL9D4SJjlqoFtKf2xoQxrLS vOYvs/LZnFH9+4oAigREJLhSSmiwm6zMKT4B2WME= Message-ID: <7742c07ce28494af40c74262277417e60fe6f500.camel@ist.tugraz.at> Subject: Re: [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package. From: Liliana Marie Prikler To: Christopher Rodriguez , 56989@debbugs.gnu.org Date: Fri, 05 Aug 2022 09:15:52 +0200 In-Reply-To: <20220805054616.30620-1-yewscion@gmail.com> References: <20220805054616.30620-1-yewscion@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: waObeELIUl4ypBWmcn/8wQ X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control Cc: control@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) merge 56989 56990 56991 56992 56993 thanks Regarding the patch title, just one level of grouping is enough. That is, use "gnu: Add dbqn." Also, you're missing a ChangeLog, i.e. * gnu/packages/bqn.scm: New file. * gnu/local.mk (GNU_SYSTEM_MODULES): Register it here. Note that the second change is lacking from your patch. Am Freitag, dem 05.08.2022 um 01:46 -0400 schrieb Christopher Rodriguez: > Thanks to some help from upstream and on IRC (thanks, dzaima and > lilyp!) I > was able to remove the non-determinism issue. Here's an updated > patch. > > --- >  gnu/packages/bqn.scm | 102 > +++++++++++++++++++++++++++++++++++++++++++ >  1 file changed, 102 insertions(+) >  create mode 100644 gnu/packages/bqn.scm > > diff --git a/gnu/packages/bqn.scm b/gnu/packages/bqn.scm > new file mode 100644 > index 0000000000..261f29ece5 > --- /dev/null > +++ b/gnu/packages/bqn.scm > @@ -0,0 +1,102 @@ > +(define-module (gnu packages bqn) > +  #:use-module ((guix licenses) #:prefix license:) > +  #:use-module (guix gexp) > +  #:use-module (guix packages) > +  #:use-module (guix download) > +  #:use-module (guix git-download) > +  #:use-module (guix build-system copy) > +  #:use-module (guix build-system gnu) > +  #:use-module (guix utils) > +  #:use-module (guix deprecation) > +  #:use-module (gnu packages) > +  #:use-module (gnu packages libffi) > +  #:use-module (gnu packages base) > +  #:use-module (gnu packages pkg-config) > +  #:use-module (gnu packages llvm) > +  #:use-module (gnu packages java) > +  #:use-module (gnu packages compression)) > +(define-public dbqn > +  (let* ((tag "0.2.1") > +         (revision "1") > +         (commit "0bbe096fc07d278b679a8479318f1722d096a03e") > +         (hash > "1kxzxz2hrd1871281s4rsi569qk314aqfmng9pkqn8gv9nqhmph0") > +         (version (git-version tag revision commit))) Don't let-bind tag, version and hash, use them inline. > +    (package > +      (name "dbqn") > +      (version version) > +      (source (origin > +                (method git-fetch) > +                (uri (git-reference > +                      (url "https://github.com/dzaima/BQN") > +                      (commit commit))) > +                (file-name (git-file-name name version)) Note that version will be bound here even if you use the version field to do so. > +                (sha256 > +                 (base32 > +                  hash)))) > +      (outputs '("out")) > +      (build-system gnu-build-system) > +      (arguments > +       (list #:tests? #f ;While there is a "test" directory, there > is no > +             ;; mechanism to run the tests other than to feed the > files into the > +             ;; binary and check for an error. This is outside the > scope of a > +             ;; packaging workflow, and would need to be fixed > upstream > +             ;; instead. Issue Reported: > https://github.com/dzaima/BQN/issues/12 > +             ;; Maintainer says many of the tests fail, and so they > will remain off > +             ;; until this is sorted out. You could do (replace 'check (lambda* (#:key tests? #:allow-other-keys) (when tests? (for-each (lambda (known-good-test) (invoke my-glorious-bin known-good-test)) known-good-tests)))) FSVO my-glorious-bin and known-good-tests. > +             #:imported-modules `(,@%gnu-build-system-modules (guix > build > +                                                                    > syscalls) > +                                  (guix build ant-build-system)) > +             #:modules `((guix build gnu-build-system) > +                         ((guix build ant-build-system) > +                          #:prefix ant:) > +                         (guix build utils)) > +             #:phases #~(modify-phases %standard-phases > +                          (delete 'configure) > +                          (replace 'build > +                            (lambda* _ > +                              (invoke "./build"))) > +                          (add-after 'build 'strip-jar-timestamps > +                            (lambda* (#:key outputs #:allow-other- > keys) > +                              (write %standard-phases))) > +                          (replace 'install > +                            (lambda* (#:key outputs #:allow-other- > keys) > +                              (let* ((out (assoc-ref outputs "out")) > +                                     (dest-bin (string-append out > "/bin")) > +                                     (dest-jar (string-append out > +                                                              > "/share/java"))) > +                                (mkdir-p dest-bin) > +                                (mkdir-p dest-jar) > +                                (copy-recursively "BQN" > +                                                  (string-append > dest-bin > +                                                                 > "/dbqn")) > +                                (chmod (string-append dest-bin > "/dbqn") 493) > +                                (install-file "BQN.jar" dest-jar)))) > +                          (add-after 'install 'subjars > +                            (lambda* (#:key outputs #:allow-other- > keys) > +                              (let* ((out (assoc-ref outputs "out")) > +                                     (dest-bin (string-append out > "/bin")) > +                                     (dest-jar (string-append out > +                                                              > "/share/java"))) > +                                (substitute* (string-append dest-bin > "/dbqn") > +                                  (("BQN.jar") > +                                   (string-append dest-jar > "/BQN.jar")))))) Could this be done in/before install? > +                          (add-after 'subjars 'reorder-jar-content > +                            (lambda* (#:key outputs #:allow-other- > keys) > +                              (apply (cdr (assoc 'reorder-jar- > content > +                                                 ant:%standard- > phases)) > +                                     #:outputs (list outputs)))) You can use #:rest args to bind args for apply. Also use assoc-ref rather than cdr + assoc. > +                          (add-after 'reorder-jar-content 'jar- > indices > +                            (lambda* (#:key outputs #:allow-other- > keys) > +                              (apply (cdr (assoc 'generate-jar- > indices > +                                                 ant:%standard- > phases)) > +                                     #:outputs (list outputs)))) > +                          (add-after 'jar-indices 'fix-jar- > timestamps > +                            (lambda* (#:key outputs #:allow-other- > keys) > +                              (apply (cdr (assoc 'reorder-jar- > content > +                                                 ant:%standard- > phases)) > +                                     #:outputs (list outputs))))))) > +      (native-inputs (list `(,openjdk17 "jdk") coreutils zip)) Is OpenJDK 17 required? > +      (synopsis "BQN implementation based on dzaima/APL") > +      (description "BQN implementation based on dzaima/APL.") > +      (home-page "https://github.com/dzaima/BQN") > +      (license license:expat)))) Cheers From unknown Fri Jun 20 19:53:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 29 Sep 2022 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator