Package: guix-patches;
Reported by: Christopher Rodriguez <yewscion <at> gmail.com>
Date: Fri, 5 Aug 2022 02:21:02 UTC
Severity: normal
Tags: patch
Merged with 56990, 56991, 56992, 56993
Done: Ludovic Courtès <ludo <at> gnu.org>
Bug is archived. No further changes may be made.
Message #40 received at 56989 <at> debbugs.gnu.org (full text, mbox):
From: Liliana Marie Prikler <liliana.prikler <at> gmail.com> To: Christopher Rodriguez <yewscion <at> gmail.com>, 56989 <at> debbugs.gnu.org Subject: Re: [PATCH v3] gnu: Add dbqn. Date: Sun, 07 Aug 2022 18:28:14 +0200
Am Freitag, dem 05.08.2022 um 22:20 -0400 schrieb Christopher
Rodriguez:
> * gnu/packages/bqn.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Registered it here.
Don't know if that's just my preference or everyone's, but I like
present tense.
> ---
> gnu/local.mk | 1 +
> gnu/packages/bqn.scm | 89
> ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 90 insertions(+)
> create mode 100644 gnu/packages/bqn.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 0e8b7b0447..c3f4cc782c 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -138,6 +138,7 @@ GNU_SYSTEM_MODULES
> = \
> %D%/packages/boost.scm \
> %D%/packages/bootloaders.scm \
> %D%/packages/bootstrap.scm \
> + %D%/packages/bqn.scm \
> %D%/packages/browser-extensions.scm \
> %D%/packages/build-tools.scm \
> %D%/packages/busybox.scm \
> diff --git a/gnu/packages/bqn.scm b/gnu/packages/bqn.scm
> new file mode 100644
> index 0000000000..456983f71f
> --- /dev/null
> +++ b/gnu/packages/bqn.scm
> @@ -0,0 +1,89 @@
> +(define-module (gnu packages bqn)
> + #:use-module ((guix licenses) #:prefix license:)
> + #:use-module (guix gexp)
> + #:use-module (guix packages)
> + #:use-module (guix download)
> + #:use-module (guix git-download)
> + #:use-module (guix build-system copy)
> + #:use-module (guix build-system gnu)
> + #:use-module (guix utils)
> + #:use-module (guix deprecation)
> + #:use-module (gnu packages)
> + #:use-module (gnu packages libffi)
> + #:use-module (gnu packages base)
> + #:use-module (gnu packages pkg-config)
> + #:use-module (gnu packages llvm)
> + #:use-module (gnu packages java)
> + #:use-module (gnu packages compression))
> +(define-public dbqn
> + (let ((commit "0bbe096fc07d278b679a8479318f1722d096a03e")
> + (revision "1"))
> + (package
> + (name "dbqn")
> + (version (git-version "0.2.1" revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/dzaima/BQN")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> +
> "1kxzxz2hrd1871281s4rsi569qk314aqfmng9pkqn8gv9nqhmph0"))))
> + (outputs '("out"))
> + (build-system gnu-build-system)
> + (arguments
> + (list #:imported-modules `(,@%gnu-build-system-modules (guix
> build
> +
> syscalls)
Put #:imported modules on a new line, same for (guix build syscalls).
> + (guix build ant-build-system))
> + #:modules `((guix build gnu-build-system)
> + ((guix build ant-build-system)
> + #:prefix ant:)
> + (guix build utils))
> + #:phases #~(modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'build
> + (lambda* _
> + (invoke "./build")))
> + (replace 'check
> + (lambda* (:#key tests?
> + #:allow-other-tags)
> + (when tests?
> + (chmod "./BQN" 493)
Use octal notation for chmod.
> + (system "./BQN ./test/test"))))
> + (add-after 'install 'reorder-jar-content
> + (lambda* (#:key outputs #:allow-other-
> keys)
> + (apply (assoc-ref ant:%standard-phases
> + 'reorder-jar-
> content)
> + #:outputs (list outputs))))
> + (add-after 'reorder-jar-content 'jar-
> indices
> + (lambda* (#:key outputs #:allow-other-
> keys)
> + (apply (assoc-ref ant:%standard-phases
> + 'generate-jar-
> indices)
> + #:outputs (list outputs))))
> + (add-after 'jar-indices 'fix-jar-
> timestamps
> + (lambda* (#:key outputs #:allow-other-
> keys)
> + (apply (assoc-ref ant:%standard-phases
> + 'reorder-jar-
> content)
> + #:outputs (list outputs))))
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-
> keys)
> + (let* ((out (assoc-ref outputs "out"))
> + (dest-bin (string-append out
> "/bin"))
> + (dest-jar (string-append out
> +
> "/share/java")))
> + (mkdir-p dest-bin)
> + (mkdir-p dest-jar)
> + (copy-recursively "BQN"
> + (string-append
> dest-bin
> +
> "/dbqn"))
> + (chmod (string-append dest-bin
> "/dbqn") 493)
> + (install-file "BQN.jar" dest-jar)
> + (substitute* (string-append dest-bin
> "/dbqn")
> + (("BQN.jar")
> + (string-append dest-jar
> "/BQN.jar")))))))))
Other than that LGTM modulo not having tested anything as of yet.
Cheers
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.