From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 21:37:33 2022 Received: (at submit) by debbugs.gnu.org; 5 Aug 2022 01:37:33 +0000 Received: from localhost ([127.0.0.1]:55438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJmHM-0005Bn-LX for submit@debbugs.gnu.org; Thu, 04 Aug 2022 21:37:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:33880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJmHJ-0005Bf-Td for submit@debbugs.gnu.org; Thu, 04 Aug 2022 21:37:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40118) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJmHJ-00087w-NQ for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 21:37:29 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]:33783) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJmHI-0000XS-5L for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 21:37:29 -0400 Received: by mail-pg1-x52f.google.com with SMTP id l64so1477718pge.0 for ; Thu, 04 Aug 2022 18:37:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc; bh=G9sG/uH+ZpX1nmqgFBffgNyj32+GRlhdSip1kyttixE=; b=O4o7yTEevvooJs1WhqCOVCQ28DYSESseOv3TV7sSLbn20HZhOCRwK2abFSd57OaehK 34NGCvN0zw8E8btaCPKAlQ6/iUE01HkptJLMQbwfuB4L/NmBb6DWFq4J1r8ALZi15OpC y81PN2wnfKFYoxX0Mxi2WZVFn8QrY+TWest0iNNc30FuUg0PsFxdkLOBToeuhYIKGVy0 QEp/12ZEq10luyvB8I//otrym7Id98n3EY07/sFKcrS3msc196Ea528vuj2Hk5XKLU1O BJXYNPHbOFD6Gd20RL7000d3B0WkB0EMdvuar1+sU8DMQ0AdR0FzHd5tf1sMA49H7maH vNEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc; bh=G9sG/uH+ZpX1nmqgFBffgNyj32+GRlhdSip1kyttixE=; b=qlvng8UbpPuhz51WZBiVeajAt+E7RIIKcf2GT1VK+MwBWitiUqVzVkXyEth6cqz/2L BY+6LXl8jcWhTCrJfc4+sZ3bg4S4G6qqP+cD/61Wdrw9BKG9TOPK0ib3atzpBRXLdx/a Vc0KxROSP8k5l8w85sUB9TUSfvFOqMML911G8te9xkfWZ9T3mBHZT1idm/9IosMCGW89 UciBijWQrSFnAKYPiR12aafEnlxKdBHF42BStahn3lhyyXTYrdboRFTi+dBOWTMikYQR +VaLFWIa30W5VIvEDrCQ/cHOoeNAI+DrR5WePiE3Bb955twrdHUC2+FgNNGHsaKEQtJR CGZw== X-Gm-Message-State: ACgBeo2tZRmejt0n7bsFSDdD3F2oOrI9PsfS5KsEyRlRM3qy+xwl7yef f+CvAmfjhHSlGMo2NOS4y50G6Hni328sw49T6BISZO6q X-Google-Smtp-Source: AA6agR5AS3Dn3VdyRW+kQEmvrVoYpmbJQ7XTm1j9a5Xq27GJoiwKJFbgGGzT8BVAO8WuRpLm9zEfSs/3rmj/DWObWuA= X-Received: by 2002:aa7:8892:0:b0:52e:14cb:7e67 with SMTP id z18-20020aa78892000000b0052e14cb7e67mr4435571pfe.35.1659663445366; Thu, 04 Aug 2022 18:37:25 -0700 (PDT) MIME-Version: 1.0 From: Lynn Winebarger Date: Thu, 4 Aug 2022 21:37:13 -0400 Message-ID: Subject: Add call-interactively to "never optimize" list for native compilation To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="0000000000001b9a3905e574829e" Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=owinebar@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --0000000000001b9a3905e574829e Content-Type: text/plain; charset="UTF-8" Version 28.1: Since dumping an Emacs with ~500 core libraries in addition to the 100+ from loadup (596 NCUs in the dump), I noticed huge numbers of async jobs compiling trampolines for call-interactively. Adding call-interactively - and funcall-interactively for good measure - to the customization variable for functions to never optimize, as well as to the hard-coded list in advice--add-function, then recompiling and dumping resolved the issue. Lynn --0000000000001b9a3905e574829e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Version 28.1:
Since dumping an Ema= cs with ~500 core libraries in addition to the 100+ from loadup (596 NCUs i= n the dump), I noticed huge numbers of async jobs compiling trampolines for= call-interactively.=C2=A0 Adding call-interactively - and funcall-interact= ively for good measure - to the customization variable for functions to nev= er optimize, as well as to the hard-coded list in advice--add-function, the= n recompiling and dumping resolved the issue.

Lynn

--0000000000001b9a3905e574829e-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 06:07:49 2022 Received: (at 56988) by debbugs.gnu.org; 5 Aug 2022 10:07:49 +0000 Received: from localhost ([127.0.0.1]:56308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJuFB-0000Fs-IA for submit@debbugs.gnu.org; Fri, 05 Aug 2022 06:07:49 -0400 Received: from mx.sdf.org ([205.166.94.24]:60698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJuF9-0000Fj-DB for 56988@debbugs.gnu.org; Fri, 05 Aug 2022 06:07:48 -0400 Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 275A7koS029570 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 5 Aug 2022 10:07:46 GMT From: Andrea Corallo To: Lynn Winebarger Subject: Re: bug#56988: Add call-interactively to "never optimize" list for native compilation References: Date: Fri, 05 Aug 2022 10:07:46 +0000 In-Reply-To: (Lynn Winebarger's message of "Thu, 4 Aug 2022 21:37:13 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 56988 Cc: 56988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lynn Winebarger writes: > Version 28.1: > Since dumping an Emacs with ~500 core libraries in addition to the 100+ from loadup (596 NCUs in the dump), I noticed > huge numbers of async jobs compiling trampolines for call-interactively. Adding call-interactively - and > funcall-interactively for good measure - to the customization variable for functions to never optimize, as well as to the > hard-coded list in advice--add-function, then recompiling and dumping resolved the issue. Hi Lynn, I think we want to keep on optimizing `call-interactively' as changing this policy this could have a negative performance impact in certain scenarios. Perhaps should be investigated why on the process you are engineering this is happening, and modify it so that only one trampoline is compiled. Best Regards Andrea From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 08:13:47 2022 Received: (at 56988) by debbugs.gnu.org; 5 Aug 2022 12:13:47 +0000 Received: from localhost ([127.0.0.1]:56515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJwD4-0005w5-UR for submit@debbugs.gnu.org; Fri, 05 Aug 2022 08:13:47 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:54076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJwD2-0005vk-K4 for 56988@debbugs.gnu.org; Fri, 05 Aug 2022 08:13:45 -0400 Received: by mail-pj1-f54.google.com with SMTP id pm17so2584542pjb.3 for <56988@debbugs.gnu.org>; Fri, 05 Aug 2022 05:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=4A6RecBL3OHh7BwxN5Yug9KVgF0n0toq9szTDbOgbpc=; b=H7JxruwVJwbGOeS8P+tfvlIQB19pEGR1uHc1R63u9GsAjBFYPKdKlyrgky0ymcSwf/ f1HUW7cN++pjt6fqnTgimC0NRvY1mXTQtLCOcpuSUTOwR3VNqys2QXXjhJKhRbgSuAYs fDLZI5P1DJ/TUT2mG2wbE4wtuhmO74QtDx0xTO2f6JmLJnDSUMvQDpuIMooDuv3PscHc n7JehbEyRzzoeKGOPStj6UtH3dDNqGF7+c0MLc/70QO2zFF69xGUzl+c8JAytKoBCa+G 9jzZ84LbgLxH0iKTdsCD5RWj/ZlcKsEQxNX0gQxNdasVozCH9t48vHmkfvJNtzRA5t1d aX+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=4A6RecBL3OHh7BwxN5Yug9KVgF0n0toq9szTDbOgbpc=; b=cAGljEdVWP+ha62RwuL93yyzqRD5adGyx05TNTL/CUAoGCCKUTXuMcCiCWW+8jqnRG n3rkWBazV/hYuVb0xWA9yWBzxHoOQRXDO+4jlN5Ajgs4V5zcbyhgwoWLdiGbsOvkYbom JmNP7KnoZJzBVHrk4xIbNhDPo3KMVI9iRRxpalVA+2OuQdSoIRlrnn7s4qfXE/hd7Idn VAjpuL6Xw8u4k48XCmTZdwFmTvoLick34Q4AttLoSESdR1uOMHJGCDkbO1dUVECwxn70 3Q7khmHumvU/rWVwpMcmtxO7e30HxJwKZlshvfLRrh8HIT4b42OBeB1ckfWjEEimRiAg xUZA== X-Gm-Message-State: ACgBeo3XJ8hioyA0Dd6yIXy53J7cofdt88FRxP0ftuaGBu9ODgzTQr4i pVjQOreNQWZvcE9BABojAfVZuigtHIORRPCpv6w= X-Google-Smtp-Source: AA6agR5tblex5Xb23d5qcUIcrTd7Z5D73Hu6F7tR9uFfiuvkCP/Zn4PuhvWZ8FDBYEwTqePsnvZ5HHCWKnqWGxptQBA= X-Received: by 2002:a17:902:900c:b0:16d:28ad:29e1 with SMTP id a12-20020a170902900c00b0016d28ad29e1mr6419055plp.93.1659701618689; Fri, 05 Aug 2022 05:13:38 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Lynn Winebarger Date: Fri, 5 Aug 2022 08:13:26 -0400 Message-ID: Subject: Re: bug#56988: Add call-interactively to "never optimize" list for native compilation To: Andrea Corallo Content-Type: multipart/alternative; boundary="0000000000006a4a1905e57d6592" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56988 Cc: 56988@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000006a4a1905e57d6592 Content-Type: text/plain; charset="UTF-8" On Fri, Aug 5, 2022, 6:07 AM Andrea Corallo wrote: > Lynn Winebarger writes: > > > Version 28.1: > > Since dumping an Emacs with ~500 core libraries in addition to the 100+ > from loadup (596 NCUs in the dump), I noticed > > huge numbers of async jobs compiling trampolines for > call-interactively. Adding call-interactively - and > > funcall-interactively for good measure - to the customization variable > for functions to never optimize, as well as to the > > hard-coded list in advice--add-function, then recompiling and dumping > resolved the issue. > > Hi Lynn, > > I think we want to keep on optimizing `call-interactively' as changing > this policy this could have a negative performance impact in certain > scenarios. > > Perhaps should be investigated why on the process you are engineering > this is happening, and modify it so that only one trampoline is > compiled. Isn't call-interactively only used in the context of requesting user input? That would seem unlikely to benefit from optimization. Something in one those additional core libraries being dumped is adding advice to call-interactively. One of the ways it started is by opening customize on a group that autoloads a library that hasn't been native compiled. That starts the async process for the compiler. This will happen just running emacs with whatever library is advising call-interactively in a problematic way in the dump. It's not part of my build process unless I use one of those builds with the additional libraries as the compiler. I'm noting it as a bug because it will bite anyone who includes these additional libraries in the dump as a regular user, not because it impacts my build process. I know that's not frequently the case now, but it should be eventually. Lynn --0000000000006a4a1905e57d6592 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Aug 5, 2022, 6:07 AM Andrea Corallo <akrl@sdf.org> wrote:
Lynn Winebarger <owinebar@gmail.com> writes:

> Version 28.1:
> Since dumping an Emacs with ~500 core libraries in addition to the 100= + from loadup (596 NCUs in the dump), I noticed
> huge numbers of async jobs compiling trampolines for call-interactivel= y.=C2=A0 Adding call-interactively - and
> funcall-interactively for good measure - to the customization variable= for functions to never optimize, as well as to the
> hard-coded list in advice--add-function, then recompiling and dumping = resolved the issue.

Hi Lynn,

I think we want to keep on optimizing `call-interactively' as changing<= br> this policy this could have a negative performance impact in certain
scenarios.

Perhaps should be investigated why on the process you are engineering
this is happening, and modify it so that only one trampoline is
compiled.

Isn't call-interactively only used in the context of requesting us= er input?=C2=A0 That would seem unlikely to benefit from optimization.
Something in one those additional core libraries being d= umped is adding advice to call-interactively.=C2=A0 One of the ways it star= ted is by opening customize on a group that autoloads a library that hasn&#= 39;t been native compiled.=C2=A0 That starts the async process for the comp= iler.=C2=A0 This will happen just running emacs with whatever library is ad= vising call-interactively in a problematic way in the dump.=C2=A0 It's = not part of my build process unless I use one of those builds with the addi= tional libraries as the compiler.=C2=A0=C2=A0
I'= m noting it as a bug because it will bite anyone who includes these additio= nal libraries in the dump as a regular user, not because it impacts my buil= d process.=C2=A0 I know that's not frequently the case now, but it shou= ld be eventually.

Lynn

--0000000000006a4a1905e57d6592-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 08:18:58 2022 Received: (at 56988) by debbugs.gnu.org; 5 Aug 2022 12:18:58 +0000 Received: from localhost ([127.0.0.1]:56532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJwI5-0008E7-PY for submit@debbugs.gnu.org; Fri, 05 Aug 2022 08:18:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJwI4-0008Dv-9Q for 56988@debbugs.gnu.org; Fri, 05 Aug 2022 08:18:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZnSBw1/NmXW3tVTWyk0kMcp1rPKI+4m5v46Sb8xPwBs=; b=ElcCCzDpFCsw0ex9+nngUQou8F brz6J1GELjHbOL88dLQpz7P0/fUuZSFwCR6N3xd+Sf2qMsMY6TqFIDb5FkvOhCqjdDlYmz0e+WUNN ZGCYWE2Uwb1ihZjwbqEaHLdtHOCSxjUBDlmicHXPcthZzA5RrCkEJ8xQGpIKKPnWPfyM=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJwHv-0001DF-Kw; Fri, 05 Aug 2022 14:18:49 +0200 From: Lars Ingebrigtsen To: Lynn Winebarger Subject: Re: bug#56988: Add call-interactively to "never optimize" list for native compilation In-Reply-To: (Lynn Winebarger's message of "Fri, 5 Aug 2022 08:13:26 -0400") References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEX6+vvS0dTd3eGi oaS+vcExMDAgHh9eXl9+foA/PT7////viaxHAAAAAWJLR0QKaND0VgAAAAd0SU1FB+YIBQsuNC2B +7QAAAGpSURBVDjLtZNLTuQwEIYdwwFiJwewq5HY0hRShh3pDINYgpSOWI96ejtRgkxOwAFQhHJb yq80dLMAaeZfZOHPfz1SZcb+vRKQXEj4BEiphTgEWmopQWixDzjdl+Izy/9VgkEXKTtJla3El7Co 15s/pM221M/llQW+6KOhnsaa1GdFx33xzlBM02TP67YyqHYpru3ZekOfrmgMMIg9XrswpAZN3fMk BVBqdngw1J3KgXMF78A0micCIBTnUuxAYyZjhm2vcwuc45evCC+HcfPSCzED5zApOx5fMWtLqYDG Eh2tvXKTskX704E8gG1s6xQvgICO4Hcc4y0ugaRlAHfxP99U0gIIjvV9dFSoKZSCbB9knXahyhBq BrACmxyW+znOSw6K70Cs6rhFZoHG2EcARy+PlDrRAuM8QoMLg4I6j2Aa1389yLrEdijyCOpGkgdk JvWPTuocA6BV6BXj+ZVmIsGVqAIwBB7O/JadpLqs8LmbQd2cu3Wit4NojPFgsKN6MIjFMqEwxUfg J7+q3PkBeO0zG+gAuHAzSKjTKDcmeoryiy8Ivg2+pjee+49Hiyd05QAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMi0wOC0wNVQxMTo0Njo1MiswMDowMHMVS5oAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjIt MDgtMDVUMTE6NDY6NTIrMDA6MDACSPMmAAAAAElFTkSuQmCC X-Now-Playing: Keith Jarrett's _The =?utf-8?Q?K=C3=B6ln?= Concert_: "Part II a" Date: Fri, 05 Aug 2022 14:18:47 +0200 Message-ID: <87a68iano8.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lynn Winebarger writes: > Isn't call-interactively only used in the context of requesting user > input? That would seem unlikely to benefit from optimization. Some interactive specs are pretty involved, and definitely benefit from being compiled, so we're not going to stop doing that. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56988 Cc: 56988@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lynn Winebarger writes: > Isn't call-interactively only used in the context of requesting user > input? That would seem unlikely to benefit from optimization. Some interactive specs are pretty involved, and definitely benefit from being compiled, so we're not going to stop doing that. From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 08:34:03 2022 Received: (at 56988) by debbugs.gnu.org; 5 Aug 2022 12:34:03 +0000 Received: from localhost ([127.0.0.1]:56601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJwWh-0000Gy-4y for submit@debbugs.gnu.org; Fri, 05 Aug 2022 08:34:03 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:47082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJwWf-0000GU-GF for 56988@debbugs.gnu.org; Fri, 05 Aug 2022 08:34:02 -0400 Received: by mail-pl1-f173.google.com with SMTP id p8so2487360plq.13 for <56988@debbugs.gnu.org>; Fri, 05 Aug 2022 05:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=pfizHDXN12R8qj20jv9lcQDA8uVw6ya3f4IAMMQ0V6k=; b=I+YkTIz5hva0fyhif2uA0zrA0TfzJ/SMCcddZzyDtAwe8DnE2lDc+9DBxLQBEhgBN9 rxLepUM6CCbPPu6WKGGVd0Yi10S9dGIPS9u2c582jrMsP0dGPW3CCAU3QILUXTJwXO/a f6vkan4Pwlbt/NnAKyBeJBlLccrjAET/vkGDQdTKYhHluv+pXClK6CkflMh1EXJPBK6R tE+wOaJQuZveUAOGhe6JsKjHeVJIGIJRvrAQY1ZQwfhZK2h3OOuk/UMfs6O+z/E+Y2AY 4RLJBRxjGaGlNZ+sEELCffFja28WdU9+dXaBPx+wGgi7uqpGNqynLvd4xT7myuiQci8/ 412Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=pfizHDXN12R8qj20jv9lcQDA8uVw6ya3f4IAMMQ0V6k=; b=4s+qFnSTR27ZI6UVuX+AYLgc8/eoYESDBdV+fZJhT8Z0MWq2fj0SpCMAsioMrzEesk CCMgf0Oin+E4z/aef9agE3MCtSTRuydC/PR1MlVoO/mhYjvfHamMV9oZfR5zVr0nv1// EqyIAmvSYLh5s7wqPonjTphRoGy5F0Ne04jQZsfo7KM9KdwI0YffgagoZtsQzYmQlByr SmDW3HXqtUdbIiHS94ph5JnAfSZgAO6xVY89bGip4Pr8RQi5mRj5V6auqXQ50YhZ06S8 cRTbXb5AQAzs4l8y8gwquwNcGhoPu4ezJKHE1p/B/auxL2t15J/bAUe2WzrrN1ZZHutL 4xUw== X-Gm-Message-State: ACgBeo0GN/KW6ExJO1DahsNTfpFUz8qBNymEdkiHjYViGS3LzPJdjxix 6TVYd4F20VSeBtpjRjhlyHlr4dolkvF6hd5UJAA= X-Google-Smtp-Source: AA6agR7RrbDJklRvJvWtkF1MPbbm318Wj/PRjGCsVZm7oFR/QNh2SQfHfyw+L/gxrJ8kHvQQNhZ/ENAbOoScQIIFbOE= X-Received: by 2002:a17:90a:2948:b0:1f3:1b42:a810 with SMTP id x8-20020a17090a294800b001f31b42a810mr7634870pjf.203.1659702835499; Fri, 05 Aug 2022 05:33:55 -0700 (PDT) MIME-Version: 1.0 References: <87a68iano8.fsf@gnus.org> In-Reply-To: <87a68iano8.fsf@gnus.org> From: Lynn Winebarger Date: Fri, 5 Aug 2022 08:33:42 -0400 Message-ID: Subject: Re: bug#56988: Add call-interactively to "never optimize" list for native compilation To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="000000000000f1563405e57dad7a" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56988 Cc: 56988@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f1563405e57dad7a Content-Type: text/plain; charset="UTF-8" On Fri, Aug 5, 2022, 8:18 AM Lars Ingebrigtsen wrote: > Lynn Winebarger writes: > > > Isn't call-interactively only used in the context of requesting user > > input? That would seem unlikely to benefit from optimization. > > Some interactive specs are pretty involved, and definitely benefit from > being compiled, so we're not going to stop doing that. > Maybe it's only an issue in the "advice" case? I can try removing it from the customization variable but leave it in the hard coded list in the advice--add-function code, if that would make a difference. Lynn --000000000000f1563405e57dad7a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Aug 5, 2022, 8:18 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Lynn Winebarger <owinebar@gmail.com> writes:
> Isn't call-interactively only used in the context of requesting us= er
> input?=C2=A0 That would seem unlikely to benefit from optimization.
Some interactive specs are pretty involved, and definitely benefit from
being compiled, so we're not going to stop doing that.
=

Maybe it's on= ly an issue in the "advice" case?=C2=A0 I can try removing it fro= m the customization variable but leave it in the hard coded list in the adv= ice--add-function code, if that would make a difference.

Lynn

--000000000000f1563405e57dad7a-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 07 07:32:48 2022 Received: (at 56988) by debbugs.gnu.org; 7 Aug 2022 11:32:48 +0000 Received: from localhost ([127.0.0.1]:36081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKeWV-0002sx-Vm for submit@debbugs.gnu.org; Sun, 07 Aug 2022 07:32:48 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:47075) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oKeWQ-0002sT-By for 56988@debbugs.gnu.org; Sun, 07 Aug 2022 07:32:44 -0400 Received: by mail-pj1-f54.google.com with SMTP id q7-20020a17090a7a8700b001f300db8677so6705594pjf.5 for <56988@debbugs.gnu.org>; Sun, 07 Aug 2022 04:32:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=fUu1PwoUGEtz9lEwz0bQlsZ0ffvC2KYh+bVuXYHYZTQ=; b=YCSB8T2NIeLyR7v4MLsyFeUIT1/d5Sp9opi2Kb2WmH1NZG+wM6TD660xFc//qmurkO k90BfU00nGkCIr2nL+v1l+GJS2mE409BQ2ONHZhZdGO0hxrgELSjVvpv9k8q5KXNLR4n pJPkYdYFmiRXGPFU+kZNXw2LlBbHhw/9gjrn+LeISiC8bO+2YCyoXB4hnZSaDEJ9GGv/ 0n1E00ihWjU/MGiaiHckuMfDreiLpYuhNH3pISihuvHSK2e2N7pAukRHOWMhOks6Hu+G emuZp4+0cZcsWpnOZqMBPRoPklxdUnhSmz6kHwzEmIApyZMmV4wbJVmc/9nfYSE7E/xd Tsww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=fUu1PwoUGEtz9lEwz0bQlsZ0ffvC2KYh+bVuXYHYZTQ=; b=zD6h+PFijuLDoOkwMwr1pBy0ttZB3b5hGJq7vM2rvO+aPyx97mfoY96uw4chAIwhtO W2hxK2MTmSyeys0F2jMnB5bJ1pt5cHa4cyuox6tkEQjga4SeeyR1+3amJEBlf4A+PW5k 6sToouXCVRfRBnqV0EE0i6pee7a9/zZFOGeEOdXtXW72Lra6pbJ4rzGVoSZ/uTWNMWeg xp1y9UoT5TYJxjeUzimv04LWwKyHOxo5FipPIDAaL2o0DulbjDpb2zMYSGtHK587ixvg tw6AvTI/4MuJDhfO8ug06Mt1qt61XVlbjHBIEQFsnjr8NpLESvZ9g97jYWKOrDiv+WRj EPgg== X-Gm-Message-State: ACgBeo2QHZiEeWaRXWn3/NZcDBW2cfexTl9Tz+wJrCjdv4IM0oBKDZqG 1b78OllBbgnUbm/5dOctDRHTchFfIPkPBWIpV88= X-Google-Smtp-Source: AA6agR4EyCy4mYcRnj3i03Trac4Zv/zjqMdh6lBU9w37PZO8GUbIZBf4rqyBgLeSKWwnGJNBVjcHDoZO81XQbzPhUfc= X-Received: by 2002:a17:90a:2948:b0:1f3:1b42:a810 with SMTP id x8-20020a17090a294800b001f31b42a810mr16372369pjf.203.1659871956465; Sun, 07 Aug 2022 04:32:36 -0700 (PDT) MIME-Version: 1.0 References: <87a68iano8.fsf@gnus.org> In-Reply-To: <87a68iano8.fsf@gnus.org> From: Lynn Winebarger Date: Sun, 7 Aug 2022 07:32:24 -0400 Message-ID: Subject: Re: bug#56988: Add call-interactively to "never optimize" list for native compilation To: Lars Ingebrigtsen Content-Type: multipart/alternative; boundary="000000000000567e8905e5a50eb6" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56988 Cc: 56988@debbugs.gnu.org, Andrea Corallo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000567e8905e5a50eb6 Content-Type: text/plain; charset="UTF-8" On Fri, Aug 5, 2022, 8:18 AM Lars Ingebrigtsen wrote: > Lynn Winebarger writes: > > > Isn't call-interactively only used in the context of requesting user > > input? That would seem unlikely to benefit from optimization. > > Some interactive specs are pretty involved, and definitely benefit from > being compiled, so we're not going to stop doing that. Another possibility would be to ensure there is a standard pdmp file to use for compiling, regardless of what is being used for the session calling the compiler. I know that is not an issue at the moment, but I'm the canary in the coal mine for when dumping additional native compiled units. That feature is way too nice for someone to not get it in the trunk at some point. Lynn --000000000000567e8905e5a50eb6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Aug 5, 2022, 8:18 AM Lars Ingebrigtsen <larsi@gnus.org> wrote:
Lynn Winebarger <owinebar@gmail.com> writes:
> Isn't call-interactively only used in the context of requesting us= er
> input?=C2=A0 That would seem unlikely to benefit from optimization.
Some interactive specs are pretty involved, and definitely benefit from
being compiled, so we're not going to stop doing that.

Another possibility w= ould be to ensure there is a standard pdmp file to use for compiling, regar= dless of what is being used for the session calling the compiler.=C2=A0 I k= now that is not an issue at the moment, but I'm the canary in the coal = mine for when dumping additional native compiled units.=C2=A0 That feature = is way too nice for someone to not get it in the trunk at some point.=C2=A0=

Lynn

--000000000000567e8905e5a50eb6-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 07 17:19:00 2023 Received: (at 56988-done) by debbugs.gnu.org; 7 Jun 2023 21:19:00 +0000 Received: from localhost ([127.0.0.1]:54943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q70YW-0005tp-6H for submit@debbugs.gnu.org; Wed, 07 Jun 2023 17:19:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q70YT-0005tZ-PY for 56988-done@debbugs.gnu.org; Wed, 07 Jun 2023 17:18:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q70YO-0005qw-B0; Wed, 07 Jun 2023 17:18:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=Di9FRsfATDJCdI/+cBi9/ROAYWAU6qg+ZJBNv7wJU+I=; b=IZU3d5vvfdyRUmYXqNu3 sDjS0vNtqwrvQpccIrxxxrh24zh76xeJY7W9mGLSbN09/E3bR8/+9yN9GvNgekDRiTMUjreANhV12 mWWXJBCXehYIXLtxig6aE6kZX0OGql2F1ROtF6Y1Wy8i14nt55yQuVT/JtcLyK7G9BQh9ydLyZBfs h1/dDqxHEgtyJyFbxhlheXKSX78GWKjv9wgu8SV7Ubd83f45mNsgeQXHfD1dACvxBh6fWTbf6Cmqc 9FOjaKtlsCQly1p+etwvEmRzcR3NTqv7TQwp0we8KxMvWh6+XZ5PYp7/7mh5p1Uo0E76YxSTg4BOs NJNIq48Tm2mCqQ==; Received: from acorallo by fencepost.gnu.org with local (Exim 4.90_1) (envelope-from ) id 1q70YN-0001e5-VH; Wed, 07 Jun 2023 17:18:52 -0400 From: Andrea Corallo To: Lynn Winebarger Subject: Re: bug#56988: Add call-interactively to "never optimize" list for native compilation In-Reply-To: (Lynn Winebarger's message of "Fri, 5 Aug 2022 08:33:42 -0400") References: <87a68iano8.fsf@gnus.org> Date: Wed, 07 Jun 2023 17:18:51 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56988-done Cc: Lars Ingebrigtsen , Andrea Corallo , 56988-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello all, I'm closing this bug as not reproducible on our codebase. Best Regards Andrea From unknown Thu Jun 19 14:12:53 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 06 Jul 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator