GNU bug report logs - #56976
29.0.50; Obsolete netrc.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56976 in the body.
You can then email your comments to 56976 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 16:16:00 +0200

It'd be nice to obsolete netrc.el, since the functionality is duplicated
by auth-source, and is broken for non-ASCII chars etc.

There's only one in-tree usage of netrc-parse, and that's in
tramp-parse-netrc.  This could be changed to use
`auth-source-netrc-parse' instead, but in earlier versions of that
function, it'd return nil when not specifying the host/user/ports, which
made it not quite compatible.  I've now changed that, but I'm not sure
what the compat situation is here (i.e., if this Tramp has to work in
older Emacs versions or not).


In GNU Emacs 29.0.50 (build 29, x86_64-pc-linux-gnu, GTK+ Version 3.24.33, cairo version 1.16.0)
 of 2022-08-04 built on joga
Repository revision: 3e60f7f3c31a8491b085684121e5229be56b3538
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101003
System Description: Ubuntu 22.04 LTS

Message #8 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 56976 <at> debbugs.gnu.org
Cc: Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 16:23:07 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> It'd be nice to obsolete netrc.el, since the functionality is duplicated
> by auth-source, and is broken for non-ASCII chars etc.
>
> There's only one in-tree usage of netrc-parse, and that's in
> tramp-parse-netrc.  This could be changed to use
> `auth-source-netrc-parse' instead, but in earlier versions of that
> function, it'd return nil when not specifying the host/user/ports, which
> made it not quite compatible.  I've now changed that, but I'm not sure
> what the compat situation is here (i.e., if this Tramp has to work in
> older Emacs versions or not).

(Adding Michael to the CCs.)

Message #11 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 16:37:26 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

Hi Lars,

> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> It'd be nice to obsolete netrc.el, since the functionality is duplicated
>> by auth-source, and is broken for non-ASCII chars etc.
>>
>> There's only one in-tree usage of netrc-parse, and that's in
>> tramp-parse-netrc.  This could be changed to use
>> `auth-source-netrc-parse' instead, but in earlier versions of that
>> function, it'd return nil when not specifying the host/user/ports, which
>> made it not quite compatible.  I've now changed that, but I'm not sure
>> what the compat situation is here (i.e., if this Tramp has to work in
>> older Emacs versions or not).

*This Tramp* has to work back with Emacs 26. Don't worry, I will check
the compatibility status after your commit, and adjust as needed.

> (Adding Michael to the CCs.)

I'm scanning all new messages in the groups I read on gmane for some
buzzwords, like "tramp". Those messages will be presented to me first :-)

Thanks to automated gnus-summary-search-article-forward.

Best regards, Michael.

Message #14 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 16:44:36 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

> *This Tramp* has to work back with Emacs 26. Don't worry, I will check
> the compatibility status after your commit, and adjust as needed.

The problem is that until earlier today, auth-source-netrc-parse just
returned nil if called with no host/user parameters, so I don't know
what the compat check would be.

Perhaps it'd be more convenient if there was a new function like
`auth-source-netrc-parse-all-entries' that tramp.el could check for the
presence of?  Would that help?  (It would just be an alias, probably.)

> I'm scanning all new messages in the groups I read on gmane for some
> buzzwords, like "tramp". Those messages will be presented to me first :-)
>
> Thanks to automated gnus-summary-search-article-forward.

:-)

Message #17 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 16:50:00 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

Hi Lars,

>> *This Tramp* has to work back with Emacs 26. Don't worry, I will check
>> the compatibility status after your commit, and adjust as needed.
>
> The problem is that until earlier today, auth-source-netrc-parse just
> returned nil if called with no host/user parameters, so I don't know
> what the compat check would be.

I could check whether netrc-parse is obsolete. In that case,
auth-source-netrc-parse would be in play.

Best regards, Michael.

Message #20 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 16:51:24 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Perhaps it'd be more convenient if there was a new function like
> `auth-source-netrc-parse-all-entries' that tramp.el could check for the
> presence of?

I've now done this, and partially reverted previous change, because the
change in behaviour might break things.

So I'll go ahead and change the Tramp code to use
`auth-source-netrc-parse-all', and leave the further adjustments to you?

Message #23 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 17:00:10 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

Hi Lars,

>> Perhaps it'd be more convenient if there was a new function like
>> `auth-source-netrc-parse-all-entries' that tramp.el could check for the
>> presence of?
>
> I've now done this, and partially reverted previous change, because the
> change in behaviour might break things.
>
> So I'll go ahead and change the Tramp code to use
> `auth-source-netrc-parse-all', and leave the further adjustments to you?

In general yes, but why the new alias? What's wrong with my proposal
checking obsolescence of netrc-parse?

I try to keep it as simple as possible, and introducing a new alias for
exactly one use case, which has a planned suicide date (compatibility of
Tramp), seems too much for me.

Best regards, Michael.

Message #26 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 17:08:04 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

>> I've now done this, and partially reverted previous change, because the
>> change in behaviour might break things.
>>
>> So I'll go ahead and change the Tramp code to use
>> `auth-source-netrc-parse-all', and leave the further adjustments to you?
>
> In general yes, but why the new alias? What's wrong with my proposal
> checking obsolescence of netrc-parse?

I decided against the alias, because my first change (to just make
missing/nil host etc return all entries) wasn't quite
backwards-compatible enough, so it wasn't a good idea in the first
place.

So a new function is needed in any case.

Message #29 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 17:14:52 +0200

I've now made the adjustments and made netrc.el obsolete.

Message #34 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 19:29:54 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

Hi Lars,

>>> So I'll go ahead and change the Tramp code to use
>>> `auth-source-netrc-parse-all', and leave the further adjustments to you?

Should be fixed now in master.

Best regards, Michael.

Message #37 received at 56976 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 56976 <at> debbugs.gnu.org
Subject: Re: bug#56976: 29.0.50; Obsolete netrc.el
Date: Thu, 04 Aug 2022 19:34:56 +0200

Michael Albinus <michael.albinus <at> gmx.de> writes:

> Should be fixed now in master.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.