GNU bug report logs - #56973
:keymap in register-definition-prefixes in loaddefs

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Thu, 4 Aug 2022 12:18:01 UTC

Severity: minor

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56973 in the body.
You can then email your comments to 56973 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to larsi <at> gnus.org, bug-gnu-emacs <at> gnu.org:
bug#56973; Package emacs. (Thu, 04 Aug 2022 12:18:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to larsi <at> gnus.org, bug-gnu-emacs <at> gnu.org. (Thu, 04 Aug 2022 12:18:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: :keymap in register-definition-prefixes in loaddefs
Date: Thu, 4 Aug 2022 12:16:58 +0000
Severity: minor

I see in ldefs-boot.el lines like:

    (register-definition-prefixes "gnus-sum" '(":keymap" "gnus-"))

The ":keymap" there is from definitions like:

    (define-keymap :keymap gnus-summary-mode-map
        ...)

I'm not sure what is the best fix, however.  Should such cases just be
changed to use `defvar-keymap', or should we add `define-keymap' to
`autoload-ignored-definitions'?




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#56973; Package emacs. (Thu, 04 Aug 2022 13:30:03 GMT) Full text and rfc822 format available.

Message #8 received at 56973 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56973 <at> debbugs.gnu.org
Subject: Re: bug#56973: :keymap in register-definition-prefixes in loaddefs
Date: Thu, 04 Aug 2022 15:29:05 +0200
Stefan Kangas <stefan <at> marxist.se> writes:

> I see in ldefs-boot.el lines like:
>
>     (register-definition-prefixes "gnus-sum" '(":keymap" "gnus-"))
>
> The ":keymap" there is from definitions like:
>
>     (define-keymap :keymap gnus-summary-mode-map
>         ...)
>
> I'm not sure what is the best fix, however.  Should such cases just be
> changed to use `defvar-keymap', or should we add `define-keymap' to
> `autoload-ignored-definitions'?

I've added it to `autoload-ignored-definitions' -- these can't be
directly translated to `defvar-keymap' for backwards compatibility
reasons, if I remember correctly.





bug marked as fixed in version 29.1, send any further explanations to 56973 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 04 Aug 2022 13:30:04 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 02 Sep 2022 11:24:13 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 289 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.