GNU bug report logs - #56969
Should erc--download-directory be named eww--download-directory?

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Thu, 4 Aug 2022 08:50:02 UTC

Severity: wishlist

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56969 in the body.
You can then email your comments to 56969 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to larsi <at> gnus.org, bug-gnu-emacs <at> gnu.org:
bug#56969; Package emacs. (Thu, 04 Aug 2022 08:50:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Stefan Kangas <stefan <at> marxist.se>:
New bug report received and forwarded. Copy sent to larsi <at> gnus.org, bug-gnu-emacs <at> gnu.org. (Thu, 04 Aug 2022 08:50:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: bug-gnu-emacs <at> gnu.org
Subject: Should erc--download-directory be named eww--download-directory?
Date: Thu, 4 Aug 2022 08:49:16 +0000

Severity: wishlist

Lars, is there a particular reason why erc--download-directory in eww.el
is named that way?  It seems to me that it should be
eww--download-directory instead.  Is it just a typo?

It was added in:

    commit 76f71e39f583b7f8bb47a47b315f49af6f23886e
    Author: Lars Ingebrigtsen <larsi <at> gnus.org>
    Date:   Wed Jul 29 07:13:56 2020 +0200

        Make eww use the XDG download directory

        * lisp/net/eww.el (erc--download-directory): New function (bug#41030).
        (eww-download-directory): Use it.
        (eww-download): Use it.
        (eww-download-callback): Adjust parameters.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#56969; Package emacs. (Thu, 04 Aug 2022 09:06:02 GMT) Full text and rfc822 format available.

Message #8 received at 56969 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 56969 <at> debbugs.gnu.org
Subject: Re: bug#56969: Should erc--download-directory be named
 eww--download-directory?
Date: Thu, 04 Aug 2022 11:05:11 +0200

Stefan Kangas <stefan <at> marxist.se> writes:

> Lars, is there a particular reason why erc--download-directory in eww.el
> is named that way?  It seems to me that it should be
> eww--download-directory instead.  Is it just a typo?

Yeah, just a typo.  Now fixed in Emacs 29.
bug marked as fixed in version 29.1, send any further explanations to 56969 <at> debbugs.gnu.org and Stefan Kangas <stefan <at> marxist.se> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 04 Aug 2022 09:06:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 01 Sep 2022 11:24:13 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 288 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.