From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 04:33:57 2022 Received: (at submit) by debbugs.gnu.org; 4 Aug 2022 08:33:57 +0000 Received: from localhost ([127.0.0.1]:51093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJWIn-0007hI-I9 for submit@debbugs.gnu.org; Thu, 04 Aug 2022 04:33:57 -0400 Received: from lists.gnu.org ([209.51.188.17]:41378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJWIk-0007h8-1m for submit@debbugs.gnu.org; Thu, 04 Aug 2022 04:33:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJWIj-00033p-5b for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 04:33:53 -0400 Received: from mail-vs1-f41.google.com ([209.85.217.41]:44855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oJWIh-0005ih-In for bug-gnu-emacs@gnu.org; Thu, 04 Aug 2022 04:33:52 -0400 Received: by mail-vs1-f41.google.com with SMTP id s129so11966076vsb.11 for ; Thu, 04 Aug 2022 01:33:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=89NL+LZ7MS7E5SeEurqYCnUUPreiDo/SdodBtPZGr6U=; b=PBj6A5W+M8NsKNpCGgJbswVjYL7bGA5BVSEtH/isVUtSyEnWUnFC98x+uxAOOHwH/y fbhMBJjRkBGi5UvAJ7JflHybkJ9bnXjsIXXT47kk66Yzs/Lvn8ZRCMeIJR2ckQzqx/yY s0/LirA5OYwG2JQ685xmUGYZKg7InCX8SJewoI6/oIoxRbqSCAepsfk1NweFmQimPu/i dxXLcOJ2RYzftYaRdilKtzY7Xe/wBV/DFj/HrC4/0CX3Z+Lf3dnpSSd7VIyYlgZyuaL3 p7Cw5fMzHES2EWAdKORTvaROoeksCe4LPdAUXSAmlQIG4jK5xxu/6Ak+nF4Ayg4J4ak6 DzIg== X-Gm-Message-State: ACgBeo1rNjJno8Rmh9/1P7oNuAGEj0EGbT7yhfop+IlUawhe50i/GnZi 9V1ewiMmOK/EU612BjIoNBo1BPt+XOtpTAv0LEUEOD8h X-Google-Smtp-Source: AA6agR5naGamcxSWz5z6KPVYWoLpsyjqVtTqM3rS0gB1hQaeDhYMzmg8Hs+e7M7Ls4o7Q+wR3gTUi+A5sWunJ3Stz6E= X-Received: by 2002:a67:cb0c:0:b0:357:9897:32d4 with SMTP id b12-20020a67cb0c000000b00357989732d4mr225793vsl.18.1659602030070; Thu, 04 Aug 2022 01:33:50 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 4 Aug 2022 08:33:49 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 4 Aug 2022 08:33:49 +0000 Message-ID: Subject: Incorrect definition prefix "my-" assigned to battery.el in ldefs-boot.el To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.217.41; envelope-from=stefankangas@gmail.com; helo=mail-vs1-f41.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Severity: minor I see in ldefs-boot.el: (register-definition-prefixes "battery" '("battery-" "my-")) However, in battery.el, the "my-" prefix only ever shows up inside a docstring. That seems like a bug. AFAICT, this doesn't happen in emacs-28, so this might be a regression. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 05:01:34 2022 Received: (at 56968) by debbugs.gnu.org; 4 Aug 2022 09:01:34 +0000 Received: from localhost ([127.0.0.1]:51136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJWjW-00029k-BD for submit@debbugs.gnu.org; Thu, 04 Aug 2022 05:01:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJWjU-00029V-5A for 56968@debbugs.gnu.org; Thu, 04 Aug 2022 05:01:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Ohy63NQYPaCRpPyyqbsOualE9Mrk36jA5Z6N0tWZbCM=; b=cRtsLDiYdWVdq8WgYdfZdr637F vP6WrFstZmZiqLsXmsY1xJMJfAGdevkjUa3eUkG9VTWY4R+OeocYWZOvc9OiquoCGt4h86qoQmXy6 5konJD4E8ttiO4ErUjMcBLb8frt/rK4GuY22JnJ3PUwqlYCKr6SF8ZQpdXvQEyGvc/Ac=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJWjH-00053y-IJ; Thu, 04 Aug 2022 11:01:25 +0200 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#56968: Incorrect definition prefix "my-" assigned to battery.el in ldefs-boot.el In-Reply-To: (Stefan Kangas's message of "Thu, 4 Aug 2022 08:33:49 +0000") References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEX7+/stKCjV1dSH g3NcWE8MBwmxsKX///8fuVgaAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YIBAg6JkpshJUAAAF+SURB VDjL7ZOxcoMwDIZ9vIEO3JkY6p1g2Ckxuy9W50CI3/8RKtm0Sblk6tqfQYc+6ZcwIMS/9oKkwxar ZoDTCaAUmPS+xQoGLCTiRaDvjGTgqJ7AAEiBgJ/aOXbk5IFYo0SH6AisICMYJXvMm+VFgEd5lgSo 3EcACRSDN4Y7ij1YxzfrCNA9mScrR+va6Rps4XgrCd8AB5oxVmMn8RYLCbgIJFuFvGncjbOpw/cd g08dcmPdyrsmcFQHHu5OH6Pp8BAfK4LT2jAwZrAe+EgcxA5v2hbhIiSJ3OkQ+zBHUE06AsB0JLiw 9+xc29eOAN4Bd9QIue7icBsBFRdjg44AjjaCJh4OAQSQvqbV8lXyi0LqYUBLFfJcF9Yfl6vlGfkP APR6MVPQS0XvfDByAxyV6pVSOhDw9vFjoFwISl9LEfrA0iGppHpVZkoIpUSWlayMoyJSqgSe6jfI XgH1d5Dt0+X2K2RPs/v8I9nUvvq5noKHde7iGXpRdC1kv434ApdpsKWK9rESAAAAJXRFWHRkYXRl OmNyZWF0ZQAyMDIyLTA4LTA0VDA4OjU4OjM4KzAwOjAwer+ILwAAACV0RVh0ZGF0ZTptb2RpZnkA MjAyMi0wOC0wNFQwODo1ODozOCswMDowMAviMJMAAAAASUVORK5CYII= X-Now-Playing: Genesis's _The Lamb Lies Down On Broadway (2)_: "The Lamia" Date: Thu, 04 Aug 2022 11:01:16 +0200 Message-ID: <87r11widr7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > Severity: minor > > I see in ldefs-boot.el: > > (register-definition-prefixes "battery" '("battery-" "my-")) > > However, in battery.el, the "my-" prefix only ever shows up inside a > docstring. Tha [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56968 Cc: 56968@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Kangas writes: > Severity: minor > > I see in ldefs-boot.el: > > (register-definition-prefixes "battery" '("battery-" "my-")) > > However, in battery.el, the "my-" prefix only ever shows up inside a > docstring. That seems like a bug. > > AFAICT, this doesn't happen in emacs-28, so this might be a regression. The (defun my- in battery.el is new in Emacs 29, so it's not a regression exactly -- it's why we're doing \( in all doc strings that have lines that start with (def. I briefly wondered whether we could usefully warn about this with something like the below, but I don't think so, since by the time we're called where, we've already read the \( into (, so there's too many false positives. So I've just fixed up the existing errors here instead. diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 7d2971502d..d8255b2584 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -294,7 +294,8 @@ byte-compile-warning-types '(redefine callargs free-vars unresolved obsolete noruntime interactive-only make-local mapcar constants suspicious lexical lexical-dynamic - docstrings docstrings-non-ascii-quotes not-unused) + docstrings docstrings-non-ascii-quotes not-unused + docstrings-defthings) "The list of warning types used when `byte-compile-warnings' is t.") (defcustom byte-compile-warnings t "List of warnings that the byte-compiler should issue (t for almost all). @@ -338,7 +339,8 @@ byte-compile-warnings byte-compile-warning-types)))) =20 (defconst byte-compile--emacs-build-warning-types - '(docstrings-non-ascii-quotes) + '(docstrings-non-ascii-quotes + docstrings-defthings) "List of warning types that are only enabled during Emacs builds. This is typically either warning types that are being phased in (but shouldn't be enabled for packages yet), or that are only relevant @@ -1770,6 +1772,13 @@ byte-compile-docstring-style-warn (when (string-match-p "\\( \"\\|[ \t]\\|^\\)[=E2=80=98=E2=80=99]= " docs) (byte-compile-warn-x name "%s%sdocstring has wrong usage of \"fancy\" single quota= tion marks" + kind name))) + ;; There's a "(def" in the first column. This will typically + ;; lead to wrong `register-definition-prefixes'. + (when (byte-compile-warning-enabled-p 'docstrings-defthings) + (when (string-match-p "^(def" docs) + (byte-compile-warn-x + name "%s%sdocstring has a \"(def\" form in the first column" kind name)))))) form) =20 From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 05:03:08 2022 Received: (at control) by debbugs.gnu.org; 4 Aug 2022 09:03:08 +0000 Received: from localhost ([127.0.0.1]:51140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJWl1-0002CI-Sx for submit@debbugs.gnu.org; Thu, 04 Aug 2022 05:03:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50076) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJWl0-0002Bp-EK for control@debbugs.gnu.org; Thu, 04 Aug 2022 05:03:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eZQe8WhH5553QTnHoIYVAI5eFyzoA93xi880W9HKJFI=; b=HjIlOSK0iQi3jug+x/V3QM8Z4/ TKmtHoQ3xVCYhbgmNbe+KTxsKlL/avxx08C5xAcIy1xT5LVxaKGe7URg67guF2+8dO/nSuEVm0JWo smUNkDGOcoOdwn0payMWIoUtdXbIkTpJo1/DDq/EL4FBR699HjBMLMVs/ZojsT7GWxVE=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJWks-00054H-KH for control@debbugs.gnu.org; Thu, 04 Aug 2022 11:03:00 +0200 Date: Thu, 04 Aug 2022 11:02:58 +0200 Message-Id: <87pmhgidod.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56968 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 56968 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 56968 29.1 quit From unknown Sun Jun 15 08:37:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 01 Sep 2022 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator