GNU bug report logs - #56960
[PATCH] * gnu: Add siglo.

Previous Next

Full log

Message #11 received at 56960 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: "Wamm K. D" <jaft.r <at> outlook.com>, 56960 <at> debbugs.gnu.org
Subject: Re: [bug#56960] [PATCH] * gnu: Add siglo.
Date: Thu, 11 Aug 2022 21:00:00 +0200

[Message part 1 (text/plain, inline)]

On 03-08-2022 22:23, Wamm K. D wrote:

See response by other reviewer (though I'm not sure about the 'name' 
thing, if we change the package name it's easy to adjust the url field 
too), and ...

> +    (propagated-inputs (list gtk+))

... why is it propagated?

> +               `("GI_TYPELIB_PATH" = (,(getenv "GI_TYPELIB_PATH")))))))))

Using getenv in this way is incorrect when cross-compiling because it 
will look in native-inputs instead of inputs, but correcting that can 
wait until gtk+ is actually cross-compilable (and then we could write a 
convenient procedure for that).

For GUIX_PYTHONPATH, search-path-as-list can be useful (and slightly 
less fragile, as it does not depend on labels).

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.