GNU bug report logs - #56957
[PATCH] Fix ignored-local-variable-values for non-primitive values

Previous Next

Package: emacs;

Reported by: Kira Bruneau <kira.bruneau <at> pm.me>

Date: Wed, 3 Aug 2022 18:24:01 UTC

Severity: normal

Tags: patch

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56957 in the body.
You can then email your comments to 56957 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#56957; Package emacs. (Wed, 03 Aug 2022 18:24:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Kira Bruneau <kira.bruneau <at> pm.me>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 03 Aug 2022 18:24:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kira Bruneau <kira.bruneau <at> pm.me>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Fix ignored-local-variable-values for non-primitive values
Date: Wed, 03 Aug 2022 18:09:50 +0000

[Message part 1 (text/plain, inline)]
I noticed that structural comparison wasn't being done to ignore values in `ignored-local-variable-values', so it could only ever ignore primitive values.
[0001-Fix-ignored-local-variable-values-for-non-primitive-.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#56957; Package emacs. (Wed, 03 Aug 2022 18:54:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kira Bruneau <kira.bruneau <at> pm.me>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: Re: [PATCH] Fix ignored-local-variable-values for non-primitive values
Date: Wed, 03 Aug 2022 18:17:16 +0000

[Message part 1 (text/plain, inline)]
Oh sorry, I just noticed I had my old email configured for my local git repo. Here's a patch with my updated email.

------- Original Message -------
On Wednesday, August 3rd, 2022 at 2:09 PM, Kira Bruneau <kira.bruneau <at> pm.me> wrote:


>
>
> I noticed that structural comparison wasn't being done to ignore values in `ignored-local-variable-values', so it could only ever ignore primitive values.
[0001-Fix-ignored-local-variable-values-for-non-primitive-.patch (text/x-patch, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#56957; Package emacs. (Thu, 04 Aug 2022 06:27:02 GMT) Full text and rfc822 format available.

Message #11 received at 56957 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kira Bruneau <kira.bruneau <at> pm.me>
Cc: 56957 <at> debbugs.gnu.org
Subject: Re: bug#56957: [PATCH] Fix ignored-local-variable-values for
 non-primitive values
Date: Thu, 04 Aug 2022 08:26:48 +0200

Kira Bruneau <kira.bruneau <at> pm.me> writes:

> Oh sorry, I just noticed I had my old email configured for my local
> git repo. Here's a patch with my updated email.

Thanks; pushed to Emacs 29.
bug marked as fixed in version 29.1, send any further explanations to 56957 <at> debbugs.gnu.org and Kira Bruneau <kira.bruneau <at> pm.me> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Thu, 04 Aug 2022 06:28:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 01 Sep 2022 11:24:11 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 289 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.