From unknown Fri Jun 20 07:17:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56939] [PATCH 31/41] gnu: Add go-github-com-google-shlex. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Aug 2022 12:07:24 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56939 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 56939@debbugs.gnu.org Cc: "\(unmatched-parenthesis" X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165952842511842 (code B ref -1); Wed, 03 Aug 2022 12:07:24 +0000 Received: (at submit) by debbugs.gnu.org; 3 Aug 2022 12:07:05 +0000 Received: from localhost ([127.0.0.1]:46435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJD9U-00034d-NM for submit@debbugs.gnu.org; Wed, 03 Aug 2022 08:07:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:49330) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJD9O-00031j-Cq for submit@debbugs.gnu.org; Wed, 03 Aug 2022 08:06:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJD9O-00082N-75 for guix-patches@gnu.org; Wed, 03 Aug 2022 08:06:58 -0400 Received: from knopi.disroot.org ([178.21.23.139]:49266) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJD9K-000362-AQ for guix-patches@gnu.org; Wed, 03 Aug 2022 08:06:57 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 7B4F94195A; Wed, 3 Aug 2022 14:06:41 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id WJd47gpR2bcF; Wed, 3 Aug 2022 14:06:40 +0200 (CEST) From: "(" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659528292; bh=dA0Bna/1zGEzun8WhQ/F+ULMCUIS05Cn2M8jrNXoMb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=LvkL5olNyawDRY7k/lDmMUMySlEc1n/PlxxTFnFt3NK9ZzZ72d8ul0xzAUzS0Lu2D DlG5afJU2rH2hdwtc6MypNNhVVMw60xribxiCLEGKC3mMrnJUglKGkSZsYchHaGuxB EuYuIFnDUZDJczw+Ruj3o7T52lF2klZjDM4ne1HLqvCHjRZlvv3gAfrq4mcWv/5PkK bVsx9E9TyM7TIWTVJlXVHXlUFHUArM9HWEa4gdDxnzX6q8JDGRhxKMdLQ30YZdH/cy vLfuz3Xm/msc/Cv3tQXaqRy8bjZrbRkpIvVOrFWoMcmW5w4QY/GDGUq5i72lP33ZCn kdHuwC2kRqXgg== Date: Wed, 3 Aug 2022 13:04:29 +0100 Message-Id: <20220803120439.5108-31-paren@disroot.org> In-Reply-To: <20220803120439.5108-1-paren@disroot.org> References: <20220803120439.5108-1-paren@disroot.org> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=178.21.23.139; envelope-from=paren@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) From: "(unmatched-parenthesis" * gnu/packages/golang.scm (go-github-com-google-shlex): New variable. --- gnu/packages/golang.scm | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm index fd2335b61a..9959dd118c 100644 --- a/gnu/packages/golang.scm +++ b/gnu/packages/golang.scm @@ -10720,3 +10720,26 @@ (define-public go-github-com-lithammer-fuzzysearch "A speedy fuzzy matching package for Go inspired by the JavaScript library bevacqua/fuzzysearch.") (license license:expat))) + +(define-public go-github-com-google-shlex + (package + (name "go-github-com-google-shlex") + (version "0.0.0-20191202100458-e7afc7fbc510") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/google/shlex") + (commit (go-version->git-ref version)))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "14z8hqyik910wk2qwnzgz8mjsmiamxa0pj55ahbv0jx6j3dgvzfm")))) + (build-system go-build-system) + (arguments + (list #:import-path "github.com/google/shlex")) + (home-page "https://github.com/google/shlex") + (synopsis "Simple lexer for Go") + (description + "Shlex is a simple lexer for Go that supports shell-style quoting, +commenting, and escaping.") + (license license:asl2.0))) -- 2.37.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 08:17:52 2022 Received: (at control) by debbugs.gnu.org; 3 Aug 2022 12:17:52 +0000 Received: from localhost ([127.0.0.1]:46549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJDJw-0003VQ-BA for submit@debbugs.gnu.org; Wed, 03 Aug 2022 08:17:52 -0400 Received: from knopi.disroot.org ([178.21.23.139]:45588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJDJt-0003VF-69 for control@debbugs.gnu.org; Wed, 03 Aug 2022 08:17:50 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 9CA2040D96 for ; Wed, 3 Aug 2022 14:17:48 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3rXwhm5q2hK1 for ; Wed, 3 Aug 2022 14:17:47 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659529067; bh=WMWGEbG5sg0dFQzbWHnMFMTLFP+a3LO8S3y8TT+KO0Q=; h=Date:Subject:From:To; b=X5zvbNM7x0wl7OqwPD+Ffu2opwG2nordWZBykon9ky7ykI+jMxJmRUafqCO+P9ijO QRKX2wN/8kjtBTwLZT7fSU9HpUOXK2pq8G6DsHuFZW59Kqf3ag1qhZ5FJSq9LQzwkS YYi3Bnl9nqOzcm/IVC62yRq344GfF1FtMGProvu+1nJ65+WQq4K1Q8evktfGp2SKjp Rooe6UsP4RKWEdfKUCXNKWwwVJFe1z3jIL75S64S34vuCJZsa7QKM4OiKumfZ8whsg Xsz9tAWFchfyJ6nBtQHV29vfZyFT1ZIjPJw+isn1xXuItlGYWhhCTVx5j4GIXS0EAS 28a48lbbojgTA== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 Aug 2022 13:17:46 +0100 Message-Id: Subject: From: "(" To: X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 55903 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 56919 56920 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 56931 56933 56936 56935 56932 56941 56938 56939 56 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) merge 55903 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 569= 19 56920 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 = 56931 56933 56936 56935 56932 56941 56938 56939 56937 56942 56940 56943 569= 44 56945 56946 56947 56948 56949 thanks -- ( From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 08:32:01 2022 Received: (at control) by debbugs.gnu.org; 3 Aug 2022 12:32:01 +0000 Received: from localhost ([127.0.0.1]:46741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJDXd-0006Gg-1b for submit@debbugs.gnu.org; Wed, 03 Aug 2022 08:32:01 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJDXa-0006GY-RY for control@debbugs.gnu.org; Wed, 03 Aug 2022 08:31:59 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 5C14040DED for ; Wed, 3 Aug 2022 14:31:58 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id E_E3ZYQrJPp3 for ; Wed, 3 Aug 2022 14:31:57 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659529904; bh=VPXzsnu7xHX/DJXk0Ame3rH2Frx2BImX8NbBTYPwhqk=; h=Date:Subject:From:To; b=fpUzS8b+PV3yGLEJUGlegB3Z8nLN9w93Ky2L03kPDE3ZQJE+OKcujMmqKTlpGzrF6 1rglT5nYRGhugteiKrxz01TOoZZ64WKnavu49NdkMMIY+OwuDEw5+DHvI9paDNQ9UX amgPytIJXyCx42y0IDMdhrpVWlKljqDlCwYLvd+szO67u3SWoMt2XL8Hgf9v8BUZX0 wngHN772uX1rhiIJoXHBPtdOHm7Jj7ocaeod5UhIC5549hmm6t4za2xB4nctX4J1xt fOqdBEPmMaBaShe0E7BXDD9H+u2+8ipK4HYAaS/p2FLqZIacIFtCX26b+PhDkKjcn1 8qqtPN5KamN4A== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 Aug 2022 13:31:44 +0100 Message-Id: Subject: From: "(" To: X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 56919 56920 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 56931 56933 56936 56935 56932 56941 56938 56939 56937 56 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) close 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 56919 569= 20 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 56931 = 56933 56936 56935 56932 56941 56938 56939 56937 56942 56940 56943 56944 569= 45 56946 56947 56948 56949 thanks -- ( From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 08:37:21 2022 Received: (at control) by debbugs.gnu.org; 3 Aug 2022 12:37:21 +0000 Received: from localhost ([127.0.0.1]:46794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJDcn-0006SZ-2U for submit@debbugs.gnu.org; Wed, 03 Aug 2022 08:37:21 -0400 Received: from knopi.disroot.org ([178.21.23.139]:37120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJDck-0006SQ-M5 for control@debbugs.gnu.org; Wed, 03 Aug 2022 08:37:20 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0C69F40DB6 for ; Wed, 3 Aug 2022 14:37:18 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f4Cxr0JOu_e9 for ; Wed, 3 Aug 2022 14:37:17 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659530234; bh=eGbYskMuk5Buchxn8aaQHX4ISR9ZG45KEnnr65aS4CM=; h=Date:From:To:Subject; b=SCw5NuStwpacvbdTTcbwXBttikRqW0YIGFWAFioOgzVBm8uXEDi6dcZ24+nO2RDui HIbnWWr5ZEmVkuU43oercKcqRKtz2hcslLpkylW0PzFsufVcoN01eYftrrPO3irQ/+ PVExpi+KrN82jIhumKgprg3RaoE5VC5K03IQEcdVDaxz2BSyEj2gWVoTl/6tYNaSUX w/xTrTZm08/+MON+/N3Ph4IMo8k+Ya2/bogA8bXHahggHJ1z+IAjpBzD/DltMkY7Vu 5lOKI2yVzKJ0iP//9/8a2YElW4HeV/PkroWbhHnR2xn3fEk6nAlJ3OmKKhVBcc3xG+ 4p8YdJN5bBhIg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 Aug 2022 13:37:14 +0100 Message-Id: From: "(" To: Subject: X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: unmerge 55903 thanks -- ( Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) unmerge 55903 thanks -- ( From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 08:37:48 2022 Received: (at control) by debbugs.gnu.org; 3 Aug 2022 12:37:48 +0000 Received: from localhost ([127.0.0.1]:46797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJDdE-0006Th-Aw for submit@debbugs.gnu.org; Wed, 03 Aug 2022 08:37:48 -0400 Received: from knopi.disroot.org ([178.21.23.139]:43224) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJDdD-0006Ta-3S for control@debbugs.gnu.org; Wed, 03 Aug 2022 08:37:47 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 74FF840DC4 for ; Wed, 3 Aug 2022 14:37:46 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id GU-_CAFJYqT3 for ; Wed, 3 Aug 2022 14:37:45 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659530265; bh=VPXzsnu7xHX/DJXk0Ame3rH2Frx2BImX8NbBTYPwhqk=; h=Date:Subject:From:To; b=jjzdDCFDu9kKY18wP4Fcrc5wQ+Z4miRsa9GbdRpj0vhJQh1VWysnknfCrvsRsuF8z vd3fvSUz3ift2vAwLpQtW3qKRmBp2WMJM/bXCLNtAQuELx4XicukTfFoDdViMxYKlQ 9FagXn69G4lbD4rrThWJuFW/Gizb1vn2HYw18d6ACr4arHZMaFx7bfA1fvx1QNGzzo x0z+mpHFecxdsCWUTvIB4ZVmaS47VMXZswub50udo6kHGccPBAD55QQlxuNx8B+XaM NhI/Or0e4YIcmVEY6+p6m1tY14XFAICsKKT7HPh0oM/uU8bWJ+ULZZr07yVPNDFwjC T1A3zTEV/J6xg== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 Aug 2022 13:37:44 +0100 Message-Id: Subject: From: "(" To: X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 56919 56920 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 56931 56933 56936 56935 56932 56941 56938 56939 56937 56 [...] Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) close 56909 56914 56910 56911 56912 56913 56915 56916 56917 56918 56919 569= 20 56921 56922 56923 56924 56925 56926 56927 56928 56934 56930 56929 56931 = 56933 56936 56935 56932 56941 56938 56939 56937 56942 56940 56943 56944 569= 45 56946 56947 56948 56949 thanks -- ( From unknown Fri Jun 20 07:17:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56939] [PATCH 31/41] gnu: Add go-github-com-google-shlex. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Aug 2022 15:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56939 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "(" , 56939@debbugs.gnu.org, 55903@debbugs.gnu.org Received: via spool by 56939-submit@debbugs.gnu.org id=B56939.165954112422782 (code B ref 56939); Wed, 03 Aug 2022 15:39:02 +0000 Received: (at 56939) by debbugs.gnu.org; 3 Aug 2022 15:38:44 +0000 Received: from localhost ([127.0.0.1]:49789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJGSJ-0005vM-Q1 for submit@debbugs.gnu.org; Wed, 03 Aug 2022 11:38:44 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:46820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJGSF-0005v4-8m for 56939@debbugs.gnu.org; Wed, 03 Aug 2022 11:38:42 -0400 Received: from [IPV6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16] ([IPv6:2a02:1811:8c09:9d00:5dba:d409:33f7:a16]) by albert.telenet-ops.be with bizsmtp id 33eb2800320ykKC063ebk8; Wed, 03 Aug 2022 17:38:37 +0200 Message-ID: <402d1704-1f18-3b6c-b0a4-2e6ac771093f@telenet.be> Date: Wed, 3 Aug 2022 17:38:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <20220803120439.5108-1-paren@disroot.org> <20220803120439.5108-31-paren@disroot.org> From: Maxime Devos In-Reply-To: <20220803120439.5108-31-paren@disroot.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ye5SnN53FzNZ6bzdBnPwTg3y" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1659541118; bh=WGaiUAFSvjlchI0/00r087ePORQi3VtF+6AN7ACdEO8=; h=Date:To:References:From:Subject:In-Reply-To; b=mYSbYRqocCGruXD4kAO3RBXTG5wjvxmLeUK6R4//ZVGCaNBOwK0GkkMQ25iPj9t6h h8ezm2qD76ZD409jWAWK/qVuXyHtEnPN1aslh7Cd5i+qgMz/3cv/sWoV6Q0cGbrzoi jxpL0SJO/wX80/iUaM6xAXE5zy2UhbIHyV8+DPct7Kr/8k7l12UX7fLaZ/3u/JN0a5 dw7RSawPCli8mUI5jg2Zdc8cYmh6oBwJz/30dVhTzyd8NmQeS2Ls21/PYhAciOcZ0m U78RZSIO9dELFmdUL8L8ff0nm1qpsqn9IkFHmw4aP+agCzIaGlNhS3vyxcQcO3y20G 1/9YKjMMkFUsw== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ye5SnN53FzNZ6bzdBnPwTg3y Content-Type: multipart/mixed; boundary="------------LYwbgVuaWPinogTCFd7Q2842"; protected-headers="v1" From: Maxime Devos To: "(" , 56939@debbugs.gnu.org, 55903@debbugs.gnu.org Message-ID: <402d1704-1f18-3b6c-b0a4-2e6ac771093f@telenet.be> Subject: Re: [bug#56939] [PATCH 31/41] gnu: Add go-github-com-google-shlex. References: <20220803120439.5108-1-paren@disroot.org> <20220803120439.5108-31-paren@disroot.org> In-Reply-To: <20220803120439.5108-31-paren@disroot.org> --------------LYwbgVuaWPinogTCFd7Q2842 Content-Type: multipart/mixed; boundary="------------9sZI0GcCS0315j6iLYCt5k7Y" --------------9sZI0GcCS0315j6iLYCt5k7Y Content-Type: multipart/alternative; boundary="------------WWo0s63XdDlWzxs3JKNce9dg" --------------WWo0s63XdDlWzxs3JKNce9dg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDMtMDgtMjAyMiAxNDowNCwgKCB2aWEgR3VpeC1wYXRjaGVzIHZpYSB3cm90ZToNCg0K PiArICAgIChhcmd1bWVudHMNCj4gKyAgICAgKGxpc3QgIzppbXBvcnQtcGF0aCAiZ2l0aHVi LmNvbS96ZW5oYWNrL2dvLm5vdG11Y2giDQo+ICsgICAgICAgICAgIDs7IFhYWDogVGVzdHMg cmVxdWlyZSB5b3UgdG8gZG93bmxvYWQgZml4dHVyZXMgZnJvbSB0aGUgSW50ZXJuZXQuDQo+ ICsgICAgICAgICAgIDs7IFNlZTxodHRwczovL2dpdGh1Yi5jb20vemVuaGFjay9nby5ub3Rt dWNoL2Jsb2IvbWFzdGVyL01ha2VmaWxlPi4NCj4gKyAgICAgICAgICAgIzp0ZXN0cz8gI2Yp KQ0KPiArICAgIChwcm9wYWdhdGVkLWlucHV0cyAobGlzdCBub3RtdWNoKSkNCkNhbiB3ZSBq dXN0IHN1YnN0aXR1dGUqIGluIHRoZSBhcHByb3ByaWF0ZSBsaWJyYXJ5IHJlZmVyZW5jZSBv ciB3aGF0ZXZlciANCmlzIHRoZSBHbyBlcXVpdmFsZW50IGluc3RlYWQgb2YgcHJvcGFnYXRp bmc/wqAgTWF5YmUgaW4gaW4gY29uZmlnTGlzdC5nbywgDQp3ZSBjYW4gcmVwbGFjZSAtbG5v dG11Y2ggYnkgLWwvZ251L3N0b3JlLy4uLi9saWJub3RtdWNoLnNvIG9yIGFkZCBhIA0KLUwv Z251L3N0b3JlLy4uLiB0aGVyZT8NCg0KPiBGcm9tOiAiKHVubWF0Y2hlZC1wYXJlbnRoZXNp cyI8cGFyZW5AZGlzcm9vdC5vcmc+DQo+DQo+ICogZ251L3BhY2thZ2VzL2dvbGFuZy5zY20g KGdvLWdpdGh1Yi1jb20tZ29vZ2xlLXNobGV4KTogTmV3IHZhcmlhYmxlLg0KPiAtLS0NCj4g ICBnbnUvcGFja2FnZXMvZ29sYW5nLnNjbSB8IDIzICsrKysrKysrKysrKysrKysrKysrKysr DQo+ICAgMSBmaWxlIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKykNCj4NCj4gZGlmZiAtLWdp dCBhL2dudS9wYWNrYWdlcy9nb2xhbmcuc2NtIGIvZ251L3BhY2thZ2VzL2dvbGFuZy5zY20N Cj4gaW5kZXggZmQyMzM1YjYxYS4uOTk1OWRkMTE4YyAxMDA2NDQNCj4gLS0tIGEvZ251L3Bh Y2thZ2VzL2dvbGFuZy5zY20NCj4gKysrIGIvZ251L3BhY2thZ2VzL2dvbGFuZy5zY20NCj4g QEAgLTEwNzIwLDMgKzEwNzIwLDI2IEBAIChkZWZpbmUtcHVibGljIGdvLWdpdGh1Yi1jb20t bGl0aGFtbWVyLWZ1enp5c2VhcmNoDQo+ICAgICAgICAiQSBzcGVlZHkgZnV6enkgbWF0Y2hp bmcgcGFja2FnZSBmb3IgR28gaW5zcGlyZWQgYnkgdGhlIEphdmFTY3JpcHQNCj4gICBsaWJy YXJ5IGJldmFjcXVhL2Z1enp5c2VhcmNoLiIpDQo+ICAgICAgIChsaWNlbnNlIGxpY2Vuc2U6 ZXhwYXQpKSkNCj4gKw0KPiArKGRlZmluZS1wdWJsaWMgZ28tZ2l0aHViLWNvbS1nb29nbGUt c2hsZXgNCj4gKyAgKHBhY2thZ2UNCj4gKyAgICAobmFtZSAiZ28tZ2l0aHViLWNvbS1nb29n bGUtc2hsZXgiKQ0KPiArICAgICh2ZXJzaW9uICIwLjAuMC0yMDE5MTIwMjEwMDQ1OC1lN2Fm YzdmYmM1MTAiKQ0KDQpXaHkgaGFzIHRoZSBjb21taXQgYW5kIGRlc2NyaXB0aW9uIGJlZW4g Y2hhbmdlZCBzaW5jZSANCjxodHRwczovL2lzc3Vlcy5ndWl4LmdudS5vcmcvMzc0NDQ+PyBU aGUgY2hhbmdlIGluIHN5bm9wc2lzIHNlZW1zIGdvb2QgDQp0byBtZSB0aG91Z2guDQoNCkFs c28sIHRoZXJlIGFyZSBtdWx0aXBsZSBwYXRjaGVzIGFkZGluZyBnby1naXRodWItY29tLWdv b2dsZS1zaGxleCBub3cgDQotLSBhcyBJJ3ZlIGFza2VkIGluIHRoZSBwYXN0LCBjYW4gd2Ug c3RvcCBkb2luZyB0aGF0LCBvciBhdCBsZWFzdCBhZGQgYSANCnBvaW50ZXIgdG8gdGhlIHBy ZXZpb3VzIHZlcnNpb24gdG8gYXZvaWQgZG91YmxlIHdvcmsgZm9yIHJldmlld2Vycz8gDQpM aWtld2lzZSBmb3I6DQoNCiAgKiBodHRwczovL2lzc3Vlcy5ndWl4LmdudS5vcmcvc2VhcmNo P3F1ZXJ5PWdvLWdvb2dsZS1nb2xhbmctb3JnLXByb3RvYnVmDQogICogaHR0cHM6Ly9pc3N1 ZXMuZ3VpeC5nbnUub3JnL3NlYXJjaD9xdWVyeT1nby1naXRodWItY29tLXhvLXRlcm1pbmZv DQogICogaHR0cHM6Ly9pc3N1ZXMuZ3VpeC5nbnUub3JnL3NlYXJjaD9xdWVyeT1nby1naXRo dWItY29tLWdvLWluaS1pbmkNCiAgKiBodHRwczovL2lzc3Vlcy5ndWl4LmdudS5vcmcvc2Vh cmNoP3F1ZXJ5PWdvLWdpdGh1Yi1jb20tZW1lcnNpb24tZ28tcGdwbWFpbA0KICAqIFsuLi5d DQoNCkxpa2UsIGlmIEkgd291bGQgcHJvcGVybHkgcmV2aWV3IChpbmNsdWRpbmcgY2hlY2tp bmcgdGhlIHNvdXJjZSBjb2RlKSANCnRoaXMgcGF0Y2ggc2VyaWVzIGFuZCBkaWRuJ3Qga25v dyBzb21lIG9mIHRob3NlIHdlcmUgcmV2aWV3ZWQgDQpwcmV2aW91c2x5LCB0aGVuIEkgd291 bGQgaGF2ZSB0byBkbyB0aGUgcmV2aWV3IGFnYWluIGV2ZW4gdGhvdWdoIHRoYXQncyANCmRv dWJsZSB3b3JrIGJldHRlciBzcGVudCBlbHNld2hlcmUgYW5kIGlmIEkgbGF0ZXIgZGlzY292 ZXIgdGhlc2Ugd2VyZSANCmFjdHVhbGx5IHJldmlld2VkIHByZXZpb3VzbHksIHRoYXQgZG9l c24ndCBzb3VuZCBnb29kIGZvciBtb3RpdmF0aW9uIHRvIG1lLg0KDQpBbmQgZXZlbiB0aG91 Z2ggSSBrbm93IHNvbWUgb2YgdGhvc2UgaGF2ZSBiZWVuIHN1Ym1pdHRlZCBhbmQgcmV2aWV3 ZWQgDQpwcmV2aW91c2x5LCBJIGRvbid0IHJlbWVtYmVyIHdoaWNoIG9uZXMgZXhhY3RseSBh bmQgdG8gd2hpY2ggZGVncmVlIA0KKG9ubHkgc3VwZXJmaWNpYWwgY2hlY2tzIGxpa2UgY2hl Y2tpbmcgc3lub3BzaXMsIGRlc2NyaXB0aW9uIGFuZCANCiM6dGVzdHM/LCBvciBhbHNvIHNv dXJjZSBjb2RlIGNoZWNrcywgLi4uKSwgc28gaWYgSSB3ZXJlIHRvIHJldmlldyB0aGlzIA0K KCopLCBJIHdvdWxkIGhhdmUgdG8gbG9vayB1cCB0aGUgb2xkIHBhdGNoZXMgYW5kIHJldmll d3MsIHNlZSB3aGljaCBvbmVzIA0Kd2VyZSByZXZpZXdlZCBwcmV2aW91c2x5IGFuZCB0byB3 aGF0IGRlZ3JlZSwgbG9vayBpZiBjaGFuZ2VzIGhhdmUgYmVlbiANCm1hZGUgKGUuZy4gY2hh bmdpbmcgd2hpY2ggY29tbWl0IHRvIHVzZSkgdGhhdCBpbnZhbGlkYXRlZCB0aGUgcmV2aWV3 LCANCi4uLiwgd2hpY2ggaXMgbm90IG1vdGl2YXRpbmcgdG8gbWUuDQoNCigqKSBUbyBiZSBj bGVhciwgSSBjb25zaWRlciBpdCB1bmxpa2VseSBmb3IgbWUgdG8gc2VyaW91c2x5IHJldmll dyBHbyANCnN0dWZmIGluIHRoZSBmdXR1cmUsIGFzIHRoZSBHbyB3b3JsZCBpcyBmdWxsIG9m IGZvcmtzIHRoYXQgbWFrZSBubyANCmF0dGVtcHQgdG8gY29udHJpYnV0ZSBiYWNrIHRvIHVw c3RyZWFtLCBvciBtYW55IGluZGVwZW5kZW50IA0KaW1wbGVtZW50YXRpb25zIChzZWUgZS5n LiB0ZXJtaW5mbyBhbmQgc2hsZXgpIHdoZXJlIGEgc2luZ2xlIG9yIG1heWJlIA0KdHdvIGlt cGxlbWVudGF0aW9ucyB3b3VsZCBzdWZmaWNlLCBvZnRlbiB0aGVyZSdzIGEgbGFjayBvZiBh dHRlbXB0aW5nIA0KYmFja3dhcmRzIGNvbXBhdGliaWxpdHkgYW5kIHZlcnNpb24gbnVtYmVy cyBhcmUgb2Z0ZW4ganVzdCAwLjAuMCwgLi4uDQoNCkdyZWV0aW5ncywNCk1heGltZS4NCg0K --------------WWo0s63XdDlWzxs3JKNce9dg Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

On 03-08-2022 14:04, ( via Guix-patches via wrote:

+    (arguments
+     (list #:import-path "github.com/zenhack/go.notmuch"
+           ;; XXX: Tests require you to download fixtures from the Inter=
net.
+           ;; See <https://github.com/z=
enhack/go.notmuch/blob/master/Makefile>.
+           #:tests? #f))
+    (propagated-inputs (list notmuch))
Can we just substitute* in the appropriate library reference or whatever is the Go equivalent instead of propagating?=C2=A0 Maybe i= n in configList.go, we can replace -lnotmuch by -l/gnu/store/.../libnotmuch.so or add a -L/gnu/store/... there?
= 

From: "(unmatched-parenthesi=
s" &=
lt;paren@disroot.org>

* gnu/packages/golang.scm (go-github-com-google-shlex): New variable.
---
 gnu/packages/golang.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index fd2335b61a..9959dd118c 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -10720,3 +10720,26 @@ (define-public go-github-com-lithammer-fuzzysear=
ch
      "A speedy fuzzy matching package for Go inspired by the JavaScript
 library bevacqua/fuzzysearch.")
     (license license:expat)))
+
+(define-public go-github-com-google-shlex
+  (package
+    (name "go-github-com-google-shlex")
+    (version "0.0.0-20191202100458-e7afc7fbc510")

Why has the commit and description been changed since <https://issues.guix.gnu.org/37444>? The change in s= ynopsis seems good to me though.

Also, there are multiple patches adding go-github-com-google-shlex now -- as I've asked in the past, can we stop doing that, or at least add a pointer to the previous version to avoid double work for reviewers? Likewise for:

Like, if I would properly review (including checking the source code) this patch series and didn't know some of those were reviewed previously, then I would have to do the review again even though that's double work better spent elsewhere and if I later discover these were actually reviewed previously, that doesn't sound good for motivation to me.

And even though I know some of those have been submitted and reviewed previously, I don't remember which ones exactly and to which degree (only superficial checks like checking synopsis, description and #:tests?, or also source code checks, ...), so if I were to review this (*), I would have to look up the old patches and reviews, see which ones were reviewed previously and to what degree, look if changes have been made (e.g. changing which commit to use) that invalidated the review, ..., which is not motivating to me.

(*) To be clear, I consider it unlikely for me to seriously review Go stuff in the future, as the Go world is full of forks that make no attempt to contribute back to upstream, or many independent implementations (see e.g. terminfo and shlex) where a single or maybe two implementations would suffice, often there's a lack of attempting backwards compatibility and version numbers are often just 0.0.0, ...

Greetings,
Maxime.

--------------WWo0s63XdDlWzxs3JKNce9dg-- --------------9sZI0GcCS0315j6iLYCt5k7Y Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------9sZI0GcCS0315j6iLYCt5k7Y-- --------------LYwbgVuaWPinogTCFd7Q2842-- --------------ye5SnN53FzNZ6bzdBnPwTg3y Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYuqWewUDAAAAAAAKCRBJ4+4iGRcl7sLW AP96W4agSsR6u5RwRBiiNG9cFoESyNI7/wyf+4DiBPx8TgEAy2ZvaXk1v8gjdVTNqu7AVL7QrX7d 8XrOyMvB3JIm4gM= =u4Wa -----END PGP SIGNATURE----- --------------ye5SnN53FzNZ6bzdBnPwTg3y-- From unknown Fri Jun 20 07:17:28 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#56939] [PATCH 31/41] gnu: Add go-github-com-google-shlex. Resent-From: "(" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 03 Aug 2022 18:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56939 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "Maxime Devos" , <56939@debbugs.gnu.org>, <55903@debbugs.gnu.org> Received: via spool by 56939-submit@debbugs.gnu.org id=B56939.16595518367693 (code B ref 56939); Wed, 03 Aug 2022 18:38:02 +0000 Received: (at 56939) by debbugs.gnu.org; 3 Aug 2022 18:37:16 +0000 Received: from localhost ([127.0.0.1]:49942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJJF5-0001zw-UC for submit@debbugs.gnu.org; Wed, 03 Aug 2022 14:37:16 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56778) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJJF0-0001zd-Gj; Wed, 03 Aug 2022 14:37:14 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 0FD9340DED; Wed, 3 Aug 2022 20:37:09 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tTGfRY52VkfA; Wed, 3 Aug 2022 20:37:07 +0200 (CEST) Mime-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1659551823; bh=GOzUi5IyMYDFJ8Nz2/OIPE70UHSGzoBGOQHeu0ezRvA=; h=Date:To:Subject:From:References:In-Reply-To; b=Rji8lXxmfP5rCin8Bha80dkOeuwSJwItQV3/glw9qKSuAmanpnFf8XtflraxAtbhV 7kaYAO2zAAg9z0zSUmtPmcIE2dzml7U+QLsx5ZAOU+NiMJetmztLFKpWJUeJK6aaWu zzySBFpAjte08C5eVjzydalYAp9bsSZYh88DbA5rNvl+Cfg5yUBXQGFyhRRVEa3L8G TlMNm7Vzw1JB7CTs+NE7iwcBdTTOoa5KCcx8CLGqqL2uRlX6r7KvLLbcZy+gVxb7xW DhOmoUqzSCfZbj59dkiHSjSZxFo7XdzDUegZVXIW/jm1s5xgKu9WRDbChCqRcEii+2 TcfCN87jOzPYw== Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 Aug 2022 19:37:03 +0100 Message-Id: From: "(" References: <20220803120439.5108-1-paren@disroot.org> <20220803120439.5108-31-paren@disroot.org> <402d1704-1f18-3b6c-b0a4-2e6ac771093f@telenet.be> In-Reply-To: <402d1704-1f18-3b6c-b0a4-2e6ac771093f@telenet.be> X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wed Aug 3, 2022 at 4:38 PM BST, Maxime Devos wrote: > Can we just substitute* in the appropriate library reference or whatever= =20 > is the Go equivalent instead of propagating?=C2=A0 Maybe in in configList= .go,=20 > we can replace -lnotmuch by -l/gnu/store/.../libnotmuch.so or add a=20 > -L/gnu/store/... there? Good point! I'll try that. > > * gnu/packages/golang.scm (go-github-com-google-shlex): New variable. > > --- > > gnu/packages/golang.scm | 23 +++++++++++++++++++++++ > > 1 file changed, 23 insertions(+) > > > > diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm > > index fd2335b61a..9959dd118c 100644 > > --- a/gnu/packages/golang.scm > > +++ b/gnu/packages/golang.scm > > @@ -10720,3 +10720,26 @@ (define-public go-github-com-lithammer-fuzzyse= arch > > "A speedy fuzzy matching package for Go inspired by the JavaScri= pt > > library bevacqua/fuzzysearch.") > > (license license:expat))) > > + > > +(define-public go-github-com-google-shlex > > + (package > > + (name "go-github-com-google-shlex") > > + (version "0.0.0-20191202100458-e7afc7fbc510") > > Why has the commit and description been changed since=20 > ? The change in synopsis seems good=20 > to me though. I never referenced that issue in the making of this patchset :) I'll change its description to that issue's version if you wish. > Also, there are multiple patches adding go-github-com-google-shlex now=20 > -- as I've asked in the past, can we stop doing that, or at least add a= =20 > pointer to the previous version to avoid double work for reviewers?=20 > Likewise for: > > * https://issues.guix.gnu.org/search?query=3Dgo-google-golang-org-proto= buf > * https://issues.guix.gnu.org/search?query=3Dgo-github-com-xo-terminfo > * https://issues.guix.gnu.org/search?query=3Dgo-github-com-go-ini-ini > * https://issues.guix.gnu.org/search?query=3Dgo-github-com-emersion-go-= pgpmail > * [...] Maybe we could merge the patches adding those duplicate packages standalone, without merging the other parts of the patchsets, so there would be no need for anyone to write them again in the future. > (*) To be clear, I consider it unlikely for me to seriously review Go=20 > stuff in the future, as the Go world is full of forks that make no=20 > attempt to contribute back to upstream, or many independent=20 > implementations (see e.g. terminfo and shlex) where a single or maybe=20 > two implementations would suffice, often there's a lack of attempting=20 > backwards compatibility and version numbers are often just 0.0.0, ... I know what you mean. It's a huge pain. -- (