From unknown Thu Aug 14 20:51:46 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56907 <56907@debbugs.gnu.org> To: bug#56907 <56907@debbugs.gnu.org> Subject: Status: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments Reply-To: bug#56907 <56907@debbugs.gnu.org> Date: Fri, 15 Aug 2025 03:51:46 +0000 retitle 56907 [PATCH] * eww.el (eww-browse): Raise error if there are no ar= guments reassign 56907 emacs submitter 56907 Philip Kaludercic severity 56907 normal tag 56907 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 06:38:00 2022 Received: (at submit) by debbugs.gnu.org; 3 Aug 2022 10:38:00 +0000 Received: from localhost ([127.0.0.1]:46225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJBlI-0006sP-3W for submit@debbugs.gnu.org; Wed, 03 Aug 2022 06:38:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:55146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJBlD-0006sE-SE for submit@debbugs.gnu.org; Wed, 03 Aug 2022 06:37:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40246) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJBlD-0006hG-L9 for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2022 06:37:55 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33113) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJBlB-0004vC-Cq for bug-gnu-emacs@gnu.org; Wed, 03 Aug 2022 06:37:55 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 203F2240105 for ; Wed, 3 Aug 2022 12:37:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1659523071; bh=VQWlIp9TUN+cRqW/7npEIrO4bvtVAcbN0ItxxkCwAhY=; h=From:To:Subject:Autocrypt:Date:From; b=ojmSkNymTZuBQCk4Uw/EPis/14Yd/7IK4OXJJVjuf6MZs8az/qNsFTij5MPG9dMoh MJUY+dv4Owujx36DsoSgsSxDwKAhk7ZAGh06PbYEfD9pIeUmOplnQ8nruzDn1CXH4d hJ+iFJESu7vX2ivtWt53nvPG/nn2koKPU9pdJZ3p0uN+CNPpUYxHeNYlD+ipRFSDGA 4p5FBLJbSZpAKHyIy+yykIOlGsPWgZAYjQ86w350DONSuQDJ0INwuZMH+7+yCATlQX R23k38ao2TYViSULFgTN9nXZDJxVK+4C04EYGHmuZRUfKTRr/tmxX3QC4CCzEQjzhN b+LDe5/qSjRXw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4LySx81Jtvz6tpc for ; Wed, 3 Aug 2022 12:37:45 +0200 (CEST) From: Philip Kaludercic To: bug-gnu-emacs@gnu.org Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Wed, 03 Aug 2022 10:37:40 +0000 Message-ID: <874jytliiz.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain Tags: patch If there are no command line arguments, then nil is passed to eww, and eventually it is given to string-trim, that raises an apparently unrelated error due to the missing string. An alternative to this patch would be to unmark it as interactive, since it appears to be meant for batch use. I had initially confused it with `eww-open-file'. In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.34, cairo version 1.17.6) of 2022-08-01 built on rhea Repository revision: 47f1cae83c269ea43d6b208e055ce536c017856f Repository branch: feature/package+vc System Description: Fedora Linux 36 (Workstation Edition) Configured using: 'configure --with-pgtk --with-native-compilation --with-imagemagick' --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-eww.el-eww-browse-Raise-error-if-there-are-no-argume.patch >From 8b25634cb3f5a486632caa97e20bfe73fa55f37e Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Wed, 3 Aug 2022 12:34:53 +0200 Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments --- lisp/net/eww.el | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 4dbd5de2ef..bf256ec21f 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -349,6 +349,8 @@ eww-browse will start Emacs and browse the GNU web site." (interactive) + (unless command-line-args-left + (user-error "No URL given")) (eww (pop command-line-args-left))) -- 2.37.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 02:33:45 2022 Received: (at 56907) by debbugs.gnu.org; 4 Aug 2022 06:33:45 +0000 Received: from localhost ([127.0.0.1]:50899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJUQT-0008Rs-JH for submit@debbugs.gnu.org; Thu, 04 Aug 2022 02:33:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJUQS-0008Re-CP for 56907@debbugs.gnu.org; Thu, 04 Aug 2022 02:33:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=apyWsLX0yzQiPZsxSZ30ebAv0dfn82UMoItyHFfHqsM=; b=NxPD2oak7d25I3WSgFumpdsRPW ArgU6H3pbV4pennr2JgaJ+7ywikmgRZSlUadL2mTBhJhq9j13D9NH5yESyOXxDK13TS2nh/tH5GpS Pk9jzn+DWFFfsUvH6vfjH6PfiHCtrTs2V/YR57LBULDo4rX2deg9GZflNlgq0A5Msxp0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJUQK-0003zn-3B; Thu, 04 Aug 2022 08:33:38 +0200 From: Lars Ingebrigtsen To: Philip Kaludercic Subject: Re: bug#56907: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments In-Reply-To: <874jytliiz.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 03 Aug 2022 10:37:40 +0000") References: <874jytliiz.fsf@posteo.net> X-Now-Playing: Kraftwerk's _Ralf & Florian_: "Ananas Symphonie" Date: Thu, 04 Aug 2022 08:33:35 +0200 Message-ID: <874jystt4w.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Philip Kaludercic writes: > Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments Looks good to me; please go ahead and push. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56907 Cc: 56907@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Philip Kaludercic writes: > Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments Looks good to me; please go ahead and push. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 08:22:09 2022 Received: (at 56907-done) by debbugs.gnu.org; 4 Aug 2022 12:22:09 +0000 Received: from localhost ([127.0.0.1]:51522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZrd-0007uF-9d for submit@debbugs.gnu.org; Thu, 04 Aug 2022 08:22:09 -0400 Received: from mout01.posteo.de ([185.67.36.65]:40697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJZrb-0007tg-JO for 56907-done@debbugs.gnu.org; Thu, 04 Aug 2022 08:22:08 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 8B01C240029 for <56907-done@debbugs.gnu.org>; Thu, 4 Aug 2022 14:22:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1659615721; bh=Gaua6cXF15Ij0o1z+xYXMm9p2DyztNKDgC3jPjs87Gk=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=aSy7sP0h9wjNUSNe8WJZkKPOxkFpUAHpAOXNHKB78R55oNQjLnktt+skqse4arOEY P2UNjl8m/qRlO485M+YNUWNHqaSaNtjQ8tjXhcM4N+ING9KEh74ZGY+MvsJ7zaY3ha N2uvGAcBxjJKQvQ6rWE/Syda1SNgP3G96m+16BHub4roZAa0r3vsme+9pp5ew2YMa5 GJxIUJuh4WsVJ2WXjdyZqduHxDTNGyDJR5IIUij/TfP+RRVNuTUROgnrqNj0809Df1 A5iJycFvxabKdnRcCN5QcZB9KIIjfaeuvt1vbBXmAdhrDDd2HgYXHgFNeZcu6y/rrU Y9SGL/N3RlxtA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Lz7Bw64mRz9rxN; Thu, 4 Aug 2022 14:22:00 +0200 (CEST) From: Philip Kaludercic To: Lars Ingebrigtsen Subject: Re: bug#56907: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments In-Reply-To: <874jystt4w.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 04 Aug 2022 08:33:35 +0200") References: <874jytliiz.fsf@posteo.net> <874jystt4w.fsf@gnus.org> Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Date: Thu, 04 Aug 2022 12:22:00 +0000 Message-ID: <877d3o9p1z.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56907-done Cc: 56907-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Lars Ingebrigtsen writes: > Philip Kaludercic writes: > >> Subject: [PATCH] * eww.el (eww-browse): Raise error if there are no arguments > > Looks good to me; please go ahead and push. Done. From unknown Thu Aug 14 20:51:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 02 Sep 2022 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator