Subject: bug#56896: closed (Re: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 16 Aug 2022 04:18:02 +0000

Your bug report

#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
56896: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=56896
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark
From: Jim Porter <[email-masked]>
To: Lars Ingebrigtsen <[email-masked]>
Cc: Eli Zaretskii <[email-masked]>, [email-masked]
Date: Mon, 15 Aug 2022 21:17:15 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

On 8/14/2022 11:44 PM, Lars Ingebrigtsen wrote:
> Makes sense to me; please go ahead and push.

Thanks. Pushed as b87400c78b047d242ae188c46c621e0e8a8e69b2.

Subject: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark
From: Jim Porter <[email-masked]>
To: [email-masked]
Date: Tue, 2 Aug 2022 12:13:44 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

Currently, the bookmark fringe icon is a circle. However, Emacs already 
uses a circle to represent breakpoints (as do a lot of other IDEs). 
These are usually a different color, but I think it would be nice if the 
bookmark fringe icon were a different shape too. This would help 
colorblind users, since (depending on their Emacs theme and what kind of 
colorblindness they have), it might be hard to distinguish the bookmark 
icon from the breakpoint icon.

It would help make the purpose of the indicator more obvious to users 
who don't directly use bookmarks. Some packages (including the built-in 
org-capture package) set bookmarks automatically, and a user might not 
realize that the dot indicates a bookmark, as opposed to some other thing.

Attached are some screenshots showing before/after, plus a patch for 
this. I converted the string definition of the bitmap to a vector of 
(binary) numbers, since then a reader can see the shape of the icon if 
they look carefully.
From 0671b44808a07237a1c183e80c7ba713255c9ee8 Mon Sep 17 00:00:00 2001
From: Jim Porter <[email-masked]>
Date: Tue, 2 Aug 2022 11:40:43 -0700
Subject: [PATCH] Make the bookmark fringe icon look like a bookmark

* lisp/bookmark.el (bookmark-fringe-mark): Change the bitmap to look
like a bookmark.
---
 lisp/bookmark.el | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 30a03e0431..53da501316 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -483,7 +483,14 @@ bookmark-history
   "The history list for bookmark functions.")
 
 (define-fringe-bitmap 'bookmark-fringe-mark
-  "\x3c\x7e\xff\xff\xff\xff\x7e\x3c")
+  [#b01111110
+   #b01111110
+   #b01111110
+   #b01111110
+   #b01111110
+   #b01111110
+   #b01100110
+   #b01000010])
 
 (defun bookmark--set-fringe-mark ()
   "Apply a colorized overlay to the bookmarked location.
-- 
2.25.1