From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 56896@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165946763527528 (code B ref -1); Tue, 02 Aug 2022 19:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Aug 2022 19:13:55 +0000 Received: from localhost ([127.0.0.1]:45094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIxL0-00079w-Sb for submit@debbugs.gnu.org; Tue, 02 Aug 2022 15:13:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:53950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIxKy-00079i-6j for submit@debbugs.gnu.org; Tue, 02 Aug 2022 15:13:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIxKw-0000SN-9w for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 15:13:52 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:43980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIxKu-0002pJ-NN for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 15:13:50 -0400 Received: by mail-pl1-x632.google.com with SMTP id y15so14311200plp.10 for ; Tue, 02 Aug 2022 12:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:mime-version:date:message-id:to:subject:from:from :to:cc; bh=tUmhofx/kqQ6o3VY632jD2v4g3A5uGIjXXOl2awxd5Q=; b=qyzX9/gvypzklR/g1iMEQUAFFmdx1mKz6YOCtlhNr5TAT2ulWIcqF5So8yJBPvY3Vt Tq3+Yldae+ZtNxiABaZwFAe4FpOgcUpqtbWzE9rwqc+hNYZifuwYiUrQF5p0Dfr3oIg3 WAGQt6AcleGflZx7knq50DJnLcN2VPIp4tQL/+lsCNgMb9id4Z9AKoSgI+M3t/g9NxRx zIXc4fAilMZcS7B4IgCkUyzZjjKL0lGJ5xVkgoUgEaoQfBQPXGdrlcNLxnjX8uxkzVZ+ 9r+49gwkceGz+nLpyAvBCx+fS7CxgBgQWPn0rnEe97sjPJM8p/6SHmuckIrUu2tZaptj haTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:mime-version:date:message-id:to:subject:from :x-gm-message-state:from:to:cc; bh=tUmhofx/kqQ6o3VY632jD2v4g3A5uGIjXXOl2awxd5Q=; b=psy7OaZYYb2Ys/6q8HBFlHIIqFaPdGdlMcCWkXPyuXQMmdo4TPpfgh8beUIog4dqtF wBPsA8EZx1kMhAeWQTpDhWBL03OV0ZwB9BNeq47EcSoi1ZDquKlzMeqK8QeK4+XLOaAR oMvohWJoHhzP0YsJ57lBWowmTFwcZYpiglowq33VPt8MFRQW/GpLzgki+rI2kMPFvcjK ym/wa3sbNzW+zkrzAn4/nyRDGZkPyeK7g1bZEuxRrvtWQw0gv8CD3q32YT8RSuZtBU/r kLgqonCXPWGm0le774WUrvFTxJModc2uyhk16egjf10TnNwMsQThEPxSWQJYy10wrsyA hjiA== X-Gm-Message-State: ACgBeo2a3YF2ahhtF4XH6jGnQ22fbDVZyNdWiGQX2g0DzlUIRecwrDMq pgdSovDbSx8+lkbE+rUB9iFplTbEniY= X-Google-Smtp-Source: AA6agR5I5rGtHIvhonz5zoPCLWLi3hquKe2g6UUfFPiNsuUVLHAFtYepTixWu6LgPe9eOQnuAZDf5A== X-Received: by 2002:a17:90a:bb14:b0:1f3:5f1:6de9 with SMTP id u20-20020a17090abb1400b001f305f16de9mr987940pjr.148.1659467626679; Tue, 02 Aug 2022 12:13:46 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b12-20020a17090a550c00b001f2fbf2c42esm11306506pji.26.2022.08.02.12.13.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 12:13:45 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Message-ID: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> Date: Tue, 2 Aug 2022 12:13:44 -0700 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------09FE3C6CAA06D0B79356ECA3" Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------09FE3C6CAA06D0B79356ECA3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Currently, the bookmark fringe icon is a circle. However, Emacs already uses a circle to represent breakpoints (as do a lot of other IDEs). These are usually a different color, but I think it would be nice if the bookmark fringe icon were a different shape too. This would help colorblind users, since (depending on their Emacs theme and what kind of colorblindness they have), it might be hard to distinguish the bookmark icon from the breakpoint icon. It would help make the purpose of the indicator more obvious to users who don't directly use bookmarks. Some packages (including the built-in org-capture package) set bookmarks automatically, and a user might not realize that the dot indicates a bookmark, as opposed to some other thing. Attached are some screenshots showing before/after, plus a patch for this. I converted the string definition of the bitmap to a vector of (binary) numbers, since then a reader can see the shape of the icon if they look carefully. --------------09FE3C6CAA06D0B79356ECA3 Content-Type: text/plain; charset=UTF-8; name="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patc"; filename*1="h" RnJvbSAwNjcxYjQ0ODA4YTA3MjM3YTFjMTgzZTgwYzdiYTcxMzI1NWM5ZWU4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMiBBdWcgMjAyMiAxMTo0MDo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIE1ha2UgdGhlIGJvb2ttYXJrIGZyaW5nZSBpY29uIGxvb2sgbGlrZSBhIGJvb2ttYXJr CgoqIGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLWZyaW5nZS1tYXJrKTogQ2hhbmdlIHRo ZSBiaXRtYXAgdG8gbG9vawpsaWtlIGEgYm9va21hcmsuCi0tLQogbGlzcC9ib29rbWFyay5l bCB8IDkgKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9ib29rbWFyay5lbCBiL2xpc3AvYm9va21h cmsuZWwKaW5kZXggMzBhMDNlMDQzMS4uNTNkYTUwMTMxNiAxMDA2NDQKLS0tIGEvbGlzcC9i b29rbWFyay5lbAorKysgYi9saXNwL2Jvb2ttYXJrLmVsCkBAIC00ODMsNyArNDgzLDE0IEBA IGJvb2ttYXJrLWhpc3RvcnkKICAgIlRoZSBoaXN0b3J5IGxpc3QgZm9yIGJvb2ttYXJrIGZ1 bmN0aW9ucy4iKQogCiAoZGVmaW5lLWZyaW5nZS1iaXRtYXAgJ2Jvb2ttYXJrLWZyaW5nZS1t YXJrCi0gICJceDNjXHg3ZVx4ZmZceGZmXHhmZlx4ZmZceDdlXHgzYyIpCisgIFsjYjAxMTEx MTEwCisgICAjYjAxMTExMTEwCisgICAjYjAxMTExMTEwCisgICAjYjAxMTExMTEwCisgICAj YjAxMTExMTEwCisgICAjYjAxMTExMTEwCisgICAjYjAxMTAwMTEwCisgICAjYjAxMDAwMDEw XSkKIAogKGRlZnVuIGJvb2ttYXJrLS1zZXQtZnJpbmdlLW1hcmsgKCkKICAgIkFwcGx5IGEg Y29sb3JpemVkIG92ZXJsYXkgdG8gdGhlIGJvb2ttYXJrZWQgbG9jYXRpb24uCi0tIAoyLjI1 LjEKCg== --------------09FE3C6CAA06D0B79356ECA3 Content-Type: image/png; name="before.png" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="before.png" iVBORw0KGgoAAAANSUhEUgAAAToAAAAyCAYAAADMZheFAAAABmJLR0QAVABUAFQzY8H1AAAA CXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH5ggCEic362qxAQAACtFJREFUeNrtnXlYVWUe xz93AQRkkU1AUDQgTCtKE9NRQ8qWqTSdQs1cSBwflzFMw5zxeVwatZkytZp0VLRpeVxSc3Im MdxyzCYeGxcwxkBMZVFZ4rLIhcu988eF7kXhcshjIvP7PM95Hj3n8Lvv+b6/9/su95xzNQaD wYIDPDw8EARBuJ3RigSCIIjRCYIgiNEJgiCI0QmCIIjRCYIgiNEJgiCI0QmCIIjRCYIgRicI giBGB+YiLm1ew+nUbOpEN0EQ2p/RVVOaMpsjHxzkh6UzSd9XhO25sRouzoth69w0zKKnIAi3 p9GZuZq2hCM7g+mz7kMeXvUkhuVz+C6rWtQTBKF9GF1d1ka+WmUg6p3FdAvW4xQ9jSGLenL+ 1aVcLLKIgoIgtHn0LZ2gi3qRuM/s92hwGZDMYztFPEEQ2s3UVRAEQYxOEARBjE4QBOFWolct Ul0tdUaj7bYTjRatkxMajYgsCEI7MTpT6hy2pdrt0AVzZ8rn9OmrF5UFQbilaOQ3IwRBaO/I Gp0gCGJ0giAIYnSCIAhtHI3FYpHnuARBkBGdIAiCGJ0gCIIYXRumBmb1grBQcHWF9ZdbeVxF js6FoESoaUv6mGH1EHhkLbT3NY42qb+gstEt1DTemiBnBUzd08pPsEDKE6DRNN6iXgWTmn71 BXQJhyO1rfxDZ1iVCWe/hCbvbW7puIrl6z4Clo5V83EV5Zz5BEbcB16u4BUMj/4eLv+frd7e FP3N8Je46/NfHwlf194GotTBp/Nh4J31uREKzy6BPLvXjFecgMmDwMcdPINhxEIoaMVbeEv2 Q/xQ6OoFWg/YabxZRteUsTXsM8OWJFi0CyotQC0cXQOT3lTY82lg4i64WgXvxsEdL0H5VTi5 5NY06LZM4ECYFPvLD7Mv7YBHEqHrq5BTAjmHYGwY1FpEf7WInGPN+6v1W2UGxDjdBqKY4UIl TFsLJ8/DsQ1wZSVMWIv1jeI1sDgejvWDzFIoOABu70Pi+yh+47jWHWInw8dLwfMmPTKqbW70 9pPZaSF+OQy5CHPWwN8Xw14/WJkEzko/xAk6dAC9DjR6cOkAzvrGU6MB02Dy49AnAroPgVS7 KaL5EiwaAV18oJMvRAyErRfqO5wseDIK7poIl89DfE8ID4e45bYRY8YGGHo3+HqCVwDEToWT FeqJ6Ci+kvIZdkCvcAjpBJ2bmDqZC2HxSAj2Bk9/eGgaZFYp16+lHjtlGbgmwp+fAz9X8IuA CYnQxa7Fm3Jh5mBrr971mvgO9VVQPuP3MH0QeHtA90Ewb0zjKaSlDNZOgQh/6OgNfcbA0VJl +aEEh/rfqL4N/b3e2gYaNhdn0ADGT6FTJPw6GnwjYX4yhHeC8DHwg1l5/ubshGfuBx9P8OsK z7wBFWro4wQzV8HzD0E3fwgfBlMGw7ffQC1QlwMHLsD4GRDkDO53wuwxcGiL8hmBdwxMHQsP dLt5nbyiuMWZkHoUPIMg0B8y98M359UtyIn/wIztcCwL5rrAvPf46Ud4vnkTVhvhYB6UXob9 b0Gkq/WYLgp2Z8HpTRDQFbZ8B9nZsG+ebcRY4wxT1kNuMRSdgr7pMO5P6k2dHcVXUj7PkZCZ DdsmN1EhZvjgt7BOB/vzoDgDYtIh/rXGDdKRfg5XFn6EI5nQfwi4ODjv37sh7m9QnAcvVEGy XXwl+jZbvjp4eyIc6A0ZxXBiNaSn2pXdDB8nwKIL8H4GGPIhSQvPzYJSS8v5oQSH+t+gvko7 m5cPw5JQSMmH9GyI3ge785XpW3EAHk+AsIVw/kcoPA7juoNZJX0aUQXpp6FPDDjVz9iaojYb ck20GVo2Oou1koevgNdHQL/fwcYkyDmm7qLtvb+Be9wAHTzYH3KzbBWp00FNkTUZr2ogtB9E +ymPff8LMDoGPJ3AqTNMHAm5J6FKpbLf1PgG2HkA4mdDlLs1/pypcG4XnDIp089h9RqgzALe no7P6z0Ong4DvQ+MHAbn7OIruf7mymc+BztPQMLLEOIMnvfB9Mds7cecB+v3wJTlMKAzaN1g 9Gzw+hwOV6uTHzean0rIXgWBfuBXv3WZAJUN+R0K4e5wRw8IjQJPL+jhBwWXlembtgEqRsEf n4aOWmsdjRplmwaqpo8F9syFLSGwIsFqHroeEBsKH74L+UYoz4KVn4DlKlS1oaWPlpfJNDD0 Res/C3vAPf7gHgFTI9QtiHtHW3LrdFBnss3x+ybD6hpYEQ8T8iHqCVj5LjzYSVnsi3th/jL4 KteanKZyMMXUr0GpsCZwM+ObS6HYDIMC7EYggdChxLq/oatypJ/D6vW0Nogyg+PzvDrZekUn 58bxHV5/C/VrLoYiIKiz7dyAQNCW119/ARTUwrpnYbPWNsorc4byKsD1xvPjRvNTCWEJkGY3 ite4ghv1gwUd6ACdHvT1J+h1YDIp07egEIJimx+Rq6KPBQ7+HhK/hc3/hLsbPswZFmyGkhnQ 2xdcwiFpNHy+DTzb0D0dWhY6sN1rjgWOgGl9fvlCarytX358eRoKT0JMBsxef83UQQMay/W3 QFiuwIzRoJsKJ87CuXOw5yVrYjU6tz7ZTM11080cVxy/mfK1WEHe4Ku19e4AhkKo9rHuV0Pb B6Pg68M/b4Su+Pqbuz5f8AMK7a7vyiWbiWgDobMLLDgEWVn12xkoyIPnfVuRH7d6ROEBISG2 rYtvy32gRYm+GggKhIJcMN5I+2nJ5ObDhIPwwW4YfI1BekTD+n9BSQUUHIfB1aC9FyL1bcno mjC0Zvf93FFJLVRXg6kOLCYwVkNNK8b9Z/bCgTNQYwEnd+igAzf3xomi9QOfYjiVf00dVYOh FqKiwV1rHUFs2Hr9tEPrDxGecOhw0wnQ3HHF8ZspX4t4wfAhsHUF/LcSai/DG2ug61PQW41E 0sGLyVC+FpK3Q3E1lObCRymQr2DIovT6m03AMHjmXtj4lnXkVnEK1ti911AbAglx8NYrcLzY 2ujKcmHbdiixKM+PW43FZG0DP21GZSNCJfrGTQL37fCHz6DSDHVlsOtTMKihjxnSXoFx+2Dd J9Df3Vp+o92tMSUZcOwcGMrg2EcwbT2Mnw5e9nFMsDQWek0BQxOfYTTWx7RAbbX1/2bVja7B 2Ow31WoYNg0HVzeYvg9yVoKHK9yzQHljqPwO5j4G/l7g3xPS+8PqSY0XGPV3w4KxsPwB6BIC v3rNGl8bAsuXwJan4IFB8PBE8OhXv5BqjyvMXwHZs8CjI/RKtn6r1NJxpfGbKx8mWBYLYWEw 6q9wZTNEhkGPvnC41lpD49dCQg08FAw+PeHo/bBlgeMvD1pDUDx88R5kL4bu3tBtAGz6HvQK WoJifR0Y7cxNMPg43OUP0TOh7zDQaWwZOn4jJLlB/F3g4QVRj8OOs7aGqiQ/mqUl/VXizBvW vHdt2Lxhh1EdfT3i4B/rIHsBhHhBQG9I+R60GhX0KYe334G8dHi0i638XsOh4ddOy49DwkAI CICnXodHU2DZoOt9oOgHOFt4vYHV7IUQN/AaCaUVEO8Nbt0gTcUvAeShfqHNkZoIs3wg43W5 11JQe0QnCLcIwwlIO2NdEjDmQspeiBsmJieI0QntiNrzMH8YBHaGbrGgT4LXhoougkxdBUEQ FKMvLy93eIL8OI4gCDJ1FQRBEKMTBEEQoxMEQRCjEwRBEKMTBEEQoxMEQYxOEARBjE4QBOH2 5X+v0IQIHBR8XgAAAABJRU5ErkJggg== --------------09FE3C6CAA06D0B79356ECA3 Content-Type: image/png; name="after.png" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="after.png" iVBORw0KGgoAAAANSUhEUgAAAToAAAAyCAYAAADMZheFAAAABmJLR0QAVABUAFQzY8H1AAAA CXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH5ggCEicujwEZwQAACslJREFUeNrt3XtYVHUa wPHvXEABuchNBFQ0IEwrShPTVUPKLltpuoWaeSFxfbysaRpm6/N4adV2y9Rq01XRtsvjJTU3 dxPDW67ZxmPrBYw1EFMRVC4xIDLMMLN/HGgGheG4HgPd9/M853l05vCb33nPe97z+505M6Mz mUx2XPD29kYIIW5legmBEEIKnRBCSKETQggpdEIIIYVOCCGk0AkhhBQ6IYSQQieEkEInhBBS 6MBWxIUNKzmRlkONxE0IcfsVuipKU2dw8MN9/LhoKhm7i3B8bqyac7Pj2DQrHZvEUwhxaxY6 G1fSF3JwWyg9Vn/Ew8ufxLRkJt9nV0n0hBC3R6GryV7H18tNxLy7gE6hRtxiJzFgflfOvLqI c0V2iaAQosUzNrWCIeZFEj53fkRHqz4pPLZNgieEuG2mrkIIIYVOCCGk0AkhRHMyatZSjYUa s9lx24lOj97NDZ1OgiyEuE0KnTVtJpvTnB4whHJn6hf06GmUKAshmpVOfjNCCHG7k2t0Qggp dEIIIYVOCCFaOJ3dbpfPcQkhZEQnhBBS6IQQQgpdC1YN07pBRAfw8IA1F6/zeQ0dmgXtk6G6 JcXHBisGwCOr4Ha/xtEi4y80LHTzdA0vV8ldChN3Xucr2CH1CdDp6i8xr4JVy3r1JYRFwkHL df6hOyzPglNfQYP3Njf1vIb96zwEFo3U8uMq6p38FIbcB74e4BsKj74GF//Prt7elPjb4M8J 1+a/MRq+sdwCQamBz+ZA3ztrc6MDPLsQ8p2+ZrziKIzvB/5e4BMKQ+ZBwXV8C2/JHkgcCB19 Qe8N28zNMaKzwcbpMH87XLYDFji0Esa9pfLMp4Ox2+FKJbyXAHe8BOVX4NjC5jmgW7KQvjAu /pcfZl/YCo8kQ8dXIbcEcvfDyAiw2CX+WomeqeT9ldrlcibEud0CQbHB2cswaRUcOwOH18Kl ZTBmFco3ilfDgkQ43AuySqFgL3h+AMkfoPobx/VeED8ePlkEPjfpI6N6NWskLoEB52DmSvjb AtgVCMumg7vaF3GD1q3BaACdEVq1Bndj/alRn0kw/nHoEQWdB0Ca0xTRdgHmD4Ewf2gbAFF9 YdPZ2hNONjwZA3eNhYtnILErREZCwhLHiDFzLQy8GwJ8wDcY4ifCsQrtguiqfTX9M22FbpEQ 3hbaNTB1shXCgqEQ6gc+QfDQJMiqVB+/ps7YqYvBIxn+9BwEekBgFIxJhjCn7LDmwdT+ylm9 41Xtu4yviv6Zf4DJ/cDPGzr3g9kj6k8h7WWwagJEBUEbP+gxAg6VqssPNVzG/0bjW3e+NyrH QN3Syh10gPkzaBsNv46FgGiYkwKRbSFyBPxoU5+/udvgmfvB3wcCO8Izb0KFFvFxg6nL4fmH oFMQRA6CCf3hu2/BAtTkwt6zMHoKtHcHrzthxgjYv1H9jMAvDiaOhAc63byTvKp2i7Mg7RD4 tIeQIMjaA9+e0bYjR/8NU7bA4WyY1Qpmv8/PP8Lz7Vuwwgz78qH0Iux5G6I9lOcMMbAjG06s h+COsPF7yMmB3bMdI8Zqd5iwBvKKoeg49MyAUX/Ubursqn01/fMZClk5sHl8AzvEBh/+FlYb YE8+FGdCXAYkvl7/gHQVP5dXFn6Cg1nQewC0crHev3ZAwl+hOB9eqIQUp/bVxLfR/tXAO2Nh b3fILIajKyAjzanvNvgkCeafhQ8ywXQepuvhuWlQam86P9RwGf8bjK/ak83LB2BhB0g9Dxk5 ELsbdpxXF9+KvfB4EkTMgzM/QeERGNUZbBrFp55KyDgBPeLArXbG1hBLDuRZaTGaLnR2ZScP XgpvDIFev4N10yH3sLYXbe/9DdzjCRjgwd6Ql+3YkQYDVBcpyXhFBx16QWyg+rbvfwGGx4GP G7i1g7FDIe8YVGrU95vavgm27YXEGRDjpbQ/cyKc3g7Hreri53L3mqDMDn4+rtfrPgqejgCj PwwdBKed2lez/Y31z3Yath2FpJch3B187oPJjzmOH1s+rNkJE5ZAn3ag94ThM8D3CzhQpU1+ 3Gh+qpGzHEICIbB2CRsDl+vyuwNEesEdXaBDDPj4QpdAKLioLr7pa6FiGPzhaWijV/bRsGGO aaBm8bHDzlmwMRyWJinFw9AF4jvAR+/BeTOUZ8OyT8F+BSpb0KWPpi+T6WDgi8o/C7vAPUHg FQUTo7TtiFcbR3IbDFBjdczxe6bAimpYmghjzkPME7DsPXiwrbq2z+2COYvh6zwlOa3lYI2r vQalwTWBm9m+rRSKbdAv2GkEEgKtS5TH605VruLncvf6KAdEmcn1er5tHWdFN/f67bvc/ib2 r60YioD27RzrBoeAvrx2+wugwAKrn4UNescor8wdyisBjxvPjxvNTzUikiDdaRSv8wBPagcL BjAABiMYa1cwGsBqVRffgkJoH9/4iFyT+Nhh32uQ/B1s+AfcXfdi7jB3A5RMge4B0CoSpg+H LzaDTwu6p6N+V+bZlaWxi7VDYFKPX76TOj/lzY+vTkDhMYjLhBlrrpo66EBnv/YWCPslmDIc DBPh6Ck4fRp2vqQkVr11a5PN2thpupHnVbffSP+a3EF+EKB3nN0BTIVQ5a88rkVsH4yBbw78 byN01dvf2PYFQCBQ6LR9ly44iog+BNq1grn7ITu7djkJBfnwfMB15Edzjyi8ITzcsYQFNH0O tKuJrw7ah0BBHphv5PhpqsjNgTH74MMd0P+qAukdC2v+CSUVUHAE+leB/l6INrbEQudc4OZp O+a0WaCqCqw1YLeCuQqqr2Pcf3IX7D0J1XZw84LWBvD0qp8o+kDwL4bj56/aR1VgskBMLHjp lRHE2k3XTjv0QRDlA/sPNJwAjT2vuv1G+tckXxg8ADYthf9cBstFeHMldHwKumuRSAZ4MQXK V0HKFiiugtI8+DgVzqsYsqjd/kYTMAKeuRfWva2M3CqOw0qn7zXUh0NSArz9ChwpVg66sjzY vAVK7Orzo7nZrcox8PNiVjciVBPfhHHgtQV+/zlctkFNGWz/DExaxMcG6a/AqN2w+lPo7aX0 3+x0a0xJJhw+DaYyOPwxTFoDoyeDr3M7VlgUD90mgKmB1zCba9u0g6VK+b9N80LXUGHTqtjZ Yf1g8PCEybshdxl4e8A9c9UfDJe/h1mPQZAvBHWFjN6wYlz94ajxbpg7EpY8AGHh8KvXlfb1 4bBkIWx8Ch7oBw+PBe9etRdSnXnAnKWQMw2820C3FOVdpaaeV9t+Y/3DCovjISIChv0FLm2A 6Ajo0hMOWJQ9NHoVJFXDQ6Hg3xUO3Q8b57p+8+B6tE+EL9+HnAXQ2Q869YH1P4BRxZGgOr4u Cu3U9dD/CNwVBLFToecgMOgcGTp6HUz3hMS7wNsXYh6HraccB6qa/GhUU/HXyMk3lbz3qFv8 YKtZm/h6J8DfV0POXAj3heDukPoD6HUaxKcc3nkX8jPg0TBH/30HQ92vnZYfgaS+EBwMT70B j6bC4n7X1oGiH+FU4bUFrHoXhHuC71AorYBEP/DsBOkavgkgH+oXLU5aMkzzh8w35F5LcTOu 0QnRDExHIf2kcknAnAepuyBhkBQ5IYVO3EYsZ2DOIAhpB53iwTgdXh8ocREydRVCCNWM5eXl LleQH8cRQsjUVQghpNAJIYQUOiGEkEInhBBS6IQQQgqdEEIKnRBCSKETQohb138BKjGACDzB RmwAAAAASUVORK5CYII= --------------09FE3C6CAA06D0B79356ECA3-- From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.165946792128614 (code B ref 56896); Tue, 02 Aug 2022 19:19:02 +0000 Received: (at 56896) by debbugs.gnu.org; 2 Aug 2022 19:18:41 +0000 Received: from localhost ([127.0.0.1]:45104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIxPc-0007RR-S0 for submit@debbugs.gnu.org; Tue, 02 Aug 2022 15:18:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIxPY-0007RC-W4 for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 15:18:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:52082) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIxPT-0003bV-PD; Tue, 02 Aug 2022 15:18:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=JutRUlDKdZfwedFeqBXF2fRN1cMwCEa6nMAOjs3wrOU=; b=PpQlt3FIrDQV KOHsj+HelkUPQe9dNA3sT5ETZz4kCASeh8ydQsbo8MfxdWfRTZVqR1gBCBWGyG8lGkDneogDReNzf BWiOC/n9FoAdylPQm5yO8yq+x+bHNxPLWtsZk4dBmw+PfTcxK8ZPnv+gF3RA0CRHpwaf2tshby/Da RYGm75QQE5NJKxnNE5T/OxIgpXDh+tk/wgW64nCkj9hL4O8E0MEWN+IBYlL2uEDmhE6izqfRZmz+W Y4iy77id31eWTGUFBYMTqdvWeLDaYt4xPPzjzrGzaZyPmb0o2vA4pxoNDjOBo6v5wMu/UCp7ltnYt bIc+uKPkkJ0gmcm4Xh0x0A==; Received: from [87.69.77.57] (port=2097 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIxPT-0008Mf-90; Tue, 02 Aug 2022 15:18:31 -0400 Date: Tue, 02 Aug 2022 22:18:24 +0300 Message-Id: <83tu6u5u9r.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> (message from Jim Porter on Tue, 2 Aug 2022 12:13:44 -0700) References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Jim Porter > Date: Tue, 2 Aug 2022 12:13:44 -0700 > > Currently, the bookmark fringe icon is a circle. However, Emacs already > uses a circle to represent breakpoints (as do a lot of other IDEs). > These are usually a different color, but I think it would be nice if the > bookmark fringe icon were a different shape too. This would help > colorblind users, since (depending on their Emacs theme and what kind of > colorblindness they have), it might be hard to distinguish the bookmark > icon from the breakpoint icon. > > It would help make the purpose of the indicator more obvious to users > who don't directly use bookmarks. Some packages (including the built-in > org-capture package) set bookmarks automatically, and a user might not > realize that the dot indicates a bookmark, as opposed to some other thing. > > Attached are some screenshots showing before/after, plus a patch for > this. I converted the string definition of the bitmap to a vector of > (binary) numbers, since then a reader can see the shape of the icon if > they look carefully. Why not make the icon customizable, and offer several possible bitmaps to chose from? Hardcoding a single icon will always annoy someone. Thanks. From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 20:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16594707512080 (code B ref 56896); Tue, 02 Aug 2022 20:06:02 +0000 Received: (at 56896) by debbugs.gnu.org; 2 Aug 2022 20:05:51 +0000 Received: from localhost ([127.0.0.1]:45148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIy9H-0000XR-Aj for submit@debbugs.gnu.org; Tue, 02 Aug 2022 16:05:51 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:40874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIy9D-0000X0-RV for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 16:05:50 -0400 Received: by mail-pj1-f49.google.com with SMTP id s5-20020a17090a13c500b001f4da9ffe5fso9414235pjf.5 for <56896@debbugs.gnu.org>; Tue, 02 Aug 2022 13:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc; bh=9GtjR5BHP2sGK1g5i1OqsXnlzNkl80z5f4h7qvXxQH0=; b=IbbcGrbR2mOMVsduCB0mQsX+6a1hKfNxW1LahjaU1KRWo+kjBesPiEYIJTP91vOxLU 7Zj2AVhNpHkRfhsvsob10QuEDdRjQcEfpaP7ACv0Am1kdXG/t8w3OYs4SG8rgkhsnOOZ mDAPyz/mN6UCFosdl8nS/81YLLEVFG9LbGQfZVcB94gQji4iegAn/Sz7RU5O/MpITIsc q6C4P6NVJku759Hpzm7opjQji6ZdDHcqSgtfVAQf3vJIqWzI6V5Td8j/TCBKi8UMLeqS Ld3num8kwi7Nb5PBEWDXJEm2jbU6i1THatoVF2FTZdAY+2Gi2L04DSMwuy4YFYkFIxKy cd5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc; bh=9GtjR5BHP2sGK1g5i1OqsXnlzNkl80z5f4h7qvXxQH0=; b=oZ/E9W+aNfvpbXSvNv1LLSfW6as133BMz759v+NxdFD2295EyROzy28RKfrKaT96FA 5Isc/CbT6LHOhBV3YLxBEEYscKBnOuFXhxUsKwlZe8E7Ghj+HKbt3DPaLumLRkg/m4Zt z43+EHKup7mqnC2fyoV9NdNMAiF2fei4OSzUuezV8rNBk6hEdDsqnMz/3M8rA9is0dWv grWBZ/TdQg71Z1NMKEij7LRJuxQc+8V7sKmsjTJRh83yBwikuhsKBgzwA3bizY2PDIQm qLjvQ+05T6olqxgijiLIFSwj6rynEjtpPsfwbkZN7CWMSLf33swfU5kR0x9q9RhztgXh dggg== X-Gm-Message-State: ACgBeo3U3wAjZ/p0rfWPMODmkWXIdswHtYqJ1gXdOwGhudNSC4qxmWwe CCgeHzgFyMG7jp9Nwag1rLKXBthHElw= X-Google-Smtp-Source: AA6agR4lP7fQaVpR4RZMgPzuO1XugAdvc8RSBNiVPvlMxHeNTv6tZZ0qSt+mQTou2e6ukjSkFYeMaA== X-Received: by 2002:a17:902:8bc5:b0:16c:f48b:d5b5 with SMTP id r5-20020a1709028bc500b0016cf48bd5b5mr23390300plo.128.1659470741874; Tue, 02 Aug 2022 13:05:41 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id bt21-20020a17090af01500b001f1ea1152aasm8859856pjb.57.2022.08.02.13.05.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 13:05:41 -0700 (PDT) References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> From: Jim Porter Message-ID: <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> Date: Tue, 2 Aug 2022 13:05:40 -0700 MIME-Version: 1.0 In-Reply-To: <83tu6u5u9r.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/2/2022 12:18 PM, Eli Zaretskii wrote: > Why not make the icon customizable, and offer several possible bitmaps > to chose from? Hardcoding a single icon will always annoy someone. Sure, we could make this customizable. What would be a good way to go about this? I see three options: 1) The status quo: users can already call (define-fringe-bitmap 'bookmark-fringe-bitmap ...) to make the icon whatever they like, though that obviously requires writing (or copy/pasting) Elisp. 2) Let `bookmark-set-fringe-mark' take a symbol for a bitmap to use for the mark (it currently takes a boolean). This would solve this immediate case, but not other similar cases. For example, what if a user wants to customize the fringe icons in diff-mode? 3) Provide a generic way to select what any fringe bitmap looks like. I'm not quite sure how this would be implemented, but it would then allow users to change the appearance of, say, the `left-curly-arrow' icon. (In the past, I've done this via (1) by just calling `define-fringe-bitmap' again.) From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Jim Porter Cc: "56896@debbugs.gnu.org" <56896@debbugs.gnu.org> Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16594710472575 (code B ref 56896); Tue, 02 Aug 2022 20:11:02 +0000 Received: (at 56896) by debbugs.gnu.org; 2 Aug 2022 20:10:47 +0000 Received: from localhost ([127.0.0.1]:45154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIyE3-0000fS-0H for submit@debbugs.gnu.org; Tue, 02 Aug 2022 16:10:47 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:14878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIyDw-0000fE-Gl for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 16:10:45 -0400 Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 272JIspr017323; Tue, 2 Aug 2022 20:10:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=ZOCHkrlyDqqURyV+1/Fx75CIxh4/MDgmmGC+5E68/9Q=; b=EBg01oSX+A0/AiPILX6kUHE7tg1NAJo+b9kLGDMfTOia8THU7b76I67k54ptrkWOLWZQ bwNsqBRYq045FxsMn7WlEKYGiT6xyjZ3nZ7LeT3lQNJYZqwWg2J1gKyCkJAaBUzZLdqA MLGT1E2zrFEndM/jHiJ82F1XgijTFftr9EX9ncUmwVKlWByqU27WwoUGCRcx0SToo8K7 j+766poUCtwN7cXP0Gv7rSWqqhQJgL0i9CU91Wb8YXpo4h3VjlEHUP0maIOXRBfHkJUK fuYwol1KgSB5Fy7e05L4jMtoRBCVkVz1NxPMVrR+Tq/Kh7syMQVskFQDtAc7ZzRAjg4j GQ== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hmue2r64g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Aug 2022 20:10:39 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 272HiBPa007338; Tue, 2 Aug 2022 20:10:38 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2106.outbound.protection.outlook.com [104.47.55.106]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hmu32dd3p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Aug 2022 20:10:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PXlLIoIGQocxK29ltG0j1N+qfDaz1+Za0HH/N0lRG+Vkx+h9h0sKCzVgxkLBdHt35Bbhi09gK0vkVu5JEUCyh32KzFMKY8zAoFRit36n7hcfnCf4SdKLNGEZdVMDkoFiFZeXmb6viNZLHih0AisTCUgn2QPhv9s18pxrG8xodF1bxYXV78GaHUzMUToAxIN1ydVYq7MW2fAEGtORXLDB4wwz8qrTfTfPVSJ4+tojuZPnVv6cZcWKH0eizq0S0/qIkWoDNVOueiU9qH81c7vkSazlzKZtpUlOxr4ONEvdvTFAqDxD1L0Mi0ErUrfOlAmFqjS9JrU+c8eg0J2/JBcaWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZOCHkrlyDqqURyV+1/Fx75CIxh4/MDgmmGC+5E68/9Q=; b=EGkr1areIu0sXlPEA7OsMEuRS5bI3LNwV5XF85dbZyEvkogD02IUb6GuE3+5gXA2ZjZWUf9d1vgVM2AaRMqwx+IyvJzTdLhRhtX3TQvv2a1nlyPoR6kyo0/e9J7agpg+41EDe7q4S0Hy3CPitShlCtNiVnMyVqDHjCUmLrLoWhUvlFH0eBELpz6D5P8UEy5QF8P1vonuIGZS3wWirfZPvIY515Zg6cKgffORVN0PE2GpNWcdsQ+6ja+s7E8ZdbQJ2gbrzYPNm7morFN932jJv9A5oFIZQebfFewFkMsY9pTZ/nW2YvXyi3u95hkl/IUpQdU0S9ovLfFtEioumfrrkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZOCHkrlyDqqURyV+1/Fx75CIxh4/MDgmmGC+5E68/9Q=; b=ikr8oMwyLHiX8wDhN3N/1q/I54EKbRmeN4n1lCnI+sU6KP4tr3hZewR8Ltx2tPqAOxKWzC1nMQJD2KBW/ROcrgp4z+WWFmpxRS3qsmW+dIiTpvSFLNZ+95IcfysTk12zMbMZVYiQoiE4ZJ045fyUUJ189Vk6/SPB5fF7UGkN0jk= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by BN0PR10MB5207.namprd10.prod.outlook.com (2603:10b6:408:12c::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Tue, 2 Aug 2022 20:10:36 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::8d65:31e6:cd0e:e95]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::8d65:31e6:cd0e:e95%5]) with mapi id 15.20.5482.016; Tue, 2 Aug 2022 20:10:36 +0000 From: Drew Adams Thread-Topic: [External] : bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Thread-Index: AQHYpqUWgTfQ0OVuZUKlXi4NQXW6Ha2cAN4A Date: Tue, 2 Aug 2022 20:10:36 +0000 Message-ID: References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> In-Reply-To: <83tu6u5u9r.fsf@gnu.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 10dc5359-1acf-488e-573d-08da74c31034 x-ms-traffictypediagnostic: BN0PR10MB5207:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: EcGITFkbeMkNq1oX3KCyTrbNXN5CDRFV1uTxC1ftUd/0D0YB5ht5Fk2fYC6PvCJNjl8hN0zVCUOl5bUzdcHq5PZm8WbVk1ielAIirrPrduXfDNZIEoHEZHMmRcl/tWtEvVI+upC78POK/C5DmzPsaGLwQXtRPYwkbkKQacX961xmtySs3aYwac8tP2wq+SZMrPxJUg+N636Jr0A66O0XLWzOSqkOXnjrOY7d6fG3S0yLKu2jYAT9rwkojvXSdT9R4y3OLu/X/ST1cx06/xlv/4m7ADRkTkqhif46HCreEjogqg6eR22VrgsqbYsXfDVnH70rxfi5MCYmnYR7ghFHc1LcKX+RfKNcNNAi52mkkrQUi3Iuxh+RWP2Xy6aQafPaBVFd4Q8dGOjc/mG1scX0uYY4vf7wqM+1LHN5Za4G0/Kia0eVft/PDg3mTA3b8TK/9Fz6ulsRqM1rl/IhWf4C4TftSm6QfU6HP4x6SYKYFrvULXfNgSZL+DTz470g+eIw3cBUTLxawwxWHEQ+xqjiNAL1kgGzmwS47RaRDvzCFdFT/2yYTRmAh9not5C9pMbqhqAkiexXa/vtjCFpDu9JUqtKKQixhocUbVCGhjkWUP837MFasohldAT3cMVWBmz5fc5EmWjNKUJnVVWSJZ2SIM6+9P9czq/skgLwPXMNcrzAB/97PWEmjshSIKPC7gJjPhp6J4rWcCn/Uo8lmJUTvEhpFz+Cgvk0PsMUJ+g/KFP8uvFn/zVOvMcMKPby0MUj81R8bu70RzquSSLuyXEoc9kCPRn6uFFSVnvusffofjV0A3z2a5Qz9pq+idtw6J9O x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(396003)(366004)(39860400002)(346002)(136003)(376002)(26005)(7696005)(6506007)(186003)(5660300002)(44832011)(8936002)(9686003)(4744005)(52536014)(33656002)(110136005)(478600001)(71200400001)(41300700001)(76116006)(122000001)(86362001)(38070700005)(316002)(2906002)(66446008)(55016003)(4326008)(8676002)(38100700002)(66946007)(64756008)(66476007)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: dPdHH/0h4ZGDbBir9AysyVQwM7EIvhgyF9mrL+6IBIbU+c1mx3/CyoLhzPFazCbsNaUF2LdXHejy4z/5qUVT/MIy6JoHjwcp6wNWn3j13YBh9VHHF3eeKfDXjkJo+6A8a2ucrrxjS1n01ZEPr9zyXsVM2jY82QGGoFHlxmD92qrzENRBACJonZlcMzmDgc5HgOeL4E7G7fLfFLwhRFQ0H9ytNFX7pGxjBS9ef2P+r55o2IT/xe2/QweLOjau4AL+G1rJfP553mVi9b/wkcEON9aZY53zCYLEMP260aWaCGP1MRbNL5M5MpiirlCKvZCFkZKoKSA+ZI7e+MQ2vfxVtmg4OJb1FqOcmXskQIT08wtXPwJC0eF+WRiLZFId4FKqrvEXzqBwpXf0dVDt41QwSYkpEyg2Opj/TggTUb1t44jFbQnZgeG8mhXUVBIC7mPJE7Rj9w9nwSlmTAC9LoqGD+o+bbFJBXW8ydtcszu9bLn5JyrqF+spzYnwRegnpGb4mKLkFXZ2fI0O2L7r2DHKgbCQ4nT5poZ4/rd0DbqdrcBEv1uT3K4Ary1PJKMzAsUz47NSHA8nAgepixvrNOpT6xkC51422rOlAmXhlKTaTwNEypY3q9LrNC5j5FVXVu4ODRCbhcojYuKrg9xcORpwFfZfxbdE5+cKsyAKaNgGDq6A4cNfR4BH3VSX/mw720tKvys5QC1/tCohPi+XAUfIC9/cnQQsI8RyzWeuY/tAVx4B5IvrcO1EwajSYbdZOzfuxHkx48wnz3Vt8torbpofuWDF9IfFAyS4nSiEj6S8YV/FudK6LGzn8LvpO+M6lIvgZ2kb2nIkgFPxYpGvltgalg+gyLGJR5U//kK8+sLSaKq/ZJb38ienElcZ3ItoZBrczWGbR/4KniDJRNL2A7ZsK5Wv6A1it/WWT5+b1rx7Wlbl5BjvJMN7laoT1cl2c/nNq2B3Ho0LxOWqtUeQu7+7qL4/9Yj4xWdbrVSI91u9V+T3PD2B5Jb/hE6SZlgjLQFy8AcghtSwtpyZji2HTlJHY3cvYEkWYbYByKcfFY/VLHppC9HQhnFLJmmbgjDSsS/dzY38mK4PjKbaYCfpZ6YM+dEAUzd8kqdRT9+vG06tyMXNyCpOY+vbHGV5A1I/mWyToLFMel10rLUzS2ZxAPac+azS5rZjFz+GhKeIzEZIL9T48ZAU41efiLQ7bpbsZLRv6i9LsDHRkmClHU3dxACH9ID+gSS+DE8o72rd6X43fWsnrnxiKkBrREfkuCDhemJ6SkWx5wE1YHDLQBrDZDtL+ZCaQnHI6kO9rtD5Ku7Aev7mUmzXt4r2unU6fWAwMe//dGfW8LIlEvmKe03o1XW2ZgJ7hCgKjSkz+Rp3mZFlKS11s050/3rEGJmLLOmMIf6VoZnZjCYQSBs95SEL1ccg2GDTw9RmJRrkESfQAiFXb7QBRCdlSQTSdHz+SrhWGuuVhjLpBXt/57ALWSKTiU8qOZ6FobcxZFds5gXyBSUu0d4LAQ1x+guAqm+kMJuuZa/Ad2GgE+VGWJqwO6bR/YcWG3xLMFYb8uG61ukbMa7GaEtHKtivZCTq95Eqqdk2JDu9 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10dc5359-1acf-488e-573d-08da74c31034 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2022 20:10:36.5344 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GIVvp85kCT/NKSXVmmTcQgt9aJMTw4hDLYRePU/muEXjFfmExgl+W4C41tWPch6/kfNyatnkRPSOFfyitPTsZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5207 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-02_14,2022-08-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxlogscore=831 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208020095 X-Proofpoint-ORIG-GUID: HfJbA0tx7dU_9HtYJQBEsyEbiexNPlYL X-Proofpoint-GUID: HfJbA0tx7dU_9HtYJQBEsyEbiexNPlYL X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Why not make the icon customizable, and offer several possible bitmaps > to chose from? Hardcoding a single icon will always annoy someone. +1. FWIW, Bookmark+ has had this for a decade. Two options for this. Uses predefined var `fringe-bitmaps' for the choice. (But really there should (also?) be a user option for such a list.) (defcustom bmkp-light-left-fringe-bitmap 'left-triangle "Symbol for the left fringe bitmap to use to highlight a bookmark." :type (cons 'choice (mapcar (lambda (bb) (list 'const bb)) fringe-bitmaps= )) :group 'bookmark-plus) (defcustom bmkp-light-right-fringe-bitmap 'right-triangle "Symbol for the right fringe bitmap to use to highlight a bookmark." :type (cons 'choice (mapcar (lambda (bb) (list 'const bb)) fringe-bitmaps= )) :group 'bookmark-plus)) E.g., setting `bmkp-light-left-fringe-bitmap' to Jim's `bookmark-fringe-mark' (symbol) uses that fringe bitmap. And yes, it would be good to add a bitmap such as Jim suggested to `fringe-bitmaps'. From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Aug 2022 02:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.165949342315886 (code B ref 56896); Wed, 03 Aug 2022 02:24:02 +0000 Received: (at 56896) by debbugs.gnu.org; 3 Aug 2022 02:23:43 +0000 Received: from localhost ([127.0.0.1]:45594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ42x-00048A-Bb for submit@debbugs.gnu.org; Tue, 02 Aug 2022 22:23:43 -0400 Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]:44113) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ42s-00047s-E0 for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 22:23:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1659493411; bh=CTLpTc3ZDWx++wfjlNhlKBfLBQQcCC1y/V7UZxy9iKs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=tv2A0B49TssvzGWRk2nSYusOrtFSDgV7h31FkLfb+LeXm/KA/jUkzzbq5UGyMPrXCeT0Ke4ChLpc2SokjG9w8Wh5uXBKKYqpeyZ5+kNrSyWCxVyfpc4JueSFNs6gWDW6cjyLFBNqoUgxnEodOhuFeLypPUOU868LUgVopS0Kspr+xxaTavV7gsTb3fh0dn3pviHs9n6cPx1cKtM/QqBFQfcqvkk+MtR0kocf+GnCKrFQh211Q5wuTOArWUDFFUMhidXhqKoBcSudXwvR3u/WNNUaLwikouLrmxxfKdfQ8ZyE6LVsVGTxhmDsyVq8JfIGimbsSSgKmbacrsPR53cH1A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1659493411; bh=zYpckcLvUVrnv/7QkcyEZPcJOXQGINkZfZJDGhaEIrG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=SXd/mvUhbS27Opvs4DJAg9mPzSFicO5sgmG7K/ZnI0Liy9dSt1KZ10Jjc+5O8I/MAQNXSEkFSDny0VYU2SoIs8/mVonsc5rvDOHFnDoi5oeyge3pw2j7xHyIphci3xD7c5T5ZXHj61w9GDRbNhT7+TiHFmKkQfI8Ut9XYH7deYKw20lss6D+JQ9+DEuwdG2fhrOcPJr7u8wpMvYCWjbWPxzaFk2+CRv0K/9857M8hAuEUsyxBNToE2lLFSakjO6fOVAgK5RWGWIOGxpKNoebuW5LWI+9ZUTmCvPwT3IM84ID8x1di59WnXcmeRpztEtXeUYkJZ3NfNdeuFkeKperag== X-YMail-OSG: I6iKCsIVM1mtRN8t3GSkFRquF_RzpIQqI9YAd32BecahKYiPgy4RIBPE3V1yQd3 wToWwAFgOmBaT43y9rqgpkI5EBLHMtomjto..H0s3OB_AUcWXWd5r3BarHn4S50AJI8LuVEC50l1 Wvc7qKD_m8N68DUaWWvhxISGsEf1ubNZGidrHBRbQDjTq9G1Do2lv.zK4qUX0LVOiYE5g5BGfOy1 wQzUKoq09sfUQtt16qmZ1zvVGwcA1RxTP2h_wpR037bFzzrkoB7q5Gf9uGBdnsyVlzSdAZLgVB8L oN2_QrTVS.RGo1O2JcU0IMlJCDSREEtWc_dvuteNiCCtoNGtzAndyqAFGhKywwNib8prgeC_EDz7 Gnu0xZrxlH_aJ7Mi3L5s4q0J1Uk2FPD3I4Aw_K7VhcWDPvva4STQrY1X06Iu_GnkzGoCO7IE1999 umrV84TxCRC8X9BL9JGY8lfxTivVQetC2iBTgDVnZ00WgAXp7op8ttLYW.GW2bozHmKWN2_iypAb Wu3EQQ7snBVn.41jM3SK6JG54Snq9E.hL0YFEtNea_FNWmbqPv.BcneOvQmgk.O.aiGRY_7SpudB PhbgXBXQlndzu1Byq4q.8Jo585v9otLn1bvQ_4gzAFAJ5sWr2IQsShAK0AT1oOQ4ORzNPRMvzorx 7oFUXPEgUYYTTBUPy1hrFTtFDAATECHCxhFHOO2iEUHadLPYSoZwiMukgRJfZ.EoW_lJvLKUkVys o9aGVtUPosQrD.B821uRKrOKOE.gMGLRC.YHFv_4qSCmKC4h9zvUzwPOEfYayMFpGibIH8ML8ZE7 YjCsTqAuYwYyPGyMsL45ngC9_cVU.nKYYYIlZKDfWpN.wLKmQTmU8Mtv_KR.n955AxnJfLnZwxZn PE1GhIl1iG06nsze4OhMnMHB1gzYfJurxqLjQhXCiwaDblc.E1ohjXVLgR5bQTgzp0KNcxpp.1aI btoecYw73K_47bba7sT4XeU7H_xpqchvm94c3napBxQNFnFoMPPJxnLvxSiz9bIEOF_BEZd3ZQTh zXxk4e_JnG1AAY.zdWPPIhl4qEyyWoBf4GmrMwtHOhefEizRQ40TQdbP3ieXn7aVEtdfnj4qYCZM eFomVFWAgcBJgZCLB6mquGyVdraxtBz1B7uzOnj.Mo9o3ppu38Ko9NzpmVOG5.jpPQG2GSWWaW4Z fK7H55gZPNOXe7HBDU8qi4Ak3_YpwqXDroSx1JLbuq_i15le3LBGtU5UlXQlO80lJ59iAb2pnbUH tVqvEIeCzAG1jGExe96O1DxmRE5c2j7WXlovaqS_cEwUXzXfNiZXr2K8a6950fshknrIGNplGb4R Kdq.dnpZt2WCSLwearZ95aKnk6j0gLEdDK1A2YOhadTiU77Yn6wgXT19InN1N_LH68LlOsgj7.sF icckh6BefPJiiU.TusU901vYOOmt9eQl_8K25SvjxeIfRdtNA0lYpoo27PvTu9lus.Zscf1AVWf. N87utr82qV2YqF4CA6yNOS0F6yKIU.8A7XtTkDwNktKBTNeLlcQEbvU8wwAPcZMvKOaqCLt8uTGh cWl3XKJzm4A0s2p5pCILBiDRD9schwfpm18eTDU4Rxk9qnIr2ba93n0vqdMejR0hoq3IU_Mt3Q3J NSx01ibA1bCKp5_eMlxf1NlCr7.xZWx8Q1SqUdVOWUnFatrm0KPqK6qiJ07ZuhlUMkn_xhRh8Wa5 eSi36fa2ANMhB.q0zI0Jjkw85qRZtYz5LKqlChBf4Zee.glC5nwLTl19_Wcd05S2iEq6yaPxMs2T HBOEF3lvaJfztTozyCL1clJ4kG3oFjdpXR1k5MXsauHJvYUW6rx_Z5N8foRgWq5PsKahMM_GEqjP 2EpIATuKoOnedhwg7byX6TdM_.CuxAAA8iERI8gF1BFZ85LCkbxRW8ynKpGedYzg6HSbFIUBrl2y bBgExW6TwdvqphbHuAPAz108zr6XaEakoVE2l8Vyo797Vr6w74NaVH5vN.PLsklbPQYdC6Ae7sz1 OfAi6cXnJFwti_6JThULIS_iBEyABkOssQfVNhgt_nJ0ROtNc1h9X3tGfkBXhJDckZH5EpUbwf3A j3XBmFs3ZIISDVwqV52c6g5MY74pRVTtAQu47tfIpiZ3cUIr.g6IvVHCytiTW4arfLheZ18tDBiE AMc3dYiFXNnxn7gJhbRO9k3AtCtxh.YG7ycFAhm48DXkJYKa_0fAeAwMO8kErbyruEsB8Y9HS1_h mIlMTeObcc2pWatgwTzwXlC6QYAlz3xqGY_MhV8sFmrx2xoAuf8zuZa_4D.aByFU- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Wed, 3 Aug 2022 02:23:31 +0000 Received: by hermes--canary-production-sg3-854c886654-ngznc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 27a203dda4b099ab38461a0becc4deb0; Wed, 03 Aug 2022 02:23:25 +0000 (UTC) From: Po Lu References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> Date: Wed, 03 Aug 2022 10:23:19 +0800 In-Reply-To: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> (Jim Porter's message of "Tue, 2 Aug 2022 12:13:44 -0700") Message-ID: <87r11ycbfs.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20491 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 140 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) What build of Emacs are you using? I see that the background of the fringe bitmap doesn't match the fringe itself, which is usually a bug. From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Aug 2022 02:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.165949373216343 (code B ref 56896); Wed, 03 Aug 2022 02:29:01 +0000 Received: (at 56896) by debbugs.gnu.org; 3 Aug 2022 02:28:52 +0000 Received: from localhost ([127.0.0.1]:45605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ47w-0004FX-7d for submit@debbugs.gnu.org; Tue, 02 Aug 2022 22:28:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ47t-0004FI-JE for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 22:28:51 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33328) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJ47o-0007We-6p; Tue, 02 Aug 2022 22:28:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kJmH8vHLlKp7ArSh/kbSsNQO/SfrJq8BHqVM/hr3fcY=; b=cAzesA3fo0kz 8sUqAedgzqFKUG2wvKKZQ/FHIDY3ewJ3+79zspC2UmePXKy+vapbeFrVSx6Ubguu6K1JNMHFWrPEr 2rHcXPWDB2snhCYUcd3w/g+/r76mnXH5Leh8hCMM6fc5Ts4DJJy2VO4zScN9Rc4AyIQqFqaGEfva5 L38t2OWpDIawl/Za3xqKY/vshpDpXIu05AhHHGlVYBwEQYE1F0H3r/m28nH0nc871K7uRC+eDqed6 n2EmHfrFG+cfxTgzLN07ow9CUe0tTTKbuRA1cxSDNyNBDiUPYeX7cBR5fL2e8YyaZpQ/x5xXRf9D1 NsVuQdACimCU3LBxayEC9A==; Received: from [87.69.77.57] (port=4540 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJ47n-0003TZ-Mj; Tue, 02 Aug 2022 22:28:44 -0400 Date: Wed, 03 Aug 2022 05:28:37 +0300 Message-Id: <83sfme5acq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> (message from Jim Porter on Tue, 2 Aug 2022 13:05:40 -0700) References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 56896@debbugs.gnu.org > From: Jim Porter > Date: Tue, 2 Aug 2022 13:05:40 -0700 > > On 8/2/2022 12:18 PM, Eli Zaretskii wrote: > > Why not make the icon customizable, and offer several possible bitmaps > > to chose from? Hardcoding a single icon will always annoy someone. > > Sure, we could make this customizable. What would be a good way to go > about this? I see three options: > > 1) The status quo: users can already call (define-fringe-bitmap > 'bookmark-fringe-bitmap ...) to make the icon whatever they like, though > that obviously requires writing (or copy/pasting) Elisp. > > 2) Let `bookmark-set-fringe-mark' take a symbol for a bitmap to use for > the mark (it currently takes a boolean). This would solve this immediate > case, but not other similar cases. For example, what if a user wants to > customize the fringe icons in diff-mode? > > 3) Provide a generic way to select what any fringe bitmap looks like. > I'm not quite sure how this would be implemented, but it would then > allow users to change the appearance of, say, the `left-curly-arrow' > icon. (In the past, I've done this via (1) by just calling > `define-fringe-bitmap' again.) What I had in mind was 2). Not sure if we need a general capability as in 3), but if it can be implemented cleanly and will be convenient for user options, I don't see why not. Thanks. From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Aug 2022 02:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Po Lu Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.165949455217709 (code B ref 56896); Wed, 03 Aug 2022 02:43:01 +0000 Received: (at 56896) by debbugs.gnu.org; 3 Aug 2022 02:42:32 +0000 Received: from localhost ([127.0.0.1]:45631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ4LA-0004bZ-0Z for submit@debbugs.gnu.org; Tue, 02 Aug 2022 22:42:32 -0400 Received: from mail-pg1-f181.google.com ([209.85.215.181]:38880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ4L7-0004bL-KH for 56896@debbugs.gnu.org; Tue, 02 Aug 2022 22:42:30 -0400 Received: by mail-pg1-f181.google.com with SMTP id h23so1736824pgv.5 for <56896@debbugs.gnu.org>; Tue, 02 Aug 2022 19:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc; bh=8T3yQ/y3tURoTxExrlUMwX9mgI7TSZvf9ynYNa65I9I=; b=XaalbHLtscgLuPdVZHZF1JO/wKEW+2w0MH+cBnkkZBDxrTffdVHQj8WSKLfM7AbiRW 0Spcv+4u/+wFiyDu2PY5GNv+pEk35DXjib+xklNHIxHuU7LwV5F2yywjW8O0fv5xQPUd MhEjoCPpH6bSu+ERPw81mx0tVpWi2pM6sMkvXjvbBuAe5DGuPOljqbox8+333JqKl9Rl w9bD2zchOFNloFZstbG0isRdO4P1KwPsY0fEOoYPCa3nzOdMGvrr1uLjT5ghAGfl57oJ QqMOhKcwbvwXQ52S9mL2C3acfQuXFeo0Oy82pgHYa7dO3pReUHq9Rsr4gwlhU9FjcBO7 4DnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc; bh=8T3yQ/y3tURoTxExrlUMwX9mgI7TSZvf9ynYNa65I9I=; b=S2Is3i7gdKge8mF018h3pMgHGIctKNk6jTTZJ8HPHZsFpiXfJoYG4w/b75fd8mOv6c tsVWX4QhznmfzG8I/wWVs7O3HljB08A4vSX7gJm6LWFbdeANldL/1EHXaIS8AYbZxJcz B3C3ILPcB8hupWdGqYTSvb3dVmDjWUnbiJW3A/GtUZBiEAWS1w6rHWWvCaklmgvW3kV1 oUiBWUwGAEPL9R7UvyjBMKllD+XN9qJ1EMerX46GYsp3lYFKC+fwcZ9p8RyYYbNZV3Hq VkqE1DgRwcZ3YZhNtHS3aVq202AyBcSYZUYWIFB0fAn4pKCoLrwShTH+/UrmRgscwtfh 7tmw== X-Gm-Message-State: AJIora/Lv8zcwwv0EmXKbgF9Sjv1Ep9UQBz2LYli9lz9YSRQ9l49bYjc wBzFlKneFwIbqslNSXIcsI8jQKeLFI4= X-Google-Smtp-Source: AA6agR5tF4NY0+PFKjLFqwKQQFRHsafqFS4V+JkninympfCW6aOpU9dJrLP9PMVnxEYC6IOHdiE5FQ== X-Received: by 2002:a05:6a00:a8e:b0:527:9d23:c613 with SMTP id b14-20020a056a000a8e00b005279d23c613mr23955512pfl.53.1659494543569; Tue, 02 Aug 2022 19:42:23 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id q38-20020a635c26000000b00419acadde52sm9962794pgb.46.2022.08.02.19.42.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 19:42:22 -0700 (PDT) References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <87r11ycbfs.fsf@yahoo.com> From: Jim Porter Message-ID: <825425fe-331f-11b8-94a4-6f899162ec4c@gmail.com> Date: Tue, 2 Aug 2022 19:42:22 -0700 MIME-Version: 1.0 In-Reply-To: <87r11ycbfs.fsf@yahoo.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/2/2022 7:23 PM, Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > What build of Emacs are you using? > I see that the background of the fringe bitmap doesn't match the fringe > itself, which is usually a bug. I think you're correct that it's a bug, although it looks like a fairly simple one. Here's the relevant bit from the definition of `bookmark-face': (((class color) (background light)) :background "White" :foreground "DarkOrange1") (((class color) (background dark)) :background "Black" :foreground "DarkOrange1")) The :background should probably be removed and replaced with :distant-foreground (I assume the :background was specified just in case the default background was too close to DarkOrange1, so we shouldn't regress that). I can fix this part at the same time as the rest of this bug. Thanks for pointing it out, since I probably would have glossed over this entirely otherwise (I don't usually use the default theme, so I hadn't seen this issue before). From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Aug 2022 04:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.165950109128370 (code B ref 56896); Wed, 03 Aug 2022 04:32:02 +0000 Received: (at 56896) by debbugs.gnu.org; 3 Aug 2022 04:31:31 +0000 Received: from localhost ([127.0.0.1]:45742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ62c-0007NU-Tv for submit@debbugs.gnu.org; Wed, 03 Aug 2022 00:31:31 -0400 Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]:46594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJ62b-0007NF-BV for 56896@debbugs.gnu.org; Wed, 03 Aug 2022 00:31:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1659501081; bh=Qd9u5x/K6jnCv/IUC52xjATWMYwbzfUIlWFXCBAy6G8=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=c4Hpm1yuleMUHD2nL41f5TQt71tLS1l1junvhfiVjgSRPcJ9F6SAQJoXSm+K1WKls9bUJ3QRZtfbrniMIG96xMyR/ewnT9m/yvRKlG7sfWpoGO5YXkxfIimhjOeBBcEz3ZpU/60JX+HB+lT0jhWHTrYd4oSOkSbn/1oLmLEtgxIrlTnofpQ+7utADQRBlXsUhOK7znRlM8LVM7rFkfQK1tXwoFqAFwUtAfx8Xth2PakBgLCiFtYfwanuaXcY3d5cKq3yyoVQVLusw9LA9UBhp7PWjB384ze5tZGC+OZ7ZgQBhN2EtZcn7RbcsUcP55+AdAUNWZbdT8mkpXaXdDHW2g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1659501081; bh=oi/ZUhsR8Enl/unxsVhciRZCZWaVSPsq7MoV45+JCj5=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=pevJjTcfl5TzfQVzsVZFGoKTjMBARbZn44Plaf4LP+YkOqw5ZPPmfdY2r08yySFfbc36u2QLEC/SraXSMeAiddYL2b4e6vd8JUnE+GMD1XDISSfu8pXY2m2DwJn32uGEDpJSfvj4n5UKXJ8WcW/YuVHPOEU27GAWphEWAvwDpsEkLt4y+NhRedB2PoW0Sm4DfuYUvgB2z6ipi8aIvuUfaz2kuGyU1mNTANn/Ii1BGldR+aaT6BOMFAp9W5Og/Ayam4gHJYZMIdLxA1p1gusGqgX/XCg8aoD2ZRbMttYhiicc4IO/X4I1Xfts301RhGpZi0tGzlNlfu9lVJ2oQmWrQg== X-YMail-OSG: sPFGke4VM1ndtAbcPRlD1tTMMNeICVACvv6R2vpLki83cG7pKrSaVXjW2FhGxQQ G_GVxFCfjyCO28RWESRgBViYSm7tcMT3TxAXbzWrrorMKGoIYodl3lCj2_wX45bUQylfsz_Pv9u6 DhLEQYXTaLHuDBSt6LYxOyhV.g4HskPzb69JsmoItwdkRVorScDYCmsI6ANBR5JT8jkmmEXE5gb3 qIVn6Gx_3FNQc430f_c03O1KfyaMMWK4MN.chqh5qE8Q34ONy5xmaeO0ZA2bcj3oVjxW4aw0BQbH J_imF209.CHNWBNDqhwe1Eim7wFPW1Mvay1a8HC97vWdLjEVVxOtLW80j8cD69BKpml8HRZ91T3D gZbt292Fsy8WRmmVIM.HDQ9m.IIq_P3Egj.9YQOZnWi0iDmwZquSY9BEQI4zHZ4tR7rFaRxFvKKA yNa9KvMaTym4nY5ZfpwQMORsGY8XhW4GUrII1a1BeXCEk87J8ky7lCXghrRGN.CVm_v1N7FB2Ois OSu0whTSxnFyBIy6u8z7J9FQz8vpF6OFwKL1rFMdo.9IgVLWylBkEhX1hwFIoAoEdOBHpF9QjT4r fmRFpMVm6U34jW4.A5jXP.7qzJJM3fjejOMmBLJU2jNv_YkPURKJrUyFBV9M4X5Nn7COYf9HABhQ iifVjnoFHmo5d4PtW_Rj5x7cGDKrcr24WC5NDn5tWfM.b_G1yNqIUMuC8VEO_jGf_JX1i7dpDBOv rlc_mNjxxOrsmi5HdIA2MMlr0atv2q4ErwH1mnDwI5Z3qqN8ooK7Y2Bh7iFwxWLChajVPJ35i6yG AAY6mPdjIfIc1zHCP_uG37h10VxKRhWZ_i0UtoKJ5IhEyEj_c5r0tTToiTofndz.PLoOup6.dmq8 dBBJBOg.PrC3GsbeTVkXNpyIsziRLjmJnWFAcOd.P7085n5lDkE98YIz88HGaXo32gQZBgRWKiiA PY6ImdyJBXwx3scVV8Q9f8KOmB42pqkBUpYSBzl1laK7QaYgDrufS_SM_uYpyAcEa01BZ32LLgxv TrgQKEwZR0vVnnA_Weq3iRvbyTRmN5n29bjJ0ltC4so2_VaPLNcz_HRU8P3PFSGSUrTj__K6Nriy _p4tUIGxtOSyrRazGojA_eGRJ8rU8pA096gvTTJ1eyOTdgBHBvMGC1X7UiRJNKOSAyhIgFjjShXE uCOhsy6sboNuI_eGjg0sQeETPFxs1jNxRreg_hp2b0cms.6GmQRyAn.1Af2_kVcdzGF2IZO3.8rz dDhelAJMwGS3vWxX82a8HLPy7xQwRwK1YlKWKRDvWAmqcXH_R2wY7IOYtIL6c2wIZxzzLa.3LrCY i8EDmWIqBkTFaw4oUou0J_YFwU7z1411YaamJy_A_XUkaYgtEUovFTlIXOWd4flit0BRf_nSENgL jd_hfhO3W6isEkf_EKIlV1INtKKpntK_Jd4zPN1qEg4lL97QnxiHUmoWDCJIROKyCIEulex_OM4F F3btm9m4JyHuMcXFFtazwSaqU15sLYAXJd3UuiuTdlJSi12PdFL3PJn_sbH8CyFJL19DWID8m.cz .i_Gpkj5ososFgX6w0x0NfcNMj2WaaxQEJ83kldZbf5.Q7BKEXTCnEAvIZjxiIp_MZK3qHcFti9B ZSerx.O7mQDBaQ3P0ywCCU5WH2.2LR9lGw7yMGi.z5icQppCm5rxcWnqAqkefo7ejyxPtve6MqHw ZNErGZjLqbyPIRQI.7a0I5h47SAFsbBvwidvpWnBPz4Wzfmxt9vJhsLrmWR5Lbub_nmqq68VeGY3 k0ORk8_6urZs.xPy0WrsBIfzm0A2HPgzYJEVTxzS_oGcmbVE0x7Ojk_9T7qICPQ9zEKm5EKySz0V AWps48Lf77UTlMWDI82n8XBspxQcqkvVf_nc4LzjK6w_zUebPfb9E23vmdVkRYXqsKD4TpHgyx58 yEpKGtMZx.9G4hHQQvUDAH7jMFMmdeDxNtol8q.eKFNLJCimQUW_.pYs5LMkjPBLK3kcn7HKFk2K CearZFvL_gbsMoU8JB67ZLdoUJ1buMwJzRN8AJIuD.qHXE0eb4SSo4N5S_7FltwYMIj2W7jdiQi_ 9tutDIALSwJSRlfkuyJDidpAlnwJU41aw4uysQ4J3bVtWIoXjeDomipXQFKo.I3vvhX2n.7Nn77K DtaAAbauoF4atlk_8d9WAJ3VmwH0rwJ.fCzcaRC5fjeZHvF4pn_FdFRYO9Uqcj9swjq_rqx0lye_ cVb6VHyO5Yp2W0cQMIyYzB0R8PkmImyrGu0x8psd9xWGqqUNrAb_Sp4skSrJdxWE- X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Wed, 3 Aug 2022 04:31:21 +0000 Received: by hermes--canary-production-sg3-854c886654-8kdzs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c644746e0fa6abf02d308e751624aa8b; Wed, 03 Aug 2022 04:31:19 +0000 (UTC) From: Po Lu References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <87r11ycbfs.fsf@yahoo.com> <825425fe-331f-11b8-94a4-6f899162ec4c@gmail.com> Date: Wed, 03 Aug 2022 12:31:12 +0800 In-Reply-To: <825425fe-331f-11b8-94a4-6f899162ec4c@gmail.com> (Jim Porter's message of "Tue, 2 Aug 2022 19:42:22 -0700") Message-ID: <87les6c5in.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20491 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 660 X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jim Porter writes: > The :background should probably be removed and replaced with > :distant-foreground (I assume the :background was specified just in > case the default background was too close to DarkOrange1, so we > shouldn't regress that). Phew. I thought it was yet another bug in the fringe bitmap drawing code, which is usually very tricky to work with. > I can fix this part at the same time as the rest of this bug. Thanks > for pointing it out, since I probably would have glossed over this > entirely otherwise (I don't usually use the default theme, so I hadn't > seen this issue before). That would be great, thanks. From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Aug 2022 03:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16595834764513 (code B ref 56896); Thu, 04 Aug 2022 03:25:02 +0000 Received: (at 56896) by debbugs.gnu.org; 4 Aug 2022 03:24:36 +0000 Received: from localhost ([127.0.0.1]:50697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJRTP-0001Ai-Qd for submit@debbugs.gnu.org; Wed, 03 Aug 2022 23:24:36 -0400 Received: from mail-pj1-f44.google.com ([209.85.216.44]:34371) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJRTM-0001AR-0L for 56896@debbugs.gnu.org; Wed, 03 Aug 2022 23:24:34 -0400 Received: by mail-pj1-f44.google.com with SMTP id c19-20020a17090ae11300b001f2f94ed5c6so4621965pjz.1 for <56896@debbugs.gnu.org>; Wed, 03 Aug 2022 20:24:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:from:to:cc; bh=7lGy8VJVNqfv82sO6tgyw2P/4O/YNDyQEsEm3tJ4n6w=; b=WJf/X4YcSAZvYCoZeNTt07/5X4LLJZwAwvRYjdZUnz3Md8p973s8zVLw7/uGWhE5Ml HCZE8T2CarOQxsRxrMi90aUtIi9JVAnC4qrCZrfon2R92+06ak/LOrAly6/cqVcJxf+W 6O2VQg8n5NfHNRZOzPCPBPF30B0ufgtSWPeS+926Q6LG1PjMP9apXjEfkB1YOYgOK6VZ FmmWwHT2nRXdfxKs7EqS1srRs49BkwE3U7GHjHp3JxyGQe8J+vgXE8/+FvRRBZebS9qO PLyO6sHP+iK8wbdHOkNsasHpKWVYjaJuopPZtkBueHTo5+Q4MzRKM3LFlu8nc5JBOxMY t6SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:x-gm-message-state:from:to:cc; bh=7lGy8VJVNqfv82sO6tgyw2P/4O/YNDyQEsEm3tJ4n6w=; b=qaKr9dPFHHzHIoHmGiBSMunQXsIDHqQMG5v5ayYdtbhwiPqkT+H0da77huhbEBANBI TpJNuAn+/NqqAbyz2mVjK1Avp6/2VZwMuUltpeWTs4o9tCWPqd2bACbTN0LAr8coglhQ 5kQbyErB5xmpAQKlSWL9iMmCMGRC5j8Od2S114txUhXh1maW8UxO8rwM27JSVOHRYpGG ChIKNd8UdeGXe8gQ46JCuZ17oVHoY9UA+Egmfenwtwcrxeah8E7iV00pmHWe3g3QvnSx hxpaVWiyi3HPIMV8EvR3gx14V310kn51UJlnq0mxz2gkxUOtZnix61Q/bMEqUFq8+1gB ZLwA== X-Gm-Message-State: ACgBeo1gTPmCI5ykBaSOF5NUNSsrDFNY2rAsCCUVQet2E7Pf/syDgbMm S+W4tFTP5FonIhM8pjSSmdmNbMhIvDQ= X-Google-Smtp-Source: AA6agR7knlAd7wVkiJVCYL0ko8IBwW0TaecJqbA+uLwIW62ER391DCWBs60f/vyUpTGiPMpWt+nvVw== X-Received: by 2002:a17:902:7143:b0:16d:986c:f2f9 with SMTP id u3-20020a170902714300b0016d986cf2f9mr29371570plm.42.1659583465748; Wed, 03 Aug 2022 20:24:25 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id c38-20020a634e26000000b0041b913c3c56sm10052602pgb.66.2022.08.03.20.24.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Aug 2022 20:24:24 -0700 (PDT) References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> From: Jim Porter Message-ID: <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> Date: Wed, 3 Aug 2022 20:24:24 -0700 MIME-Version: 1.0 In-Reply-To: <83sfme5acq.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------8E4F1D9BAC6FA78DDEBBF7D7" Content-Language: en-US X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------8E4F1D9BAC6FA78DDEBBF7D7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 8/2/2022 7:28 PM, Eli Zaretskii wrote: >> Cc: 56896@debbugs.gnu.org >> From: Jim Porter >> Date: Tue, 2 Aug 2022 13:05:40 -0700 >> >> 2) Let `bookmark-set-fringe-mark' take a symbol for a bitmap to use for >> the mark (it currently takes a boolean). This would solve this immediate >> case, but not other similar cases. For example, what if a user wants to >> customize the fringe icons in diff-mode? >> > What I had in mind was 2). > > Not sure if we need a general capability as in 3), but if it can be > implemented cleanly and will be convenient for user options, I don't > see why not. How does this look? I added a new built-in fringe bitmap ('large-circle'), since it should be generally-useful. There are a couple different fringe bitmaps for breakpoints that could use this, but I didn't do anything about that in this patch. I also added a Customize widget to let users pick a fringe bitmap. I'm not super-familiar with Customize, so I just guessed on how this is supposed to be defined (I based it on the 'font' widget). Finally, I adjusted the names of a couple bookmark variables and let users specify a bitmap (or nil) for 'bookmark-fringe-mark'. Note that changing this (via Customize or not) doesn't force an update of already-set bookmark fringe marks. That would be nice to have, but I'd need to study the code quite a bit more to figure out how to do this. If this seems about right, I'll add a NEWS entry describing the change (though I welcome any feedback about how much should go in NEWS; I'm not 100% sure). --------------8E4F1D9BAC6FA78DDEBBF7D7 Content-Type: text/plain; charset=UTF-8; name="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patc"; filename*1="h" RnJvbSAzMzkxYWU4ZmM0MWI3ZTJmOGMyMTZmN2RjNmIyMzFmNThmYWU3NDRmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMiBBdWcgMjAyMiAxMTo0MDo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIE1ha2UgdGhlIGJvb2ttYXJrIGZyaW5nZSBpY29uIGxvb2sgbGlrZSBhIGJvb2ttYXJr CgoqIHNyYy9mcmluZ2UuYyAobGFyZ2VfY2lyY2xlX2JpdHMpOiBOZXcgdmFyaWFibGUuCihz dGFuZGFyZF9iaXRtYXBzKTogQWRkIGxhcmdlX2NpcmNsZV9iaXRzLgoKKiBsaXNwL2ZyaW5n ZS5lbCAoZnJpbmdlLWJpdG1hcHMpOiBBZGQgJ2xhcmdlLWNpcmNsZScuCgoqIGxpc3AvY3Vz LWVkaXQuZWwgKHdpZGdldC1mcmluZ2UtYml0bWFwLXByb21wdC12YWx1ZS1oaXN0b3J5KTog TmV3CnZhcmlhYmxlLgooZnJpbmdlLWJpdG1hcCk6IE5ldyB3aWRnZXQuCgoqIGxpc3AvYm9v a21hcmsuZWwgKGJvb2ttYXJrLXNldC1mcmluZ2UtbWFyayk6IE9ic29sZXRlIGluIGZhdm9y IG9mLi4uCihib29rbWFyay1mcmluZ2UtbWFyayk6IC4uLiB0aGlzLgooYm9va21hcmstZnJp bmdlLW1hcmspOiBSZW5hbWUgdGhpcyBmcmluZ2UgYml0bWFwIHRvLi4uCihib29rbWFyay1t YXJrKTogLi4uIGFuZCBjaGFuZ2UgaXQgdG8gbG9vayBsaWtlIGEgYm9va21hcmsuCihib29r bWFyay1mYWNlKTogRG9uJ3Qgc2V0IHRoZSAnOmJhY2tncm91bmQnIG9mIHRoZSBmYWNlLiAg SW5zdGVhZCwKc2V0ICc6ZGlzdGFudC1mb3JlZ3JvdW5kJy4KKGJvb2ttYXJrLS1zZXQtZnJp bmdlLW1hcmspOiBDb25zdWx0IHRoZSAnYm9va21hcmstZnJpbmdlLW1hcmsnCm9wdGlvbi4K LS0tCiBsaXNwL2Jvb2ttYXJrLmVsIHwgMzMgKysrKysrKysrKysrKysrKysrKysrKy0tLS0t LS0tLS0tCiBsaXNwL2N1cy1lZGl0LmVsIHwgMjEgKysrKysrKysrKysrKysrKysrKysrCiBs aXNwL2ZyaW5nZS5lbCAgIHwgIDEgKwogc3JjL2ZyaW5nZS5jICAgICB8IDE1ICsrKysrKysr KysrKysrKwogNCBmaWxlcyBjaGFuZ2VkLCA1OSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2Jvb2ttYXJrLmVsIGIvbGlzcC9ib29rbWFyay5l bAppbmRleCAzMGEwM2UwNDMxLi43NmM3YjdkZjVkIDEwMDY0NAotLS0gYS9saXNwL2Jvb2tt YXJrLmVsCisrKyBiL2xpc3AvYm9va21hcmsuZWwKQEAgLTE4MSwxMCArMTgxLDE0IEBAIGJv b2ttYXJrLXNlYXJjaC1kZWxheQogICAiVGltZSBiZWZvcmUgYGJvb2ttYXJrLWJtZW51LXNl YXJjaCcgdXBkYXRlcyB0aGUgZGlzcGxheS4iCiAgIDp0eXBlICAnbnVtYmVyKQogCi0oZGVm Y3VzdG9tIGJvb2ttYXJrLXNldC1mcmluZ2UtbWFyayB0Ci0gICJXaGV0aGVyIHRvIHNldCBh IGZyaW5nZSBtYXJrIGF0IGJvb2ttYXJrZWQgbGluZXMuIgotICA6dHlwZSAgJ2Jvb2xlYW4K LSAgOnZlcnNpb24gIjI4LjEiKQorKGRlZmluZS1vYnNvbGV0ZS12YXJpYWJsZS1hbGlhcyAn Ym9va21hcmstc2V0LWZyaW5nZS1tYXJrCisgICdib29rbWFyay1mcmluZ2UtbWFyayAiMjku MSIpCisKKyhkZWZjdXN0b20gYm9va21hcmstZnJpbmdlLW1hcmsgJ2Jvb2ttYXJrLW1hcmsK KyAgIlRoZSBmcmluZ2UgYml0bWFwIHRvIG1hcmsgYm9va21hcmtlZCBsaW5lcyB3aXRoLgor SWYgbmlsLCBkb24ndCBkaXNwbGF5IGEgbWFyayBvbiB0aGUgZnJpbmdlLiIKKyAgOnR5cGUg JyhjaG9pY2UgKGNvbnN0IG5pbCkgZnJpbmdlLWJpdG1hcCkKKyAgOnZlcnNpb24gIjI5LjEi KQogCiA7OyBGSVhNRTogTm8gbG9uZ2VyIHVzZWQuICBTaG91bGQgYmUgZGVjbGFyZWQgb2Jz b2xldGUgb3IgcmVtb3ZlZC4KIChkZWZmYWNlIGJvb2ttYXJrLW1lbnUtaGVhZGluZwpAQCAt MjAxLDEwICsyMDUsMTAgQEAgYm9va21hcmstZmFjZQogICAgICA6Zm9yZWdyb3VuZCAiTGln aHRHcmF5IikKICAgICAoKChjbGFzcyBjb2xvcikKICAgICAgIChiYWNrZ3JvdW5kIGxpZ2h0 KSkKLSAgICAgOmJhY2tncm91bmQgIldoaXRlIiA6Zm9yZWdyb3VuZCAiRGFya09yYW5nZTEi KQorICAgICA6Zm9yZWdyb3VuZCAiRGFya09yYW5nZTEiIDpkaXN0YW50LWZvcmVncm91bmQg IkRhcmtPcmFuZ2UzIikKICAgICAoKChjbGFzcyBjb2xvcikKICAgICAgIChiYWNrZ3JvdW5k IGRhcmspKQotICAgICA6YmFja2dyb3VuZCAiQmxhY2siIDpmb3JlZ3JvdW5kICJEYXJrT3Jh bmdlMSIpKQorICAgICA6Zm9yZWdyb3VuZCAiRGFya09yYW5nZTEiIDpkaXN0YW50LWZvcmVn cm91bmQgIk9yYW5nZTEiKSkKICAgIkZhY2UgdXNlZCB0byBoaWdobGlnaHQgY3VycmVudCBs aW5lLiIKICAgOnZlcnNpb24gIjI4LjEiKQogCkBAIC00ODIsMjQgKzQ4NiwzMSBAQCBib29r bWFyay11cGRhdGUtbGFzdC1tb2RpZmllZAogKGRlZnZhciBib29rbWFyay1oaXN0b3J5IG5p bAogICAiVGhlIGhpc3RvcnkgbGlzdCBmb3IgYm9va21hcmsgZnVuY3Rpb25zLiIpCiAKLShk ZWZpbmUtZnJpbmdlLWJpdG1hcCAnYm9va21hcmstZnJpbmdlLW1hcmsKLSAgIlx4M2NceDdl XHhmZlx4ZmZceGZmXHhmZlx4N2VceDNjIikKKyhkZWZpbmUtZnJpbmdlLWJpdG1hcCAnYm9v a21hcmstbWFyaworICBbI2IwMTExMTExMAorICAgI2IwMTExMTExMAorICAgI2IwMTExMTEx MAorICAgI2IwMTExMTExMAorICAgI2IwMTExMTExMAorICAgI2IwMTExMTExMAorICAgI2Iw MTEwMDExMAorICAgI2IwMTAwMDAxMF0pCiAKIChkZWZ1biBib29rbWFyay0tc2V0LWZyaW5n ZS1tYXJrICgpCiAgICJBcHBseSBhIGNvbG9yaXplZCBvdmVybGF5IHRvIHRoZSBib29rbWFy a2VkIGxvY2F0aW9uLgotU2VlIHVzZXIgb3B0aW9uIGBib29rbWFyay1zZXQtZnJpbmdlLW1h cmsnLiIKK1NlZSB1c2VyIG9wdGlvbiBgYm9va21hcmstZnJpbmdlLW1hcmsnLiIKICAgKGxl dCAoKGJtIChtYWtlLW92ZXJsYXkgKHBvaW50LWF0LWJvbCkgKDErIChwb2ludC1hdC1ib2wp KSkpKQogICAgIChvdmVybGF5LXB1dCBibSAnY2F0ZWdvcnkgJ2Jvb2ttYXJrKQogICAgIChv dmVybGF5LXB1dCBibSAnZXZhcG9yYXRlIHQpCiAgICAgKG92ZXJsYXktcHV0IGJtICdiZWZv cmUtc3RyaW5nCiAgICAgICAgICAgICAgICAgIChwcm9wZXJ0aXplCiAgICAgICAgICAgICAg ICAgICAieCIgJ2Rpc3BsYXkKLSAgICAgICAgICAgICAgICAgIGAobGVmdC1mcmluZ2UgYm9v a21hcmstZnJpbmdlLW1hcmsgYm9va21hcmstZmFjZSkpKSkpCisgICAgICAgICAgICAgICAg ICBgKGxlZnQtZnJpbmdlICxib29rbWFyay1mcmluZ2UtbWFyayBib29rbWFyay1mYWNlKSkp KSkKIAogKGRlZnVuIGJvb2ttYXJrLS1yZW1vdmUtZnJpbmdlLW1hcmsgKGJtKQogICAiUmVt b3ZlIGEgYm9va21hcmsncyBjb2xvcml6ZWQgb3ZlcmxheS4KIEJNIGlzIGEgYm9va21hcmsg YXMgcmV0dXJuZWQgZnJvbSBmdW5jdGlvbiBgYm9va21hcmstZ2V0LWJvb2ttYXJrJy4KLVNl ZSB1c2VyIG9wdGlvbiBgYm9va21hcmstc2V0LWZyaW5nZScuIgorU2VlIHVzZXIgb3B0aW9u IGBib29rbWFyay1mcmluZ2UtbWFyaycuIgogICAobGV0ICgoZmlsZW5hbWUgKGNkciAoYXNz cSAnZmlsZW5hbWUgYm0pKSkKICAgICAgICAgKHBvcyAoY2RyIChhc3NxICdwb3NpdGlvbiBi bSkpKQogICAgICAgICBvdmVybGF5cyBmb3VuZCB0ZW1wKQpkaWZmIC0tZ2l0IGEvbGlzcC9j dXMtZWRpdC5lbCBiL2xpc3AvY3VzLWVkaXQuZWwKaW5kZXggZWRjMDlmMzE5OS4uY2EyNjky MmMzMCAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5lbAorKysgYi9saXNwL2N1cy1lZGl0 LmVsCkBAIC00Mjg2LDYgKzQyODYsMjcgQEAgY3VzdG9tLWhvb2stY29udmVydC13aWRnZXQK ICAgICAod2lkZ2V0LXB1dCB3aWRnZXQgOmFyZ3MgYXJncykKICAgICB3aWRnZXQpKQogCis7 OzsgVGhlIGBmcmluZ2UtYml0bWFwJyBXaWRnZXQuCisKKyhkZWZ2YXIgd2lkZ2V0LWZyaW5n ZS1iaXRtYXAtcHJvbXB0LXZhbHVlLWhpc3RvcnkgbmlsCisgICJIaXN0b3J5IG9mIGlucHV0 IHRvIGB3aWRnZXQtZnJpbmdlLWJpdG1hcC1wcm9tcHQtdmFsdWUnLiIpCisKKyhkZWZpbmUt d2lkZ2V0ICdmcmluZ2UtYml0bWFwICdzeW1ib2wKKyAgIkEgTGlzcCBmcmluZ2UgYml0bWFw IG5hbWUiCisgIDpmb3JtYXQgIiV2IgorICA6dGFnICJGcmluZ2UgYml0bWFwIgorICA6bWF0 Y2ggKGxhbWJkYSAoX3dpZGdldCB2YWx1ZSkgKGZyaW5nZS1iaXRtYXAtcCB2YWx1ZSkpCisg IDpjb21wbGV0aW9ucyAoYXBwbHktcGFydGlhbGx5ICMnY29tcGxldGlvbi10YWJsZS13aXRo LXByZWRpY2F0ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBvYmFycmF5ICMn ZnJpbmdlLWJpdG1hcC1wICdzdHJpY3QpCisgIDpwcm9tcHQtbWF0Y2ggJ2ZyaW5nZS1iaXRt YXAtcAorICA6cHJvbXB0LWhpc3RvcnkgJ3dpZGdldC1mYWNlLXByb21wdC12YWx1ZS1oaXN0 b3J5CisgIDp2YWxpZGF0ZSAobGFtYmRhICh3aWRnZXQpCisJICAgICAgKHVubGVzcyAoZnJp bmdlLWJpdG1hcC1wICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSkKKwkJKHdpZGdldC1wdXQgd2lk Z2V0CisJCQkgICAgOmVycm9yIChmb3JtYXQgIkludmFsaWQgZnJpbmdlIGJpdG1hcDogJVMi CisJCQkJCSAgICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSkpCisJCXdpZGdldCkpKQorCiA7Ozsg VGhlIGBjdXN0b20tZ3JvdXAtbGluaycgV2lkZ2V0LgogCiAoZGVmaW5lLXdpZGdldCAnY3Vz dG9tLWdyb3VwLWxpbmsgJ2xpbmsKZGlmZiAtLWdpdCBhL2xpc3AvZnJpbmdlLmVsIGIvbGlz cC9mcmluZ2UuZWwKaW5kZXggNjU3YTczNzcyZC4uZGE2ODEyZTY4ZCAxMDA2NDQKLS0tIGEv bGlzcC9mcmluZ2UuZWwKKysrIGIvbGlzcC9mcmluZ2UuZWwKQEAgLTQ2LDYgKzQ2LDcgQEAg ZnJpbmdlCiAgIChsZXQgKChiaXRtYXBzICcocXVlc3Rpb24tbWFyayBleGNsYW1hdGlvbi1t YXJrCiAJCSAgIGxlZnQtYXJyb3cgcmlnaHQtYXJyb3cgdXAtYXJyb3cgZG93bi1hcnJvdwog CQkgICBsZWZ0LWN1cmx5LWFycm93IHJpZ2h0LWN1cmx5LWFycm93CisJCSAgIGxhcmdlLWNp cmNsZQogCQkgICBsZWZ0LXRyaWFuZ2xlIHJpZ2h0LXRyaWFuZ2xlCiAJCSAgIHRvcC1sZWZ0 LWFuZ2xlIHRvcC1yaWdodC1hbmdsZQogCQkgICBib3R0b20tbGVmdC1hbmdsZSBib3R0b20t cmlnaHQtYW5nbGUKZGlmZiAtLWdpdCBhL3NyYy9mcmluZ2UuYyBiL3NyYy9mcmluZ2UuYwpp bmRleCBiZjBiNWZkZTc2Li41ZDdjOGRjYTk5IDEwMDY0NAotLS0gYS9zcmMvZnJpbmdlLmMK KysrIGIvc3JjL2ZyaW5nZS5jCkBAIC0yMDksNiArMjA5LDIwIEBACiBzdGF0aWMgdW5zaWdu ZWQgc2hvcnQgcmlnaHRfY3VybHlfYXJyb3dfYml0c1tdID0gewogICAgMHgzYywgMHgzZSwg MHgwMywgMHgyNywgMHgzZiwgMHgzZSwgMHgzYywgMHgzZX07CiAKKy8qIExhcmdlIGNpcmNs ZSBiaXRtYXAuICAqLworLyoKKyAgLi4uLi4uLi4KKyAgLi54eHh4Li4KKyAgLnh4eHh4eC4K KyAgeHh4eHh4eHgKKyAgeHh4eHh4eHgKKyAgLnh4eHh4eC4KKyAgLi54eHh4Li4KKyAgLi4u Li4uLi4KKyovCitzdGF0aWMgdW5zaWduZWQgc2hvcnQgbGFyZ2VfY2lyY2xlX2JpdHNbXSA9 IHsKKyAgMHgzYywgMHg3ZSwgMHhmZiwgMHhmZiwgMHhmZiwgMHhmZiwgMHg3ZSwgMHgzY307 CisKIC8qIFJldmVyc2UgT3ZlcmxheSBhcnJvdyBiaXRtYXAuICBBIHRyaWFuZ3VsYXIgYXJy b3cuICAqLwogLyoKICAgLi4uLi4ueHgKQEAgLTQ1NCw2ICs0NjgsNyBAQCAjZGVmaW5lIEZS QklUUyhiaXRzKSAgYml0cywgU1RBTkRBUkRfQklUTUFQX0hFSUdIVCAoYml0cykKICAgeyBG UkJJVFMgKGRvd25fYXJyb3dfYml0cyksICAgICAgICAgOCwgMCwgQUxJR05fQklUTUFQX0JP VFRPTSwgMCB9LAogICB7IEZSQklUUyAobGVmdF9jdXJseV9hcnJvd19iaXRzKSwgICA4LCAw LCBBTElHTl9CSVRNQVBfQ0VOVEVSLCAwIH0sCiAgIHsgRlJCSVRTIChyaWdodF9jdXJseV9h cnJvd19iaXRzKSwgIDgsIDAsIEFMSUdOX0JJVE1BUF9DRU5URVIsIDAgfSwKKyAgeyBGUkJJ VFMgKGxhcmdlX2NpcmNsZV9iaXRzKSwgICAgICAgOCwgMCwgQUxJR05fQklUTUFQX0NFTlRF UiwgMCB9LAogICB7IEZSQklUUyAobGVmdF90cmlhbmdsZV9iaXRzKSwgICAgICA4LCAwLCBB TElHTl9CSVRNQVBfQ0VOVEVSLCAwIH0sCiAgIHsgRlJCSVRTIChyaWdodF90cmlhbmdsZV9i aXRzKSwgICAgIDgsIDAsIEFMSUdOX0JJVE1BUF9DRU5URVIsIDAgfSwKICAgeyBGUkJJVFMg KHRvcF9sZWZ0X2FuZ2xlX2JpdHMpLCAgICAgOCwgMCwgQUxJR05fQklUTUFQX1RPUCwgICAg MCB9LAotLSAKMi4yNS4xCgo= --------------8E4F1D9BAC6FA78DDEBBF7D7-- From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Aug 2022 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter , Lars Ingebrigtsen Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16595960262170 (code B ref 56896); Thu, 04 Aug 2022 06:54:02 +0000 Received: (at 56896) by debbugs.gnu.org; 4 Aug 2022 06:53:46 +0000 Received: from localhost ([127.0.0.1]:50938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJUjq-0000Yv-8t for submit@debbugs.gnu.org; Thu, 04 Aug 2022 02:53:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48830) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJUjm-0000Ye-NG for 56896@debbugs.gnu.org; Thu, 04 Aug 2022 02:53:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35062) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJUjh-0006OG-Bl; Thu, 04 Aug 2022 02:53:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=YDIeaiZQLeue01n1PXST+1TZrFNt2UtQd8LFx5PN65g=; b=NgWUxjSaJ9p3 oAFYQkhNAyj/PbxkRJbi3SYiMevjPnCacUPUcIO3YW2Rp+AhOgo7lr2MrNr4vM8UIEpD1NQ3lPXRy TpJRKUla7pXjddYLiq3m87QumRFjHSWgnzONAydBd8lINBSO1xAe9geUHXzLmKUeFT9DhQ4yEzt1H yAdMulaIfxg+k3X5jiShS+fTdUXGd6Plj5YLdUrZxhJPCiz1L8Wl4OrU8X4I8wzq+6VXrq3Q3nCk2 dVmJQ8XUcmP47iGGh0TskSe1Z7auPo+t7BFoePy3GNwa0JYf52sQhp9yUdaAodsu7XcR9LsuPGo8W czj34rxt2dVasqTSMlQncw==; Received: from [87.69.77.57] (port=1690 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJUjg-0001Uz-8f; Thu, 04 Aug 2022 02:53:36 -0400 Date: Thu, 04 Aug 2022 09:53:32 +0300 Message-Id: <83edxw4hzn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> (message from Jim Porter on Wed, 3 Aug 2022 20:24:24 -0700) References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 56896@debbugs.gnu.org > From: Jim Porter > Date: Wed, 3 Aug 2022 20:24:24 -0700 > > > Not sure if we need a general capability as in 3), but if it can be > > implemented cleanly and will be convenient for user options, I don't > > see why not. > > How does this look? I added a new built-in fringe bitmap > ('large-circle'), since it should be generally-useful. There are a > couple different fringe bitmaps for breakpoints that could use this, but > I didn't do anything about that in this patch. > > I also added a Customize widget to let users pick a fringe bitmap. I'm > not super-familiar with Customize, so I just guessed on how this is > supposed to be defined (I based it on the 'font' widget). Reading the code, it LGTM. But I'm not familiar enough with the Customize parts of the patch, so let's wait a bit for others to chime in. Lars, WDYT? > Finally, I adjusted the names of a couple bookmark variables and let > users specify a bitmap (or nil) for 'bookmark-fringe-mark'. Note that > changing this (via Customize or not) doesn't force an update of > already-set bookmark fringe marks. That would be nice to have, but I'd > need to study the code quite a bit more to figure out how to do this. I think we should fix this aspect, yes. So please do try to find the way of doing it with some kind of :set function. > If this seems about right, I'll add a NEWS entry describing the change > (though I welcome any feedback about how much should go in NEWS; I'm not > 100% sure). If there's a detailed enough description in the manual(s), the NEWS entry can be quite short, just mentioning the new capabilities and variables. If you don't think this is manual-worthy, the NEWS entry should be a bit more detailed. But don't worry about that, we will get to it when you submit the actual text for NEWS. Thanks. From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Aug 2022 06:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Jim Porter , 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16595962692661 (code B ref 56896); Thu, 04 Aug 2022 06:58:01 +0000 Received: (at 56896) by debbugs.gnu.org; 4 Aug 2022 06:57:49 +0000 Received: from localhost ([127.0.0.1]:50965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJUnl-0000gr-Df for submit@debbugs.gnu.org; Thu, 04 Aug 2022 02:57:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:48878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJUnk-0000gf-9p for 56896@debbugs.gnu.org; Thu, 04 Aug 2022 02:57:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wJMYosetBLmC7tp34M5zF7Mv4OWCOqXYMFCyCrSJMCk=; b=GAXGXqiLM1A1jZah2ZkQbvJ2Tb gz5gIXVFDkB51v/fd3CPMZiQKz2QLcAJz8Lsau+6Qlv0FXktqzia+zSYb6C5+c23myXsedJWIMJAP wFfHbBVjoH5ot4vLp7qV46dmzecn6yXqqTMnz6IrFFsUlKAGf7tZjVMWP2lAgzvOTlj0=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oJUnc-0004E7-0W; Thu, 04 Aug 2022 08:57:42 +0200 From: Lars Ingebrigtsen In-Reply-To: <83edxw4hzn.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 04 Aug 2022 09:53:32 +0300") References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> <83edxw4hzn.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUBAQEeKCcuTUw4 hFROk20nZWM1h24uiZ0/lakgRoseZZiQuoL///9Zwu6dAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+YI BAY5FdQPm0oAAAGnSURBVDjLvZIxTyMxEIXtoBR069UhRJcsrE5HhbKEHmQiyijIG3B1kGSoQQGH lEgRFiUShVORSMsSl/xC7D0d9hJK7l4383me7ZlB6LtFwjAgVgEi2AfhSlgP6xExB7bqPwKvAptz pgYjTALy7Q/6RyLBV1kcJklSX0Y4TvaglzSWyCYD6EOSND7lwyQdQL8F0NspG3WaN02gFACaJbO1 KD0+7KXQigHaPohi1h3eDxoEt+DcdzpV2uoB4TaA57UxNdmRlBOEa13fa9vm9Wi8MOAEzhyImdZC 3tuKoJO6S3DE+YWQUt4Z0F4fOMAzlg8ppQcmMODj9irr8EUuJX0zh9o/3bOqSikDRg9zA4ITqP0F q5p1tXjVemLB680HwOpxU/BcXGc2yoUDEVljrE/3i/UUInAV0S+lTtWsiETmwFSZXglxV0Rd5v38 aSGEGB78AXNvfvELGDIpAj1zoMKZBbeFr/a6W3ni4+GRLCrw2J+t+Xq2S6lN4St/tBvKavpsq59L W8IzboZlr62U96rKdHohfqNlmenmrhclM51foq+EQ11D/1Xv1buAyipV56AAAAAldEVYdGRhdGU6 Y3JlYXRlADIwMjItMDgtMDRUMDY6NTc6MjErMDA6MDAoYJpfAAAAJXRFWHRkYXRlOm1vZGlmeQAy MDIyLTA4LTA0VDA2OjU3OjIxKzAwOjAwWT0i4wAAAABJRU5ErkJggg== X-Now-Playing: John Martyn's _Solid Air_: "Go Down Easy" Date: Thu, 04 Aug 2022 08:57:37 +0200 Message-ID: <87sfmcjy1q.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > Reading the code, it LGTM. But I'm not familiar enough with the > Customize parts of the patch, so let's wait a bit for others to chime > in. Lars, WDYT? Looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > Reading the code, it LGTM. But I'm not familiar enough with the > Customize parts of the patch, so let's wait a bit for others to chime > in. Lars, WDYT? Looks good to me. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 09:58:18 2022 Received: (at control) by debbugs.gnu.org; 4 Aug 2022 13:58:18 +0000 Received: from localhost ([127.0.0.1]:54065 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJbMg-0006xL-Gy for submit@debbugs.gnu.org; Thu, 04 Aug 2022 09:58:18 -0400 Received: from mail-ua1-f48.google.com ([209.85.222.48]:42624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJbMf-0006ut-Cj for control@debbugs.gnu.org; Thu, 04 Aug 2022 09:58:17 -0400 Received: by mail-ua1-f48.google.com with SMTP id l7so8270400ual.9 for ; Thu, 04 Aug 2022 06:58:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=VIPflZXtjDAGVDyNHgv8cWmX5ejmXXVjYdIa1i1rB5U=; b=DLq2gihK2787vqsRezPi6IcCBM5Gyb68+fjCO8fxRkx7YWoYxvX60mGaaAXzFbUCBL RTgRTM09JrVaUXdPxuN66swyXwMfo6f7Q8f3HnFm35Ede8ijiWvV/hRZRv07wvJ2EqBl UAfVZ2AZu6jvN1mn28ev9LYKwS5qzi12A4hABqVM0eEn62mYZ0sloibh0SFmkGx40zoO +idZiEbQrecTtyOgdeYPkm99iInjyKfw5BWvV1G0biwkrNdwrBg8MjXq5nn1NC5Zikc/ X3erliYmvb2jusCxGrS1dQIcoeurFnW6MxC+xA29nz2Nil3XrY3fea0WuYlzqIVuGpCK D1aA== X-Gm-Message-State: ACgBeo13skcU5vs5Xe0GNsp2TT2xIQph2M1jZKre741WZR91N/xYOuX7 sCRNfo8jRsrypnwi1nS+2vC6TdLc73l/Xx/YQJMOqS0w X-Google-Smtp-Source: AA6agR7Q3g2jW+oIwsL8r7/ycfqoOBERQ3h5HMg5jAqRSb8BqZhjzdPCt19fZR0JKm3gQgKtPk8v/vItSKNC2CC5X9A= X-Received: by 2002:ab0:1423:0:b0:384:da85:8a5b with SMTP id b32-20020ab01423000000b00384da858a5bmr906505uae.48.1659621497125; Thu, 04 Aug 2022 06:58:17 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 4 Aug 2022 13:58:16 +0000 X-Hashcash: 1:21:220804:control@debbugs.gnu.org::dbDCwqixF4xJsAiT:ACu3 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 4 Aug 2022 13:58:16 +0000 Message-ID: Subject: control message for bug #56896 To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) severity 56896 wishlist quit From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Aug 2022 04:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Lars Ingebrigtsen Cc: 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16596745326137 (code B ref 56896); Fri, 05 Aug 2022 04:43:01 +0000 Received: (at 56896) by debbugs.gnu.org; 5 Aug 2022 04:42:12 +0000 Received: from localhost ([127.0.0.1]:55645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJpA3-0001ap-8q for submit@debbugs.gnu.org; Fri, 05 Aug 2022 00:42:12 -0400 Received: from mail-pg1-f171.google.com ([209.85.215.171]:43522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJp9x-0001aH-DR for 56896@debbugs.gnu.org; Fri, 05 Aug 2022 00:42:09 -0400 Received: by mail-pg1-f171.google.com with SMTP id h132so1696683pgc.10 for <56896@debbugs.gnu.org>; Thu, 04 Aug 2022 21:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:from:to:cc; bh=YSidcQPF3k58v1MGMnXE1HpybtxRQGf/qih58S6t5o4=; b=Eobu+/EZRMESVQeIEEdzzC3dR8+t2r/8xJX4yiO0tji4lk+hCTwYz7zD7JXU4bCfTL GntV0+6+7wFkyHXFsmG69Cwp0SdNofcd+mkiSPHH/uGKCZYtj4U0fUytDrfN0nyyKqRz q5N7FJcFtfoRv/Y+SCqK0nLG3x2wP29LkflZwRST3C1ve4IfBKA9yv0miLVTZgs+be1B JEenuN8oa2N1G63nPFIIZATVLMWPZHFqXR9GB07XjimJAQMfpRvxOi1cHqeN5H6c0AlS pxdbXnPUb7T8KmkHJk3kYJhb5ELTHluHOWAp9YhTNH1xAh3uxHE/VjiC8NySqy4hFx6L 6GZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject:x-gm-message-state:from:to:cc; bh=YSidcQPF3k58v1MGMnXE1HpybtxRQGf/qih58S6t5o4=; b=jra1C5/vGF7CV4F/24/g48ntlBIm00Ut21li17qXPUkVht+GJLN2dTUR2EsY9Geg7L +ILFI3bJIuJeB7fI1XCAWJtMWZWGUua0u/fc8XeHEHWUNRLbPzIRHTouuyRFzk+OhPEQ 61D/FxZ2QQVNq2TIQzhlNDjmYZRbPQjTwPX2oO0oHED0+B0tCb0eQpF1JCQzng/ZtBT4 OFlGu+VBiXawiMiphfnHt6XBOOxXDNaI8eOvRu4Ze4CFupGq2dcXqs6DkiBL9rB0O/yp lPmjVNoGH8/oCKv7pefZ1D8qEIao3iRhOTW19SoIzm4tAqlX1xubIe/YvBY1qWvnBys6 5AOw== X-Gm-Message-State: ACgBeo2NekL+2dQGAyDaWiLOn7TaQ6GUqqhFJh220A22wRtnlsXIV3fA +uZI9nxS5UG0Mgo5rkCUIasjaajyRsY= X-Google-Smtp-Source: AA6agR5GMXdilM9/nSs/RH+F1+1THTlZ57zp7w3pCzJmQhmtUgfOp0JxvYN5opndZyNijIREpTFi+A== X-Received: by 2002:a62:1a56:0:b0:52d:4352:3ae0 with SMTP id a83-20020a621a56000000b0052d43523ae0mr5138696pfa.35.1659674519261; Thu, 04 Aug 2022 21:41:59 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g64-20020a625243000000b0052d6ad246a4sm1875803pfb.144.2022.08.04.21.41.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Aug 2022 21:41:57 -0700 (PDT) References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> <83edxw4hzn.fsf@gnu.org> From: Jim Porter Message-ID: <7566691d-090e-f380-b395-4d2aa2fdebdb@gmail.com> Date: Thu, 4 Aug 2022 21:41:56 -0700 MIME-Version: 1.0 In-Reply-To: <83edxw4hzn.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------2D4DBE4B10623A0DADBE3CD3" Content-Language: en-US X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------2D4DBE4B10623A0DADBE3CD3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 8/3/2022 11:53 PM, Eli Zaretskii wrote: >> Cc: 56896@debbugs.gnu.org >> From: Jim Porter >> Date: Wed, 3 Aug 2022 20:24:24 -0700 >> >> Finally, I adjusted the names of a couple bookmark variables and let >> users specify a bitmap (or nil) for 'bookmark-fringe-mark'. Note that >> changing this (via Customize or not) doesn't force an update of >> already-set bookmark fringe marks. That would be nice to have, but I'd >> need to study the code quite a bit more to figure out how to do this. > > I think we should fix this aspect, yes. So please do try to find the > way of doing it with some kind of :set function. Ok, I figured out a way to do this. I added a proxy object ('bookmark--fringe-mark') that I can dynamically set the 'fringe' property on, and then the :set function will update that and the display code will Just Work. Well, so long as a redisplay is triggered, but I think happens when you set options via Customize? It worked in my tests, anyway. This method feels kind of hacky, but I can't think of a better way, and it's certainly more feasible than trying to find all the fringe markers manually. (Given that code can define custom bookmark handler functions, I'm not even sure that would have been possible...) > If there's a detailed enough description in the manual(s), the NEWS > entry can be quite short, just mentioning the new capabilities and > variables. If you don't think this is manual-worthy, the NEWS entry > should be a bit more detailed. But don't worry about that, we will > get to it when you submit the actual text for NEWS. I added some documentation and a NEWS entry for the user-facing part of this (the new option). There might be room to add more documentation though. --------------2D4DBE4B10623A0DADBE3CD3 Content-Type: text/plain; charset=UTF-8; name="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patc"; filename*1="h" RnJvbSAxYjNmZjc1NzhkMWVhYWE2YzIwZTQ1N2E0MmRlZjQ2ZWE0ZjMxMDhiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMiBBdWcgMjAyMiAxMTo0MDo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIE1ha2UgdGhlIGJvb2ttYXJrIGZyaW5nZSBpY29uIGxvb2sgbGlrZSBhIGJvb2ttYXJr CgoqIHNyYy9mcmluZ2UuYyAobGFyZ2VfY2lyY2xlX2JpdHMpOiBOZXcgdmFyaWFibGUuCihz dGFuZGFyZF9iaXRtYXBzKTogQWRkIGxhcmdlX2NpcmNsZV9iaXRzLgoKKiBsaXNwL2ZyaW5n ZS5lbCAoZnJpbmdlLWJpdG1hcHMpOiBBZGQgJ2xhcmdlLWNpcmNsZScuCgoqIGxpc3AvY3Vz LWVkaXQuZWwgKHdpZGdldC1mcmluZ2UtYml0bWFwLXByb21wdC12YWx1ZS1oaXN0b3J5KTog TmV3CnZhcmlhYmxlLgooZnJpbmdlLWJpdG1hcCk6IE5ldyB3aWRnZXQuCgoqIGxpc3AvYm9v a21hcmsuZWwgKGJvb2ttYXJrLXNldC1mcmluZ2UtbWFyayk6IE9ic29sZXRlIGluIGZhdm9y IG9mLi4uCihib29rbWFyay1mcmluZ2UtbWFyayk6IC4uLiB0aGlzLgooYm9va21hcmstZnJp bmdlLW1hcmspOiBSZW5hbWUgdGhpcyBmcmluZ2UgYml0bWFwIHRvLi4uCihib29rbWFyay1t YXJrKTogLi4uIGFuZCBjaGFuZ2UgaXQgdG8gbG9vayBsaWtlIGEgYm9va21hcmsuCihib29r bWFyay0tZnJpbmdlLW1hcmspOiBOZXcgdmFyaWFibGUuCihib29rbWFyay1mYWNlKTogRG9u J3Qgc2V0IHRoZSAnOmJhY2tncm91bmQnIG9mIHRoZSBmYWNlLiAgSW5zdGVhZCwKc2V0ICc6 ZGlzdGFudC1mb3JlZ3JvdW5kJy4KKGJvb2ttYXJrLS1zZXQtZnJpbmdlLW1hcmssIGJvb2tt YXJrLXN0b3JlLCBib29rbWFyay0tanVtcC12aWEpOgpDb25zdWx0IHRoZSAnYm9va21hcmst ZnJpbmdlLW1hcmsnIG9wdGlvbi4KCiogZG9jL2xpc3ByZWYvY3VzdG9taXplLnRleGkgKFNp bXBsZSBUeXBlcyk6IERvY3VtZW50ICdmcmluZ2UtYml0bWFwJwp0eXBlLgoKKiBkb2MvbGlz cHJlZi9kaXNwbGF5LnRleGkgKEZyaW5nZSBCaXRtYXBzKTogTWVudGlvbiAnbGFyZ2UtY2ly Y2xlJy4KCiogZXRjL05FV1M6IEFubm91bmNlIHRoaXMgY2hhbmdlLgotLS0KIGRvYy9saXNw cmVmL2N1c3RvbWl6ZS50ZXhpIHwgIDQgKysrKwogZG9jL2xpc3ByZWYvZGlzcGxheS50ZXhp ICAgfCAgMSArCiBldGMvTkVXUyAgICAgICAgICAgICAgICAgICB8ICA1ICsrKysKIGxpc3Av Ym9va21hcmsuZWwgICAgICAgICAgIHwgNDkgKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0KIGxpc3AvY3VzLWVkaXQuZWwgICAgICAgICAgIHwgMjEgKysrKysrKysr KysrKysrKwogbGlzcC9mcmluZ2UuZWwgICAgICAgICAgICAgfCAgMSArCiBzcmMvZnJpbmdl LmMgICAgICAgICAgICAgICB8IDE1ICsrKysrKysrKysrKwogNyBmaWxlcyBjaGFuZ2VkLCA4 MSBpbnNlcnRpb25zKCspLCAxNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2MvbGlz cHJlZi9jdXN0b21pemUudGV4aSBiL2RvYy9saXNwcmVmL2N1c3RvbWl6ZS50ZXhpCmluZGV4 IDUyODQyMWJmM2IuLjZiYTM1Y2ZmZmYgMTAwNjQ0Ci0tLSBhL2RvYy9saXNwcmVmL2N1c3Rv bWl6ZS50ZXhpCisrKyBiL2RvYy9saXNwcmVmL2N1c3RvbWl6ZS50ZXhpCkBAIC02NzIsNiAr NjcyLDEwIEBAIFNpbXBsZSBUeXBlcwogZm9yIGNvbG9yIG5hbWVzLCBhcyB3ZWxsIGFzIGEg c2FtcGxlIGFuZCBhIGJ1dHRvbiBmb3Igc2VsZWN0aW5nIGEKIGNvbG9yIG5hbWUgZnJvbSBh IGxpc3Qgb2YgY29sb3IgbmFtZXMgc2hvd24gaW4gYSBAZmlsZXsqQ29sb3JzKn0KIGJ1ZmZl ci4KKworQGl0ZW0gZnJpbmdlLWJpdG1hcAorVGhlIHZhbHVlIG11c3QgYmUgYSB2YWxpZCBm cmluZ2UgYml0bWFwIG5hbWUuICBUaGUgd2lkZ2V0IHByb3ZpZGVzCitjb21wbGV0aW9uLgog QGVuZCB0YWJsZQogCiBAbm9kZSBDb21wb3NpdGUgVHlwZXMKZGlmZiAtLWdpdCBhL2RvYy9s aXNwcmVmL2Rpc3BsYXkudGV4aSBiL2RvYy9saXNwcmVmL2Rpc3BsYXkudGV4aQppbmRleCBh Y2U2N2ZiZWRiLi40OGY0NmI0Y2I2IDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9kaXNwbGF5 LnRleGkKKysrIGIvZG9jL2xpc3ByZWYvZGlzcGxheS50ZXhpCkBAIC00NjI2LDYgKzQ2MjYs NyBAQCBGcmluZ2UgQml0bWFwcwogVXNlZCBmb3IgZGlmZmVyZW50IHR5cGVzIG9mIGZyaW5n ZSBjdXJzb3JzLgogCiBAaXRlbSBAY29kZXtleGNsYW1hdGlvbi1tYXJrfSwgQGNvZGV7cXVl c3Rpb24tbWFya30KK0BpdGVteCBAY29kZXtsYXJnZS1jaXJjbGV9CiBOb3QgdXNlZCBieSBj b3JlIEVtYWNzIGZlYXR1cmVzLgogQGVuZCB0YWJsZQogCmRpZmYgLS1naXQgYS9ldGMvTkVX UyBiL2V0Yy9ORVdTCmluZGV4IGI4OGZiNjM2NjIuLjIxOWU4MTI0ZmUgMTAwNjQ0Ci0tLSBh L2V0Yy9ORVdTCisrKyBiL2V0Yy9ORVdTCkBAIC0xOTc5LDYgKzE5NzksMTEgQEAgcmVjZW50 bHkgc2V0LgogKioqIFdoZW4gZWRpdGluZyBhIGJvb2ttYXJrIGFubm90YXRpb24sICdDLWMg Qy1rJyB3aWxsIG5vdyBjYW5jZWwuCiBJdCBpcyBib3VuZCB0byB0aGUgbmV3IGNvbW1hbmQg J2Jvb2ttYXJrLWVkaXQtYW5ub3RhdGlvbi1jYW5jZWwnLgogCistLS0KKyoqKiBOZXcgb3B0 aW9uICdib29rbWFyay1mcmluZ2UtbWFyaycuCitUaGlzIG9wdGlvbiBjb250cm9scyB0aGUg Yml0bWFwIHVzZWQgdG8gaW5kaWNhdGUgYm9va21hcmtzIGluIHRoZQorZnJpbmdlIChvciAn bmlsJyB0byBkaXNhYmxlIHNob3dpbmcgdGhpcyBtYXJrZXIpLgorCiAqKiBFeGlmCiAKIC0t LQpkaWZmIC0tZ2l0IGEvbGlzcC9ib29rbWFyay5lbCBiL2xpc3AvYm9va21hcmsuZWwKaW5k ZXggMzBhMDNlMDQzMS4uMGJkZjNiY2M1OCAxMDA2NDQKLS0tIGEvbGlzcC9ib29rbWFyay5l bAorKysgYi9saXNwL2Jvb2ttYXJrLmVsCkBAIC0xODEsMTAgKzE4MSwzMiBAQCBib29rbWFy ay1zZWFyY2gtZGVsYXkKICAgIlRpbWUgYmVmb3JlIGBib29rbWFyay1ibWVudS1zZWFyY2gn IHVwZGF0ZXMgdGhlIGRpc3BsYXkuIgogICA6dHlwZSAgJ251bWJlcikKIAotKGRlZmN1c3Rv bSBib29rbWFyay1zZXQtZnJpbmdlLW1hcmsgdAotICAiV2hldGhlciB0byBzZXQgYSBmcmlu Z2UgbWFyayBhdCBib29rbWFya2VkIGxpbmVzLiIKLSAgOnR5cGUgICdib29sZWFuCi0gIDp2 ZXJzaW9uICIyOC4xIikKKyhkZWZpbmUtZnJpbmdlLWJpdG1hcCAnYm9va21hcmstbWFyawor ICBbI2IwMTExMTExMAorICAgI2IwMTExMTExMAorICAgI2IwMTExMTExMAorICAgI2IwMTEx MTExMAorICAgI2IwMTExMTExMAorICAgI2IwMTExMTExMAorICAgI2IwMTEwMDExMAorICAg I2IwMTAwMDAxMF0pCisKKyhkZWZ2YXIgYm9va21hcmstLWZyaW5nZS1tYXJrIG5pbAorICAi QSBwcm94eSBvYmplY3QgdG8gdXNlIHdoZW4gc2V0dGluZyB0aGUgYm9va21hcmsgZnJpbmdl IG1hcmsuCitUaGlzIGhvbGRzIGEgYGZyaW5nZScgcHJvcGVydHkgdGhhdCBjYW4gYmUgdXBk YXRlZCBpbi1wbGFjZSB0bworZHluYW1pY2FsbHkgY2hhbmdlIHRoZSBiaXRtYXAgdXNlZCBm b3IgbWFya2luZyBib29rbWFya3MuIikKKworKGRlZmluZS1vYnNvbGV0ZS12YXJpYWJsZS1h bGlhcyAnYm9va21hcmstc2V0LWZyaW5nZS1tYXJrCisgICdib29rbWFyay1mcmluZ2UtbWFy ayAiMjkuMSIpCisKKyhkZWZjdXN0b20gYm9va21hcmstZnJpbmdlLW1hcmsgJ2Jvb2ttYXJr LW1hcmsKKyAgIlRoZSBmcmluZ2UgYml0bWFwIHRvIG1hcmsgYm9va21hcmtlZCBsaW5lcyB3 aXRoLgorSWYgbmlsLCBkb24ndCBkaXNwbGF5IGEgbWFyayBvbiB0aGUgZnJpbmdlLiIKKyAg OnR5cGUgJyhjaG9pY2UgKGNvbnN0IG5pbCkgZnJpbmdlLWJpdG1hcCkKKyAgOnNldCAobGFt YmRhIChzeW1ib2wgdmFsdWUpCisgICAgICAgICAoc2V0IHN5bWJvbCB2YWx1ZSkKKyAgICAg ICAgIChwdXQgJ2Jvb2ttYXJrLS1mcmluZ2UtbWFyayAnZnJpbmdlIChnZXQgdmFsdWUgJ2Zy aW5nZSkpKQorICA6dmVyc2lvbiAiMjkuMSIpCiAKIDs7IEZJWE1FOiBObyBsb25nZXIgdXNl ZC4gIFNob3VsZCBiZSBkZWNsYXJlZCBvYnNvbGV0ZSBvciByZW1vdmVkLgogKGRlZmZhY2Ug Ym9va21hcmstbWVudS1oZWFkaW5nCkBAIC0yMDEsMTAgKzIyMywxMCBAQCBib29rbWFyay1m YWNlCiAgICAgIDpmb3JlZ3JvdW5kICJMaWdodEdyYXkiKQogICAgICgoKGNsYXNzIGNvbG9y KQogICAgICAgKGJhY2tncm91bmQgbGlnaHQpKQotICAgICA6YmFja2dyb3VuZCAiV2hpdGUi IDpmb3JlZ3JvdW5kICJEYXJrT3JhbmdlMSIpCisgICAgIDpmb3JlZ3JvdW5kICJEYXJrT3Jh bmdlMSIgOmRpc3RhbnQtZm9yZWdyb3VuZCAiRGFya09yYW5nZTMiKQogICAgICgoKGNsYXNz IGNvbG9yKQogICAgICAgKGJhY2tncm91bmQgZGFyaykpCi0gICAgIDpiYWNrZ3JvdW5kICJC bGFjayIgOmZvcmVncm91bmQgIkRhcmtPcmFuZ2UxIikpCisgICAgIDpmb3JlZ3JvdW5kICJE YXJrT3JhbmdlMSIgOmRpc3RhbnQtZm9yZWdyb3VuZCAiT3JhbmdlMSIpKQogICAiRmFjZSB1 c2VkIHRvIGhpZ2hsaWdodCBjdXJyZW50IGxpbmUuIgogICA6dmVyc2lvbiAiMjguMSIpCiAK QEAgLTQ4MiwyNCArNTA0LDIxIEBAIGJvb2ttYXJrLXVwZGF0ZS1sYXN0LW1vZGlmaWVkCiAo ZGVmdmFyIGJvb2ttYXJrLWhpc3RvcnkgbmlsCiAgICJUaGUgaGlzdG9yeSBsaXN0IGZvciBi b29rbWFyayBmdW5jdGlvbnMuIikKIAotKGRlZmluZS1mcmluZ2UtYml0bWFwICdib29rbWFy ay1mcmluZ2UtbWFyawotICAiXHgzY1x4N2VceGZmXHhmZlx4ZmZceGZmXHg3ZVx4M2MiKQot CiAoZGVmdW4gYm9va21hcmstLXNldC1mcmluZ2UtbWFyayAoKQogICAiQXBwbHkgYSBjb2xv cml6ZWQgb3ZlcmxheSB0byB0aGUgYm9va21hcmtlZCBsb2NhdGlvbi4KLVNlZSB1c2VyIG9w dGlvbiBgYm9va21hcmstc2V0LWZyaW5nZS1tYXJrJy4iCitTZWUgdXNlciBvcHRpb24gYGJv b2ttYXJrLWZyaW5nZS1tYXJrJy4iCiAgIChsZXQgKChibSAobWFrZS1vdmVybGF5IChwb2lu dC1hdC1ib2wpICgxKyAocG9pbnQtYXQtYm9sKSkpKSkKICAgICAob3ZlcmxheS1wdXQgYm0g J2NhdGVnb3J5ICdib29rbWFyaykKICAgICAob3ZlcmxheS1wdXQgYm0gJ2V2YXBvcmF0ZSB0 KQogICAgIChvdmVybGF5LXB1dCBibSAnYmVmb3JlLXN0cmluZwogICAgICAgICAgICAgICAg ICAocHJvcGVydGl6ZQogICAgICAgICAgICAgICAgICAgIngiICdkaXNwbGF5Ci0gICAgICAg ICAgICAgICAgICBgKGxlZnQtZnJpbmdlIGJvb2ttYXJrLWZyaW5nZS1tYXJrIGJvb2ttYXJr LWZhY2UpKSkpKQorICAgICAgICAgICAgICAgICAgYChsZWZ0LWZyaW5nZSBib29rbWFyay0t ZnJpbmdlLW1hcmsgYm9va21hcmstZmFjZSkpKSkpCiAKIChkZWZ1biBib29rbWFyay0tcmVt b3ZlLWZyaW5nZS1tYXJrIChibSkKICAgIlJlbW92ZSBhIGJvb2ttYXJrJ3MgY29sb3JpemVk IG92ZXJsYXkuCiBCTSBpcyBhIGJvb2ttYXJrIGFzIHJldHVybmVkIGZyb20gZnVuY3Rpb24g YGJvb2ttYXJrLWdldC1ib29rbWFyaycuCi1TZWUgdXNlciBvcHRpb24gYGJvb2ttYXJrLXNl dC1mcmluZ2UnLiIKK1NlZSB1c2VyIG9wdGlvbiBgYm9va21hcmstZnJpbmdlLW1hcmsnLiIK ICAgKGxldCAoKGZpbGVuYW1lIChjZHIgKGFzc3EgJ2ZpbGVuYW1lIGJtKSkpCiAgICAgICAg IChwb3MgKGNkciAoYXNzcSAncG9zaXRpb24gYm0pKSkKICAgICAgICAgb3ZlcmxheXMgZm91 bmQgdGVtcCkKQEAgLTYxNSw3ICs2MzQsNyBAQCBib29rbWFyay1zdG9yZQogICAgICAgICA7 OyBubyBwcmVmaXggYXJnIG1lYW5zIGp1c3Qgb3ZlcndyaXRlIG9sZCBib29rbWFyay4KICAg ICAgICAgKGxldCAoKGJtIChib29rbWFyay1nZXQtYm9va21hcmsgc3RyaXBwZWQtbmFtZSkp KQogICAgICAgICAgIDs7IEZpcnN0IGNsZWFuIHVwIGlmIHByZXZpb3VzbHkgbG9jYXRpb24g d2FzIGZvbnRpZmllZC4KLSAgICAgICAgICAod2hlbiBib29rbWFyay1zZXQtZnJpbmdlLW1h cmsKKyAgICAgICAgICAod2hlbiBib29rbWFyay1mcmluZ2UtbWFyawogICAgICAgICAgICAg KGJvb2ttYXJrLS1yZW1vdmUtZnJpbmdlLW1hcmsgYm0pKQogICAgICAgICAgIDs7IE1vZGlm eSB1c2luZyB0aGUgbmV3IChOQU1FIC4gQUxJU1QpIGZvcm1hdC4KICAgICAgICAgICAoc2V0 Y2RyIGJtIGFsaXN0KSkKQEAgLTkzMSw3ICs5NTAsNyBAQCBib29rbWFyay1zZXQtaW50ZXJu YWwKICAgICAgICAgICAgOzsgQXNrIGZvciBhbiBhbm5vdGF0aW9uIGJ1ZmZlciBmb3IgdGhp cyBib29rbWFyawogICAgICAgICAgICAod2hlbiBib29rbWFyay11c2UtYW5ub3RhdGlvbnMK ICAgICAgICAgICAgICAoYm9va21hcmstZWRpdC1hbm5vdGF0aW9uIHN0cikpCi0gICAgICAg ICAgICh3aGVuIGJvb2ttYXJrLXNldC1mcmluZ2UtbWFyaworICAgICAgICAgICAod2hlbiBi b29rbWFyay1mcmluZ2UtbWFyawogICAgICAgICAgICAgIChib29rbWFyay0tc2V0LWZyaW5n ZS1tYXJrKSkpKQogICAgIChzZXRxIGJvb2ttYXJrLXlhbmstcG9pbnQgbmlsKQogICAgIChz ZXRxIGJvb2ttYXJrLWN1cnJlbnQtYnVmZmVyIG5pbCkpKQpAQCAtMTIxMyw3ICsxMjMyLDcg QEAgYm9va21hcmstLWp1bXAtdmlhCiAgICAgKGlmIHdpbiAoc2V0LXdpbmRvdy1wb2ludCB3 aW4gKHBvaW50KSkpKQogICA7OyBGSVhNRTogd2UgdXNlZCB0byBvbmx5IHJ1biBib29rbWFy ay1hZnRlci1qdW1wLWhvb2sgaW4KICAgOzsgYGJvb2ttYXJrLWp1bXAnIGl0c2VsZiwgYnV0 IGluIG5vbmUgb2YgdGhlIG90aGVyIGNvbW1hbmRzLgotICAod2hlbiBib29rbWFyay1zZXQt ZnJpbmdlLW1hcmsKKyAgKHdoZW4gYm9va21hcmstZnJpbmdlLW1hcmsKICAgICAobGV0ICgo b3ZlcmxheXMgKG92ZXJsYXlzLWluIChwb2ludC1hdC1ib2wpICgxKyAocG9pbnQtYXQtYm9s KSkpKQogICAgICAgICAgIHRlbXAgZm91bmQpCiAgICAgICAod2hpbGUgKGFuZCAobm90IGZv dW5kKSAoc2V0cSB0ZW1wIChwb3Agb3ZlcmxheXMpKSkKZGlmZiAtLWdpdCBhL2xpc3AvY3Vz LWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4IGVkYzA5ZjMxOTkuLmNhMjY5MjJj MzAgMTAwNjQ0Ci0tLSBhL2xpc3AvY3VzLWVkaXQuZWwKKysrIGIvbGlzcC9jdXMtZWRpdC5l bApAQCAtNDI4Niw2ICs0Mjg2LDI3IEBAIGN1c3RvbS1ob29rLWNvbnZlcnQtd2lkZ2V0CiAg ICAgKHdpZGdldC1wdXQgd2lkZ2V0IDphcmdzIGFyZ3MpCiAgICAgd2lkZ2V0KSkKIAorOzs7 IFRoZSBgZnJpbmdlLWJpdG1hcCcgV2lkZ2V0LgorCisoZGVmdmFyIHdpZGdldC1mcmluZ2Ut Yml0bWFwLXByb21wdC12YWx1ZS1oaXN0b3J5IG5pbAorICAiSGlzdG9yeSBvZiBpbnB1dCB0 byBgd2lkZ2V0LWZyaW5nZS1iaXRtYXAtcHJvbXB0LXZhbHVlJy4iKQorCisoZGVmaW5lLXdp ZGdldCAnZnJpbmdlLWJpdG1hcCAnc3ltYm9sCisgICJBIExpc3AgZnJpbmdlIGJpdG1hcCBu YW1lIgorICA6Zm9ybWF0ICIldiIKKyAgOnRhZyAiRnJpbmdlIGJpdG1hcCIKKyAgOm1hdGNo IChsYW1iZGEgKF93aWRnZXQgdmFsdWUpIChmcmluZ2UtYml0bWFwLXAgdmFsdWUpKQorICA6 Y29tcGxldGlvbnMgKGFwcGx5LXBhcnRpYWxseSAjJ2NvbXBsZXRpb24tdGFibGUtd2l0aC1w cmVkaWNhdGUKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgb2JhcnJheSAjJ2Zy aW5nZS1iaXRtYXAtcCAnc3RyaWN0KQorICA6cHJvbXB0LW1hdGNoICdmcmluZ2UtYml0bWFw LXAKKyAgOnByb21wdC1oaXN0b3J5ICd3aWRnZXQtZmFjZS1wcm9tcHQtdmFsdWUtaGlzdG9y eQorICA6dmFsaWRhdGUgKGxhbWJkYSAod2lkZ2V0KQorCSAgICAgICh1bmxlc3MgKGZyaW5n ZS1iaXRtYXAtcCAod2lkZ2V0LXZhbHVlIHdpZGdldCkpCisJCSh3aWRnZXQtcHV0IHdpZGdl dAorCQkJICAgIDplcnJvciAoZm9ybWF0ICJJbnZhbGlkIGZyaW5nZSBiaXRtYXA6ICVTIgor CQkJCQkgICAod2lkZ2V0LXZhbHVlIHdpZGdldCkpKQorCQl3aWRnZXQpKSkKKwogOzs7IFRo ZSBgY3VzdG9tLWdyb3VwLWxpbmsnIFdpZGdldC4KIAogKGRlZmluZS13aWRnZXQgJ2N1c3Rv bS1ncm91cC1saW5rICdsaW5rCmRpZmYgLS1naXQgYS9saXNwL2ZyaW5nZS5lbCBiL2xpc3Av ZnJpbmdlLmVsCmluZGV4IDY1N2E3Mzc3MmQuLmRhNjgxMmU2OGQgMTAwNjQ0Ci0tLSBhL2xp c3AvZnJpbmdlLmVsCisrKyBiL2xpc3AvZnJpbmdlLmVsCkBAIC00Niw2ICs0Niw3IEBAIGZy aW5nZQogICAobGV0ICgoYml0bWFwcyAnKHF1ZXN0aW9uLW1hcmsgZXhjbGFtYXRpb24tbWFy awogCQkgICBsZWZ0LWFycm93IHJpZ2h0LWFycm93IHVwLWFycm93IGRvd24tYXJyb3cKIAkJ ICAgbGVmdC1jdXJseS1hcnJvdyByaWdodC1jdXJseS1hcnJvdworCQkgICBsYXJnZS1jaXJj bGUKIAkJICAgbGVmdC10cmlhbmdsZSByaWdodC10cmlhbmdsZQogCQkgICB0b3AtbGVmdC1h bmdsZSB0b3AtcmlnaHQtYW5nbGUKIAkJICAgYm90dG9tLWxlZnQtYW5nbGUgYm90dG9tLXJp Z2h0LWFuZ2xlCmRpZmYgLS1naXQgYS9zcmMvZnJpbmdlLmMgYi9zcmMvZnJpbmdlLmMKaW5k ZXggYmYwYjVmZGU3Ni4uNWQ3YzhkY2E5OSAxMDA2NDQKLS0tIGEvc3JjL2ZyaW5nZS5jCisr KyBiL3NyYy9mcmluZ2UuYwpAQCAtMjA5LDYgKzIwOSwyMCBAQAogc3RhdGljIHVuc2lnbmVk IHNob3J0IHJpZ2h0X2N1cmx5X2Fycm93X2JpdHNbXSA9IHsKICAgIDB4M2MsIDB4M2UsIDB4 MDMsIDB4MjcsIDB4M2YsIDB4M2UsIDB4M2MsIDB4M2V9OwogCisvKiBMYXJnZSBjaXJjbGUg Yml0bWFwLiAgKi8KKy8qCisgIC4uLi4uLi4uCisgIC4ueHh4eC4uCisgIC54eHh4eHguCisg IHh4eHh4eHh4CisgIHh4eHh4eHh4CisgIC54eHh4eHguCisgIC4ueHh4eC4uCisgIC4uLi4u Li4uCisqLworc3RhdGljIHVuc2lnbmVkIHNob3J0IGxhcmdlX2NpcmNsZV9iaXRzW10gPSB7 CisgIDB4M2MsIDB4N2UsIDB4ZmYsIDB4ZmYsIDB4ZmYsIDB4ZmYsIDB4N2UsIDB4M2N9Owor CiAvKiBSZXZlcnNlIE92ZXJsYXkgYXJyb3cgYml0bWFwLiAgQSB0cmlhbmd1bGFyIGFycm93 LiAgKi8KIC8qCiAgIC4uLi4uLnh4CkBAIC00NTQsNiArNDY4LDcgQEAgI2RlZmluZSBGUkJJ VFMoYml0cykgIGJpdHMsIFNUQU5EQVJEX0JJVE1BUF9IRUlHSFQgKGJpdHMpCiAgIHsgRlJC SVRTIChkb3duX2Fycm93X2JpdHMpLCAgICAgICAgIDgsIDAsIEFMSUdOX0JJVE1BUF9CT1RU T00sIDAgfSwKICAgeyBGUkJJVFMgKGxlZnRfY3VybHlfYXJyb3dfYml0cyksICAgOCwgMCwg QUxJR05fQklUTUFQX0NFTlRFUiwgMCB9LAogICB7IEZSQklUUyAocmlnaHRfY3VybHlfYXJy b3dfYml0cyksICA4LCAwLCBBTElHTl9CSVRNQVBfQ0VOVEVSLCAwIH0sCisgIHsgRlJCSVRT IChsYXJnZV9jaXJjbGVfYml0cyksICAgICAgIDgsIDAsIEFMSUdOX0JJVE1BUF9DRU5URVIs IDAgfSwKICAgeyBGUkJJVFMgKGxlZnRfdHJpYW5nbGVfYml0cyksICAgICAgOCwgMCwgQUxJ R05fQklUTUFQX0NFTlRFUiwgMCB9LAogICB7IEZSQklUUyAocmlnaHRfdHJpYW5nbGVfYml0 cyksICAgICA4LCAwLCBBTElHTl9CSVRNQVBfQ0VOVEVSLCAwIH0sCiAgIHsgRlJCSVRTICh0 b3BfbGVmdF9hbmdsZV9iaXRzKSwgICAgIDgsIDAsIEFMSUdOX0JJVE1BUF9UT1AsICAgIDAg fSwKLS0gCjIuMjUuMQoK --------------2D4DBE4B10623A0DADBE3CD3-- From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Aug 2022 22:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Lars Ingebrigtsen , 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.166042800329137 (code B ref 56896); Sat, 13 Aug 2022 22:01:02 +0000 Received: (at 56896) by debbugs.gnu.org; 13 Aug 2022 22:00:03 +0000 Received: from localhost ([127.0.0.1]:35316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMzAn-0007ZL-CE for submit@debbugs.gnu.org; Sat, 13 Aug 2022 18:00:02 -0400 Received: from mail-pg1-f179.google.com ([209.85.215.179]:33338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oMzAj-0007Z7-UY for 56896@debbugs.gnu.org; Sat, 13 Aug 2022 17:59:59 -0400 Received: by mail-pg1-f179.google.com with SMTP id l64so3638662pge.0 for <56896@debbugs.gnu.org>; Sat, 13 Aug 2022 14:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id :references:to:from:subject:from:to:cc; bh=goKi1PkMjBSNu4dUoq4iZfVqhxF7ePlVg8nZDzMDw5k=; b=XPQJk9s5CjZbNt/2ph9dXfvqSUP1j/UWjbfjzSlOqyFdG5tJl0u3aVWIKBjLlDwMRn RZIoM+AdTjiDV7fDlwyiu28BPCsaLEgYF3TPfKZLFFhh9bPedXB07Lpc5hOQeLU3rJBB GeEKsfrRPghdCL2WjOABCMDNhZ3cfOBDH2E9OR7/i4bu/r8prcOz2yZcUUAwf4ao/7jY NGNBFYTJ2ib16vXR5BG8WgSb4UI2KgNxhKejX91HBQwGozdMlbzjyIl1ZIM9VF+Tf/Mm ZDbHkIRAb42NE5P85gnTsWcj3wqRV4Kd3GoASW7TNWrHmTMOcXgguzyp2GalCGYD8tI7 ig2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:in-reply-to:mime-version:date:message-id :references:to:from:subject:x-gm-message-state:from:to:cc; bh=goKi1PkMjBSNu4dUoq4iZfVqhxF7ePlVg8nZDzMDw5k=; b=OQ3dxApWotpjmlbcoho77gI2EwJN2f2uNw8yd0nMIbbcfVsd/BIF06PD4B7m3Z0KOv moD6crRy3LC6qHTrFsVoWegwkGfTazMhOtViyetvmli9sGHopUngjd+cJOtdLi5PJsQl LzkbqGiLRPPJTwUCrZhQ6T6/XHJnqWGxMyO9EmTC36w1b0qm7BM3TWWstHDsjMB2PTBw cmD2yc3+GGHsARn5X2KaVgLZm5DQgkG21km93H73I+6mj5Qxfg7+9eRl4tC6iQK9/+gz 5HIIPEoe6Jw9xaDztW3anuR7RYGSRt6Sfz/b8Y2N8XFJRhuz4gaP8n5m/AZC6hcPzEZS YpFA== X-Gm-Message-State: ACgBeo2Fr1+GNvbMMHwzdxtgnMxfYLPyxzw5kCHePx41gAaAA/9VVio0 awprkmNCGQzWsRAnoYoYmYt76fhqks0= X-Google-Smtp-Source: AA6agR4UnyYERcceh6KzfDKIAtU6TLMeu3f+uk9aF85+aLQH9ttjsQuuqbV8hlytBn6TL24KF2lKQg== X-Received: by 2002:a05:6a00:288d:b0:52e:e0cd:151e with SMTP id ch13-20020a056a00288d00b0052ee0cd151emr9502713pfb.24.1660427991899; Sat, 13 Aug 2022 14:59:51 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id v14-20020aa799ce000000b0052b6277df9esm4060844pfi.43.2022.08.13.14.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Aug 2022 14:59:50 -0700 (PDT) From: Jim Porter References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> <83edxw4hzn.fsf@gnu.org> <7566691d-090e-f380-b395-4d2aa2fdebdb@gmail.com> Message-ID: <01ebb4e2-4f0d-98c1-2e34-e7f5ea3fdc39@gmail.com> Date: Sat, 13 Aug 2022 14:59:49 -0700 MIME-Version: 1.0 In-Reply-To: <7566691d-090e-f380-b395-4d2aa2fdebdb@gmail.com> Content-Type: multipart/mixed; boundary="------------F2BAFEE8C72D9A96344EA0EB" Content-Language: en-US X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------F2BAFEE8C72D9A96344EA0EB Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 8/4/2022 9:41 PM, Jim Porter wrote: > Ok, I figured out a way to do this. I added a proxy object > ('bookmark--fringe-mark') that I can dynamically set the 'fringe' > property on, and then the :set function will update that and the display > code will Just Work. Well, so long as a redisplay is triggered, but I > think happens when you set options via Customize? It worked in my tests, > anyway. > > This method feels kind of hacky, but I can't think of a better way, and > it's certainly more feasible than trying to find all the fringe markers > manually. (Given that code can define custom bookmark handler functions, > I'm not even sure that would have been possible...) Here's a better version of this patch. Rather than a proxy object, it just sets the 'fringe' property on the defcustom, which the rest of the bookmark code can then use like a "regular" fringe bitmap (essentially, it's just an alias to a real fringe bitmap). I also added a 'fringe-custom-set-bitmap' function that anyone can use as a :set function. This should be general enough that it could be used wherever anyone wants to allow users to use Customize to change the fringe bitmap that gets used for a particular purpose. Potentially, it could even be used for *every* use of a fringe bitmap. That would let users pick icons they like for a particular purpose based on their general description (e.g. 'right-triangle'), but they could also independently adjust the bitmaps (e.g. redefining all the fringe bitmaps to be larger for high DPI monitors). For the latter case, maybe users could download a package from ELPA to do that. --------------F2BAFEE8C72D9A96344EA0EB Content-Type: text/plain; charset=UTF-8; name="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patc"; filename*1="h" RnJvbSBjODMwMzRlMmNjNGQyOWE3YWI0YTg0NzYxYTEwN2M1M2JhZDZjZGU4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMiBBdWcgMjAyMiAxMTo0MDo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIE1ha2UgdGhlIGJvb2ttYXJrIGZyaW5nZSBpY29uIGxvb2sgbGlrZSBhIGJvb2ttYXJr CgoqIHNyYy9mcmluZ2UuYyAobGFyZ2VfY2lyY2xlX2JpdHMpOiBOZXcgdmFyaWFibGUuCihz dGFuZGFyZF9iaXRtYXBzKTogQWRkIGxhcmdlX2NpcmNsZV9iaXRzLgoKKiBsaXNwL2ZyaW5n ZS5lbCAoZnJpbmdlLWJpdG1hcHMpOiBBZGQgJ2xhcmdlLWNpcmNsZScuCihmcmluZ2UtY3Vz dG9tLXNldC1iaXRtYXApOiBOZXcgZnVuY3Rpb24uCgoqIGxpc3AvY3VzLWVkaXQuZWwgKHdp ZGdldC1mcmluZ2UtYml0bWFwLXByb21wdC12YWx1ZS1oaXN0b3J5KTogTmV3CnZhcmlhYmxl LgooZnJpbmdlLWJpdG1hcCk6IE5ldyB3aWRnZXQuCgoqIGxpc3AvYm9va21hcmsuZWwgKGJv b2ttYXJrLXNldC1mcmluZ2UtbWFyayk6IE9ic29sZXRlIGluIGZhdm9yIG9mLi4uCihib29r bWFyay1mcmluZ2UtbWFyayk6IC4uLiB0aGlzLgooYm9va21hcmstZnJpbmdlLW1hcmspOiBS ZW5hbWUgdGhpcyBmcmluZ2UgYml0bWFwIHRvLi4uCihib29rbWFyay1tYXJrKTogLi4uIGFu ZCBjaGFuZ2UgaXQgdG8gbG9vayBsaWtlIGEgYm9va21hcmsuCihib29rbWFyay1mYWNlKTog RG9uJ3Qgc2V0IHRoZSAnOmJhY2tncm91bmQnIG9mIHRoZSBmYWNlLiAgSW5zdGVhZCwKc2V0 ICc6ZGlzdGFudC1mb3JlZ3JvdW5kJy4KKGJvb2ttYXJrLS1zZXQtZnJpbmdlLW1hcmssIGJv b2ttYXJrLS1yZW1vdmUtZnJpbmdlLW1hcmspCihib29rbWFyay1zdG9yZSwgYm9va21hcmst LWp1bXAtdmlhKTogQ29uc3VsdCB0aGUKJ2Jvb2ttYXJrLWZyaW5nZS1tYXJrJyBvcHRpb24u CgoqIGRvYy9saXNwcmVmL2N1c3RvbWl6ZS50ZXhpIChTaW1wbGUgVHlwZXMpOiBEb2N1bWVu dCAnZnJpbmdlLWJpdG1hcCcKdHlwZS4KCiogZG9jL2xpc3ByZWYvZGlzcGxheS50ZXhpIChG cmluZ2UgQml0bWFwcyk6IE1lbnRpb24gJ2xhcmdlLWNpcmNsZScuCgoqIGV0Yy9ORVdTOiBB bm5vdW5jZSB0aGlzIGNoYW5nZS4KLS0tCiBkb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aSB8 ICA0ICsrKysKIGRvYy9saXNwcmVmL2Rpc3BsYXkudGV4aSAgIHwgIDEgKwogZXRjL05FV1Mg ICAgICAgICAgICAgICAgICAgfCAgNSArKysrKwogbGlzcC9ib29rbWFyay5lbCAgICAgICAg ICAgfCA0MCArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLQogbGlzcC9j dXMtZWRpdC5lbCAgICAgICAgICAgfCAyMSArKysrKysrKysrKysrKysrKysrKwogbGlzcC9m cmluZ2UuZWwgICAgICAgICAgICAgfCAxMiArKysrKysrKysrKysKIHNyYy9mcmluZ2UuYyAg ICAgICAgICAgICAgIHwgMTUgKysrKysrKysrKysrKysKIDcgZmlsZXMgY2hhbmdlZCwgODQg aW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvZG9jL2xpc3By ZWYvY3VzdG9taXplLnRleGkgYi9kb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aQppbmRleCA1 Mjg0MjFiZjNiLi42YmEzNWNmZmZmIDEwMDY0NAotLS0gYS9kb2MvbGlzcHJlZi9jdXN0b21p emUudGV4aQorKysgYi9kb2MvbGlzcHJlZi9jdXN0b21pemUudGV4aQpAQCAtNjcyLDYgKzY3 MiwxMCBAQCBTaW1wbGUgVHlwZXMKIGZvciBjb2xvciBuYW1lcywgYXMgd2VsbCBhcyBhIHNh bXBsZSBhbmQgYSBidXR0b24gZm9yIHNlbGVjdGluZyBhCiBjb2xvciBuYW1lIGZyb20gYSBs aXN0IG9mIGNvbG9yIG5hbWVzIHNob3duIGluIGEgQGZpbGV7KkNvbG9ycyp9CiBidWZmZXIu CisKK0BpdGVtIGZyaW5nZS1iaXRtYXAKK1RoZSB2YWx1ZSBtdXN0IGJlIGEgdmFsaWQgZnJp bmdlIGJpdG1hcCBuYW1lLiAgVGhlIHdpZGdldCBwcm92aWRlcworY29tcGxldGlvbi4KIEBl bmQgdGFibGUKIAogQG5vZGUgQ29tcG9zaXRlIFR5cGVzCmRpZmYgLS1naXQgYS9kb2MvbGlz cHJlZi9kaXNwbGF5LnRleGkgYi9kb2MvbGlzcHJlZi9kaXNwbGF5LnRleGkKaW5kZXggOTYw NzlkYzEwNi4uZDMzNmNkYTY3NCAxMDA2NDQKLS0tIGEvZG9jL2xpc3ByZWYvZGlzcGxheS50 ZXhpCisrKyBiL2RvYy9saXNwcmVmL2Rpc3BsYXkudGV4aQpAQCAtNDYyNiw2ICs0NjI2LDcg QEAgRnJpbmdlIEJpdG1hcHMKIFVzZWQgZm9yIGRpZmZlcmVudCB0eXBlcyBvZiBmcmluZ2Ug Y3Vyc29ycy4KIAogQGl0ZW0gQGNvZGV7ZXhjbGFtYXRpb24tbWFya30sIEBjb2Rle3F1ZXN0 aW9uLW1hcmt9CitAaXRlbXggQGNvZGV7bGFyZ2UtY2lyY2xlfQogTm90IHVzZWQgYnkgY29y ZSBFbWFjcyBmZWF0dXJlcy4KIEBlbmQgdGFibGUKIApkaWZmIC0tZ2l0IGEvZXRjL05FV1Mg Yi9ldGMvTkVXUwppbmRleCBlMmJjY2NhNGE4Li5mNDEzOThlNWIwIDEwMDY0NAotLS0gYS9l dGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAtMjAxMSw2ICsyMDExLDExIEBAIHJlY2VudGx5 IHNldC4KICoqKiBXaGVuIGVkaXRpbmcgYSBib29rbWFyayBhbm5vdGF0aW9uLCAnQy1jIEMt aycgd2lsbCBub3cgY2FuY2VsLgogSXQgaXMgYm91bmQgdG8gdGhlIG5ldyBjb21tYW5kICdi b29rbWFyay1lZGl0LWFubm90YXRpb24tY2FuY2VsJy4KIAorLS0tCisqKiogTmV3IG9wdGlv biAnYm9va21hcmstZnJpbmdlLW1hcmsnLgorVGhpcyBvcHRpb24gY29udHJvbHMgdGhlIGJp dG1hcCB1c2VkIHRvIGluZGljYXRlIGJvb2ttYXJrcyBpbiB0aGUKK2ZyaW5nZSAob3IgJ25p bCcgdG8gZGlzYWJsZSBzaG93aW5nIHRoaXMgbWFya2VyKS4KKwogKiogRXhpZgogCiAtLS0K ZGlmZiAtLWdpdCBhL2xpc3AvYm9va21hcmsuZWwgYi9saXNwL2Jvb2ttYXJrLmVsCmluZGV4 IGQwODkzZTkzMmIuLjc0NjZiZTMyYjQgMTAwNjQ0Ci0tLSBhL2xpc3AvYm9va21hcmsuZWwK KysrIGIvbGlzcC9ib29rbWFyay5lbApAQCAtMTgxLDEwICsxODEsMjUgQEAgYm9va21hcmst c2VhcmNoLWRlbGF5CiAgICJUaW1lIGJlZm9yZSBgYm9va21hcmstYm1lbnUtc2VhcmNoJyB1 cGRhdGVzIHRoZSBkaXNwbGF5LiIKICAgOnR5cGUgICdudW1iZXIpCiAKLShkZWZjdXN0b20g Ym9va21hcmstc2V0LWZyaW5nZS1tYXJrIHQKLSAgIldoZXRoZXIgdG8gc2V0IGEgZnJpbmdl IG1hcmsgYXQgYm9va21hcmtlZCBsaW5lcy4iCi0gIDp0eXBlICAnYm9vbGVhbgotICA6dmVy c2lvbiAiMjguMSIpCisoZGVmaW5lLWZyaW5nZS1iaXRtYXAgJ2Jvb2ttYXJrLW1hcmsKKyAg WyNiMDExMTExMTAKKyAgICNiMDExMTExMTAKKyAgICNiMDExMTExMTAKKyAgICNiMDExMTEx MTAKKyAgICNiMDExMTExMTAKKyAgICNiMDExMTExMTAKKyAgICNiMDExMDAxMTAKKyAgICNi MDEwMDAwMTBdKQorCisoZGVmaW5lLW9ic29sZXRlLXZhcmlhYmxlLWFsaWFzICdib29rbWFy ay1zZXQtZnJpbmdlLW1hcmsKKyAgJ2Jvb2ttYXJrLWZyaW5nZS1tYXJrICIyOS4xIikKKwor KGRlZmN1c3RvbSBib29rbWFyay1mcmluZ2UtbWFyayAnYm9va21hcmstbWFyaworICAiVGhl IGZyaW5nZSBiaXRtYXAgdG8gbWFyayBib29rbWFya2VkIGxpbmVzIHdpdGguCitJZiBuaWws IGRvbid0IGRpc3BsYXkgYSBtYXJrIG9uIHRoZSBmcmluZ2UuIgorICA6dHlwZSAnKGNob2lj ZSAoY29uc3QgbmlsKSBmcmluZ2UtYml0bWFwKQorICA6c2V0ICMnZnJpbmdlLWN1c3RvbS1z ZXQtYml0bWFwCisgIDp2ZXJzaW9uICIyOS4xIikKIAogOzsgRklYTUU6IE5vIGxvbmdlciB1 c2VkLiAgU2hvdWxkIGJlIGRlY2xhcmVkIG9ic29sZXRlIG9yIHJlbW92ZWQuCiAoZGVmZmFj ZSBib29rbWFyay1tZW51LWhlYWRpbmcKQEAgLTIwMSwxMCArMjE2LDEwIEBAIGJvb2ttYXJr LWZhY2UKICAgICAgOmZvcmVncm91bmQgIkxpZ2h0R3JheSIpCiAgICAgKCgoY2xhc3MgY29s b3IpCiAgICAgICAoYmFja2dyb3VuZCBsaWdodCkpCi0gICAgIDpiYWNrZ3JvdW5kICJXaGl0 ZSIgOmZvcmVncm91bmQgIkRhcmtPcmFuZ2UxIikKKyAgICAgOmZvcmVncm91bmQgIkRhcmtP cmFuZ2UxIiA6ZGlzdGFudC1mb3JlZ3JvdW5kICJEYXJrT3JhbmdlMyIpCiAgICAgKCgoY2xh c3MgY29sb3IpCiAgICAgICAoYmFja2dyb3VuZCBkYXJrKSkKLSAgICAgOmJhY2tncm91bmQg IkJsYWNrIiA6Zm9yZWdyb3VuZCAiRGFya09yYW5nZTEiKSkKKyAgICAgOmZvcmVncm91bmQg IkRhcmtPcmFuZ2UxIiA6ZGlzdGFudC1mb3JlZ3JvdW5kICJPcmFuZ2UxIikpCiAgICJGYWNl IHVzZWQgdG8gaGlnaGxpZ2h0IGN1cnJlbnQgbGluZS4iCiAgIDp2ZXJzaW9uICIyOC4xIikK IApAQCAtNDgyLDEyICs0OTcsOSBAQCBib29rbWFyay11cGRhdGUtbGFzdC1tb2RpZmllZAog KGRlZnZhciBib29rbWFyay1oaXN0b3J5IG5pbAogICAiVGhlIGhpc3RvcnkgbGlzdCBmb3Ig Ym9va21hcmsgZnVuY3Rpb25zLiIpCiAKLShkZWZpbmUtZnJpbmdlLWJpdG1hcCAnYm9va21h cmstZnJpbmdlLW1hcmsKLSAgIlx4M2NceDdlXHhmZlx4ZmZceGZmXHhmZlx4N2VceDNjIikK LQogKGRlZnVuIGJvb2ttYXJrLS1zZXQtZnJpbmdlLW1hcmsgKCkKICAgIkFwcGx5IGEgY29s b3JpemVkIG92ZXJsYXkgdG8gdGhlIGJvb2ttYXJrZWQgbG9jYXRpb24uCi1TZWUgdXNlciBv cHRpb24gYGJvb2ttYXJrLXNldC1mcmluZ2UtbWFyaycuIgorU2VlIHVzZXIgb3B0aW9uIGBi b29rbWFyay1mcmluZ2UtbWFyaycuIgogICAobGV0ICgoYm0gKG1ha2Utb3ZlcmxheSAocG9p bnQtYXQtYm9sKSAoMSsgKHBvaW50LWF0LWJvbCkpKSkpCiAgICAgKG92ZXJsYXktcHV0IGJt ICdjYXRlZ29yeSAnYm9va21hcmspCiAgICAgKG92ZXJsYXktcHV0IGJtICdldmFwb3JhdGUg dCkKQEAgLTQ5OSw3ICs1MTEsNyBAQCBib29rbWFyay0tc2V0LWZyaW5nZS1tYXJrCiAoZGVm dW4gYm9va21hcmstLXJlbW92ZS1mcmluZ2UtbWFyayAoYm0pCiAgICJSZW1vdmUgYSBib29r bWFyaydzIGNvbG9yaXplZCBvdmVybGF5LgogQk0gaXMgYSBib29rbWFyayBhcyByZXR1cm5l ZCBmcm9tIGZ1bmN0aW9uIGBib29rbWFyay1nZXQtYm9va21hcmsnLgotU2VlIHVzZXIgb3B0 aW9uIGBib29rbWFyay1zZXQtZnJpbmdlJy4iCitTZWUgdXNlciBvcHRpb24gYGJvb2ttYXJr LWZyaW5nZS1tYXJrJy4iCiAgIChsZXQgKChmaWxlbmFtZSAoY2RyIChhc3NxICdmaWxlbmFt ZSBibSkpKQogICAgICAgICAocG9zIChjZHIgKGFzc3EgJ3Bvc2l0aW9uIGJtKSkpCiAgICAg ICAgIG92ZXJsYXlzIGZvdW5kIHRlbXApCkBAIC02MTUsNyArNjI3LDcgQEAgYm9va21hcmst c3RvcmUKICAgICAgICAgOzsgbm8gcHJlZml4IGFyZyBtZWFucyBqdXN0IG92ZXJ3cml0ZSBv bGQgYm9va21hcmsuCiAgICAgICAgIChsZXQgKChibSAoYm9va21hcmstZ2V0LWJvb2ttYXJr IHN0cmlwcGVkLW5hbWUpKSkKICAgICAgICAgICA7OyBGaXJzdCBjbGVhbiB1cCBpZiBwcmV2 aW91c2x5IGxvY2F0aW9uIHdhcyBmb250aWZpZWQuCi0gICAgICAgICAgKHdoZW4gYm9va21h cmstc2V0LWZyaW5nZS1tYXJrCisgICAgICAgICAgKHdoZW4gYm9va21hcmstZnJpbmdlLW1h cmsKICAgICAgICAgICAgIChib29rbWFyay0tcmVtb3ZlLWZyaW5nZS1tYXJrIGJtKSkKICAg ICAgICAgICA7OyBNb2RpZnkgdXNpbmcgdGhlIG5ldyAoTkFNRSAuIEFMSVNUKSBmb3JtYXQu CiAgICAgICAgICAgKHNldGNkciBibSBhbGlzdCkpCkBAIC05MzEsNyArOTQzLDcgQEAgYm9v a21hcmstc2V0LWludGVybmFsCiAgICAgICAgICAgIDs7IEFzayBmb3IgYW4gYW5ub3RhdGlv biBidWZmZXIgZm9yIHRoaXMgYm9va21hcmsKICAgICAgICAgICAgKHdoZW4gYm9va21hcmst dXNlLWFubm90YXRpb25zCiAgICAgICAgICAgICAgKGJvb2ttYXJrLWVkaXQtYW5ub3RhdGlv biBzdHIpKQotICAgICAgICAgICAod2hlbiBib29rbWFyay1zZXQtZnJpbmdlLW1hcmsKKyAg ICAgICAgICAgKHdoZW4gYm9va21hcmstZnJpbmdlLW1hcmsKICAgICAgICAgICAgICAoYm9v a21hcmstLXNldC1mcmluZ2UtbWFyaykpKSkKICAgICAoc2V0cSBib29rbWFyay15YW5rLXBv aW50IG5pbCkKICAgICAoc2V0cSBib29rbWFyay1jdXJyZW50LWJ1ZmZlciBuaWwpKSkKQEAg LTEyMTMsNyArMTIyNSw3IEBAIGJvb2ttYXJrLS1qdW1wLXZpYQogICAgIChpZiB3aW4gKHNl dC13aW5kb3ctcG9pbnQgd2luIChwb2ludCkpKSkKICAgOzsgRklYTUU6IHdlIHVzZWQgdG8g b25seSBydW4gYm9va21hcmstYWZ0ZXItanVtcC1ob29rIGluCiAgIDs7IGBib29rbWFyay1q dW1wJyBpdHNlbGYsIGJ1dCBpbiBub25lIG9mIHRoZSBvdGhlciBjb21tYW5kcy4KLSAgKHdo ZW4gYm9va21hcmstc2V0LWZyaW5nZS1tYXJrCisgICh3aGVuIGJvb2ttYXJrLWZyaW5nZS1t YXJrCiAgICAgKGxldCAoKG92ZXJsYXlzIChvdmVybGF5cy1pbiAocG9pbnQtYXQtYm9sKSAo MSsgKHBvaW50LWF0LWJvbCkpKSkKICAgICAgICAgICB0ZW1wIGZvdW5kKQogICAgICAgKHdo aWxlIChhbmQgKG5vdCBmb3VuZCkgKHNldHEgdGVtcCAocG9wIG92ZXJsYXlzKSkpCmRpZmYg LS1naXQgYS9saXNwL2N1cy1lZGl0LmVsIGIvbGlzcC9jdXMtZWRpdC5lbAppbmRleCBlZGMw OWYzMTk5Li5kNWJhZThmNjZmIDEwMDY0NAotLS0gYS9saXNwL2N1cy1lZGl0LmVsCisrKyBi L2xpc3AvY3VzLWVkaXQuZWwKQEAgLTQyODYsNiArNDI4NiwyNyBAQCBjdXN0b20taG9vay1j b252ZXJ0LXdpZGdldAogICAgICh3aWRnZXQtcHV0IHdpZGdldCA6YXJncyBhcmdzKQogICAg IHdpZGdldCkpCiAKKzs7OyBUaGUgYGZyaW5nZS1iaXRtYXAnIFdpZGdldC4KKworKGRlZnZh ciB3aWRnZXQtZnJpbmdlLWJpdG1hcC1wcm9tcHQtdmFsdWUtaGlzdG9yeSBuaWwKKyAgIkhp c3Rvcnkgb2YgaW5wdXQgdG8gYHdpZGdldC1mcmluZ2UtYml0bWFwLXByb21wdC12YWx1ZScu IikKKworKGRlZmluZS13aWRnZXQgJ2ZyaW5nZS1iaXRtYXAgJ3N5bWJvbAorICAiQSBMaXNw IGZyaW5nZSBiaXRtYXAgbmFtZS4iCisgIDpmb3JtYXQgIiV2IgorICA6dGFnICJGcmluZ2Ug Yml0bWFwIgorICA6bWF0Y2ggKGxhbWJkYSAoX3dpZGdldCB2YWx1ZSkgKGZyaW5nZS1iaXRt YXAtcCB2YWx1ZSkpCisgIDpjb21wbGV0aW9ucyAoYXBwbHktcGFydGlhbGx5ICMnY29tcGxl dGlvbi10YWJsZS13aXRoLXByZWRpY2F0ZQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBvYmFycmF5ICMnZnJpbmdlLWJpdG1hcC1wICdzdHJpY3QpCisgIDpwcm9tcHQtbWF0 Y2ggJ2ZyaW5nZS1iaXRtYXAtcAorICA6cHJvbXB0LWhpc3RvcnkgJ3dpZGdldC1mYWNlLXBy b21wdC12YWx1ZS1oaXN0b3J5CisgIDp2YWxpZGF0ZSAobGFtYmRhICh3aWRnZXQpCisJICAg ICAgKHVubGVzcyAoZnJpbmdlLWJpdG1hcC1wICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSkKKwkJ KHdpZGdldC1wdXQgd2lkZ2V0CisJCQkgICAgOmVycm9yIChmb3JtYXQgIkludmFsaWQgZnJp bmdlIGJpdG1hcDogJVMiCisJCQkJCSAgICh3aWRnZXQtdmFsdWUgd2lkZ2V0KSkpCisJCXdp ZGdldCkpKQorCiA7OzsgVGhlIGBjdXN0b20tZ3JvdXAtbGluaycgV2lkZ2V0LgogCiAoZGVm aW5lLXdpZGdldCAnY3VzdG9tLWdyb3VwLWxpbmsgJ2xpbmsKZGlmZiAtLWdpdCBhL2xpc3Av ZnJpbmdlLmVsIGIvbGlzcC9mcmluZ2UuZWwKaW5kZXggNjU3YTczNzcyZC4uMGM4ODUwMTI5 OCAxMDA2NDQKLS0tIGEvbGlzcC9mcmluZ2UuZWwKKysrIGIvbGlzcC9mcmluZ2UuZWwKQEAg LTQ2LDYgKzQ2LDcgQEAgZnJpbmdlCiAgIChsZXQgKChiaXRtYXBzICcocXVlc3Rpb24tbWFy ayBleGNsYW1hdGlvbi1tYXJrCiAJCSAgIGxlZnQtYXJyb3cgcmlnaHQtYXJyb3cgdXAtYXJy b3cgZG93bi1hcnJvdwogCQkgICBsZWZ0LWN1cmx5LWFycm93IHJpZ2h0LWN1cmx5LWFycm93 CisJCSAgIGxhcmdlLWNpcmNsZQogCQkgICBsZWZ0LXRyaWFuZ2xlIHJpZ2h0LXRyaWFuZ2xl CiAJCSAgIHRvcC1sZWZ0LWFuZ2xlIHRvcC1yaWdodC1hbmdsZQogCQkgICBib3R0b20tbGVm dC1hbmdsZSBib3R0b20tcmlnaHQtYW5nbGUKQEAgLTMyNCw2ICszMjUsMTcgQEAgZnJpbmdl LWNvbHVtbnMKICAgICA7OyBUaGUgcmVhbCBpbXBsZW1lbnRhdGlvbiBpcyBpbiBzcmMvZnJp bmdlLmMuCiAgICAgKSkKIAorKGRlZnVuIGZyaW5nZS1jdXN0b20tc2V0LWJpdG1hcCAoc3lt Ym9sIHZhbHVlKQorICAiU2V0IFNZTUJPTCB0byBhIGZyaW5nZSBiaXRtYXAgVkFMVUUuCitU aGlzIHNldHMgdGhlIGBmcmluZ2UnIHByb3BlcnR5IG9uIFNZTUJPTCB0byBtYXRjaCB0aGF0 IG9mIFZBTFVFLAorYW5kIHRoZW4gZm9yY2UgYWxsIHdpbmRvd3MgdG8gYmUgdXBkYXRlZCBv biB0aGUgbmV4dCByZWRpc3BsYXkuCitZb3Ugc2hvdWxkIHVzZSB0aGlzIGZvciB0aGUgOnNl dCBwYXJhbWV0ZXIgZm9yIGN1c3RvbWl6YXRpb24KK29wdGlvbnMgdG8gcGljayBhIGZyaW5n ZSBiaXRtYXAuIgorICAocHJvZzEKKyAgICAgIChzZXQgc3ltYm9sIHZhbHVlKQorICAgIChw dXQgc3ltYm9sICdmcmluZ2UgKGdldCB2YWx1ZSAnZnJpbmdlKSkKKyAgICAoZm9yY2Utd2lu ZG93LXVwZGF0ZSkpKQorCiAocHJvdmlkZSAnZnJpbmdlKQogCiA7OzsgZnJpbmdlLmVsIGVu ZHMgaGVyZQpkaWZmIC0tZ2l0IGEvc3JjL2ZyaW5nZS5jIGIvc3JjL2ZyaW5nZS5jCmluZGV4 IGJmMGI1ZmRlNzYuLjVkN2M4ZGNhOTkgMTAwNjQ0Ci0tLSBhL3NyYy9mcmluZ2UuYworKysg Yi9zcmMvZnJpbmdlLmMKQEAgLTIwOSw2ICsyMDksMjAgQEAKIHN0YXRpYyB1bnNpZ25lZCBz aG9ydCByaWdodF9jdXJseV9hcnJvd19iaXRzW10gPSB7CiAgICAweDNjLCAweDNlLCAweDAz LCAweDI3LCAweDNmLCAweDNlLCAweDNjLCAweDNlfTsKIAorLyogTGFyZ2UgY2lyY2xlIGJp dG1hcC4gICovCisvKgorICAuLi4uLi4uLgorICAuLnh4eHguLgorICAueHh4eHh4LgorICB4 eHh4eHh4eAorICB4eHh4eHh4eAorICAueHh4eHh4LgorICAuLnh4eHguLgorICAuLi4uLi4u LgorKi8KK3N0YXRpYyB1bnNpZ25lZCBzaG9ydCBsYXJnZV9jaXJjbGVfYml0c1tdID0gewor ICAweDNjLCAweDdlLCAweGZmLCAweGZmLCAweGZmLCAweGZmLCAweDdlLCAweDNjfTsKKwog LyogUmV2ZXJzZSBPdmVybGF5IGFycm93IGJpdG1hcC4gIEEgdHJpYW5ndWxhciBhcnJvdy4g ICovCiAvKgogICAuLi4uLi54eApAQCAtNDU0LDYgKzQ2OCw3IEBAICNkZWZpbmUgRlJCSVRT KGJpdHMpICBiaXRzLCBTVEFOREFSRF9CSVRNQVBfSEVJR0hUIChiaXRzKQogICB7IEZSQklU UyAoZG93bl9hcnJvd19iaXRzKSwgICAgICAgICA4LCAwLCBBTElHTl9CSVRNQVBfQk9UVE9N LCAwIH0sCiAgIHsgRlJCSVRTIChsZWZ0X2N1cmx5X2Fycm93X2JpdHMpLCAgIDgsIDAsIEFM SUdOX0JJVE1BUF9DRU5URVIsIDAgfSwKICAgeyBGUkJJVFMgKHJpZ2h0X2N1cmx5X2Fycm93 X2JpdHMpLCAgOCwgMCwgQUxJR05fQklUTUFQX0NFTlRFUiwgMCB9LAorICB7IEZSQklUUyAo bGFyZ2VfY2lyY2xlX2JpdHMpLCAgICAgICA4LCAwLCBBTElHTl9CSVRNQVBfQ0VOVEVSLCAw IH0sCiAgIHsgRlJCSVRTIChsZWZ0X3RyaWFuZ2xlX2JpdHMpLCAgICAgIDgsIDAsIEFMSUdO X0JJVE1BUF9DRU5URVIsIDAgfSwKICAgeyBGUkJJVFMgKHJpZ2h0X3RyaWFuZ2xlX2JpdHMp LCAgICAgOCwgMCwgQUxJR05fQklUTUFQX0NFTlRFUiwgMCB9LAogICB7IEZSQklUUyAodG9w X2xlZnRfYW5nbGVfYml0cyksICAgICA4LCAwLCBBTElHTl9CSVRNQVBfVE9QLCAgICAwIH0s Ci0tIAoyLjI1LjEKCg== --------------F2BAFEE8C72D9A96344EA0EB-- From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 56896@debbugs.gnu.org, Eli Zaretskii Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16605458951792 (code B ref 56896); Mon, 15 Aug 2022 06:45:02 +0000 Received: (at 56896) by debbugs.gnu.org; 15 Aug 2022 06:44:55 +0000 Received: from localhost ([127.0.0.1]:40443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNTqJ-0000Sq-CO for submit@debbugs.gnu.org; Mon, 15 Aug 2022 02:44:55 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNTqH-0000SY-UG for 56896@debbugs.gnu.org; Mon, 15 Aug 2022 02:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VC5+xvQtMN0HQaNo8R6YKSVksVSjdfMPgCz6cu5mmq0=; b=mMGP9TPZGV40VnzwgyTesMuLJC 1dB2lZo/+oAxf/P33WdTFziudvIR1OuFwVzIf/EFkemyksHwRsd1dSZyA/KJo1IkySCmqptfSfucu DcArpitbUOrXsuzgoAq2mcsspbMomj47ys3RwXXIsI4Pt+66bHJFdw0+KX/oHPvgv9vU=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNTq9-0004bn-63; Mon, 15 Aug 2022 08:44:47 +0200 From: Lars Ingebrigtsen In-Reply-To: <01ebb4e2-4f0d-98c1-2e34-e7f5ea3fdc39@gmail.com> (Jim Porter's message of "Sat, 13 Aug 2022 14:59:49 -0700") References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> <83edxw4hzn.fsf@gnu.org> <7566691d-090e-f380-b395-4d2aa2fdebdb@gmail.com> <01ebb4e2-4f0d-98c1-2e34-e7f5ea3fdc39@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEW6ub0TExZaWl// ///b7+IJAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YIDwYdNL6P7bMAAAHBSURBVCjPLZFBi9swFIQn Bpe174Ylp7CgkuRXJLklJ2M8QvZJNZsl9q9wDIF1T70obHNyCgrJ/so+byuQ4NPTG0kzAO3VMPPJ MY8ArqKUafgW6VBgo4yASRghqFfuPwQIm1VyYBZq5eYIh059CHDiY7BU/Bo/SDB3ZCqzHKGSXStV 7QjfyypSZFijD7V3r0lNbrd4d/q7w6QomNWQloztRM7mCbajaNfTUSuIjuK7YkGu4Zo86SvvS+7/ gAfro1I9zPnzLpfWPLI+8uZLyGUi11TcsgB1Un742IY1azBlc5sFbaDdA6cqX97aEdQOfW+WEAD7 DreFmeFFKqweMIV5xqxrJ/IPeaiZtnPVXse3nQpzGWI3XLXvoXZWD9/us/j1kcHtMt6jdojPysAV jcDh12JPDceYh8A8L8QFOH0RmE1/j75FWckmsNNSJ1v87ATQCoQbqEp+A1ykUiHRlRNw9djj2PIw wpcaNzQCxX5MoVwlVpL9PLscizerLF7cp+aAcJ/GA2L3oBiypp2n/8AjpX3KReAxpqCdXSpxoJdQ 4b19CiXRiHWN/TqdT6R5wtMezOw8kEAjiUu8Hubifhdp8i8Ngbq/aYpF5AAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMi0wOC0xNVQwNjoyOTo1MSswMDowMDyZ7KQAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjItMDgtMTVUMDY6Mjk6NTErMDA6MDBNxFQYAAAAAElFTkSuQmCC X-Now-Playing: Prince's _Dirty Mind_: "Head" Date: Mon, 15 Aug 2022 08:44:44 +0200 Message-ID: <87pmh2c8f7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > Here's a better version of this patch. Rather than a proxy object, it > just sets the 'fringe' property on the defcustom, which the rest of > the bookmark code can then use like a "regular" fringe b [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > Here's a better version of this patch. Rather than a proxy object, it > just sets the 'fringe' property on the defcustom, which the rest of > the bookmark code can then use like a "regular" fringe bitmap > (essentially, it's just an alias to a real fringe bitmap). I also > added a 'fringe-custom-set-bitmap' function that anyone can use as a > :set function. Makes sense to me; please go ahead and push. > This should be general enough that it could be used wherever anyone > wants to allow users to use Customize to change the fringe bitmap that > gets used for a particular purpose. Potentially, it could even be used > for *every* use of a fringe bitmap. That would let users pick icons > they like for a particular purpose based on their general description > (e.g. 'right-triangle'), but they could also independently adjust the > bitmaps (e.g. redefining all the fringe bitmaps to be larger for high > DPI monitors). For the latter case, maybe users could download a > package from ELPA to do that. I wonder whether we could usefully fold this stuff into the new icons.el library. I'm not sure how, though, because the fringe stuff is so low level. And icons.el is all about graceful degradation, and there's not much to degrade to in a fringe context. From unknown Sun Jun 22 00:48:41 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jim Porter Subject: bug#56896: closed (Re: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark) Message-ID: References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> X-Gnu-PR-Message: they-closed 56896 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 56896@debbugs.gnu.org Date: Tue, 16 Aug 2022 04:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1660623482-3807-1" This is a multi-part message in MIME format... ------------=_1660623482-3807-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #56896: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 56896@debbugs.gnu.org. --=20 56896: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D56896 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1660623482-3807-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 56896-done) by debbugs.gnu.org; 16 Aug 2022 04:17:27 +0000 Received: from localhost ([127.0.0.1]:44496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNo18-0000yY-Of for submit@debbugs.gnu.org; Tue, 16 Aug 2022 00:17:26 -0400 Received: from mail-pl1-f172.google.com ([209.85.214.172]:34379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNo14-0000yH-Pe for 56896-done@debbugs.gnu.org; Tue, 16 Aug 2022 00:17:23 -0400 Received: by mail-pl1-f172.google.com with SMTP id jl18so331827plb.1 for <56896-done@debbugs.gnu.org>; Mon, 15 Aug 2022 21:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc; bh=oaIJlkDqRH1AWghH94tcyzoHwwgXbIL/GsfmQJOjs6c=; b=KprWZUM3wletrJUkhveq3rlz5RzMxSE27RQyx2oSvWAf+LDSC4gVwjwDN7gnAi2rsb 1/vYQ0EuzN9J/K9//qB/GaI/34GIcdl6tVMcmfbMJhCVXVM5ph20WfugppTXQS+3SSIA b1KeoHMMtqwKTy7hBf8KIAYxfroMGTeXlk64KezHEuR1ONlk7BBgpnqiM+6k4nWFH8eZ 1Kg5uoMcaoCHbWkSGMeL1soECuCwtBFmJeWAm9FeQwVVD6ZPW6iZCXN/m6YhkguunrT2 BUZvWHXULNKaJoKIi3iaeGSaKHietlp365R7XpFZa9c8buNIOvSemuusBZRXEgXM5BU3 FjVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc; bh=oaIJlkDqRH1AWghH94tcyzoHwwgXbIL/GsfmQJOjs6c=; b=3+t7Gv17lxIL+bR2lQitOrZm6zE/41j8vYYbcUTp0jhqhzMxEpDRAblg9lbu2/QufJ DtkEAz/fTYRXkmI3FkfgTh8bJVqgTa/Xm0NzUwc+QcclKYnfkvhcVHnoVWrXXiqehKEl nv9qFIV+qVpJZHGGGiylqaEhzaFmM+UUcoG8ARE6bWuJzipabyMJ5nphLv2ixognNJuM hYTXD0M5/h4I5wn0PIio3Al3WAvYp2YUfDofRiFaCkiHZndq2BPkzeCqzyuDsqF0d4bk cUC0eCNYiVnpDSKKW+b71z82nyeZaxh7dUQ6c3BGYALL4wv4w8pz7gGJSdUsArWB93yV 5s7g== X-Gm-Message-State: ACgBeo23sJZxCbasX6XL1o8c6GqduGWpRVvnuN2H8OrQcEtmsMtTsset O41LeiqncSFHRjdTMxt22As= X-Google-Smtp-Source: AA6agR423v+AtZSCYnn52QevLlY7CFtlGIm2K2m+LFIXipJ+zFxjzBhnhkd16xbK6HObmDy9x28hKw== X-Received: by 2002:a17:90b:3805:b0:1f4:ebfe:558b with SMTP id mq5-20020a17090b380500b001f4ebfe558bmr31528045pjb.48.1660623436871; Mon, 15 Aug 2022 21:17:16 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id y12-20020a170903010c00b0016db51ca7dfsm7828234plc.15.2022.08.15.21.17.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 21:17:15 -0700 (PDT) Subject: Re: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark To: Lars Ingebrigtsen References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> <83edxw4hzn.fsf@gnu.org> <7566691d-090e-f380-b395-4d2aa2fdebdb@gmail.com> <01ebb4e2-4f0d-98c1-2e34-e7f5ea3fdc39@gmail.com> <87pmh2c8f7.fsf@gnus.org> From: Jim Porter Message-ID: Date: Mon, 15 Aug 2022 21:17:15 -0700 MIME-Version: 1.0 In-Reply-To: <87pmh2c8f7.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56896-done Cc: Eli Zaretskii , 56896-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 8/14/2022 11:44 PM, Lars Ingebrigtsen wrote: > Makes sense to me; please go ahead and push. Thanks. Pushed as b87400c78b047d242ae188c46c621e0e8a8e69b2. ------------=_1660623482-3807-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Aug 2022 19:13:55 +0000 Received: from localhost ([127.0.0.1]:45094 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIxL0-00079w-Sb for submit@debbugs.gnu.org; Tue, 02 Aug 2022 15:13:55 -0400 Received: from lists.gnu.org ([209.51.188.17]:53950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIxKy-00079i-6j for submit@debbugs.gnu.org; Tue, 02 Aug 2022 15:13:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIxKw-0000SN-9w for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 15:13:52 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:43980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIxKu-0002pJ-NN for bug-gnu-emacs@gnu.org; Tue, 02 Aug 2022 15:13:50 -0400 Received: by mail-pl1-x632.google.com with SMTP id y15so14311200plp.10 for ; Tue, 02 Aug 2022 12:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-language:mime-version:date:message-id:to:subject:from:from :to:cc; bh=tUmhofx/kqQ6o3VY632jD2v4g3A5uGIjXXOl2awxd5Q=; b=qyzX9/gvypzklR/g1iMEQUAFFmdx1mKz6YOCtlhNr5TAT2ulWIcqF5So8yJBPvY3Vt Tq3+Yldae+ZtNxiABaZwFAe4FpOgcUpqtbWzE9rwqc+hNYZifuwYiUrQF5p0Dfr3oIg3 WAGQt6AcleGflZx7knq50DJnLcN2VPIp4tQL/+lsCNgMb9id4Z9AKoSgI+M3t/g9NxRx zIXc4fAilMZcS7B4IgCkUyzZjjKL0lGJ5xVkgoUgEaoQfBQPXGdrlcNLxnjX8uxkzVZ+ 9r+49gwkceGz+nLpyAvBCx+fS7CxgBgQWPn0rnEe97sjPJM8p/6SHmuckIrUu2tZaptj haTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-language:mime-version:date:message-id:to:subject:from :x-gm-message-state:from:to:cc; bh=tUmhofx/kqQ6o3VY632jD2v4g3A5uGIjXXOl2awxd5Q=; b=psy7OaZYYb2Ys/6q8HBFlHIIqFaPdGdlMcCWkXPyuXQMmdo4TPpfgh8beUIog4dqtF wBPsA8EZx1kMhAeWQTpDhWBL03OV0ZwB9BNeq47EcSoi1ZDquKlzMeqK8QeK4+XLOaAR oMvohWJoHhzP0YsJ57lBWowmTFwcZYpiglowq33VPt8MFRQW/GpLzgki+rI2kMPFvcjK ym/wa3sbNzW+zkrzAn4/nyRDGZkPyeK7g1bZEuxRrvtWQw0gv8CD3q32YT8RSuZtBU/r kLgqonCXPWGm0le774WUrvFTxJModc2uyhk16egjf10TnNwMsQThEPxSWQJYy10wrsyA hjiA== X-Gm-Message-State: ACgBeo2a3YF2ahhtF4XH6jGnQ22fbDVZyNdWiGQX2g0DzlUIRecwrDMq pgdSovDbSx8+lkbE+rUB9iFplTbEniY= X-Google-Smtp-Source: AA6agR5I5rGtHIvhonz5zoPCLWLi3hquKe2g6UUfFPiNsuUVLHAFtYepTixWu6LgPe9eOQnuAZDf5A== X-Received: by 2002:a17:90a:bb14:b0:1f3:5f1:6de9 with SMTP id u20-20020a17090abb1400b001f305f16de9mr987940pjr.148.1659467626679; Tue, 02 Aug 2022 12:13:46 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id b12-20020a17090a550c00b001f2fbf2c42esm11306506pji.26.2022.08.02.12.13.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 12:13:45 -0700 (PDT) X-Mozilla-News-Host: news://news.gmane.org:119 From: Jim Porter Subject: 29.0.50; [PATCH] Make the bookmark fringe icon look like a bookmark To: bug-gnu-emacs@gnu.org Message-ID: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> Date: Tue, 2 Aug 2022 12:13:44 -0700 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------09FE3C6CAA06D0B79356ECA3" Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------09FE3C6CAA06D0B79356ECA3 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Currently, the bookmark fringe icon is a circle. However, Emacs already uses a circle to represent breakpoints (as do a lot of other IDEs). These are usually a different color, but I think it would be nice if the bookmark fringe icon were a different shape too. This would help colorblind users, since (depending on their Emacs theme and what kind of colorblindness they have), it might be hard to distinguish the bookmark icon from the breakpoint icon. It would help make the purpose of the indicator more obvious to users who don't directly use bookmarks. Some packages (including the built-in org-capture package) set bookmarks automatically, and a user might not realize that the dot indicates a bookmark, as opposed to some other thing. Attached are some screenshots showing before/after, plus a patch for this. I converted the string definition of the bitmap to a vector of (binary) numbers, since then a reader can see the shape of the icon if they look carefully. --------------09FE3C6CAA06D0B79356ECA3 Content-Type: text/plain; charset=UTF-8; name="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Make-the-bookmark-fringe-icon-look-like-a-bookmark.patc"; filename*1="h" RnJvbSAwNjcxYjQ0ODA4YTA3MjM3YTFjMTgzZTgwYzdiYTcxMzI1NWM5ZWU4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFR1ZSwgMiBBdWcgMjAyMiAxMTo0MDo0MyAtMDcwMApTdWJqZWN0OiBbUEFU Q0hdIE1ha2UgdGhlIGJvb2ttYXJrIGZyaW5nZSBpY29uIGxvb2sgbGlrZSBhIGJvb2ttYXJr CgoqIGxpc3AvYm9va21hcmsuZWwgKGJvb2ttYXJrLWZyaW5nZS1tYXJrKTogQ2hhbmdlIHRo ZSBiaXRtYXAgdG8gbG9vawpsaWtlIGEgYm9va21hcmsuCi0tLQogbGlzcC9ib29rbWFyay5l bCB8IDkgKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9ib29rbWFyay5lbCBiL2xpc3AvYm9va21h cmsuZWwKaW5kZXggMzBhMDNlMDQzMS4uNTNkYTUwMTMxNiAxMDA2NDQKLS0tIGEvbGlzcC9i b29rbWFyay5lbAorKysgYi9saXNwL2Jvb2ttYXJrLmVsCkBAIC00ODMsNyArNDgzLDE0IEBA IGJvb2ttYXJrLWhpc3RvcnkKICAgIlRoZSBoaXN0b3J5IGxpc3QgZm9yIGJvb2ttYXJrIGZ1 bmN0aW9ucy4iKQogCiAoZGVmaW5lLWZyaW5nZS1iaXRtYXAgJ2Jvb2ttYXJrLWZyaW5nZS1t YXJrCi0gICJceDNjXHg3ZVx4ZmZceGZmXHhmZlx4ZmZceDdlXHgzYyIpCisgIFsjYjAxMTEx MTEwCisgICAjYjAxMTExMTEwCisgICAjYjAxMTExMTEwCisgICAjYjAxMTExMTEwCisgICAj YjAxMTExMTEwCisgICAjYjAxMTExMTEwCisgICAjYjAxMTAwMTEwCisgICAjYjAxMDAwMDEw XSkKIAogKGRlZnVuIGJvb2ttYXJrLS1zZXQtZnJpbmdlLW1hcmsgKCkKICAgIkFwcGx5IGEg Y29sb3JpemVkIG92ZXJsYXkgdG8gdGhlIGJvb2ttYXJrZWQgbG9jYXRpb24uCi0tIAoyLjI1 LjEKCg== --------------09FE3C6CAA06D0B79356ECA3 Content-Type: image/png; name="before.png" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="before.png" iVBORw0KGgoAAAANSUhEUgAAAToAAAAyCAYAAADMZheFAAAABmJLR0QAVABUAFQzY8H1AAAA CXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH5ggCEic362qxAQAACtFJREFUeNrtnXlYVWUe xz93AQRkkU1AUDQgTCtKE9NRQ8qWqTSdQs1cSBwflzFMw5zxeVwatZkytZp0VLRpeVxSc3Im MdxyzCYeGxcwxkBMZVFZ4rLIhcu988eF7kXhcshjIvP7PM95Hj3n8Lvv+b6/9/su95xzNQaD wYIDPDw8EARBuJ3RigSCIIjRCYIgiNEJgiCI0QmCIIjRCYIgiNEJgiCI0QmCIIjRCYIgRicI giBGB+YiLm1ew+nUbOpEN0EQ2p/RVVOaMpsjHxzkh6UzSd9XhO25sRouzoth69w0zKKnIAi3 p9GZuZq2hCM7g+mz7kMeXvUkhuVz+C6rWtQTBKF9GF1d1ka+WmUg6p3FdAvW4xQ9jSGLenL+ 1aVcLLKIgoIgtHn0LZ2gi3qRuM/s92hwGZDMYztFPEEQ2s3UVRAEQYxOEARBjE4QBOFWolct Ul0tdUaj7bYTjRatkxMajYgsCEI7MTpT6hy2pdrt0AVzZ8rn9OmrF5UFQbilaOQ3IwRBaO/I Gp0gCGJ0giAIYnSCIAhtHI3FYpHnuARBkBGdIAiCGJ0gCIIYXRumBmb1grBQcHWF9ZdbeVxF js6FoESoaUv6mGH1EHhkLbT3NY42qb+gstEt1DTemiBnBUzd08pPsEDKE6DRNN6iXgWTmn71 BXQJhyO1rfxDZ1iVCWe/hCbvbW7puIrl6z4Clo5V83EV5Zz5BEbcB16u4BUMj/4eLv+frd7e FP3N8Je46/NfHwlf194GotTBp/Nh4J31uREKzy6BPLvXjFecgMmDwMcdPINhxEIoaMVbeEv2 Q/xQ6OoFWg/YabxZRteUsTXsM8OWJFi0CyotQC0cXQOT3lTY82lg4i64WgXvxsEdL0H5VTi5 5NY06LZM4ECYFPvLD7Mv7YBHEqHrq5BTAjmHYGwY1FpEf7WInGPN+6v1W2UGxDjdBqKY4UIl TFsLJ8/DsQ1wZSVMWIv1jeI1sDgejvWDzFIoOABu70Pi+yh+47jWHWInw8dLwfMmPTKqbW70 9pPZaSF+OQy5CHPWwN8Xw14/WJkEzko/xAk6dAC9DjR6cOkAzvrGU6MB02Dy49AnAroPgVS7 KaL5EiwaAV18oJMvRAyErRfqO5wseDIK7poIl89DfE8ID4e45bYRY8YGGHo3+HqCVwDEToWT FeqJ6Ci+kvIZdkCvcAjpBJ2bmDqZC2HxSAj2Bk9/eGgaZFYp16+lHjtlGbgmwp+fAz9X8IuA CYnQxa7Fm3Jh5mBrr971mvgO9VVQPuP3MH0QeHtA90Ewb0zjKaSlDNZOgQh/6OgNfcbA0VJl +aEEh/rfqL4N/b3e2gYaNhdn0ADGT6FTJPw6GnwjYX4yhHeC8DHwg1l5/ubshGfuBx9P8OsK z7wBFWro4wQzV8HzD0E3fwgfBlMGw7ffQC1QlwMHLsD4GRDkDO53wuwxcGiL8hmBdwxMHQsP dLt5nbyiuMWZkHoUPIMg0B8y98M359UtyIn/wIztcCwL5rrAvPf46Ud4vnkTVhvhYB6UXob9 b0Gkq/WYLgp2Z8HpTRDQFbZ8B9nZsG+ebcRY4wxT1kNuMRSdgr7pMO5P6k2dHcVXUj7PkZCZ DdsmN1EhZvjgt7BOB/vzoDgDYtIh/rXGDdKRfg5XFn6EI5nQfwi4ODjv37sh7m9QnAcvVEGy XXwl+jZbvjp4eyIc6A0ZxXBiNaSn2pXdDB8nwKIL8H4GGPIhSQvPzYJSS8v5oQSH+t+gvko7 m5cPw5JQSMmH9GyI3ge785XpW3EAHk+AsIVw/kcoPA7juoNZJX0aUQXpp6FPDDjVz9iaojYb ck20GVo2Oou1koevgNdHQL/fwcYkyDmm7qLtvb+Be9wAHTzYH3KzbBWp00FNkTUZr2ogtB9E +ymPff8LMDoGPJ3AqTNMHAm5J6FKpbLf1PgG2HkA4mdDlLs1/pypcG4XnDIp089h9RqgzALe no7P6z0Ong4DvQ+MHAbn7OIruf7mymc+BztPQMLLEOIMnvfB9Mds7cecB+v3wJTlMKAzaN1g 9Gzw+hwOV6uTHzean0rIXgWBfuBXv3WZAJUN+R0K4e5wRw8IjQJPL+jhBwWXlembtgEqRsEf n4aOWmsdjRplmwaqpo8F9syFLSGwIsFqHroeEBsKH74L+UYoz4KVn4DlKlS1oaWPlpfJNDD0 Res/C3vAPf7gHgFTI9QtiHtHW3LrdFBnss3x+ybD6hpYEQ8T8iHqCVj5LjzYSVnsi3th/jL4 KteanKZyMMXUr0GpsCZwM+ObS6HYDIMC7EYggdChxLq/oatypJ/D6vW0Nogyg+PzvDrZekUn 58bxHV5/C/VrLoYiIKiz7dyAQNCW119/ARTUwrpnYbPWNsorc4byKsD1xvPjRvNTCWEJkGY3 ite4ghv1gwUd6ACdHvT1J+h1YDIp07egEIJimx+Rq6KPBQ7+HhK/hc3/hLsbPswZFmyGkhnQ 2xdcwiFpNHy+DTzb0D0dWhY6sN1rjgWOgGl9fvlCarytX358eRoKT0JMBsxef83UQQMay/W3 QFiuwIzRoJsKJ87CuXOw5yVrYjU6tz7ZTM11080cVxy/mfK1WEHe4Ku19e4AhkKo9rHuV0Pb B6Pg68M/b4Su+Pqbuz5f8AMK7a7vyiWbiWgDobMLLDgEWVn12xkoyIPnfVuRH7d6ROEBISG2 rYtvy32gRYm+GggKhIJcMN5I+2nJ5ObDhIPwwW4YfI1BekTD+n9BSQUUHIfB1aC9FyL1bcno mjC0Zvf93FFJLVRXg6kOLCYwVkNNK8b9Z/bCgTNQYwEnd+igAzf3xomi9QOfYjiVf00dVYOh FqKiwV1rHUFs2Hr9tEPrDxGecOhw0wnQ3HHF8ZspX4t4wfAhsHUF/LcSai/DG2ug61PQW41E 0sGLyVC+FpK3Q3E1lObCRymQr2DIovT6m03AMHjmXtj4lnXkVnEK1ti911AbAglx8NYrcLzY 2ujKcmHbdiixKM+PW43FZG0DP21GZSNCJfrGTQL37fCHz6DSDHVlsOtTMKihjxnSXoFx+2Dd J9Df3Vp+o92tMSUZcOwcGMrg2EcwbT2Mnw5e9nFMsDQWek0BQxOfYTTWx7RAbbX1/2bVja7B 2Ow31WoYNg0HVzeYvg9yVoKHK9yzQHljqPwO5j4G/l7g3xPS+8PqSY0XGPV3w4KxsPwB6BIC v3rNGl8bAsuXwJan4IFB8PBE8OhXv5BqjyvMXwHZs8CjI/RKtn6r1NJxpfGbKx8mWBYLYWEw 6q9wZTNEhkGPvnC41lpD49dCQg08FAw+PeHo/bBlgeMvD1pDUDx88R5kL4bu3tBtAGz6HvQK WoJifR0Y7cxNMPg43OUP0TOh7zDQaWwZOn4jJLlB/F3g4QVRj8OOs7aGqiQ/mqUl/VXizBvW vHdt2Lxhh1EdfT3i4B/rIHsBhHhBQG9I+R60GhX0KYe334G8dHi0i638XsOh4ddOy49DwkAI CICnXodHU2DZoOt9oOgHOFt4vYHV7IUQN/AaCaUVEO8Nbt0gTcUvAeShfqHNkZoIs3wg43W5 11JQe0QnCLcIwwlIO2NdEjDmQspeiBsmJieI0QntiNrzMH8YBHaGbrGgT4LXhoougkxdBUEQ FKMvLy93eIL8OI4gCDJ1FQRBEKMTBEEQoxMEQRCjEwRBEKMTBEEQoxMEQYxOEARBjE4QBOH2 5X+v0IQIHBR8XgAAAABJRU5ErkJggg== --------------09FE3C6CAA06D0B79356ECA3 Content-Type: image/png; name="after.png" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="after.png" iVBORw0KGgoAAAANSUhEUgAAAToAAAAyCAYAAADMZheFAAAABmJLR0QAVABUAFQzY8H1AAAA CXBIWXMAAAsTAAALEwEAmpwYAAAAB3RJTUUH5ggCEicujwEZwQAACslJREFUeNrt3XtYVHUa wPHvXEABuchNBFQ0IEwrShPTVUPKLltpuoWaeSFxfbysaRpm6/N4adV2y9Rq01XRtsvjJTU3 dxPDW67ZxmPrBYw1EFMRVC4xIDLMMLN/HGgGheG4HgPd9/M853l05vCb33nPe97z+505M6Mz mUx2XPD29kYIIW5legmBEEIKnRBCSKETQggpdEIIIYVOCCGk0AkhhBQ6IYSQQieEkEInhBBS 6MBWxIUNKzmRlkONxE0IcfsVuipKU2dw8MN9/LhoKhm7i3B8bqyac7Pj2DQrHZvEUwhxaxY6 G1fSF3JwWyg9Vn/Ew8ufxLRkJt9nV0n0hBC3R6GryV7H18tNxLy7gE6hRtxiJzFgflfOvLqI c0V2iaAQosUzNrWCIeZFEj53fkRHqz4pPLZNgieEuG2mrkIIIYVOCCGk0AkhRHMyatZSjYUa s9lx24lOj97NDZ1OgiyEuE0KnTVtJpvTnB4whHJn6hf06GmUKAshmpVOfjNCCHG7k2t0Qggp dEIIIYVOCCFaOJ3dbpfPcQkhZEQnhBBS6IQQQgpdC1YN07pBRAfw8IA1F6/zeQ0dmgXtk6G6 JcXHBisGwCOr4Ha/xtEi4y80LHTzdA0vV8ldChN3Xucr2CH1CdDp6i8xr4JVy3r1JYRFwkHL df6hOyzPglNfQYP3Njf1vIb96zwEFo3U8uMq6p38FIbcB74e4BsKj74GF//Prt7elPjb4M8J 1+a/MRq+sdwCQamBz+ZA3ztrc6MDPLsQ8p2+ZrziKIzvB/5e4BMKQ+ZBwXV8C2/JHkgcCB19 Qe8N28zNMaKzwcbpMH87XLYDFji0Esa9pfLMp4Ox2+FKJbyXAHe8BOVX4NjC5jmgW7KQvjAu /pcfZl/YCo8kQ8dXIbcEcvfDyAiw2CX+WomeqeT9ldrlcibEud0CQbHB2cswaRUcOwOH18Kl ZTBmFco3ilfDgkQ43AuySqFgL3h+AMkfoPobx/VeED8ePlkEPjfpI6N6NWskLoEB52DmSvjb AtgVCMumg7vaF3GD1q3BaACdEVq1Bndj/alRn0kw/nHoEQWdB0Ca0xTRdgHmD4Ewf2gbAFF9 YdPZ2hNONjwZA3eNhYtnILErREZCwhLHiDFzLQy8GwJ8wDcY4ifCsQrtguiqfTX9M22FbpEQ 3hbaNTB1shXCgqEQ6gc+QfDQJMiqVB+/ps7YqYvBIxn+9BwEekBgFIxJhjCn7LDmwdT+ylm9 41Xtu4yviv6Zf4DJ/cDPGzr3g9kj6k8h7WWwagJEBUEbP+gxAg6VqssPNVzG/0bjW3e+NyrH QN3Syh10gPkzaBsNv46FgGiYkwKRbSFyBPxoU5+/udvgmfvB3wcCO8Izb0KFFvFxg6nL4fmH oFMQRA6CCf3hu2/BAtTkwt6zMHoKtHcHrzthxgjYv1H9jMAvDiaOhAc63byTvKp2i7Mg7RD4 tIeQIMjaA9+e0bYjR/8NU7bA4WyY1Qpmv8/PP8Lz7Vuwwgz78qH0Iux5G6I9lOcMMbAjG06s h+COsPF7yMmB3bMdI8Zqd5iwBvKKoeg49MyAUX/Ubursqn01/fMZClk5sHl8AzvEBh/+FlYb YE8+FGdCXAYkvl7/gHQVP5dXFn6Cg1nQewC0crHev3ZAwl+hOB9eqIQUp/bVxLfR/tXAO2Nh b3fILIajKyAjzanvNvgkCeafhQ8ywXQepuvhuWlQam86P9RwGf8bjK/ak83LB2BhB0g9Dxk5 ELsbdpxXF9+KvfB4EkTMgzM/QeERGNUZbBrFp55KyDgBPeLArXbG1hBLDuRZaTGaLnR2ZScP XgpvDIFev4N10yH3sLYXbe/9DdzjCRjgwd6Ql+3YkQYDVBcpyXhFBx16QWyg+rbvfwGGx4GP G7i1g7FDIe8YVGrU95vavgm27YXEGRDjpbQ/cyKc3g7Hreri53L3mqDMDn4+rtfrPgqejgCj PwwdBKed2lez/Y31z3Yath2FpJch3B187oPJjzmOH1s+rNkJE5ZAn3ag94ThM8D3CzhQpU1+ 3Gh+qpGzHEICIbB2CRsDl+vyuwNEesEdXaBDDPj4QpdAKLioLr7pa6FiGPzhaWijV/bRsGGO aaBm8bHDzlmwMRyWJinFw9AF4jvAR+/BeTOUZ8OyT8F+BSpb0KWPpi+T6WDgi8o/C7vAPUHg FQUTo7TtiFcbR3IbDFBjdczxe6bAimpYmghjzkPME7DsPXiwrbq2z+2COYvh6zwlOa3lYI2r vQalwTWBm9m+rRSKbdAv2GkEEgKtS5TH605VruLncvf6KAdEmcn1er5tHWdFN/f67bvc/ib2 r60YioD27RzrBoeAvrx2+wugwAKrn4UNescor8wdyisBjxvPjxvNTzUikiDdaRSv8wBPagcL BjAABiMYa1cwGsBqVRffgkJoH9/4iFyT+Nhh32uQ/B1s+AfcXfdi7jB3A5RMge4B0CoSpg+H LzaDTwu6p6N+V+bZlaWxi7VDYFKPX76TOj/lzY+vTkDhMYjLhBlrrpo66EBnv/YWCPslmDIc DBPh6Ck4fRp2vqQkVr11a5PN2thpupHnVbffSP+a3EF+EKB3nN0BTIVQ5a88rkVsH4yBbw78 byN01dvf2PYFQCBQ6LR9ly44iog+BNq1grn7ITu7djkJBfnwfMB15Edzjyi8ITzcsYQFNH0O tKuJrw7ah0BBHphv5PhpqsjNgTH74MMd0P+qAukdC2v+CSUVUHAE+leB/l6INrbEQudc4OZp O+a0WaCqCqw1YLeCuQqqr2Pcf3IX7D0J1XZw84LWBvD0qp8o+kDwL4bj56/aR1VgskBMLHjp lRHE2k3XTjv0QRDlA/sPNJwAjT2vuv1G+tckXxg8ADYthf9cBstFeHMldHwKumuRSAZ4MQXK V0HKFiiugtI8+DgVzqsYsqjd/kYTMAKeuRfWva2M3CqOw0qn7zXUh0NSArz9ChwpVg66sjzY vAVK7Orzo7nZrcox8PNiVjciVBPfhHHgtQV+/zlctkFNGWz/DExaxMcG6a/AqN2w+lPo7aX0 3+x0a0xJJhw+DaYyOPwxTFoDoyeDr3M7VlgUD90mgKmB1zCba9u0g6VK+b9N80LXUGHTqtjZ Yf1g8PCEybshdxl4e8A9c9UfDJe/h1mPQZAvBHWFjN6wYlz94ajxbpg7EpY8AGHh8KvXlfb1 4bBkIWx8Ch7oBw+PBe9etRdSnXnAnKWQMw2820C3FOVdpaaeV9t+Y/3DCovjISIChv0FLm2A 6Ajo0hMOWJQ9NHoVJFXDQ6Hg3xUO3Q8b57p+8+B6tE+EL9+HnAXQ2Q869YH1P4BRxZGgOr4u Cu3U9dD/CNwVBLFToecgMOgcGTp6HUz3hMS7wNsXYh6HraccB6qa/GhUU/HXyMk3lbz3qFv8 YKtZm/h6J8DfV0POXAj3heDukPoD6HUaxKcc3nkX8jPg0TBH/30HQ92vnZYfgaS+EBwMT70B j6bC4n7X1oGiH+FU4bUFrHoXhHuC71AorYBEP/DsBOkavgkgH+oXLU5aMkzzh8w35F5LcTOu 0QnRDExHIf2kcknAnAepuyBhkBQ5IYVO3EYsZ2DOIAhpB53iwTgdXh8ocREydRVCCNWM5eXl LleQH8cRQsjUVQghpNAJIYQUOiGEkEInhBBS6IQQQgqdEEIKnRBCSKETQohb138BKjGACDzB RmwAAAAASUVORK5CYII= --------------09FE3C6CAA06D0B79356ECA3-- ------------=_1660623482-3807-1-- From unknown Sun Jun 22 00:48:41 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Aug 2022 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Jim Porter , Eli Zaretskii , 56896@debbugs.gnu.org Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.166110060924403 (code B ref 56896); Sun, 21 Aug 2022 16:51:02 +0000 Received: (at 56896) by debbugs.gnu.org; 21 Aug 2022 16:50:09 +0000 Received: from localhost ([127.0.0.1]:36650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPo9I-0006LV-Q9 for submit@debbugs.gnu.org; Sun, 21 Aug 2022 12:50:09 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:56383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oPo9F-0006Kl-Ml for 56896@debbugs.gnu.org; Sun, 21 Aug 2022 12:50:07 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4F61DFF804; Sun, 21 Aug 2022 16:49:57 +0000 (UTC) From: Juri Linkov In-Reply-To: <87pmh2c8f7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 15 Aug 2022 08:44:44 +0200") Organization: LINKOV.NET References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> <83edxw4hzn.fsf@gnu.org> <7566691d-090e-f380-b395-4d2aa2fdebdb@gmail.com> <01ebb4e2-4f0d-98c1-2e34-e7f5ea3fdc39@gmail.com> <87pmh2c8f7.fsf@gnus.org> Date: Sun, 21 Aug 2022 19:23:39 +0300 Message-ID: <865yimm190.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > And icons.el is all about graceful degradation, and there's not > much to degrade to in a fringe context. In a fringe context degradation can be applied when the fringe is disabled.