GNU bug report logs - #56884
[PATCH] Make x265 build on ppc64le

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 56884 in the body.
You can then email your comments to 56884 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marcel van der Boom <marcel <at> van-der-boom.nl>
To: guix-patches <at> gnu.org
Cc: Marcel van der Boom <marcel <at> van-der-boom.nl>
Subject: [PATCH] Make x265 build on ppc64le
Date: Tue,  2 Aug 2022 14:10:14 +0200

* gnu/packages/video.scm: disable ALTIVEC for target-ppc64le
---
 gnu/packages/video.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 04049fd9c8..09f8b7fd23 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1252,6 +1252,9 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"
@@ -1272,6 +1275,9 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"

base-commit: a1f7d98a9c7380be5815fd13b519bbab145757c2
-- 
2.37.1

Message #8 received at 56884 <at> debbugs.gnu.org (full text, mbox):

From: Marcel van der Boom <marcel <at> van-der-boom.nl>
To: 56884 <at> debbugs.gnu.org
Subject: [PATCH] Make x265 build on ppc64le
Date: Tue, 09 Aug 2022 10:02:34 +0200

Anything else needed here?

The patch seems consistent with other packagers I think. Others 
are also confused on what is needed for the altivec code between 
different POWER processors.

Message #11 received at 56884 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Marcel van der Boom <marcel <at> van-der-boom.nl>
Cc: 56884 <at> debbugs.gnu.org
Subject: Re: [bug#56884] [PATCH] Make x265 build on ppc64le
Date: Tue, 09 Aug 2022 23:16:35 -0300

Hello Marcel,

Marcel van der Boom <marcel <at> van-der-boom.nl> writes:

> Anything else needed here?
>
> The patch seems consistent with other packagers I think.

Thank you for the patch! It looks good to me. I only have one
suggestion: IMHO it would be a good idea to have a short comment above
the “(if (target-ppc64le?) …)” line explaining why it's needed, such as
“Enabling AltiVec support causes compilation errors.” or something
similar.

Ideally upstream should be notified about this problem so that they are
aware of it, but looking at the x265 website I can't find any bug
tracker.

> Others are also confused on what is needed for the altivec code
> between different POWER processors.

Sorry, I'm not sure what you mean.

PS: Just for the sake of documenting in the issue tracker why x265 isn't
building on ppc64le — the build fails because of many errors such as:

/tmp/guix-build-x265-3.5.drv-0/x265_3.5/source/common/ppc/pixel_altivec.cpp:4199:42: error: no matches converting function ‘sad16_altivec’ to type ‘x265_12bit::pixelcmp_t’ {aka ‘int (*)(const short unsigned int*, long int, const short unsigned int*, long int)’}
 4199 |         p.pu[LUMA_ ## W ## x ## H].sad = sad16_altivec<W, H>; \
      |                                          ^~~~~~~~~~~~~~~~~~~

-- 
Thanks
Thiago

Message #14 received at 56884 <at> debbugs.gnu.org (full text, mbox):

From: Marcel van der Boom <marcel <at> van-der-boom.nl>
To: 56884 <at> debbugs.gnu.org
Cc: Marcel van der Boom <marcel <at> van-der-boom.nl>,
 Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Subject: [PATCH] Make x265 build on ppc64le
Date: Wed, 10 Aug 2022 09:19:02 +0200

* gnu/packages/video.scm: disable ALTIVEC for target-ppc64le

  Build produces many errors. The altivec code needs adjusting each type of
  POWER processor specifically.
---
 gnu/packages/video.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index 04049fd9c8..bf033c7d84 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -1252,6 +1252,10 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ;; Altivec code produces many build errors
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"
@@ -1272,6 +1276,10 @@ (define-public x265
                  ,@(if (target-aarch64?)
                      '("-DENABLE_ASSEMBLY=OFF")
                      '())
+                 ;; Altivec code produces many build errors
+                 ,@(if (target-ppc64le?)
+                     '("-DENABLE_ALTIVEC=OFF")
+                     '())
                  "-DHIGH_BIT_DEPTH=ON"
                  "-DEXPORT_C_API=OFF"
                  "-DENABLE_CLI=OFF"
-- 
2.37.1

Message #17 received at 56884 <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Marcel van der Boom <marcel <at> van-der-boom.nl>
Cc: 56884 <at> debbugs.gnu.org
Subject: Re: [PATCH] Make x265 build on ppc64le
Date: Wed, 10 Aug 2022 23:15:40 -0300

user guix
usertag 56884 reviewed looks-good
quit

Hello Marcel,

Marcel van der Boom <marcel <at> van-der-boom.nl> writes:

> * gnu/packages/video.scm: disable ALTIVEC for target-ppc64le
>
>   Build produces many errors. The altivec code needs adjusting each type of
>   POWER processor specifically.

Thank you for the new version. This one looks good to me.

I'm not a maintainer though, so we need to wait for one to chime in.

-- 
Thanks
Thiago

Message #22 received at 56884-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
Cc: 56884-done <at> debbugs.gnu.org, Marcel van der Boom <marcel <at> van-der-boom.nl>
Subject: Re: bug#56884: [PATCH] Make x265 build on ppc64le
Date: Thu, 11 Aug 2022 09:45:45 +0200

Hello,

Thanks for reviewing Thiago. I fixed the indentation and edited the
commit message before pushing.

Mathieu

Message #25 received at 56884-done <at> debbugs.gnu.org (full text, mbox):

From: Thiago Jung Bauermann <bauermann <at> kolabnow.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 56884-done <at> debbugs.gnu.org, Marcel van der Boom <marcel <at> van-der-boom.nl>
Subject: Re: bug#56884: [PATCH] Make x265 build on ppc64le
Date: Thu, 11 Aug 2022 11:50:40 -0300

Hello Mathieu,

Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Thanks for reviewing Thiago. I fixed the indentation and edited the
> commit message before pushing.

Thank you!

-- 
Thanks
Thiago

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.