From unknown Tue Jun 24 13:54:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#56880 <56880@debbugs.gnu.org> To: bug#56880 <56880@debbugs.gnu.org> Subject: Status: [PATCH] gnu: system: file-systems: Add shared flag. Reply-To: bug#56880 <56880@debbugs.gnu.org> Date: Tue, 24 Jun 2025 20:54:15 +0000 retitle 56880 [PATCH] gnu: system: file-systems: Add shared flag. reassign 56880 guix-patches submitter 56880 Oleg Pykhalov severity 56880 normal tag 56880 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 02 07:23:41 2022 Received: (at submit) by debbugs.gnu.org; 2 Aug 2022 11:23:41 +0000 Received: from localhost ([127.0.0.1]:42621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIpzw-0004hx-Pb for submit@debbugs.gnu.org; Tue, 02 Aug 2022 07:23:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:40126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIpzt-0004ho-Pp for submit@debbugs.gnu.org; Tue, 02 Aug 2022 07:23:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIpzt-0003p8-9V for guix-patches@gnu.org; Tue, 02 Aug 2022 07:23:37 -0400 Received: from mail-lj1-x229.google.com ([2a00:1450:4864:20::229]:35708) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIpzr-0006ah-HY for guix-patches@gnu.org; Tue, 02 Aug 2022 07:23:37 -0400 Received: by mail-lj1-x229.google.com with SMTP id r14so15299045ljp.2 for ; Tue, 02 Aug 2022 04:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=SYDtzaZCM1fPNQkDpol6W2O7XDXyRxROLUjHYsS5gPk=; b=mJtOGOfHy6hnIRVn7LoN3TiHvGnbrcgQ2aQi6Dd2kruoU2+jQufXzYtjtj7K7YNiFV 8bjfr2x3+F2QXmjFAHPxp+sChjB3vOA07Pz6qJNKiLGEOlU6DPreLXqYxHocCbcq8JIl t2KSAcTQNAdeM9DzqE6XiZdCGw1zqpxoCYW6QBeQEKNmf8Fzo6wmrUqqXW5jf2oJtPch z4LC8w5qk17rOGq4Macv4n9Gg9mJFUwid20YtgvtVPIP0AE/Hb6Cmw/nn68LbdHfRlAR EUdrGeZ6iTThcfoTLEoBNMRF457njlMW4C4dFQe1REZ5okMgj9lWilEtDIFOP/HZ0QOt 6qOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=SYDtzaZCM1fPNQkDpol6W2O7XDXyRxROLUjHYsS5gPk=; b=FaWsPO/vPdDu8WtWq5Y+v1+8nicoBPIKeYGlEEnufgG8Hr/hJLJK8jgR0nnGaqkzyH Spo+RrsCAdbvjQJERFP+33sYEa3rMoZDzyl74QHUoVIIIX28gvON64FXo1U6uije75hy vyvZy4EGIgmpzVMGFZh3rT66VqkTWWl45yc84XdlEuWaPDXD6lQmCslJNhSKflO4x2nt q8jf4ZGieXuCOa2FUAjnffp4YoPLx4OzaI5DbSRIrX4IAKbVIAm+3FeoqFnrFxjo55ji q0Nz3ISD4NVa/ndFSyrDiJ6LAQrhn7+SDo79YbhVtfLS6Hx4rYt6SHIlxyyFJEOxt8J+ OdRQ== X-Gm-Message-State: AJIora/jGSetcOVHqaYYKPXq3+/VxAXM92oseGh6gVm0sHUGagfuj2MN DofemiACEcg8n4/4CnlcpBpWbVa8+Tw= X-Google-Smtp-Source: AGRyM1s14SZOrvjepJVAF75tXRrUgSjEwTBkB4W2XGV7ow9uQl3RVonPU2sKLiZWY81iV+QZh6wRyQ== X-Received: by 2002:a05:651c:b13:b0:25d:8342:e11 with SMTP id b19-20020a05651c0b1300b0025d83420e11mr6053396ljr.266.1659439411436; Tue, 02 Aug 2022 04:23:31 -0700 (PDT) Received: from guixsd.wugi.info ([88.201.161.72]) by smtp.gmail.com with ESMTPSA id j7-20020a2e6e07000000b0025e65b3b24csm54936ljc.4.2022.08.02.04.23.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 04:23:30 -0700 (PDT) From: Oleg Pykhalov To: guix-patches@gnu.org Subject: [PATCH] gnu: system: file-systems: Add shared flag. Date: Tue, 2 Aug 2022 14:23:09 +0300 Message-Id: <20220802112309.28423-1-go.wigust@gmail.com> X-Mailer: git-send-email 2.37.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::229; envelope-from=go.wigust@gmail.com; helo=mail-lj1-x229.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Oleg Pykhalov X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/build/file-systems.scm (mount-flags->bit-mask, mount-file-system): Handle shared flag. * gnu/system/file-systems.scm (invalid-file-system-flags): Add shared to known flags. * guix/build/syscalls.scm (MS_SHARED): New variable. (option-string->mount-flags): Handle shared flag. * doc/guix.texi (File Systems): Document shared flag. --- doc/guix.texi | 5 +++-- gnu/build/file-systems.scm | 6 ++++++ gnu/system/file-systems.scm | 4 +++- guix/build/syscalls.scm | 6 +++++- 4 files changed, 17 insertions(+), 4 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index 9d17050ffc..106ab428d9 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -16376,8 +16376,9 @@ include @code{read-only}, @code{bind-mount}, @code{no-dev} (disallow access to special files), @code{no-suid} (ignore setuid and setgid bits), @code{no-atime} (do not update file access times), @code{strict-atime} (update file access time), @code{lazy-time} (only -update time on the in-memory version of the file inode), and -@code{no-exec} (disallow program execution). +update time on the in-memory version of the file inode), +@code{no-exec} (disallow program execution), and @code{shared} (make the +mount shared). @xref{Mount-Unmount-Remount,,, libc, The GNU C Library Reference Manual}, for more information on these flags. diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index 1d3b33e7bd..b9d46c9350 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -6,6 +6,7 @@ ;;; Copyright © 2019–2021 Tobias Geerinckx-Rice ;;; Copyright © 2019 David C. Trudgian ;;; Copyright © 2020 Maxim Cournoyer +;;; Copyright © 2022 Oleg Pykhalov ;;; ;;; This file is part of GNU Guix. ;;; @@ -1123,6 +1124,8 @@ (define (mount-flags->bit-mask flags) (logior MS_STRICTATIME (loop rest))) (('lazy-time rest ...) (logior MS_LAZYTIME (loop rest))) + (('shared rest ...) + (loop rest)) (() 0)))) @@ -1186,6 +1189,9 @@ (define (mount-nfs source mount-point type flags options) (cond ((string-prefix? "nfs" type) (mount-nfs source target type flags options)) + ((memq 'shared (file-system-flags fs)) + (mount source target type flags options) + (mount "none" target #f MS_SHARED)) (else (mount source target type flags options))) diff --git a/gnu/system/file-systems.scm b/gnu/system/file-systems.scm index f8f4276283..464b76a2ca 100644 --- a/gnu/system/file-systems.scm +++ b/gnu/system/file-systems.scm @@ -4,6 +4,7 @@ ;;; Copyright © 2020 Jakub Kądziołka ;;; Copyright © 2020, 2021 Maxim Cournoyer ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2022 Oleg Pykhalov ;;; ;;; This file is part of GNU Guix. ;;; @@ -121,7 +122,8 @@ (define invalid-file-system-flags ;; Note: Keep in sync with 'mount-flags->bit-mask'. (let ((known-flags '(read-only bind-mount no-suid no-dev no-exec - no-atime strict-atime lazy-time))) + no-atime strict-atime lazy-time + shared))) (lambda (flags) "Return the subset of FLAGS that is invalid." (remove (cut memq <> known-flags) flags)))) diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index a7401fd73f..ef0b1d67fd 100644 --- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -8,6 +8,7 @@ ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen ;;; Copyright © 2021 Chris Marusich ;;; Copyright © 2021 Tobias Geerinckx-Rice +;;; Copyright © 2022 Oleg Pykhalov ;;; ;;; This file is part of GNU Guix. ;;; @@ -49,6 +50,7 @@ (define-module (guix build syscalls) MS_RELATIME MS_BIND MS_MOVE + MS_SHARED MS_LAZYTIME MNT_FORCE MNT_DETACH @@ -537,6 +539,7 @@ (define MS_REMOUNT 32) (define MS_NOATIME 1024) (define MS_BIND 4096) (define MS_MOVE 8192) +(define MS_SHARED 1048576) (define MS_RELATIME 2097152) (define MS_STRICTATIME 16777216) (define MS_LAZYTIME 33554432) @@ -637,7 +640,8 @@ (define lst ("nodev" => MS_NODEV) ("noexec" => MS_NOEXEC) ("relatime" => MS_RELATIME) - ("noatime" => MS_NOATIME))))))) + ("noatime" => MS_NOATIME) + ("shared" => MS_SHARED))))))) (define (mount-flags mount) "Return the mount flags of MOUNT, a record, as an inclusive or of -- 2.37.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 03 11:21:34 2022 Received: (at 56880) by debbugs.gnu.org; 3 Aug 2022 15:21:35 +0000 Received: from localhost ([127.0.0.1]:49759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJGBi-0005TB-Ke for submit@debbugs.gnu.org; Wed, 03 Aug 2022 11:21:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJGBh-0005Sz-KC for 56880@debbugs.gnu.org; Wed, 03 Aug 2022 11:21:33 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47810) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGBc-0004HW-Da; Wed, 03 Aug 2022 11:21:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=oevsGthkkmS3Ys1FNyb/LFb19cZTEjw++TIVA73RMaA=; b=QfIRy87XGVD4Pz3zu28W XpjnukVCFeFQpd+sR2pR+Quo64j36DksoR/IFcHi8+I+Bj6DKx2v8OfTiWJaNBUnbR1Qy58RanMxd PldJsHcKQkPF7OwHymqtPrjlW/RUCaoX+jkrhCBxVJEQIQV9dPhSNBN0TmJBPkEf99FdEkN+xerEx Z2PJMfGVvWhDOiJZzdlkT2i32J5oyaojiRWxGEgP3Qvw5sU3cf9LxMWm+LOCcmqXCZpqTfG7DOmED V3mbF5D7xIrP5J01eiyUnzfadOwOtj1dbP5jGeOPwg+/Yb0FgtnNJF0lEwM6dAASus8xCybsMMh46 pChe6VKyRkA+hw==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=55762 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJGBc-0000l2-0O; Wed, 03 Aug 2022 11:21:28 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Oleg Pykhalov Subject: Re: bug#56880: [PATCH] gnu: system: file-systems: Add shared flag. References: <20220802112309.28423-1-go.wigust@gmail.com> Date: Wed, 03 Aug 2022 17:21:26 +0200 In-Reply-To: <20220802112309.28423-1-go.wigust@gmail.com> (Oleg Pykhalov's message of "Tue, 2 Aug 2022 14:23:09 +0300") Message-ID: <87fsids689.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56880 Cc: 56880@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Oleg, Oleg Pykhalov skribis: > * gnu/build/file-systems.scm (mount-flags->bit-mask, mount-file-system): > Handle shared flag. > * gnu/system/file-systems.scm (invalid-file-system-flags): Add shared to = known > flags. > * guix/build/syscalls.scm (MS_SHARED): New variable. > (option-string->mount-flags): Handle shared flag. > * doc/guix.texi (File Systems): Document shared flag. LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 04 09:20:27 2022 Received: (at 56880) by debbugs.gnu.org; 4 Aug 2022 13:20:27 +0000 Received: from localhost ([127.0.0.1]:51602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJam3-0003AV-HH for submit@debbugs.gnu.org; Thu, 04 Aug 2022 09:20:27 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:43932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJam1-0003A7-9g for 56880@debbugs.gnu.org; Thu, 04 Aug 2022 09:20:25 -0400 Received: by mail-lj1-f172.google.com with SMTP id bx38so12255695ljb.10 for <56880@debbugs.gnu.org>; Thu, 04 Aug 2022 06:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc; bh=QyobtlMccqhfcAsLPySppyejcgSlPdZNTRNSsWZmqIQ=; b=h5J5EKz5zJC5cemIfwZ8QLGWCUgGLEMsKhHeVJp4AYfNfidHnu8wghItVomdVTM+S8 GOJ/IMopKkMse7aRoEtasvGbjW5X+445qKe8TKDe7224xcpaM/UBy1EdWPzViSQb6K1S FzshEvnUi3Oi6JcF1QFH2T1XCgaGXzSlH6zZYfyOHHaAGjCEs5GWAL57gYC0WZtx2ci1 uOcOlEVj71auHUliGQRLuFLZC3GPzM/cOzBYKfzbw56lYwmznYErGMBVWnXfmXbA5e0W nu1gcVy6McXCFQ3hfxTK5xZw+5F4p+u9LgAyJxRmjNEF6n8TCPTEBf5wq3Qszn1sLMa+ 63ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=QyobtlMccqhfcAsLPySppyejcgSlPdZNTRNSsWZmqIQ=; b=TSQEKX+9v2wwX8SGbcG/6KunBnHufTfXtRK0pURDStYjH/r7zN0d8G0ecA0m4HREs5 bomHqd4Y0SHzSaDp5G+da4I7M/R+odutw68h8/Rca6C6IBlpYgpB73v4oDfmje0bbttc qFgr5A59xH4ibaB2d58NSQ6If5YZvbJZ213tVPrjycgz85mKyk8Rq21W1rHAPq8LhAbZ kCV/lq65DV4ZSkoUfSG83d8N5ady6u3ytJRPMxFhCQ8rYY7G1uZqnThnDsgwTT3InR0O uu8KavTCXCX1Xu1twPHsXgfSff6EkDXQBZD1hwS+f5JnglBdr51lhKqhN/E/Ga6o9Gmf qnEA== X-Gm-Message-State: ACgBeo3EuhFE/ml2RZLzlztu3Eqi/i519lqHI56iq8+oByrBq79BYDSz y8gnySwkeVdOBbq/n6m5AudaFjdp9IA= X-Google-Smtp-Source: AA6agR4hJwZCbOtEjxtdXUtmRn0xbwh3QBfkJ6uOcXNprZaCM2LY2JEvd7Tk2vTSilpzrH7omsfluA== X-Received: by 2002:a2e:5011:0:b0:25e:71cd:b718 with SMTP id e17-20020a2e5011000000b0025e71cdb718mr577081ljb.448.1659619218893; Thu, 04 Aug 2022 06:20:18 -0700 (PDT) Received: from localhost ([88.201.161.72]) by smtp.gmail.com with ESMTPSA id z1-20020ac24f81000000b0048a81bebaf8sm122584lfs.147.2022.08.04.06.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Aug 2022 06:20:17 -0700 (PDT) From: Oleg Pykhalov To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#56880: [PATCH] gnu: system: file-systems: Add shared flag. References: <20220802112309.28423-1-go.wigust@gmail.com> <87fsids689.fsf@gnu.org> Date: Thu, 04 Aug 2022 16:20:16 +0300 In-Reply-To: <87fsids689.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 03 Aug 2022 17:21:26 +0200") Message-ID: <87czdgqh67.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56880 Cc: 56880@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Ludovic, Thank you for the review. Ludovic Court=C3=A8s writes: [=E2=80=A6] >> (option-string->mount-flags): Handle shared flag. I looked again on this procedure before merge. With applied patch it will return a wrong bitmask according to the manual page: mount(2) The only other flags that can be specified while changing the propaga= =E2=80=90 tion type are MS_REC (described below) and MS_SILENT (which is ig= =E2=80=90 nored). Also I tried to invoke 'mount' from C code, if MS_SHARED specified and mountpoint does not exist (not mounted without MS_SHARED before), then nothing will happen. =20 The procedure is out of the scope adding a shared flag support to file-system record. I see two variants: 1. Remove the modification from option-string->mount-flags and merge, someone will add when required. 2. Modify option-string->mount-flags in such way, that it will return multiple bitmasks or in some other way. Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmLrx5AUHGdvLndpZ3Vz dEBnbWFpbC5jb20ACgkQFn+OpQAa+px+DA/9EEim/20sYP1OJWW3R2YGM5nbjxh8 1PIp+eCLI6M8gcXlD5Nf22Iye7mhDtM2LVDLeD6Su6DTiokgOG5Tg/iL6v2BE9BI psGo13FKT8YFNt8Okn4A+bV10/3oGcJoGICgMh0cCg1MVJ4WJjFUCNsA8sfi4Bl0 TJYr7DmsY2LoPbXqAhDGpH+Wwm7/eZbiKH8rSolJo8Tzhuaoqsy81GNtWliCOPKs UP3PRh5weA2k0/wWK4GUMEynx+96SrOD7CiKhKDbYA5NTH9KMMC+RlPbmF+p+AwR 29FdFwsDiZPYFlWJqLIxKQEzaztji2ofT9J4Q3m1uFJr7cXR4oiBXanCSO9x5R7I DSQ0nLlI7xyr/ob4u+vu8oRiLgcDaZ1Bl7NZPGrBRy4IH7kHd+DE+XowZM3Lf4cl fO92e6J0seoko/9IaRIq0b4G0k6q1OKd8n/hAF8G7+2QO+quYt+zwJpaQZ2zYCZ3 ktnxKfVOU2nuSjVQkQff/17GZLPaViWJQ2TpaRZQDZ2MUm7ElGVy3VaRR4vukdgC rXsHBsIUcZ27aesqiAHECFmpPwzVgwc+BicLKhDkiYW9mZEDzHyFzYcyUTRy6tUh DgXkkTFrSb6ZDcrNX9YRY1W9ikW2pSD/REnyFa9xD9r9m12O/vY2Y6cetLAT8/q/ ughUZ07AzNRC+B8= =mylf -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 05 05:41:52 2022 Received: (at 56880) by debbugs.gnu.org; 5 Aug 2022 09:41:52 +0000 Received: from localhost ([127.0.0.1]:56263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJtq4-0007xe-0S for submit@debbugs.gnu.org; Fri, 05 Aug 2022 05:41:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oJtpz-0007xP-VA for 56880@debbugs.gnu.org; Fri, 05 Aug 2022 05:41:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJtpu-0001uT-HU; Fri, 05 Aug 2022 05:41:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=zDT4yOmQThr+47J3hXkxOikYNio/GPK7SwlEMxDKqg0=; b=ffwjI6LpU2L37Im/1/d1 QaQSjaFC1I9rQImleRCc/rElRXHytrRw8mOYrIYKLpw7Gi8dRb2R4iqIcasPlFKzplxeXB1MnVTed K44DrbE9KJo0lIzOsMUkquI9PT9hX+oqAuGTTygJgS14EyKmgNaclSaJpUfcyzPn3Lg07ps0qXajk gOxI86Ea1y68g1O11e4GulCZS178baHGJX3D4dwuptzdsXLiQqO/c5p7LbjHcNXqIVzbwNQ/sfR7U 64go7gE1eMfQ52/iLomyOTVxp8iO8jxfCzxEIYEoBlPZ4YE+LEN+pHXX7Hwl1fYS1MPCMi7IxCwrW qpyHiyX0Iu34kw==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=46632 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oJtpu-0006mH-6F; Fri, 05 Aug 2022 05:41:42 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Oleg Pykhalov Subject: Re: bug#56880: [PATCH] gnu: system: file-systems: Add shared flag. References: <20220802112309.28423-1-go.wigust@gmail.com> <87fsids689.fsf@gnu.org> <87czdgqh67.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Octidi 18 Thermidor an 230 de la =?utf-8?Q?R=C3=A9vo?= =?utf-8?Q?lution=2C?= jour de l'Amande X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 05 Aug 2022 11:41:38 +0200 In-Reply-To: <87czdgqh67.fsf@gmail.com> (Oleg Pykhalov's message of "Thu, 04 Aug 2022 16:20:16 +0300") Message-ID: <87fsibhvsd.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56880 Cc: 56880@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Oleg Pykhalov skribis: > Ludovic Court=C3=A8s writes: > > [=E2=80=A6] > >>> (option-string->mount-flags): Handle shared flag. > > I looked again on this procedure before merge. With applied patch it > will return a wrong bitmask according to the manual page: > > mount(2) > > The only other flags that can be specified while changing the propag= a=E2=80=90 > tion type are MS_REC (described below) and MS_SILENT (which is i= g=E2=80=90 > nored). > > Also I tried to invoke 'mount' from C code, if MS_SHARED specified and > mountpoint does not exist (not mounted without MS_SHARED before), then > nothing will happen. Hmm not sure I follow. > The procedure is out of the scope adding a shared flag support to > file-system record. I see two variants: > > 1. Remove the modification from option-string->mount-flags and merge, > someone will add when required. > > 2. Modify option-string->mount-flags in such way, that it will return > multiple bitmasks or in some other way. I understand option #1 and it sounds reasonable to me. I=E2=80=99m not sure what option #2 means concretely? Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 10 00:19:49 2022 Received: (at 56880-done) by debbugs.gnu.org; 10 Aug 2022 04:19:49 +0000 Received: from localhost ([127.0.0.1]:45749 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLdC9-0000yv-9h for submit@debbugs.gnu.org; Wed, 10 Aug 2022 00:19:49 -0400 Received: from mail-lj1-f171.google.com ([209.85.208.171]:40730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLdC7-0000yg-Rw for 56880-done@debbugs.gnu.org; Wed, 10 Aug 2022 00:19:48 -0400 Received: by mail-lj1-f171.google.com with SMTP id l10so10322093lje.7 for <56880-done@debbugs.gnu.org>; Tue, 09 Aug 2022 21:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc; bh=NJyqFaWIiMdokLsd5icuytYsiTafy7FjNqVJSWbgLTk=; b=m0C9TVgrYxmPARjlrY6NI6laekUDNYGu3QCQRP+61xePKTxocKIb7OrsNP1gweM2Zy +nUHDqkfV8uLTeCo9BeaEb6JDZeBKEmC8mRsXKXpKuYr7qa8bd/zaY5w88zfcTcM9rqu eNmIwG4095xaA53QZrVSK3OexzRXBU/2l12Mp0gVS8zXJpdXimSKNTJAgdz9nq6FXUmA p2j4OWxlHVtMKDSuysbL3zCzIUvZ23bC7cwiAV7xdX1Hn4YG2p8Smlv0VExXlop73gGg vhjv7uMtOydDNTfpt70z20ol7q978efN/1O0Ac47PTNIXDC1A00gsB42nQDL6cOAuz0Y PL6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc; bh=NJyqFaWIiMdokLsd5icuytYsiTafy7FjNqVJSWbgLTk=; b=5HxwUnBA9ekSqU2Sh2+vly1rshubd2odsqYgzAbud3BWIGoC3sxhJXEBCOWpY2/oDM EcjXIWNiMSimd0GyJhiqJrcbB6A0iAno4Turtcuodh4LQuHkCg32VhEsUKHyuCKoFb52 86tF8vGcwvM22a/rISZ8DiDCbGdhhduwuHLN3T/hnsMRVmrw/iIqvLCVbs+tKYxwHrqS tLZEOtgfrP/WLQ85CKq8IYaR8DbmyPB+CIxI01Q7xJaJzmoKx16a32I+8JBdGRze7l0E BOV1j5SQcaUzmIK076jjrkBeslHsooQhQ2Nk0swuKKVdM8sVkzpI4E8IyoEyC6PHKFX4 8NNA== X-Gm-Message-State: ACgBeo3jV6fVRRjckLjqpmrhtw4HRGh2SzF24SruCAGXeJEz4w96ezji FCabX/SmktoepNlVGk+Qb8s= X-Google-Smtp-Source: AA6agR5NcqPvlyq+zaK6Gi2LyKOox+nmEP5gyTZFCOgrbzxvKf1maDiT5Z+m3wfeDGfhz0+uViS9uQ== X-Received: by 2002:a2e:bd89:0:b0:25a:9386:75d0 with SMTP id o9-20020a2ebd89000000b0025a938675d0mr8564869ljq.431.1660105181537; Tue, 09 Aug 2022 21:19:41 -0700 (PDT) Received: from localhost ([88.201.161.72]) by smtp.gmail.com with ESMTPSA id v28-20020a056512049c00b0048b31fa9f3asm181470lfq.179.2022.08.09.21.19.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Aug 2022 21:19:40 -0700 (PDT) From: Oleg Pykhalov To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#56880: [PATCH] gnu: system: file-systems: Add shared flag. References: <20220802112309.28423-1-go.wigust@gmail.com> <87fsids689.fsf@gnu.org> <87czdgqh67.fsf@gmail.com> <87fsibhvsd.fsf@gnu.org> Date: Wed, 10 Aug 2022 07:19:38 +0300 In-Reply-To: <87fsibhvsd.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Fri, 05 Aug 2022 11:41:38 +0200") Message-ID: <87lerwd92d.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 56880-done Cc: 56880-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: [=E2=80=A6] >> I looked again on this procedure before merge. With applied patch it >> will return a wrong bitmask according to the manual page: >> >> mount(2) >> >> The only other flags that can be specified while changing the propa= ga=E2=80=90 >> tion type are MS_REC (described below) and MS_SILENT (which is = ig=E2=80=90 >> nored). >> >> Also I tried to invoke 'mount' from C code, if MS_SHARED specified and >> mountpoint does not exist (not mounted without MS_SHARED before), then >> nothing will happen. > > Hmm not sure I follow. [=E2=80=A6] >> 2. Modify option-string->mount-flags in such way, that it will return >> multiple bitmasks or in some other way. [=E2=80=A6] > I=E2=80=99m not sure what option #2 means concretely? We need to call mount(2) two times, which is not handled by option-string->mount-flags which returns only one mount(2) bitmask. I pushed #1 as 4b494878380920c8c7eecccd1f299164dd4a2c3f to master. Oleg. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJIBAEBCgAyFiEEcjhxI46s62NFSFhXFn+OpQAa+pwFAmLzMdoUHGdvLndpZ3Vz dEBnbWFpbC5jb20ACgkQFn+OpQAa+pxW/BAAhB6dHNKl0kCffDW2SlaLphgsvd2z WLDiIxiuI+SnHqruJ3/W+srVEOyUuIZvZ9EpuRAQOMs2/NwU/3JlBzZ+I6AGpnKB aQ12BJOgKxTcpRrKjfNmaH7eugEmv3SZIb2VKQrngvTURAJBdGJmVkLawjbsTIqC DSPO+sLAizp0VKs5TEIZYlQIN7vH6HjaCvE9fnWLHQduBKbujU/oc0N1nJLUxilY /fXmT2Kcro8wkCnV9MJqn1H0ADNF4w12Fz3MpnLfnB8Dr3cMVt8hJm+zeqeapGKj 2yhU1EUAp4dHW9xw4/sT/tc/uAPOd08hZMlZNdMThVxiP2L+Dy0nGAJYM2xVzLvj 4iQh+pwIswXowOtRo27AEYOeiF0Rzz5PHQ0VQD7QaJVjj4qV5kM2mRNRvtO6Wg3P HEgWlKgwHWMRmCQa143Q0yUL05QKEE2m1O+7zEDYbXvDwFbS/n1RflArmogjcSFL UffYO3We3bmMDXypItfi+WlF+IO4og68jMqbnH6dvvZFC3nkbvEZVsqTJN52z4CH exRJCEgxwLnT9sfQNxtc+LTQY7FvRpjFFH52tgkUQvplTwlnr3I3kSIN3n8y6IwM qdv9JCaUDbbk7A3EeLm8fS7Qwx/pUKzZ0Ikfs5RS6Z43r6xvsSeisogoSjyLO4C5 B115Je81ALTjQRc= =MSN/ -----END PGP SIGNATURE----- --=-=-=-- From unknown Tue Jun 24 13:54:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 07 Sep 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator