GNU bug report logs - #56873
Make `defvar-keymap' warn on conflicting and redundant bindings

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Mon, 1 Aug 2022 16:48:01 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 29.1

Done: Robert Pluim <rpluim <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #14 received at 56873 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Robert Pluim <rpluim <at> gmail.com>
Cc: 56873 <at> debbugs.gnu.org
Subject: Re: bug#56873: Make `defvar-keymap' warn on conflicting and redundant
 bindings
Date: Tue, 2 Aug 2022 10:09:43 +0000

Robert Pluim <rpluim <at> gmail.com> writes:

>     Stefan>     (defvar-keymap foo
>     Stefan>       "a" #'next-line
>     Stefan>       "a" #'previous-line)
>
> Is that a common occurence?

I don't know.  I've only seen such a mistake once, but flagging it might
help us find more.

Your patch looks fine to me, but I agree with Lars that it should be an
error instead of a warning.  (And putting it in `define-keymap' is
indeed better.)
This bug report was last modified 2 years and 296 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.