From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Aug 2022 16:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 56873@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165937245121570 (code B ref -1); Mon, 01 Aug 2022 16:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 1 Aug 2022 16:47:31 +0000 Received: from localhost ([127.0.0.1]:41482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIYZm-0005bp-2K for submit@debbugs.gnu.org; Mon, 01 Aug 2022 12:47:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:58566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIYZX-0005bO-8q for submit@debbugs.gnu.org; Mon, 01 Aug 2022 12:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50702) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oIYZW-0001M8-Oh for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 12:47:14 -0400 Received: from mail-vk1-f172.google.com ([209.85.221.172]:43893) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oIYZU-0000r2-0J for bug-gnu-emacs@gnu.org; Mon, 01 Aug 2022 12:47:13 -0400 Received: by mail-vk1-f172.google.com with SMTP id w129so5840389vkg.10 for ; Mon, 01 Aug 2022 09:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=LeCL/mpH5jnMQH2uhYsIYhKxdLtD5ap+fhEwgO++voQ=; b=gTcpcHx9oD+8hAyXQrcB8hszWN6YL7/XwBs1ZWBlO/4vvskU7rp8QbV/QbkTTnERg9 wpucq2mtyY0qwKBnm10ckZ/+onPdNPZC/e0+UaNOJTxv2k28+nfcN0z0u2TCritI2jWC mltapESY4W2Feq1XcdtgYewOPMkl+OSawkPRwOGvLcfgA9W260jH3aNe7xvhDcac3n+d g/xYKWFbhBZPAllTzThj9/y1FcdTYzCDWGgctGk0jv3kT+X2sHz1+Tn4DZwEIdka3KUr v2IM4FJyJ6InqV8PUPRuCfxkA8JGL2ZIbdlwnUAFm7Kn0l6war3gs2KIC07LQKxExJyw 44dw== X-Gm-Message-State: ACgBeo0wbg8I5jwHB9E92hermGw7RSeFyCkXY3Q2IkO4xo2dx7cI+XQz OEbkxg/5lM/3FFkjMUc6GFISpW0isFxeGtTV1zEzPcug X-Google-Smtp-Source: AA6agR7Qn3Vh6NX7O5UhxgfcrdZ/BZ+hQheKmxAC+STzLhVZWYA4TW8wo6jRNF7hDr+fwzPENMx3ZEHIcSA6MbPDLR8= X-Received: by 2002:a05:6122:c5f:b0:377:b803:c24f with SMTP id i31-20020a0561220c5f00b00377b803c24fmr818vkr.32.1659372430897; Mon, 01 Aug 2022 09:47:10 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 1 Aug 2022 16:47:10 +0000 From: Stefan Kangas MIME-Version: 1.0 Date: Mon, 1 Aug 2022 16:47:10 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.221.172; envelope-from=stefankangas@gmail.com; helo=mail-vk1-f172.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Severity: wishlist It would be useful if `defvar-keymap' could warn on conflicting bindings, such as in: (defvar-keymap foo "a" #'next-line "a" #'previous-line) Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) Severity: wishlist It would be useful if `defvar-keymap' could warn on conflicting bindings, such as in: (defvar-keymap foo "a" #'next-line "a" #'previous-line) It would also be useful to warn about redundant bindings, such as in: (defvar-keymap foo "a" #'next-line "a" #'next-line) From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 08:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: 56873@debbugs.gnu.org Received: via spool by 56873-submit@debbugs.gnu.org id=B56873.165942875713952 (code B ref 56873); Tue, 02 Aug 2022 08:26:02 +0000 Received: (at 56873) by debbugs.gnu.org; 2 Aug 2022 08:25:57 +0000 Received: from localhost ([127.0.0.1]:42254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oInDx-0003cy-2q for submit@debbugs.gnu.org; Tue, 02 Aug 2022 04:25:57 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:33437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oInDu-0003ck-Bv for 56873@debbugs.gnu.org; Tue, 02 Aug 2022 04:25:56 -0400 Received: by mail-wr1-f42.google.com with SMTP id v3so15976750wrp.0 for <56873@debbugs.gnu.org>; Tue, 02 Aug 2022 01:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc; bh=HGwpFoBsWjFWkhiAq/cgCw601mhXJtjB5Vsha+Ay7XE=; b=HeJC6jQBufS5636zX/vXZ9kdvbnKGeJ40x6/gSA798Q6fs045lqtGI3Bt1HgQ7lYqA t7hOVVI/oI8uhcUbRdI6Ctwd/khm25mzmYcO8wlYkTvQzseNnYQznM4O4UWWSZw+yEfF JiMm+kb2FFejC4Yj5Ltov87jGO5Et3TCDludYuRGz4qGSi1Qlz/VuxlyJL3It1uzeUuc 5yEmpH+tevHzonc8TGtDPGbogE8LFAuohmz4t5mJ5+IEpthpwN316za0KQ40oJiBvkTA /PtAklpYvphILXfR/x/eXrr3xEz2ah+IMffVKUZ20jC2hBzrq7serTEwkwxFZFl9SNmw lORw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=HGwpFoBsWjFWkhiAq/cgCw601mhXJtjB5Vsha+Ay7XE=; b=VTPnOjiM+Tz0mZJBAtsVp/pjmAjYNNQyz+kUfPE9mfaqcqyaMDuxUH127Jjno89hEn dxcrjVkMbis5XYF2J2v9ZdKgaxjGD7SxPtn0t+qpDGVLehIa4mHS6/wjEfSKK298d4UL NGqP47y2Og8P67aLsPbmE3b2dCeMQ67/ubMtiX4z/auvlmMZSS6NYC8Ak1OFaWju3l0T 6gi4lwEKUlia9BdDSeDpJ1PulTqZ+4Hd3R7ZqvhD7q4tXnnG8qIfaqmo+mW9UY0V6Vrl UhBP6MTz4YxYE4MEun5/svax7CYx2vh6POtDgstX/UXWOO9W0xy5rErbSnA+R8q/8vq3 plzg== X-Gm-Message-State: ACgBeo3CwC71iOaCb9oc67d3RNGndYv+sXDhdnSF5xN5NIz4OOx28lpX pMTMc15yGO1WhiqLYttFCtLl4zIoyiU= X-Google-Smtp-Source: AA6agR6zUePVffBYQmjPL76V18avz95Phw64RBOmLilkw6eOQwBdgoJBOqamZ0bYys+rbKxaB3CgLQ== X-Received: by 2002:a05:6000:2ab:b0:21e:2e68:52f4 with SMTP id l11-20020a05600002ab00b0021e2e6852f4mr12046228wry.236.1659428747975; Tue, 02 Aug 2022 01:25:47 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:6d96:2ef3:e3b8:ccb2]) by smtp.gmail.com with ESMTPSA id i18-20020adfaad2000000b0021d70a871cbsm14424964wrc.32.2022.08.02.01.25.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 01:25:47 -0700 (PDT) From: Robert Pluim In-Reply-To: (Stefan Kangas's message of "Mon, 1 Aug 2022 16:47:10 +0000") References: Date: Tue, 02 Aug 2022 10:25:46 +0200 Message-ID: <87mtcnhx11.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 1 Aug 2022 16:47:10 +0000, Stefan Kangas = said: Stefan> Severity: wishlist Stefan> It would be useful if `defvar-keymap' could warn on conflicting Stefan> bindings, such as in: Stefan> (defvar-keymap foo Stefan> "a" #'next-line Stefan> "a" #'previous-line) Is that a common occurence? Stefan> It would also be useful to warn about redundant bindings, such = as in: Stefan> (defvar-keymap foo Stefan> "a" #'next-line Stefan> "a" #'next-line) That=CA=BCs just a special case of conflicting bindings. This will do it, but I wonder if `warn' is overkill. I put it in `define-keymap', but it could equally well go in `defvar-keymap'. diff --git a/lisp/keymap.el b/lisp/keymap.el index 376a30f106..b44a961d73 100644 --- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -530,7 +530,8 @@ define-keymap (keymap keymap) (prefix (define-prefix-command prefix nil name)) (full (make-keymap name)) - (t (make-sparse-keymap name))))) + (t (make-sparse-keymap name)))) + seen-keys) (when suppress (suppress-keymap keymap (eq suppress 'nodigits))) (when parent @@ -544,6 +545,9 @@ define-keymap (let ((def (pop definitions))) (if (eq key :menu) (easy-menu-define nil keymap "" def) + (if (member key seen-keys) + (warn "Duplicate definition for key: %S" key) + (push key seen-keys)) (keymap-set keymap key def))))) keymap))) =20 Robert --=20 From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: Stefan Kangas , 56873@debbugs.gnu.org Received: via spool by 56873-submit@debbugs.gnu.org id=B56873.165943370222152 (code B ref 56873); Tue, 02 Aug 2022 09:49:02 +0000 Received: (at 56873) by debbugs.gnu.org; 2 Aug 2022 09:48:22 +0000 Received: from localhost ([127.0.0.1]:42343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIoVh-0005lE-QE for submit@debbugs.gnu.org; Tue, 02 Aug 2022 05:48:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIoVe-0005ka-Vj for 56873@debbugs.gnu.org; Tue, 02 Aug 2022 05:48:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UNMhhegLn0nc0tl4Jm3RKzAXqFbkpbkEh13DnXB7teI=; b=V1ld7mEVtmFnS7+o2vWa4jgrbt p8IoZxgfTEOlmp607f4bn2xF6FarZKSruB0wiQQGko+pvN1+kOB5ZBK9cfWe+4gupP7VCEDklxz0Q 044Xd7TJL9WURlgDP1bxOiGGSwfPxqgjiESRMrVsOWTSSTxTm9dCPQvOYfWuIamaiKH8=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIoVW-0006h4-3N; Tue, 02 Aug 2022 11:48:12 +0200 From: Lars Ingebrigtsen In-Reply-To: <87mtcnhx11.fsf@gmail.com> (Robert Pluim's message of "Tue, 02 Aug 2022 10:25:46 +0200") References: <87mtcnhx11.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAIVBMVEUxLCgiHRlhXFdD Pjr19PDEwbuGgnumo53W1M6AfHb///9QeSwYAAAAAWJLR0QKaND0VgAAAAd0SU1FB+YIAgkvNkTH Rw4AAAGoSURBVDjLjZO9b9swEMVPUlJ5lB0IWkWLjNVNdm1UY6BQpUZ/yBCyuV2ySi0Fc3Qlu1TG Fh3y5zZLhpAskBvvh3ePdw8EeK0xmMuKPDOaULQwAnu5KdemSd9IPWOGYTe0gHFFkAaCnoeW4Jmn gWZUW5UnNeAjcj/pvUgf9dstxBo0AfhNm8pe78OoOo1v8pdnq+CKItHhtWfPlf0I/S676xpdKQDc B2YFxeUuDlXzwzlvT885blQFXMRs02KuAoDM8vv2mmrXcvLH0V25yPU8KFudyvlB29GZgrv7ZUtt w5f6QDK/cCNVkyLM8zRfUnUTHOIhJyzCGwX8PZDzQKpOfH3bT3iYDlxyShNFwUMSiww3WPNAf+JZ N2o+K69ylrKeRlgUvbL4eTt8Sh7Jdq8cyz0ev/iodRtLmbSw7BLX+9UPxdniefgssjJVHADkfpBb MSxPSn/y06/YE85WawUELJ4fWdC4WuRUJAsW7xwti/AWjtNLZkgpQJVtSg/wbh/L0AAkG0R50PvO PR8600e3GWbsNtHBhAVbykyKJw8+mrwhgf+W8z7wD1jTW5FlsOchAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIyLTA4LTAyVDA5OjQ3OjU0KzAwOjAwxfLf8AAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0w OC0wMlQwOTo0Nzo1NCswMDowMLSvZ0wAAAAASUVORK5CYII= X-Now-Playing: Rocketnumbernine's _Meyouweyou_: "Black And Blue" Date: Tue, 02 Aug 2022 11:48:09 +0200 Message-ID: <87ilnb2cyu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > =?UTF-8?Q?That=CA=BCs?= just a special case of conflicting bindings. This will do it, > but I wonder if `warn' is overkill. I think it should signal an error. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > That=CA=BCs just a special case of conflicting bindings. This will do it, > but I wonder if `warn' is overkill. I think it should signal an error. From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 10:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Robert Pluim Cc: 56873@debbugs.gnu.org Received: via spool by 56873-submit@debbugs.gnu.org id=B56873.165943499432535 (code B ref 56873); Tue, 02 Aug 2022 10:10:02 +0000 Received: (at 56873) by debbugs.gnu.org; 2 Aug 2022 10:09:54 +0000 Received: from localhost ([127.0.0.1]:42378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIoqY-0008Sg-3X for submit@debbugs.gnu.org; Tue, 02 Aug 2022 06:09:54 -0400 Received: from mail-vs1-f41.google.com ([209.85.217.41]:33594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIoqV-0008SS-P3 for 56873@debbugs.gnu.org; Tue, 02 Aug 2022 06:09:52 -0400 Received: by mail-vs1-f41.google.com with SMTP id l68so14038319vsc.0 for <56873@debbugs.gnu.org>; Tue, 02 Aug 2022 03:09:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=ztUYAEGUgPhpjFPGNsWTvqFmarNHXs828pR9Sk16rnc=; b=Df0PjFwMkAxOo0XDBpuKA/Pl7woO0zNOWkH9t8Bhf70daeal4cVNk0nLuiiSPxEWrS ngbIXSbnvAqZAgGDkukNC+L/XVUNQAB/GbYsHqta1GGwDeql7cewJhl3R+77e+eZ+Dm8 V2g6XOA3PHpeiBl9UGRrX4amosuAmBdbJfQBYfBCo4RD5/zGH+X8cv/3iw/N/pMCWi+d XbYDfNg/iy6L6baGP83ncvHyEv4hOxHH0s75vEKkVok/wd41yPco7XULYK7N3n3a+vbA JgyII0VCrP1tghNa1WbNuQYXHnOyDXOvd9o+Cq620WDWqJnq1hEvvAm21ufrr26GmvCn d0QQ== X-Gm-Message-State: ACgBeo0w3tLPhIGHnLcDHKFelZLh79XQ6zBGmFTN7f853gDQCvr9nTQA +9y5uL1ezXKwQlilCTr6tkb0vpzHqZeD+0cpi1E= X-Google-Smtp-Source: AA6agR59EbUEOkf5JdURmvHT/885oIMyou5/rksauDVJA8DtCVD90eP3x/tkTncQFw7Y7q71PmGkQKI/yg6fHHDy85M= X-Received: by 2002:a05:6102:512b:b0:387:cc8f:a0fa with SMTP id bm43-20020a056102512b00b00387cc8fa0famr1047313vsb.3.1659434984778; Tue, 02 Aug 2022 03:09:44 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Aug 2022 10:09:43 +0000 From: Stefan Kangas In-Reply-To: <87mtcnhx11.fsf@gmail.com> References: <87mtcnhx11.fsf@gmail.com> X-Hashcash: 1:21:220802:56873@debbugs.gnu.org::b2ELJdiHShcCb+pq:6EyS MIME-Version: 1.0 Date: Tue, 2 Aug 2022 10:09:43 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Robert Pluim writes: > Stefan> (defvar-keymap foo > Stefan> "a" #'next-line > Stefan> "a" #'previous-line) > > Is that a common occurence? I don't know. I've only seen such a mistake once, but flagging it might help us find more. Your patch looks fine to me, but I agree with Lars that it should be an error instead of a warning. (And putting it in `define-keymap' is indeed better.) From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 02 06:18:16 2022 Received: (at control) by debbugs.gnu.org; 2 Aug 2022 10:18:16 +0000 Received: from localhost ([127.0.0.1]:42416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIoye-0002QL-5p for submit@debbugs.gnu.org; Tue, 02 Aug 2022 06:18:16 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIoyc-0002Q6-4O for control@debbugs.gnu.org; Tue, 02 Aug 2022 06:18:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=d5KYd0WMBrbm88WIv6aTwswpGynaz27RT6gAPW9rfuQ=; b=kBv9Zzmxu3/dBPbtpc5WE9gyfh QXuxKcsA/9VLmFbVmda1hTyzcfPwdUQPa0FiEeP5rMwyKwjfS+nwsaDyE3SwPdHd/MW6LhDWS6by3 N+s2IwwwYfgQTW78lbg2h9n8FrajfUvQT1MDyk/fL7htAzUT6cggVM6NyVXC2Ws2OocE=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIoyU-00076P-Cf for control@debbugs.gnu.org; Tue, 02 Aug 2022 12:18:08 +0200 Date: Tue, 02 Aug 2022 12:18:06 +0200 Message-Id: <8735ef0x0h.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #56873 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 56873 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 56873 + patch quit From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 11:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Lars Ingebrigtsen , 56873@debbugs.gnu.org Received: via spool by 56873-submit@debbugs.gnu.org id=B56873.165944122229620 (code B ref 56873); Tue, 02 Aug 2022 11:54:01 +0000 Received: (at 56873) by debbugs.gnu.org; 2 Aug 2022 11:53:42 +0000 Received: from localhost ([127.0.0.1]:42682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIqSz-0007hg-SV for submit@debbugs.gnu.org; Tue, 02 Aug 2022 07:53:42 -0400 Received: from mail-wr1-f48.google.com ([209.85.221.48]:43547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIqSx-0007hR-IS for 56873@debbugs.gnu.org; Tue, 02 Aug 2022 07:53:40 -0400 Received: by mail-wr1-f48.google.com with SMTP id bk11so7736008wrb.10 for <56873@debbugs.gnu.org>; Tue, 02 Aug 2022 04:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc; bh=fWISzFOWxRbE8tIvbxFndGhaI7xeHFcuuInkG3mbi30=; b=NIRspQ4XIYzl4PBaB3yjNu1jt/U8c+DfBUT/tKzYgSC9BPAXprCHqalPvg1gZ0fICS BbMahKH98zRiBukg/3Wf9+QLy2cB4iIlqcHhA8WyfRFUYB4yB4yddwIhABhwehXSoTbl OfjxGivX3k7UaNlVcYbCaqm5l5SoMcFkBjoNbyoxD3N2iL/TV6YIRQSoj7oDGsbSjoPF FJe6LjPTLH4tBjmal+Ogpk2WteF4C2pYG1djjUQ6D0dSN4tukFuJ7NATnj3hhdyCqX91 h9pkvu2TWzuZ55tsujlW4hDXczFUeCZqzn2qUcJx//tAUYOKEp411Z5AWLW5ODZ6OREB WnFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc; bh=fWISzFOWxRbE8tIvbxFndGhaI7xeHFcuuInkG3mbi30=; b=rm0emho15+fzep0Q5Cp7uRWJB06L5+DDnuW3K82IL9yPxXz6ZglL8EZTgBfHaCCqY0 lLs30FDGrtPDUO4tJk9ojxcrCzHqILLoV/F2I+F3Z5+NE+OhBc4i2Ufc2JhIU7/5PNa9 R4xmArWjcaAqaEGPNRBZqFodXbYOsl/3Rj6/yoTYX/jaee8dFkP/k1a7OPTG01fr+5gf Suwx5EAk+csH/iWImrzQ0DPdi7ju1NJkhLBSq1qD4LpFePv8V831Dw7ub3H8OV2nbCSy IZ9f8Wq3ccUvpTzNHzdAh2aHMHa8Xt64UJpv5GVgf0AwoEEJjUnDqknBbsSJGXBbet0/ vl3A== X-Gm-Message-State: ACgBeo0vfto9vbhkGPrmlWvPlW8ERhRIXyAQ9VtOGDQVn+256y01H1/M fLwLKMHUW01rj5E/RXKQjIU= X-Google-Smtp-Source: AA6agR4GzsJ4HprQJfZJCSND3zb/NI8F6Ned16Imp/KzS0YD+Gcj6HeBYpaRmPRJomn+ReMk9tZn1Q== X-Received: by 2002:adf:fb42:0:b0:21e:f0cc:8c15 with SMTP id c2-20020adffb42000000b0021ef0cc8c15mr12708125wrs.430.1659441213627; Tue, 02 Aug 2022 04:53:33 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:6d96:2ef3:e3b8:ccb2]) by smtp.gmail.com with ESMTPSA id ba4-20020a0560001c0400b002205f0890eesm8439566wrb.77.2022.08.02.04.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 04:53:32 -0700 (PDT) From: Robert Pluim In-Reply-To: (Stefan Kangas's message of "Tue, 2 Aug 2022 10:09:43 +0000") References: <87mtcnhx11.fsf@gmail.com> Date: Tue, 02 Aug 2022 13:53:32 +0200 Message-ID: <87bkt2j1z7.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >>>>> On Tue, 2 Aug 2022 10:09:43 +0000, Stefan Kangas = said: Stefan> Robert Pluim writes: Stefan> (defvar-keymap foo Stefan> "a" #'next-line Stefan> "a" #'previous-line) >>=20 >> Is that a common occurence? Stefan> I don't know. I've only seen such a mistake once, but flagging= it might Stefan> help us find more. There are in fact 4 instances in Emacs=CA=BC sources. Stefan> Your patch looks fine to me, but I agree with Lars that it shou= ld be an Stefan> error instead of a warning. (And putting it in `define-keymap'= is Stefan> indeed better.) I put it in both, and it turns out we have errors in both, which I propose to fix like this (this preserves current behaviour, due to the 'last definition wins' nature of define-keymap). I decided that for coherence, the gnus-summary-up-thread binding should go as well (it=CA=BCs available on "T-u" anyway). --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=duplicate-definitions.patch diff --git c/lisp/gnus/gnus-srvr.el i/lisp/gnus/gnus-srvr.el index a520bfcd8b..54be0f8e6a 100644 --- c/lisp/gnus/gnus-srvr.el +++ i/lisp/gnus/gnus-srvr.el @@ -699,7 +699,6 @@ gnus-browse-mode-map "n" #'gnus-browse-next-group "p" #'gnus-browse-prev-group "DEL" #'gnus-browse-prev-group - "" #'gnus-browse-prev-group "N" #'gnus-browse-next-group "P" #'gnus-browse-prev-group "M-n" #'gnus-browse-next-group diff --git c/lisp/gnus/gnus-sum.el i/lisp/gnus/gnus-sum.el index bf2a083fec..90b57695c5 100644 --- c/lisp/gnus/gnus-sum.el +++ i/lisp/gnus/gnus-sum.el @@ -1958,8 +1958,6 @@ :keymap "C-M-b" #'gnus-summary-prev-thread "M-" #'gnus-summary-next-thread "M-" #'gnus-summary-prev-thread - "C-M-u" #'gnus-summary-up-thread - "C-M-d" #'gnus-summary-down-thread "&" #'gnus-summary-execute-command "c" #'gnus-summary-catchup-and-exit "C-w" #'gnus-summary-mark-region-as-read diff --git c/lisp/ibuffer.el i/lisp/ibuffer.el index 742d21d0b0..65430d7d11 100644 --- c/lisp/ibuffer.el +++ i/lisp/ibuffer.el @@ -447,7 +447,6 @@ ibuffer-mode-map "d" #'ibuffer-mark-for-delete "C-d" #'ibuffer-mark-for-delete-backwards - "k" #'ibuffer-mark-for-delete "x" #'ibuffer-do-kill-on-deletion-marks ;; immediate operations diff --git c/lisp/wdired.el i/lisp/wdired.el index a5858ed190..106d57174d 100644 --- c/lisp/wdired.el +++ i/lisp/wdired.el @@ -902,7 +902,6 @@ wdired-perm-mode-map "x" #'wdired-set-bit "-" #'wdired-set-bit "S" #'wdired-set-bit - "s" #'wdired-set-bit "T" #'wdired-set-bit "t" #'wdired-set-bit "s" #'wdired-set-bit --=-=-= Content-Type: text/plain The detection looks like this: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=keymap-duplicate-detection.patch diff --git i/lisp/keymap.el w/lisp/keymap.el index 376a30f106..107565590c 100644 --- i/lisp/keymap.el +++ w/lisp/keymap.el @@ -530,7 +530,8 @@ define-keymap (keymap keymap) (prefix (define-prefix-command prefix nil name)) (full (make-keymap name)) - (t (make-sparse-keymap name))))) + (t (make-sparse-keymap name)))) + seen-keys) (when suppress (suppress-keymap keymap (eq suppress 'nodigits))) (when parent @@ -544,6 +545,9 @@ define-keymap (let ((def (pop definitions))) (if (eq key :menu) (easy-menu-define nil keymap "" def) + (if (member key seen-keys) + (error "Duplicate definition for key: %S %s" key keymap) + (push key seen-keys)) (keymap-set keymap key def))))) keymap))) @@ -571,6 +575,16 @@ defvar-keymap (push (pop defs) opts)))) (unless (zerop (% (length defs) 2)) (error "Uneven number of key/definition pairs: %s" defs)) + (let ((defs defs) + key seen-keys) + (while defs + (setq key (pop defs)) + (pop defs) + (when (not (eq key :menu)) + (if (member key seen-keys) + (error "Duplicate definition for key '%s' in keymap '%s'" + key variable-name) + (push key seen-keys))))) `(defvar ,variable-name (define-keymap ,@(nreverse opts) ,@defs) ,@(and doc (list doc))))) diff --git i/test/src/keymap-tests.el w/test/src/keymap-tests.el index b0876664ed..ce96be6869 100644 --- i/test/src/keymap-tests.el +++ w/test/src/keymap-tests.el @@ -430,6 +430,18 @@ test-non-key-events (make-non-key-event 'keymap-tests-event) (should (equal (where-is-internal 'keymap-tests-command) '([3 103])))) +(ert-deftest keymap-test-duplicate-definitions () + "Check that defvar-keymap rejects duplicate key definitions." + (should-error + (defvar-keymap + ert-keymap-duplicate + "a" #'next-line + "a" #'previous-line)) + (should-error + (define-keymap + "a" #'next-line + "a" #'previous-line))) + (provide 'keymap-tests) ;;; keymap-tests.el ends here --=-=-=-- From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 12:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: Stefan Kangas , 56873@debbugs.gnu.org Received: via spool by 56873-submit@debbugs.gnu.org id=B56873.165944168930571 (code B ref 56873); Tue, 02 Aug 2022 12:02:03 +0000 Received: (at 56873) by debbugs.gnu.org; 2 Aug 2022 12:01:29 +0000 Received: from localhost ([127.0.0.1]:42712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIqaX-0007x1-JA for submit@debbugs.gnu.org; Tue, 02 Aug 2022 08:01:29 -0400 Received: from quimby.gnus.org ([95.216.78.240]:57024) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIqaV-0007wc-7i for 56873@debbugs.gnu.org; Tue, 02 Aug 2022 08:01:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=J7Jp23QHJNBQ2aj9TGyeUFZJb4J/T2U6e+R5L533AhU=; b=KHlU4mSRbnXnlt2JXT/8Rvcu4X 93IAETjXX5lha2OKCKR0ePdIPnbtCB8g2/0Cj0RTeUdbr3yvXYpU21Fk3ocgiXEcB9Sc2YlzsF4Fa 0rEyd0iU0A4sbMtuev9DzAcDFjl4endhlMjK+4Uizdwc6SmQap/G7O/QnXYO0aR8NQkk=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oIqaM-0008Oa-Hx; Tue, 02 Aug 2022 14:01:20 +0200 From: Lars Ingebrigtsen In-Reply-To: <87bkt2j1z7.fsf@gmail.com> (Robert Pluim's message of "Tue, 02 Aug 2022 13:53:32 +0200") References: <87mtcnhx11.fsf@gmail.com> <87bkt2j1z7.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEU3QzqOi2u2v8X/ //9TfYjHAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YIAgwAMLlzGL0AAAGCSURBVCjPRdC9btwwDAdw ujgFaKcecB56W7c+hg3EGTpZgP4CrDkapKdI1k5JEBpIpgynIuZTljSCxoPFnyhSH0RuoM8vbYf/ cVfi3R78MjR/r4OTd/33HB6Jhihvih8I0DzkjjpagFkx73V9i/jEsnygG6iLmzWbaSCddLeKvc6T WZspHHQMBj3gyaZthU7QyRHpMc9sncdpb7/lfemOL83gYDV0teKimcOOrzHZxodet+tKrnU4zCdF RoTU+5J1HxTcsMiT8BBoK5lXkSa4nqkUICkYegBgwVnk0jDO2iDim8i7YI6U9NppBxRrFEPxD6BU WjEkHzzFBVmxbaFXMNjAoQdl7f1736dnA/4osr0s0Kym6ZNPCqQo1QASjVepfOkVzaeoGWasKz3Q EU9SAS+NNEaWOgElU3fsFliGbx9pHA1nTi/LSvN0fF4kceX0SsE5hFJSQxQKvfPXegtw/Evh1A2+ bTU1WQnhO3lWiC5D+DmMCtmc0NT5fF5bTZcb+QcofrAnaQCH1AAAACV0RVh0ZGF0ZTpjcmVhdGUA MjAyMi0wOC0wMlQxMjowMDo0OCswMDowMOY7gzQAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDgt MDJUMTI6MDA6NDgrMDA6MDCXZjuIAAAAAElFTkSuQmCC X-Now-Playing: Osees's _Panther Rotate_: "Scramble Experiment" Date: Tue, 02 Aug 2022 14:01:18 +0200 Message-ID: <87v8ravoq9.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Robert Pluim writes: > I put it in both, and it turns out we have errors in both, which I > propose to fix like this (this preserves current behaviour, due to the > 'last definition wins' nature of define-keymap). I decid [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Robert Pluim writes: > I put it in both, and it turns out we have errors in both, which I > propose to fix like this (this preserves current behaviour, due to the > 'last definition wins' nature of define-keymap). I decided that for > coherence, the gnus-summary-up-thread binding should go as well (it=CA=BCs > available on "T-u" anyway). Looks good to me; please go ahead and push. From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: Lars Ingebrigtsen , 56873@debbugs.gnu.org Received: via spool by 56873-submit@debbugs.gnu.org id=B56873.165944266432356 (code B ref 56873); Tue, 02 Aug 2022 12:18:02 +0000 Received: (at 56873) by debbugs.gnu.org; 2 Aug 2022 12:17:44 +0000 Received: from localhost ([127.0.0.1]:42762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIqqG-0008Po-0W for submit@debbugs.gnu.org; Tue, 02 Aug 2022 08:17:44 -0400 Received: from mail-vs1-f42.google.com ([209.85.217.42]:39644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIqqC-0008PW-Dy for 56873@debbugs.gnu.org; Tue, 02 Aug 2022 08:17:42 -0400 Received: by mail-vs1-f42.google.com with SMTP id c3so14315858vsc.6 for <56873@debbugs.gnu.org>; Tue, 02 Aug 2022 05:17:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=fgPiOl/uxx87J2/hZeaGfT6akzsLAbit7Kb5qr2kjEY=; b=51ff3S8ewjIHCQJP2uVZP3nx3rj+rWG0LjxFIRIZ/becCV4kJs1UUyZMy0Zz9nEsAJ cPKPYbh5K7CLR16nkuS8k94Ku1yslkyLt+JoU5zW/J67vkbeovpFu5N6QaKarWGAPdzm qUsZXKsHtAUgV1kN8X6xRuHmZixQdycZ4M7mL7F5/eO469d8o+aIXFxM0J10LY+6rmmO YS9NnwfCasogOAWIdibSmkcexdHmCCuFEhnPbpenEtEs1GPb6dMthoMwx8KkDJ8X5V2g xYCmR61PDxx0LHYycl/g3TVBV+k47RA4Xmb4bKfBavoMu40kOIoSi85ybF5VhQZfM7xl F9Ug== X-Gm-Message-State: AJIora8ehimAXXOmjlaS4ImYxqZtfIpR+7rSPCID0loRvVBJ4sw1pbj1 4j48Cx7opz0SurLVqMzzel+yMX/UiKou1l2f09Q= X-Google-Smtp-Source: AGRyM1t1Nkq7ITB0R5b5BEYRw7TOxDFi1WdYRdi7HzGqg/wu2FlCSxZycFs+pQGa9Zbu0M0YtDKyvOB9C8ezocaf7PU= X-Received: by 2002:a67:cb0c:0:b0:357:9897:32d4 with SMTP id b12-20020a67cb0c000000b00357989732d4mr7779761vsl.18.1659442654792; Tue, 02 Aug 2022 05:17:34 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 2 Aug 2022 12:17:34 +0000 From: Stefan Kangas In-Reply-To: <87bkt2j1z7.fsf@gmail.com> References: <87mtcnhx11.fsf@gmail.com> <87bkt2j1z7.fsf@gmail.com> X-Hashcash: 1:21:220802:larsi@gnus.org::xEFqqwKdoexaWAuz:6lFx MIME-Version: 1.0 Date: Tue, 2 Aug 2022 12:17:34 +0000 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Robert Pluim writes: > The detection looks like this: LGTM. From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 12:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Stefan Kangas , 56873@debbugs.gnu.org Received: via spool by 56873-submit@debbugs.gnu.org id=B56873.16594436211543 (code B ref 56873); Tue, 02 Aug 2022 12:34:01 +0000 Received: (at 56873) by debbugs.gnu.org; 2 Aug 2022 12:33:41 +0000 Received: from localhost ([127.0.0.1]:42776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIr5h-0000Oj-4f for submit@debbugs.gnu.org; Tue, 02 Aug 2022 08:33:41 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:42866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIr5d-0000OP-ST; Tue, 02 Aug 2022 08:33:40 -0400 Received: by mail-wm1-f42.google.com with SMTP id 8-20020a05600c024800b003a2fe343db1so6894101wmj.1; Tue, 02 Aug 2022 05:33:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc; bh=LFkg7Fpe2VjRJMMRL4eL2Jb1Yya4Dy8v9PAFgqOTdEY=; b=OQyEoqiURMJjcXkvKC45sjnWYF5q6Mlq/vn+NbwJ4z2+4RR0p0htn3glFbUrRezFtx IkfiUP7Y/zOetyRpAtlV8uSCMRIoMY3TPSSIQy/7Fv1Ywe4NHfjtoORzPDM1Pa76Z36H yVQ2ycjUcRNdU4BNzBfgC6nOpgvTUlpnrnFV6UvPd4OAEmaxh+ZzKZMA8j7nEfMtUzqk yga7u6hdu/X0wMvoIyCuWFDZ9LwHhgIQrLofOtC83TYBf3nX1HjUEwH6pxsoKaZ+zl+s fj8c4zDlpPSWQwOsAG98jbhtQYbGJonHbR/y0yU/IYlKhFVzLgzU4WA1Rzy7oqe4abup iPuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc; bh=LFkg7Fpe2VjRJMMRL4eL2Jb1Yya4Dy8v9PAFgqOTdEY=; b=LQauxxrOcfHim6+FtGlPkVL5nVdYpZ7FbPRBHfz7NAZpFILMk+/4QMNlXdfeu8Li+C vYm82BdZ2mdUGT41ddDFbp1L4/sOIWdmUyoI9gP+EgC9N9Im5Qod1vly5Nfi9iGyvWm9 Wt0U3QNdaANpOYaNEjVT8Y3EJGJjkmxdyW3rjt9GF+FPfA/obcsvOhmanP3esDsmTrCt 72U19GyjmJboqI6RmXGTU3h/Ss8fnE41u+yaPxLcXsvEZ4Gd3FyEvcIZpBIUS0f9Csqu 8gE56Ayl7C8JmwkRsm6z/ihkRELWPMeZ7t9JCkcdzlB/naDsiOQpEFNGgQp92LxS/P14 6kVQ== X-Gm-Message-State: AJIora9qeudXYpfepRa/4FHCOai+VOlzpzoKUqJTLElpPD4qylcaIJq9 rpuroUoANsOJlNhkX0CmFWu8P4gpHPA= X-Google-Smtp-Source: AGRyM1tpoQjkVi4npQcHaL+YxX4gLTLlvthhSPJ3nCPOBQnxwF3PgKL4XuFAXohcjrFR20ffTh/idA== X-Received: by 2002:a05:600c:4349:b0:3a4:a4fa:450 with SMTP id r9-20020a05600c434900b003a4a4fa0450mr12867788wme.157.1659443611614; Tue, 02 Aug 2022 05:33:31 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:6d96:2ef3:e3b8:ccb2]) by smtp.gmail.com with ESMTPSA id j3-20020a5d6043000000b0021efc75914esm15242396wrt.79.2022.08.02.05.33.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Aug 2022 05:33:31 -0700 (PDT) From: Robert Pluim In-Reply-To: <87v8ravoq9.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 02 Aug 2022 14:01:18 +0200") References: <87mtcnhx11.fsf@gmail.com> <87bkt2j1z7.fsf@gmail.com> <87v8ravoq9.fsf@gnus.org> Date: Tue, 02 Aug 2022 14:33:30 +0200 Message-ID: <8735eej04l.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 56873 fixed close 56873 29.1 quit >>>>> On Tue, 02 Aug 2022 14:01:18 +0200, Lars Ingebrigtsen said: Lars> Robert Pluim writes: >> I put it in both, and it turns out we have errors in both, which I >> propose to fix like this (this preserves current behaviour, due to t= he >> 'last definition wins' nature of define-keymap). I decided that for >> coherence, the gnus-summary-up-thread binding should go as well (it= =CA=BCs >> available on "T-u" anyway). Lars> Looks good to me; please go ahead and push. Closing. Committed as bf47851e08 From unknown Sun Jun 22 22:42:31 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2022 15:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56873 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed To: Lars Ingebrigtsen , Robert Pluim Cc: Stefan Kangas , "56873@debbugs.gnu.org" <56873@debbugs.gnu.org> Received: via spool by 56873-submit@debbugs.gnu.org id=B56873.16594551966857 (code B ref 56873); Tue, 02 Aug 2022 15:47:01 +0000 Received: (at 56873) by debbugs.gnu.org; 2 Aug 2022 15:46:36 +0000 Received: from localhost ([127.0.0.1]:44850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIu6N-0001mW-Jl for submit@debbugs.gnu.org; Tue, 02 Aug 2022 11:46:35 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:40060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIu6J-0001mM-1W for 56873@debbugs.gnu.org; Tue, 02 Aug 2022 11:46:34 -0400 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 272FETlw025866; Tue, 2 Aug 2022 15:46:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=3UKEQSW7VPDl+94VZGwdgJip4RJD/GxjnPbghg6d+qs=; b=3EIKJn/5ObUP2mEKN4vnKsIXIPXbUOfIlp9qa/z3J6OEmduNSZMmkv+WTFtVONKJg17P BylJi1+3g65jVHWuxiUAmcMYENjBJsqJ9VXifDxoZv2m5TzhRO9aOK59/RyGLAr0eLJP +ZmpIXTcUMjx5sva28eL8vwOrNz8rQQKXqO0jSDuXZG9pv+9RKlwoWaRFfm3924IMJQT ++VrTjFNZ3C1LFTZn++YTl4hqHZrWZZ+46AaGUFNF6YS+gDqFGyN5uw5NarsLTJFuSt6 BuTRo7AzdxzfHf8Rk4xMRSiRW6fhh19n2jTnxjRypTHZS1cP8c7ImGCXJQz04N3EgU8u tw== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hmw6tf7vt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Aug 2022 15:46:29 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 272DoBr5031589; Tue, 2 Aug 2022 15:46:12 GMT Received: from nam12-mw2-obe.outbound.protection.outlook.com (mail-mw2nam12lp2046.outbound.protection.outlook.com [104.47.66.46]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3hmu32eqxb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Aug 2022 15:46:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DBKcaisriiuqreYgmpUABmcc7WpW9kTDio8d6oADB0r+gHAQfVdpTKF1kuTcx/CmabC4JFRCTSrbu65gLxjUS1zq0AWEBTnNaSCoyE/HsL06H6tmCGmXIF45ijlGU0ri4WCCtibmDYnzxvOhC/sDDWeODTFOrWU9ikBhxqki0iXHQe4F46Z2S5aEeE4Aiwhux9kNCYkkSLY74XnFUOtANVXZQpd4a1o+S+bXjyGIMPVBhMV6uaZdmycPQS+UxAKZctb0DzYO8lL7JkLcIcA4lJ4qMF8ZFOsPwO27SgdSL2KdaoQObuo6v+gQnn8BdYTKje2XyaXVT36lb4iWdGSLjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3UKEQSW7VPDl+94VZGwdgJip4RJD/GxjnPbghg6d+qs=; b=EY2cM4UWQD9ANl9oMmO/S2fx3Rc1LBxzl/ApieInz2CPcBlioNyxxl+i3Nk5sWd7aARyTUqCuL+pZ2O21nL3TW104QMYKNiuC2FVE5/YHQjkvGDl8X3ci6/cKi3WYO8AzEaGcEsn2XcIaP5DWp4v4T//yR/4PutoudpQ7OuNzNvTxlcozBa5hvGqrwlsrtwIJ6d1gkmqg5LQTcRlzu2rX2UXLb6eCZvtkzPRlZwRNqoTHniUXqhelzWLQfuihuHj4YL+uJXHiRWlDNAyq71ZOeyW6WWMBKodzRh3buswP9C+7w5aucnS/a/GfO4iMS1uuk411tuGM1RQGVr427pIJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3UKEQSW7VPDl+94VZGwdgJip4RJD/GxjnPbghg6d+qs=; b=HhOW+/cKmV3nufSukcz1LlDB8zEC3nzjsd0TNu+FKRvkBcs9fRVM9jPMG76wE27xbkDe6035klfJ/oyucJEOohriCG9RD2uL3oRutA+7Jojn0zY0pyygfx7XUYd0TiMbnWUfPDUEky2eEttm1PHtHPtS0gd8fpM5iqRuI69EWlw= Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19) by CY4PR10MB1464.namprd10.prod.outlook.com (2603:10b6:903:27::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.14; Tue, 2 Aug 2022 15:46:10 +0000 Received: from SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::8d65:31e6:cd0e:e95]) by SJ0PR10MB5488.namprd10.prod.outlook.com ([fe80::8d65:31e6:cd0e:e95%5]) with mapi id 15.20.5482.016; Tue, 2 Aug 2022 15:46:10 +0000 From: Drew Adams Thread-Topic: [External] : bug#56873: Make `defvar-keymap' warn on conflicting and redundant bindings Thread-Index: AQHYplUkfZSVrHkwyUuofVYJIh8x3K2bv9zg Date: Tue, 2 Aug 2022 15:46:09 +0000 Message-ID: References: <87mtcnhx11.fsf@gmail.com> <87ilnb2cyu.fsf@gnus.org> In-Reply-To: <87ilnb2cyu.fsf@gnus.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c57b5170-f0e8-4a59-fac9-08da749e1f02 x-ms-traffictypediagnostic: CY4PR10MB1464:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: K1t0ooJwfpf6058RMdqY5PVb05JRYUA3FOgG2FKH8m/SFkyCYbISVL3xrSAgHU94AxvuycJ148dwjn6RDm1PY6xz6AfK/Y89Hi9ImSW/POB39RNU7L09Wq5pQCdkPRVU0JddhPhz8PXvUG0X7ZuPH+V6AOa8nQjVdYteQ+pRZJ29i6APW25uN2Wfjb/gSysePBb9ckjZEuBcB7r71Yno+3pPEIPZiy5ePr/LZ2BzQYCw+r+d2sZdu5XhN5tmHpmZWlEc0mOLuHanQFM4DmZtioowiQiQldVQ0WE2bohKM4+J6dA14Dr6l7xDmgcL1nTW/6b6CtMsupDeFq/otMeT+dH30j3JfKCfASvr8/U98ve+vt0T1N3c3wXibC732PEgJIVNIhcVDN+dYWgUUYh50YmmuGBpX99IUgY+pu0sqWjxjwQhxuiMAXZs4m7TWltHyTA6j1TXU9yNff973ESgiFRK9eXJ9cN7eEwUnEa6fq+/Wg3Tmd6bXqOA/R2FUVwHViby09dhYHTL9SghubFuPUAD3ljbRskpoo8imzeZhI55FaDEPIgSYJIl9fOfUFOO0RE5/KZmby7AI8lFEOeRkIvGddEg9WawOiGVgtRURmiTnScxS0nRh4v2B+t1NO5HPOP5Hr+SkX4LTVd/u17ncFzDgHdOItmqPUBpbMaoP8qkyn5+uZs2VDAOcL/CiR75zCJUUdyeC675HktMe9NbpI6RYvgDUPiUla8LevyJ888v0bDdxEr64CYM2RYWynV8ik41FaIDHzfwyatcHaYxt8/JdEZES75t3dDoPqDjl0pAdd1DAVmqyEX4fA8G2gw7 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(366004)(346002)(376002)(396003)(39860400002)(33656002)(55016003)(8676002)(2906002)(76116006)(4744005)(66946007)(44832011)(52536014)(5660300002)(38070700005)(66446008)(66476007)(64756008)(86362001)(66556008)(4326008)(122000001)(38100700002)(71200400001)(9686003)(316002)(26005)(478600001)(8936002)(41300700001)(7696005)(6506007)(54906003)(186003)(110136005)(83380400001)(81973001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: d7Vgocpw7d0U+bxLP6cj8E3VTtChl1NrZmx/+FUimaAET7ClnfEyLfEf6MUVtJG9JkUAGZPifhtO+zpC6hSGHynxek6JShfr+e/+bGR34b/XRkpb+lStdQHkdbxi1Q61BHXNkADb6vJKXdiXirZmUWJgnyZertr4AR86hfMGXPOv/m7Bjyq3mWu3o14pqzXT4JBT0fyJddArMDJKTgJwN+c7utdTeXHexJFSrQp/DFa3i6zzRsf677rupofdmXGV1FMJbcNfkEOIZ22cKL4oWdiksGRQf3LXEe/dNjLuRhBeUq0D59WsuJ3UAj3RbGC3PyX7wYmd885fD+O5/pYliB9Dw582wRgpaczgbZKtb2PDHTaeEuWJfNTT2YJ0gcM51Y9/7nRx9NnI0IENn3tNjusNubl2RsZ9wanwyn88lb12iahaTawZsuIJd1KR9clMxST2XpUD3CqjkBg9FhGO3X2Zo2iihmynfJ0QsgrcuRAl+n3IdsEJSMnpgXAxOKlnA/1+G8EpdtM1ABi3uEyDU9bsmPnFoX+wKvXNbzDEBtjLZUOelS/cgKqepgeSaGtFncn+hyAM28fGbqqT9UJM75kQ2VP9PJ9Qxup5U8msIWyknNsWyIsOff36fS2PmQFESDqSFacX7rVJYSVmP8ITOHL1JMJQZFqWxNJw8eCI0Hp9xRlDoYPnoyBz6VrpctArr2vessyAKYfDhQf8ldp+cPUZwfFvkB8QNfsSSLWUNBsLmtfbOsYS1BL4sZ6IRxZc8qfVk4OYIOoBByTzRkxGV8rzUo/ZnkfNT1SShcFdqQzW8J7GIKVJsB9QfG9w1xilmghIrKqWzoYDaqhHoRXJZqjpMcT03IC7jmHr0M2jfO+1Bnw8IlKcJYJHe335FJIyVusYycAqMNhi0e/8pqVCItA1ZYKu3fv2RKpjwosBqWfbv3ie56RXqc5UlyVB+E1xNIDZgOmKN71pN6cmCgY02hvoqGiHnc4VyK3b2luhiKF8wKXbRpiri46x8k3CdFuBShDGKZZp6j6m1vtDQHcYT0VRa6hNfTcI4UckhA6U4aAaYWgpfaf4lpfqqBl7BWi9UV9649jvUFUJgdFdWNP6azjFzbvanaJn1ypii+ylKHojnuMX2BjoeJVLnhEV1LE1OY1N+IxsC+J9Fem32HksumfaEBww5kFntHICFkYVMYhBlUTfgGaN0IYmqRIhTfogBtFm7CQJld0G24mPMjQwIKjwbq9Pk8cHMAHXMIivOhY0S0T7ZX2J8T+pjZmhSPGQmcR5TPO1Vor3uRvrwXBUuoSROjek1j2sHZYuTudvpbjInRKzDPGLotPDYYZyHjr3e+MdCd7y9fL2dkrBMk6mufYKN/TmQ+PrDMYtL6Njs4zDG6rdSB2IBE7F1v2ZniESPSeQPPGySOMkNnSjk7kMvaR/FoUMIvP7hy5DjFDV5WpOHCyikkHdAjnBReqDBX40iw4nGxYeATgcuPn+Np5Tep7Tlb/7R5LMz1/zS+KEKl7/urCO20isa+i6guuY1B+mfRdFdeuBbnIdCgDKNuStVb7DVzFl7+lvuHdRh87/W+LQuhtxlnpdlH8GYpflEzBr Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c57b5170-f0e8-4a59-fac9-08da749e1f02 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Aug 2022 15:46:09.9665 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Mo/3Vk8DsB93Qc1u6+sFcQBvXJ9wRAcECgGYhrIU8/HXBogRldkgJWgDshaYbKJCZpd36Rt6mUnp2NR39aWB9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1464 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-02_10,2022-08-02_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0 suspectscore=0 adultscore=0 mlxlogscore=936 bulkscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2208020073 X-Proofpoint-GUID: w7ceY7RnqYm6euC_hsKUbo8uETSzMVX2 X-Proofpoint-ORIG-GUID: w7ceY7RnqYm6euC_hsKUbo8uETSzMVX2 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiA+IGJ1dCBJIHdvbmRlciBpZiBgd2FybicgaXMgb3ZlcmtpbGwuDQo+IEkgdGhpbmsgaXQgc2hv dWxkIHNpZ25hbCBhbiBlcnJvci4NCg0KV2h5PyAgSSBkb24ndCB1bmRlcnN0YW5kIHdoYXQgdGhl ICJlcnJvciIgaXMuDQpBIHdhcm5pbmcgaXMgb25lIHRoaW5nIC0gbGV0cyB5b3Uga25vdyBhYm91 dA0KYSBwb3NzaWJsZSB0eXBvIG9yIGxvZ2ljIG1pc3Rha2UuICBCdXQgYW4gZXJyb3I/DQoNCldp bGwgeW91IHJhaXNlIGFuIGVycm9yIGZvciB0aGVzZSBhbHNvPyAgV2h5IG5vdD8NCg0KKHNldHEg YSBuaWwNCiAgICAgIGEgdCkNCg0KKHNldHEgYSA0Mg0KICAgICAgYSA0MikNCg0KV2hhdCBhYm91 dCBnZW5lcmF0ZWQgY29kZT8gIElzIHRoZXJlIHNvbWV0aGluZw0KX25lY2Vzc2FyaWx5IHdyb25n XyB3aXRoIHRoZSBjb2RlIHlvdSB3YW50IHRvDQpyYWlzZSBhbiBlcnJvciBmb3I/ICBXaGVyZSdz IHRoZSBlcnJvciBiZWVmPw0K