From unknown Tue Jun 17 01:43:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56861: [PATCH] test-canonicalize-lgpl fails with musl libc Resent-From: =?UTF-8?Q?S=C3=B6ren?= Tempel Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Sun, 31 Jul 2022 16:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 56861 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: 56861@debbugs.gnu.org X-Debbugs-Original-To: bug-sed@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.165928579927181 (code B ref -1); Sun, 31 Jul 2022 16:44:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jul 2022 16:43:19 +0000 Received: from localhost ([127.0.0.1]:38551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIC2A-00074K-U5 for submit@debbugs.gnu.org; Sun, 31 Jul 2022 12:43:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:37916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oI9F4-0008DX-BO for submit@debbugs.gnu.org; Sun, 31 Jul 2022 09:44:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI9F4-0007wW-6Z for bug-sed@gnu.org; Sun, 31 Jul 2022 09:44:26 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:47084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI9F2-0001YV-2b for bug-sed@gnu.org; Sun, 31 Jul 2022 09:44:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=opensmtpd; bh=pIWC8Bm3ib 4/cmqTHOdezfNO8NmnjXGxZi6ml4jA7vs=; h=from:subject:to:date; d=soeren-tempel.net; b=nqzKswa6RiQHG07vNjsjBGZUxcSHYfkGBULu8JmUX8nhW+5 nZwMvbD1w4+oZr+Lv+EjcDOwBXdvjMY7oYkbWrFJPRtW0QbxVLYJMpsx21PwxDIwPvfTUf 1dn0lDWRy5DBGczSbrVBNtrwwOsn9nQTGYXXXpMF4VGDdC4PuVnMwU= Received: from localhost (ipb218e4db.dynamic.kabel-deutschland.de [178.24.228.219]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 2c16cdfc (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES) for ; Sun, 31 Jul 2022 15:44:17 +0200 (CEST) Date: Sun, 31 Jul 2022 15:44:13 +0200 From: =?UTF-8?Q?S=C3=B6ren?= Tempel Message-Id: <2UR170T3B4MRE.3KX5HNJRQPEEB@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=45.76.88.171; envelope-from=soeren@soeren-tempel.net; helo=magnesium.8pit.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Mailman-Approved-At: Sun, 31 Jul 2022 12:43:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, While enabling the sed test suite for the Alpine Linux sed package, I noticed that the test-canonicalize-lgpl test case fails because musl does not provide canonicalize_file_name and hence sed uses a compat implementation which invokes realpath(3). However, musl realpath(3) implementation does not strip leading // characters hence the following test from gnulib-tests/test-canonicalize-lgpl.c fails (handling of leading // is implementation-defined in POSIX): 203 /* On IBM z/OS, "/" and "//" are distinct, yet they both have 204 st_dev =3D=3D st_ino =3D=3D 1. */ 205 #ifndef __MVS__ 206 if (SAME_INODE (st1, st2)) 207 { 208 ASSERT (strcmp (result1, "/") =3D=3D 0); 209 ASSERT (strcmp (result2, "/") =3D=3D 0); 210 } 211 else 212 #endif The problem being the assertions in line 208 and 209. The following patch fixes this issue: diff -upr sed-4.8.orig/gnulib-tests/test-canonicalize-lgpl.c sed-4.8/gnulib= -tests/test-canonicalize-lgpl.c --- sed-4.8.orig/gnulib-tests/test-canonicalize-lgpl.c 2022-07-31 15:28:20.= 249302470 +0200 +++ sed-4.8/gnulib-tests/test-canonicalize-lgpl.c 2022-07-31 15:30:03.09951= 8653 +0200 @@ -200,9 +200,9 @@ main (void) ASSERT (result2); ASSERT (stat ("/", &st1) =3D=3D 0); ASSERT (stat ("//", &st2) =3D=3D 0); - /* On IBM z/OS, "/" and "//" are distinct, yet they both have - st_dev =3D=3D st_ino =3D=3D 1. */ -#ifndef __MVS__ + /* On IBM z/OS and musl libc, "/" and "//" are distinct, yet + they both have st_dev =3D=3D st_ino =3D=3D 1. */ +#if !defined(__MVS__) && !defined(MUSL_LIBC) if (SAME_INODE (st1, st2)) { ASSERT (strcmp (result1, "/") =3D=3D 0); Greetings, S=C3=B6ren PS: Please CC me, I am not subscribed to the list. From unknown Tue Jun 17 01:43:29 2025 X-Loop: help-debbugs@gnu.org Subject: bug#56861: Bug 56861 References: <2UR170T3B4MRE.3KX5HNJRQPEEB@8pit.net> In-Reply-To: <2UR170T3B4MRE.3KX5HNJRQPEEB@8pit.net> Resent-From: Sam James Original-Sender: "Debbugs-submit" Resent-CC: bug-sed@gnu.org Resent-Date: Sat, 31 Dec 2022 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56861 X-GNU-PR-Package: sed X-GNU-PR-Keywords: patch To: 56861@debbugs.gnu.org Received: via spool by 56861-submit@debbugs.gnu.org id=B56861.16725256827314 (code B ref 56861); Sat, 31 Dec 2022 22:29:02 +0000 Received: (at 56861) by debbugs.gnu.org; 31 Dec 2022 22:28:02 +0000 Received: from localhost ([127.0.0.1]:39998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBkKf-0001tj-Qu for submit@debbugs.gnu.org; Sat, 31 Dec 2022 17:28:02 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:57290 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBkKe-0001tN-3F for 56861@debbugs.gnu.org; Sat, 31 Dec 2022 17:28:00 -0500 From: Sam James Content-Type: multipart/signed; boundary="Apple-Mail=_B47D46CF-E16A-4763-BA0D-7F535BFC647D"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Message-Id: <388CD9BC-9838-4108-AAF4-6D886F4F57F0@gentoo.org> Date: Sat, 31 Dec 2022 22:27:41 +0000 X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --Apple-Mail=_B47D46CF-E16A-4763-BA0D-7F535BFC647D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii This is a gnulib bug and should be been fixed by: 1. = https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=3Daae308a3354bb3d0= ae0bdf8647ce9be8e46abbce 2. = https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=3D6ee6c7189f4bafbb= 603ef043fdf44b84c3f7532a sed 4.9 is the first release to have these changes. --Apple-Mail=_B47D46CF-E16A-4763-BA0D-7F535BFC647D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY7C3XV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kIagAQCm/53TUqr14KQJzE3Kiy5S0tEfS13PxoEWfHZW6VfVugD9GzRay0/69Rt4 0CFzIJrH+90577GKR6n/BU68PHrEAg4= =nso9 -----END PGP SIGNATURE----- --Apple-Mail=_B47D46CF-E16A-4763-BA0D-7F535BFC647D--