From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 31 12:43:19 2022 Received: (at submit) by debbugs.gnu.org; 31 Jul 2022 16:43:19 +0000 Received: from localhost ([127.0.0.1]:38551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oIC2A-00074K-U5 for submit@debbugs.gnu.org; Sun, 31 Jul 2022 12:43:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:37916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oI9F4-0008DX-BO for submit@debbugs.gnu.org; Sun, 31 Jul 2022 09:44:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI9F4-0007wW-6Z for bug-sed@gnu.org; Sun, 31 Jul 2022 09:44:26 -0400 Received: from magnesium.8pit.net ([45.76.88.171]:47084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oI9F2-0001YV-2b for bug-sed@gnu.org; Sun, 31 Jul 2022 09:44:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=opensmtpd; bh=pIWC8Bm3ib 4/cmqTHOdezfNO8NmnjXGxZi6ml4jA7vs=; h=from:subject:to:date; d=soeren-tempel.net; b=nqzKswa6RiQHG07vNjsjBGZUxcSHYfkGBULu8JmUX8nhW+5 nZwMvbD1w4+oZr+Lv+EjcDOwBXdvjMY7oYkbWrFJPRtW0QbxVLYJMpsx21PwxDIwPvfTUf 1dn0lDWRy5DBGczSbrVBNtrwwOsn9nQTGYXXXpMF4VGDdC4PuVnMwU= Received: from localhost (ipb218e4db.dynamic.kabel-deutschland.de [178.24.228.219]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 2c16cdfc (TLSv1.3:TLS_AES_256_GCM_SHA384:256:YES) for ; Sun, 31 Jul 2022 15:44:17 +0200 (CEST) Date: Sun, 31 Jul 2022 15:44:13 +0200 To: bug-sed@gnu.org Subject: [PATCH] test-canonicalize-lgpl fails with musl libc From: =?UTF-8?Q?S=C3=B6ren?= Tempel Message-Id: <2UR170T3B4MRE.3KX5HNJRQPEEB@8pit.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=45.76.88.171; envelope-from=soeren@soeren-tempel.net; helo=magnesium.8pit.net X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 31 Jul 2022 12:43:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hi, While enabling the sed test suite for the Alpine Linux sed package, I noticed that the test-canonicalize-lgpl test case fails because musl does not provide canonicalize_file_name and hence sed uses a compat implementation which invokes realpath(3). However, musl realpath(3) implementation does not strip leading // characters hence the following test from gnulib-tests/test-canonicalize-lgpl.c fails (handling of leading // is implementation-defined in POSIX): 203 /* On IBM z/OS, "/" and "//" are distinct, yet they both have 204 st_dev =3D=3D st_ino =3D=3D 1. */ 205 #ifndef __MVS__ 206 if (SAME_INODE (st1, st2)) 207 { 208 ASSERT (strcmp (result1, "/") =3D=3D 0); 209 ASSERT (strcmp (result2, "/") =3D=3D 0); 210 } 211 else 212 #endif The problem being the assertions in line 208 and 209. The following patch fixes this issue: diff -upr sed-4.8.orig/gnulib-tests/test-canonicalize-lgpl.c sed-4.8/gnulib= -tests/test-canonicalize-lgpl.c --- sed-4.8.orig/gnulib-tests/test-canonicalize-lgpl.c 2022-07-31 15:28:20.= 249302470 +0200 +++ sed-4.8/gnulib-tests/test-canonicalize-lgpl.c 2022-07-31 15:30:03.09951= 8653 +0200 @@ -200,9 +200,9 @@ main (void) ASSERT (result2); ASSERT (stat ("/", &st1) =3D=3D 0); ASSERT (stat ("//", &st2) =3D=3D 0); - /* On IBM z/OS, "/" and "//" are distinct, yet they both have - st_dev =3D=3D st_ino =3D=3D 1. */ -#ifndef __MVS__ + /* On IBM z/OS and musl libc, "/" and "//" are distinct, yet + they both have st_dev =3D=3D st_ino =3D=3D 1. */ +#if !defined(__MVS__) && !defined(MUSL_LIBC) if (SAME_INODE (st1, st2)) { ASSERT (strcmp (result1, "/") =3D=3D 0); Greetings, S=C3=B6ren PS: Please CC me, I am not subscribed to the list. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 31 17:28:02 2022 Received: (at 56861) by debbugs.gnu.org; 31 Dec 2022 22:28:02 +0000 Received: from localhost ([127.0.0.1]:39998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBkKf-0001tj-Qu for submit@debbugs.gnu.org; Sat, 31 Dec 2022 17:28:02 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:57290 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pBkKe-0001tN-3F for 56861@debbugs.gnu.org; Sat, 31 Dec 2022 17:28:00 -0500 From: Sam James Content-Type: multipart/signed; boundary="Apple-Mail=_B47D46CF-E16A-4763-BA0D-7F535BFC647D"; protocol="application/pgp-signature"; micalg=pgp-sha512 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Subject: Bug 56861 Message-Id: <388CD9BC-9838-4108-AAF4-6D886F4F57F0@gentoo.org> Date: Sat, 31 Dec 2022 22:27:41 +0000 To: 56861@debbugs.gnu.org X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 56861 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --Apple-Mail=_B47D46CF-E16A-4763-BA0D-7F535BFC647D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii This is a gnulib bug and should be been fixed by: 1. = https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=3Daae308a3354bb3d0= ae0bdf8647ce9be8e46abbce 2. = https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=3D6ee6c7189f4bafbb= 603ef043fdf44b84c3f7532a sed 4.9 is the first release to have these changes. --Apple-Mail=_B47D46CF-E16A-4763-BA0D-7F535BFC647D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iNUEARYKAH0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCY7C3XV8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MAAKCRBzhAn1IN+R kIagAQCm/53TUqr14KQJzE3Kiy5S0tEfS13PxoEWfHZW6VfVugD9GzRay0/69Rt4 0CFzIJrH+90577GKR6n/BU68PHrEAg4= =nso9 -----END PGP SIGNATURE----- --Apple-Mail=_B47D46CF-E16A-4763-BA0D-7F535BFC647D-- From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 02 22:42:52 2025 Received: (at control) by debbugs.gnu.org; 3 Aug 2025 02:42:52 +0000 Received: from localhost ([127.0.0.1]:40293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1uiOgW-0004IU-2b for submit@debbugs.gnu.org; Sat, 02 Aug 2025 22:42:52 -0400 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]:45190) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1uiOgT-0004I3-5D for control@debbugs.gnu.org; Sat, 02 Aug 2025 22:42:49 -0400 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-76bd041c431so2733296b3a.2 for ; Sat, 02 Aug 2025 19:42:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1754188962; x=1754793762; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=YbFpGzuMjEiN6bPY4hCEsZmyZ8ZVPg4zpMdUoB5br3c=; b=Kz+5Q620RnUw/qQUbHyokPtAeTc0Rceaas67OpLMBul7t+e7e3FpyI1gQNgLfBdbF3 YNhMcnG2otNiu4DGwYR1MI4/7FHQIe5mMxwgnTGawWj12mbNclYegQr1WbUolHmgK23X HgOiSrY3YJL57oq2WM3y3EgpvMHDcw/55T1Ts63sjmACnWeA5rRaaMHDMgtmv+vDOfOO YaWjDx7HRcfx5pD+Qzv8LBGtKMPjUvbUNQg4pqGDs/lJybcCqzlMjWMlznUUU2d2qbIf UShsXZmd1oopxm/kYZFXofcSfDs+AX/spOc98e0dD7WgRBZH6cjDDRbauZhtTclxz1fl mArg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754188962; x=1754793762; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YbFpGzuMjEiN6bPY4hCEsZmyZ8ZVPg4zpMdUoB5br3c=; b=N8hU5PfXZiV4K+7oGpSy61nTB+oQAMmyZ+T3zKTw9Oj2/2lo6ZPGE+3poq9LZnK3Fg dKD6SVuDeMWPRE67q7oF3XXgtySwF4mTKcfoYMwGS7LffO6QQvGPt1fBiNoXZq43Ff+P AFEJ6CUT5lopOAhWo3nvOwJyGNZP0jHHpIlstSvRABKJ7gVNVQdJwUErTNSelPfQw1+O 4ptSQznuCPTyRbFAWcFH8Mi2tdmue/t12c3vCLhOQ0P19pYPtJ0XSQfTcZqUcr3+dmdu a+kZ9ZaXS/+Gbbv0wCQEfw58Q/hKbyO1qr9gsXXW+nnILKiKeRJpD8W+2l3XKwrP9phT b7GQ== X-Gm-Message-State: AOJu0YzMadTQIBirPEilEXpjvNwmtDcz3rOUBEpey1v9RhUNVkcwanbs Tu67ngw+e3hx0KxToMxIQ1KN7aCyoSzOPiYdkh0sFXcrQigTx33dYsE9/RVrDQ== X-Gm-Gg: ASbGncuCHlVJdEdn1fHQusealwrxw7TAZuoVi/FfDOUqecT3Fa1yDggv0xQbqOJb7TM VsfkRhtjBbowF5jICItPHewvrbywTCcYJWCjWO0LEEwCrXExzip7CkmjL9cJGH/oU1QKy8juL6P 7L9RGWLw6Ynp6NEckEOiHwQkTtcOzFCGK+EUsvlbOyxdfxmUW9oaAhMqW6N90rVHfHkQRSeD7OW ZCMiH3U8xhyTkhci+NkdIS6eNQtcl5Z6IBg/WdToi+If+TQul47nHbbZ10/bf4bKh9pRbgyoNmB dJL+K+jlvCQXWIJPrD814CXJ8M2t6Zed5V8nLo6kJOyPeR1jbRKxfF68FBVF2zeKxNCtTEfxG3M MHRpgWpeDoKVaIA== X-Google-Smtp-Source: AGHT+IE+v0GFcrTRoGcHbWOYiTjc/fX+xApYrhEDIM/vWxMRa5SVHD3Qn+YRYs6riKditbWg67MTtA== X-Received: by 2002:a05:6a00:23d5:b0:76b:dee5:9af4 with SMTP id d2e1a72fcca58-76bec4bddb0mr5992237b3a.13.1754188961847; Sat, 02 Aug 2025 19:42:41 -0700 (PDT) Received: from fedora ([2601:646:8081:3770::e9a2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-76bccfe8f90sm7337260b3a.127.2025.08.02.19.42.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Aug 2025 19:42:41 -0700 (PDT) From: Collin Funk To: control@debbugs.gnu.org Subject: Re: [PATCH] test-canonicalize-lgpl fails with musl libc Date: Sat, 02 Aug 2025 19:42:40 -0700 Message-ID: <87plddjfbz.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) tags 56861 fixed close 56861 4.9 stop Sam's email was correct. Thanks, Collin